Commit Graph

2806 Commits

Author SHA1 Message Date
Justin Newberry c4f322ce2d Linter: remove pylint (#29611)
remove pylint
old-commit-hash: 1ee6ed4b16e2ade0dd887c0687243aee769043e5
2023-08-24 16:30:54 -07:00
Adeeb Shihadeh 61cf541322 Minimal build (#29600)
* add build flag for minimum build

* add minimal build

* update

* fix pj

* bump opendbc

* update subaru
old-commit-hash: 4917e22615adbfcc9b3c3ec89b00d240e0b48883
2023-08-24 14:58:30 -07:00
Shane Smiskol ce1c61d59a car interfaces: long running fuzzy test (#29592)
* draft

* draft 2

* increase deadline and run

* imports

* run -> use
old-commit-hash: 821cfff56d00b61fc3b4fba12bf0830cdb21ed27
2023-08-24 10:45:50 -07:00
Cameron Clough 2b38b62afe add missing openpilot prefix to imports
old-commit-hash: 74b9a6af9e10e97f1686732ab7b6ba0ace597c48
2023-08-24 15:46:56 +01:00
Shane Smiskol 9564eba598 car interface test: pick from possible ECUs (#29593)
pick from possible ecus
old-commit-hash: d58cb9994f678ad8625b5af8fee53ca2edffd334
2023-08-24 05:27:58 -07:00
Shane Smiskol 820ca41f1a car interfaces test: don't sleep (#29589)
don't sleep in test_car_interfaces
old-commit-hash: e38ce6087fe56068de40dbbc57944ddf68b8642c
2023-08-24 04:24:22 -07:00
Shane Smiskol acec4fc22f Subaru: Forester Hybrid 2020 dashcam (#24770)
* Add support for Forester Hybrid 2020

Co-authored-by: martinl <martin@mlp.ee>

* it's a param now

* make it work

* fix

* merge and cleanup

* remove duplicate

* should be forester

* bump submodules

* should be abs

* add missing params

* still need a test route

* still need a test route

* consitent

* here too

* todo

* more

* Update selfdrive/car/tests/routes.py

* clean up

---------

Co-authored-by: martinl <martin@mlp.ee>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 3719be8b76f81068da3aadd5bd0f76e8a4d00396
2023-08-23 21:30:12 -07:00
Irene 1a787910a8 Toyota: add TODO comment for TSS-P BSM (#28396)
* Toyota: enable BSM on C-Hr

* Update selfdrive/car/toyota/carstate.py

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

* remove duplicate block

* Remove useless addition

* make this a comment for now

* remove extra bit

* clean up

* clean up

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: cb342461f03e6ff0e6eccbe5de55796b44e659f1
2023-08-23 20:52:01 -07:00
Adeeb Shihadeh 56facfcc5a Subaru: Crosstrek Hybrid dashcam mode (#25378)
* Subaru: Crosstrek Hybrid support

* hybrid cars in dashcam only

* revert that

* just dashcam

* tah should be abs

* remove unused import

* use the old dbc for now

* hybrid car exceptions in carstate

* need dashstatus until we get a proper cruiseactivated bit

* missing CP

* merge conflicts

* lets be consistent about extend

* cleanup

* fix and comments

* preglobal fix

* and the rest

* and this

* added hybrid to release

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 973d90be779efc0e4a83eeab213c0cc9b4d711ce
2023-08-23 18:50:55 -07:00
Gellis12 e311487192 Add initial fingerprint 2.0 for Nissan Leaf 2018-23 (#29505)
Initial fingerprint 2.0 for Nissan Leaf 2018-23
old-commit-hash: a0f3b830622a2ebee2a718554c542cb208b10acf
2023-08-23 17:46:34 -07:00
Erich Moraga 01a8a30fe8 Toyota: add engine & fwdRadar ECU versions for 2023 Toyota Camry Hybrid (#29508)
`@Varvaras` 2023 Toyota Camry Hybrid  Dongle ID/route 3a47f2dd831feb30|2023-08-20--19-41-21
old-commit-hash: ba1ad422d74622a6e565a1b5bed97cf379173e21
2023-08-23 17:37:38 -07:00
Jason Wen 7b99834975 Hyundai longitudinal (CAN): display AEB indicator on non-FCA cars (#29484)
* Hyundai longitudinal (CAN): display AEB indicator on dashboard on non-FCA cars

* clear up comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3b01d99d3001034890f17aaf3834c92e7e689661
2023-08-23 15:22:52 -07:00
Shane Smiskol 7ecfda8b79 Revert "FW query: query one sub-address in parallel" (#29550)
Revert "FW query: query one sub-address in parallel (#28675)"

This reverts commit 3d4c32284699dfd4f78bb2f5bb645344c98f1b46.
old-commit-hash: 365bdd342200b5348370de418a652301da2e3949
2023-08-23 01:41:28 -07:00
Shane Smiskol c5099d5000 FW query: query one sub-address in parallel (#28675)
* put one subaddr in parallel_addrs

* p

* remove print

* update test refs

* test

* revert test changes

* do same in present ECU query, lower threshold to catch (~0.82 to ~0.72 right within bounds)

* type

* clean up

* update test ref
old-commit-hash: 861ceb2feeb8e9f303b96c0e7a9ef19c5423938d
2023-08-23 01:31:04 -07:00
Shane Smiskol c9ca332b3f Update FW query total time
old-commit-hash: 1ea310b202ecedfad67831cca189970944977145
2023-08-22 23:58:29 -07:00
Shane Smiskol 4699eed8f3 FW Query: test noOBD queries on aux panda (#29547)
* huh, this test just works!

* fix

* Update selfdrive/car/tests/test_fw_fingerprint.py
old-commit-hash: 7de9842245dfb506ec340290469d7412989e2233
2023-08-22 23:43:52 -07:00
Shane Smiskol 3527b47f6d Toyota: prepare to disable radar (#29542)
* try to disable radar

* fix bug and bump panda

* prep

* always attempt longitudinal for testers

* fix rav4

* send ACC_HUD

* bump panda

* revert

* check for failure to disable

* fix arg

* bump to master

* revert to master

* comments only

* correct check

* carcontroller

* something like this

* or this

* use flag

* send PCS HUD

* clean up

* carstate checks

* fix from test models

* consistent
old-commit-hash: 0aa6e2ce41113a8f129ab88762037254f2951f91
2023-08-22 21:17:30 -07:00
Shane Smiskol 5949a8d3c6 Toyota: remove redundant car set union (#29546)
remove confusing union
old-commit-hash: 16a8c9fbf13bf6a61f5704d5a2885b09ce4a8f80
2023-08-22 21:09:33 -07:00
Shane Smiskol ada18f0da7 Revert "Toyota: prepare to disable radar (#29541)"
This reverts commit 2d56016f4c25f7672ff770958ea65c6bc023e387.

old-commit-hash: cb368163158fe8133b317273f99f011ce1fa2288
2023-08-22 19:50:24 -07:00
Shane Smiskol 1acbc2c55a Toyota: prepare to disable radar (#29541)
* try to disable radar

* fix bug and bump panda

* prep

* always attempt longitudinal for testers

* fix rav4

* send ACC_HUD

* bump panda

* revert

* check for failure to disable

* fix arg

* bump to master

* revert to master

* comments only
old-commit-hash: 61653bf343bc189d9231234a5b95777998096fa6
2023-08-22 17:16:38 -07:00
Vivek Aithal ab4788cb3b CHEVROLET SILVERADO 1500 2020: Make Silverado lateral tune non-linear (#29540)
add nonlinear values to silverado
old-commit-hash: 2fe3231b49ea8cd82dd270682a4641ffd016d73a
2023-08-22 16:11:21 -07:00
Shane Smiskol 03f174cd66 Hyundai: remove Ioniq EV 2022 from legacy safety mode (#29531)
* fw

* remove from legacy

* update docs
old-commit-hash: 2c835b81d9b206c04b23498c32bece1c8dbfaa52
2023-08-22 12:59:56 -07:00
Shane Smiskol 350461b680 Kia: move Optima Gen 4 FL out of legacy safety mode (#29530)
move Optima Gen 4 Facelift out of legacy
old-commit-hash: f546e9277466d298b1b3c62e70de9cbe002fa5d6
2023-08-22 12:41:52 -07:00
Cameron Clough a49d2d2619 Ford: test FW query config and versions (#29016)
* Ford: test FW query config and versions

* comments about software p/n

* should keep it in bytes

* don't need car_model

* it prints nicely

* add todo

* Update selfdrive/car/ford/tests/test_ford.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 92a7d702fcc8fd5188918871ed44fa0d4cb7d28f
2023-08-21 23:29:15 -07:00
Felixowns 04fdd1a147 Remove Sonata LF from LEGACY_SAFETY_MODE_CAR (#29521)
* Update values.py

remove sonata_lf from legacy safety mode. added sonata_lf to unsupported longitudinal car

* Update selfdrive/car/hyundai/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 0c4b91975b113dbf06203d5ee4537a713d19e5fa
2023-08-21 21:28:13 -07:00
Shane Smiskol f6fd240e95 Revert "Subaru: always show LKAS active (#27945)" (#29515)
This reverts commit a81e7c635e8c52e84f7da2f3e35b0f5ba86c3e3c.
old-commit-hash: b373e5d5ec8ad108925bc4f7aece5977dd405f97
2023-08-21 16:25:13 -07:00
Justin Newberry bb3a0f883b Subaru: longitudinal incorrect "inactive" rpm (#29496)
* fix incorrect base rpm issue

* "min" name is better
old-commit-hash: b20eba5f1d28ae623eecf5dbbc22f67ff02d3609
2023-08-21 14:54:42 -07:00
Jason Wen c322a93e1b HKG: Car Port for Kia Sorento Hybrid 2023 (#29322)
* HKG: Car Port for Kia Sorento Hybrid 2023

* Update CARS.md

* Oops

* add test route

* specify segment

* all packages

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: bfa714ef3b4a9cf00b79965bfb0f149b090008ef
2023-08-21 14:34:53 -07:00
Shane Smiskol 804cebf327 add enhancement todo for hyundai fuzzy FP
old-commit-hash: de7bcb04fccaf41b3149e26d353a18598d1030d0
2023-08-21 14:32:56 -07:00
Shane Smiskol 8ba8ffdef4 Kia: update supported Sorento PHEV package (#29509)
* Sorento PHEV includes all

* update docs
old-commit-hash: 229c43a80838a80fb5a7c4c6fc7b968ba04d70cc
2023-08-21 14:11:32 -07:00
Justin Newberry 8abf2d1637 Subaru: remove unused backoff rate calculation (#29368)
* cancel rate

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* leave it as it was for now

* cleanup

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fc9a623d69919897c3e070ed11309c92651611a8
2023-08-21 13:31:57 -07:00
Caleb Stultz 7681ae50af Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR (#29502)
* Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR

* Update values.py

* Added Kia Sorento to UNSUPPORTED_LONGITUDINAL_CAR
old-commit-hash: 551b0cc8f20794362ce66ecee0afb7cbcf4f97b1
2023-08-21 10:43:31 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Shane Smiskol 5ab3d6403b Nissan: add alt request for engine on Rogue (#29477)
* get engine

* \xda should work

* fix issue

* Update selfdrive/car/nissan/values.py

* bump ref

* other ref
old-commit-hash: ac07c205ed70745da1400b69afb38c5ee81d1241
2023-08-18 23:47:58 -07:00
Jason Wen 41c8ddebf3 Hyundai longitudinal (CAN): don't send FCA11 on non-FCA cars (#28479)
* Hyundai longitudinal (CAN): don't send FCA messages to non-FCA cars

* Update comments

* outside

* change to FCA11 only

* move down

* add todos

* Apply suggestions from code review

* add todo

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2bd4e71b243e8c07a8698ae91174cf269983a20b
2023-08-18 23:38:36 -07:00
Shane Smiskol 1a2818d775 Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)" (#29474)
* Revert "static analysis fixes"

This reverts commit 2271d0adf9a02aee1359717c47cb6280893a6b9b.

* Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)"

This reverts commit 6757e90415766e84ad1b6c921a2edb29ceb3bbbe.

* update refs
old-commit-hash: 1a08c2986e5600dd4e84bfeaed26c74e679085de
2023-08-18 22:56:43 -07:00
Shane Smiskol 559c626fd1 add Kia Niro Hybrid 2019 to legacy safety mode list (#29472)
* add Kia Niro Hybrid 2019 to legacy safety mode list

* list

* test

* update docs

* space
old-commit-hash: 38f15237420e911294ff12f541529d21242e51aa
2023-08-18 20:57:42 -07:00
Shane Smiskol 43e1679da2 CAN fingerprint: timing test (#29461)
* test fingerprint frames (timing)

* guess not needed

* it checks both buses

* use case list

* this is safe since we call current test only in the current loop, never after

* prof

* test this too
old-commit-hash: 6253dca9eb2e936c5828de5cf96e6c988d1349a7
2023-08-18 14:33:13 -07:00
Terry Huang 169da0c3e7 Ford: Kuga 2022 fingerprint (#29449)
Ford: Kuga 2022 fingerprint
old-commit-hash: 0c50dd9d0fb1d6cec9c40a552d91c43b406bafd5
2023-08-18 13:11:50 +01:00
Shane Smiskol 81e7f53ccb CAN fingerprint: test fingerprint response (#29462)
* test finger

* split up
old-commit-hash: 19767da6688f0f9ae1b91f332a78d76af2745811
2023-08-18 00:37:32 -07:00
Jason Young ac83f87b36 interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f76ffbdbbcef50ba201edc0349f777e4e372b515
2023-08-17 21:06:07 -07:00
Shane Smiskol 183515c04b Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
old-commit-hash: 8dcd108972b7a434d91dd00686de669236edf148
2023-08-17 21:02:09 -07:00
Shane Smiskol 98b3087fbb test_models: remove body standstill exception (#29453)
* remove body exception

* bump to master
old-commit-hash: 3563292e6538a9aaf98800e28f9a6557994d8968
2023-08-17 16:26:30 -07:00
Shane Smiskol c817cb942d CAN fingerprinting test (#29427)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models

* test can fingerprinting

* so much simpler!

* fix dict resizing

* simplify

* need to do this

* fix

* move to new file

* rename

* comment

* ignore function-uses-loop-variable
old-commit-hash: fd8f8d8785dd07777f150bd61c7ba9a0ed00d786
2023-08-17 00:57:12 -07:00
Shane Smiskol d87466556c Hyundai: match panda standstill check (#29442)
* bump panda

* clean up

* common?

* Revert "common?" (not now)

This reverts commit 197af7cdbb6a8c8e58fcbccca94f7db004ce91e4.

* fix

* no failures!

* remove time

* bump

* bump

* undo
old-commit-hash: 9d0d59ac9b40dabeb5984afc301917242da2515a
2023-08-17 00:06:38 -07:00
Shane Smiskol 2d42b7bd1d fingerprints: prevent global from changing (#29438)
prevent _FINGERPRINTS from changing
old-commit-hash: 25ac9e214880ca846a209ce35d8d4245bf391d08
2023-08-16 19:52:41 -07:00
Justin Newberry 7faefd677b Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
old-commit-hash: d6c682b40168241e481aa2904198ac29c8d1a73e
2023-08-16 12:58:09 -07:00
Shane Smiskol 3fd62cfe23 car_helpers: common CAN fingerprint function (#29417)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models
old-commit-hash: b9e36b7faae1ad2a9ff78c72f5169a99f94ca82c
2023-08-16 03:28:50 -07:00
Shane Smiskol dc6af2820a test_models: check panda cruise state (#29423)
* cruise state test

* add todo

* rename

* clean up

* remove
old-commit-hash: 2d636deb4eabf54044b086d87305fc898f833711
2023-08-15 23:55:53 -07:00
Shane Smiskol 2fc1ed6d5d test_models: add full internal segment list (#29425)
full internal test models seg list

remove avalon and sienna

volt with ascm on

another volt with ascm on

9bc2ee633c361c3d|2023-07-28--20-17-51--2

dashcam mode

c4e21532b6fe3847|2023-07-05--08-34-05--1

can invalid (missing PSCMStatus)

cf6ba99592c48848|2023-07-01--11-36-56--20
old-commit-hash: 4073ffb02bb84fe5e877a1708185c00ff1a35ac2
2023-08-15 23:33:52 -07:00