715f028a0e
Ruff: enable flake8-builtins ( #29315 )
...
* enable flake8-builtins
* replace any with contains
* fix typo in pack
* fix type
* format is from the parent module, has to be enabled
* item_id
* fix item_id
* disable for id since that's what the remote server returns
old-commit-hash: 8793cbff40662a92bff16d75b51479c80517305a
2023-08-10 18:58:22 -07:00
3ee0786de3
CI: Pylint to ruff ( #29294 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
* set line length
* pylint exclusions to ruff
* same excludes as old linter
* fix tools QA
* remove unrequired check
* revert linting third_party
* ignore e402
old-commit-hash: 7fdd9fc37c1c5febf1cd3dc86441ebf0dec7f370
2023-08-09 13:26:54 -07:00
ff96892511
Revert "CI: pylint to ruff ( #29276 )" ( #29284 )
...
This reverts commit ffad7279cbad3c4f2ea786287b4624d3a3aa18d7.
old-commit-hash: a91764954b0c9bfe5ccfc8e64321af6bb6c56536
2023-08-08 14:24:04 -07:00
99006365a3
CI: pylint to ruff ( #29276 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
old-commit-hash: cb31a53d8a93cf6cb1f8bd2fff1431716b3a47e4
2023-08-08 13:41:30 -07:00
8bcaf1f942
increase min duration of steer saturated alert ( #29191 )
...
* increase min duration of steer saturated alert
* update refs
old-commit-hash: 347620556946eb365dc61363079655ae5a4a891d
2023-07-31 12:48:11 -07:00
3ebff5c415
Events: debug script ( #28898 )
...
* Move to separate branch
* Fix mypy
* Better printout
* Fix spacing
* cleanup
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 22c413af6de56450cad3db4a978527549a924eaa
2023-07-16 16:59:27 -07:00
27b53b914b
reduce startup alert duration ( #28749 )
...
* reduce startup alert duration
* update refs
old-commit-hash: 336b5f732490b0f9ad5b3276a22c1629934e25c0
2023-06-29 17:57:25 -07:00
8bb530cec5
Deprecate brakeUnavailable event ( #28351 )
...
* bump cereal
* deprecate
* Update selfdrive/controls/lib/events.py
old-commit-hash: fc2bd16e72a89feb270f99468cfd8d14ccbab4fd
2023-05-31 16:29:11 -07:00
5ddceb553d
Calibrationd: make recalibrating alert ( #28149 )
...
* Initial
* fixes
* not an int anymore
* elif
* revert ref
* update ref
* fix alert text
* regen refs
* update ref
* add recalibration unit test
* set into recalibration state
* fix words
* recalib
* text
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 598343aad18a7896c6b65ff6e19f9e27ba19cc10
2023-05-15 09:29:57 -07:00
298e7466f5
Ford: hybrids are unsupported ( #28171 )
...
* hybrid fords are dashcammed
* something like this?
* just do an alert
* good comment
* space
* bb
bb
* top
* Update selfdrive/car/ford/interface.py
* add a noEntry
* remove from release notes
* sad :(
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com >
old-commit-hash: 344064d6bd45b6d0f54e1eedfc73b87a856efe3e
2023-05-11 23:35:07 -07:00
da12bfb021
Ford: add alert for steering wheel angle not ready ( #28140 )
...
* add event for steering angle calibrating
* how about this
how about this
* rename
* more openpilot-y
* add comment to code
* move to top
* better wording
* more general
* fix
* ?
* above
* bump cereal to master
* add more comms
old-commit-hash: fb29d0f3bfe69c83f73e3af09235bd4c8287aaac
2023-05-08 22:03:30 -07:00
73e00a05ac
Calibration remount detector: soft disable ( #27993 )
...
* Calibration remount detector: soft disable
* Update test_calibrationd.py
old-commit-hash: a979a54cf9ce02610cc0999a52a9fbed2f7d4cbb
2023-04-22 00:27:20 +00:00
6433154d5d
remove accFaultedTemp, add steerTimeLimit ( #27720 )
...
* remove accFaultedTemp
* retry CI
* bump cereal
* grab the new steerTimeLimit Event
* bump cereal to updated master
old-commit-hash: 267974e00200324805c76ef2e8ae279efa7757a1
2023-03-28 16:04:14 -07:00
70cfe29351
better main off alert ( #27442 )
...
old-commit-hash: 7a3b3e8b567ea476088e6f3d7344c7220e35e398
2023-02-23 15:01:10 -08:00
0a1ee30b15
add 'remount device' to permanent calibration invalid alert ( #27407 )
...
old-commit-hash: ea419c5764739555673d5545f16cff7c05f9e6c0
2023-02-20 16:29:17 -08:00
37a1a0bc2c
better min enable speed alert ( #27317 )
...
old-commit-hash: 5af5f02ba82a0094c7f721ad8dd6138f503455d8
2023-02-14 13:29:23 -08:00
47197d7009
events: reword ESP off alert ( #27304 )
...
* Rename event
* rename to Control
* rename to disabled
old-commit-hash: 4f2134468f2b2b94daa24d9ba80cc70da0ad8224
2023-02-10 23:46:48 -08:00
bbed3a961a
Events: actionable accFaulted alert text ( #26783 )
...
same alert text as steer and brake unavailable
old-commit-hash: 9e9600a4f4fb69dd99cc24b791ccdd62540348f1
2022-12-13 00:16:36 -08:00
e13e373bfb
alert: smaller standstill alert ( #26751 )
...
smaller standstill alert
old-commit-hash: 2545dd195efc164da9561ae9ae2115482eb9f931
2022-12-09 23:30:41 -08:00
634a6c9802
Deprecate noTarget event ( #26638 )
...
deprecate notarget
old-commit-hash: 5409895ab2668284df7b688ce513fa0ef1e57be2
2022-11-30 02:32:47 -08:00
d1dee4625a
controlsd: preEnable on brake at a standstill ( #26273 )
...
* pre-enable on brake at standstill
* test by getting rid of noTarget
* Update events.py
* rename
* stash what we got so far
* cmt
* not sure if best way to fix, but enabled with current states defs is fine
* no noEntry in preEnabled
* bumpcereal
* uncomment
* Update ref_commit
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: dbe512d167a51f02fe276e17a8794de2137d0e14
2022-11-29 17:34:10 -08:00
bcdbd8edb9
Toyota: alert when in standstill ( #26585 )
...
* add resume required alert
* possibly need this (pressing resume with brake held does nothing)
* better text (has both meanings)
* try this
* Revert "try this"
This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.
* no alert with interceptor
* check long
old-commit-hash: 3253b8590002fa5f56e003add3f5f47a21870873
2022-11-25 16:00:58 -08:00
7c96e7876a
cleanup panda types everywhere ( #26574 )
...
* cleanup panda types everywhere
* one more
old-commit-hash: 65fa87a96965000986e76604ac868891e35a86bc
2022-11-21 23:43:24 -08:00
054cb1f8c1
Hyundai: fix button enable controls mismatch ( #26471 )
...
* bump panda
* buttonCancel needs to be a noEntry
* bompo
* Update ref_commit
old-commit-hash: 89b88fc7a23c393b1d74c5c74aacd5c4ee254d81
2022-11-11 14:49:38 -08:00
70249fae14
Rename gmAccFaultedTemp -> accFaultedTemp
...
old-commit-hash: b1efdab788da77380dfd3f5765bb6cc03ccc3a77
2022-10-19 01:31:12 -07:00
961c613005
GM camera ACC: prevent fault when engaging at a stop ( #26079 )
...
* prevent bolt fault
* comment
* only for camera ACC
* fixup alert
* bump cereal to master
* use new name
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* only care about prevent engagement when we look at PCM
old-commit-hash: 4e82f68de2641e628f0df1aa82e5a5e935c8cce6
2022-10-14 22:21:53 -07:00
c1b9a202aa
controls: enter overriding state for steering override ( #25617 )
...
* lateral overriding is overriding
* Update test
* remove
* also could do something like this and only have one OVERRIDE ET
* Revert "also could do something like this and only have one OVERRIDE ET"
This reverts commit 5c381641c08961676a56a9718fbdaa84989ac249.
* full names
* bump cereal
* test every event type
* update refs
old-commit-hash: 992707c1724ab0047ddd6e230b82e47ae51b25ed
2022-09-13 23:20:45 -07:00
2bd8ee0974
controls: block resume if cruise not previously engaged ( #25402 )
...
* see if this works at all
* can revert this
* think adding a no entry conditionally is nicer
* then we can revert this
* 0 makes more sense
* Revert "0 makes more sense"
This reverts commit efc89e8a2389ef58fbc0cec0a2872d24db524867.
* gm CC uses > 70
* bump cereal
* comment
* test on Honda
* whoops
* works
* add exception with todo
* moved button enable events to controlsd
* get rid of that
get rid of that
* different values for now
* car interfaces add enable event, controlsd can block it
* Regen and update refs
* delete if not set
* One place
one place
* regen routes are uninitialized first few frames
* Trim start of segment so it's like original segment
* stash
* regen
* not working
* clean up
* more cleanup
* revert
* bump ceral
* actually check resume button
* whoops
* pcmCruise cars don't use setSpeed, so we're good
* engage correctly in sim
* Update ref_commit
* Update refs
old-commit-hash: 5ed587ebeff24bacf70c44879616c51756730bba
2022-08-17 18:03:33 -07:00
283970114e
Sensor Invalid Alert ( #25303 )
...
* modify text, add soft disable
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: f1fecc3da7299a45f1f4728c48ff33b225d43eb1
2022-07-28 18:52:10 -07:00
2ca2152573
less beeps for steering override faults ( #25196 )
...
* less beeps for steering override faults
* less repeat
old-commit-hash: 278d6893fe2a4a2da84feb6b7aaf50190be36146
2022-07-20 19:36:22 -07:00
297a0bd65b
controlsd: avoid lag on first iteration due to get_short_branch ( #25031 )
...
* controlsd: avoid lag on first iteration due to get_short_branch
* always cache
old-commit-hash: d4cc13c88a8a9a9215777709fe2eccade1fd0ccd
2022-07-04 17:13:30 +02:00
3c48bc47b7
Move a bunch of stuff to system/ part 3 ( #24829 )
...
* move swaglog.py
* timezoned
* logmessaged
* version.py
* fix linter
old-commit-hash: 0fce5d90459b77bf2cfa70f55f322f0e1fb8d01c
2022-06-11 23:19:27 -07:00
753045c73d
less TICI when not needed ( #24698 )
...
* less TICI when not needed
* fix process replay
* move reading voltages into hw abstraction layer
* Update selfdrive/hardware/tici/hardware.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/hardware/hw.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/hardware/base.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* rename init function
* Update selfdrive/athena/athenad.py
Co-authored-by: Robbe Derks <robbe.derks@gmail.com >
* Update selfdrive/boardd/boardd.cc
* Apply suggestions from code review
* Update selfdrive/thermald/thermald.py
* update ref
* fix alert width if all cameras are bad
* add ecam to test_loggerd
* bump cereal
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
Co-authored-by: Robbe Derks <robbe.derks@gmail.com >
old-commit-hash: f49a9c9fd2100a4f1401a93d88064ddbbbd935c1
2022-06-02 15:20:51 +02:00
29e2b3f757
controlsd: ensure all system malfunction events have the right types ( #24635 )
...
old-commit-hash: 71901c94dbbaa2f9f156a80c14cc7ea65219fc7c
2022-05-23 17:46:46 -07:00
a6bcd14abd
show which cameras are malfunctioning ( #24558 )
...
old-commit-hash: 0b1f6e3620793a0a06708464387613cec2937591
2022-05-16 22:01:04 -07:00
cfc16a88c5
improved alert verbosity ( #24434 )
...
* improved alert verbosity
* better testing script
* better description
* speed diff
* touch ups
* fix that
old-commit-hash: b1858df00e40f96832f812cb5b42596b8f522ab7
2022-05-16 21:19:38 -07:00
19aebce4f2
Round system overheated temperature ( #24544 )
...
* Update events.py
* Apply suggestions from code review
Co-authored-by: Willem Melching <willem.melching@gmail.com >
old-commit-hash: 961a121fde36fca88834e732fc50b34fbd82e94b
2022-05-16 18:08:02 +02:00
b9a07b8f05
Round model lagging frame drop percentage ( #24549 )
...
alerts: round model frame drop percentage
old-commit-hash: 076f0acd5fcd5bca59d9403232c3e37e86db19d1
2022-05-16 16:26:18 +02:00
2dfba97175
add mypy check for return-any ( #24379 )
...
* add mypy check for return-any
* remove unused import
* typing
* remove unnecessary variable typing
* cleanup
* cleanup
* bump submodules
* small fixes
* only a problem on mac
Co-authored-by: Willem Melching <willem.melching@gmail.com >
old-commit-hash: d2eef1955c777ef6110c7a74d2a9ca9e4e1d958c
2022-05-12 14:59:00 +02:00
fdf13d565b
controlsd: add lagging alert ( #24360 )
...
* controlsd: add lagging alert
* move those
* just this for now
* no camera malfunction
old-commit-hash: 3abbe827deac4954a2af97a191171c8b7d08d0c1
2022-04-28 19:51:42 -07:00
75174c93d7
more verbose debug alerts ( #24126 )
...
old-commit-hash: 70987fd9d971ffd1a60b9c97835c838de21a764b
2022-04-22 16:12:54 -07:00
e8ad31f32b
controlsd: handle controls mismatch race ( #24245 )
...
* controlsd: handle controls mismatch race
* update refs
old-commit-hash: 233a167cc901afcf0a0abf48fad8516609d19c99
2022-04-18 17:08:25 -07:00
598ba913ae
Fix camera error description ( #24202 )
...
* Fix camera error message
* Shorter
old-commit-hash: e0845752e3a1ac4a0fd47ac4e0400f3528f213fa
2022-04-13 09:56:37 -07:00
3789587df1
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
old-commit-hash: 49c2164814e07c1243ef2b979957760d64c9eb35
2022-04-12 22:58:34 -07:00
e04e6fea87
bump cereal
...
old-commit-hash: 162e47456cf88dab27db8f86474b0d41a52c03e5
2022-04-06 22:25:59 -07:00
83c103e46a
update camera CRC alert text ( #24156 )
...
old-commit-hash: fb344021aa2e69408b32f7878f1c705691640330
2022-04-06 17:46:56 -07:00
a47666d1fd
add cameraFrameRate alert ( #24152 )
...
* add cameraFrameRate alert
* bump cereal
old-commit-hash: 1848050fd980a04dfc70454547ab7b52affe2917
2022-04-06 17:11:39 -07:00
871ecc451b
commIssueAvgFreq: separate alert for avg freq check ( #24150 )
...
* commIssueAvgFreq: separate alert for avg freq check
* bump cereal
* bump cereal
* bump cereal
* freq_ok separate from alive
* bump cereal to master
* update_ref
* fix profiler
old-commit-hash: eaa581921161b2643b10ad72da0708dff14367aa
2022-04-06 16:43:32 -07:00
d359310631
alerts: Don't use Malfunction twice
...
old-commit-hash: 8031a68e55b42d1a80303f00a3aecd646e3c2359
2022-04-04 12:45:57 -07:00
01d005c322
update refs
...
old-commit-hash: a4353303d4f7a1faef88918dc83a2f08d412460d
2022-04-01 22:39:08 -07:00
Justin Newberry