Commit Graph

377 Commits

Author SHA1 Message Date
ShaneSmiskol 23ea456f4f Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
old-commit-hash: ae77f693a26527ffbee044f852cc4185718c2433
2021-06-11 14:33:17 -07:00
Dean Lee 147b355dde add space after function name and if statement (#21225)
old-commit-hash: e4e669bb0fc1a919dfb38800099f8e3ad52346f1
2021-06-11 10:17:52 +02:00
Willem Melching eb0fdfecf1 Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: ec17fad41a851369383173530bdaa3dfbfc1c671
2021-06-09 10:58:01 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh c2875eea66 fix mpc compilation (#21178)
old-commit-hash: 524aa55b93dbe883c8bdd69f5ca04f5a41e47386
2021-06-07 15:01:29 -07:00
Adeeb Shihadeh 5dfc430d47 startup alert for no fw returned (#21177)
old-commit-hash: d4ab1f1e274bc5e36b47fb9e6f76a977e04d1f1a
2021-06-07 14:15:09 -07:00
speedking456 2bcc0c0ada Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
old-commit-hash: 24b6b4a341bbd02551756b3e0fd5ba2120e66eef
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh e7cb6f6512 bump cereal
old-commit-hash: f2a9b134980e5ef7af86da71a13f01f2b23d017f
2021-06-04 16:06:57 -07:00
Willem Melching 51eb52fec4 Determine lane chane direction in preLaneChange state (#21119)
* Determine lane chane direction in preLaneChange state

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: de34d1a527799acd8dde755bdb6dba2d0625b096
2021-06-04 10:03:13 +02:00
HaraldSchafer f0f36a0a06 Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
old-commit-hash: 1c926d23da0c73ceb246ca6d61db6ed1c48a1ab9
2021-06-03 09:26:53 -07:00
Adeeb Shihadeh d9026b7660 fix camera error indices
old-commit-hash: 6fa573a2d6e64cd37afd6218e6676acbe625a4c1
2021-06-01 16:56:33 -07:00
Jafar Al-Gharaibeh f108d93bc0 Mazda FP 2.0 support (#20879)
* Mazda FP 2.0 support

ECU FW for CX-5 2017 and Mazda3 2017

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use standard UDS request/reponse, fix missing arg.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add CX-5 FW test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update/add FW FP

Current suported models:
  CX-5 2017/2021
  CX-9 2019/2020
  Mazda3 2017/2018

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add Cx-9 2019 FW FP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Remove comments, remove TESTER_PRESENT_REQUEST from Mazda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* add transmission ecu to startup test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 824f93303d95695a761d10a00b0e9547274db6a9
2021-05-28 15:50:58 +02:00
Adeeb Shihadeh bf9f1f3871 fix low memory on tici
old-commit-hash: e1d7a1af10c1a4a5efe2fe6f278f2af0dbc25718
2021-05-26 19:47:10 -07:00
Adeeb Shihadeh bb70ddcbfe Move CAN fingerprinting behind community features (#20993)
* Move CAN fingerprinting behind community features

* fix typo

* fix startup test

* fix
old-commit-hash: 726fb9d50135d2469fe87ff50d0540965955e37f
2021-05-24 19:21:58 -07:00
HaraldSchafer 5c5dfe5415 Safe interpolation in lane_planner (#20995)
* safe idxs

* make thread more safe
old-commit-hash: d6fcf6fa84bf897f4a2be7eff6a95d5431aa4853
2021-05-21 16:34:17 -07:00
Adeeb Shihadeh 41f8f5c7ce per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
old-commit-hash: 12ed986333856086c774b3142659dfbaecdf654b
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh d7a2931a1f stricter memory usage check (#20985)
old-commit-hash: c04b47938d34e8f320e6483a47509ca5d7ff9d1b
2021-05-21 11:25:11 +02:00
Adeeb Shihadeh a4550fec27 show alert for rest of drive
old-commit-hash: fa1df5f78395677451d6244d33b786ca74a2fe37
2021-05-20 20:03:39 -07:00
Mitchell Goff 78927e4ebb New model outputs (#20933)
* New model: 51a237cd-9c43-4281-9072-802325e6744d/950

* Added new meta outputs and proper interp for plan_t_arr

* Added meta-based trigger for FCW

* No nans in planner, separate alert for model FCW

* Cleaned up plan_t interp logic

* Added empty cameraError alert to fix unit tests

* Use the normal FCW event

* Updated filter logic

* Updated model replay ref

* Moved disengage predictions into their own cereal struct

* Updated model replay ref for new cereal structs

* Apparently this breaks stuff?

* Bumped cereal commit and model replay ref
old-commit-hash: 29cc3500a5161b4d2245b8d041f190533be4ee8e
2021-05-19 22:30:23 -07:00
Adeeb Shihadeh 340a080c3b alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2defc730db18f7f9c0b08b0c8b0f6806cc513ac4
2021-05-19 21:28:16 -07:00
Adeeb Shihadeh 16c7107d65 fingerprint cloudlog event (#20950)
* fingerprint cloudlog event

* kale cloudlog

* not fuzzy
old-commit-hash: f08e01c97fa884e99be6a90937d4cdee6f545198
2021-05-18 10:52:53 -07:00
Adeeb Shihadeh 29a2bef998 offroad alert for missing nvme (#20931)
* offroad alert for missing nvme

* remove that

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 313741062ea28a9d0601ff11399d20e9bd1a50bf
2021-05-17 13:35:24 -07:00
Adeeb Shihadeh 3fbeb1299e boardd: set can and pandaState valid flags (#20899)
* boardd: set can and pandaState valid flags

* add event

* bump cereal

* consistency
old-commit-hash: e694f0b4d6f8cfe55e2c8d36a78cf86fe0c86f1a
2021-05-14 21:26:02 -07:00
Adeeb Shihadeh 8002b848b6 offroad alert for unregistered devices (#20870)
* offroad alert for unregistered devices

* update tests

* add param

* fix stretch
old-commit-hash: b93ccc465dbc8b847b65f7d062182465344dac4d
2021-05-11 03:18:45 -07:00
Dean Lee e333e4f189 Cleanup selfdrive/ includes (#20822)
* cleanup include path

* continue

* format includes

* fix testraw.cc

* remove include path from SConstruct

* regroup

* rebase master

* almost done

* apply review

* rename FileReader.xx to filereader.xx

* rename Unlogger.x->unlogger.x

* rename FrameReader.xx -> framereader.xx

* apply reviews

* ui.h

* continue

* fix framebuffer.cc build error:mv util.h up

* full path to msm_media_info

* fix qcom2 camerad

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7222d0f20dc8edfe0d2f3417d1ce7c84fbd32805
2021-05-08 22:15:17 -07:00
Willem Melching 523c00acdc Improve community feature alert text (#20803)
old-commit-hash: b38e57eb2b1c5b6b438fb238b1752f40b4a9e188
2021-05-03 11:59:01 +02:00
Adeeb Shihadeh ec7913cbe5 delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f9a961f6fb69f36f8a113246920b2d71e6af8ae1
2021-04-30 13:55:17 -07:00
Willem Melching 002057e1f1 Fix ability to change lane change direction while in progress (#20765)
old-commit-hash: a57f10c202fe7dc63023d45ef612c4ec849882ab
2021-04-29 13:03:16 -07:00
qadmus 99d3a5e553 ignore_avg_freq of longitudinalPlan, which is triggered by radarState (#20743)
old-commit-hash: 0d10f9c4ad0e11ecd25e0c29355e1c825333f740
2021-04-29 11:06:44 -07:00
Willem Melching 5ec437bb6e Ignore radarState average frequency
old-commit-hash: 64d2ec38f290f7146af4196d240fb70cc11653b0
2021-04-21 10:59:26 +02:00
Adeeb Shihadeh cc29fdfed2 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
old-commit-hash: 836668f1050e1dbc185af7d472e2016627711aeb
2021-04-20 21:01:28 -07:00
Adeeb Shihadeh 6d28491dbf Toyota: use FW query for DSU detection (#20615)
* Toyota: use FW query for DSU detection

* make sure we have at least some fw responses

* bool

* add test to test_startup

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a19d94ae2d21c9df39c42a60431f8d4f6d228706
2021-04-20 14:32:34 +02:00
Willem Melching ee0e80a6d4 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
old-commit-hash: e4f73fbda5c2dd07cbb15816ac1bf30b010408fe
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh 07ba5a7fe9 show gps alert when lte's enabled
old-commit-hash: 3fa86657cbdc9ecc202a6ad8b4bce1276021f603
2021-04-15 22:12:16 -07:00
Adeeb Shihadeh 31d818b39a tici: offline big cluster while offroad (#20668)
* tici: offline big cluster while offroad

* shuffling

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 9edda6fbc1e4030e2e86ec7041d81c39cd27c8a0
2021-04-12 23:06:24 -07:00
Willem Melching 811746959e tici: move real-time processes to high-performance cores (#20634)
old-commit-hash: 8ede1b30aab2a4bfb628aef6a24714865388f1fa
2021-04-09 13:41:43 +02:00
Willem Melching 80b4e6ce09 plannerd: use get_bool to read param
old-commit-hash: 44c395165b750a80334077b387b5dc221789b2ad
2021-04-09 10:32:31 +02:00
HaraldSchafer 3833a80305 MPC retune for laneless fix (#20616)
* was making wrong policy more aggresive

* allow to be set from simulator

* update refs

* put params together
old-commit-hash: 0e10b74a61a8e06e7a27b414b21bfe85be827698
2021-04-08 12:56:47 -07:00
Willem Melching 99a8e9222e Add list for average frequency ignore (#20624)
* add list for averge frequency ignore

* typo
old-commit-hash: c1075037ba3cbef9814e3bc2930e5c6eea6c46ed
2021-04-08 18:04:16 +02:00
Adeeb Shihadeh 99b2c0d024 Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
old-commit-hash: 2fa1b2572dfb63e367cfe2868da576090b227ca4
2021-04-07 12:18:58 -07:00
Willem Melching 00b19b6351 ecam toggle (#20597)
* use ecam in ui

* needs reboot

* use in modeld

* typo

* effective FL is longer in center

* normalize zoom by focal dist

* read param before init

* make 2x as wide

* review comments

* more explicit

* fix camera offset

Co-authored-by: ZwX1616 <zwx1616@gmail.com>
old-commit-hash: 1fc7bcca43e9ef75d95ae8689e3b1cd8c4f8041e
2021-04-07 19:12:35 +02:00
Willem Melching 8f4a445171 add putBool/getBool wrappers to cython params class (#20611)
* add putBool/getBool wrappers to cython class

* use new API

* some more puts

* fix mockparams arguments

* add get_bool to MockParams

* typo
old-commit-hash: ae094042ade44815fdba50196c15ba552bbf33d7
2021-04-07 15:36:37 +02:00
Willem Melching d4795ed361 remove ubloxRaw from controlsd SubMaster
old-commit-hash: 0dca8cb7dd2e515beb955ad8cb146f6a5b5f7941
2021-04-07 14:41:38 +02:00
HaraldSchafer 1d36adf351 no heading cost (#20594)
* no heading cost

* live mpc weight config

* need to add stds

* make work on empty data

* no divide by 0

* update refs

* update model replay

* update proc replat

* new model replay ref
old-commit-hash: d72d433ec7a3c9f0bb2f90d196b3826d48d9b1a0
2021-04-06 23:49:29 -07:00
Willem Melching 15c06d1c06 Check average frequency in SubMaster (#20558)
old-commit-hash: 79b5bee9dd4a56b06f02ca22114cc063d606d7c2
2021-04-06 10:09:47 +02:00
Adeeb Shihadeh 7850141e1a lower min lane change speed to 30mph (#20586)
* lower min lane change speed to 30mph

* update refs
old-commit-hash: 2319d726fbc81d949fc7313c7536a7f5e2e7e8c5
2021-04-05 15:38:53 -07:00
Adeeb Shihadeh 092db4eadc show persistent dashcam mode alert (#20483)
* always show dashcam mode alert

* show persistent dashcam mode alert

* lowest

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 367aec54d1c4c5ed8d3f651d0b2f8b80fb0ac0e5
2021-03-25 21:37:38 -07:00
HaraldSchafer eae1fa481c New KL model + laneless toggle (#20454)
* New model: 0bf38240-6b55-42b0-bcfb-da08ff5cd0b9/650

* laneless baby

* hardcode model difference for now

* kale toggle

* kale emoji

* sensible description

* make clear it is not just for ui

* emojis dont work yet

* 9671a8fe-539f-4a04-a163-54571df21139/650

* new model

* only read param on rising edge of ignition

* update toggle text

* fix that

* update refs

Co-authored-by: mitchell <mitchellgoffpc@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7ee79c99236f749d02a6779b006ee1ab187e0612
2021-03-24 01:10:31 -07:00
Adeeb Shihadeh 5cfc42911b Remove lane change toggle and default LDW to off (#20442)
* remove lane change toggle and default LDW to off

* update refs
old-commit-hash: 43ce7165c4eee9af167a650decdb8c3f11195d8d
2021-03-22 20:55:57 -07:00
Erich Moraga 10d1905a24 remove unused line (#20426)
old-commit-hash: 0fc5c868051e17814d68db34fdfe6056fb9a70ce
2021-03-21 17:13:16 -07:00