Commit Graph

169 Commits

Author SHA1 Message Date
Shane Smiskol 9e9600a4f4 Events: actionable accFaulted alert text (#26783)
same alert text as steer and brake unavailable
2022-12-13 00:16:36 -08:00
Shane Smiskol 2545dd195e alert: smaller standstill alert (#26751)
smaller standstill alert
2022-12-09 23:30:41 -08:00
Shane Smiskol 5409895ab2 Deprecate noTarget event (#26638)
deprecate notarget
2022-11-30 02:32:47 -08:00
Shane Smiskol dbe512d167 controlsd: preEnable on brake at a standstill (#26273)
* pre-enable on brake at standstill

* test by getting rid of noTarget

* Update events.py

* rename

* stash what we got so far

* cmt

* not sure if best way to fix, but enabled with current states defs is fine

* no noEntry in preEnabled

* bumpcereal

* uncomment

* Update ref_commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-11-29 17:34:10 -08:00
Shane Smiskol 3253b85900 Toyota: alert when in standstill (#26585)
* add resume required alert

* possibly need this (pressing resume with brake held does nothing)

* better text (has both meanings)

* try this

* Revert "try this"

This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.

* no alert with interceptor

* check long
2022-11-25 16:00:58 -08:00
Adeeb Shihadeh 65fa87a969 cleanup panda types everywhere (#26574)
* cleanup panda types everywhere

* one more
2022-11-21 23:43:24 -08:00
Shane Smiskol 89b88fc7a2 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
2022-11-11 14:49:38 -08:00
Shane Smiskol b1efdab788 Rename gmAccFaultedTemp -> accFaultedTemp 2022-10-19 01:31:12 -07:00
Shane Smiskol 4e82f68de2 GM camera ACC: prevent fault when engaging at a stop (#26079)
* prevent bolt fault

* comment

* only for camera ACC

* fixup alert

* bump cereal to master

* use new name

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* only care about prevent engagement when we look at PCM
2022-10-14 22:21:53 -07:00
Shane Smiskol 992707c172 controls: enter overriding state for steering override (#25617)
* lateral overriding is overriding

* Update test

* remove

* also could do something like this and only have one OVERRIDE ET

* Revert "also could do something like this and only have one OVERRIDE ET"

This reverts commit 5c381641c08961676a56a9718fbdaa84989ac249.

* full names

* bump cereal

* test every event type

* update refs
2022-09-13 23:20:45 -07:00
Shane Smiskol 5ed587ebef controls: block resume if cruise not previously engaged (#25402)
* see if this works at all

* can revert this

* think adding a no entry conditionally is nicer

* then we can revert this

* 0 makes more sense

* Revert "0 makes more sense"

This reverts commit efc89e8a2389ef58fbc0cec0a2872d24db524867.

* gm CC uses > 70

* bump cereal

* comment

* test on Honda

* whoops

* works

* add exception with todo

* moved button enable events to controlsd

* get rid of that

get rid of that

* different values for now

* car interfaces add enable event, controlsd can block it

* Regen and update refs

* delete if not set

* One place

one place

* regen routes are uninitialized first few frames

* Trim start of segment so it's like original segment

* stash

* regen

* not working

* clean up

* more cleanup

* revert

* bump ceral

* actually check resume button

* whoops

* pcmCruise cars don't use setSpeed, so we're good

* engage correctly in sim

* Update ref_commit

* Update refs
2022-08-17 18:03:33 -07:00
Vivek Aithal f1fecc3da7 Sensor Invalid Alert (#25303)
* modify text, add soft disable

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-07-28 18:52:10 -07:00
Adeeb Shihadeh 278d6893fe less beeps for steering override faults (#25196)
* less beeps for steering override faults

* less repeat
2022-07-20 19:36:22 -07:00
Willem Melching d4cc13c88a controlsd: avoid lag on first iteration due to get_short_branch (#25031)
* controlsd: avoid lag on first iteration due to get_short_branch

* always cache
2022-07-04 17:13:30 +02:00
Adeeb Shihadeh 0fce5d9045 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
2022-06-11 23:19:27 -07:00
Willem Melching f49a9c9fd2 less TICI when not needed (#24698)
* less TICI when not needed

* fix process replay

* move reading voltages into hw abstraction layer

* Update selfdrive/hardware/tici/hardware.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/hw.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/base.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* rename init function

* Update selfdrive/athena/athenad.py

Co-authored-by: Robbe Derks <robbe.derks@gmail.com>

* Update selfdrive/boardd/boardd.cc

* Apply suggestions from code review

* Update selfdrive/thermald/thermald.py

* update ref

* fix alert width if all cameras are bad

* add ecam to test_loggerd

* bump cereal

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
2022-06-02 15:20:51 +02:00
Adeeb Shihadeh 71901c94db controlsd: ensure all system malfunction events have the right types (#24635) 2022-05-23 17:46:46 -07:00
Adeeb Shihadeh 0b1f6e3620 show which cameras are malfunctioning (#24558) 2022-05-16 22:01:04 -07:00
Adeeb Shihadeh b1858df00e improved alert verbosity (#24434)
* improved alert verbosity

* better testing script

* better description

* speed diff

* touch ups

* fix that
2022-05-16 21:19:38 -07:00
Shane Smiskol 961a121fde Round system overheated temperature (#24544)
* Update events.py

* Apply suggestions from code review

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-05-16 18:08:02 +02:00
ntegan1 076f0acd5f Round model lagging frame drop percentage (#24549)
alerts: round model frame drop percentage
2022-05-16 16:26:18 +02:00
Dylan Herman d2eef1955c add mypy check for return-any (#24379)
* add mypy check for return-any

* remove unused import

* typing

* remove unnecessary variable typing

* cleanup

* cleanup

* bump submodules

* small fixes

* only a problem on mac

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-05-12 14:59:00 +02:00
Adeeb Shihadeh 3abbe827de controlsd: add lagging alert (#24360)
* controlsd: add lagging alert

* move those

* just this for now

* no camera malfunction
2022-04-28 19:51:42 -07:00
Adeeb Shihadeh 70987fd9d9 more verbose debug alerts (#24126) 2022-04-22 16:12:54 -07:00
Adeeb Shihadeh 233a167cc9 controlsd: handle controls mismatch race (#24245)
* controlsd: handle controls mismatch race

* update refs
2022-04-18 17:08:25 -07:00
Gijs Koning e0845752e3 Fix camera error description (#24202)
* Fix camera error message

* Shorter
2022-04-13 09:56:37 -07:00
Adeeb Shihadeh 49c2164814 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
2022-04-12 22:58:34 -07:00
Adeeb Shihadeh 162e47456c bump cereal 2022-04-06 22:25:59 -07:00
Willem Melching fb344021aa update camera CRC alert text (#24156) 2022-04-06 17:46:56 -07:00
Willem Melching 1848050fd9 add cameraFrameRate alert (#24152)
* add cameraFrameRate alert

* bump cereal
2022-04-06 17:11:39 -07:00
Willem Melching eaa5819211 commIssueAvgFreq: separate alert for avg freq check (#24150)
* commIssueAvgFreq: separate alert for avg freq check

* bump cereal

* bump cereal

* bump cereal

* freq_ok separate from alive

* bump cereal to master

* update_ref

* fix profiler
2022-04-06 16:43:32 -07:00
George Hotz 8031a68e55 alerts: Don't use Malfunction twice 2022-04-04 12:45:57 -07:00
Shane Smiskol a4353303d4 update refs 2022-04-01 22:39:08 -07:00
Shane Smiskol ca3171c0f9 bump cereal 2022-04-01 20:59:15 -07:00
Adeeb Shihadeh f1719aab84 Contact Support -> Hardware Malfunction (#24076)
* Contact Support -> Hardware Malfunction

* missed that one
2022-03-30 16:13:28 -07:00
Adeeb Shihadeh 5c3f3e44bc break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Willem Melching 14260c01c6 process replay: fix branch name alert (#23783)
* env is modified after start

* update ref
2022-02-17 16:47:42 +01:00
Adeeb Shihadeh f59adbeaaa keep the new alert consistent for process replay 2022-02-16 23:47:02 -08:00
Adeeb Shihadeh ff965c772b add branch name to startup master alert (#23782)
* add branch name to startup master alert

* still orange

* update refs
2022-02-16 20:27:07 -08:00
Willem Melching 8effa2d878 hide localizerMalfunction alert (#23730)
* hide localizerMalfunction alert

* update ref
2022-02-08 22:22:03 -08:00
Jafar Al-Gharaibeh 1c31c9b7a3 Mazda: alert when LKAS is disabled (#23288)
* Mazda: alert when LKAS is disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update refs

* revert that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-01-30 21:04:07 -08:00
Adeeb Shihadeh 3e9cb7fa12 remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
2022-01-24 14:49:47 -08:00
Dean Lee a186bcc9f1 cleanup iterate keys in dictionaries (#23497) 2022-01-12 12:42:50 +01:00
Dean Lee a653461dec check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Dean Lee 8eec818ae6 events: cleanup function any (#23479) 2022-01-10 14:32:07 +01:00
George Hotz dc96d4bee7 Add More Types for mypy (#23268)
* mypy passes

* a few more

* a few in manager

* more types, will lint

* more

* simple types

* events type

* Update selfdrive/thermald/thermald.py

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-12-28 18:07:00 +01:00
Adeeb Shihadeh 256c51e16a bump cereal 2021-12-20 23:04:27 -08:00
Adeeb Shihadeh c92199ab1a Revert "Mazda: alert when LKAS is disabled (#23273)"
This reverts commit f25121b736.
2021-12-20 23:02:02 -08:00
Jafar Al-Gharaibeh f25121b736 Mazda: alert when LKAS is disabled (#23273)
* Mazda: alert when LKAS is disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update selfdrive/controls/lib/events.py

* Update selfdrive/car/mazda/interface.py

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-12-20 14:58:46 -08:00
Adeeb Shihadeh 8068df0b2a alerts: escalate soft disable alert near disengagement (#23198)
* alerts: escalate soft disable alert if resulted in disengagement

* show 0.5s before disengagement
2021-12-11 17:07:37 -08:00