Commit Graph

249 Commits

Author SHA1 Message Date
cl0cks4fe dd9d5d4528 Unittest to pytest (#32366)
* add pytest-asyncio

* switch common

* switch selfdrive

* switch system

* switch tools

* small fixes

* fix setUp and valgrind pytest

* switch to setup

* fix random

* switch mock

* switch test_lateral_limits

* revert test_ui

* fix poetry.lock

* add unittest to banned-api

* add inline ignores to remaining unittest imports

* revert test_models

* revert check_can_parser_performance

* one more skip

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-05-17 11:01:44 -07:00
Shane Smiskol f597d63bf6 PlatformConfig: clean up and print all flags (#32369)
* script to print flags

* don't need

* SAL

* back

* fix
2024-05-07 15:00:02 -07:00
Jack Merrill 5783bdc513 Subaru: Increase RPM Limit (#32299)
Increase the Subaru RPM limit in values.py, update panda submodule
2024-04-26 16:07:17 -07:00
Jason Young d14407dafa Subaru: Add FW for 2020 Subaru Forester (#31748) 2024-04-15 15:03:22 -07:00
Justin Newberry b0eb3ba4f4 cars: platform enums -> prepend brand name (#31927)
* with brand name

* migrate

* Fix

* fixes

* more

* passes

* fix

* fix the doc

* collects

* these too

* more stuff

* body exception :/

* more

* hardcode i guess

* update ref

* toyota

* more toyota

* and here

* final!

* fix notebooks and ccs

* move this here
2024-03-19 17:29:50 -07:00
Adeeb Shihadeh 3a7582d9a6 Abstract out common CarInterface.apply (#31924) 2024-03-19 13:46:31 -07:00
thenhnn 489528dcae PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2024-03-19 11:16:02 -07:00
Shane Smiskol d82fc7f27b [bot] Fingerprints: add missing FW versions from new users (#31842)
Export fingerprints
2024-03-18 16:02:34 -07:00
Justin Newberry 655e5f7c3e rename CarInfo to CarDocs (#31879)
car info to car docs
2024-03-15 11:45:44 -07:00
Shane Smiskol bdae188c6f docs: don't support multi-type car info (#31875)
don't support multi-type car info
2024-03-15 00:11:41 -07:00
Shane Smiskol 5be3f0b7db Subaru: log alt request (#31812)
* add alt query (same as Hyundai)

* refs
2024-03-08 19:36:33 -08:00
Shane Smiskol 3862911ae6 [bot] Fingerprints: add missing FW versions from new users (#31732)
Export fingerprints
2024-03-08 17:01:31 -08:00
Shane Smiskol 66adf8781e Subaru: extra logging request for camera (#31783)
* 7f - service not supported in active session

* update refs

* rm short

* Apply suggestions from code review

* bus 0
2024-03-08 17:00:07 -08:00
Shane Smiskol 99610c8819 Revert "common PlatformFlags base class + test for < 32 bits" (#31793)
Revert "common PlatformFlags base class + test for < 32 bits (#31779)"

This reverts commit 8ba5d660f3.
2024-03-08 00:15:21 -08:00
Shane Smiskol 90442e3597 Subaru: make OBD query logging (#31785)
* make OBD query logging

* Update selfdrive/car/subaru/values.py

Co-authored-by: Justin Newberry <justin@comma.ai>

* wording

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
2024-03-07 18:57:15 -08:00
Justin Newberry 5d710ecf57 Subaru: log eyesight faults as acc faults (#31716)
* log cruise fault

* better comment

* spacing

* backwards

* moved

* copy the other one

* localized

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-03-07 15:30:31 -08:00
Justin Newberry 8ba5d660f3 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
2024-03-07 14:01:28 -08:00
Shane Smiskol 78a46ce724 car values formatting (#31747)
values formatting
2024-03-06 15:47:44 -08:00
Justin Newberry 25ccb2426c cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
2024-03-06 11:22:12 -08:00
Justin Newberry b0eae8c1b7 platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
2024-03-01 11:31:51 -08:00
Shane Smiskol 690dc55ea2 Car flags: label static flags (#31639)
* comment, consistent source

* no caps not global

* no field

* label rest
2024-02-29 15:36:40 -08:00
Shane Smiskol 0fa3445ddb Subaru: use carParams flags in interface (#31653)
* Subaru: don't use platform flags

* clean up
2024-02-29 15:19:31 -08:00
Justin Newberry ac16c5518a add CAR.print_debug (#31652)
print debug
2024-02-29 15:01:47 -08:00
Shane Smiskol 5d291cb64d Subaru: group steer rate limited with GEN2 (#31640)
* remove sideways diff

* make a subclass

* fix

* fix
2024-02-29 14:45:31 -08:00
Justin Newberry 3a6c3315ab Subaru: move to flags within PlatformConfig (#31584)
* flags

* update ref

* use the flags directly

* use post_init (don't freeze)

* we can maintain frozen with custom class

* not preglobal

* move to common

* cleanup
2024-02-28 20:12:14 -08:00
Justin Newberry d4c497d826 add CarControllerBase base class to all CarControllers (#31630)
just base class for now
2024-02-28 17:13:44 -08:00
Justin Newberry 9ecff49118 platformconfig: freeze all dataclasses (#31605)
* frozen

* frozen
2024-02-26 21:16:05 -08:00
Eric Brown 5012e15aa6 GM: move to platform config (#31553)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* Move GM to platform config

* Implement CarSpecs

* Simplify centerToFront

* Accidentally had subaru DBC

* Fix typo in DBC name

* done above

* two spaces

* that is moved up

* fix hardcoded fingerprints

* whitespace

* values

* better?

* fix

* bump

* fix

* fix

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
2024-02-25 17:53:26 -08:00
Justin Newberry cdd4d418aa Subaru: fix forester weight (#31585)
fix weight
2024-02-24 23:15:16 -08:00
Justin Newberry e6009d80e9 cars: introduce "Platform" union type for all car enums (#31558)
* Hmm

* release

* hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm

* unrelated

* forgot

* cleaner

* Platform

* new syntax

* Fix

* clean

* Fix
2024-02-24 22:18:13 -08:00
Cameron Clough 995250ae49 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
Justin Newberry 1161d33c18 Subaru: move carspecs to PlatformConfig (#31550)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* fix
2024-02-23 13:23:40 -08:00
Justin Newberry 73a497ded8 cleanup PlatformConfig (#31551)
cleanup
2024-02-22 17:49:27 -08:00
Justin Newberry 015eed5d61 Subaru: move to PlatformConfig (#31547)
* subaru platform config

* forester wrong dbc

* spacing
2024-02-22 17:17:00 -08:00
Justin Newberry 51e3daf244 Subaru: add 2024 forester (#31520)
* also angle based

* 24 forester
2024-02-20 15:02:56 -08:00
Justin Newberry 33e6158d9b Subaru: add message for angle LKAS (#31402)
add angle
2024-02-10 17:47:06 -08:00
Justin Newberry 54fe19206e Subaru: eps is non-essential for gen2 cars (#31220)
* eps non essential

* comment

* suggestions
2024-01-29 16:48:03 -08:00
Andrei Tanas e86aafc723 Add 2022 Subaru Outback IDs to subaru/fingerprints.py (#31016) 2024-01-29 16:07:56 -08:00
Justin Newberry aff3d5ae09 Subaru: move non-obd requests out of logging (#31174)
enable
2024-01-27 09:07:14 -08:00
Justin Newberry 94cd4c9046 Subaru: ensure consistent firmware version size (#31001)
* fix copying mistakes

* fix SA

* remove print

* ensure size is same

* fix SA

* not in database
2024-01-15 12:52:15 -08:00
Justin Newberry 4c6f7da404 Subaru: remove incorrect fingerprints from other brands queries (#30984)
s
2024-01-14 19:55:15 -08:00
Justin Newberry e7657d896f Subaru: fix disable eyesight enum (#30974)
value
2024-01-11 17:15:37 -08:00
Justin Newberry a58baf48fe Subaru: longitudinal cleanup and dash status fixes (#30868) 2023-12-29 23:47:55 -05:00
Justin Newberry 9520153b6a bump submodules (#30866) 2023-12-29 19:39:17 -05:00
Justin Newberry 3d8c78d6b3 format_fingerprints: automatically sort fw fingerprints (#30819)
* Auto sort fingerprints

* add comment
2023-12-20 11:54:31 -08:00
Justin Newberry 3713e4d5ea add script to automatically format fingerprints file (#30792)
* Add script

* fix script

* fix script

* fix for subaddr

* run the script

* old style can fingerprints

* cleanup

* sort imports, make executable, fix path

* newline w/o newline

* match og can formatting

* match og formatting

* generate template once

* standard name

* less nested

* can fingerprints comments

* fix spacing

* no need for PLATFORM_TO_ENUM_NAME!

* prep for PRs

* comments for all, add honda comments

* Auto-generated fingerprint PR from fuzzy fingerprinting cars

* Revert "Auto-generated fingerprint PR from fuzzy fingerprinting cars"

This reverts commit 97bc9e3bdb9d819dcbe684ceba92ea702d40eaf0.

* even closer to original

* readd this comment

* and run script

* add to precommit

* add comments

* add comments

* add to release

* use for auto fingerprint

* disable precommit for now

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-12-20 11:18:29 -08:00
Shane Smiskol adb04b5dc5 fingerprints: fix formatting (#30814)
formatting
2023-12-19 23:47:34 -08:00
Justin Newberry 28eed156e0 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
2023-12-18 14:04:27 -08:00
Justin Newberry 5f24078a48 Subaru: enable alpha longitudinal for gen1 cars (#30714)
* enable alpha long

* update docs

* added footnote about eyesight

* only for these cars

* add alpha

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-12-13 20:17:33 -08:00
Justin Newberry b1e2e0f565 Revert "Subaru: log eyesight fault as a cruise fault" (#30560) 2023-11-30 07:57:29 -08:00