Commit Graph

8094 Commits

Author SHA1 Message Date
Shane Smiskol 270fe5aac3 controlsd cruise speed: fix missing initial value
old-commit-hash: f15d169289c0d806a49af123678bd49b8b3ba4f1
2022-11-14 11:01:01 -08:00
Shane Smiskol 74d58ab0d6 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
old-commit-hash: 15383d30161de7646edf770153b0f81d15338c54
2022-11-13 21:13:46 -08:00
Shane Smiskol a570984aa3 interfaces: disable on falling edge of cancel button (#26493)
* both

* Update ref_commit
old-commit-hash: ca37d0c8cc43a88189c2a96b02aed0edfe5aa32e
2022-11-13 20:50:28 -08:00
Shane Smiskol a0539910bf controlsd: no speed increment if enabled on button rising edge (#26490)
* don't increment speed if we enabled on rising edge

* more realistic test
old-commit-hash: e46063086f079eff6292a32ae9aeeafa3aa523a3
2022-11-13 16:34:26 -08:00
Shane Smiskol 210e281cd4 cruise speed tests: match controlsd initialization of cruise speed (#26491)
* helper functions and fix resetting/enabling

* comment (resume not yet tested)

* make it clear how this resets

* this is fine to enable once

* same here
old-commit-hash: 3524cc7f0bbb94ccb4d6b7b0504692d23288a05f
2022-11-13 16:15:17 -08:00
Shane Smiskol dc27f0de03 GM: handle run-away set speed (#26480)
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04fca25e6a1bac889e44afac6430d5ad7c30.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6900e0f0470f14ed55e7846e4b1d570826.

* fix

* bump

* fix that

* Bump to master

* fix fix
old-commit-hash: 65f494d845bbfa47293ad3158a68bc38c1b4dcff
2022-11-12 02:02:30 -08:00
Shane Smiskol 0f3aeb531c controlsd: clean up v_cruise updating (#26479)
* clean up

* clean up

* clean up
old-commit-hash: 870b79818566ab91159d23f1197183f3e6567608
2022-11-11 23:56:35 -08:00
Shane Smiskol 415152ade9 controlsd: add tests around cruise speed (#26478)
* start to add some tests

* test !pcmCruise

* test !pcmCruise

* better test

* fix pylint

* new test for making sure we adjust on falling edge of buttons
old-commit-hash: a638afb98e2b9d7844c04b1ec55c79d3274bc9b1
2022-11-11 23:11:49 -08:00
Kurt Nistelberger 2efa3cecc1 CI: regroup devices (#26436)
* regroup ci devices

* cleanup looopback test

* split loopback devices

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
old-commit-hash: 5f094b836851c392b89429cc654082c659f7caec
2022-11-11 21:50:09 -08:00
Shane Smiskol dd6f16fcfd controlsd v_cruise: fix unknown buttons (#26474)
Fix button being None
old-commit-hash: d3f971b365613329a35a3140b9418977baebd856
2022-11-11 20:10:12 -08:00
Shane Smiskol 0371e47fac controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
old-commit-hash: 76ac3d4c99df24f068aee3baedb796f65dfcca66
2022-11-11 19:43:30 -08:00
Shane Smiskol a7828e1ae3 controlsd: add cruise speed helper class (#26472)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* revert gm stuff

* revert standstill stuff

* remove

* revert that

* we can put this in here now!

* below update

* actually only used here

* one line
old-commit-hash: 811c096e6454dc2bbdd1e15a08952979c3fb7be1
2022-11-11 18:53:48 -08:00
Shane Smiskol 054cb1f8c1 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
old-commit-hash: 89b88fc7a23c393b1d74c5c74aacd5c4ee254d81
2022-11-11 14:49:38 -08:00
Shane Smiskol 400b36a57f longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
old-commit-hash: 9f80a97eee52d128559b7fef0593b8c328a6142d
2022-11-11 14:02:09 -08:00
Shane Smiskol 3fb09283a6 planner: fix undeclared variable (#26468)
* undeclared variable

* run first second disabled

* revert test

* rev
old-commit-hash: 98206fb92e6a071127f6d6e4fec456d0c437444f
2022-11-11 13:22:56 -08:00
Adeeb Shihadeh 8e88116dba boardd: SPI bulk read + write (#26462)
* bulk read

* write

* write

* fix write

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 714ab491b0ff90170353df99f43f09bbae1ab00d
2022-11-11 12:51:14 -08:00
Jason Wen 434324bfcb HKG: Bump Kia Telluride support to 2022 (#26467)
old-commit-hash: f6189b32351b21ad528486ee69c55666a1ef0d55
2022-11-11 11:40:21 -08:00
Harald Schäfer dfd47a5f4d Add force decel to e2e long (#26448)
* add force decel to e2e

* Update longitudinal_planner.py
old-commit-hash: f23296bc87a79c59d9ab011f2ba35ed1049beb72
2022-11-11 10:46:03 -05:00
Shane Smiskol 1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7dc8e0b1ec051f00037506d23a017ae8
2022-11-10 19:06:31 -08:00
eFini 2dc299e937 Multilang: add missing Chinese (Traditional) translations (#26433)
* update cht translation

* fix ellipsis -> spaces

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 765761d7d0e813a3397728dcbe81a23a30051288
2022-11-10 19:02:58 -08:00
Adeeb Shihadeh cec416ac66 boardd: verify SPI checksum (#26454)
* verify checksum

* import from panda

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f5bf3cd21bef0069e0f470ad79ccac3da361a295
2022-11-10 18:37:10 -08:00
Lee Jong Mun b1b9b98efa Multilang: kor translation update (#26445)
* Multilang: kor translation update

* fix
old-commit-hash: df145ae99f80d53667533f848b661768b7d5c269
2022-11-10 16:56:28 -08:00
AlexandreSato ed43e73c33 Multilang: Update pt-BR translations (#26444)
* update pt-BR translations

* fix some cutoff texts

* Delete main_pt-BR.ts

* Add files via upload

* Delete main_pt-BR.ts

* Add files via upload
old-commit-hash: 2961f8a7d8b891dd95912e0d21f54cf1f4afb696
2022-11-10 12:27:25 -08:00
YassineYousfi b7b827bdd2 min lane change speed 20mph (#26434)
old-commit-hash: 737408066895452f31f08144c129551b94e64662
2022-11-09 22:04:57 -08:00
Shane Smiskol 8c981ed847 Toggle titles: proper capitalization (#26438)
* proper caps

* update translations

update translations

update translations

* Update selfdrive/ui/translations/main_pt-BR.ts
old-commit-hash: 4efb01ece2a9ef54152682c1dc3756d3e4161241
2022-11-09 20:33:01 -08:00
Shane Smiskol a7eaaa16bb ui: static color non-e2e path (#26406)
* remove orientation color changing

* "just green"
old-commit-hash: 0941e40177eb0eb7a49bb08628e5aad2deb19c7f
2022-11-09 20:31:38 -08:00
Nelson Chen fcf4893f7d Toyota: add missing engine FW for RAV4H_TSS2 (#26432)
"rav4 hybrid xse 2020"

From Rogrhoa#2158 on Discord.

Example Route: 64edc30d23cad8cb|2022-11-09--20-02-03
old-commit-hash: d3122cc77e169d8eb87663741bacc165f7062d56
2022-11-09 19:59:12 -08:00
Shane Smiskol 848dc2da49 experimental long toggle: adjust description (#26437)
* Spell out AEB

* vanish
old-commit-hash: af84f1b3506082d644c2f52f88390fabcc9f7835
2022-11-09 19:42:34 -08:00
Shane Smiskol b2e82d028a ParamControl dialog: more explicit confirmation text (#26431)
* Use enable

* vanish

* fill in missing translation

* Update selfdrive/ui/translations/main_pt-BR.ts
old-commit-hash: a3cd50c5bbb924eaf40ab18d76f603edfc2f5a2a
2022-11-09 19:38:17 -08:00
Shane Smiskol 7c6601fed1 Multilang: clean up translation string (#26435)
* update translations

* do pt

* do pt

* do ko

* do ko

* Update selfdrive/ui/translations/main_pt-BR.ts
old-commit-hash: 5a3c5e7a4b78853d6b350f551432a1bb6050eba9
2022-11-09 19:33:42 -08:00
Adeeb Shihadeh 18203a1cee UI: add set speed clarification for e2e long
old-commit-hash: 1fda075c7306976099bcfbb6b0a6303e819036b4
2022-11-09 18:42:51 -08:00
Shane Smiskol ab5e2b66e8 Toyota: factor on cluster speed to match dash (#26408)
* add a minimum factort

* Update ref_commit
old-commit-hash: e1001a3036fb93d6d0340d139d4ae2a1f2419d52
2022-11-09 18:27:30 -08:00
Shane Smiskol 2f978cd1a3 Multilang: mark some translations finished (#26430)
* mark finished translations

* fix

* cleanup

* revert
old-commit-hash: 6c03e093c6d1d9d45dc342cce2374656b80ecaa9
2022-11-09 17:31:58 -08:00
Shane Smiskol 215c16d661 Multilang badges: assert width exists in xml
old-commit-hash: bbc14656d937cadacbcb87ed88cb8800eb6b62fa
2022-11-09 17:30:33 -08:00
Shane Smiskol 9913ba51a9 multilang badges: no need to handle plurals
old-commit-hash: d8327bd9bed9833eb3d58a51097215c2de803d1b
2022-11-09 16:58:02 -08:00
Shane Smiskol c5f5a951dc translation badges: add number of unfinished translations (#26429)
* some clean up and add missing translations

* unfinished

* set proper width

* make this variable common
old-commit-hash: f540002e3fb6bcb15323add59d87269e7da6d00f
2022-11-09 16:49:17 -08:00
Lee Jong Mun 90418d1f97 Multilang: Korean translation update (#26424)
fix
old-commit-hash: 26d66ac671a6b15be4611face27844bae90b185f
2022-11-09 16:15:44 -08:00
AlexandreSato abd77480dc Toyota: Add missing Corolla Cross FW verions (#26426)
* add geraldo fingerprint

* add to non-H

* Update selfdrive/car/tests/routes.py

* Update non-us cross model years

* add test route

* Update routes.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 52378c97ecde4c489e18e23d01021f27c3acf073
2022-11-09 16:06:36 -08:00
Shane Smiskol 4980210416 Hyundai: add missing Sonata 2022 FW versions (#26428)
* Added FW Versions for 2022 Elantra and 2022 Sonata. 

Added for CAR.ELANTRA_2021 :

Ecu.transmission :  b’\xf1\x87CXMQFM3421815JB2ww\x96y\xaa\x98x\x87\x88wtwTfuwWh\x9f\xff\x8a\xff\xff\xffE\xe3\xf1\x89HT6VA640A1\xf1\x82CCN0N20NS5\x00\x00\x00\x00\x00\x00'

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x82CNDWD0AMFCXCSG8A'


Added for CAR.SONATA :

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x81HM6M1_0a0_J10'

Ecu.transmission: 
b'\xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x81T02832A1  \xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x82VDN8T25XXX832NS8'

* Update values.py

* Removed FW Versions for Elantra_2021.

* fix

Co-authored-by: humza2000 <111622889+humza2000@users.noreply.github.com>
old-commit-hash: 048cce2149db34ea0e32df3673248fbbc8e804ad
2022-11-09 16:04:19 -08:00
AlexandreSato 5cdd97649d Multilang: update pt-BR (#26420)
* update pt-BR translations

* fix some cutoff texts

* Update pt-BR translations
old-commit-hash: 584842488f4cab62bb9d5e4d8fc2cc3090634fb7
2022-11-09 15:13:17 -08:00
Cameron Clough 07282a9aeb ui: increase toggle confirmation font size (#26413)
* ui: make toggle confirmation text larger

* center title

* reduce line breaks

* slightly reduce font size
old-commit-hash: f38fe7cfb1b3011ea48a34b0500f352338e05b25
2022-11-09 14:53:41 -08:00
Shane Smiskol fc733027f5 interrfaces: more complete PID tests (#26422)
* more complete PID tests

* doesn't need to be fancy

* less fancy
old-commit-hash: 0ca9d1810c39d96ec0ebefc80df16dd68eb3387e
2022-11-09 12:10:08 -08:00
Vivek Aithal 66231d85de [controlsd] Toyota Rav4 TSS2 bugfix (#26421)
bugfix toyota rav4 pid init values
old-commit-hash: c64e2c228a57dd82685f9ca4251c49e953e1ac69
2022-11-09 12:09:55 -08:00
Jason Young 7dcbc23732 VW PQ: Fix exception with openpilot longitudinal (#26417)
* VW PQ: Fix exception in long control

* move default value to init
old-commit-hash: 34f580e75ee148398e6a44980053c20bf10f9797
2022-11-09 01:55:37 -08:00
Shane Smiskol 54b089a56d GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
old-commit-hash: 191b8081b2a9f3f9db0131edd270e40166570cfa
2022-11-08 20:52:35 -08:00
Adeeb Shihadeh 74979a7c76 experimental mode (#26416)
* experimental mode

* rename param

* red lights
old-commit-hash: 9a3f46805104c4bcb5cffa304b9b322874ccf412
2022-11-08 14:45:01 -08:00
Adeeb Shihadeh 461206de1c boardd: SPI support (#26374)
* spi handle

* put usb back

* handle eintr

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 8ba9a5107b353cc0fc5ab3bbab589b70c2fe9aaa
2022-11-08 13:21:07 -08:00
Adeeb Shihadeh 45dec4e84f UI: widecam only in e2e mode (#26412)
old-commit-hash: 5960ba5def7c42b3944f96cf103a0c4a6e633754
2022-11-08 12:49:22 -08:00
Shane Smiskol f9c9b96e27 Toyota: add hysteresis to cluster speed (#26386)
* add hysteresis to cluster speed

* add minimum cluster scaling

* fix

* Update ref_commit
old-commit-hash: 52a644e6564582632559255230c82b550db50c76
2022-11-08 00:03:23 -08:00
Jason Wen 62990e317e HKG: Car Port for Genesis GV70 2022 (#26373)
* HKG: Car Port for Genesis GV70 2023 thanks to @zunichky!

Co-authored-by: kyle zunich <zunichky@msu.edu>

* Update docs

* Update selfdrive/car/hyundai/values.py

* GV70 does radar SCC, separate them

* One more

* bump panda

* Gate 0x1A0 away from bus 6

* Can't leave out the OG

* EV6 non-HDA2 too?

* bump panda

* bump panda

* Check 0x1a0 based on param

* bump panda

* bump panda

* bit simpler

* fix bit op

* fixes

* bump panda to master

* cmt

* flip

Co-authored-by: kyle zunich <zunichky@msu.edu>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: d62cdc400ce5f49b22ac42d5e9b74398e7c636b6
2022-11-07 23:03:36 -08:00