Commit Graph

200 Commits

Author SHA1 Message Date
Justin Newberry 1b35278d95 Subaru: remove 2020+ temporary steering faults (#29116)
* subaru steer faults

* it takes a bool now

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* that was removed

* should be abs

* bump panda

* bump panda

* subaru faults

* add fixme

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* review suggestions

* still want zero steer when lat not active

* bump submodules

* move it under the non-preglobal section

* better comment for steer limited

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fb06b98667483bbf9d62b16d7f5aa5e50721f597
2023-09-07 15:28:46 -07:00
Justin Newberry a1b0f02051 Subaru: don't copy eyesight counters, calculate manually (#29533)
* subaru manual counters

* update ref

* that isn't used

* review suggestions
old-commit-hash: 338288df6e0f872ddc6c1cd02ce130d6ce154e36
2023-09-06 16:08:59 -07:00
Justin Newberry 3b91610c0b Precommit: ensure executable bit is set (#29784)
* precommit ensure executable

* exclude tinygrad

* bump submodules

* exclude tinygrad globally
old-commit-hash: 4e69937d0d3fbdc7d1d42cbc18d7ccf8ddb115f1
2023-09-05 16:33:26 -07:00
Justin Newberry 8b7c706ff3 Subaru: impreza 22 fingerprint (#29765)
add fingerprint
old-commit-hash: f4f92f1a2fba9358f7a529b9f5c28d90c9691d08
2023-09-03 13:12:31 -07:00
Justin Newberry 417968212b Parser: assert no duplicate message checks (#29696)
* assert no duplicate checks

* bump

* remove duplicates

* are both messages present?

* guess we need this extra check

* this makes it more clear

* bump opendbc

* fix preglobal
old-commit-hash: 5f0729791ab6bdb22b3e971f0153a88441f8831a
2023-08-29 10:53:21 -07:00
Justin Newberry f22753034c Subaru: cleanup and fix preglobal (#29690)
* cleanup and fix preglobal

* those are also duplicates
old-commit-hash: 3348cd3825d33a6026ef92a526e54ff8cf41ce5e
2023-08-28 19:37:04 -07:00
martinl 5f1528708e Subaru: Ascent 2023 dashcam mode (#27583)
* Subaru: Add support for 2023 Ascent

* Update supported cars list

* Remove tester present from fw query

* merge master

* fix merge issues

* minimize diff

* add comment about 23 ascent

* add comment

* correct spot

* fix name

* nocap

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a1bf66a0d26574eabf322ce139142a6db92c9098
2023-08-25 20:55:21 -07:00
Adeeb Shihadeh 61cf541322 Minimal build (#29600)
* add build flag for minimum build

* add minimal build

* update

* fix pj

* bump opendbc

* update subaru
old-commit-hash: 4917e22615adbfcc9b3c3ec89b00d240e0b48883
2023-08-24 14:58:30 -07:00
Shane Smiskol acec4fc22f Subaru: Forester Hybrid 2020 dashcam (#24770)
* Add support for Forester Hybrid 2020

Co-authored-by: martinl <martin@mlp.ee>

* it's a param now

* make it work

* fix

* merge and cleanup

* remove duplicate

* should be forester

* bump submodules

* should be abs

* add missing params

* still need a test route

* still need a test route

* consitent

* here too

* todo

* more

* Update selfdrive/car/tests/routes.py

* clean up

---------

Co-authored-by: martinl <martin@mlp.ee>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 3719be8b76f81068da3aadd5bd0f76e8a4d00396
2023-08-23 21:30:12 -07:00
Adeeb Shihadeh 56facfcc5a Subaru: Crosstrek Hybrid dashcam mode (#25378)
* Subaru: Crosstrek Hybrid support

* hybrid cars in dashcam only

* revert that

* just dashcam

* tah should be abs

* remove unused import

* use the old dbc for now

* hybrid car exceptions in carstate

* need dashstatus until we get a proper cruiseactivated bit

* missing CP

* merge conflicts

* lets be consistent about extend

* cleanup

* fix and comments

* preglobal fix

* and the rest

* and this

* added hybrid to release

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
old-commit-hash: 973d90be779efc0e4a83eeab213c0cc9b4d711ce
2023-08-23 18:50:55 -07:00
Shane Smiskol f6fd240e95 Revert "Subaru: always show LKAS active (#27945)" (#29515)
This reverts commit a81e7c635e8c52e84f7da2f3e35b0f5ba86c3e3c.
old-commit-hash: b373e5d5ec8ad108925bc4f7aece5977dd405f97
2023-08-21 16:25:13 -07:00
Justin Newberry bb3a0f883b Subaru: longitudinal incorrect "inactive" rpm (#29496)
* fix incorrect base rpm issue

* "min" name is better
old-commit-hash: b20eba5f1d28ae623eecf5dbbc22f67ff02d3609
2023-08-21 14:54:42 -07:00
Justin Newberry 8abf2d1637 Subaru: remove unused backoff rate calculation (#29368)
* cancel rate

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* leave it as it was for now

* cleanup

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fc9a623d69919897c3e070ed11309c92651611a8
2023-08-21 13:31:57 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Jason Young ac83f87b36 interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f76ffbdbbcef50ba201edc0349f777e4e372b515
2023-08-17 21:06:07 -07:00
Justin Newberry 7faefd677b Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
old-commit-hash: d6c682b40168241e481aa2904198ac29c8d1a73e
2023-08-16 12:58:09 -07:00
Justin Newberry 268fb070a8 Subaru: calculate steering angle rate (#29409)
* calculate rate

* added adeeb's comment

* move to selfdrive/car

* that makes way more sense

* much simpler

* fix rate

* preglobal doesn't have a counter

* update ref

* merge

* update ref after merging
old-commit-hash: 7ec52da33ade1b0926b38fb5dc1e2bc52e957bad
2023-08-15 15:28:46 -07:00
Justin Newberry 1ef7623ec7 Subaru: ES_Distance cruise cancel safety (#29362)
old-commit-hash: c8cae714c681dae9a380b1bcb7b71eeb3fdfba3d
2023-08-13 22:14:13 -07:00
Marcus Millspaugh 9b98b3d6ea additional Subaru fwVersion (#29365)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

* started adding support for toyota bZ4X

* Add files via upload

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* remove duplicates and mistakes

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 2c13dea1c822ce8be02be530604d0d984277ad13
2023-08-12 22:05:33 -07:00
Shane Smiskol 151b707901 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cbfcc405715ae4fa45b3beea03dd82ba925495c4
2023-08-10 20:30:35 -07:00
Justin Newberry 7648f35b1c Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
old-commit-hash: 1e1cc638d8e9fa408a02a57d689c13c2219d823d
2023-08-01 00:06:21 -07:00
Justin Newberry cb45be4b6f Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
old-commit-hash: 38954418f097f5267505df67ff275f7830191022
2023-07-31 13:58:33 -07:00
Marcus Millspaugh a185de7fdc Update Car/Subaru values.py to support 2022 Crosstrek (#29177)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: d7e857730121c7c6426ebd7310c1db1e534c692c
2023-07-30 10:05:21 -07:00
JeanPierre Rousseau ca10c50d37 Subaru: add footnote to docs for international models (#26381)
* Update Cars.md

Updated Subaru required specs

* Update values.py

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b349a8c940cc77188e6c144bc3f8c40b5a3cd3c7
2023-07-08 05:17:10 -07:00
Maxime Desroches 585921ffad car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
old-commit-hash: e85acfa365dea5fc4b004664ef2df120d05d0022
2023-06-27 16:48:43 -07:00
Justin Newberry 18cb3e6cb3 Subaru: Signals Cleanup (#28602)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

old-commit-hash: 803c077dc1f4b1b7aafe6df11f168159f986d602
2023-06-23 21:24:27 +01:00
martinl 91e7bf83b8 Subaru: log stock AEB (#28052)
* Subaru: log stock AEB

* Remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* add ES_Brake

* use actuation bit

* bump opendbc

* remove aeb from UI

fix

* Update selfdrive/car/subaru/carstate.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5cb9360fa0061222bcef18882f829ec8b9fcece4
2023-06-16 22:48:09 -07:00
Shane Smiskol a9986892c0 Subaru: use latActive for steer request bit (#28453)
* subaru: use latactive

* Update ref_commit
old-commit-hash: bce19bf187ed9c444bca834f64460f1648abe587
2023-06-12 23:03:04 -07:00
Shane Smiskol 31c1e66a01 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
old-commit-hash: 024abe6455d44c7616ca7c694643c5324d0d371c
2023-05-31 21:30:50 -07:00
Shane Smiskol a072c467b5 cars: explicitly add counter/checksum messages (#28341)
* hkg canfd: add counter/checksum

* add explicitly to subaru

* same for ES_LKAS_State

* and ES_DashStatus

* aaand INFOTAINMENT_STATUS

* and preglobal ES_Distance

* Revert "and preglobal ES_Distance"

This reverts commit 68d98307703a24296ff7aafd99503ea6af4b231b.
old-commit-hash: 439a30aae4c0495bb27aed4b5cd2d0e684fe0f1b
2023-05-30 15:33:02 -07:00
Shane Smiskol 39088829b6 Subaru: explicitly copy signals to forward (#28304)
* do subaru

* add missing checksum

* more missing checksums
old-commit-hash: 54e6d4c4028f790a2c38c5ccd3e4a9f012e4cce2
2023-05-25 22:59:52 -07:00
Justin Newberry 8e51174066 Subaru: frequency based messaging (#28066)
* frequency based messaging

* frequency based messaging

* frequency based messaging

* frequency based messaging

* rename better

* use frame in if statement

* syntax

* remove extra space

* put all behind one if statement

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: c1909df43716d8e40333b2e587dbc5ac97020b05
2023-05-25 22:33:04 -07:00
Maxime Desroches 734b6481b7 car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9f5f8b603cf69b06c4804632268491cf38cfac7e
2023-05-22 10:17:33 -07:00
Kyle Greenlaw 08b67e417f Subaru: Add fw for 2020 Subaru Outback (#28240)
Route: a4e8e925930fce2c|2023-05-19--20-47-32
old-commit-hash: 7a684da47f7c587063ec3c333d748cc37b5417a6
2023-05-19 22:49:46 -07:00
Justin Newberry 63794374e9 Subaru: rename legacy to preglobal (#28204)
* rename

* submodules too

* missed some variables

* fix find/replace error

* revert modules

* bump submodules

* bump cereal
old-commit-hash: f327053ac0326e9ac8d4094d35940245c07b0f3b
2023-05-15 19:12:47 -07:00
Maxime Desroches 4626add29c add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 70677fe5fc044bff0ea99eab6bba5a6d02d5a85f
2023-05-15 15:33:54 -07:00
martinl eb47aa90ee Subaru: FPv2: Add Crosstrek Limited 2023 missing FW values (#28014)
* Subaru: FPv2: Add Crosstrek Limited 2023

* trailing comma

* remove duplicate

* prefer hex

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: 2ad352d2993d25d5b656b2e20b696130ad465da1
2023-04-26 20:21:50 -07:00
Shane Smiskol d57006f829 cars: various small cleanups (#28031)
* finally fix subarucan formatting

* no need for intermediate variables

* make this check explicit
old-commit-hash: 9689e9c5675835a611a749c4a024551263f5daa3
2023-04-26 01:43:07 -07:00
Shane Smiskol 1db7785289 Subaru: fix forwarded signal name (#28030)
actually Cruise_Status_Msg
old-commit-hash: 045db2f2357d59117e14fabe4c2d32735e02fada
2023-04-26 00:19:01 -07:00
goatstalker 49b1caa329 Add additional fingerprints for Subaru Outback 2022 model (#27995)
* Fingerprint Subaru outback 2022

Add fingerprint for carFw abs, engine, transmission, and fwdCamera.

* fingerprint two more values

* order values properly before submitting a PR

* remove hyundai fw responses

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: a5d0d7b0697aea8aa535d7e99f31b6cc8a1e0942
2023-04-21 19:24:24 -07:00
Chase Bolt 298edb7704 Add missing IMPREZA engine & fwdCamera f/w (#27985)
adding fingerprints for 2019 subaru impreza sport
old-commit-hash: f7e02c28d743dc2d2fe60a93b99b0f49750b4d80
2023-04-20 21:59:49 -07:00
Shane Smiskol d916e0ed2d Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
old-commit-hash: 5aebdb0ad0e7e527f5deb553ffd193abea02a357
2023-04-18 12:22:22 -07:00
martinl 7bdb84c1a3 Subaru: signals cleanup (#27946)
* Update counter in carstate checks

* Rename es_lkas to es_lkas_state to match signal

* formatting

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 13c75dc138477def107f7da8b0f6430b65d73399
2023-04-17 22:54:27 -07:00
Shane Smiskol 9131202975 Subaru: always show LKAS active (#27945)
subaru always shows lines if LKAS is enabled (not active), more clear what we're sending
old-commit-hash: 8f1e67f6259c436aff500f6bdff9067d4ca79eb1
2023-04-17 22:31:59 -07:00
Justin Newberry da2f2114d6 Subaru: infotainment status intercept and rewrite (#27829)
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* remove compiler flag stuff

* force error for testing

* bump panda and fix mistake

* wip

* bump panda

* wip

* wip

* forgot checksum and stuff

* add to signals

* rename

* test

* test

* bump panda and opendbc

* bump cereal

* add blank filler

* test

* add steer required to infotainment

* fix missing bit

* fix missing bit

* cleanup for PR

* cleanup for PR

* bump submodules

* wip

* wip

* i wonder what 1 is

* seemed to also be obstacle detected?

* bumppanda

* only if global

* only global gen 2

* fix order

* detect and send

* detect in rest of places

* update refs

* bumpopendbc

* copy whole message (camera sometimes sets these signals)

* bumppanda

* update refs!

* bumppanda

* let's not change this

* same as all the other functions

* Revert "same as all the other functions"

This reverts commit e86dbb695ef84a18f3123720fed37a6b81391cc4.

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: d59bfa551955c481fd3762170d483a44251122f7
2023-04-17 19:05:16 -07:00
martinl 225762ba63 Add FPv2: Subaru Forester 2020 (#27854)
* Add FPv2: Subaru Forester 2020

* missing FW

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: cd3a72e8f3039eb6780d2ba6812b82fdfde51793
2023-04-10 20:03:21 -07:00
seven121-ym 85f946795e Subaru: add FW for 2019 Subaru Impreza (#27771)
* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Add missing engine

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 61e718fe5fc270603462cea7fd7ece462802b7b6
2023-04-03 13:40:02 -07:00
martinl dee1d69ec0 Subaru: Add 2019 Forester FPv2 (#27500)
* Subaru: Add 2019 Forester FPv2

* Update selfdrive/car/subaru/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 0d1e272b917b8c1a98453bbe78337a42cd8451fe
2023-03-16 14:32:22 -07:00
Shane Smiskol 4cf0ce33d5 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
old-commit-hash: 581fd62d2642629b23ac111112245a963202143f
2023-02-26 17:32:52 -08:00
Shane Smiskol acc8e38111 GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
old-commit-hash: 8f5057ff2dbea4ebc85bc8f55bc7a37e4d5969b6
2023-02-09 15:37:39 -08:00