Commit Graph

2743 Commits

Author SHA1 Message Date
Jason Young a38f32ae48 VW MQB: Add FW for 2017 Volkswagen Golf R (#29360)
old-commit-hash: c76d24cec99eae552f3387e3378f3557ea47c658
2023-08-12 13:30:40 -07:00
Shane Smiskol 89b56e9661 FPv2: fingerprint on current brand's candidates (#28435)
* pass in brand

* needs to be flipped for exact matching since it's subtractive

* new helper

* makes more sense flipped

* clean up
old-commit-hash: f5a361a1112440b941d50b22b2203192e2d68e3d
2023-08-11 18:47:12 -07:00
Shane Smiskol 8f958e8ee6 fw_versions: clean up some typing (#29350)
* another common type

* here too

* unused
old-commit-hash: 09ce869ee73994af31205e37ae297968e10f66a1
2023-08-11 18:37:17 -07:00
Shane Smiskol 1945ef0441 test_models: match online fingerprinting behavior (#29306)
* draft

* 1x

* clean up

* final clean up

* fix

* self explan

* space

* space
old-commit-hash: 001d4e8729bdab999f9bd948b162091465a125f6
2023-08-11 18:33:11 -07:00
Shane Smiskol 4c47e5fd21 static analysis fixes
old-commit-hash: a1e85f3661d2a464ec452294a57e7c0462044a28
2023-08-11 18:22:42 -07:00
Shane Smiskol 344cbd2049 test_models: check relay malfunction (#29270)
* check relay malfunction in test_models

* draft

* actual relay malfunction (or ASCM was turned on)

* rav4: not dashcam and op enabled, but we're not sending anything

* clean up

* spaces

* more space

* flip

* better?

* combine

* for

* move up
old-commit-hash: 1099b3486a8c38c56873caceac88ea252f972771
2023-08-11 18:10:27 -07:00
Kacper Rączy 4017b1707c radard: tie radard frequency to modelV2 vol. 2 (#29240)
* radard: tie radard frequency to modelV2

Accumulate parsed messages until state is updated (toyota)

Same for honda

Rename rr to something more descriptive

* Change _update method name, since signature has changed

* Update ref commit

* Some renames

* Check for number of cans
old-commit-hash: 460f5c8e0b2fd2c420e211b09b70d1d79834a929
2023-08-11 18:07:06 -07:00
Justin Newberry f33b4de80b Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
old-commit-hash: e4ead4f1830618f5f61978491930cb0b8d36ab26
2023-08-11 16:13:51 -07:00
Justin Newberry d487c0501f Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
old-commit-hash: 62c1e6592439119f360dd64b854e7047f35222ba
2023-08-11 15:33:49 -07:00
Shane Smiskol 6b7b6034b7 common_fault_avoidance: take a bool (#29328)
old-commit-hash: 2a38f38be12052790804851a179acd159cea7f8b
2023-08-11 00:27:53 -07:00
Shane Smiskol 151b707901 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cbfcc405715ae4fa45b3beea03dd82ba925495c4
2023-08-10 20:30:35 -07:00
Justin Newberry 715f028a0e Ruff: enable flake8-builtins (#29315)
* enable flake8-builtins

* replace any with contains

* fix typo in pack

* fix type

* format is from the parent module, has to be enabled

* item_id

* fix item_id

* disable for id since that's what the remote server returns
old-commit-hash: 8793cbff40662a92bff16d75b51479c80517305a
2023-08-10 18:58:22 -07:00
Justin Newberry a14f162bc7 Ruff: comprehensions conventions (#29317)
ignore c408
old-commit-hash: 4a9afd7554060ac5353e96f1d7feb06d3a3671e9
2023-08-10 16:40:30 -07:00
Shane Smiskol 11492496fc test_models: run on route list (#26226)
* move to openpilot

* draft

* support internal urls

* not used

* update seg list

* regen segment list

* regen seg list

* regen

* regen

* regen

* no dirty segments

* regen seg list with no fuzzy or fixed fp

* regen segments with hda2 exception

* regen with added filters

* regen without bad dongle

* regen

* regenerate!

* regenerate, only OP enabled

* regen

* regenerate!

* regenerate!

* stash

* use SegmentName

* new route list

* add temp comment

* remove comment

* let's see if this works

* comment out other tests to speed up

* fix agent

* ?

* hmm

* oh whoops...

* add matrix

* fix

* how many levels do we need?

* fix values

* matrix can't be in parallel

* how about this

* try this

* Revert matrix

Revert "try this"

This reverts commit 8d0d91fd70c467c1fbb4e4e9aed511d15b2a30ef.

Revert "how about this"

This reverts commit a8e4fc53234824e77cbfb1e471277bc033e9dea1.

Revert "matrix can't be in parallel"

This reverts commit daaa6fcc3c75c74cbb90e97c565099a94123994c.

Revert "fix values"

This reverts commit df554b6a3371d124a574eb8d26bc51ef5b5b8fde.

Revert "how many levels do we need?"

This reverts commit 1a17320fa1c5e7220ef60e29981bbb3bb7da16c6.

Revert "fix"

This reverts commit e7eb6e404358fbd2eac3fea1901a8d30ea92d729.

Revert "add matrix"

This reverts commit a1b57e5725417d3c2f639f8edfc0c889b84b6753.

* use pytest instead! (5 jobs is ~150 mins)

* split lines, uncomment

* This Sienna seg has a fault SDSU that stopped forwarding/sending msgs

* picked a route with no PSCMStatus and no panda errors, recent routes are working

* this cadillac was dashcammed (no radar)

* opened an issue for this, it's 'expected' right now

* small clean up

* small clean up

* i don't think that worked

* is this needed?

* add to new PC tests

* cache

* draft

* Revert "draft"

This reverts commit 3b7f740dd4883118747300bc3687074c2d3c2116.

* probably should be function

* draft

* clean up

* add todo

* 600 random segments

* debug

* does this fix pythonpath issues?

fix

* try this

* mount?

* pytest again!

* no need for PYTHONPATH now

* Update Jenkinsfile

* ?

* convention

* clean up

* would be even more complex (have to unset ci which is class level)

* track

* is lfs pulled at all?

* ah no it's not
old-commit-hash: 70b1e9dd756cd2f6929cdf33dd1061a33f3b52b1
2023-08-10 00:45:23 -07:00
Cruise Brantley 051380ca3d Hyundai: Additional Ioniq 5 firmware (#29307)
added fwdCamera
old-commit-hash: e8f33fb5b7d99533719451d6358ef49c090d7008
2023-08-09 23:10:54 -07:00
Shane Smiskol 4cd205fd36 Toyota: set stop and go if TSS2 car (#29303)
we should assume all TSS2 have stop and go (because we set them all manually)
old-commit-hash: 6ffdc32bfc7bcd53ecc5264e6cd6299081c9e8ee
2023-08-09 17:46:06 -07:00
Shane Smiskol 8714f1a406 interfaces: test interface attributes (#29301)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
old-commit-hash: 225ed2ed5a7221974e44c6d1307f959678f237ea
2023-08-09 17:01:38 -07:00
Adeeb Shihadeh a55a8849b3 Revert "interfaces: test interface attributes (#29297)"
This reverts commit 55af4cce3d3955ca0ecdb98517089a0a42b53ad2.

old-commit-hash: 51831d03a3e79d7d9765e173a2eefac1cf0bb694
2023-08-09 16:28:12 -07:00
Shane Smiskol cfa3ff0fba interfaces: test interface attributes (#29297)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
old-commit-hash: 6a678cde6c3ed95ffb5d7236108e9a317517370b
2023-08-09 16:10:30 -07:00
Justin Newberry 3ee0786de3 CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
old-commit-hash: 7fdd9fc37c1c5febf1cd3dc86441ebf0dec7f370
2023-08-09 13:26:54 -07:00
Justin Newberry 7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168614f851087adab2d7f766425922f64
2023-08-08 17:13:35 -07:00
LC 3489b482f1 Toyota: Lexus IS 2023 port (#29257)
* added LEXUS_IS_TSS2 to values.py

* added LEXUS_IS_TSS2 to interface.py

* Apply suggestions from code review

* add torque params

* add test route

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5ace930c5c2ec135578242b4cea49290bb3ce035
2023-08-08 16:34:37 -07:00
Irene 229bb21c9a Toyota: rename ACC_HUD to PCS_HUD (#29150)
* Toyota: rename ACC_HUD to PCS_HUD

* bump opendbc

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2bceb2425f57c1c19e2d7f10d36386aaa1575ef1
2023-08-08 15:24:57 -07:00
Justin Newberry ff96892511 Revert "CI: pylint to ruff (#29276)" (#29284)
This reverts commit ffad7279cbad3c4f2ea786287b4624d3a3aa18d7.
old-commit-hash: a91764954b0c9bfe5ccfc8e64321af6bb6c56536
2023-08-08 14:24:04 -07:00
Justin Newberry 99006365a3 CI: pylint to ruff (#29276)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad
old-commit-hash: cb31a53d8a93cf6cb1f8bd2fff1431716b3a47e4
2023-08-08 13:41:30 -07:00
Cameron Clough 11f0523e8c Ford: update Maverick 2022 docs (#29280)
old-commit-hash: 95289cb180ac53cbe0f522fcbd81a8ad0019a2cc
2023-08-08 11:47:23 +01:00
Shane Smiskol 22187ad0fe Toyota: rename Toyota A harness (#29269)
* add toyota b harness

* not used yet
old-commit-hash: 8d3e661f795260ebd708975105d98f1bdbbcf181
2023-08-07 15:31:50 -07:00
Saber 62ec8c5b35 VW MQB: Add FW for 2023 Skoda Karoq (#29264)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

old-commit-hash: fa504b7baec829214322e1b58182e3d9ba3d6bbd
2023-08-07 22:38:59 +01:00
Shane Smiskol 5d45abcb55 GM: remove unused CANParser flag (#29244)
setting to 0 does same thing
old-commit-hash: 8bff75c010afb04b3acc43ebec312be01dd4efe3
2023-08-04 21:42:34 -07:00
Kacper Rączy c92e7265a6 Revert "radard: tie radard frequency to modelV2 (#29063)" (#29243)
This reverts commit 4b221cb4fd271664ab7d39c5cfefb4225ca07c2a.
old-commit-hash: 1774b4fc61c8f92fae16545a68854238660737e6
2023-08-04 20:25:40 -07:00
David Peterson c0802af169 Nissan: allow B drive mode for Nissan Leaf (#29228)
* CAR.LEAF: NissanCarInfo("Nissan Leaf 2018-22”), video_link= "https://youtu.be/vaMbtAh_0cY&t=0s"),

Add Youtube video 2019 Leaf

* Update selfdrive/car/nissan/values.py

* Update interface.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b50ffc436037354ad5f13580db8d2dede8010a5c
2023-08-04 20:21:04 -07:00
Shane Smiskol 206e06456b FPv2: fast fuzzy fingerprinting (#29233)
* fast fuzzy fingerprinting

* use match_fw_to_car helper

* fix and comment

* alone

* Update selfdrive/car/fw_versions.py

* Update selfdrive/car/fw_versions.py
old-commit-hash: 082fe6868d3833923ff9b0b73b3fe703ef43f366
2023-08-04 16:10:49 -07:00
Shane Smiskol 8b08ba1166 Chrysler: add new diagnostic address for Jeep Grand Cherokee 2016-18 (#29235)
not a standard diag address, or anything we query. only 2 messages

900dfa83b4addfe6|2023-07-31--08-33-51
old-commit-hash: fffc4ae446a8e4a9cbbeb04c1eea0b4a39f72183
2023-08-04 14:29:00 -07:00
Kacper Rączy 79fa322d4a radard: tie radard frequency to modelV2 (#29063)
old-commit-hash: 255f5c13f2d8c6796fd960b248856f11a3c1b05a
2023-08-03 22:10:21 -07:00
Saber faa9444a6a VW MQB: Add FW for 2019 Skoda Kodiaq (#29225)
route name:0bbe367c98fa1538|2023-08-01--12-21-06--0
old-commit-hash: 8332abf015ad2d6a962ed08c991dbd8099ecec58
2023-08-03 16:37:54 -07:00
Saber 55bb3f4566 VW MQB: Add FW for 2018 Skoda Superb (#29222)
route name:77478022b2ebc4b6|2023-07-31--19-00-38--45
old-commit-hash: 2ff53a62ebe93aff125a41821a149244ef535c94
2023-08-03 16:37:34 -07:00
Tenebrous fcef654a2b Toyota: add missing C-HR Hybrid 2020 (UK) FW (#29223)
old-commit-hash: c438f2ba171a9d855f1bb29c7cfb43ab98fdfd65
2023-08-03 15:05:10 +01:00
Christian Bull Gjertsen cab3911ebd car docs: update Toyota vote link (#29218)
* Update CARS.md

Dead link

* fix link

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 24bfb2b44b4d8cd44cf6d0e025843dd68d9c5c67
2023-08-03 03:05:59 -07:00
Maxime Desroches fc3ec6ad35 docs: fix 3x shop link (#29212)
fix link
old-commit-hash: f18ff752d3c14b77eae89f0ca023979f584c5143
2023-08-02 10:50:07 -07:00
Shane Smiskol e3b5998998 Clean up common steer fault avoidance code (#29200)
* fix spacing

* more spacing

* better names and comments

* this default doesn't make sense

* or this

* explicitly boolean since latActive is
old-commit-hash: dba4492aa0b7b773f50816c5992fbe6e272d832f
2023-08-01 14:02:15 -07:00
Shane Smiskol d016d9fad7 Car docs: clean up docs_definitions (#29201)
* two spaces around class

* inch

* easier to read
old-commit-hash: 4474cb734fc7ba2062d848cd1b8dc12821277762
2023-08-01 13:24:51 -07:00
Justin Newberry 6c4a4e5d74 Homogenize Steering Fault Avoidance (#29140)
* fix subaru fault

* try this!

* wip

* try this

* this more or less worked

* this is all under gen2

* that needs to be up there

* comment

* steer_angle

* test

* wip

* wip

* sync

* wip

* cleanup

* remove print

* use sets and fix unittests

* common fault avoidance

* common fault avoidance

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* revert subaru to get this part merged

* revert name change

* revert name change

* revert name change

* same as before

* add test case

* also verify zero tolerance

* keep the current behavior

* split into multiple tests for easier debugging

* added comments and remove tests

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: a19f8dce92bfe7242e64160cb86364d728b01d97
2023-08-01 10:27:06 -07:00
Justin Newberry 7648f35b1c Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
old-commit-hash: 1e1cc638d8e9fa408a02a57d689c13c2219d823d
2023-08-01 00:06:21 -07:00
Shane Smiskol 8540c4dcc6 FW query timing test: fix total time ref
old-commit-hash: 328bfefb5a6f2519210b04c802f6a0b9fbff0637
2023-07-31 22:18:06 -07:00
Pavel Galashin fcd84e35b9 Mazda: fingerprint 2023 Mazda CX-5 Carbon Edition (#29092)
fingerprint 2023 Mazda CX-5 Carbon Edition
old-commit-hash: 9992f852b2c9b4170396499be1f7ea7a44a3c8b6
2023-07-31 19:51:44 -07:00
Shane Smiskol e66c88e20c fingerprinting: always log CAN fingerprint (#29192)
* always log CAN fingerprint

* called finger
old-commit-hash: c8050cf6b379b70d1734d44d363b5d16fe8939f8
2023-07-31 18:26:05 -07:00
Justin Newberry cb45be4b6f Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
old-commit-hash: 38954418f097f5267505df67ff275f7830191022
2023-07-31 13:58:33 -07:00
Cameron Clough b07e2bdb4a docs: remove experimental mode comments from unsupported cars
old-commit-hash: 2fd6310352c39f98501f8467c62854729197fa1e
2023-07-30 20:38:20 +01:00
Cameron Clough 141948c1fa docs: CAN FD cars require a comma 3X or CAN FD panda kit (#29182)
old-commit-hash: 2762a088f12b2e0f0cffca148bf35c8423daae6b
2023-07-30 20:29:56 +01:00
Marcus Millspaugh a185de7fdc Update Car/Subaru values.py to support 2022 Crosstrek (#29177)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: d7e857730121c7c6426ebd7310c1db1e534c692c
2023-07-30 10:05:21 -07:00