Commit Graph

3043 Commits

Author SHA1 Message Date
Justin Newberry 3b65f2075e format_fingerprints: automatically sort fw fingerprints (#30819)
* Auto sort fingerprints

* add comment
old-commit-hash: 3d8c78d6b3a74196b09576f97ac02b4baa67dfe0
2023-12-20 11:54:31 -08:00
Justin Newberry bf8e8f8338 test_models: fallback to public route when route isn't uploaded to CI bucket (#30794)
* wip

* add public comment

* fix that

* wip

* retrigger
old-commit-hash: 05dc0b51e6597fb83aed14f5a390fa4254751c98
2023-12-20 11:29:19 -08:00
Justin Newberry 611e3fe8e7 add script to automatically format fingerprints file (#30792)
* Add script

* fix script

* fix script

* fix for subaddr

* run the script

* old style can fingerprints

* cleanup

* sort imports, make executable, fix path

* newline w/o newline

* match og can formatting

* match og formatting

* generate template once

* standard name

* less nested

* can fingerprints comments

* fix spacing

* no need for PLATFORM_TO_ENUM_NAME!

* prep for PRs

* comments for all, add honda comments

* Auto-generated fingerprint PR from fuzzy fingerprinting cars

* Revert "Auto-generated fingerprint PR from fuzzy fingerprinting cars"

This reverts commit 97bc9e3bdb9d819dcbe684ceba92ea702d40eaf0.

* even closer to original

* readd this comment

* and run script

* add to precommit

* add comments

* add comments

* add to release

* use for auto fingerprint

* disable precommit for now

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3713e4d5eaed783738ea8ecdbd3b7e6abaa974c0
2023-12-20 11:18:29 -08:00
Shane Smiskol a918ee9b72 fingerprints: fix formatting (#30814)
formatting
old-commit-hash: adb04b5dc52a8063bf16a91a159fdbb82c83d514
2023-12-19 23:47:34 -08:00
Shane Smiskol e9e408118b interfaces: fix get_interface_attr typing (#30813)
* fix

* Update selfdrive/car/interfaces.py
old-commit-hash: 1a165c658035233b4fca774d886c7ecb97a43364
2023-12-19 23:35:31 -08:00
Shane Smiskol b7811099e4 fix bad CAN fingerprint type (#30809)
fix bad wrong type
old-commit-hash: 426072bd8717753afec89c4291f329bdedbc31b8
2023-12-19 20:30:42 -08:00
Justin Newberry 1314156365 cleanup fingerprinting typing (#30801)
* wip

* undo + add can fingerprints

* add can fingerpints

* those should go there
old-commit-hash: adca970ca9dc574f740e8523536bf8d4b0d7bfa8
2023-12-19 09:41:09 -08:00
Shane Smiskol f65ccca8e0 test_models: fuzz test panda and CarState (#30443)
* pre-hypothesis

* some hypothesis junk

* this kinda works but is really slow due to counter check

* choose addrs from fingerprint

* stash

* honda nidec brake pressed mismatches fixed

* bump panda

* stash

* tesla: use DI_torque2 (panda msg)

* run

* run

* ah this honda mismatch too

* no more multi can msgs

* clean up, remove old file

* add todo

* prob can remove urandom

* stash, huge examples

* fix pq standstill mismatch

* yuge

* yup there's a leak somewhere

* try to find leak

* skip dashcam (pq and tesla)

* PR comments

* bump

* draft stash

* fix alt brake hondas

* bump

* bump

* bump

* some clean up

* minor clean up

* more clean up

* stash

* fix honda bug

* more

* 100 examples

* revert tesla

* no memory leak any more?

* bring back tests with skips

* parameterize max_examples

* skip interceptor

* is jenkins on my branch?

* ooh that's fast

* 50 is not bad for GH CI

* 300 might be better with rest of test_models

* no more detection

* bump

* need CS_prev to catch bugs where openpilot changes and panda doesn't (eg. not setting interceptor safety mode)

* need to simplify all this

* need a warm up first, since some signals are 1 by default (toyota's gas_released!=1)

* changes

* set honda safety param

* set toyota safety param

* bump panda

* clean up honda

* rm interceptor

* thought interleaving addrs might help, but we can fine tune later

* Revert "thought interleaving addrs might help, but we can fine tune later"

This reverts commit 153301384b48c9f33f9e2af3c224241eaeec41c1.

* get size from dict

* what

* add nocapture marker

* clean up

* try to raise logging level

* need to run last as pytest_runtest_call, since it starts capturing

* get capman conditionally

* mark

* type fingerprint

* should use gen_empty_fingerprint

* no longer needed

* draft

* no longer need gc

* clean that up

* test everything!

* more clean up

* more

* no point

* fix that

* fix errors

* bump

* nice even 300 examples for 300 segs

* final bump :fingers_crossed:

* better import order

* remove debugging prints

* warm up kinda works

* Revert "warm up kinda works"

This reverts commit 7fc77b07d592edb13eadca77deb49540954a7d69.

* random seed

* revert

* strat

strat

* add expl comment

* cmt

* check controls allowed

* Revert "check controls allowed"

This reverts commit e82a0e5396810dd4670e6847aa555194a709e10f.

* not unittests

* run tests!

* run tests 2!

* run tests 3!

* seed unused

* revert

* add shrink phase, and remove health check suppression

* hello

* oncemore

* Update selfdrive/car/tests/test_models.py
old-commit-hash: 5052b55c440f3a778f9db9c854fa385077dd7ab9
2023-12-19 03:18:54 -06:00
Justin Newberry ff12759e80 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
old-commit-hash: 28eed156e0a62ab993de6d534bb102a6ede222f7
2023-12-18 14:04:27 -08:00
Adeeb Shihadeh 63b374bd89 Cython KF1D to Python (#30773)
* Cython KF1D to Python

* cleanup

* set x

* less nesting

* fix release

* Revert "fix release"

This reverts commit 97e5d0f80405660efb861c7b9df7fbfd5dda5dd9.
old-commit-hash: 1421551297396cf16e3d041506f156c1626ded50
2023-12-16 23:45:28 -08:00
Adeeb Shihadeh ab31860658 remove PyYAML package (#30770)
* remove PyYAML package

* remove those

* add comments back

* fix lock

* fix those
old-commit-hash: bc54ed794b2cd9dcb9522cdeb241ad78ac30d998
2023-12-16 20:48:57 -08:00
Shane Smiskol 3c7fcbb839 test_models: use gen_empty_fingerprint (#30752)
use gen_empty_fingerprint
old-commit-hash: d9a8846d58af2a3a9a598fcf9fb1acf89e4b54f6
2023-12-15 17:16:19 -08:00
Shane Smiskol 19572df478 Revert "test_models: check consitency between panda and openpilot for velocity (#30750)" (#30753)
This reverts commit 19c040150dcec8bfa4b70aa870ae5564739c278a.
old-commit-hash: 123ef46af3694afc30b4ec28ce8f995d9fa92cd1
2023-12-15 17:16:01 -08:00
Justin Newberry ffae1ce377 test_models: check consitency between panda and openpilot for velocity (#30750)
* sanity check on velocity

* import from there

* use raw

* just check last

* ignore body

* reduce tolerance and bump panda

* its not average anymore

* slightly higher tolerance
old-commit-hash: 1ca1cf39223557955cee58e18a418914faf472c3
2023-12-15 14:50:37 -08:00
royjr 2614ca6a20 car docs: remove outdated video link (#30737)
remove outdated link
old-commit-hash: 05d5056e8c9dff538b5a5be66022bf32c8995802
2023-12-14 20:36:33 -08:00
Shane Smiskol 0c18b556ea Use a safety param for gas interceptor (#30719)
* bump

* bump

* space

* remove from boardd

* set flag for honda to pass tests

* migrate

* Update ref_commit

* final bump

* bump cereal

* bump to master
old-commit-hash: 582743fdb5a20fbbe841aa154cf36304771d52a6
2023-12-14 16:53:22 -08:00
Justin Newberry a625ca55e7 Subaru: enable alpha longitudinal for gen1 cars (#30714)
* enable alpha long

* update docs

* added footnote about eyesight

* only for these cars

* add alpha

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5f24078a480c9436ce99bf19358b5737aebf065f
2023-12-13 20:17:33 -08:00
Jason Wen 5e9c22e051 Hyundai CAN-FD: Panda safety config assignments cleanup (#29733)
* Hyundai CAN-FD: Interface small cleanup

* some more

* Do this too

* fix

* cleaner

* use flag

* consolidate

* do it there

* Fix

* hda2 only

* cleaner

* default to False

* in another PR

* lint
old-commit-hash: 8009b11516fdedd964716a414dcefc996dea807a
2023-12-13 20:15:25 -08:00
Harald Schäfer 2d7a222239 Ford: radar + long control fixups (#28948)
* enable radar

* manual new track

* Don't filter points

* cleanup

* Update radar_interface.py

* This is non-zero in stock

* add speed

* more extreme

* A few more things

* fixes

* cleanup

* revert that

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8c25741e468b7cb11a59c8905c9d00d5612b9143
2023-12-13 19:54:06 -08:00
Isaac d5b4ba8239 Ford: Add Mach-E (#30691)
* Update interface.py

* Update values.py

* Update routes.py

* Update override.yaml

* Update selfdrive/car/ford/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update interface.py

* order

* only have dongles for these

42f08a29af3699f4
83a4e056c7072678

from https://github.com/commaai/openpilot/pull/30444

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 26a67641d2e4a4b908239996c7a9b580c3813d4b
2023-12-13 09:05:41 -08:00
Jason Wen 82747c42a1 Hyundai: Car Port for Staria 2023 (#30672)
* Hyundai: Car Port for Staria 2023

* camera scc!

* add test route

* Update RELEASES.md

* Apply suggestions from code review

* bump down max torque

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: d6465e39bd74591d82d9a8c673052f656ed62516
2023-12-13 08:23:10 -08:00
Shane Smiskol 197571344e Car docs: fixes (#30710)
* always lower case

* more fixes

* link

* rm ()
old-commit-hash: c4759c0a5008b33c2b772a2b2ad27c5d05d50d77
2023-12-12 20:41:43 -08:00
Shane Smiskol eb642a1704 Ford: consolidate comments about unsupported hybrid platforms (#30709)
* fix typo, move comments to one place

* -appear

* Update selfdrive/car/ford/carstate.py
old-commit-hash: 77066a226068ea933b565b9521c26a99c72e7a6a
2023-12-12 20:37:37 -08:00
Isaac 390e75b3bd Ford: Add F-150 Lightning (#30692)
* Update interface.py

* Update values.py

* Update routes.py

* Update override.yaml

* Update values.py

* Update interface.py

* Update selfdrive/car/ford/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2192cc170c3231186704b0929e1ee81d318e940e
2023-12-12 20:07:59 -08:00
Justin Newberry ff8521a32e cleanup car port docs (#30707)
readme
old-commit-hash: 5d80858a16cfc1ab36f16ac3ed464eb6010c68a4
2023-12-12 18:17:10 -08:00
Justin Newberry 4472679994 add car porting docs (#30704)
* add car porting docs

* add cabana

* absolute link

* absolute link

* absolute link

* selfdrive/car
old-commit-hash: 595041ffc0a2fd8ab6eb09e366d7cd4ddd262781
2023-12-12 16:40:21 -08:00
Jason Young 736b903c7c VW MQB: Add FW for 2020 Škoda Superb (#30699)
old-commit-hash: aaff6aebcaf3bece8ae741d3e12abf764bf635c5
2023-12-12 10:57:12 -08:00
Rabin Karki 307aa120b9 HKG: Add FW Versions for Kia Carnival 2022 (#30677)
* HKG: Add FW Versions for Kia Carnival 2022

* 2022

* should

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a03a931737fed35f4ff203236039d1ccc4c7de96
2023-12-12 00:52:36 -08:00
Shane Smiskol 4c47510e55 Revert "2022"
This reverts commit bb190fb973706782f5dbf0ecb1e2992c4a96bf73.

old-commit-hash: fc0daa9693361b51e787500e8e40f0cdffc44737
2023-12-12 00:51:05 -08:00
Shane Smiskol 92dc6ca1ba 2022
old-commit-hash: ad0a882c1ced9f03abd3f85b40dca6fb3262a8dc
2023-12-12 00:50:42 -08:00
Shane Smiskol b11fbd5e47 Ford: add CAN FD harness info (#30698)
* add correct harness to f150 and angled mount

* can remove this
old-commit-hash: 1c011e6024527b9e2b311fbe48485e6d424f8bca
2023-12-12 00:45:13 -08:00
Shane Smiskol 4596da1508 Revert "FW query timing test: mock get_data function for timeout" (#30696)
Revert "FW query timing test: mock get_data function for timeout (#29712)"

This reverts commit 3014e27e57cf3a281eac656391615299ba981958.
old-commit-hash: b1ecfd55ce73062f297a5ea7d99d0c55d57c58ab
2023-12-11 22:12:21 -08:00
Jason Wen 35c0b199a5 HKG: Car Port for Kia Niro Plug-in Hybrid 2022 (#30576)
* HKG: Car Port for Kia Niro Plug-in Hybrid 2022

* Update CARS.md and add test route

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9807bd99dbc526ba92bb68c503d5108b9f892dd1
2023-12-11 20:32:36 -08:00
Sparkguys 3a333e1a66 Update values.py for VW Passat MK8 (#30646)
Update values.py

Added FW for Passat MK8
old-commit-hash: d2583d64f0ce997bdc7413f091f794ac3d704d4b
2023-12-11 19:25:55 -08:00
Justin Newberry 05a6da6e96 FW query timing test: mock get_data function for timeout (#29712)
* use a mock function to simulate timeout

* Cleanup

* Cleanup

* clean refs

* tolerance can also go down

* fix

* better name

revert refs

* use unittest

* revert

* Revert "use unittest"

This reverts commit 7a1d6a6fc72fa129a66590e0e5998c2438ecbe55.

* order

* local

* use a context

* revert

* stress test it

* let's try

* it's consistent

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 4028cb6121ffd1f92463cfc109593b17abe3aa8c
2023-12-11 19:24:01 -08:00
Lukejb14 64d1835db7 Add 2021 Mazda CX-5 engine fingerprint (#30616)
old-commit-hash: 76c53e4742850966906b1ba10e5faf7b457503fc
2023-12-11 15:41:51 -08:00
Jason Wen eaae93109b Hyundai CAN-FD Longitudinal: Enable for ICE camera-SCC cars (non-HDA2) (#30034)
* Hyundai CAN-FD Longitudinal: Enable for all camera-based SCC platforms (non-HDA2)

* allow ice camera scc longitudinal

* allow ice camera scc longitudinal

* Update docs

* Merge commaai#30021

* Update CARS.md

* revert unrelated changes

* add test route

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 63bf098017c89a09f79059647deb90d1960f720d
2023-12-09 17:36:34 -08:00
Shane Smiskol 8119ba7c1a Volkswagen: update MY for Tiguan
old-commit-hash: b3908e3c82f53ab998bdbef34a005d0a699c7448
2023-12-09 15:05:06 -08:00
hodgiers 43dc2d6956 Volkswagen: Tiguan R-Line 2024 Fingerprint (#30605)
* Update values.py

2024 Tiguan R Line

* Update values.py

Removed extraneous text

* already here

* Update values.py

Updating model year for Volkswagen Tiguan to include 2024.

* Update values.py

Correcting Tiguan fingerprint values

* Apply suggestions from code review

* Update selfdrive/car/volkswagen/values.py

---------

Co-authored-by: Hodge <rhodge@Hodge-MBP.local>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: dd034bbfb7db198d07c05d927b60b0ceba453ea4
2023-12-09 15:04:27 -08:00
hanyiabc e7ee874dbd Added fingerprint for 22 Kia Stinger KIA_STINGER_2022 (#30589)
* added fingerprint for my 22 kia stinger

* Apply suggestions from code review

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5051ff0b84845cbbacd31927461eac82fba90142
2023-12-09 14:46:40 -08:00
TerryWloch e83d54c66a VW: add missing FW for Skoda Kodiaq 2017 (#30665)
* Update values.py

Added FingerPrint for my Skoda Kodiaq 2017 14. tsi DSG 4x4

* Apply suggestions from code review

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6d9629b0e11e6d36b71530e7dbd1475acb30e280
2023-12-09 14:35:15 -08:00
Shane Smiskol e46c20ac61 test_models: randomize internal segment list (#30653)
* randomize internal seg list segments

* random

* pytest-randomly sets random.seed to a consistent value for all the workers/processes

* noeol

* update

* Revert "update"

This reverts commit aff9a69c4e5e3934deebaa33986b42f44b55b002.

* lock

* don't randomize by default

* remove random-order

* strict

* random

* one fix

* test

* does nothing

* rm tests

* Revert "rm tests"

This reverts commit b548e3fcd48e60538695506888d863c01b459d27.

* (can't repro locally) just athena should be fine

* bs1

* bs2

* bs3

* bs4

* bs5

* wrong way

* no controls

* no car

* no board

* controls?

* crazy -common

* Revert "crazy -common"

This reverts commit 02365d712b3d09cab1893cce2261a4b418bb3851.

* test athena

* test athena 2

* test athena 3

* test athena 4

* test athena 5

* test athena 6

* test athena 7

* test athena 8

* test athena 9

* ??

* in one commit

* common?

* car and board

* -controls -board

* random-order

* no board

* revert

* car/tests

* least likely

* try

* try 2

* draft

* draft

* so much better

* cmt

* use randomly

* not needed here

* directly modify option works

* bb

* test time

* Revert "test time"

This reverts commit 2c5caabe2b470b47b7322e37800680b92773fccc.

* tmut

* i concur

* revert
old-commit-hash: ac83318ac4f54c46deef02c69d46c549bd741cb3
2023-12-09 14:28:32 -08:00
Shane Smiskol 81cc8a561a Toyota: enable LTA (#30109)
* bump panda

* enable lta

* try upper/lower delay similar to longcontrol lag comp

* add comment about eps torque rate limits

* more clear

* more clear

* Revert "try upper/lower delay similar to longcontrol lag comp"

This reverts commit 8e85333ee6e2456fcda076af4c31a9e9babbc897.

* bump

* no driver torque limiting to test

* fix the setme_x3

* bump

* bump

* enable inactive safety

* use vEgoRaw

* rename

* fix

* some comments/organization

* bump

* docs

* no corolla

* shorter name

* bump

* bump

* add to releases

* bump panda

* remove camry

* bump

* bump

* rm

* bump

* bump

* bump again

* bump
old-commit-hash: bf4026ed7e55866e1a27f5aee277fbdbeb4853cd
2023-12-08 15:31:10 -08:00
Shane Smiskol 3ec8a2f852 Ford: add Explorer 2020 FW (#30638)
* 49cead668ca2ac46

* docs

* b18d8435f1460528
old-commit-hash: 49317e390351f702bfe95a0400fef479d389007f
2023-12-07 16:37:59 -08:00
Shane Smiskol eb622a85d1 Ford: add Explorer 2023 FW (#30637)
* 49cead668ca2ac46

* docs
old-commit-hash: 1cd7b04e6ffb97018159c1fef930622bb0b77054
2023-12-07 11:37:18 -08:00
Adeeb Shihadeh 59eb2988de swaglog.py goes in common/ (#30631)
* swaglog.py goes in common/

* all of these go in release

* we'll even include the pyx
old-commit-hash: 35f819c8239b8ac3a000087a0f791b91ccea5e5e
2023-12-06 17:27:51 -08:00
Justin Newberry 62d0647ab3 pytest: group test_models by route instead of car name (#30625)
* group by route

* dont need those
old-commit-hash: f16df8e4b7901f5e38b6f90a8900eef02faab504
2023-12-06 16:00:59 -08:00
Shane Smiskol 8dd6c7d4b1 Toyota: LTA unit test (#30613)
LTA unit test
old-commit-hash: 67d6186bbd5b19269162453a6028cabd6a2fabfc
2023-12-05 19:24:28 -08:00
Shane Smiskol baeaa2f730 Toyota: rename LTA torque wind down signal (#30603)
* bump

* rename

* bump
old-commit-hash: 3fed87dbb701c263f38d64a29f7bbf186ad25e39
2023-12-04 21:16:12 -08:00
Shane Smiskol ad5ae03be1 Toyota: LTA cleanup (#30579)
* have been running this for a few weeks: good

* set setme_x3 closer to stock

* add comment to values about additional EPS torque rate safety

* rename some variables

* should use vEgoRaw here to match panda!

* switch

* more notes

* specify

* smaller

* for

* oof
old-commit-hash: 54517c0638c99b7a40b146376def1ac324d07074
2023-12-01 22:27:29 -08:00