Commit Graph

117 Commits

Author SHA1 Message Date
Adeeb Shihadeh 6c2182c026 Newer sounds (#23091)
* new prompt sound

* padding

* prompt distracted

* debug

* fix spelling

* lower min volume

* better volume at low speeds

* revert debug

* revert that

* fix tests

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 3b367e68728c29eea057d99f3948d64ed6cbfa92
2021-12-02 00:28:25 -08:00
Adeeb Shihadeh dccb8b4010 New sounds (#22652)
* new engage/disengage + amp config

* first family

* cleanup audible alerts

* tici isn't special

* fix up debug cycle alerts

* these were better

* extend range

* use distracted sound

* log scaling

* getting closer

* slightly louder

* prompt

* update tests

* update refs

* fix c2 test

* resolve todo

* adjust tolerance

* revert for now

* should work

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e679d05d9e98e267047c21c0b6b67fe9d61f8ed6
2021-11-30 19:47:33 -08:00
Adeeb Shihadeh 1ffe047666 improve crc camera error (#22943)
old-commit-hash: 5296ca8d73573a59a5198b73770d2a4f20cbc9c2
2021-11-16 22:57:22 -08:00
Adeeb Shihadeh d1eacc4619 alerts: make soft disables an orange alert (#22925)
old-commit-hash: 833399e9418db26df70169d37c2dff90051d89c7
2021-11-16 13:11:32 -08:00
Adeeb Shihadeh 9f84f9ad97 put cruiseMismatch event in logging only mode
old-commit-hash: 33022390138df73199ac626cb7b5ab7fac1a89a6
2021-11-15 21:16:54 -08:00
Adeeb Shihadeh ee15159a3b alert cleanup (#22919)
old-commit-hash: 5265c36de7be6a2519488fa4a46462f13918b1fb
2021-11-15 16:14:31 -08:00
Adeeb Shihadeh 731d85c522 alerts: use repeating warning2 sound for steerSaturated (#22874)
old-commit-hash: 308219c5b1850da4e947ea587e131df29024a402
2021-11-11 11:55:34 -08:00
Adeeb Shihadeh a142638899 increase engagement alerts duration
old-commit-hash: 327464fb845dd01533f390ac89d9fd78fbfb02d7
2021-11-10 22:11:14 -08:00
Adeeb Shihadeh d6c42f11f4 controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
old-commit-hash: 035bc0c20fd27490cc353a33f3c373201288a10a
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh 448d5f9e93 alerts: use a single duration for sound, text, and HUD (#22856)
* alerts: use a single duration for sound, text, and HUD

* little cleanup

* update refs
old-commit-hash: c5d6b85c9014386b8d1cb2a17f8767abef3afd57
2021-11-10 11:54:12 -08:00
Adeeb Shihadeh 450471058b controlsd: optimize alert management (#22846)
* controlsd: optimize alert management

* little cleanup

* dataclass is nice

* fix tests

* update refs

* sort by start frame

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 93ba52c76c20baf36e07c25d28a98bc8e9ea6219
2021-11-10 10:54:18 -08:00
Adeeb Shihadeh da7cd6bbaa soundd: don't loop controls unresponsive sound infinitely (#22839)
* soundd: don't loop controls unresponsive sound infinitely

* update tests

* actually fix
old-commit-hash: 445a5aaca4431962d189cc3e54da2d5cd13d0aac
2021-11-09 16:58:21 -08:00
Mayfield 18ff2f5cbd alerts: show min enable speed in "speed too low" alert (#22755)
* alerts: show min enable speed in "speed too low" alert

* commonize display speed construction
old-commit-hash: 8c501f026581c5690e5f3b253198cd0a13dc1cc3
2021-11-02 14:10:07 +01:00
Adeeb Shihadeh d2a6eeae42 lower profile below steer speed alert (#22740)
old-commit-hash: 3312bf6d15ebe16ca21229c2387617d7048ab132
2021-10-29 13:39:12 -07:00
Adeeb Shihadeh 01043f505a more specific no fw startup alert
old-commit-hash: 897492d27c416b1b8f70fee00de5e4db8c168ba8
2021-10-21 16:24:01 -07:00
Willem Melching 11066c6236 Split pandaState into peripheralState and pandaState (#22385)
* publish peripheralState from boardd

* refactor consumers

* rename thread

* peripheralState has panda type too

* add to process replay

* fix device build

* properly remove hardware unsupported alert

* latest peripheralState

* remove pandaState from thermal_monitor

* put that back

* add back harness check

* fix cloudlog

* needs pandaState

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* dont conflate

* Update selfdrive/thermald/tests/test_power_monitoring.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* pigeon is peripheral

* cleanup

* less global

* comment

* move rtc to peripheral_control_thread

* better diff?

* whitespace

* get msg

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f4e2537b124d3d1c0d697a12d8b243b54b76501b
2021-10-04 11:30:11 +02:00
Adeeb Shihadeh 18097d7c06 change reverse gear event from immediate to user disable (#22337)
old-commit-hash: 2fe91e6085072db547c34bb603da1164aac6a1fe
2021-09-24 10:27:51 -07:00
Willem Melching b3601ce43b Remove fuzzy fingerprint startup alert (#22328)
* deprecate fuzzy fingerprint startup alert

* bump cereal
old-commit-hash: 88d248a5af55a5b184b313e3c3223edd77461db9
2021-09-23 17:15:33 -07:00
Adeeb Shihadeh 7fc6a76f04 reduce startup alert duration to 10s (#22163)
* reduce startup alert duration to 10s

* update refs

* update refs

* update refs
old-commit-hash: 1c750975fc179185b270f2063831431538d075d8
2021-09-07 13:40:31 -07:00
Adeeb Shihadeh ac8b08fa0c alert for per-core cpu usage (#21983)
* thermald: per-core cpu usage

* add alert

* better alert text

* list

* fix process replay
old-commit-hash: fc8b571a847f1a89abb331eef8f85f310453fd77
2021-08-19 19:14:51 -07:00
HaraldSchafer e13349366e Remove HUD alert from green DM alert (#21942)
old-commit-hash: c0cacc7d2f30b18f1a19eb3b508a62ba4e2f0121
2021-08-16 22:30:51 -07:00
HaraldSchafer b615987244 Cleaner lane change alerts (#21857)
* less is more

* small

* remove HUD warnings

* update ref

* safe

* update refs

* update again

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aa689176fc84e57f16a4fe9f1769e76fb8effc46
2021-08-05 14:23:27 -07:00
Adeeb Shihadeh eb8a334bfc remove alert for stock fcw (#21834)
old-commit-hash: fb028041cd895765a1c0dd88ba6cdf145477a005
2021-08-02 21:59:03 -07:00
HaraldSchafer d1c5e054d0 Better localizer unstable alert (#21660)
* use canonical language

* filter out when gps signal is flaky

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 049a1bca34c74ea1fae473386e8bea62f1b3041c
2021-07-20 19:20:00 -07:00
Adeeb Shihadeh 4b79c86b5f fix unnecessary harsh steering unavailable alerts (#21541)
old-commit-hash: 092c728e766bc17a63279b42ea88a4f0f1c51a6d
2021-07-10 01:53:14 -07:00
HaraldSchafer 098d939428 Remove DM high std alert (#21501)
* cleaner

* no face and high stds is the same

* change test

* final clean

* need to deprecate
old-commit-hash: 2aadf8beb2d69145d182c9e95105d29590935983
2021-07-07 17:08:55 -07:00
Adeeb Shihadeh 2293b4bcae update speedTooHigh alert sound (#21484)
old-commit-hash: 8dce135279c846a5f960e3d30dfe0afcc3f9ed0b
2021-07-04 19:23:09 -07:00
Adeeb Shihadeh b449a2a7d9 fix warning -> userPrompt
old-commit-hash: 8e36a7d07c29ecfb265cdf3218a2ae2402fbfa13
2021-06-28 21:46:26 -07:00
Adeeb Shihadeh 2c3d136d32 make speed too high alert orange
old-commit-hash: 880435f6a28cd30a45e37f09f2e493a32c0de618
2021-06-28 21:42:25 -07:00
Chris McCammon e8904916a6 steer unavailable below speed audible alert (#21209)
old-commit-hash: 317afa335f16deae21b6613203f8d92a31928a23
2021-06-17 14:10:24 -07:00
ShaneSmiskol 23ea456f4f Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
old-commit-hash: ae77f693a26527ffbee044f852cc4185718c2433
2021-06-11 14:33:17 -07:00
Willem Melching eb0fdfecf1 Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: ec17fad41a851369383173530bdaa3dfbfc1c671
2021-06-09 10:58:01 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh 5dfc430d47 startup alert for no fw returned (#21177)
old-commit-hash: d4ab1f1e274bc5e36b47fb9e6f76a977e04d1f1a
2021-06-07 14:15:09 -07:00
speedking456 2bcc0c0ada Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
old-commit-hash: 24b6b4a341bbd02551756b3e0fd5ba2120e66eef
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh e7cb6f6512 bump cereal
old-commit-hash: f2a9b134980e5ef7af86da71a13f01f2b23d017f
2021-06-04 16:06:57 -07:00
HaraldSchafer f0f36a0a06 Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
old-commit-hash: 1c926d23da0c73ceb246ca6d61db6ed1c48a1ab9
2021-06-03 09:26:53 -07:00
Adeeb Shihadeh 41f8f5c7ce per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
old-commit-hash: 12ed986333856086c774b3142659dfbaecdf654b
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh 340a080c3b alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2defc730db18f7f9c0b08b0c8b0f6806cc513ac4
2021-05-19 21:28:16 -07:00
Adeeb Shihadeh 3fbeb1299e boardd: set can and pandaState valid flags (#20899)
* boardd: set can and pandaState valid flags

* add event

* bump cereal

* consistency
old-commit-hash: e694f0b4d6f8cfe55e2c8d36a78cf86fe0c86f1a
2021-05-14 21:26:02 -07:00
Willem Melching 523c00acdc Improve community feature alert text (#20803)
old-commit-hash: b38e57eb2b1c5b6b438fb238b1752f40b4a9e188
2021-05-03 11:59:01 +02:00
Adeeb Shihadeh ec7913cbe5 delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f9a961f6fb69f36f8a113246920b2d71e6af8ae1
2021-04-30 13:55:17 -07:00
Adeeb Shihadeh cc29fdfed2 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
old-commit-hash: 836668f1050e1dbc185af7d472e2016627711aeb
2021-04-20 21:01:28 -07:00
Willem Melching ee0e80a6d4 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
old-commit-hash: e4f73fbda5c2dd07cbb15816ac1bf30b010408fe
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh 99b2c0d024 Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
old-commit-hash: 2fa1b2572dfb63e367cfe2868da576090b227ca4
2021-04-07 12:18:58 -07:00
Adeeb Shihadeh 092db4eadc show persistent dashcam mode alert (#20483)
* always show dashcam mode alert

* show persistent dashcam mode alert

* lowest

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 367aec54d1c4c5ed8d3f651d0b2f8b80fb0ac0e5
2021-03-25 21:37:38 -07:00
Willem Melching f1dc58a5f6 make vehicleModelInvalid a NoEntry
old-commit-hash: 2ca5bf99920dd20162957f1897b461e6db746444
2021-03-15 12:15:27 +01:00
HaraldSchafer 7b243b8747 Better high speed alert message (#20322)
old-commit-hash: 0223578461bd30ef3a388891ede60c8e0d01cf8d
2021-03-11 17:01:29 -08:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Adeeb Shihadeh 966945880b Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
old-commit-hash: 000bd226aa9902da01e6010bf26762fca2c20df0
2021-02-03 19:57:30 -08:00