Commit Graph

792 Commits

Author SHA1 Message Date
Shane Smiskol bbed3a961a Events: actionable accFaulted alert text (#26783)
same alert text as steer and brake unavailable
old-commit-hash: 9e9600a4f4fb69dd99cc24b791ccdd62540348f1
2022-12-13 00:16:36 -08:00
Adeeb Shihadeh 69f6d32678 controlsd: add blinkers to carControl (#26773)
* controlsd: add blinkers to carControl

* not actuators

* update refs
old-commit-hash: 151e0d8c39234f44e00ecf69fcd0cbe01b2b910c
2022-12-12 14:03:09 -08:00
Shane Smiskol e13e373bfb alert: smaller standstill alert (#26751)
smaller standstill alert
old-commit-hash: 2545dd195efc164da9561ae9ae2115482eb9f931
2022-12-09 23:30:41 -08:00
Shane Smiskol a98e7d49cc LatControlAngle: fix setting saturation check speed (#26752)
set in init function
old-commit-hash: 84340f07abdef408f3fa29083af2f1a55cd3308e
2022-12-09 23:29:56 -08:00
Shane Smiskol de8ddbb73f LatControlAngle: lower saturation check speed (#26749)
lower speed for angle
old-commit-hash: d5ffb90a048d9a6d727e723e3551d5333abddef7
2022-12-09 21:43:55 -08:00
Shane Smiskol 333464b3d3 controlsd: set steer_limited for angle cars (#26748)
* Set steer limited for angle cars

* closer to torque threshold
old-commit-hash: c1b3d696bc5bdd799a937f569c94e0834230c89e
2022-12-09 21:43:27 -08:00
Shane Smiskol 883be4410f LatControl: remove duplicate logic for saturation (#26725)
this is already checked
old-commit-hash: d97336d5326190559d1ff0518daee273f270aaf8
2022-12-08 03:01:57 -08:00
Shane Smiskol 7a2dc6eca5 Longitudinal tests: clean up (#26708)
* refactor test_cruise_speed.py

* clean up long tests

* and here
old-commit-hash: 9ea72b655035ee9f96c60c3268049bba6b8b9e1a
2022-12-05 17:34:57 -08:00
Shane Smiskol 4bf3cebb21 planner: read experimental mode from controlsState (#26553)
read from controlsState
old-commit-hash: e6fcc2d6aa582f90fd3a2b2192616005f875fcb2
2022-12-05 13:58:15 -08:00
Shane Smiskol 634a6c9802 Deprecate noTarget event (#26638)
deprecate notarget
old-commit-hash: 5409895ab2668284df7b688ce513fa0ef1e57be2
2022-11-30 02:32:47 -08:00
Shane Smiskol 3d161c4d42 controls: remove noTarget event (#26632)
remove noTarget alert
old-commit-hash: 41610fe8ae7019264f09fbbb5db64e48b45b7ca0
2022-11-29 23:12:58 -08:00
Shane Smiskol d1dee4625a controlsd: preEnable on brake at a standstill (#26273)
* pre-enable on brake at standstill

* test by getting rid of noTarget

* Update events.py

* rename

* stash what we got so far

* cmt

* not sure if best way to fix, but enabled with current states defs is fine

* no noEntry in preEnabled

* bumpcereal

* uncomment

* Update ref_commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dbe512d167a51f02fe276e17a8794de2137d0e14
2022-11-29 17:34:10 -08:00
Shane Smiskol 76e7a45284 controls: preEnabled doesn't consider noEntry (#26627)
preEnabled doesn't consider noEntry
old-commit-hash: 8ad8d4e1c2887bcd22ab7048960ed6a1a7f8e3f6
2022-11-29 13:11:03 -08:00
Vivek Aithal 238e63bc2a [controlsd] Refactor apply_deadzone in Lateral Torque Control (#26626)
rename apply_slack to apply_center_deadzone, remove unused prius offline values
old-commit-hash: 3a4f19f0ee454a9c8d7c55d66e794ef20c4b4f01
2022-11-29 12:46:08 -08:00
Vivek Aithal 5bc529bf20 [controlsd] Toyota Prius 2017 (#26455)
* increase lag on prius

* better offline values computation

* split prius ecu more, set deadzone to 0

* add deadzone back

* replace deadzone with slack

* reduce deadzone to 0.2

* update refs
old-commit-hash: 0706b03e8cf41f7d51c9a42f01bda2084bfe3be6
2022-11-29 10:47:13 -08:00
Shane Smiskol bcdbd8edb9 Toyota: alert when in standstill (#26585)
* add resume required alert

* possibly need this (pressing resume with brake held does nothing)

* better text (has both meanings)

* try this

* Revert "try this"

This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.

* no alert with interceptor

* check long
old-commit-hash: 3253b8590002fa5f56e003add3f5f47a21870873
2022-11-25 16:00:58 -08:00
Shane Smiskol db8028fa63 longcontrol: ignore cruise standstill if interceptor (#26597)
* ignore standstill

* cmt

* standstill

* rm cmt

* flip
old-commit-hash: a19b5b91d2bcc0cd405599193828b9e9e187c52e
2022-11-24 18:17:36 -08:00
Adeeb Shihadeh 4f7bfc430a process replay: support old routes with no peripheralState
old-commit-hash: 7361d1a11b21cc6482ed9ba8e5505b88081b66f6
2022-11-22 11:46:28 -08:00
Adeeb Shihadeh 7c96e7876a cleanup panda types everywhere (#26574)
* cleanup panda types everywhere

* one more
old-commit-hash: 65fa87a96965000986e76604ac868891e35a86bc
2022-11-21 23:43:24 -08:00
Shane Smiskol b94dfd81c6 controlsd: add test around cruise speed gas pressed behavior (#26486)
* test

* test

* debug

* test

* test

* test

* clean up

* clean up

* add test

* stash

* clean up

* clean up

* clean up

* assert equal
old-commit-hash: 23a7a987f6ab75ebee4dd856ba0a0c179b2f90b0
2022-11-21 17:05:13 -08:00
Adeeb Shihadeh 4cb61240b3 enable experimental longitudinal control on devel (#26544)
old-commit-hash: 94aa39bdd406400ab48765d8b50f08e03ecf9eb8
2022-11-21 16:18:51 -08:00
YassineYousfi 7d5a2309a7 long_mpc: fix e2e source condition (#26546)
* fix long_mpc source param

* rm print

* add back space for formatting
old-commit-hash: ded66e6307825d9327c12145e1bc6acd2e835346
2022-11-21 15:25:23 -08:00
Adeeb Shihadeh aec5f32f3c publish experimental mode state (#26512)
* publish experimental mode state

* remove that
old-commit-hash: 9c96b21367af3dda9b193a821fe2e175a63f4176
2022-11-15 17:18:13 -08:00
Shane Smiskol 270fe5aac3 controlsd cruise speed: fix missing initial value
old-commit-hash: f15d169289c0d806a49af123678bd49b8b3ba4f1
2022-11-14 11:01:01 -08:00
Shane Smiskol a0539910bf controlsd: no speed increment if enabled on button rising edge (#26490)
* don't increment speed if we enabled on rising edge

* more realistic test
old-commit-hash: e46063086f079eff6292a32ae9aeeafa3aa523a3
2022-11-13 16:34:26 -08:00
Shane Smiskol 210e281cd4 cruise speed tests: match controlsd initialization of cruise speed (#26491)
* helper functions and fix resetting/enabling

* comment (resume not yet tested)

* make it clear how this resets

* this is fine to enable once

* same here
old-commit-hash: 3524cc7f0bbb94ccb4d6b7b0504692d23288a05f
2022-11-13 16:15:17 -08:00
Shane Smiskol 0f3aeb531c controlsd: clean up v_cruise updating (#26479)
* clean up

* clean up

* clean up
old-commit-hash: 870b79818566ab91159d23f1197183f3e6567608
2022-11-11 23:56:35 -08:00
Shane Smiskol 415152ade9 controlsd: add tests around cruise speed (#26478)
* start to add some tests

* test !pcmCruise

* test !pcmCruise

* better test

* fix pylint

* new test for making sure we adjust on falling edge of buttons
old-commit-hash: a638afb98e2b9d7844c04b1ec55c79d3274bc9b1
2022-11-11 23:11:49 -08:00
Shane Smiskol dd6f16fcfd controlsd v_cruise: fix unknown buttons (#26474)
Fix button being None
old-commit-hash: d3f971b365613329a35a3140b9418977baebd856
2022-11-11 20:10:12 -08:00
Shane Smiskol 0371e47fac controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
old-commit-hash: 76ac3d4c99df24f068aee3baedb796f65dfcca66
2022-11-11 19:43:30 -08:00
Shane Smiskol a7828e1ae3 controlsd: add cruise speed helper class (#26472)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* revert gm stuff

* revert standstill stuff

* remove

* revert that

* we can put this in here now!

* below update

* actually only used here

* one line
old-commit-hash: 811c096e6454dc2bbdd1e15a08952979c3fb7be1
2022-11-11 18:53:48 -08:00
Shane Smiskol 054cb1f8c1 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
old-commit-hash: 89b88fc7a23c393b1d74c5c74aacd5c4ee254d81
2022-11-11 14:49:38 -08:00
Shane Smiskol 400b36a57f longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
old-commit-hash: 9f80a97eee52d128559b7fef0593b8c328a6142d
2022-11-11 14:02:09 -08:00
Shane Smiskol 3fb09283a6 planner: fix undeclared variable (#26468)
* undeclared variable

* run first second disabled

* revert test

* rev
old-commit-hash: 98206fb92e6a071127f6d6e4fec456d0c437444f
2022-11-11 13:22:56 -08:00
Harald Schäfer dfd47a5f4d Add force decel to e2e long (#26448)
* add force decel to e2e

* Update longitudinal_planner.py
old-commit-hash: f23296bc87a79c59d9ab011f2ba35ed1049beb72
2022-11-11 10:46:03 -05:00
Shane Smiskol 1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7dc8e0b1ec051f00037506d23a017ae8
2022-11-10 19:06:31 -08:00
YassineYousfi b7b827bdd2 min lane change speed 20mph (#26434)
old-commit-hash: 737408066895452f31f08144c129551b94e64662
2022-11-09 22:04:57 -08:00
Adeeb Shihadeh 74979a7c76 experimental mode (#26416)
* experimental mode

* rename param

* red lights
old-commit-hash: 9a3f46805104c4bcb5cffa304b9b322874ccf412
2022-11-08 14:45:01 -08:00
Harald Schäfer f86b44d516 E2e long model: calibrate model speed to wheel speed (#26395)
* calibrate!

* Fix test

* Fix proc replay

* check len

* get v_ego from model 8501d20-bb59-4193-aa82-82b2737dedd6/449 609d90f3-65e6-4617-a60c-d6d99eead408/700

* bump cereal

* initialize v_model_error

* typo

* better names

* cleanup

* bump cereal

* update model replay ref commit

* bump to cereal master

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: f63f0de80a78ade6ad12fe98ea27094035d97457
2022-11-07 17:49:36 -08:00
Vivek Aithal 3029919422 [torqued] Fix high speed oscillations (#26338)
* modify low speed factor during high speeds and rescale friction

* update refs
old-commit-hash: e9eb5d99ff659a3f5e1b4e0bead321c469d8d889
2022-11-07 17:01:24 -08:00
Harald Schäfer f10cccb318 FCW: less false positives (#26366)
* Less FP for FCW

* enable fcw for e2e long
old-commit-hash: 253e5d7f9d7741e61f010f2ffd6b82a2e908019a
2022-11-06 12:17:07 -08:00
Harald Schäfer e20020053d Longcontrol: faster transition from starting to stopping (#26361)
* Never command accel when stopping

* Update ref_commit
old-commit-hash: a7ced7c54b86107cb4095423158e28398aa62143
2022-11-04 13:21:34 -07:00
Adeeb Shihadeh 8ec2fa1307 controlsd: steer in old preEnable state (#26269)
* controlsd: steer in old preEnable state

* bump panda

* bump panda

* Update ref_commit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6698cd48294e94fdb4e09e8943e6505efa29c5d5
2022-10-27 20:53:15 -07:00
HaraldSchafer dd03dbc344 Eliminate toyota close radar glitches causing no resume (#26272)
Eliminate toyota close radar glitches
old-commit-hash: f76a390daf677700fbce49253f93412dd44eee0d
2022-10-27 17:31:15 -07:00
HaraldSchafer 48f4c8b701 No fcw when standstill (#26252)
old-commit-hash: b80f2efdf29fb5095ea2fa258ec7695730467515
2022-10-26 14:53:01 -07:00
HaraldSchafer 742310271b Long control: add a_change cost in e2e mode (#26237)
Add e2e cost
old-commit-hash: dcde942d9fb05575dcc70f0b24f9c3c6b7c220ab
2022-10-25 16:53:24 -07:00
Greg Hogan 92014b7dbe controlsd: update is_metric live (#26228)
* fix speed increment if units changed while driving

* don't recreate params

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9091e737c8fea44158570e6e15668e30d518d4d3
2022-10-25 15:51:39 -07:00
HaraldSchafer 3b62f66008 Use same minimum speed for lateral planning and controls (#26177)
* Use same speed for lag adjustmenet

* One is a nicer number

* Update ref
old-commit-hash: 4f84b2998579a630e1577e60dd1d30d23261cd28
2022-10-20 14:34:36 -07:00
Shane Smiskol 70249fae14 Rename gmAccFaultedTemp -> accFaultedTemp
old-commit-hash: b1efdab788da77380dfd3f5765bb6cc03ccc3a77
2022-10-19 01:31:12 -07:00
HaraldSchafer 9c26b70a43 Partial revert, lax torque control (#26146)
* Closer to original

* Update ref
old-commit-hash: 1548db8962c2555b53843ec361453ece7abdbc16
2022-10-18 21:25:06 -07:00