Commit Graph

2980 Commits

Author SHA1 Message Date
Shane Smiskol bcd29a2b8a Hyundai: add PT queries for all ECUs (#31334)
* We never had any bus 0 logging queries for CAN!

* should be logging

* try all, and try on can fd as well

* update refs

* oof forgot about hda2 can fd where pt is bus 1

* sheesh

* fix the timing

* fix ref
2024-02-06 20:37:26 -08:00
Shane Smiskol 4ec0ed311c FW query timing test: fix total reference time (#31344)
* We never had any bus 0 logging queries for CAN!

* should be logging

* try all, and try on can fd as well

* update refs

* oof forgot about hda2 can fd where pt is bus 1

* sheesh

* fix the timing

* not here

* revert

* this just simply measured the total time of all the brands with aux queries (1.25s)

* clean up
2024-02-06 20:10:06 -08:00
Shane Smiskol a07259d765 HKG: mark queries as logging (#31343)
* should be logging

* fix cmt
2024-02-06 19:37:15 -08:00
Justin Newberry 66dc7030de test_models: cleanup by using new logreader (#31267)
* cleanup

* only check error

* this segment only

* fix

* fix

* keep this

* fix internal
2024-02-06 16:50:30 -08:00
gaanthony 30dd1087ea Update fingerprints.py - for 2023 Kia Sorento X-Line SX Prestige (#31286)
* Update fingerprints.py - for 2023 Kia Sorento X-Line SX Prestige

* Update fingerprints.py - fix file for unit tests

* Update fingerprints.py

trailing

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2024-02-06 16:00:24 -08:00
Tico Fortes 1185645271 Add fingerprint Hyundai Tucson Hibrid 2022 Europe (#31291) 2024-02-06 15:55:01 -08:00
Shane Smiskol d5821c6812 [bot] Fingerprints: add missing FW versions from new users (#31277)
Export fingerprints
2024-02-06 01:47:51 -08:00
dblacknc 75ea3f3e3a Add fingerprint and car info for 2021 Kia Niro PHEV (#31275)
* Add 2021 Kia Niro Plug-in Hybrid

* Added CAR.KIA_NIRO_PHEV_2021

* Added CAR.KIA_NIRO_PHEV_2021

Created new block and moved 2022 model to it as well, with correct mass and steerRatio values.

* Added 2021 Kia Niro PHEV

* Added 2021 Kia Niro PHEV

For now, using 2020 Niro EV torque data

* Update values.py

Add '21 Kia Niro PHEV to HYBRID_CAR for gas signal and DBC info

* Test route for 2021 Kia Niro PHEV

* Add public test route for 2021 Kia Niro PHEV

* Fixed typo in test route for 2021 Kia Niro PHEV

* Move '21 Kia Niro PHEV car info under '22

...and remove other mention of '21 as distinct car

* Added '21 Kia Niro PHEV fingerprint under '22

...and removed separate car definition

* Removed '21 Kia Niro PHEV as separate car, now under '22

* Removed '21 Kia Niro PHEV, now under '22 fingerprint

* Removed test route for '21 Kia Niro PHEV

* Update values.py

Missed removing one more reference to '21 Kiro Niro PHEV, consolidating under '22.

* Update selfdrive/car/hyundai/interface.py

* Update selfdrive/car/hyundai/fingerprints.py

* Apply suggestions from code review

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-02-06 01:10:10 -08:00
neverbread 769c044269 Hyundai: add FW for 2018 Elantra GT Sport (#30732)
* Update values.py

* we really gotta get fuzzy FP for these date codes

* format

* rc

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-02-06 00:56:02 -08:00
Maddog1929 90dbe61c7d Add fingerprint for 2018 Genesis G90 (#31271)
* Update fingerprints.py

* Update fingerprints.py

* Update fingerprints.py

* Update fingerprints.py

* Update fingerprints.py

* Update fingerprints.py

* Update fingerprints.py

* Update values.py

* Update values.py

* Update fingerprints.py

* Update values.py

* Update values.py

* Update fingerprints.py

changed formatting of FW value to match existing convention and removed extra FW value no longer being shown in carParam logs
2024-02-06 00:43:41 -08:00
Jason Young e6bace867e VW MQB: Add FW for 2024 Volkswagen Jetta (#30979)
* VW MQB: Add FW for 2024 Volkswagen Jetta

* update docs

* fix sorting
2024-02-06 00:42:28 -08:00
Shane Smiskol ee16eefc1a Ford: Add missing FW for Escape 2022 (#31321)
Add missing FW for a25d5d0b645d8bc3
2024-02-06 00:05:08 -08:00
Shane Smiskol dd6065c33b Reapply "Ford: don't fingerprint on engine (#31195)" part 2 (#31320)
* Reapply "Ford: don't fingerprint on engine (#31195) part 2"

This reverts commit 7694712cd6.

* add comment

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2024-02-05 23:57:46 -08:00
Shane Smiskol 618366be06 get_vin: respond to full 11-bit diagnostic address range (#31317)
* fix

* not 7df

* cleaner

* whop
2024-02-05 21:52:06 -08:00
Shane Smiskol 55cc3989d8 Ford: add ABS address to get VIN without OBD port (#31308)
* consider ford abs

* cmts

* fix

* who

* Revert "who"

This reverts commit eef45b147fab715a9f35b9712e8b9d7ebb1b2fdf.

* this doesn't work correctly

* add cmt

* fix

* Revert "fix"

This reverts commit 60dfe09c426e74293711df9e2f3b2f75cf3a1da9.
2024-02-05 21:48:57 -08:00
Shane Smiskol cd153e6376 log vin request to qlog (#31314) 2024-02-05 20:30:33 -08:00
Shane Smiskol 50a552ab8d Reapply "Ford: don't fingerprint on engine (#31195)" (#31303)
* Reapply "Ford: don't fingerprint on engine (#31195)"

This reverts commit 7694712cd6.

* don't change the queries

* revert refs
2024-02-05 14:46:34 -08:00
Shane Smiskol 7694712cd6 Revert "Ford: don't fingerprint on engine (#31195)"
This reverts commit 1d1c9936cf.
2024-02-05 01:35:39 -08:00
Shane Smiskol 81f52f2e53 car_helpers: don't log fingerprints as a dict (#31289)
Update car_helpers.py
2024-02-02 23:45:28 -08:00
Shane Smiskol 0110540300 Test car interfaces: init controllers (#31282)
* not pytest?

* copy what build release does

* test controls step with CI and lat/long controllers, car controller.update, etc

* clean up

* not needed

* not here

* here

* better cmt

* fix test_fuzzy

* see what's failing

* need conftest for OPENPILOT_PREFIX to work!

* up

* clean up

* test

* fix

* params put is slow

* stash

* Revert "stash"

This reverts commit 22cc9f814c0699f7046970763663205907f2890b.

* stash

bad

* just freaking merge

* sort

* rm
2024-02-02 23:43:30 -08:00
Shane Smiskol c9bd4e4c0d FW_QUERY_CONFIGS: type annotate (#31265)
* annotate

* fix

* clean up

* test

* clean up

* space

* fix
2024-02-01 21:01:31 -08:00
Shane Smiskol 33c93cc583 Mazda: add missing FW versions for CX9 2022 (#30725) (#31273)
* Adding CX9 engine ECU FW

* Adding cx92023 fingerprints for transmission

* add fingerprints

---------

Co-authored-by: Elshan <8066214+ekodikara@users.noreply.github.com>
Co-authored-by: Elshan <elshan.kodikara@stepglobal.com>
2024-02-01 15:22:26 -08:00
Shane Smiskol 341f8420db fw_versions: type annotate test_brand_ecu_matches (#31272)
* test this

* we
2024-02-01 15:11:10 -08:00
Vivek Aithal 619625625c CHEVROLET BOLT EUV 2022: Add a simple neural feed forward (#31266)
* add simple neural feed forward

* update refs

* do not sample during inference in op

* update refs
2024-02-01 12:30:43 -08:00
Vivek Aithal 056b330e8b LatControlTorque: Add more inputs (#31252)
* add history and state to the ff inputs

* add history

* resolve comments

* remove history, simplify

* don't compute lateral accel, roll comp always
2024-02-01 04:12:48 -08:00
Shane Smiskol f0b6f48948 Mazda: use bus 0 to fingerprint (#31261)
* for testing

* switch OBD port to logging

* revert

* cmt

* cmt

* remove OBD query

* Update selfdrive/car/mazda/values.py
2024-02-01 00:28:00 -08:00
Eric Brown 1ab3745400 GM: Fix wheel direction signals (#31258)
* Fix wheel direction signals

* Update name

* Add comment

* Remove signal value table

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* bump

* add 3

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-01-31 18:45:10 -08:00
Shane Smiskol 7222eb3665 Nissan: use bus 0 to fingerprint (#31243)
* Nissan: use bus 0 to fingerprint

* update refs

* switch OBD query to be logging instead, might want OBD logging for one more release
2024-01-31 18:20:33 -08:00
Shane Smiskol 5195f0a624 [bot] Fingerprints: add missing FW versions from new users (#31245) 2024-01-31 09:52:44 -08:00
Elshan 883f9458eb Mazda: add missing FW versions for CX9 2022 (#30725)
* Adding CX9 engine ECU FW

* Adding cx92023 fingerprints for transmission

* add fingerprints

---------

Co-authored-by: Elshan <elshan.kodikara@stepglobal.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-01-31 03:20:58 -08:00
Shane Smiskol e4e161f8de Hyundai CAN FD: enable enhanced fuzzy fingerprinting for Sorento & Sorento Hybrid (#31242)
* allow fuzzy fingerprinting

* rm todo

* better cmt
2024-01-31 00:52:49 -08:00
Shane Smiskol b4f958c13f HKG CAN FD: Merge Sorento Plug-in Hybrid and Hybrid (#31241)
* merge sorento plug-in hybrid and hybrid

* format

* allow fuzzy fingerprinting

* rm todo

* Revert "rm todo"

This reverts commit f2457eb58f88f780b25625942dbd9c74202acbb8.

* Revert "allow fuzzy fingerprinting"

This reverts commit 91f143f3115e31107752a5e84d3f587e6917933f.
2024-01-31 00:41:57 -08:00
Shane Smiskol 2f4cadc6bf Hyundai CAN FD: merge Sportage platforms (#31235)
* merge Tucson 4th gen!

* format fingerprints

* fix torque params

* fix

* detect CANFD hybrid with ACCELERATOR_ALT

* passes

* add test

* pass test

* cmt

* Revert "pass test"

This reverts commit 5f48ab1f6e6569def1cbbc92c9c0dd4ea5eebbe2.

* combine sportage hybrid

* merge sportage

* format
2024-01-31 00:19:15 -08:00
Shane Smiskol e92e856f7a Hyundai CAN FD: merge Tucson and Tucson Hybrid (#31238)
* combine tucson and tucson hybrid can fd

* format fingerprints
2024-01-30 23:06:24 -08:00
Shane Smiskol e5a8ddc3d0 Hyundai CAN FD: detect hybrid (#31237)
* detect can fd hybrid

* remove from set

* prevent EV & hybrid somehow
2024-01-30 22:43:56 -08:00
Shane Smiskol b40660692b Hyundai: use hybrid & ev flags (#31236)
* hyundai: use hybrid & ev flags

* Update ref_commit

* todo

* match order
2024-01-30 21:57:29 -08:00
Shane Smiskol 9c48e85c78 Revert "docs: fix car docs video icon" (#31234) 2024-01-30 19:04:43 -08:00
Shane Smiskol 97aa08d8de docs: fix car docs video icon (#31218)
* fix yt icon on docs.comma.ai

* bigger
2024-01-30 18:46:46 -08:00
Shane Smiskol bd1678e71f Toyota: fix rare panda standstill mismatch (#31232)
* fix

* clean up

* just use 2x lower threshold so we're not on edge again
2024-01-30 16:06:28 -08:00
Shane Smiskol 0176c870ea Fingerprints: add missing FW versions from users for Toyota, Honda, Chrysler, Mazda, Ford [bot] (#31231) 2024-01-30 13:57:52 -08:00
Harald Schäfer feaf52dd4c Ford long control improvements (#31123)
* Ford updates

* back to normal

* Small fixes

* Try max

* Does pred matter

* ref commit

* Update ref
2024-01-30 11:40:52 -08:00
Shane Smiskol c2ee072907 format fingerprints: fix empty FW versions (#31230)
fix
2024-01-30 03:07:00 -08:00
Cameron Clough 1d1c9936cf Ford: don't fingerprint on engine (#31195)
* Ford: do not fingerprint engine

* add notebook

* Ford: add missing Explorer FW

* revert

* revert

* Revert "revert"

This reverts commit ad32feaa689f2b497c8bcc9fedc73cae6c87f697.

* TestFwFingerprintTiming: try these

* TestFwFingerprintTiming: update total ref time

* remove notebook

* fix ref

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-01-30 02:42:33 -08:00
Shane Smiskol 06f0e50964 GM: FPv2 logging (#31221)
* bump

* from https://github.com/commaai/openpilot/pull/27929

* get VIN on bolt!

* might as well try on other gms

* remove vin

* ugh gm is going to be slow

* fix

* should really fix this

* revert

* happy?1

* fix unit test

* bump

* functional addressing must be an OBD gateway feature, this does nothing

* fix vin response

* fix addr!

* finally fix fw_versions bugs since boardd IsOnroad refactor

* for

* only bus 0

* clean up

* Update selfdrive/car/gm/values.py

* ChatGPT re-write

* filter out did

* todo

* oof

* preview: what multiple DIDs per ECU would look like in the future

* Revert "preview: what multiple DIDs per ECU would look like in the future"

This reverts commit 88f0d8611e638de644adc5feabade848c03d59e4.

* function to get all ecus

* we can remove this!

* can also do this!

* and this one too :o

* consistency

* yay

* clean up
2024-01-30 02:19:12 -08:00
Shane Smiskol 2c0f7b8727 FPv2: support FwQueryConfig with no FW versions (#31227)
* bump

* from https://github.com/commaai/openpilot/pull/27929

* get VIN on bolt!

* might as well try on other gms

* remove vin

* ugh gm is going to be slow

* fix

* should really fix this

* revert

* happy?1

* fix unit test

* bump

* functional addressing must be an OBD gateway feature, this does nothing

* fix vin response

* fix addr!

* finally fix fw_versions bugs since boardd IsOnroad refactor

* for

* only bus 0

* clean up

* Update selfdrive/car/gm/values.py

* ChatGPT re-write

* filter out did

* todo

* oof

* preview: what multiple DIDs per ECU would look like in the future

* Revert "preview: what multiple DIDs per ECU would look like in the future"

This reverts commit 88f0d8611e638de644adc5feabade848c03d59e4.

* function to get all ecus

* we can remove this!

* can also do this!

* and this one too :o

* consistency

* yay

* add tests

* revert GM stuff

* another PR

* reads better

* revert rest of gm

* use that

* interesting

* these are exactly the same (with ordering differences)

* Revert "these are exactly the same (with ordering differences)"

This reverts commit a9e918dc351d24f1b7c8a05c7ec402e057a0e09a.

* flip
2024-01-30 02:08:08 -08:00
Shane Smiskol c3fcf75737 GM camera ACC: get VIN from camera (#31224)
* bump

* gm vin

* that's not right

* only check relevant buses

* instead try queries for each bus first

* clean up

* use default retry in function

* all
2024-01-29 23:24:21 -08:00
Shane Smiskol 5a8686b439 fw_versions: fix params.remove 2024-01-29 22:36:29 -08:00
Shane Smiskol a4cf7745e8 fix manually running fw_versions.py (#31226) 2024-01-29 21:44:00 -08:00
Shane Smiskol 3a0033e81e vin: fix retry logging (#31225)
* retry should really be outside inner query loop

* just req

* nls

* bump

* rmnl

* useful to have

* is it though
2024-01-29 21:28:29 -08:00
Justin Newberry 54fe19206e Subaru: eps is non-essential for gen2 cars (#31220)
* eps non essential

* comment

* suggestions
2024-01-29 16:48:03 -08:00