Commit Graph

146 Commits

Author SHA1 Message Date
Justin Newberry 8ba5d660f3 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
2024-03-07 14:01:28 -08:00
Shane Smiskol 78a46ce724 car values formatting (#31747)
values formatting
2024-03-06 15:47:44 -08:00
Justin Newberry 25ccb2426c cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
2024-03-06 11:22:12 -08:00
Shane Smiskol 638aaa9e53 Platform configs: move tire stiffness into config (#31678)
* first one to open PR

* mazda

* oh it is

* fix gm car specs and create MazdaCarSpecs

* fix

* do honda

* ruff
2024-03-05 15:10:58 -08:00
Shane Smiskol eaf3332599 Revert "mazda"
This reverts commit b57d371626.
2024-03-01 21:37:29 -08:00
Shane Smiskol b57d371626 mazda 2024-03-01 21:37:09 -08:00
Justin Newberry b0eae8c1b7 platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
2024-03-01 11:31:51 -08:00
Shane Smiskol 690dc55ea2 Car flags: label static flags (#31639)
* comment, consistent source

* no caps not global

* no field

* label rest
2024-02-29 15:36:40 -08:00
Justin Newberry e122f1d749 Mazda: move to platform config (#31647)
* mazda platform config

* update ref
2024-02-29 11:14:00 -08:00
Justin Newberry d4c497d826 add CarControllerBase base class to all CarControllers (#31630)
just base class for now
2024-02-28 17:13:44 -08:00
Cameron Clough 995250ae49 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
Shane Smiskol b163c1f255 Mazda: fix potential standstill panda mismatch (#31449)
* repro mazda standstill mismatch

* fix mazda standstill mismatch

* clean up
2024-02-13 22:02:04 -08:00
Shane Smiskol 33c93cc583 Mazda: add missing FW versions for CX9 2022 (#30725) (#31273)
* Adding CX9 engine ECU FW

* Adding cx92023 fingerprints for transmission

* add fingerprints

---------

Co-authored-by: Elshan <8066214+ekodikara@users.noreply.github.com>
Co-authored-by: Elshan <elshan.kodikara@stepglobal.com>
2024-02-01 15:22:26 -08:00
Shane Smiskol f0b6f48948 Mazda: use bus 0 to fingerprint (#31261)
* for testing

* switch OBD port to logging

* revert

* cmt

* cmt

* remove OBD query

* Update selfdrive/car/mazda/values.py
2024-02-01 00:28:00 -08:00
Shane Smiskol 5195f0a624 [bot] Fingerprints: add missing FW versions from new users (#31245) 2024-01-31 09:52:44 -08:00
Elshan 883f9458eb Mazda: add missing FW versions for CX9 2022 (#30725)
* Adding CX9 engine ECU FW

* Adding cx92023 fingerprints for transmission

* add fingerprints

---------

Co-authored-by: Elshan <elshan.kodikara@stepglobal.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-01-31 03:20:58 -08:00
Justin Newberry 3d8c78d6b3 format_fingerprints: automatically sort fw fingerprints (#30819)
* Auto sort fingerprints

* add comment
2023-12-20 11:54:31 -08:00
Justin Newberry 3713e4d5ea add script to automatically format fingerprints file (#30792)
* Add script

* fix script

* fix script

* fix for subaddr

* run the script

* old style can fingerprints

* cleanup

* sort imports, make executable, fix path

* newline w/o newline

* match og can formatting

* match og formatting

* generate template once

* standard name

* less nested

* can fingerprints comments

* fix spacing

* no need for PLATFORM_TO_ENUM_NAME!

* prep for PRs

* comments for all, add honda comments

* Auto-generated fingerprint PR from fuzzy fingerprinting cars

* Revert "Auto-generated fingerprint PR from fuzzy fingerprinting cars"

This reverts commit 97bc9e3bdb9d819dcbe684ceba92ea702d40eaf0.

* even closer to original

* readd this comment

* and run script

* add to precommit

* add comments

* add comments

* add to release

* use for auto fingerprint

* disable precommit for now

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-12-20 11:18:29 -08:00
Shane Smiskol adb04b5dc5 fingerprints: fix formatting (#30814)
formatting
2023-12-19 23:47:34 -08:00
Justin Newberry 28eed156e0 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
2023-12-18 14:04:27 -08:00
Lukejb14 76c53e4742 Add 2021 Mazda CX-5 engine fingerprint (#30616) 2023-12-11 15:41:51 -08:00
Tam Chau 96eee13836 Mazda: add CX5 2022 fingerprint values (VN 2023) (#30342)
Add mazda cx5 VN 2023 values
2023-11-14 03:36:26 -08:00
Justin Newberry 6ae465e4af Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
2023-09-30 17:15:34 -07:00
Shurui Gui 0d7272ea19 Mazda: add FW versions for CX-5 2024 (#30093)
* Port CX-5 2024

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-09-29 00:59:23 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Jason Young f76ffbdbbc interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 21:06:07 -07:00
Jason Young 90c4bbe8e4 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 14:17:08 -07:00
Shane Smiskol cbfcc40571 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-10 20:30:35 -07:00
Pavel Galashin 9992f852b2 Mazda: fingerprint 2023 Mazda CX-5 Carbon Edition (#29092)
fingerprint 2023 Mazda CX-5 Carbon Edition
2023-07-31 19:51:44 -07:00
b801r 4b0cdf71f6 Fingerprint - 2020 Mazda CX-9 (#28805)
139b81648a954ae7|2023-07-04--13-46-16

VIN: JM3TCBDY7L0412945

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-10 11:07:56 +01:00
weapons eeccb09504 Mazda CX-5 2022 fingerprint (#28803)
Update values.py

Updated Mazda CX-5 2022 fingerprint for my vehicle (2023 Mazda CX-5 UAE).
2023-07-07 02:10:24 -07:00
Shane Smiskol d59172bc19 Mazda: query and log FW on bus 0 (#28569)
* mazda: query FW on bus 0

* update refs
2023-06-29 00:14:09 -07:00
Maxime Desroches e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Jafar Al-Gharaibeh 354b5be9c3 Mazda: Fix BSM detection with blinkers (#27919)
* Mazda: Fix BSM detection

Submitted-by: Samuel <samuel95_54@hotmail.com>
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* bump opendbc

* use new signals

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-06-15 20:50:21 -07:00
Shane Smiskol 024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Shane Smiskol 2e4e41a7d3 Mazda: set default steering control values (#28342)
don't crash when porting new car
2023-05-30 15:40:54 -07:00
Maxime Desroches 9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Shane Smiskol 37eb9f900c Mazda: explicitly copy signals to forward (#28244)
mazda
2023-05-20 18:25:19 -07:00
Maxime Desroches 70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
Shane Smiskol 5aebdb0ad0 Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
2023-04-18 12:22:22 -07:00
Jafar Al-Gharaibeh 97aeb83f95 Mazda: CX-9 2022, Mazda6 2018 FW (#27918)
* Mazda: CX-9 2022 FW

dongle-id: 7200177292912f30

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add mazda 6 2018 FW FP

dongle id: 0383a108994bd18b

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Samuel <samuel95_54@hotmail.com>
2023-04-17 23:11:38 -07:00
Saber422 18f49b4541 MAZDA: add missing 2018 Mazda6 wagon FW (#27863)
route name:79e2c7ffb9ae445d|2023-04-10--21-58-55--0
2023-04-10 19:10:36 -07:00
Shane Smiskol 581fd62d26 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
2023-02-26 17:32:52 -08:00
Shane Smiskol 8f5057ff2d GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
2023-02-09 15:37:39 -08:00
Adeeb Shihadeh 6fa9b555a4 rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
2023-02-02 11:38:09 -08:00
Shane Smiskol aab33b1c5f Lateral jerk unit test (#25759)
* stash

* more test

* less test

* clean test

* no angle

* add tolerance

* fix gm

fix gm

* test both

* lower some rates on hkg

* stash

* simpler

* bump panda

* Revert "bump panda"

This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.

* only torque

* make kona pass

* duplicate __init__

* move

* half clean up

* half clean up

* more clean up

* more clean up

* fix static analysis

* calculate over 0.5 seconds

* limit to max steer

* type annotation

* calc once
2022-12-15 21:52:07 -08:00
Shane Smiskol f36a3664b0 CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
2022-12-10 02:03:40 -08:00
alancyau 9c62513ffa Mazda: Add 2023 CX9 fw (#26704)
* Mazda: Add 2023 CX9 fw

DongleID: 629c4aced073d15a
Discord User: bsk#7841

* Attempt to steer below 28mph for CX9

* undo comment

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-07 16:50:14 -08:00
alancyau 47977b2c0e Mazda: Add support for 2023 CX9 in CARS.md (#26717)
* Mazda: Add support for 2023 CX9

See https://github.com/commaai/openpilot/pull/26704 for the 2023 CX9 firmware.

* update values

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-12-06 16:37:18 -08:00
Shane Smiskol 860f441e2f Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
2022-11-29 11:49:13 -08:00