Commit Graph

1837 Commits

Author SHA1 Message Date
Shane Smiskol 15383d3016 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
2022-11-13 21:13:46 -08:00
Shane Smiskol ca37d0c8cc interfaces: disable on falling edge of cancel button (#26493)
* both

* Update ref_commit
2022-11-13 20:50:28 -08:00
Shane Smiskol 65f494d845 GM: handle run-away set speed (#26480)
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04fca25e6a1bac889e44afac6430d5ad7c30.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6900e0f0470f14ed55e7846e4b1d570826.

* fix

* bump

* fix that

* Bump to master

* fix fix
2022-11-12 02:02:30 -08:00
Shane Smiskol 76ac3d4c99 controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
2022-11-11 19:43:30 -08:00
Jason Wen f6189b3235 HKG: Bump Kia Telluride support to 2022 (#26467) 2022-11-11 11:40:21 -08:00
Shane Smiskol 74b6e22a7d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
2022-11-10 19:06:31 -08:00
Nelson Chen d3122cc77e Toyota: add missing engine FW for RAV4H_TSS2 (#26432)
"rav4 hybrid xse 2020"

From Rogrhoa#2158 on Discord.

Example Route: 64edc30d23cad8cb|2022-11-09--20-02-03
2022-11-09 19:59:12 -08:00
Shane Smiskol e1001a3036 Toyota: factor on cluster speed to match dash (#26408)
* add a minimum factort

* Update ref_commit
2022-11-09 18:27:30 -08:00
AlexandreSato 52378c97ec Toyota: Add missing Corolla Cross FW verions (#26426)
* add geraldo fingerprint

* add to non-H

* Update selfdrive/car/tests/routes.py

* Update non-us cross model years

* add test route

* Update routes.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-09 16:06:36 -08:00
Shane Smiskol 048cce2149 Hyundai: add missing Sonata 2022 FW versions (#26428)
* Added FW Versions for 2022 Elantra and 2022 Sonata. 

Added for CAR.ELANTRA_2021 :

Ecu.transmission :  b’\xf1\x87CXMQFM3421815JB2ww\x96y\xaa\x98x\x87\x88wtwTfuwWh\x9f\xff\x8a\xff\xff\xffE\xe3\xf1\x89HT6VA640A1\xf1\x82CCN0N20NS5\x00\x00\x00\x00\x00\x00'

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x82CNDWD0AMFCXCSG8A'


Added for CAR.SONATA :

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x81HM6M1_0a0_J10'

Ecu.transmission: 
b'\xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x81T02832A1  \xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x82VDN8T25XXX832NS8'

* Update values.py

* Removed FW Versions for Elantra_2021.

* fix

Co-authored-by: humza2000 <111622889+humza2000@users.noreply.github.com>
2022-11-09 16:04:19 -08:00
Shane Smiskol 0ca9d1810c interrfaces: more complete PID tests (#26422)
* more complete PID tests

* doesn't need to be fancy

* less fancy
2022-11-09 12:10:08 -08:00
Vivek Aithal c64e2c228a [controlsd] Toyota Rav4 TSS2 bugfix (#26421)
bugfix toyota rav4 pid init values
2022-11-09 12:09:55 -08:00
Jason Young 34f580e75e VW PQ: Fix exception with openpilot longitudinal (#26417)
* VW PQ: Fix exception in long control

* move default value to init
2022-11-09 01:55:37 -08:00
Shane Smiskol 191b8081b2 GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
2022-11-08 20:52:35 -08:00
Shane Smiskol 52a644e656 Toyota: add hysteresis to cluster speed (#26386)
* add hysteresis to cluster speed

* add minimum cluster scaling

* fix

* Update ref_commit
2022-11-08 00:03:23 -08:00
Jason Wen d62cdc400c HKG: Car Port for Genesis GV70 2022 (#26373)
* HKG: Car Port for Genesis GV70 2023 thanks to @zunichky!

Co-authored-by: kyle zunich <zunichky@msu.edu>

* Update docs

* Update selfdrive/car/hyundai/values.py

* GV70 does radar SCC, separate them

* One more

* bump panda

* Gate 0x1A0 away from bus 6

* Can't leave out the OG

* EV6 non-HDA2 too?

* bump panda

* bump panda

* Check 0x1a0 based on param

* bump panda

* bump panda

* bit simpler

* fix bit op

* fixes

* bump panda to master

* cmt

* flip

Co-authored-by: kyle zunich <zunichky@msu.edu>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-07 23:03:36 -08:00
Vivek Aithal a0edd05bb0 [controlsd] Revert Rav4 TSS2 to PID control (#26403)
* revert rav4 tss2 to pid control

* Update interface.py
2022-11-07 18:25:39 -08:00
Vivek Aithal e9eb5d99ff [torqued] Fix high speed oscillations (#26338)
* modify low speed factor during high speeds and rescale friction

* update refs
2022-11-07 17:01:24 -08:00
Jason Wen 1b6e37daa6 Hyundai: update Ioniq 5 HDA I supported model years (#26376)
* Hyundai: Add FW for 2023 Ioniq 5 HDA2

* Update values.py

* Update CARS.md

* Update values.py

* Update CARS.md
2022-11-07 16:51:32 -08:00
brownspaceman ea813a9a7d Subaru: add missing engine FW for 2019 Impreza (#26385)
added fw for 2019 subaru impreza
2022-11-07 16:48:54 -08:00
Alen 1fe45ab3c5 Kia EV6: Add EU fwdCamera firmware (#26398) 2022-11-07 14:07:40 -08:00
Jason Wen e4342b5e16 Hyundai CAN-FD: support 2023 Kia Sportage & 2022 Hyundai Santa Cruz (#25434)
* Hyundai: Car Port for Santa Cruz 2022

* bump opendbc

* New struct and params for CAN-FD ICE models

* fixup! New struct and params for CAN-FD ICE models

* bump panda

* bump panda

* HKG: Car Port for Sportage 2023

* fixup! HKG: Car Port for Sportage 2023

* Kia Sportage 2023: Add FW versions

* Longitudinal Control: ICE CAN-FD models

* fixup! Longitudinal Control: ICE CAN-FD models

* bump panda

* fixup! Longitudinal Control: ICE CAN-FD models

* Update car info

* fixup! Longitudinal Control: ICE CAN-FD models

* Gate radar disable behind HDA2 only

* Gate radar disable behind camera SCC cars

* Update CARS.md

* Add FW versions for Santa Cruz 2021

* Test route for Kia Sportage 2023 (openpilot longitudinal enabled)

* Test route for Santa Cruz 2021 (openpilot longitudinal enabled)

* fixup! Kia Sportage 2023: Add FW versions

* HKG: Car Port for Genesis GV70 2023 thanks to @zunichky!

Co-authored-by: kyle zunich <zunichky@msu.edu>

* Update car info

* Add torque param for GENESIS GV70 1ST GEN

* Fix CARS.md

* Update test route

* Remove unnecessary HDA2 checks

* Add additional FW versions for Sportage 2023

* Fix Kia Sportage supported MY

* Fix MISRA violation

* Fix release note

* Use IntFlag to gate camera SCC for CAN-FD

* Parse 0x1A0 on bus 4 dynamically

* bump panda

* Car code cleanup

* Typo

* Add additional 0x1A0 signals to bus 4

* Fix weird bitwise logic

* Check 0x1a0 after safety config is set

* Revert "Check 0x1a0 after safety config is set"

This reverts commit 141bbf79792bcde9cfadbc0680654acf61d8d16f.

* Check car list instead

* Add GV70 2022 test route

* Add fwdRadar FW version for GV70 2022

* Fix CARS.md

* Fix CARS.md

* Fix CARS.md

* new santa cruz route

* bump panda to commaai/panda#1031

* bumppanda

* some clean up

* lets refactor CAMERA_SCC_CAR in another pr

* minor clean up

* update docs!

* GV70 is a radar-SCC car :( (another PR)

* fix removed sportage hybrid versions

* update docs

Co-authored-by: kyle zunich <zunichky@msu.edu>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: sshane <shane@smiskol.com>
2022-11-04 18:44:38 -07:00
Shane Smiskol b22fc70f52 Hyundai CAN-FD: support ICE alt gears (#26367)
* Hyundai: Car Port for Santa Cruz 2022

* bump opendbc

* New struct and params for CAN-FD ICE models

* fixup! New struct and params for CAN-FD ICE models

* bump panda

* bump panda

* HKG: Car Port for Sportage 2023

* fixup! HKG: Car Port for Sportage 2023

* Kia Sportage 2023: Add FW versions

* Longitudinal Control: ICE CAN-FD models

* fixup! Longitudinal Control: ICE CAN-FD models

* bump panda

* fixup! Longitudinal Control: ICE CAN-FD models

* Update car info

* fixup! Longitudinal Control: ICE CAN-FD models

* Gate radar disable behind HDA2 only

* Gate radar disable behind camera SCC cars

* Update CARS.md

* Add FW versions for Santa Cruz 2021

* Test route for Kia Sportage 2023 (openpilot longitudinal enabled)

* Test route for Santa Cruz 2021 (openpilot longitudinal enabled)

* fixup! Kia Sportage 2023: Add FW versions

* HKG: Car Port for Genesis GV70 2023 thanks to @zunichky!

Co-authored-by: kyle zunich <zunichky@msu.edu>

* Update car info

* Add torque param for GENESIS GV70 1ST GEN

* Fix CARS.md

* Update test route

* Remove unnecessary HDA2 checks

* Add additional FW versions for Sportage 2023

* Fix Kia Sportage supported MY

* Fix MISRA violation

* Fix release note

* Use IntFlag to gate camera SCC for CAN-FD

* Parse 0x1A0 on bus 4 dynamically

* bump panda

* Car code cleanup

* Typo

* Add additional 0x1A0 signals to bus 4

* Fix weird bitwise logic

* Check 0x1a0 after safety config is set

* Revert "Check 0x1a0 after safety config is set"

This reverts commit 141bbf79792bcde9cfadbc0680654acf61d8d16f.

* Check car list instead

* Add GV70 2022 test route

* Add fwdRadar FW version for GV70 2022

* Fix CARS.md

* Fix CARS.md

* Fix CARS.md

* new santa cruz route

* bump panda to commaai/panda#1031

* bumppanda

* some clean up

* lets refactor CAMERA_SCC_CAR in another pr

* minor clean up

* revert car stuff

* revert panda

* revvy

* revvy

* it's all ice

* revert

* revert

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
Co-authored-by: kyle zunich <zunichky@msu.edu>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com>
2022-11-04 17:06:34 -07:00
Shane Smiskol 1db915ec1f Hyundai CAN-FD: remove check on unused msg (#26368)
remove check on unused msg
2022-11-04 17:03:41 -07:00
Jason Wen 31dbd21f07 Hyundai: Add FW for 2023 Ioniq 5 HDA2 (#26145) 2022-11-04 16:32:40 -07:00
Jason Young 9382d55280 VW MQB: Enable experimental long (#26359)
* VW MQB: Harness updates

* don't need the variant footnote

* VW MQB: Enable experimental long

* autogen doc fixes

* rename that
2022-11-04 12:45:35 -07:00
Mehmet Tolga Avcioglu ee0dd36a3c Kona EV 2022: add missing FW versions (#26278)
* add fingerprint for kona electric 2022

* Update selfdrive/car/hyundai/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-03 15:17:36 -07:00
Jason Young c9e65be9b1 VW MQB: Harness updates and docs cleanup (#26313)
* VW MQB: Harness updates

* don't need the variant footnote

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-11-03 14:37:21 -07:00
Jason Young d172cbbcc8 VW MQB: Add FW for 2021 Audi Q3 (#26343)
* VW MQB: Add FW for 2021 Audi Q3

* update docs
2022-11-03 13:33:01 -07:00
Vivek Aithal ad62a448fa [torqued] Set HYUNDAI ELANTRA 2021 Offline vlaues (#26344)
change elantra values
2022-11-03 13:21:11 -07:00
Shane Smiskol 3e69973819 car docs: auto-generate footnote for DSU cars (#26321)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* fix autoResume

* fix autoResume 2
2022-11-03 01:00:33 -07:00
Shane Smiskol 80e8d76d39 car docs: speedup test (#26337)
* faster

* faster
2022-11-02 20:40:42 -07:00
Shane Smiskol b0656f2c75 Toyota: add unsupported DSU car list (#26336)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* .

* .

* revert

* revert

* smaller diff
2022-11-02 20:12:35 -07:00
Shane Smiskol 735af656a0 car docs: docs-only footnote flag (#26335)
docs-only footnotes
2022-11-02 18:56:26 -07:00
Shane Smiskol e634afb719 GM: fix fault while moving backwards (#26333)
* log signed speed

* bump to master

* need this

* fix

* fix...

* see if this works

* just fault fix (no logging or standstill. tho revisit standstill)

* move

* Revert "move"

This reverts commit c564e74666e3a418ef43a77926c8a38a2bf89511.
2022-11-02 17:55:53 -07:00
Shane Smiskol 2fb7b4ffad GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
2022-11-02 02:46:29 -07:00
Shane Smiskol 423d16693a Toyota: unify deadzone params (#26325)
* i'm sure this makes no difference

* update refs
2022-11-02 02:09:54 -07:00
Shane Smiskol 0f6f305f2d GM: add longitudinal deadzone (#26323)
* add deadzone

* Update ref_commit
2022-11-02 01:58:15 -07:00
Shane Smiskol b76829c725 docs: expose available openpilot longitudinal control (#26312)
* openpilot -> openpilot available

* note for dsu cars

* common footnotes

* Revert "note for dsu cars" - another PR

This reverts commit 7f18742fdaaf5f86a1f1caa041b8b027d4b767cf.

* space

* better?

* Update selfdrive/car/docs_definitions.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* typo

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-11-01 15:55:21 -07:00
Jason Young b31b031044 VW MQB: Fahrzeuglängsbeschleunigungssteuerungseinrichtung (#22963)
* can I kick it?

* bumpity bump bump

* bump panda

* everybody's gotta be special

* attempt at improving stopping/starting

* reduce lateral feedforward

* tweak gradient and comfort bands

* oops

* accel from the dept of redundancy dept

* bump opendbc

* jerk limiter not needed and causing problems

* don't leave stop/start flags hung when not enabled

* reduce comfort band with lead car

* borrow decel comp from HKG

* align stopping state thresholds

* (re)try letting PI clean up some of this

* bump panda

* tweaks and comments

* elide superfluous import

* VW MQB: Longitudinal prereqs

* gate this too

* bump CI

* cleanup

* more cleanup; require gateway integration

* don't run long state/actuators unless sending message

* setpoint visibility in instrument cluster

* show fixed lead car if lead visible

* hold my beer?

* tuning

* the code is darkest before the refactor

* a little more

* set freewheel and stop distance correctly

* rounding issue maybe?

* ACC_04 Charisma profiles and HUD alerts

* fix ACC_04 counter, fix gradient and accel bugs

* revert tuning change in upstream focused branch

* need 0.5m/s to leave

* reduced braking when not absolutely needed

* oops

* bump panda

* match opendbc to master

* filter ACC_13, disable secondary accel

* bump panda

* bump panda

* bump opendbc and panda

* startAccel is deprecated

* testing manual trans min engage speeds

* pass stock ACC type to TSK

* bump panda

* bump opendbc

* bump opendbc

* test hax for Brake alert

* remove ACC_13 with matching panda bump

* fix submodule refs

* update long control safety param name

* bump panda

* actuator delay corrected by Mk1 eyeball

* a little more

* tweak stop/start thresholds

* Revert "tweak stop/start thresholds"

This reverts commit 60abd57d2025c3218f069dbec4600c8d14033c05.

* more lag reduction

* bump opendbc

* support both analog and digital clusters

* tuning adjustments

* bump opendbc and panda

* accept two button types for resume

* support separate set and resume

* bump panda

* #24706

* partial revert 6b93ac27

* fixes

* one more

* refactor all the things

* follow experimental long refactor

* fill in ACC hud status

* temp force E2E availability

* start cleaning up

* comment touchup

* gimme some comfort baby

* experiment

* SnG me maybe?

* a little more rollout

* is this why I'm not leaving?

* turns out you need startAccel to leave

* try without ACC_04

* cleanup unused variables

* temp hack to standstill handling

* temp hack to button handling

* trim rollout distance with slower vEgoStopping

* ultra fat comfort band due to noisy E2E actuator

* I like big changes and I cannot lie

* remove lead car display for now

* cleanup, drives somewhat better

* partial FtS/basic support

* diff reduction

* not needed

* more cleanup

* oops

* more cleanup

* restore lead car visible for PQ

* bump panda

* better enable button solution

* redundant

* OP long on *all* the things

* OP long on all the things *sometimes*

* docs generator a little TOO clever

* solve starting-state a different way

* try that again

* bump panda

* oops

* follow DBC refactor

* retry CI

* signal name changed

* sync with custom enable button branch

* oops

* more follow refactor

* bump panda

* sync opendbc to master

* bump panda

* updated comments

* light P, no I

* bump panda

* bump panda again

* add openpilot long test_models route

* bump panda with replay route

* temporarily disable experimental long for merge

* bump panda to master

* resolve conflict?

* now can we go to head?

* explicit length check

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-11-01 10:00:26 -07:00
Shane Smiskol 0e162cc13b test_models: fix Nidec routes that start enabled (#26305)
* Update test_models.py

* Update test_models.py

* fix non-pcmCruise routes where button is left pressed in warmup

* more explicit, don't allow multiple continues

* revert chjange

* -that
2022-10-31 23:02:31 -07:00
Shane Smiskol 23d5e5e07f test_models: speed up test (#26304)
* Update test_models.py

* Update test_models.py
2022-10-31 21:32:17 -07:00
Shane Smiskol 3160493c85 Nissan: match panda standstill (#26301)
* move to openpilot

* draft

* support internal urls

* not used

* update seg list

* regen segment list

* regen seg list

* fix

* check both rear wheels

* revert chganges

* bump panda

* bump padna
2022-10-31 19:44:53 -07:00
Shane Smiskol fe75dd4c09 Elantra 2021: add missing FW (#26299)
add FW for 82e9cdd3f43bf83e|2021-05-15--02-42-51 (test route)
2022-10-31 18:11:25 -07:00
Shane Smiskol 39167cccd9 RAM HD: add missing abs FW (#26300)
FW from 8fb5eabf914632ae|2022-08-04--17-28-53 (test route)
2022-10-31 18:11:18 -07:00
Shane Smiskol 4d7bdc271f test_models: remove carState test from panda tests (#26298)
Update test_models.py
2022-10-31 17:45:56 -07:00
Shane Smiskol d793d3622b test_models: fix runaway memory growth for long running tests (#26295)
* delete can msgs

* only can msgs
2022-10-31 13:54:13 -07:00
FAN HANGYU 131263a75b Honda: add Chinese Odyssey FW versions (#25943)
* Update values.py

add a carFW of odyssey_chn

* move after odyssey

* common carparams

* just ignore

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-10-31 13:13:57 -07:00
Adeeb Shihadeh b727f6cff4 EV6 long tuning (#26166)
* some matching and jerk limit

* update that

* one jerk limit

* little more

* more jerk

* bump opendbc

* update refs
2022-10-31 08:37:05 -07:00
Adeeb Shihadeh 5ae2131424 bump opendbc (#26277) 2022-10-28 17:26:25 -07:00