1033d3d80e
Desire helper: set lane change direction on entering preLaneChange state ( #36074 )
...
* set immediately to avoid flash on right lane changes
* one function
* name
* comment
2025-09-05 22:34:04 -07:00
b976135d2f
torqued: apply offset (with more robust unit test) ( #36075 )
...
* torqued: apply latAccelOffset to torque control feed forward
* test learned latAccelOffset captures roll compensation bias on straight road driving, when the device is not flush in roll relative to the car
* test correct torqued latAccelOffset parameter convergence
2025-08-27 13:06:01 -07:00
f40f7f9ece
Revert "torqued: apply offset ( #36005 )"
...
This reverts commit 1d74a97ba6
2025-08-26 21:45:49 -07:00
1d74a97ba6
torqued: apply offset ( #36005 )
...
* torqued: apply latAccelOffset to torque control feed forward
* test learned latAccelOffset captures roll compensation bias on straight road driving, when the device is not flush in roll relative to the car
* test correct torqued latAccelOffset parameter convergence
---------
Co-authored-by: felsager <d.felsager@gmail.com >
2025-08-25 13:50:10 -07:00
ab44c9a4ff
Torque controller: refactor calculations to be in accel space ( #35790 )
...
* clean up
* little confusing but works
* clean up
* fix
* pid outputs torque again, fix windup above max torque
* clean up
* fix
* fix
* typo
* fix conflicts
* fix PID
* cleanups
* seems correct
* updte
* inverse
* whitespace
* move
* small cleanup
* more cleanup
* update ref
---------
Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com >
2025-08-15 11:39:56 -07:00
4536719353
longitudinal_planner: Convert self.mode to a local variable in update() ( #35999 )
...
Make 'mode' variable local
2025-08-15 09:02:38 -07:00
455a6a586a
Misc PID refactors ( #35844 )
...
* Misc PID refactors
* dead
* finish rename
* unused import
* whitespace
* typo
* fix fan controller
* pid_log
* whitespace
* integral clipping in pid
* update ref
* cleaner
* rm print
* update ref
* revert fan changes
* forgot this
2025-08-11 14:25:29 -07:00
7413982f0d
Lower ALLOW_THROTTLE_THRESHOLD ( #35928 )
...
* Lower ALLOW_THROTTLE_THRESHOLD
* Bumped process_replay refs
2025-08-05 17:35:54 -07:00
9dc98b36be
refactor: cleanup gravity constant handling ( #35866 )
...
* refactor: move lateral methods from init to lateral.py (#2594 )
* Extracting lateral methods to lateral.py
* cleaning
* more cleaning
* more cleaning
* Making sure it remains where it should
* Leave rate_limit where it belongs
* Moving things to `car/controls/`
* Moving rate limit to get a taste of the changes
* clean
* copy verbatim
* clean up
* more
* now we can format
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
* No need to change order of import
* refactor: consolidate ACCELERATION_DUE_TO_GRAVITY import path
* bump opendbc
* update refs
* don't import from opendbc
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2025-08-02 11:20:18 -07:00
4d01b7bec8
Fix up radarFault handling ( #35880 )
...
* fixup radarFault handling
* catch all
---------
Co-authored-by: Comma Device <device@comma.ai >
2025-08-01 16:27:26 -07:00
1966845fc9
refactor: move lateral methods from init to lateral.py ( #35856 )
...
* refactor: move lateral methods from init to lateral.py (#2594 )
* Extracting lateral methods to lateral.py
* cleaning
* more cleaning
* more cleaning
* Making sure it remains where it should
* Leave rate_limit where it belongs
* Moving things to `car/controls/`
* Moving rate limit to get a taste of the changes
* clean
* copy verbatim
* clean up
* more
* now we can format
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
* No need to change order of import
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2025-08-01 15:17:37 -07:00
347cee4b09
big opendbc bump ( #35799 )
...
* bump
* bump
* bump
* bump
* bump
* update refs
* that doesn't work anymore
* bump
* update refs
* bump
2025-07-23 23:23:59 -07:00
bc7d6f2677
torque controller: clean up friction ( #35781 )
...
* conditional friction inside here is confusing
* do it here
* one line
* run
* bump
2025-07-21 20:27:34 -07:00
3c43a000cd
acados: relative rpath ( #35624 )
...
* opendbc/SharedLibrary
* acados, mpc don't link to absolute paths
* update opendbc
* include gen path, dont include abs path
* escape escape
* move rpath to relative path in mpc SConscripts
* clean up
* missing libs
* don't update opendbc
* rpath literal and rel_path
* ld library path is for runtime?
* same for darwin
* build on macos
* Update selfdrive/controls/lib/lateral_mpc_lib/SConscript
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update selfdrive/controls/lib/longitudinal_mpc_lib/SConscript
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Revert "Update selfdrive/controls/lib/longitudinal_mpc_lib/SConscript"
This reverts commit a55077f39ea248428e5916b85f24542293edefc9.
* Reapply "Update selfdrive/controls/lib/longitudinal_mpc_lib/SConscript"
This reverts commit 07a6a26292ea7f436ff43fb7efe1ad826eef689b.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-10 18:59:09 -07:00
20fdb686ca
latcontrol torque: remove option to feed back on localizer ( #35659 )
...
* Localizer is too laggy for control
* typo
* typo
* fix test
* fix imports
* Revert "fix imports"
This reverts commit 5074f8050170f974b451e00d9fdc752f09a47d57.
* fix improt
* import
2025-07-08 14:12:46 -07:00
e503e657bc
Model error deprecated with TR ( #35628 )
...
* Model error deprecated with TR
* no get speed error
* import
2025-07-02 23:36:41 -07:00
64fd3f9860
Tomb Raider 14 ( #35620 )
...
* f7db6a09-43c5-4db9-b856-7fe1a1c231eb/400
* bd99d079-9afb-4af5-9f31-236d5c9ff15f/400
* aggressive tr: 7707a4ca-7d5e-47a2-8760-93b5004695cd/400
* bd99d079-9afb-4af5-9f31-236d5c9ff15f/400
* ae82d7a8-b74d-43b5-ab6d-d72e6040dab3/400
* revert stop distance
* comments
2025-07-02 21:50:55 -07:00
8427bf76cf
typo
2025-05-17 22:54:01 -07:00
49c422e872
Tesla: fix angle control saturation ( #35256 )
...
* we shouldn't need this
* or this?
* stash junk
* hmm
* comment
* cc
* sadly we have to maintain behavior
* bump
2025-05-16 21:29:16 -07:00
e9cea3ae5c
Revert TR again ( #35179 )
...
Revert "Tomb Raider 7 (#35114 )"
This reverts commit 0fb4aafa35
2025-05-11 08:24:46 -07:00
0fb4aafa35
Tomb Raider 7 ( #35114 )
...
* Revert "Revert TR (#35110 )"
This reverts commit df4f2955dc
2025-05-07 18:06:41 -07:00
df4f2955dc
Revert TR ( #35110 )
...
* Revert "Tomb raider 2 (#35029 )"
This reverts commit 2c162d9b75
2025-05-02 20:54:42 -07:00
9f1e462faa
Tomb Raider 6 ( #35087 )
...
* 5ec366c3-7883-4004-84a2-e4b14bac5b1d/400
* Use lat plan
* fix import
* fix
* 8d0a1b3b-9972-4e53-b9c5-3e13e5e3e404/400
* whitespace
* whitespace
2025-04-30 17:19:53 -07:00
a029d13398
update smooth
2025-04-21 15:44:30 -07:00
33a7d853f0
Modeld: small refactor ( #35044 )
...
refactor
2025-04-21 15:10:41 -07:00
34514ef176
Long planner: make work with training ( #35043 )
...
* revert useless
* update ref
2025-04-21 14:11:57 -07:00
2c162d9b75
Tomb raider 2 ( #35029 )
...
* db56b8fb-9135-4ab6-af18-99b7df7b2245/400
* fixes
* linter unhappy
* 6dbe0991-baa1-49ad-836a-ab370d1f0d92/400
* This one is good: 19387087-1005-475e-9015-9458dd8e7c5f/400
* Better every day: 39ed911c-0937-417f-97d2-58a8bb3caa53/400
* Actually end-to-end
* typo
* smooooooth: 94e23541-eb84-4fef-9f51-6a2d82aff314/360
* Revert "smooooooth: 94e23541-eb84-4fef-9f51-6a2d82aff314/360"
This reverts commit edd4f02386d83d82dd8a188985cde80ed1646b7f.
* 11632ef7-f555-489c-8480-e3bf97d9285e/400
* 08712d27-f6bd-4536-a30e-c729e5f62356/400
* 0a92a35e-1f72-476a-8cb6-c9f103f36822/400
* ee6d2394-2072-420c-a664-b4c0d4ed0b61/400
* no prev curv
* No double work
* fix bug
* smooth
* update prev action
* whitespace
* add little accel
* new ref
* Update plant.py
2025-04-17 23:21:25 -07:00
b42ec33a63
Update modeld action logic ( #35032 )
...
* add action logic
* magic numbers
* unused
* plot accel
* more changes
2025-04-17 17:59:15 -07:00
ea4554526e
Keep steering active at standstill ( #34918 )
...
* Keep steering active at standstill
* bump opendbc
* bump opendbc
* update refs
2025-03-25 14:00:24 -07:00
5c3020844e
car interfaces: each specify their own dependencies ( #34874 )
...
* remove these
* fix
* oops
* clean up
* nl
* bump
2025-03-14 22:37:49 -07:00
6891b795c4
controls: limit max curvature from lateral acceleration ( #34651 )
...
* limit max curvature with lateral accel too
* not a guideline
* roll compensation in curv clip
* improve clipping and alerting
* typo
* clean up
* no float
* get ready
* good idea
* good
* redundant
* TODO
* test
* do max curvature clip last
* flip
---------
Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com >
2025-03-03 19:47:52 -08:00
68d22b960b
rename steer_limited ( #34763 )
...
rename
2025-03-03 16:28:49 -08:00
6723106bf5
Move vehicle_model.py to opendbc ( #34681 )
...
* move
* fix
* move test too
* bump
* better
* bump to master
2025-02-26 17:35:43 -08:00
77a442c4e8
Long planner: allow negative accel constraint ( #34565 )
...
* allow negative accel constraint
* dont let MPC do clipping
* Typo
* whitespace
* Fix tests
* More cruise accel
* rm print
* ref commit
2025-02-12 13:11:32 -08:00
8eebce75ac
Getting rid of openpilot.common.numpy_fast ( #34368 )
...
* Got rid openpilot.common.numpy_fast
* fixed some data type erros
* importing numpy instead of importing specific functions
* fixing some numpy importing mistakes
* Update selfdrive/car/cruise.py
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2025-01-14 14:52:56 -08:00
383893d39e
Long planner get accel: new function args ( #34288 )
...
* Change function args
* typo
* typo
* ref commit
2024-12-18 16:41:57 -08:00
8743bc4fe2
Null Pointer Model ( #34111 )
...
* e8cb7f27-e448-4c15-90c2-ac440cd5a042/400
* 0078ad07-4d46-4086-820f-23d61c90e07f/400
* 4bd74082-70af-47da-8156-e84ebf4d4812/400
* 2a074022-5c2c-4628-97f9-f54849a936a6/400
* 0660aa81-93c5-41b7-9cc2-dc8816a512cd/400
* Clip curvature to reasonable limits
* Better curvature and speed clips
* typo
* typo
* 31aa62c3-b373-4878-8f2e-5107305de187/400
* 384690ca-9b8a-41fe-9bcd-389b20fc6aa4/400
* ref commit
---------
Co-authored-by: Yassine <yassine.y10@gmail.com >
2024-12-13 19:14:21 -08:00
b470bef140
Fix low-speed allow_throttle behavior in long planner ( #33894 )
...
* Misc fixes
* don't check allow_throttle slowdown for e2e
* Removed unused variable
* believe this clip is still necessary
* Update process replay refs
---------
Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com >
2024-10-30 14:15:19 -07:00
b943cbd421
Reapply "Remove steering wheel offset for planner slow down for curves" ( #33848 ) ( #33849 )
...
* Reapply "Remove steering wheel offset for planner slow down for curves" (#33848 )
This reverts commit 4f8b11257e
2024-10-24 19:24:11 -07:00
0ff498cc83
longitudinal_planner: allow for zero actuator delay ( #33855 )
...
Allow zero actuator delay
2024-10-22 20:49:10 -07:00
4f8b11257e
Revert "Remove steering wheel offset for planner slow down for curves" ( #33848 )
...
Revert "Remove steering wheel offset for planner slow down for curves (#33827 )"
This reverts commit d26730ffd5
2024-10-22 12:58:06 -07:00
d26730ffd5
Remove steering wheel offset for planner slow down for curves ( #33827 )
...
* long planner: use vehicle model w/ avg steer offset for limit accel in turns
* remove unused CP in limit_accel_in_turns
* revert use of vehicle model, keeping angle offset in limit accel in turns
* only the offset fix, check valid, and fix process replay
* update refs (valid two frames later)
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
2024-10-22 12:50:06 -07:00
af727d41bb
long planner: allow throttle reflects usage ( #33792 )
...
* UI is now accurate
* update refs
2024-10-14 20:54:42 -07:00
7556233cca
Reapply "move car.capnp to opendbc ( #33722 )" ( #33728 )
...
* Reapply "move car.capnp to opendbc" (#33725 )
This reverts commit 9d52a5b485
2024-10-03 22:47:03 -07:00
9d52a5b485
Revert "move car.capnp to opendbc" ( #33725 )
...
Revert "move car.capnp to opendbc (#33722 )"
This reverts commit 8149f7cb11
2024-10-03 16:57:45 -07:00
8149f7cb11
move car.capnp to opendbc ( #33722 )
...
* move car.capnp to opendbc
* bump
* do card
* fix some more tests
* rm helpers
* format fp
* more
* whoops
* bump
* bump to master
2024-10-03 16:40:24 -07:00
47cc314b14
Gate acceleration on model gas press predictions ( #33643 )
...
* no ui squash
* already calibrated
* Already calibrated
* Add longitudinal maneuver tests
* Fix linter errors
* Added get_coast_accel function
---------
Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com >
2024-09-30 18:13:51 -07:00
36a9687d5d
long planner: use temporalPose for v_model_error calibration ( #33655 )
...
* long planner: add flag to disable v_model_error calibration
* use temporal pose instead of flag
* udpate model replay ref
2024-09-26 11:01:56 -07:00
e8bea2c78f
Tomb Raider Model ( #33629 )
...
* 69acff08-5383-4103-beea-822f0d228c76/160
* 53f39907-4763-4d19-ba26-e757527c2b61/200
* 21afb89f-1397-4652-b423-abc2da32417a/200
* 21afb89f-1397-4652-b423-abc2da32417a/400
* 53f39907-4763-4d19-ba26-e757527c2b61/400
* 3fb967fd-16a8-4569-ba57-359e54deeab3/395
* Try other policy again
* 3fb967fd-16a8-4569-ba57-359e54deeab3/400
* 0136cabf-539a-4a43-bc7f-06c3654a493c/4400
* 473c0686-1ac9-4c05-9b0b-d1f1afdb6cc3/400
* 83b7993d-51a9-4e3f-904e-3fcd5763c231/400
* 021566c7-cff3-431d-8da2-17a96c888c5f/400
* Fix bugs
* Update longitudinal_planner.py
* Update fill_model_msg.py
* 8be6b59d-4449-42fd-b8e0-93c48387070f/400
* f670a748-3591-4489-a0b3-215118ddad01/400
* 790a2950-c713-4eec-838b-4f55f4fe0ccb/400
* Update model ref
* Plans start at ego
* Update ref
2024-09-23 14:26:28 -07:00
2e6e977c93
Longitudinal planner: wait for valid cruise speed ( #33568 )
...
* Revert "only vCruise changes here"
This reverts commit 4f5659b5d53e9bac3357781bce262a29d3b1d14e.
* less nonsense
2024-09-16 16:06:02 -07:00
Shane Smiskol