Commit Graph

319 Commits

Author SHA1 Message Date
Willem Melching 977cf8ca02 parameterize longitudinal actuator delay (#22153)
* paremetrize longitudinal actuator delay

* update ref
old-commit-hash: b39f6efa3fc91b3df851a133109ec18f598dce68
2021-09-06 17:56:52 -07:00
Willem Melching 6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcdc9d651fe7169044fb7f52fd70f94ab
2021-09-06 17:29:32 -07:00
HaraldSchafer 1b98341932 Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
old-commit-hash: ebf2a2279d837feb3ce55a7bc44c7f0053e77f27
2021-09-02 14:16:44 -07:00
Harald Schafer 4e7cca187c unused
old-commit-hash: a4ae99a489911bcaa0fe86633b7c6e21ae2a09fe
2021-09-01 16:46:17 -07:00
Willem Melching a06ffc48c1 Smarter longitudinal lag compensations (#22094)
* smarter lag compensations

* need to use speed from plan

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: edae2218d76e3fb81839eabab344c9dabc852fe9
2021-09-01 15:28:16 -07:00
grekiki afe4df11dd Add angleError to pid_log (#21611)
* add angleError

* Log all the time

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 21fad4d1adcaea1fd802f8dcb80f267d6d5b19d3
2021-09-01 13:45:22 -07:00
robbederks f8085a47ef Smarter thermal controls for tici (#21923)
* dumb controller 'tuned' on a desk

* reduce Ki

* fix prev_time bug

* reset integral on going onroad

* cleanup thermal detection logic

* more minor tuning

* use controls' PI controller

* get rid of bat_temp

* change if once more

* cleanup

* cleanup import order

* add back bat temp in this PR

* move to constructor

* consistency

* add bp

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f539cd45c99034d379c797bb7faeb0e0dc44899e
2021-08-31 12:29:53 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh 9de66112fb remove deprecated mpc logging code
old-commit-hash: 9be7cf2cdaa4c274cc4fd55797ac5d6421fc9652
2021-08-26 13:33:43 -07:00
Adeeb Shihadeh ac8b08fa0c alert for per-core cpu usage (#21983)
* thermald: per-core cpu usage

* add alert

* better alert text

* list

* fix process replay
old-commit-hash: fc8b571a847f1a89abb331eef8f85f310453fd77
2021-08-19 19:14:51 -07:00
HaraldSchafer e13349366e Remove HUD alert from green DM alert (#21942)
old-commit-hash: c0cacc7d2f30b18f1a19eb3b508a62ba4e2f0121
2021-08-16 22:30:51 -07:00
Mitchell Goff b7b87efed9 Retuned desire model (#21919)
* New model: d8e7f76f-7bec-4a83-af00-c0fae792527f/950

* Updated process replay refs

* Updated model replay ref
old-commit-hash: 05b37552f3a38f914af41f44ccc7c633ad152a15
2021-08-12 21:06:26 -07:00
sshane 41b7cbdadf longitudinal comments (#21898)
* cmt

* Update longcontrol.py
old-commit-hash: 737a79e5560816f1ef852eb42f761af86f57a55c
2021-08-11 01:33:59 -07:00
Mitchell Goff 7fffcd9baa Update long_mpc api for use with sim (#21890)
old-commit-hash: 3022f68fa70574202d7bd5ed0100133719e2316c
2021-08-10 10:51:38 -07:00
HaraldSchafer b615987244 Cleaner lane change alerts (#21857)
* less is more

* small

* remove HUD warnings

* update ref

* safe

* update refs

* update again

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aa689176fc84e57f16a4fe9f1769e76fb8effc46
2021-08-05 14:23:27 -07:00
sshane 51698f04bc Use first order filter (#21411)
* Use first order filter in INDI

* use first order filter in LP as well

* Update selfdrive/controls/lib/lane_planner.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* RC->rc

* division safe

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: c900bce1b08e28edb777a5e9032d241c52bb1a2c
2021-08-03 13:47:46 +02:00
Adeeb Shihadeh eb8a334bfc remove alert for stock fcw (#21834)
old-commit-hash: fb028041cd895765a1c0dd88ba6cdf145477a005
2021-08-02 21:59:03 -07:00
Mitchell Goff 2d0512b8a1 Revert "New desire model (#21729)" (#21805)
* Revert "New desire model (#21729)"

This reverts commit 709932b3bfb4c3b4f33711b8d07615469e762832.

* Updated process replay ref and reverted release notes
old-commit-hash: 15d6bbb47c3a33f98d33377d95bf7e69c46565fa
2021-07-30 14:34:29 -07:00
Mitchell Goff 3fb1a1c746 New desire model (#21729)
* New model: b822ee32-917c-4639-99f8-25be3e6aabad/900

* Enable keeps

* use new packet

* Send keep pulses once per second

* Updated model_replay_ref_commit

* New model: 0f160bf9-1bce-43e6-9785-564b2453eeac

* Bump model_replay_ref_commit

* Bump submodules

* New model: fd904bf9-5dd8-4619-8997-c5668400e078/550

* New model: fd904bf9-5dd8-4619-8997-c5668400e078/950

* No keeps

* Bumped model replay ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: e83973b9b31199c1594b9be2371a7af0c589c2d9
2021-07-26 21:11:09 -07:00
HaraldSchafer dee5a3e9a0 safer low speed (#21705)
old-commit-hash: 4bd4ed4999ef86824ef2d3a9dfa86ba61ae24b4f
2021-07-25 15:15:50 -07:00
HaraldSchafer d1c5e054d0 Better localizer unstable alert (#21660)
* use canonical language

* filter out when gps signal is flaky

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 049a1bca34c74ea1fae473386e8bea62f1b3041c
2021-07-20 19:20:00 -07:00
HaraldSchafer 4455ae1b86 add jerk to longitudinal plan (#21598)
* add jerk output, so its like lateral

* typo

* add to packet

* update cereal and ref
old-commit-hash: ef0b120a9ac589b22672b95adb57ecb4e4cee336
2021-07-14 11:51:48 -07:00
HaraldSchafer bbd7181df2 Taper off high speed accel (#21599)
* max 0.2 diff from before to preserve bad tuned cars

* update ref
old-commit-hash: 5d078190840adf2e6d50cdd3937ca407538886e6
2021-07-14 10:53:14 -07:00
HaraldSchafer 8fdfa3b97d fix low speed override bug and cut-in bug (#21593)
* fix low speed bug and cutin bug

* update ref
old-commit-hash: 6a933467292f2364940b35cc87855d336d2275f7
2021-07-13 23:36:25 -07:00
HaraldSchafer cdb2c42ca2 Lower speed for lowest planned acceleration (#21578)
* 55mph sounds about right

* update refs
old-commit-hash: fd41e9f01b98e259f7c8431a79d71636075e4504
2021-07-13 14:22:06 -07:00
Adeeb Shihadeh 477e2e22d3 Revert model (#21571)
* Revert "New desire model (#21458)"

This reverts commit 9db03d2a3fefff50b738d288beadc2c2e7c3165e.

* revert rel notes
old-commit-hash: 88424ede2c5bdd2beade731717cbb0bb635034e9
2021-07-12 19:26:50 -07:00
HaraldSchafer 91d5b10426 less accel (#21565)
* less accel

* new refs

* Update longitudinal_planner.py

* update refs
old-commit-hash: a42d8f3a14132c3c0826ed106d61a617ce41936e
2021-07-12 18:30:56 -07:00
Adeeb Shihadeh 4b79c86b5f fix unnecessary harsh steering unavailable alerts (#21541)
old-commit-hash: 092c728e766bc17a63279b42ea88a4f0f1c51a6d
2021-07-10 01:53:14 -07:00
HaraldSchafer 56b457207f less np (#21536)
old-commit-hash: 148c202bc4a9d2b5be3c7dfc529da89c62dd7230
2021-07-09 11:34:00 -07:00
HaraldSchafer 7fcdd04541 New desire model (#21458)
* New model: b822ee32-917c-4639-99f8-25be3e6aabad/900

* Enable keeps

* use new packet

* Send keep pulses once per second

* Updated model_replay_ref_commit

* New model: 0f160bf9-1bce-43e6-9785-564b2453eeac

* Bump model_replay_ref_commit

Co-authored-by: mitchell <mitchellgoffpc@gmail.com>
old-commit-hash: 4230d5d2124577b86e69b136d846ca9cc3ecd746
2021-07-07 19:44:17 -07:00
HaraldSchafer 96d4bfbff3 Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
old-commit-hash: be5ddd25cd3f4c8b7e46cdeecf303e2c73301003
2021-07-07 19:42:26 -07:00
HaraldSchafer 098d939428 Remove DM high std alert (#21501)
* cleaner

* no face and high stds is the same

* change test

* final clean

* need to deprecate
old-commit-hash: 2aadf8beb2d69145d182c9e95105d29590935983
2021-07-07 17:08:55 -07:00
Adeeb Shihadeh 2293b4bcae update speedTooHigh alert sound (#21484)
old-commit-hash: 8dce135279c846a5f960e3d30dfe0afcc3f9ed0b
2021-07-04 19:23:09 -07:00
HaraldSchafer 7e87930a20 Refactor lateral lag compensation (#21334)
* add T_IDXS

* refactor

* fix test

* unused

* typo

* needs casting

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* deprecate field

* regen all

* new segs

* add todo

* split back

* clean

* bad names

* do in controls

* add arg

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6838e1c82c5abb9f347228006219d96744b3fbb5
2021-06-30 14:19:39 -07:00
Adeeb Shihadeh b449a2a7d9 fix warning -> userPrompt
old-commit-hash: 8e36a7d07c29ecfb265cdf3218a2ae2402fbfa13
2021-06-28 21:46:26 -07:00
Adeeb Shihadeh 2c3d136d32 make speed too high alert orange
old-commit-hash: 880435f6a28cd30a45e37f09f2e493a32c0de618
2021-06-28 21:42:25 -07:00
Chris McCammon e8904916a6 steer unavailable below speed audible alert (#21209)
old-commit-hash: 317afa335f16deae21b6613203f8d92a31928a23
2021-06-17 14:10:24 -07:00
ShaneSmiskol 23ea456f4f Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
old-commit-hash: ae77f693a26527ffbee044f852cc4185718c2433
2021-06-11 14:33:17 -07:00
Dean Lee 147b355dde add space after function name and if statement (#21225)
old-commit-hash: e4e669bb0fc1a919dfb38800099f8e3ad52346f1
2021-06-11 10:17:52 +02:00
Willem Melching eb0fdfecf1 Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: ec17fad41a851369383173530bdaa3dfbfc1c671
2021-06-09 10:58:01 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh c2875eea66 fix mpc compilation (#21178)
old-commit-hash: 524aa55b93dbe883c8bdd69f5ca04f5a41e47386
2021-06-07 15:01:29 -07:00
Adeeb Shihadeh 5dfc430d47 startup alert for no fw returned (#21177)
old-commit-hash: d4ab1f1e274bc5e36b47fb9e6f76a977e04d1f1a
2021-06-07 14:15:09 -07:00
speedking456 2bcc0c0ada Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
old-commit-hash: 24b6b4a341bbd02551756b3e0fd5ba2120e66eef
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh e7cb6f6512 bump cereal
old-commit-hash: f2a9b134980e5ef7af86da71a13f01f2b23d017f
2021-06-04 16:06:57 -07:00
Willem Melching 51eb52fec4 Determine lane chane direction in preLaneChange state (#21119)
* Determine lane chane direction in preLaneChange state

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: de34d1a527799acd8dde755bdb6dba2d0625b096
2021-06-04 10:03:13 +02:00
HaraldSchafer f0f36a0a06 Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
old-commit-hash: 1c926d23da0c73ceb246ca6d61db6ed1c48a1ab9
2021-06-03 09:26:53 -07:00
HaraldSchafer 5c5dfe5415 Safe interpolation in lane_planner (#20995)
* safe idxs

* make thread more safe
old-commit-hash: d6fcf6fa84bf897f4a2be7eff6a95d5431aa4853
2021-05-21 16:34:17 -07:00
Adeeb Shihadeh 41f8f5c7ce per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
old-commit-hash: 12ed986333856086c774b3142659dfbaecdf654b
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh 340a080c3b alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2defc730db18f7f9c0b08b0c8b0f6806cc513ac4
2021-05-19 21:28:16 -07:00