Commit Graph

1157 Commits

Author SHA1 Message Date
Shane Smiskol d1dee4625a controlsd: preEnable on brake at a standstill (#26273)
* pre-enable on brake at standstill

* test by getting rid of noTarget

* Update events.py

* rename

* stash what we got so far

* cmt

* not sure if best way to fix, but enabled with current states defs is fine

* no noEntry in preEnabled

* bumpcereal

* uncomment

* Update ref_commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dbe512d167a51f02fe276e17a8794de2137d0e14
2022-11-29 17:34:10 -08:00
Vivek Aithal 5bc529bf20 [controlsd] Toyota Prius 2017 (#26455)
* increase lag on prius

* better offline values computation

* split prius ecu more, set deadzone to 0

* add deadzone back

* replace deadzone with slack

* reduce deadzone to 0.2

* update refs
old-commit-hash: 0706b03e8cf41f7d51c9a42f01bda2084bfe3be6
2022-11-29 10:47:13 -08:00
Jason Young 0d2373312e VW MQB: Redundant brake pressed signals (#26401)
* VW MQB: Redundant brake pressed signals

* retry CI

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 636ff5979fc19fe0a965fbceae214694c97c1e3d
2022-11-22 16:18:42 -08:00
Shane Smiskol cf287d796b GM Cam: log when cruise not adaptive (#26581)
* bump opendbc

* log when nonAdaptive

* Update ref_commit
old-commit-hash: 9fdbe9f397b79f33c0653f4e9dd3b1cbb2e92273
2022-11-22 15:18:10 -08:00
YassineYousfi 30414a7305 Revert "Albert Einstein Model" (#26576)
Revert "Albert Einstein Model (#26456)"

This reverts commit 0129c20611bd21fb5b94d19b96d435c7e02041f1.
old-commit-hash: ceb94f1bcd7eae99977e132fd596db353e4e11b4
2022-11-22 11:41:22 -08:00
Adeeb Shihadeh cc8025894b jenkins: set hostname on startup
old-commit-hash: 8ee07def5c8b21c479b9f342ba490887237b2d0f
2022-11-21 21:18:35 -08:00
YassineYousfi 5bb8ff4a90 Albert Einstein Model (#26456)
* d0bc247d-9529-4e50-a5dd-95a8a5733874/440 38fb1ce9-18d7-4292-9ffd-678f8483ebf4/700

* update model replay ref commit
old-commit-hash: 34c80a6fbdf8780ad0b75f497c226cf1d9de0ddb
2022-11-18 17:50:24 -08:00
Harald Schäfer beccaa2e76 More Honda rate limit (#26509)
* More Honda rate limit

* Update ref_commit
old-commit-hash: fbf3ef0895182ffab90ddda83fa485b02d5a76d6
2022-11-15 14:21:00 -08:00
Harald Schäfer 88135d52cb Rate limit honda steer (#26500)
* Rate limit honda steer

* Update ref_commit
old-commit-hash: e58f6fbc11424e8059d6a86a4f0990f604c3a22f
2022-11-15 00:46:47 -08:00
Shane Smiskol 74d58ab0d6 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
old-commit-hash: 15383d30161de7646edf770153b0f81d15338c54
2022-11-13 21:13:46 -08:00
Shane Smiskol a570984aa3 interfaces: disable on falling edge of cancel button (#26493)
* both

* Update ref_commit
old-commit-hash: ca37d0c8cc43a88189c2a96b02aed0edfe5aa32e
2022-11-13 20:50:28 -08:00
Shane Smiskol 054cb1f8c1 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
old-commit-hash: 89b88fc7a23c393b1d74c5c74aacd5c4ee254d81
2022-11-11 14:49:38 -08:00
Shane Smiskol 400b36a57f longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
old-commit-hash: 9f80a97eee52d128559b7fef0593b8c328a6142d
2022-11-11 14:02:09 -08:00
Shane Smiskol 1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7dc8e0b1ec051f00037506d23a017ae8
2022-11-10 19:06:31 -08:00
Shane Smiskol ab5e2b66e8 Toyota: factor on cluster speed to match dash (#26408)
* add a minimum factort

* Update ref_commit
old-commit-hash: e1001a3036fb93d6d0340d139d4ae2a1f2419d52
2022-11-09 18:27:30 -08:00
Shane Smiskol 54b089a56d GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
old-commit-hash: 191b8081b2a9f3f9db0131edd270e40166570cfa
2022-11-08 20:52:35 -08:00
Adeeb Shihadeh 74979a7c76 experimental mode (#26416)
* experimental mode

* rename param

* red lights
old-commit-hash: 9a3f46805104c4bcb5cffa304b9b322874ccf412
2022-11-08 14:45:01 -08:00
Shane Smiskol f9c9b96e27 Toyota: add hysteresis to cluster speed (#26386)
* add hysteresis to cluster speed

* add minimum cluster scaling

* fix

* Update ref_commit
old-commit-hash: 52a644e6564582632559255230c82b550db50c76
2022-11-08 00:03:23 -08:00
Shane Smiskol f36d799198 Hyundai: bump safety params (#26407)
* bump panda

* bump panda

* bump panda

* update refs

* bump panda

* bump panda
old-commit-hash: e971bb11c2170d8d6d66f430741d7234a77a0499
2022-11-07 22:14:47 -08:00
Harald Schäfer f86b44d516 E2e long model: calibrate model speed to wheel speed (#26395)
* calibrate!

* Fix test

* Fix proc replay

* check len

* get v_ego from model 8501d20-bb59-4193-aa82-82b2737dedd6/449 609d90f3-65e6-4617-a60c-d6d99eead408/700

* bump cereal

* initialize v_model_error

* typo

* better names

* cleanup

* bump cereal

* update model replay ref commit

* bump to cereal master

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: f63f0de80a78ade6ad12fe98ea27094035d97457
2022-11-07 17:49:36 -08:00
Vivek Aithal 3029919422 [torqued] Fix high speed oscillations (#26338)
* modify low speed factor during high speeds and rescale friction

* update refs
old-commit-hash: e9eb5d99ff659a3f5e1b4e0bead321c469d8d889
2022-11-07 17:01:24 -08:00
ZwX1616 cfa80ee10c DM: compensate for non-calibrated pitch spread (#26348)
old-commit-hash: 2837e73a70b8b8faba7047db5124a582635439ff
2022-11-04 14:18:51 -07:00
Harald Schäfer e20020053d Longcontrol: faster transition from starting to stopping (#26361)
* Never command accel when stopping

* Update ref_commit
old-commit-hash: a7ced7c54b86107cb4095423158e28398aa62143
2022-11-04 13:21:34 -07:00
Vivek Aithal 8f6f406237 [paramsd] Prevent low speed drifting (#26360)
* lower active speed for paramsd observations

* update refs
old-commit-hash: 81f6ebebaaeda467fd7a4552711cc1109b33ddd5
2022-11-04 01:32:29 -07:00
Kurt Nistelberger 890f7ffd80 locationd: add gps sanity check for quectel gps (#26352)
* update check

* .

* .

* remove gps kf time check for gps ok

* upsi

* dont use gps_mode

* update refs

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Shane Smiskol <shane@smiskol.com>

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: aebb08e10542758c458c3abb219f8b57485e0b61
2022-11-03 23:43:30 -07:00
Shane Smiskol da68ac1b66 car docs: auto-generate footnote for DSU cars (#26321)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* fix autoResume

* fix autoResume 2
old-commit-hash: 3e69973819ba337743d4d9c71d31369a761a688d
2022-11-03 01:00:33 -07:00
Adeeb Shihadeh 3a3ae6c75f bump up controlsd cpu usage
old-commit-hash: 0589ff23a52efb90269d270f13a3d921176d377b
2022-11-02 15:51:52 -07:00
Shane Smiskol 6a7ce3a4d6 GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
old-commit-hash: 2fb7b4ffad204901033273f6f92f289bbce19f06
2022-11-02 02:46:29 -07:00
Shane Smiskol a230015754 Toyota: unify deadzone params (#26325)
* i'm sure this makes no difference

* update refs
old-commit-hash: 423d16693a4d805db2035dcd87f120b2902c2c4a
2022-11-02 02:09:54 -07:00
Shane Smiskol 59090b598f GM: add longitudinal deadzone (#26323)
* add deadzone

* Update ref_commit
old-commit-hash: 0f6f305f2da81c30aef849bc55c76e57ebe5e34d
2022-11-02 01:58:15 -07:00
Adeeb Shihadeh 96ba2b3c1a test_onroad: temp disable max UI draw time check
old-commit-hash: bdbdd42d5b736c2d10d2e586c382a5989b38a250
2022-11-01 23:18:56 -07:00
Jason Young eb3d572add VW MQB: Fahrzeuglängsbeschleunigungssteuerungseinrichtung (#22963)
* can I kick it?

* bumpity bump bump

* bump panda

* everybody's gotta be special

* attempt at improving stopping/starting

* reduce lateral feedforward

* tweak gradient and comfort bands

* oops

* accel from the dept of redundancy dept

* bump opendbc

* jerk limiter not needed and causing problems

* don't leave stop/start flags hung when not enabled

* reduce comfort band with lead car

* borrow decel comp from HKG

* align stopping state thresholds

* (re)try letting PI clean up some of this

* bump panda

* tweaks and comments

* elide superfluous import

* VW MQB: Longitudinal prereqs

* gate this too

* bump CI

* cleanup

* more cleanup; require gateway integration

* don't run long state/actuators unless sending message

* setpoint visibility in instrument cluster

* show fixed lead car if lead visible

* hold my beer?

* tuning

* the code is darkest before the refactor

* a little more

* set freewheel and stop distance correctly

* rounding issue maybe?

* ACC_04 Charisma profiles and HUD alerts

* fix ACC_04 counter, fix gradient and accel bugs

* revert tuning change in upstream focused branch

* need 0.5m/s to leave

* reduced braking when not absolutely needed

* oops

* bump panda

* match opendbc to master

* filter ACC_13, disable secondary accel

* bump panda

* bump panda

* bump opendbc and panda

* startAccel is deprecated

* testing manual trans min engage speeds

* pass stock ACC type to TSK

* bump panda

* bump opendbc

* bump opendbc

* test hax for Brake alert

* remove ACC_13 with matching panda bump

* fix submodule refs

* update long control safety param name

* bump panda

* actuator delay corrected by Mk1 eyeball

* a little more

* tweak stop/start thresholds

* Revert "tweak stop/start thresholds"

This reverts commit 60abd57d2025c3218f069dbec4600c8d14033c05.

* more lag reduction

* bump opendbc

* support both analog and digital clusters

* tuning adjustments

* bump opendbc and panda

* accept two button types for resume

* support separate set and resume

* bump panda

* #24706

* partial revert 6b93ac27

* fixes

* one more

* refactor all the things

* follow experimental long refactor

* fill in ACC hud status

* temp force E2E availability

* start cleaning up

* comment touchup

* gimme some comfort baby

* experiment

* SnG me maybe?

* a little more rollout

* is this why I'm not leaving?

* turns out you need startAccel to leave

* try without ACC_04

* cleanup unused variables

* temp hack to standstill handling

* temp hack to button handling

* trim rollout distance with slower vEgoStopping

* ultra fat comfort band due to noisy E2E actuator

* I like big changes and I cannot lie

* remove lead car display for now

* cleanup, drives somewhat better

* partial FtS/basic support

* diff reduction

* not needed

* more cleanup

* oops

* more cleanup

* restore lead car visible for PQ

* bump panda

* better enable button solution

* redundant

* OP long on *all* the things

* OP long on all the things *sometimes*

* docs generator a little TOO clever

* solve starting-state a different way

* try that again

* bump panda

* oops

* follow DBC refactor

* retry CI

* signal name changed

* sync with custom enable button branch

* oops

* more follow refactor

* bump panda

* sync opendbc to master

* bump panda

* updated comments

* light P, no I

* bump panda

* bump panda again

* add openpilot long test_models route

* bump panda with replay route

* temporarily disable experimental long for merge

* bump panda to master

* resolve conflict?

* now can we go to head?

* explicit length check

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b31b0310444e83dc8e151767f57ee21f46f1515b
2022-11-01 10:00:26 -07:00
Adeeb Shihadeh 8f4338cef4 EV6 long tuning (#26166)
* some matching and jerk limit

* update that

* one jerk limit

* little more

* more jerk

* bump opendbc

* update refs
old-commit-hash: b727f6cff4968a53dd489e9825b785d97eda66ef
2022-10-31 08:37:05 -07:00
YassineYousfi eafe85c1eb Model trained with headlight augmentation (#26284)
* d8501d20-bb59-4193-aa82-82b2737dedd6/449 ddfe2a22-fb0e-4ff0-a97f-0157b95eb44d/700

* update ref
old-commit-hash: c3388d216c33111ae8bd16452016cf8908679c28
2022-10-30 23:55:48 -07:00
Adeeb Shihadeh 8ec2fa1307 controlsd: steer in old preEnable state (#26269)
* controlsd: steer in old preEnable state

* bump panda

* bump panda

* Update ref_commit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6698cd48294e94fdb4e09e8943e6505efa29c5d5
2022-10-27 20:53:15 -07:00
Shane Smiskol 4b02af4adc process replay: support experimental long (#26233)
Support experimental long
old-commit-hash: c2326a421993534c49aea1efa78e31a6bfa0625c
2022-10-27 16:44:22 -07:00
Vivek Aithal d843347126 [torqued] Update offline values (#26261)
* add qlog mode to torqued

* update offline valujes from qlogs

* resollve comments

* update refs

* resolve comments
old-commit-hash: b158c016cbd58a84e57124f49c657dbba8beb19e
2022-10-27 16:34:11 -07:00
Shane Smiskol e135d07018 process replay: test Bolt EUV (camera-ACC platform) (#26270)
ADD BOLT TO PROCESS REPLAY
old-commit-hash: 995c74a994345de3d22c84cd1404aaf4cf8b7e82
2022-10-27 14:36:47 -07:00
Vivek Aithal 5cfe86afa5 [torqued] Update offline values (#26243)
* update offline vals

* update refs
old-commit-hash: 03ebc3bff57627843bde8b5ea758a54e8b96cb4e
2022-10-26 11:45:21 -07:00
HaraldSchafer 4b0d7997ac Model trained with more long noise (#26241)
* d8501d20-bb59-4193-aa82-82b2737dedd6/449 d37d320d-7d78-479a-9be2-d58c75284307/700

* Update model ref
old-commit-hash: 2b7290a14261ca0a745f4cd537de7cc9d11ccb12
2022-10-26 00:20:30 -07:00
Adeeb Shihadeh 53c9b3c5cd Hyundai: CAN-FD blindspot signals (#26229)
* Hyundai: CAN-FD blindspot signals

* fix that

* update refs
old-commit-hash: 339253bc05179530e47509e548c482495fbc6e82
2022-10-25 13:51:23 -07:00
Shane Smiskol ed9c040be9 GM: reduce LKAS faults while inactive (#26196)
* send at 10hz when inactive

* try to make it fine to switch rates

* fix rate

* todododo

* fine if we skip, we usually send too early

* clean up

* this may be required, 50Hz is not really needed to sync/initialize

* preserves previous behavior (not sure if this makes sense)

* Revert "preserves previous behavior (not sure if this makes sense)"

This reverts commit 3b297bca72307b5cba09bec4e2cd8e0f2761af42.

* Revert "this may be required, 50Hz is not really needed to sync/initialize"

This reverts commit a6b4693814214d3f508db922f3b371c402a13995.

* rm com

* Update ref_commit

* gate behind GM Cam

* common logic

* bet

* update refs
old-commit-hash: 27e315e58f5273da79803ad95737fc15483fef21
2022-10-25 00:12:49 -07:00
HaraldSchafer 89e6b69f05 Calibrationd: Calibrate wide from device (#26204)
* Use calibrator to stabilize wide transform

* Need array

* Needs init

* Needs to be arr

* publish mshg

* Check size

* Update ref

* fix calibration param read when no wide calib

* need self!
old-commit-hash: 15595fc8599f0ddf1e72ed02422e9f6d266db1f6
2022-10-24 20:17:05 -07:00
Bruce Wayne 21bcfad5a7 Revert "Use calibrator to stabilize wide transform (#26201)"
This reverts commit 1827b3c9e2942240f65d03ec0f790c91aa9c00ee.

old-commit-hash: 75b7fd0a7d9728dbf84e4cff209cbc44799dbdeb
2022-10-21 21:44:47 -07:00
HaraldSchafer dfbb291ef2 Use calibrator to stabilize wide transform (#26201)
* Use calibrator to stabilize wide transform

* Need array

* Needs init

* Bump to master

* Needs to be arr

* publish mshg

* Check size

* Update ref
old-commit-hash: 42ef62e39102ca5ad03982232ebadc37928a6ca2
2022-10-21 20:30:48 -07:00
YassineYousfi 78f0a175ae use upstream tinygrad (#26178)
* use upstream tinygrad

* add networkx to pipfile

* Revert "add networkx to pipfile"

This reverts commit 6cfa164378fa072b325a27040f0388730771437c.

* dont need networkx and update tinygrad

* submodule sync

* add new thneed file

* fix release files

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 68e7f42d68232efb89a5dc882fafa71daab72a28
2022-10-21 13:11:50 -07:00
HaraldSchafer bcb1ba7bfe Wide transform model (#26165)
* d8501d20-bb59-4193-aa82-82b2737dedd6/449 f78009d1-2184-4136-9fbc-1c5de55d460d/700

* Change model outs

* Add cereal

* Publish transform

* d8501d20-bb59-4193-aa82-82b2737dedd6/449 f78009d1-2184-4136-9fbc-1c5de55d460d/700

* Bump cereal to master

* Bump cereal to master

* Update model ref
old-commit-hash: d25ab3e3663f1e8a7b08348692d6555fac84e73b
2022-10-21 01:29:58 -07:00
Adeeb Shihadeh 7dac75758d model replay speedup (#26181)
* model replay speedup

* less frames too

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 188c2c1c5e1c06d68ae957ab16bcb77e29052f4b
2022-10-20 20:58:58 -07:00
HaraldSchafer 3b62f66008 Use same minimum speed for lateral planning and controls (#26177)
* Use same speed for lag adjustmenet

* One is a nicer number

* Update ref
old-commit-hash: 4f84b2998579a630e1577e60dd1d30d23261cd28
2022-10-20 14:34:36 -07:00
Adeeb Shihadeh 449fd1db18 Hyundai CAN-FD: use cruise signals from SCC ECU (#26171)
* Hyundai CAN-FD: use cruise signals from SCC ECU

* bump panda

* bumppanda

* update refs
old-commit-hash: eaedfb9a66012b82091c4b602184a0078d7f0c25
2022-10-19 23:31:24 -07:00