Commit Graph

196 Commits

Author SHA1 Message Date
Shane Smiskol 8aadc8dda6 Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
old-commit-hash: 860f441e2f122173c5034656aeed5706fd41e38f
2022-11-29 11:49:13 -08:00
Shane Smiskol cf287d796b GM Cam: log when cruise not adaptive (#26581)
* bump opendbc

* log when nonAdaptive

* Update ref_commit
old-commit-hash: 9fdbe9f397b79f33c0653f4e9dd3b1cbb2e92273
2022-11-22 15:18:10 -08:00
Shane Smiskol ee961b62f8 Car docs: add a make-specific init function (#26565)
* add a hook function for makes to implement custom docs logic

* don't need this

* use the pre-defined list for honda's harnesses

* one line 😎

* Update selfdrive/car/docs_definitions.py

* i didn't know you didn't need a pass!

* don't change docs order
old-commit-hash: 1367f84425b5fbdb3ecf8452b134b641998e404a
2022-11-21 18:01:08 -08:00
Tim Wilson 713ec37e49 Add video_link for GMC Sierra (#26506)
* Add video_link for GMS Sierra

* fix precommit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 187f8c177a1a4d507a4ca145463f852cee3ce7aa
2022-11-17 02:03:13 -08:00
Tim Wilson d985096170 Add video link for Volt (#26504)
old-commit-hash: bdc432d21824cc83627bb5d1abd5e99b4bc62fc3
2022-11-15 10:55:43 -08:00
Shane Smiskol 74d58ab0d6 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
old-commit-hash: 15383d30161de7646edf770153b0f81d15338c54
2022-11-13 21:13:46 -08:00
Shane Smiskol dc27f0de03 GM: handle run-away set speed (#26480)
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04fca25e6a1bac889e44afac6430d5ad7c30.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6900e0f0470f14ed55e7846e4b1d570826.

* fix

* bump

* fix that

* Bump to master

* fix fix
old-commit-hash: 65f494d845bbfa47293ad3158a68bc38c1b4dcff
2022-11-12 02:02:30 -08:00
Shane Smiskol 0371e47fac controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
old-commit-hash: 76ac3d4c99df24f068aee3baedb796f65dfcca66
2022-11-11 19:43:30 -08:00
Shane Smiskol 1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7dc8e0b1ec051f00037506d23a017ae8
2022-11-10 19:06:31 -08:00
Shane Smiskol 54b089a56d GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
old-commit-hash: 191b8081b2a9f3f9db0131edd270e40166570cfa
2022-11-08 20:52:35 -08:00
Shane Smiskol 84bf91ceda GM: fix fault while moving backwards (#26333)
* log signed speed

* bump to master

* need this

* fix

* fix...

* see if this works

* just fault fix (no logging or standstill. tho revisit standstill)

* move

* Revert "move"

This reverts commit c564e74666e3a418ef43a77926c8a38a2bf89511.
old-commit-hash: e634afb719e9ea787155272b3d2fe64b385bcb7d
2022-11-02 17:55:53 -07:00
Shane Smiskol 6a7ce3a4d6 GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
old-commit-hash: 2fb7b4ffad204901033273f6f92f289bbce19f06
2022-11-02 02:46:29 -07:00
Shane Smiskol 59090b598f GM: add longitudinal deadzone (#26323)
* add deadzone

* Update ref_commit
old-commit-hash: 0f6f305f2da81c30aef849bc55c76e57ebe5e34d
2022-11-02 01:58:15 -07:00
Shane Smiskol ed9c040be9 GM: reduce LKAS faults while inactive (#26196)
* send at 10hz when inactive

* try to make it fine to switch rates

* fix rate

* todododo

* fine if we skip, we usually send too early

* clean up

* this may be required, 50Hz is not really needed to sync/initialize

* preserves previous behavior (not sure if this makes sense)

* Revert "preserves previous behavior (not sure if this makes sense)"

This reverts commit 3b297bca72307b5cba09bec4e2cd8e0f2761af42.

* Revert "this may be required, 50Hz is not really needed to sync/initialize"

This reverts commit a6b4693814214d3f508db922f3b371c402a13995.

* rm com

* Update ref_commit

* gate behind GM Cam

* common logic

* bet

* update refs
old-commit-hash: 27e315e58f5273da79803ad95737fc15483fef21
2022-10-25 00:12:49 -07:00
Shane Smiskol 8b7a98ab8d GM: clean up gmcan (#26206)
* camera

* clean up gmcan

* fix

* revv
old-commit-hash: 66c01801a5223503435f1da366a3a6c4974ef988
2022-10-22 00:09:37 -07:00
Shane Smiskol f3589b7cf2 GM camera ACC: cancel after delay (#26197)
* add delay to GM camera ACC cancel to avoid FCW and cruise fault

* we can revert brake pressed threshold now

* bump panda

* add proper threshold

* bump

* bujmp panda
old-commit-hash: 6efd2c3de3d5b2955f3e7ab5c93701e94ac25537
2022-10-21 18:15:52 -07:00
Shane Smiskol dcb882a690 GM: inactive gas/regen safety (#26184)
* Add INACTIVE_REGEN

* bump

* Update selfdrive/car/gm/carcontroller.py
old-commit-hash: 3a70253567cc908204b73cf5df53369b19506b7b
2022-10-21 01:14:15 -07:00
Shane Smiskol b65f516cb8 GM camera ACC: hide take steering alert (#26010)
* add all signals

* try to forward this PSCMStatus

* fixes

* see if this works

* modify checksum when bit flipped

* bump opendbc

* so i can test without restarting

* bump

* bump panda

* clean up

* comment

* also fix this

* bump

* bump

* every 5 seconds

* only send our values

* fix

* try sending everything again (+1 counter)

* revert

* revert, forward msg

* forward

* fix that

* bump panda

* bump panda

* fine to not copy

* after cancel, pass bus

* fix

* Revert "fine to not copy"

This reverts commit 654ac1a7dad4f7b9b0a3de52768522fb60cc55bd.
old-commit-hash: 63d552cafc6e4728cfe097e7a3f8e3f5cd98a566
2022-10-19 23:41:54 -07:00
Shane Smiskol 334ede288c GM: make loopback updated check more explicit
This previously checked if parser_pyx filled the defaultdict, now it checks the values in the list (same either way)

old-commit-hash: 301a7ce1899a3212900dc6cfb08de6840d276a05
2022-10-19 20:40:52 -07:00
Shane Smiskol 31d274d7a4 GM camera ACC: show under enable speed alert (#26148)
* fix the fault more generically

* fix

* need this

* some clean up

* comment and use standstill

* comment

* add comment

* better fix

* rm

* better (for now)

* update docs
old-commit-hash: e46d162b1e5d4414d54d27c54190e7b3116596ba
2022-10-19 01:28:46 -07:00
Shane Smiskol 47a55f3a14 GM: match panda & ECM standstill checks (#26095)
* gm: match panda standstill check

* fix

* needs to be <= 10 to avoid a fault, fix for safety tests

* fix

* fix

* bump panda to master
old-commit-hash: 826d8a8ae34bfd909535f5edff2229b8b2daf1a6
2022-10-18 11:24:13 -07:00
Shane Smiskol cc31d7f734 GM camera ACC: revert FCW logging (#26114)
Revert FCW logging
old-commit-hash: 1dffbb629a6b629b3079bcea195f64f389fc5d1d
2022-10-17 10:47:54 -07:00
Shane Smiskol 961c613005 GM camera ACC: prevent fault when engaging at a stop (#26079)
* prevent bolt fault

* comment

* only for camera ACC

* fixup alert

* bump cereal to master

* use new name

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* only care about prevent engagement when we look at PCM
old-commit-hash: 4e82f68de2641e628f0df1aa82e5a5e935c8cce6
2022-10-14 22:21:53 -07:00
Shane Smiskol 7512d184bc GM camera ACC: raise brake pressed threshold (#26081)
* Different brake pressed thresholds

* comment

* bump to master
old-commit-hash: 91a7bb4ea3f01f40a7d8e88e857d60ef090dad2c
2022-10-14 16:54:13 -07:00
Shane Smiskol 87b9f41022 GM: remove brake scaling (#26080)
* Don't add a weird factor to ret.brake

* update refs
old-commit-hash: 5d00e5cc71106c6c4a9b25e3a2873e9e0606544c
2022-10-14 15:53:24 -07:00
Jason Shuler 6d8f98ab9b GM: disable checks on loopback bus (#26015)
* disabling checks on loopback bus

* Apply suggestions from code review

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: ac88ad871a9fba9076eb4d02a57e34ad34839f59
2022-10-12 14:02:01 -07:00
Shane Smiskol f3a4c0c6a5 GM camera ACC: log stock aeb/fcw (#26017)
* GM camera ACC: log aeb/fcw

* order

* fix stockAeb
old-commit-hash: 5ad89425a7b4a888ae43228af92b8839f79ec9ec
2022-10-11 22:55:21 -07:00
Shane Smiskol 6a92eb5a7a GM camera ACC: reduce LKAS faults on startup (#26039)
* GM camera ACC: no faults on start up 2.0

And by 2.0 I mean we don't need to wait for blocked msg support to be merged first to merge this without regressing accidental single blocked msg count handling.

* Send the camera counter + 1

* Keep updating the first counter until we get a message on the bus

* Only update right before sending so sent_lka_steering_cmd is updated first

* Update ref_commit
old-commit-hash: 0f94d81b7adffa9da5c4632fb5979b27695bbb53
2022-10-11 22:33:37 -07:00
Shane Smiskol 779ad387bf GM: use ECM brake-pressed threshold (#25970)
* This brake position value disengages stock ACC, use it to avoid controls mismatch. 2016-2017 Volt will hit this threshold and disengage, must install new design of brake pedal retaining clip, TSB 16-NA-147.

* 80 hz

* comment

* bump panda

* update refs

* bump panda

* bump panda

* bump panda

* bump panda to master

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
old-commit-hash: 6ce511cc605782c25d45c66b55f859caaf7ce516
2022-10-07 16:12:58 -07:00
Shane Smiskol 8e1e6132c8 GM: raise max brake (#25810)
* -4 didn't make any sense?

* comments

* comments

* update to 400

* bump panda

* remove unused iso limit vars

* update comments

* bump panda

* Update selfdrive/car/gm/values.py

* Update ref_commit
old-commit-hash: 84adb8d9259be92951c604b0780608de8c039f9f
2022-10-04 00:39:19 -07:00
Cameron Clough 529b861d4b docs: remove redundant keyword args (#25899)
remove unnecessary keyword args, unnecessary package
old-commit-hash: 89768376c0e141fb4143f95136693c6fe48f1f0b
2022-09-27 14:00:08 -07:00
Shane Smiskol 98b821fb1a GM minSteerSpeed: add some tolerance for Volt (#25809)
* add some tolerance for volts

* add comment

* update refs
old-commit-hash: b7dc1968cd4c61d33f96124b36d8d7a48957748f
2022-09-15 21:21:10 -07:00
Jason Shuler 929cf64bb5 GM: Chevy Bolt EV 2022-23 (#25430)
* Chevy Bolt EV w ACC Port

* dashcam

* The website allows you to select the package without ACC

* fix Bolt E(U)V centerToFront

* Update selfdrive/car/gm/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: cfaa1b7d3eeeb8ae16b77e04a0416dbacf4bc6d2
2022-09-15 20:11:53 -07:00
Shane Smiskol 81503147d5 GM: adjust Bolt EUV centerToFront
old-commit-hash: 5a80fda819fda68cad1caf7c6db15d9a495aefac
2022-09-15 19:24:18 -07:00
Jason Shuler c1fa914af8 GM: Chevy Equinox 2019-22 (#25431)
* Chevy Equinox Port

* LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+)

* 2019 here too

* clean up

* add to untested

* not in docs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 1aa8c0525ea5339eecd82cb08572636ebbaa7034
2022-09-15 17:55:02 -07:00
Shane Smiskol 978c84e885 Car docs: more consistent package names (#25797)
* update docs

* Revert "update docs"

This reverts commit a5127198fe8e43ecadb0cbde432773f4da2e212a.

* spell it out

* update docs

* add (ACC) for consistency

* All VW
old-commit-hash: ce9c689bb4f8924d47a9beb264081ed922ce9e91
2022-09-15 16:07:51 -07:00
Adeeb Shihadeh e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b60318ce44ef0271e03de16e8b135b5268
2022-09-07 17:12:49 -07:00
Shane Smiskol 846e366a55 GM: update minimum steer speed (#25618)
* EUV is 10 kph

* Update ref_commit

* temp

* Revert "temp"

This reverts commit 90ce28b06ba623e7bd1252798af3c285b465e0ec.
old-commit-hash: 3b602e28443263c043daec4bfa2ca6bc7a13eb56
2022-09-02 13:41:58 -07:00
Shane Smiskol 1fcc31aac6 Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
old-commit-hash: 452d5e42ecf963fee65889937662c708f5e17474
2022-08-30 17:54:40 -07:00
Shane Smiskol 16b585f007 GM: add Silverado 2021 High Country FP (#25499)
* Add FP from 61c6258cac78af08

* add to dict
old-commit-hash: 0822f94bb4545bb9427d1525b157edbf46416fe7
2022-08-22 17:45:41 -07:00
Shane Smiskol 4f628954c7 GMC: Sierra 2020-21 support (#25523)
* Add Sierra

* actually this package works

* add to releases

* credit
old-commit-hash: 68ba8df69329024e57efdbd00740acc0d298f214
2022-08-22 17:35:04 -07:00
Jason Shuler a019d5ea40 GM: Chevy Silverado 2020-21 support (#25429)
* Silverado support

Co-authored-by: Jason Shuler <jshuler@gmail.com>

* Update docs

* Try 2 m/s/s

* Should be good torque values

* Add Silverado test route

* Add to releases

* Send counter

* can't send multiple or it faults

* Send at 33hz, no counter

* try 25hz, don't line up exactly with car's buttons

* never tried 10hz with same counter

* Update selfdrive/car/gm/gmcan.py

* Make same as pcmCruise branch

* update year and package (different packages needed per-trim)

* Update year in releases

* Revert to 21

* We can use this package name again

* wrong one!

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 1e9fdff6422c4f49702f5de56280241088b2abca
2022-08-19 16:58:06 -07:00
Shane Smiskol e1a61dec0c GM Bolt EUV: update supported packages (#25496)
* Update values.py

* Update selfdrive/car/gm/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update docs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fb19e24d6019a23e8bfb5f767bfa976d373a6e3d
2022-08-19 15:48:46 -07:00
Shane Smiskol 1101462fc7 GM pcmCruise: cancel more reliably (#25454)
* Cancel more reliably

* Apply suggestions from code review

* Try sending multiple

* Apply suggestions from code review

* Apply suggestions from code review

* Update selfdrive/car/gm/carcontroller.py

* lower rate a bit

* try this

* Update selfdrive/car/gm/carcontroller.py
old-commit-hash: fe509e0354466a301dd403d29b5b2c82aea8aad1
2022-08-19 12:04:12 -07:00
Shane Smiskol c3342795f2 Common button enable/cancel event creation (#25445)
* handle button presses in create_common_events

* remove from imports

* Handle

* Fix Honda (it hardcodes pcmCruise)

* Update selfdrive/car/volkswagen/interface.py

* Update selfdrive/car/volkswagen/interface.py
old-commit-hash: e3d3fd02300ef7109f5fdf0717395eca3757195e
2022-08-18 23:40:24 -07:00
MadBrad 74142e16b1 Car docs: add video link for 2022 Chevy Bolt EUV (#25443)
* Car docs: Add video link for 2022 Chevy Bolt EUV

* New video added
old-commit-hash: 07320fb8a83e9f7340b8db731be623fa6f8611b2
2022-08-15 15:29:46 -07:00
Shane Smiskol 40189c8d3f GM: move set speed scaling to DBC (#25422)
* Move scaling into DBC for GM cruise setpoint

* bump opendbc

* no int

* Update refs

* Update ref_commit
old-commit-hash: f341df006a002a47034787673893f930caa81b53
2022-08-15 02:13:09 -07:00
Shane Smiskol dc4270ceee Car docs: fix required package for Bolt EUV 2022-23 (#25421)
* Need Adaptive Cruise Control

* no 2LT in configurator

* or redline
old-commit-hash: c2162420d24e8c4e43c63376cc5bc5576e467f58
2022-08-12 20:56:26 -07:00
Jason Shuler 3072fb4aec GM: Bolt EUV 2022-23 port (#24875)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* values.py almost complete

* Silverado and Bolt EUV val and CP

* GM controller updated

* Cam hrns supp done (in theory)

* cleanup for new cars

* Remove extra constant

* WS, etc cleanup

* removing the unused

* Fix kpBP typo

* Updated docs

* Skip's PIF tune

* Dropped LKA CAN error patch

* Add silverado sigmoid ff

* CAN Err & LKA latch patch

* Remove EPS fault fix (another PR)

* Remove Silverado (another PR)

* clean up some common params

* Remove Escalade FP

Remove Escalade FP

* comment

* Premier is just a trim

Premier is just a trim

Premier is just a trim

* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera

* clean up

clean up

* bump panda

* bump panda

* bump panda

* bump panda

* bump panda

* remove comments

* try spamming buttons on bus 2

* bump panda

* bumping opendbc w btn rc

* not needed for this port

This reverts commit 6af1f0ba799e075f877d7acc8ca0f117d97da361.

* add button safety

* Send next rc when spamming btns

* forward other signals in message

* missing DriveModeButton

* fill cruiseState.speed

* see if resume works without counter

* try the whole message

* send immediately and at 10Hz

* no resume, back to just button signal

* even holding random buttons it cancels

* Use torque controller with base tune

* stock long GM don't auto-resume yet

* Testing GM zero min steer speed

* Revert latcontrol

* revert opendbc

* latActive is basically lkas_enabled

* Update Bolt torque params

* comment

* clean up

* Add to releases

* Add test route

* Don't specify segment

* bump panda

* bump panda

* no harness for Bolt just yet

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* We support all and 2023

* move safetyParam up to first cam check

* Bump panda and update docs

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 4ffe9e68db8d752d9da45febccfe4c28a6e8a0f9
2022-08-12 16:10:34 -07:00
Tim Wilson 5066d2c04c GM: separate EV/ICE gas/brake lookup tables (#25354)
* GM: separate EV/ICE gas/brake lookup tables

* removed blank line

* V are the same

* comment

better ordering

comment

comment

* Add some delay for the laggy brakes

Add some delay for the laggy brakes

* move actuator to only acadia

* start braking at 0 m/s/s

* Revert "start braking at 0 m/s/s"

This reverts commit 55c1dee733aab3dc037fb1705c9bd0ace55c849f.

* add delay for escalade

* revert EV changes

* Update selfdrive/car/gm/carcontroller.py

* comment

* only ACADIA

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2a4020da60b9c383efa75a5ffb54df3bc10756a0
2022-08-08 13:55:40 -07:00