Commit Graph

156 Commits

Author SHA1 Message Date
Willem Melching 297a0bd65b controlsd: avoid lag on first iteration due to get_short_branch (#25031)
* controlsd: avoid lag on first iteration due to get_short_branch

* always cache
old-commit-hash: d4cc13c88a8a9a9215777709fe2eccade1fd0ccd
2022-07-04 17:13:30 +02:00
Adeeb Shihadeh 3c48bc47b7 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
old-commit-hash: 0fce5d90459b77bf2cfa70f55f322f0e1fb8d01c
2022-06-11 23:19:27 -07:00
Willem Melching 753045c73d less TICI when not needed (#24698)
* less TICI when not needed

* fix process replay

* move reading voltages into hw abstraction layer

* Update selfdrive/hardware/tici/hardware.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/hw.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/base.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* rename init function

* Update selfdrive/athena/athenad.py

Co-authored-by: Robbe Derks <robbe.derks@gmail.com>

* Update selfdrive/boardd/boardd.cc

* Apply suggestions from code review

* Update selfdrive/thermald/thermald.py

* update ref

* fix alert width if all cameras are bad

* add ecam to test_loggerd

* bump cereal

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
old-commit-hash: f49a9c9fd2100a4f1401a93d88064ddbbbd935c1
2022-06-02 15:20:51 +02:00
Adeeb Shihadeh 29e2b3f757 controlsd: ensure all system malfunction events have the right types (#24635)
old-commit-hash: 71901c94dbbaa2f9f156a80c14cc7ea65219fc7c
2022-05-23 17:46:46 -07:00
Adeeb Shihadeh a6bcd14abd show which cameras are malfunctioning (#24558)
old-commit-hash: 0b1f6e3620793a0a06708464387613cec2937591
2022-05-16 22:01:04 -07:00
Adeeb Shihadeh cfc16a88c5 improved alert verbosity (#24434)
* improved alert verbosity

* better testing script

* better description

* speed diff

* touch ups

* fix that
old-commit-hash: b1858df00e40f96832f812cb5b42596b8f522ab7
2022-05-16 21:19:38 -07:00
Shane Smiskol 19aebce4f2 Round system overheated temperature (#24544)
* Update events.py

* Apply suggestions from code review

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 961a121fde36fca88834e732fc50b34fbd82e94b
2022-05-16 18:08:02 +02:00
ntegan1 b9a07b8f05 Round model lagging frame drop percentage (#24549)
alerts: round model frame drop percentage
old-commit-hash: 076f0acd5fcd5bca59d9403232c3e37e86db19d1
2022-05-16 16:26:18 +02:00
Dylan Herman 2dfba97175 add mypy check for return-any (#24379)
* add mypy check for return-any

* remove unused import

* typing

* remove unnecessary variable typing

* cleanup

* cleanup

* bump submodules

* small fixes

* only a problem on mac

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c777ef6110c7a74d2a9ca9e4e1d958c
2022-05-12 14:59:00 +02:00
Adeeb Shihadeh fdf13d565b controlsd: add lagging alert (#24360)
* controlsd: add lagging alert

* move those

* just this for now

* no camera malfunction
old-commit-hash: 3abbe827deac4954a2af97a191171c8b7d08d0c1
2022-04-28 19:51:42 -07:00
Adeeb Shihadeh 75174c93d7 more verbose debug alerts (#24126)
old-commit-hash: 70987fd9d971ffd1a60b9c97835c838de21a764b
2022-04-22 16:12:54 -07:00
Adeeb Shihadeh e8ad31f32b controlsd: handle controls mismatch race (#24245)
* controlsd: handle controls mismatch race

* update refs
old-commit-hash: 233a167cc901afcf0a0abf48fad8516609d19c99
2022-04-18 17:08:25 -07:00
Gijs Koning 598ba913ae Fix camera error description (#24202)
* Fix camera error message

* Shorter
old-commit-hash: e0845752e3a1ac4a0fd47ac4e0400f3528f213fa
2022-04-13 09:56:37 -07:00
Adeeb Shihadeh 3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814e07c1243ef2b979957760d64c9eb35
2022-04-12 22:58:34 -07:00
Adeeb Shihadeh e04e6fea87 bump cereal
old-commit-hash: 162e47456cf88dab27db8f86474b0d41a52c03e5
2022-04-06 22:25:59 -07:00
Willem Melching 83c103e46a update camera CRC alert text (#24156)
old-commit-hash: fb344021aa2e69408b32f7878f1c705691640330
2022-04-06 17:46:56 -07:00
Willem Melching a47666d1fd add cameraFrameRate alert (#24152)
* add cameraFrameRate alert

* bump cereal
old-commit-hash: 1848050fd980a04dfc70454547ab7b52affe2917
2022-04-06 17:11:39 -07:00
Willem Melching 871ecc451b commIssueAvgFreq: separate alert for avg freq check (#24150)
* commIssueAvgFreq: separate alert for avg freq check

* bump cereal

* bump cereal

* bump cereal

* freq_ok separate from alive

* bump cereal to master

* update_ref

* fix profiler
old-commit-hash: eaa581921161b2643b10ad72da0708dff14367aa
2022-04-06 16:43:32 -07:00
George Hotz d359310631 alerts: Don't use Malfunction twice
old-commit-hash: 8031a68e55b42d1a80303f00a3aecd646e3c2359
2022-04-04 12:45:57 -07:00
Shane Smiskol 01d005c322 update refs
old-commit-hash: a4353303d4f7a1faef88918dc83a2f08d412460d
2022-04-01 22:39:08 -07:00
Shane Smiskol 53fff66742 bump cereal
old-commit-hash: ca3171c0f912afec3a349ce8ca0a4d7e41cd7127
2022-04-01 20:59:15 -07:00
Adeeb Shihadeh bb9dd45677 Contact Support -> Hardware Malfunction (#24076)
* Contact Support -> Hardware Malfunction

* missed that one
old-commit-hash: f1719aab84d2a4e62ef0529f8bb1cd5bef3f37e7
2022-03-30 16:13:28 -07:00
Adeeb Shihadeh ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc7b25c9ce502419bcd0261c12ec2b0d
2022-03-13 21:42:39 -07:00
Willem Melching 849bbc8a2f process replay: fix branch name alert (#23783)
* env is modified after start

* update ref
old-commit-hash: 14260c01c6a91554a63377acfce504758af4d096
2022-02-17 16:47:42 +01:00
Adeeb Shihadeh ddde46c503 keep the new alert consistent for process replay
old-commit-hash: f59adbeaaa4ac8634cba663fa39679f4af0c9325
2022-02-16 23:47:02 -08:00
Adeeb Shihadeh 693b66c1e0 add branch name to startup master alert (#23782)
* add branch name to startup master alert

* still orange

* update refs
old-commit-hash: ff965c772bd1bc85dec717d090cee4466033ce73
2022-02-16 20:27:07 -08:00
Willem Melching 5a78f1d29c hide localizerMalfunction alert (#23730)
* hide localizerMalfunction alert

* update ref
old-commit-hash: 8effa2d8786b408222c504bed241426b9c8f6f0b
2022-02-08 22:22:03 -08:00
Jafar Al-Gharaibeh 055b8b06e6 Mazda: alert when LKAS is disabled (#23288)
* Mazda: alert when LKAS is disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update refs

* revert that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1c31c9b7a3b0ee72b9dca443067deab793e19187
2022-01-30 21:04:07 -08:00
Adeeb Shihadeh 70f1418256 remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
old-commit-hash: 3e9cb7fa12b5f686fdcf6122ef5979d01c41f0a3
2022-01-24 14:49:47 -08:00
Dean Lee 54bdb321bd cleanup iterate keys in dictionaries (#23497)
old-commit-hash: a186bcc9f16c08f405dda92b8ac9e8a80895cdc7
2022-01-12 12:42:50 +01:00
Dean Lee 98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec18b1313148905172ba54bac9f5fdfd
2022-01-10 16:36:51 +01:00
Dean Lee 75d00872e8 events: cleanup function any (#23479)
old-commit-hash: 8eec818ae625fd2311bd3d5f9976d034674cb13e
2022-01-10 14:32:07 +01:00
George Hotz 86a39e838b Add More Types for mypy (#23268)
* mypy passes

* a few more

* a few in manager

* more types, will lint

* more

* simple types

* events type

* Update selfdrive/thermald/thermald.py

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dc96d4bee7b898172a6a15de4799af0e2d35605e
2021-12-28 18:07:00 +01:00
Adeeb Shihadeh 8f09da4407 bump cereal
old-commit-hash: 256c51e16afdf4a8fa7089cc9c318c07b15504a7
2021-12-20 23:04:27 -08:00
Adeeb Shihadeh 55d6972d08 Revert "Mazda: alert when LKAS is disabled (#23273)"
This reverts commit e67713edb1f62957974f20a0f7eceb2fc9efb1f4.

old-commit-hash: c92199ab1a94d2ea565e68e513bf4f9e3e81d489
2021-12-20 23:02:02 -08:00
Jafar Al-Gharaibeh 9b7dd754c4 Mazda: alert when LKAS is disabled (#23273)
* Mazda: alert when LKAS is disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update selfdrive/controls/lib/events.py

* Update selfdrive/car/mazda/interface.py

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f25121b7364a2babef5022e852cf97570bee6da2
2021-12-20 14:58:46 -08:00
Adeeb Shihadeh 06a9b3448d alerts: escalate soft disable alert near disengagement (#23198)
* alerts: escalate soft disable alert if resulted in disengagement

* show 0.5s before disengagement
old-commit-hash: 8068df0b2a35eb8fcef809f4ce9a6cb7bfc75fdc
2021-12-11 17:07:37 -08:00
Adeeb Shihadeh 700ad9ec50 alerts: handle min duration properly (#23191)
* alerts: handle min duration properly

* add active

* tests

* cleanup test

* update refs
old-commit-hash: 07b971d4735d891cc59f404095812f5d001b3092
2021-12-10 19:20:07 -08:00
Adeeb Shihadeh 853dc0d016 alert text simplification (#23186)
* alert text simplification

* little more

* user triggered

* little more

* less annoying ldw

* Update selfdrive/controls/lib/events.py

* update refs

* revert
old-commit-hash: 4627d201b68b670c4d4c29f3ce7523daf8ddc732
2021-12-10 15:21:37 -08:00
Adeeb Shihadeh 6c2182c026 Newer sounds (#23091)
* new prompt sound

* padding

* prompt distracted

* debug

* fix spelling

* lower min volume

* better volume at low speeds

* revert debug

* revert that

* fix tests

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 3b367e68728c29eea057d99f3948d64ed6cbfa92
2021-12-02 00:28:25 -08:00
Adeeb Shihadeh dccb8b4010 New sounds (#22652)
* new engage/disengage + amp config

* first family

* cleanup audible alerts

* tici isn't special

* fix up debug cycle alerts

* these were better

* extend range

* use distracted sound

* log scaling

* getting closer

* slightly louder

* prompt

* update tests

* update refs

* fix c2 test

* resolve todo

* adjust tolerance

* revert for now

* should work

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e679d05d9e98e267047c21c0b6b67fe9d61f8ed6
2021-11-30 19:47:33 -08:00
Adeeb Shihadeh 1ffe047666 improve crc camera error (#22943)
old-commit-hash: 5296ca8d73573a59a5198b73770d2a4f20cbc9c2
2021-11-16 22:57:22 -08:00
Adeeb Shihadeh d1eacc4619 alerts: make soft disables an orange alert (#22925)
old-commit-hash: 833399e9418db26df70169d37c2dff90051d89c7
2021-11-16 13:11:32 -08:00
Adeeb Shihadeh 9f84f9ad97 put cruiseMismatch event in logging only mode
old-commit-hash: 33022390138df73199ac626cb7b5ab7fac1a89a6
2021-11-15 21:16:54 -08:00
Adeeb Shihadeh ee15159a3b alert cleanup (#22919)
old-commit-hash: 5265c36de7be6a2519488fa4a46462f13918b1fb
2021-11-15 16:14:31 -08:00
Adeeb Shihadeh 731d85c522 alerts: use repeating warning2 sound for steerSaturated (#22874)
old-commit-hash: 308219c5b1850da4e947ea587e131df29024a402
2021-11-11 11:55:34 -08:00
Adeeb Shihadeh a142638899 increase engagement alerts duration
old-commit-hash: 327464fb845dd01533f390ac89d9fd78fbfb02d7
2021-11-10 22:11:14 -08:00
Adeeb Shihadeh d6c42f11f4 controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
old-commit-hash: 035bc0c20fd27490cc353a33f3c373201288a10a
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh 448d5f9e93 alerts: use a single duration for sound, text, and HUD (#22856)
* alerts: use a single duration for sound, text, and HUD

* little cleanup

* update refs
old-commit-hash: c5d6b85c9014386b8d1cb2a17f8767abef3afd57
2021-11-10 11:54:12 -08:00
Adeeb Shihadeh 450471058b controlsd: optimize alert management (#22846)
* controlsd: optimize alert management

* little cleanup

* dataclass is nice

* fix tests

* update refs

* sort by start frame

* update refs

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 93ba52c76c20baf36e07c25d28a98bc8e9ea6219
2021-11-10 10:54:18 -08:00