Commit Graph

98 Commits

Author SHA1 Message Date
ZwX1616 e85d833a80 Revert "Revert "OS04C10: use IFE downscaler for road cameras"" (#35047)
* Revert "Revert "OS04C10: use IFE downscaler for road cameras" (#35046)"

This reverts commit aaaa2d0dd0.

* fixed

* patch it here

* surely
2025-04-23 21:09:22 -07:00
ZwX1616 aaaa2d0dd0 Revert "OS04C10: use IFE downscaler for road cameras" (#35046)
Revert "OS04C10: use IFE downscaler for road cameras (#35023)"

This reverts commit 3b60b22cee.
2025-04-21 17:02:36 -07:00
ZwX1616 3b60b22cee OS04C10: use IFE downscaler for road cameras (#35023)
* squashh

* wrong

* clean up

* rename
2025-04-18 14:29:37 -07:00
ZwX1616 1c678c910e camerad: fix AE oscillation (#34833)
* flooring is fine

* .

* better solution

---------

Co-authored-by: Comma Device <device@comma.ai>
2025-03-10 16:01:03 -07:00
Dean Lee 3e629acf79 camerad: use ALL_CAMERA_CONFIGS array (#34810)
use ALL_CAMERA_CONFIGS array
2025-03-07 10:31:01 -08:00
Dean Lee e9f7c01a3a camerad: move output_type to config (#34792)
move output_type to config
2025-03-06 10:17:58 -08:00
Dean Lee 47c04210e2 camerad: refactor frame processing to direct handling (#34655)
refactor frame processing
2025-02-21 09:18:35 -08:00
Dean Lee 99e552b485 camerad: remove camera threads (#34627)
* remove camera threads

* remove unnecessary frame delay handling logic

---------

Co-authored-by: Comma Device <device@comma.ai>
2025-02-20 08:52:03 -08:00
Dean Lee 4835e9fa88 camerad: rename set_exposure_target to calculate_exposure_value (#34631)
rename set_exposure_target to calculate_exposure_value
2025-02-20 08:08:49 -08:00
Adeeb Shihadeh efda24dbe1 camerad: match some BPS settings (#34548)
* start common

* fix bayer pattern

* lil more

* all 1q10

* cc en

* same pts?

* this is weird

* some cleanup

* less

* off

* clean up

---------

Co-authored-by: Comma Device <device@comma.ai>
2025-02-14 16:05:00 -08:00
Adeeb Shihadeh 3d097faec0 Revert "camerad: enable BPS (#34570)"
This reverts commit da2a5f4305.
2025-02-11 20:30:37 -08:00
Adeeb Shihadeh da2a5f4305 camerad: enable BPS (#34570)
* camerad: enable BPS

* update power draw
2025-02-11 14:03:32 -08:00
Dean Lee 3c0990e716 move thumbnail generation from camerad to encoderd (#34554)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2025-02-10 23:43:46 +00:00
Adeeb Shihadeh 5b870c6f92 camerad: simple BPS support (#34538)
* camerad: simple BPS support

* works

* cleanup

* lil more

---------

Co-authored-by: Comma Device <device@comma.ai>
2025-02-06 15:23:19 -08:00
Adeeb Shihadeh e31ae06959 camerad: remove AR register processing (#34537) 2025-02-06 14:15:37 -08:00
Adeeb Shihadeh 6d12a47d05 Revert "camerad: disable ISP for now (#34440)"
This reverts commit e48752d8fa.
2025-01-31 19:17:07 -08:00
ZwX1616 0ca726ed29 camerad: increase dcam ae min (#34455)
* never dip below 0.125

* clamp is double
2025-01-23 14:13:35 -08:00
commaci-public dcb05af228 [bot] Update Python packages (#34431)
* Update Python packages

* codespell

* update refs

---------

Co-authored-by: Vehicle Researcher <user@comma.ai>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2025-01-21 21:04:19 -08:00
Adeeb Shihadeh e48752d8fa camerad: disable ISP for now (#34440) 2025-01-21 15:10:50 -08:00
Adeeb Shihadeh 7a2af78846 camerad: re-enable ISP debayer (#34212)
camerad: re-enable ISP debayer

Co-authored-by: Comma Device <device@comma.ai>
2024-12-11 20:04:40 -08:00
Adeeb Shihadeh c4edfa8b25 camerad: fix running AR0231 in single road cam mode (#34148)
Co-authored-by: Comma Device <device@comma.ai>
2024-12-03 14:16:28 -08:00
ZwX1616 d90d5a403f camerad: ev scaling (#34070)
ev scaling

Co-authored-by: Waddle Wednesday <>
2024-11-20 15:40:55 -08:00
Adeeb Shihadeh d9d57e5d6f Revert ISP image processing + tinygrad bump (#34020)
* Revert "Replace ThneedModel with TinygradModel (#33532)"

This reverts commit da952e9b64.

* Revert "camerad: move E + D cams image pipelines to the IFE (#33959)"

This reverts commit f2a1cce42b.
2024-11-13 19:27:11 -08:00
Adeeb Shihadeh f2a1cce42b camerad: move E + D cams image pipelines to the IFE (#33959)
* camerad: move E + D cams image pipelines to the IFE

* arvig
2024-11-07 14:41:08 -08:00
Adeeb Shihadeh b87a52a9a0 all raw for now 2024-10-21 20:13:29 -07:00
Adeeb Shihadeh f7f15d63dc CSID cropping for IFE (#33844)
* ife csid crop

* fix reg processing

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-10-21 19:55:39 -07:00
Adeeb Shihadeh 89d5761329 camerad: setup IFE black level and color correction (#33834)
* black level

* enable cc

* seems to work

* doesnt do anything

* sensorinfo

* this is fine

* cleanup

* disable

* cleanup os

* revert

---------

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: ZwX1616 <zwx1616@gmail.com>
2024-10-21 14:23:44 -07:00
Adeeb Shihadeh 8e8f61ad35 camerad: IFE debayer support (#33720)
* ife is up

* split out cdm, bps needs this too

* straight to vipc buffer

* start reducing the diff

* support both

* disable for now

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-10-12 13:07:30 -07:00
Adeeb Shihadeh 8cf1b79189 camerad: more ISP prep (#33752) 2024-10-08 14:07:13 -07:00
Dean Lee 2cb526a5a9 camerad: refactor gain index loop for clarity (#33613)
* Refactor Gain Index Loop for Clarity

* Update system/camerad/cameras/camera_qcom2.cc

* Update system/camerad/cameras/camera_qcom2.cc

---------

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-09-29 10:06:34 -07:00
Dean Lee 07f3f93bd9 camerad: remove SpectraCamera inheritance from CameraState and simplify initialization (#33611)
remove inherit

Co-authored-by: Comma Device <device@comma.ai>
2024-09-20 11:15:49 -07:00
Dean Lee eaebea0968 camerad: cleanup includes (#33600)
cleanup includes

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 14:16:48 -07:00
Dean Lee 34f5ba46b3 camerad: move handle_camera_event to SpectraCamera class (#33595)
move handle event

Co-authored-by: Comma Device <device@comma.ai>
2024-09-19 11:34:37 -07:00
Dean Lee 943aa616b3 camerad: add helper function get_gain_factor (#33594) 2024-09-19 10:58:49 -07:00
Dean Lee b852aba670 camerad: fix POLLPRI event check in poll loop (#33591)
fix event check in poll loop to validate POLLPRI
2024-09-19 10:58:06 -07:00
Dean Lee c95f0f039f camerad: move debugging parameters from camera_common.h to camera_qcom2.cc (#33589)
move debugging parameters

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-09-19 10:45:57 -07:00
Adeeb Shihadeh 80013219fe camerad: abstract out ISP handling (#33583)
* spectra and tici

* master

* move the rest

* rm stupid indirection

* start move

* multi cam state is dead

* rest is moved

* lil more

* mv that

* lil more

* fix pc build

* we haven't done rgb for a while

* bring this stuff back

* fix mac?

* no camera in ui!

* i remember why we always cut mac

* fix mac build

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-09-18 22:24:53 -07:00
Adeeb Shihadeh 718835a825 camerad: prep part 2 (#33584)
* no camerastate in sensors

* bring this over

* and encoder
2024-09-18 21:10:45 -07:00
Adeeb Shihadeh 5378e63812 it's not really rgb 2024-09-18 21:01:38 -07:00
Adeeb Shihadeh b733b875f8 camerad: ci -> sensor rename (#33582)
* camerad: ci -> sensor rename

* no behavior change for now
2024-09-18 15:51:03 -07:00
Dean Lee 7adc4219f0 camerad: update frame msg related variable types to uint64_t for consistency (#33113)
Update frame_msg related variable types to uint64_t for  type safety
old-commit-hash: c40d129f70338674302116cfdde129ba6511a920
2024-08-02 12:57:29 -07:00
Dean Lee 2a16a305b3 camerad: move do_exit to camera_qcom2.cc (#33086)
move do_exit to camera_qcom2.cc
old-commit-hash: 8ab587d30b461cf52844a351b912e3560b9dcbcd
2024-08-02 12:18:10 -07:00
Dean Lee 01ac526046 camerad: merge thread functions into one (#33025)
merge multiple thread functions into one
old-commit-hash: ccd369ee9639beae479704615f198902d58135b9
2024-07-25 15:05:14 -07:00
Dean Lee 5b5e3ef053 camerad: add CameraConfig struct for initializing CameraState in constructor (#33065)
* Add CameraConfig struct for initializing CameraState in constructor

* init member variables
old-commit-hash: 75f49f84f3b71c970e7f4a5768016a092175e870
2024-07-25 13:09:03 -07:00
Dean Lee 4d6d229820 camerad: refactor camera_open() into separate functions for clarity (#33056)
split function
old-commit-hash: 0fa6745a67b60a572cfa4060d8155ac50f4e4e06
2024-07-24 10:07:10 -07:00
Adeeb Shihadeh 5025140f37 Revert "camerad: add CameraConfig struct for initializing CameraState in constructor (#33034)"
This reverts commit 8ef650da47eec8b64e2aedcba5114ca1a2428a89.

old-commit-hash: cefe00c964d41f5ac15f13bc83b3e389d8965a5e
2024-07-21 20:36:45 -07:00
Dean Lee 3f327ef4d3 camerad: add CameraConfig struct for initializing CameraState in constructor (#33034)
* Add CameraConfig struct for initializing CameraState in constructor

* Update system/camerad/cameras/camera_qcom2.h

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dc886e195f9815c77b721a8a438bbdffe9067e38
2024-07-21 19:19:34 -07:00
Dean Lee cc3f9090bf cereal: deprecate FrameData.frameType (#33019)
deprecate FrameData.frameType
old-commit-hash: 917ea5699f3af241e60311455af5f20c0c55a8c4
2024-07-19 10:14:04 -07:00
Dean Lee 2772be8303 camerad: Localizing the variable "ret" (#32294)
Localizing the variable "ret"
old-commit-hash: edb683a62bf0944974d9c781b3fe1ab4daba739b
2024-04-25 11:08:27 -07:00
ZwX1616 f466145f34 image processing refactor and test (#32249)
* it's something

* backup

* 16:10

* cleanup

* this is fine

* close

* remove some junk

* no heck

* disos

* real 10

* for some reason this is flipped

* 20hz

* no return

* ae

* tear

* need curve laster

* correct real gains

* fix time

* cleanup

* why the scam

* disable for now

* 0.7

* hdr

* that doesnt work

* what

* hugeoof

* clean up

* cleanup

* fix regs

* welp cant

* is this corrent

* it is sq

* remove

* back

* stg10bit

* back2ten

* Revert "remove"

This reverts commit 18712ab7e103c12621c929cd0f772ecb9b348247.

* 20hz and swb

* correct height

* 10bit

* ui hack for now

* slight

* perfect

* blk64

* ccm

* fix page faults

* template

* set 4x

* is this fine

* try

* this seems to work

* Revert "this seems to work"

This reverts commit d3c9023d3f14bd9394fed2d6276dba777ed0e606.

* needs to be static

* close

* 64 is optimal

* 2

* take

* not 1

* offset

* whats going on

* i have no idea

* less resistence

* box defs

* no

* reduce blur artifacts

* simplify

* fix

* fake short is too much for bright

* can be subzero

* should not use lsvc

* no wasted bit

* cont no slow

* no less than 10bit

* it is based

* wrong

* right

* quart

* shift

* raise noise floor

* 4.5/4.7

* same ballpark

* int is fine

* shane owes me m4a4

* Revert "shane owes me m4a4"

This reverts commit b4283fee18efebedae628a6cfd926ff1416dcfe5.

* back

* Revert "4.5/4.7"

This reverts commit e38f96e90cb5370bd378f6b66def9e7e3ed0ce5d.

* default

* oof

* clean up

* simpilfy

* from sensorinfo

* no div

* better name

* not the wrong one

* not anymore relevant

* too

* not call it debayer

* cl headers

* arg is 2nd

* gone is is_bggr

* define

* no is hdr

* rgb_tmp

* p1

* clean up

* 4

* cant for

* fix somewhre else

* const

* ap

* rects

* just set staruc

* nnew tmp

* pull it for now

* 12

* common rect

* Revert "not anymore relevant"

This reverts commit 1d574673a16cc31b7a255609e07775c3579eef15.

* Revert "too"

This reverts commit c2d4dcc52a859fe799362f9fcc2ffda99b264e50.

* Revert "Revert "too""

This reverts commit 0abbabe1fde51592f1619058638b4ac6a6dee4b3.

* no tol is fine

* rename

* sensor id

* unsgin

* flag

* some linalg

* cast

* should be h ref

* cap

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 331c7b103a7e4349c75be373589fc68161e69500
2024-04-18 21:45:59 -07:00