E.118 specifies decimal digits, but many real SIMs carry hex characters
in EF_ICCID (e.g. China Mobile's 898600B5... range, some MVNO/IoT SIMs).
AT+QCCID returns them verbatim, and the strict isdigit() check blanked
the ICCID, leaving the modem daemon stuck in INITIALIZING forever and
cellular dead. ModemManager parses ICCID as hex for the same reason.
Verified on a comma four with a China Mobile SIM (EG916Q-GL): previously
stuck retrying 'identity read incomplete', now dials and passes traffic.
The destructor built its cleanup commands as "rm %s -rf", with the flags
after the operand. GNU rm permutes arguments so this works on device and
in CI, but BSD rm on macOS stops option parsing at the first operand and
treats "-rf" as a second filename:
$ mkdir -p /tmp/rmtest/sub && rm /tmp/rmtest -rf
rm: /tmp/rmtest: is a directory
rm: -rf: No such file or directory
exit=1
So nothing is removed, and each of the four calls prints two errors plus
"system command failed (256)" from check_system. Every run of a tool that
owns an OpenpilotPrefix (replay, cabana) leaks its params dir, its
comma_home and its /tmp/msgq_ dir; 33 of each had accumulated on my
machine.
Pass the flags first.
* system: add chestnut offroad alerts
* system: refine chestnut offroad alerts
* system: refine chestnut power alerts
* system: confirm chestnut power recovery from PCIe
* system: detect missing chestnut power from INA voltage
* uh, i did not commit anything all this time
* slideee to the left, cha cha
* lint lint
* ui: unify model source predicate and per-source bundle lookup in model_info
* [TIZI/TICI] ui: disable the other-model row onroad like the active row
* [TIZI/TICI] ui: drop docstring that restates the function name
* [TIZI/TICI] ui: keep Favorites as the first model folder in the picker
* ui: record why model names read the params slots and not modelManagerSP
* ui: show the default model's name on the picker Default entries
* models: bind a download to its ref so cancel and reselect work everywhere
* models: resume partial chunked downloads and verify silently
* models: publish a verifying status so cached checks read as verification, not a stuck download
* [TIZI/TICI] ui: move download status onto each model's own row
* [TIZI/TICI] ui: show the row status description while it has text
* [TIZI/TICI] ui: restore the Model Status bar row
* models: a cancel interrupts verification immediately and keeps on-disk chunks
* models: a selection made mid-download queues instead of cancelling the transfer
* [TIZI/TICI] ui: Model Status shows both slots idle and the queued pick while busy
* [TIZI/TICI] ui: label the Model Status slots small and big and scroll long names
* models: start a queued download in the same tick and label empty slots (Default)
* ui: scroll Model Status names at the corrected speed
* [TIZI/TICI] ui: Model Status shows the big model failing over to small
* [TIZI/TICI] ui: stable model rows and a runner-matched failover note on Model Status
* [TIZI/TICI] ui: model rows show full names and the failover note reopens with the page
* ui: name the actually driving model runner-matched and bring mici to state parity
* fix ugly
---------
Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
Co-authored-by: James Vecellio-Grant <159560811+Discountchubbs@users.noreply.github.com>
royjr