Commit Graph

1078 Commits

Author SHA1 Message Date
Adeeb Shihadeh
bc2f10da57 Revert "pre-commit: autoupdate hooks (#1618)"
This reverts commit 526588b3e9.
2023-08-30 10:38:12 -07:00
Justin Newberry
e30ba9547c Subaru: add steer req bit test (#1613)
add active bit test
2023-08-30 01:29:27 -07:00
Adeeb Shihadeh
526588b3e9 pre-commit: autoupdate hooks (#1618)
* Update pre-commit hook versions

* fix ranges

---------

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 01:27:07 -07:00
Jason Wen
e6c1648835 Hyundai CAN-FD: Alternate LKAS steering message (#1504)
* new steering message!

* fix

* check tx

* fix var

* allow all tx to test LFA suppression

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block all bus 2/6 messages

* Final test to block LFA

* Fix tx

* in another PR

* cleanup

* lint

* Add new tx to unit test

* linter

* Apply suggestions

* Revert to this

* Unnecessary

* clean up

* rename to hda2

* prototype

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-29 23:40:14 -07:00
Shane Smiskol
ca9d8675b9 Revert "Toyota: ACC message relay check (#1612)" (#1617)
This reverts commit 5a9d8cfaaf.
2023-08-28 23:18:42 -07:00
Shane Smiskol
5a9d8cfaaf Toyota: ACC message relay check (#1612)
* toyota: add safety for tester present

* block ACC_HUD

* check stock ECU

* clean up

* not this

* test new addr

* comment

* rm

* cmt
2023-08-27 15:43:59 -07:00
Shane Smiskol
cca252c8d4 Honda: match openpilot button enable check (#1607)
* NONE -> not BUTTON

* update test and fix safety

* cleaner
2023-08-25 16:11:08 -07:00
Igor Biletskyy
0a32b17513 H7: few more Kb of RAM found (#1605)
* init

* remove discard
2023-08-24 16:56:31 -07:00
Willem Melching
a48678f625 MacOS: Homebrew GCC is now version 13 (#1603) 2023-08-24 13:52:59 -07:00
Justin Newberry
04df95db1c Subaru: add new angle LKAS message definitions (#1602)
* just add the lkas message to start

* added to tests too

* default parameter
2023-08-23 13:17:36 -07:00
Justin Newberry
3d91d78018 Revert "Subaru: infrastructure to support the new angle based control… (#1601)
Revert "Subaru: infrastructure to support the new angle based controllers (#1590)"

This reverts commit ea16a54166.
2023-08-22 17:30:11 -07:00
Justin Newberry
ea16a54166 Subaru: infrastructure to support the new angle based controllers (#1590) 2023-08-22 00:21:19 -07:00
Adeeb Shihadeh
57ec466a91 prefix openpilot imports (#1593) 2023-08-20 17:50:31 -07:00
Adeeb Shihadeh
aed103d537 Revert "Subaru: gen2 long safety (#1587)"
This reverts commit 2ae2567d8d.
2023-08-17 15:58:45 -07:00
Justin Newberry
95c89b8045 GM: switch to common gas/brake test (#1578)
* gm switch to common gas/brake test

* fix typo

* add comment about regen
2023-08-17 01:55:11 -07:00
Justin Newberry
2ae2567d8d Subaru: gen2 long safety (#1587)
* setup proper safety for gen2 long

* whitespace

* misra

* alt bus

* high beam assist

* better names

* whitespace

* whitespace

* whitespace
2023-08-17 01:32:34 -07:00
Shane Smiskol
1f475a8aff Hyundai: match openpilot standstill check (#1586)
* checks that we can replicate in openpilot

* clean up

* fix test

* can simplify this

* can also simplify this
2023-08-16 23:51:07 -07:00
Igor Biletksyy
cfff3386c5 fix linter 2023-08-16 16:14:21 -07:00
Igor Biletksyy
16b3ec4ca3 add FW size checker script 2023-08-16 15:49:08 -07:00
Justin Newberry
02bcd14376 Subaru: cleanup to prepare for angle controller (#1585)
cleanup prepare for angle
2023-08-16 12:40:29 -07:00
Justin Newberry
8bd3e93813 Subaru: Global gen1 longitudinal safety (#1500)
* Add subaru long TX and RX messages

* misra c2012 fix

* fix tests

* Reorder signals

* increase max steering torque

* merge fix

* merge fix, remove cnt from test

* Move subaru logitudinal behind flag, add safety test

* update subaru_longitudinal checks

* cleanup

* Add subaru longitudinal checks

* misra fix

* Add subaru rpm and throttle rate limit checks

* temporary disable cruise throttle and cruise rpm checks

* update subaru long test

* update longitudinal safety and add tests

* fix tests

* fix misra

* subaru long signals limits checks

* Add controls_allowed to long tests

* remove unused variables

* Add AEB passthru and tests

* Add bus

* Update AEB logic

* Add GEN2 AEB support

* syntax fix

* Update AEB tests

* Add comment for subaru_aeb

* Do not check cruise_throttle and cruise_rpm limits when gas pressed

* use long limits struct

* Subaru: longitudinal checks only when controls_allowed, use ES_LKAS_State LKAS_Alert for AEB

* fix misra, set controls_allowed for es_brake test

* fix misra

* Fix es_brake violation check

* Add 0x323 to longitudinal test

* Remove stock fcw from aeb signals

* Use GET_BYTES

* Revert "export FW_PATH"

This reverts commit 2a5058d858.

* Revert "cleanup fw filename conventions (#1434)"

This reverts commit 4dd2735e38.

* Revert "Revert "export FW_PATH""

This reverts commit 86e8d321d0.

* Revert "Revert "cleanup fw filename conventions (#1434)""

This reverts commit 5aae6716fa.

* cleaned up safety

* cleanup subaru long safety

* subaru_aeb -> stock_aeb for other platforms

* fix unittests

* pretty

* need to upload this route

* remove AEB stuff for now

* remove unrequired rpm checks

* add comment

* added comment about acceleration and use throttle limit for rpm too

* inactive_throttle_fix

* Update board/safety/safety_subaru.h

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* added comments about long limits

* increase max brake

* revert that

* cleanup

* rename throttle to gas

* add safety replay

* remove todo

* rename throttle to gas

* move subaru stuff out of common test

* PR cleanup

* added min gas

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* create common gas brake safety test

* remove unrelated subaru reference

* also test below min_value

* fix fwd hook test

* better name and hardcoded

* use same as acceleration limits

* revert gm

* remove callable

* also limit rpm

* remove safety replay for now

* revert unrelated changes

* pr cleanup

* remove unused gasbrake safety test

* fix ruff linter

* PR cleanup

* pr cleanup?

* added common brake test and moved generic test to base safety class

* remove duplicate test

* wip

* wip

* rename longitudinalaccelsafety

* revert limits correct test

* fix controls allowed test

* move gm over to long gas brake test

* assert that limits are reasonable

* fix typing

* fix linter again

* fix linter again

* fix linter again

* like to make it clear

* typo

* fix from merge

* clearer names

* dont need thesemore

* subaru: use common test

* fix merge issue

* inactive gas from long limits

* fix tests

* linter

* fix gen2

* fix linter

* also test torque when doing long control

* renamre transmision rpm

* consistent whitespace

* rename declarations too

* rename transmission rpm

* same line

* actually is transmission rpm

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 18:51:13 -07:00
Adeeb Shihadeh
d7f75ca722 safety tests: test one of each MCU type 2023-08-14 21:08:46 -07:00
Justin Newberry
10a2727882 Subaru: prepare tests for long and angle control (#1580)
* prepare tests for long and angle control

* fix names
2023-08-14 19:26:00 -07:00
Justin Newberry
4ea50fbb09 Ruff: propgate config from OP (#1579) 2023-08-14 12:52:02 -07:00
Justin Newberry
a0344a11e7 Subaru: cancel safety (#1576)
* subaru cancel safety

* misra
2023-08-12 17:16:28 -07:00
Justin Newberry
7dbdf6ba2b Safety Tests: Create common gas brake safety test (#1537)
* create common gas brake safety test

* remove unrelated subaru reference

* also test below min_value

* better name and hardcoded

* use same as acceleration limits

* revert gm

* remove callable

* added common brake test and moved generic test to base safety class

* remove duplicate test

* wip

* wip

* rename longitudinalaccelsafety

* revert limits correct test

* fix controls allowed test

* move gm over to long gas brake test

* assert that limits are reasonable

* fix typing

* fix linter again

* fix linter again

* fix linter again

* like to make it clear

* typo

* fix from merge

* clearer names

* dont need thesemore

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-12 14:03:40 -07:00
Justin Newberry
f29c753ba4 Safety: generic limit safety check (#1575)
* generic limit safety check

* fix messagefunction
2023-08-12 13:51:26 -07:00
Shane Smiskol
20b1e505c3 GM: move more longitudinal related function into class (#1574)
move these into the long test
2023-08-10 23:59:58 -07:00
Shane Smiskol
61590b681a GM: clean up longitudinal safety test (#1573)
* clean up gm long safety test

* move to long base

* common brake
2023-08-10 23:49:28 -07:00
Igor Biletskyy
25f1444d73 panda: add CAN-FD throughput test (#1572)
init
2023-08-10 18:41:50 -07:00
Adeeb Shihadeh
61e987f6e2 remove safety replay test (#1569) 2023-08-07 18:38:01 -07:00
Igor Biletskyy
a651fe3c6b set OBD to False after test (#1568)
* reset OBD after test

* add comment
2023-08-07 10:54:39 -07:00
Justin Newberry
5801582baf Subaru: convert measured angle to centigrees (#1567)
convert to centigrees
2023-08-07 09:29:34 -07:00
Adeeb Shihadeh
235067a22b run HITL tests in parallel (#1566)
* seems to work

* cleanup

* run in ci

* fail on first

* fix jungle scope

---------

Co-authored-by: Bruce Wayne <batman@comma.ai>
2023-08-06 20:51:26 -07:00
Adeeb Shihadeh
77b09a3160 misc hitl test cleanup (#1562)
* misc hitl test cleanup

* adjust that

* update

* tres fix

---------

Co-authored-by: Bruce Wayne <batman@comma.ai>
Co-authored-by: Comma Device <device@comma.ai>
2023-08-06 16:30:21 -07:00
Adeeb Shihadeh
3dc3b58e20 ruff: enable bugbear checks (#1565) 2023-08-06 14:59:22 -07:00
Adeeb Shihadeh
fc506e7b39 switch to ruff linter (#1564)
* switch to ruff linter

* cleanup
2023-08-06 14:29:28 -07:00
Adeeb Shihadeh
33a95d6bea pedal: fix warning on invalid serial (#1563)
* pedal: fix warning on invalid serial

* fix

* fix:

* shouldn't need that

* fix

---------

Co-authored-by: Bruce Wayne <batman@comma.ai>
2023-08-06 13:47:37 -07:00
Adeeb Shihadeh
c66b98b2a6 finish esp/gps removal (#1559) 2023-08-06 12:29:54 -07:00
Adeeb Shihadeh
b976cf426a libpanda: silence build warning 2023-08-04 22:16:49 -07:00
Adeeb Shihadeh
6e1d35b033 more complete jungle reflash (#1557)
* more complete jungle reflash

* no spi!

* mv flash

* mv that
2023-08-04 21:51:09 -07:00
Adeeb Shihadeh
0f479a30a3 CI: reflash jungle (#1546) 2023-08-04 18:11:29 -07:00
Justin Newberry
7b6806c270 Safety: Add desired angle to safety helpers (#1554)
add desired angle
2023-08-04 17:30:10 -07:00
Justin Newberry
2a72404ccb Subaru: Add measured steering angle and vehicle speed (#1528)
* correct vehicle speed and add measured angle

* misra

* misra

* common test for angle

* PR cleanup

* use subaru prefix

* clean it up a bit

* minimize whitespace diff

* need float for deg_to_can
2023-08-04 17:16:35 -07:00
Adeeb Shihadeh
1950ba6f83 cleanup bus count constant 2023-08-04 10:47:03 -07:00
Adeeb Shihadeh
977d702770 cleanup old pedal stuff (#1552) 2023-08-04 10:40:53 -07:00
Adeeb Shihadeh
d7120be904 panda jungle (#1547)
* mv jungle

* match pedal style

* fix linter

* fix fw path

* fix paths

* safety!
2023-08-03 23:55:13 -07:00
Adeeb Shihadeh
e7894e6770 Move CanHandle to python/ (#1550) 2023-08-03 23:10:16 -07:00
Adeeb Shihadeh
f37f8d90ba cleanup build, prep for jungle (#1549)
* cleanup build, prep for jungle

* cleanup

* update pedal obj path
2023-08-03 19:07:41 -07:00
Adeeb Shihadeh
1eac0d7634 HITL: remove old check, it's always checked on panda connect now 2023-07-20 11:25:06 -07:00