Commit Graph

134 Commits

Author SHA1 Message Date
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Andre Volmensky 9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching b5a2cec913 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh 18afb979fe remove file that shouldn't have been committed 2020-05-30 14:40:00 -07:00
Adeeb Shihadeh 2d898bc0ed update refs 2020-05-29 12:41:20 -07:00
Jafar Al-Gharaibeh 34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching ba2ac1207a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
2020-05-28 15:40:48 -07:00
Willem Melching 3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching bee15f8abe make pre-commit pass without xx present 2020-05-28 13:20:28 -07:00
Willem Melching 29aaa44740 flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Adeeb c78602e8cc Remove incomplete Hyundai Ioniq port (#1570) 2020-05-26 20:48:41 -07:00
Adeeb Shihadeh a1ffcdd253 update refs after radarState fields populated 2020-05-26 18:12:12 -07:00
Thaixican dd16990952 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
2020-05-26 13:49:18 -07:00
Adeeb Shihadeh b251eff764 remove that script 2020-05-22 14:50:08 -07:00
Adeeb Shihadeh ea1b192565 bump panda after hyundai checksum 2020-05-22 14:42:22 -07:00
Willem Melching fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching ef2ea14ecc add sonata 2019 to test_car_modelsg 2020-05-20 17:20:17 -07:00
Alice Knag fde1a5e9af add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
2020-05-20 17:12:00 -07:00
Willem Melching d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
Willem Melching 96605d0951 This one also needs to be fixed 2020-05-19 16:19:00 -07:00
Adeeb Shihadeh 8788ab36e4 remove those debug prints 2020-05-19 13:54:24 -07:00
Willem Melching bb8bbdd9ee Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
Adeeb d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Adeeb 08832ff29d Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
2020-05-12 15:06:48 -07:00
Willem Melching 27ffa29f6c Fix counter in HKG clu11 message (#1484)
* fix counter in clu11 message

* update ref
2020-05-10 20:13:35 -07:00
Willem Melching 5182da3100 fix update ref script 2020-05-10 18:55:53 -07:00
Adeeb Shihadeh ad2c54e991 fake less of PubMaster and SubMaster when profiling 2020-05-03 17:41:26 -07:00
Adeeb 337529d5cb Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Willem Melching 5d69e97281 Less hardcoded values in profiling script 2020-05-01 11:38:30 -07:00
Willem Melching 4301c5efb5 small cleanup of profiling script 2020-05-01 10:49:02 -07:00
Willem Melching b3e7d94303 run both deterministic and statistical profiler 2020-04-30 17:39:37 -07:00
Willem Melching 04bc4a0e45 use proper cachegrind extension 2020-04-30 17:07:46 -07:00
Willem Melching 079c9e714b Write profiling result after running 2020-04-30 16:19:12 -07:00
Willem Melching 4d03b8536f Run controlsd without sockets 2020-04-30 15:15:19 -07:00
Willem Melching 71589fc92e Logreader can take car of downloading the files 2020-04-30 15:09:19 -07:00
Chris Souers 0f530be2b4 Static 0xe5 on Honda Bosch (#1420)
* Recreate a static 0xe5 and send to radar

* remove unneeded declaration

* Update ref_commit
2020-04-28 14:12:46 -07:00
Willem Melching 94bba46d6d Hyundai: use same gas pressed bit as in panda (#1428)
* use same bit as in panda

* remove lines

* update ref

* switch gas pedal signal
2020-04-27 15:28:34 -07:00
Erich Moraga 009c32d516 Add HIGHLANDERH_TSS2 Support (#1425)
* exclude HIGHLANDERH_TSS2

* add HIGHLANDERH_TSS2 support

* Add HIGHLANDERH_TSS2 Support

* Add HIGHLANDERH_TSS2 Support

* Added to IGNORED_FINGERPRINTS per @pd0wm
2020-04-27 14:56:30 -07:00
Willem Melching 09ac646abd Unblock stdout in testing slave script 2020-04-27 14:11:38 -07:00
Willem Melching f7f0a81d13 Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
Willem Melching d0d117a999 this is now in the panda repo 2020-04-24 14:04:26 -07:00
Willem Melching 90eb7aadf2 move sensor bootloop script 2020-04-24 14:03:55 -07:00
Willem Melching 035d461fdf that is not a test 2020-04-24 14:02:35 -07:00
Willem Melching 2ecf054891 catch all exceptions in testing script 2020-04-23 21:58:35 -07:00
ZwX1616 922055f464 orange distracted alert is now continuous (#1412) 2020-04-23 14:15:05 -07:00
Willem Melching 95c2ff5a3d Add more timeouts to eon_testing_slave 2020-04-23 11:58:48 -07:00
cowanhmoore 1d6042c5f3 Honda HRV (#1404)
* PR - Honda HRV

values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR

Once *5 is approved, will need to update values.py to matching dbc

Thanks, Cowan Moore 330-701-3922

* Honda HRV Door Signal

BO_ 422 SCM_BUTTONS: 8 SCM
 SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON

* Update values.py

* Update test_car_models.py
2020-04-20 15:30:46 -07:00