Commit Graph

3388 Commits

Author SHA1 Message Date
Harald Schäfer 965415135a Long control: Double delay is super complicated (#32694)
* Double delay is super complicated

* No more upper bound

* DEAD

* Update ref
2024-06-10 22:29:17 -07:00
Shane Smiskol e3f18b9f95 VW: bump model year of all CRAFTER_MK2 models 2024-06-10 16:23:20 -07:00
Shane Smiskol c514ee7212 [bot] Fingerprints: add missing FW versions from new users (#32689)
Export fingerprints
2024-06-10 14:36:42 -07:00
Shane Smiskol 26e52a4aed Revert "[bot] Fingerprints: add missing FW versions from new users" (#32688)
Revert "[bot] Fingerprints: add missing FW versions from new users (#32683)"

This reverts commit cf100f740e.
2024-06-10 13:42:27 -07:00
Shane Smiskol cf100f740e [bot] Fingerprints: add missing FW versions from new users (#32683) 2024-06-10 13:39:02 -07:00
Metalbird1997 19e0fa3094 Update fingerprints.py for 2024 MAN TGE (#32657)
* Update fingerprints.py for 2024 MAN TGE

* add TGE chassis codes

* unsure about the others

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-10 00:22:34 -07:00
Nelson Chen 3b6862030a Change the term "Non-US" to "South America" for the "Corolla Hybrid (Non-US only) 2020-23" entry (#32658)
The term "Non-US" in cars.md for the "Corolla Hybrid (Non-US only) 2020-23" is not precise enough and should be changed to South America

Users may think "Non-US" includes Europe or Canada, which is not the case for this entry.

It has two issues:

* The 2023 Corolla Hybrid in Europe and Canada include a new Toyota Safety Sense 3.0 that has yet to be supported due to it being a new version and the presence of Toyota Security Key.
* The 2020-2022 Corolla Hybrid in Europe is the same as the 2020-2022 Corolla Hybrid in North America, which is supported by Openpilot and has full-speed ACC due to the presence of an electronic parking brake which is not present in the 2020-2022 Corolla Hybrid in South America and the reason why it is listed as not having full-speed ACC.

The entry should be reverted to at least "Corolla Hybrid (South America) 2020-23" which was proposed but not merged in the pull request:

https://github.com/commaai/openpilot/commit/28454c04cc93dc241da3b004a7154e44313e85c9

Pull request for that change that does not include that commit: https://github.com/commaai/openpilot/pull/26943

Examples of confusion throughout the community:

comma.ai Discord:

https://discord.com/channels/469524606043160576/524327905937850394/1235264758580772996

https://discord.com/channels/469524606043160576/524327905937850394/1228090600272691370

https://discord.com/channels/469524606043160576/954493346250887168/1209952008329633813

https://discord.com/channels/469524606043160576/524327905937850394/1182093384647721140

https://discord.com/channels/469524606043160576/954493346250887168/1147751657543848017

openpilot community Discord:

https://discord.com/channels/771493367246094347/771495215570747403/1247737844727021629

> I think that the supported cars list (https://github.com/commaai/openpilot/blob/master/docs/CARS.md) is incorrect.
>
> I have a UK 2020 Toyota Corolla Hybrid
>
> In the cars list it's listed as "no accel below" 17 mph and no resume from > stop.
>
> This is not my experience. For me it works just fine down to a complete stop and it can resume from a stop too.
>
>

CC: @AlexandreSato
2024-06-08 09:18:00 -07:00
Shane Smiskol 90523b3b00 remove old fingerprints test (#32654)
* is this even used?

* remove
2024-06-07 23:38:51 -07:00
Adeeb Shihadeh b42b156fcd card: remove old canRcvtimeout field (#32650)
* card: remove old canRcvtimeout field

* deprecate
2024-06-07 17:03:17 -07:00
Vivek Aithal e8857a6713 [Lag] Increase Optima Lag (#32583)
increase lag in optima to 0.2
2024-06-06 01:14:28 -07:00
Shane Smiskol ae375091db Genesis G70 2020: use common specs (#32641)
use non-2020 specs
2024-06-05 23:44:19 -07:00
Dean Lee 045b9f20b7 improve get_torque_params (#32586)
* Loading torque data only once and reusing it across function calls.

* apply review

* still check only one entry

* fix that

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-05 21:21:16 -07:00
Solomon Jones a418c9e40a Fingerprint for 2017 Subaru Forester (#32584)
Fingerprint for 2017 Forester
2024-06-05 21:18:29 -07:00
Dean Lee 91fd918fcb car/interfaces.py: optimize parse_gear_shifter() with predefined dictionary (#32592)
Optimize gear shifter parsing for improved performance
2024-06-05 18:04:03 -07:00
Shane Smiskol 7cfd91bb69 Restore lateral limits report (#32640)
* stash

* staaaaash

* clean up

* more clean up

* fix

fix

* fix

* stash

clean up

* more

* this is just simpler to understand

* explicitly check
2024-06-05 18:03:23 -07:00
Riley Williams 7381872a54 2024 IONIQ 6 (#32302)
* Tweak carspecs for 2023 (and now also 24) ioniq 6 to reflect public info instead of cloning ioniq 5 specs

* Regenerated car docs

* revert specs *for now*

---------

Co-authored-by: Riley Williams <riley@rileyww.dev>
Co-authored-by: Riley Williams <riley@rileyw.dev>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-05 14:34:02 -07:00
Shane Smiskol bbc21b9f52 [bot] Fingerprints: add missing FW versions from new users (#32605)
Export fingerprints
2024-06-04 22:09:54 -07:00
Shane Smiskol de61d417b9 Honda: remove programmedFuelInjection ECU (#32626)
* set up for quick test

* remove pgfi

* Revert "set up for quick test"

This reverts commit aa6af2ff838b2cd203a6feaacaa5b4f3b71272ed.

* still query JIC
2024-06-04 21:29:05 -07:00
Adeeb Shihadeh 34e329649d boardd is pandad (#32628)
* boardd is pandad

* rename tests
2024-06-04 19:16:55 -07:00
Shane Smiskol e494d98960 Honda: helpful non-essential ECU comment 2024-06-04 16:37:01 -07:00
Shane Smiskol ba9ea0a25f Hyundai: remove Ioniq EV 2020 CAN fingerprint (#32625)
* add from afc1609bb1584f28

* remove HYUNDAI_IONIQ_EV_2020 CAN fingerprint
2024-06-04 16:31:16 -07:00
Vivek Aithal 8a4bfcf5b4 [torqued] Reduce friction for some Hyundai cars (#32578)
* reduce friction coeff for ev6 and ioniq6

* Update ref

---------

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
2024-06-04 11:10:04 -07:00
Adeeb Shihadeh c59887c810 test_*.py files are no longer executable (#32610)
* test_*.py files are no longer executable

* cleanup empty lines

* update precommit

* fixme

* enable

* build
2024-06-03 15:48:56 -07:00
Shane Smiskol 7c4b7ce799 [bot] Fingerprints: add missing FW versions from CAN fingerprinting cars (#32604)
Export fingerprints
2024-06-03 14:11:51 -07:00
cl0cks4fe 8f4b00c263 cache get_torque_params (#32560)
* cache get_torque_params

* switch to cache

* Update selfdrive/car/interfaces.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-31 13:43:12 -07:00
Shane Smiskol f887b8703c add Hyundai CAN FD fingerprinting note 2024-05-30 23:08:14 -07:00
Shane Smiskol 0a43d82428 fw_versions debug: match online vin retry 2024-05-30 22:20:04 -07:00
William Stairs 984ad8833a Add Chassis for VW Arteon Shooting Brake 2020-2023 (#32579)
* Added Arteon "3H" chassis code for Shooting Brake to VWCarDocs.

* Added new engine and transmission FW to Volkswagen fingerprints.py for Arteon Mk1.

* Apply suggestions from code review

* updates docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-30 21:35:19 -07:00
kacperhq 325dcec06b KIA SPORTAGE 5th HEV 2022 EUR fingerprint (#32558)
Update fingerprints.py

KIA Sportage 5th GEN EUR ver
2024-05-28 15:27:08 -07:00
Shane Smiskol 521ee46c47 [bot] Fingerprints: add missing FW versions from new users (#32552)
Export fingerprints
2024-05-27 22:01:31 -07:00
Shane Smiskol 93963207f2 [bot] Fingerprints: add missing FW versions from new users (#32542)
Export fingerprints
2024-05-26 08:41:19 -07:00
Shane Smiskol 95aa7c4b68 [bot] Fingerprints: add missing FW versions from new users (#32533)
Export fingerprints
2024-05-25 09:42:23 -07:00
Shane Smiskol a7065d158b Kia: add 2022 Forte model year
The minimum enable speed is also 0 mph with a lead like the 2023, so it's likely supported with this harness
2024-05-24 15:49:45 -07:00
Shane Smiskol 937ff7f418 Kia: update Forte 2019-21 min enable speed (#32528)
* forte enable speed fix

* update docs
2024-05-24 15:48:26 -07:00
cipioh 652f15d54e Added ecu firmware data for 2024 Kia EV6 GT (#32524)
* Update fingerprints.py

added KIA EV6 GT 2024

* Update fingerprints.py

added firmware from 2024 Kia EV6 GT

* format

* update my

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-24 13:39:42 -07:00
Shane Smiskol 7a6818da7e Reapply "Ford: detect missing LKAS from EPS configuration (#31821)" (#32518)
* Reapply "Ford: detect missing LKAS from EPS configuration (#31821)"

This reverts commit ffb34e558f.

* catch

* now fix

* clean up
2024-05-22 17:27:22 -07:00
Shane Smiskol ef1b6b4703 test car interfaces: catch more FW-related failures (#32514)
* only pick ecus from brand

* use superset of all requests

* much better

* clean up

* clean up

* try 150

* ?

* ???

* faster debug

* wtf

* no clue

* run push!

* this shouldn't catch it

* clean up

* rm
2024-05-22 17:12:54 -07:00
Shane Smiskol d96b8bbc01 [bot] Fingerprints: add missing FW versions from new users (#32511)
Export fingerprints
2024-05-22 10:02:26 -07:00
Shane Smiskol ffb34e558f Revert "Ford: detect missing LKAS from EPS configuration (#31821)"
This reverts commit 9f327aeb48.
2024-05-21 23:21:31 -07:00
Shane Smiskol 9fa92c2225 card: only exit ELM once done with ECU knock outs (#32505)
* only exit elm once done with knock outs

* comments!
2024-05-21 21:23:14 -07:00
roberttruong b059f2eda8 Additional Subaru Impreza 2022 Fingerprint (#31916)
* Update fingerprints.py

Add fingerprint for Subaru Impreza 2022 Australia

* auto_fingerprint

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-21 20:31:47 -07:00
Marcin Perlikowski 5e63906a3f Hyundai: add fingerprint for 2020 IONIQ PHEV (#31301)
add fingerprint for 2020 Hyundai IONIQ PHEV

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-21 20:24:45 -07:00
Cameron Clough 9f327aeb48 Ford: detect missing LKAS from EPS configuration (#31821)
* debug: disable FW cache

* Ford: detect missing TJA/LCA config and disable LKAS

* set dashcamOnly

* revert

* clean up

* clean up

* some CAN FD do not have 0x01 block for PSCM

* bump cereal (fork)

* remove confusing comment

* add flags/event

* remove duplicate from events

* copy can be next pr

* dashcamOnly if no config comes back either (this shouldn't happen)

* flipped

* can do this

* Revert "can do this"

This reverts commit c3d311b2ffb7bbc346c7f702ac5c1934bc495c65.

* Revert "flipped"

This reverts commit 75c01fb4c5f7fdc9222ea13b8901f76b5b419c99.

* Revert "dashcamOnly if no config comes back either (this shouldn't happen)"

This reverts commit f82624a0eb28bf683660f86b3ddfd44717a6915f.

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-21 17:01:04 -07:00
Shane Smiskol e29ed6849e [bot] Fingerprints: add missing FW versions from new users (#32501)
Export fingerprints
2024-05-21 14:37:24 -07:00
Shane Smiskol 71f5c441fe card: process that abstracts car interface and CAN (#32380)
* format card

* standalone process

* no class member CS, there's no point

also can be confusing; what else could be using this?

* rename CoS

* Update selfdrive/controls/controlsd.py

* never works first time :D

* canRcvTimeout is bool

* hack

* add cpu

* see what testing closet comes up with

* first

* some clean up

* support passable CI, fix test models

* fix startup alert

* process replay changes

* test_fuzzy

* gate carOutput valid on carControl valid

* we should publish after we update carOutput

* controlsd was using actuatorsOutput from 2 frames ago for torque, not the most up to date

* check all checks for carControl in case controlsd dies

* log more timestamps

* more generic latency logger; needs some clean up

latency_logger.py was difficult to understand and modify

* card polls on can and carControl to get latest carControl possible

* temp try to send earlier

* add log

* remove latencylogger

* no mpld3!

* old loop

* detect first event

* normal send

* revert "card polls on can and carControl to get latest carControl possible"

how it was is best

* sheesh! update should be first

* first timestamp

* temp comment ( timestamp is slow :( )

* more final ordering, and make polling on/off test repeatable

* Received can

* new plot timestamps

* clean up

* no poll

* add controllers (draft)

* Revert "add controllers (draft)"

This reverts commit e2c3f01b2fadcff74347bac90c8a5cc1ef4e27b3.

* fix that

* conventions

* just use CS

* consider controlsd state machine in card: not fully done

* hmm it's just becoming controlsd

* rm debugging

* Revert "hmm it's just becoming controlsd"

This reverts commit 534a357ee95bec4ed070667186af55d59421bbc7.

* Revert "just use CS"

This reverts commit 9fa7406f30c86200f20457f7b9ff95e731201bf9.

* add vCruise

* migrate car state

* Revert "migrate car state"

This reverts commit 4ae86ca163c6920070f410f608f7644ab632850b.

* Revert "add vCruise"

This reverts commit af247a8da41c3626ada4231b98042da1a1ae4633.

* simple state machine in card (doesn't work as is)

* Revert "simple state machine in card (doesn't work as is)"

This reverts commit b4af8a9b0a2e17fdfc89d344c64678ef51305c24.

* poll carState without conflate

* bump

* remove state transition

* fix

* update refs

* ignore cumLagMs and don't ignore valid

* fix controls mismatch; controlsd used to set alt exp

* controlsd_config_callback not needed for card

* revert ref temp

* update refs

* no poll

* not builder!

* test fix

* need to migrate initialized

* CC will be a reader

* more as_reader!

* fix None

* init after publish like before - no real difference

* controlsd clean up

* remove redundant check and check passive for init

* stash

* flip

* migrate missing carOutput for controlsd

* Update ref_commit

* bump cereal

* comment

* no class params

* no class

* Revert "no class"

This reverts commit 5499b83c2dcb5462070626f8523e3aec6f4c209d.

* add todo

* regen and update refs

* fix

* update refs

* and fix that

* should be controlsstate

* remove controlsState migration

CoS.initialized isn't needed yet

* fix

* flip!

* bump

* fix that

* update refs

* fix

* if canValid goes false, controlsd would still send

* bump

* rm diff

* need to be very careful with initializing

* update refs
2024-05-21 01:18:10 -07:00
LostEon 1ea2411575 Fingerprint 2016 Jeep Grand Cherokee (#32491)
* Fingerprint 2016 Grand Cherokee

* sort

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-20 17:38:47 -07:00
Shane Smiskol 833316835a [bot] Fingerprints: add missing FW versions from new users (#32486)
Export fingerprints
2024-05-20 09:48:51 -07:00
Shane Smiskol 09f2077f58 [bot] Fingerprints: add missing FW versions from new users (#32477)
Export fingerprints
2024-05-19 10:39:29 -07:00
Shane Smiskol 1a4e022d70 [bot] Fingerprints: add missing FW versions from new users (#32468)
Export fingerprints
2024-05-18 14:03:50 -07:00
Curtis Jiang 5cfaae771d HKG: Add FW version for Canada Hyundai Tucson PHEV 2024 (#32440)
* Car port for Hyundai Tucson PHEV 2024

* Fix doc
2024-05-17 13:17:24 -07:00