Commit Graph

81 Commits

Author SHA1 Message Date
Rick Lan a0a83dc040 Merge remote-tracking branch 'origin/master' into master3 2024-06-27 14:39:03 +08:00
James 046ed7e9f8 Cleanup "longitudinalPlan" fields (#32845) 2024-06-26 14:51:27 -07:00
Rick Lan 53f11a8955 refactored to use tune from new long control API (https://github.com/commaai/openpilot/pull/32706) 2024-06-26 20:32:58 +08:00
Rick Lan 3f76785dd4 Toyota PCM Compensation tune and bugfixes
* Do not reset long mpc weight (perform better)
* Lower stopAccel for quicker response for TSS2.
2024-06-25 22:04:04 +08:00
Rick Lan 058fab6da2 reset state (mpc weight) when mode changed 2024-06-23 21:51:02 +08:00
Rick Lan e84bf06f6e Curve Speed Limiter 2024-06-21 14:46:50 +08:00
Rick Lan fa62b6ae1a Alt Driving Personality Controller 2024-06-21 14:07:47 +08:00
Rick Lan e6230b18ee Alt Driving Personality Controller 2024-06-21 13:43:16 +08:00
Rick Lan 41fc49dcc4 Merge remote-tracking branch 'origin/master' into master3 2024-06-21 13:16:13 +08:00
Harald Schäfer 442e9f4ae4 Long planner: small cleanup (#32804) 2024-06-20 16:33:06 -07:00
Rick Lan 5387b2e977 Low Speed Aggressive Mode 2024-06-21 00:16:58 +08:00
Rick Lan 65a5ef4d77 Merge remote-tracking branch 'origin/master' into master3 2024-06-18 11:59:35 +08:00
Harald Schäfer bc303df6a0 long control: new API (#32706)
* Simplify long control

* Seperate

* Rename

* Try new api for toyota

* rm v_pid everywhere

* No speed in reset

* 0 is better default

* unassigned variable

* Update other cars

* Update gm

* SIMPLIFY

* simplify more

* fix API boundry

* Fix stopping bug

* Small fixes

* Update ref
2024-06-14 00:08:58 -07:00
Rick Lan f6095ef8e2 Disable use of navInstruction for now 2024-06-13 19:59:17 +08:00
Rick Lan e3693fe996 Merge branch 'master' of https://github.com/commaai/openpilot into master3 2024-06-12 13:51:15 +08:00
Rick Lan 080957e642 added DE2E 2024-06-12 12:41:20 +08:00
Dean Lee 1e70b23855 LongitudinalPlanner: replace hardcoded length with ModelConstants.IDX_N (#32597)
replace hardcoded length
2024-06-02 22:52:45 -07:00
Shane Smiskol 6ecb710305 LongitudinalMpc: use DT_MDL (#32532)
bad magic number
2024-05-25 03:29:54 -07:00
Shane Smiskol 29e55f99a5 Move personality to controlsState (#31855)
* start at param

* start by sending personality

* change to personality

* POC: button changes personality

* what's wrong with this?

* fix

* not really possible but fuzzy test catches this

* there's always a typo

* dang, we're dropping messages

* clean up

* no comment

* bump

* rename

* not all cars yet

* works but at what cost

* clean up

* inside settings

* write param so we save the distance button changes

* setChecked activates buttonToggled and already writes param!

* don't need this, we update from longitudinalPlan on changes

* some clean up

* more

* ui

* allow some time for ui to receive and write param

* plannerd: only track changes in case no ui

* Revert "plannerd: only track changes in case no ui"

This reverts commit 2b081aa6ceb92c67a621b74592b2292756d29871.

* write in plannerd as well, I assume this is atomic?

* don't write when setting checked (only user clicks)

* better nane

* more

* Update selfdrive/controls/lib/longitudinal_planner.py

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

* doesn't write param now

* ParamWatcher is nice

* no debug

* Update translations

* fix

* odd drain sock proc replay behavior

* vanish

* Revert "odd drain sock proc replay behavior"

This reverts commit 29b70b39413e1852bb512155af6b6a94a5bd9454.

* add GM

* only if OP long

* move personality to controlsState, since eventually it won't be exclusive to long planner

more

bump

* diff without translations

* fix

* put nonblocking

* CS should start at up to date personality always (no ui flicker)

* update toggle on cereal message change

* fix

* fix that

* ubmp

* mypy doesn't know this is an int :(

* update translations

* fix the tests

* revert ui

* not here

* migrate controlsState

* Revert "migrate controlsState" - i see no reason we need to test with
any specific personality

This reverts commit 6063508f2df1a5623f113cda34dcd59a1f4b2ac9.

* Update ref_commit

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2024-03-13 00:57:57 -07:00
Shane Smiskol fdab60cad7 longitudinal planner: start at personality param (#31788)
start at param
2024-03-07 19:56:22 -08:00
YassineYousfi d6cece756c longplanner: expose dt (#30941) 2024-01-08 19:46:13 -08:00
Adeeb Shihadeh 35f819c823 swaglog.py goes in common/ (#30631)
* swaglog.py goes in common/

* all of these go in release

* we'll even include the pyx
2023-12-06 17:27:51 -08:00
YassineYousfi cad17b1255 modeld: parsing and publishing in python (#30273)
* WIP try modeld all in python

* fix plan

* add lane lines stds

* fix lane lines prob

* add lead prob

* add meta

* simplify plan parsing

* add hard brake pred

* add confidence

* fix desire state and desire pred

* check this file for now

* rm prints

* rm debug

* add todos

* add plan_t_idxs

* same as cpp

* removed cython

* add wfd width - rm cpp code

* add new files rm old files

* get metadata at compile time

* forgot this file

* now uses more CPU

* not used

* update readme

* lint

* copy this too

* simplify disengage probs

* update model replay ref commit

* update again

* confidence: remove if statemens

* use publish_state.enqueue

* Revert "use publish_state.enqueue"

This reverts commit d8807c8348338a1f773a8de00fd796abb8181404.

* confidence: better shape defs

* use ModelConstants class

* fix confidence

* Parser

* slightly more power too

* no inline ifs :(

* confidence: just use if statements
2023-10-19 14:23:51 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
eFini 8ca7753c95 longitudinal_planner.py: cleaner variable assignment (#29290)
* cleaner variable assignment

* Update selfdrive/controls/lib/longitudinal_planner.py

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-09 15:17:19 -07:00
Lee Jong Mun a61df2bdde controls: use common car interface acceleration limits (#29184)
* Duplicate Accel param

using interfaces accel param

* revert brand accel value

* import error

* sort

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-31 22:56:47 -07:00
Shane Smiskol b5b431c12d Revert "experimental mode: gate navigate on openpilot (#28883)" (#29005)
This reverts commit f973d605b2.
2023-07-17 19:56:38 -07:00
Shane Smiskol f973d605b2 experimental mode: gate navigate on openpilot (#28883)
* first draft copy, needs updates

* gate behind exp mode

* can be one line

* this is no longer true

* toggle isn't just e2e long now, rename

* don't enable/disable

* kinda works!

* remove old giant qstring

* comment clean up

* similar breakpoint

* more clean up

* fixup onroad

* preserve planner behavior, and we don't need to look at confirmed param if we're onroad

* update translations

* vanish translations

* use scene for op long

* lowercase!

* updated copy

* need to check longitudinal here now too

* clean up!

* here is better

* used

* no nav emoji

* don't check param if not valid

* revert this

revert this

* ed
2023-07-14 05:26:59 -07:00
Dean Lee 48b507c0b4 handle conversion exception for LongitudinalPersonality (#28426)
* handle type conversion exception

* catch multiple exception
2023-06-06 13:10:12 -07:00
Harald Schäfer 205c900742 Driving Personality setting (also changes follow distance) (#24742)
* Skeleton

* Adjustable follow parameter

* fix rebase

* long planner

* typo

* Add ui toggle

* Fix icon

* Improve text

* Better toggle position

* Im a UX engineer now

* add param reader

* CHange jerk to have same crash test performance

* Try reading param

* Unused comment

* translate ui text

* std stoi

* Parametrized buttons

* Empty strings are ints

* Move to generic

* Update translations

* Fix translation diffs

* Release notes

* update refs

* tweaks

* Misc fixes

* No param is standard
2023-06-05 22:17:41 -07:00
Vivek Aithal a599890fed Lateral Planner: Calibrate model speed with vEgo (#28049)
* calibrate speed in the lateral planner

* make speed err helper fn

* check if trans has values

* clip the vel_err

* update refs
2023-05-09 14:26:58 -07:00
Shane Smiskol 3ab8645d3a uiPlan: add planned acceleration field (#27484)
* add accel

* bump cereal

* Update ref_commit

---------

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
2023-03-02 20:11:24 -08:00
Harald Schäfer eb8bdc0026 MPC path in UI (#27380)
* 10s lat

* Full length MPC

* redfine N

* Leave controls the same for now

* Updates

* use long plan in lat plan

* interp plan

* simplergit add selfdrive/controls/plannerd.py selfdrive/controls/

* expand to 10s

* revert this

* fix linter

* vizualize

* fix long test

* typo

* cleanup

* compiles

* unused

* unused

* bump cereal

* bump cereal

* use model if no uiplanm

* update replay

* update ref commit

* bump cereal to master
2023-02-17 19:58:30 -08:00
Shane Smiskol b45dda2d0a Longitudinal tests: test forceDecel (#26765)
* test with forceDecel

* test all combos

* fix

* fix

* fix

* ...

* remove print

* clean up

* just set cruise to 0

* update ref commit

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
2023-01-10 14:46:43 -08:00
Shane Smiskol e6fcc2d6aa planner: read experimental mode from controlsState (#26553)
read from controlsState
2022-12-05 13:58:15 -08:00
Shane Smiskol 9f80a97eee longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
2022-11-11 14:02:09 -08:00
Shane Smiskol 98206fb92e planner: fix undeclared variable (#26468)
* undeclared variable

* run first second disabled

* revert test

* rev
2022-11-11 13:22:56 -08:00
Harald Schäfer f23296bc87 Add force decel to e2e long (#26448)
* add force decel to e2e

* Update longitudinal_planner.py
2022-11-11 10:46:03 -05:00
Adeeb Shihadeh 9a3f468051 experimental mode (#26416)
* experimental mode

* rename param

* red lights
2022-11-08 14:45:01 -08:00
Harald Schäfer f63f0de80a E2e long model: calibrate model speed to wheel speed (#26395)
* calibrate!

* Fix test

* Fix proc replay

* check len

* get v_ego from model 8501d20-bb59-4193-aa82-82b2737dedd6/449 609d90f3-65e6-4617-a60c-d6d99eead408/700

* bump cereal

* initialize v_model_error

* typo

* better names

* cleanup

* bump cereal

* update model replay ref commit

* bump to cereal master

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
2022-11-07 17:49:36 -08:00
Harald Schäfer 253e5d7f9d FCW: less false positives (#26366)
* Less FP for FCW

* enable fcw for e2e long
2022-11-06 12:17:07 -08:00
HaraldSchafer b80f2efdf2 No fcw when standstill (#26252) 2022-10-26 14:53:01 -07:00
HaraldSchafer cb0b7375b7 Rocket Launcher Model (#25963)
* 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/300

* compute only 9 tokens: 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/300

* tinygrad: cleanup gather

* 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/700

* empty commit for tests

* bump tinygrad

* dont use tinygrad matmul for now

* bump tinygrad

* 1456d261-d232-4654-8885-4d9fde883894/440 e63ab895-2222-4abd-a9a5-af86bb70e260/700

* float16 1456d261-d232-4654-8885-4d9fde883894/440 e63ab895-2222-4abd-a9a5-af86bb70e260/700

* increase steer rate cost

* Revert "increase steer rate cost"

This reverts commit 74ce9ab9be7ef17ecfec931f96851b12f37f2336.

* fork tinygrad

* empty commit for tests

* basics

* Kinda works

* new lat

* new tuning

* Move LATMPCN so scons compiles

* Update long weights

* Add tinygrad optim

* Update model ref

* update weights

* Update ref

* Try

* Error message for field ignore

* update model regf

* ref commit

* Fix onnx test

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
2022-10-05 21:43:38 -07:00
HaraldSchafer e5d2c3ce7a Planner cleanup (#25969) 2022-10-04 21:19:04 -07:00
Shane Smiskol 4bd146ee7a Longitudinal planner: clip a_desired to cruise limits (#25928)
* Clip a_desired to cruise limits

* Update selfdrive/controls/lib/longitudinal_planner.py

* fix

* update refs

* explicit
2022-09-30 15:43:04 -07:00
HaraldSchafer 1007df874f Minor ACC fixes (#25911)
* Change cruise accel limits

* Long tuning script looks good

* Cap cruise slowdown aggression in e2e mode

* Revert atau change

* Cleanup

* Update ref

* fix ref
2022-09-28 13:27:07 -07:00
Adeeb Shihadeh 3ef37fe2e8 split out experimental long toggle (#25698)
* split out experimental long toggle

* clean up

* update translations
2022-09-07 20:38:04 -07:00
HaraldSchafer 8857e02dd4 Live e2e long toggling (#25685)
Live toggling
2022-09-07 11:29:19 -07:00
HaraldSchafer 7899fb79c1 More conservative lead policy in e2e long mode (#25684)
* Add params for lead and danger

* fix long params

* E2e passes simple maneuver tests

* Make tests run with e2e long mode

* Slightly more error allowed in e2e mode

* FCW back and populate long source field

* Fix planner name

* FCW still doesnt work

* Slightly less aggressive

* Doesn't need to simulate from stop
2022-09-06 21:52:34 -07:00
HaraldSchafer faff2b8950 Add e2e long toggle (#25638)
* Add toggle

* Misc fixes

* Update translations

* pre alpha not great
2022-09-02 00:24:53 -07:00