Commit Graph

67 Commits

Author SHA1 Message Date
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching b5a2cec913 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh 18afb979fe remove file that shouldn't have been committed 2020-05-30 14:40:00 -07:00
Adeeb Shihadeh 2d898bc0ed update refs 2020-05-29 12:41:20 -07:00
Jafar Al-Gharaibeh 34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching 3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching 29aaa44740 flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Adeeb Shihadeh a1ffcdd253 update refs after radarState fields populated 2020-05-26 18:12:12 -07:00
Willem Melching fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
Adeeb d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching 27ffa29f6c Fix counter in HKG clu11 message (#1484)
* fix counter in clu11 message

* update ref
2020-05-10 20:13:35 -07:00
Willem Melching 5182da3100 fix update ref script 2020-05-10 18:55:53 -07:00
Adeeb 337529d5cb Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Willem Melching 71589fc92e Logreader can take car of downloading the files 2020-04-30 15:09:19 -07:00
Chris Souers 0f530be2b4 Static 0xe5 on Honda Bosch (#1420)
* Recreate a static 0xe5 and send to radar

* remove unneeded declaration

* Update ref_commit
2020-04-28 14:12:46 -07:00
Willem Melching 94bba46d6d Hyundai: use same gas pressed bit as in panda (#1428)
* use same bit as in panda

* remove lines

* update ref

* switch gas pedal signal
2020-04-27 15:28:34 -07:00
Willem Melching f7f0a81d13 Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
ZwX1616 922055f464 orange distracted alert is now continuous (#1412) 2020-04-23 14:15:05 -07:00
Willem Melching c9cefb2fbc nissan and hyundai are community 2020-04-17 11:42:33 -07:00
Willem Melching 7d78cef34b Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
ZwX1616 133b1a20b4 RHD support for driver monitoring (#1299) 2020-04-15 16:48:44 -07:00
HaraldSchafer a18832748c rely on carstate to be sure (#1363)
* rely on carstate to be sure

* relies on carstate now too

* don't know how else to make this work

* update ref

* clean up hacks

* prev ref was weirdly bad?

* lets try that from my machine

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-15 13:14:23 -07:00
Adeeb 928b1561aa Toyota: use universal gas pressed bit to match panda safety (#1335)
* Toyota: use universal gas pressed bit to match panda safety

* update ref
2020-04-09 12:09:20 -07:00
Willem Melching 3eda14f2fe update test ref 2020-04-07 21:43:57 -07:00
Adeeb 0f6c22ce8b Unit test for alert width (#1307)
* unit test for alert width

* fix scale

* comment

* fix offending alert text

* rename

* update process replay refs

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-07 21:37:17 -07:00
martinl d0b3c69505 Add Subaru gearShifter to carstate (#1318)
* Add Subaru gearShifter to carstate

* reset submodules, remove ignore gearshifter from subaru interface

* update apks to master

* update ref_commit
2020-04-07 11:55:17 -07:00
Arne Schwarck 43b62d8bb6 Toyota Tss2 Blindspot signals (#1309)
* Toyota Tss2 Blindspot signals

Adding these signals are easy, they are on the can bus.

* Update ref_commit
2020-04-03 08:31:12 -07:00
Andre Volmensky 9c16ad8e18 Nissan set speed (#1289)
* LKA_ACTIVE should be set with enabled, not cruiseState.enabled. Was causing panda violations

* Added cruiseState.speed to Nissan X-Trail

* Bump opendbc

* Remove redundant if statement

* Fix tests

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-29 15:28:06 -07:00
Willem Melching 46ae7f0369 update ref 2020-03-29 14:53:51 -07:00
Willem Melching fca82ba503 add nissan to test_processes 2020-03-27 21:54:40 -07:00
George Hotz 2ecddbb3b6 Move all non Honda+Toyota to community supported (#1280)
* readme update, still need the gates on the cars themselves

* add community feature gating to other car ports

* promotion note

* from the brand

* readme touchups

* sell the harness

* full ISO

* update ref

Co-authored-by: George Hotz <geohot@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-27 10:59:07 -07:00
HaraldSchafer 5f8e3b4d93 New lane planner (#1276)
* better lane planner

* works well on test

* needs speed now

* update ref
2020-03-25 16:57:58 -07:00
Willem Melching e074b4fbe8 fix test ref 2020-03-23 14:16:32 -07:00
HaraldSchafer 628e7e6968 stricter calibration requirements (#1227)
* stricter requirements

* update refg

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-13 11:15:58 -07:00
rbiasini fe911bcca8 abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
2020-03-08 23:35:00 -07:00
rbiasini 24e092ffab Subaru brake check (#1212) 2020-03-06 23:17:16 -08:00
Jason Young c2200baf60 Updates to Volkswagen port (#1147)
* Remove unreachable Radar Fault alert code
* Update max torque
2020-03-05 22:45:28 -08:00
Shane Smiskol 6ff881f789 initialize all messages in 1 line (#1206) 2020-03-05 17:32:52 -08:00
Willem Melching 6db044c86c Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models
2020-03-05 15:40:07 -08:00
Willem Melching 78c1745ed5 add progress to save_logs 2020-03-05 13:24:21 -08:00
Harald Schafer c0557b0519 reupdate calib 2020-03-04 19:02:14 -08:00
HaraldSchafer 63d3bb517f Pulse desire (#1172)
* initial

* compilation fixes

* add desire

* pulse desire

* 0d5728f6-a918-40a6-bce3-a9d0f1238180/20

* cleaner

* inject model

* inject model

* test runs

* ah already done I see

* remove useless

* update

* updates, doesnt work

* fix generating new references

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-04 18:51:45 -08:00
Harald Schafer bae7816999 stable calib 2020-03-04 18:44:33 -08:00
rbiasini e90d0e832d Add brake press disengagement in Chrysler (#1163)
* Add brake press disengagement in Chrysler
2020-02-27 10:14:21 -08:00
Willem Melching 61706ce3a0 fix update refs 2020-02-26 16:44:53 -08:00