Commit Graph

76 Commits

Author SHA1 Message Date
Justin Newberry b0eb3ba4f4 cars: platform enums -> prepend brand name (#31927)
* with brand name

* migrate

* Fix

* fixes

* more

* passes

* fix

* fix the doc

* collects

* these too

* more stuff

* body exception :/

* more

* hardcode i guess

* update ref

* toyota

* more toyota

* and here

* final!

* fix notebooks and ccs

* move this here
2024-03-19 17:29:50 -07:00
thenhnn 489528dcae PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2024-03-19 11:16:02 -07:00
Justin Newberry 655e5f7c3e rename CarInfo to CarDocs (#31879)
car info to car docs
2024-03-15 11:45:44 -07:00
Shane Smiskol bdae188c6f docs: don't support multi-type car info (#31875)
don't support multi-type car info
2024-03-15 00:11:41 -07:00
Shane Smiskol 99610c8819 Revert "common PlatformFlags base class + test for < 32 bits" (#31793)
Revert "common PlatformFlags base class + test for < 32 bits (#31779)"

This reverts commit 8ba5d660f3.
2024-03-08 00:15:21 -08:00
Justin Newberry 8ba5d660f3 common PlatformFlags base class + test for < 32 bits (#31779)
* add 32 bit check

* space

* this is not required

* jk yes we do
2024-03-07 14:01:28 -08:00
Shane Smiskol 78a46ce724 car values formatting (#31747)
values formatting
2024-03-06 15:47:44 -08:00
Justin Newberry 25ccb2426c cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
2024-03-06 11:22:12 -08:00
Shane Smiskol 638aaa9e53 Platform configs: move tire stiffness into config (#31678)
* first one to open PR

* mazda

* oh it is

* fix gm car specs and create MazdaCarSpecs

* fix

* do honda

* ruff
2024-03-05 15:10:58 -08:00
Shane Smiskol eaf3332599 Revert "mazda"
This reverts commit b57d371626.
2024-03-01 21:37:29 -08:00
Shane Smiskol b57d371626 mazda 2024-03-01 21:37:09 -08:00
Justin Newberry b0eae8c1b7 platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
2024-03-01 11:31:51 -08:00
Shane Smiskol 690dc55ea2 Car flags: label static flags (#31639)
* comment, consistent source

* no caps not global

* no field

* label rest
2024-02-29 15:36:40 -08:00
Justin Newberry e122f1d749 Mazda: move to platform config (#31647)
* mazda platform config

* update ref
2024-02-29 11:14:00 -08:00
Cameron Clough 995250ae49 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
Shane Smiskol f0b6f48948 Mazda: use bus 0 to fingerprint (#31261)
* for testing

* switch OBD port to logging

* revert

* cmt

* cmt

* remove OBD query

* Update selfdrive/car/mazda/values.py
2024-02-01 00:28:00 -08:00
Justin Newberry 28eed156e0 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
2023-12-18 14:04:27 -08:00
Lukejb14 76c53e4742 Add 2021 Mazda CX-5 engine fingerprint (#30616) 2023-12-11 15:41:51 -08:00
Tam Chau 96eee13836 Mazda: add CX5 2022 fingerprint values (VN 2023) (#30342)
Add mazda cx5 VN 2023 values
2023-11-14 03:36:26 -08:00
Justin Newberry 6ae465e4af Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
2023-09-30 17:15:34 -07:00
Shurui Gui 0d7272ea19 Mazda: add FW versions for CX-5 2024 (#30093)
* Port CX-5 2024

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-09-29 00:59:23 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Pavel Galashin 9992f852b2 Mazda: fingerprint 2023 Mazda CX-5 Carbon Edition (#29092)
fingerprint 2023 Mazda CX-5 Carbon Edition
2023-07-31 19:51:44 -07:00
b801r 4b0cdf71f6 Fingerprint - 2020 Mazda CX-9 (#28805)
139b81648a954ae7|2023-07-04--13-46-16

VIN: JM3TCBDY7L0412945

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-10 11:07:56 +01:00
weapons eeccb09504 Mazda CX-5 2022 fingerprint (#28803)
Update values.py

Updated Mazda CX-5 2022 fingerprint for my vehicle (2023 Mazda CX-5 UAE).
2023-07-07 02:10:24 -07:00
Shane Smiskol d59172bc19 Mazda: query and log FW on bus 0 (#28569)
* mazda: query FW on bus 0

* update refs
2023-06-29 00:14:09 -07:00
Maxime Desroches e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Shane Smiskol 024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches 9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Maxime Desroches 70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
Jafar Al-Gharaibeh 97aeb83f95 Mazda: CX-9 2022, Mazda6 2018 FW (#27918)
* Mazda: CX-9 2022 FW

dongle-id: 7200177292912f30

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add mazda 6 2018 FW FP

dongle id: 0383a108994bd18b

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Samuel <samuel95_54@hotmail.com>
2023-04-17 23:11:38 -07:00
Saber422 18f49b4541 MAZDA: add missing 2018 Mazda6 wagon FW (#27863)
route name:79e2c7ffb9ae445d|2023-04-10--21-58-55--0
2023-04-10 19:10:36 -07:00
Shane Smiskol aab33b1c5f Lateral jerk unit test (#25759)
* stash

* more test

* less test

* clean test

* no angle

* add tolerance

* fix gm

fix gm

* test both

* lower some rates on hkg

* stash

* simpler

* bump panda

* Revert "bump panda"

This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.

* only torque

* make kona pass

* duplicate __init__

* move

* half clean up

* half clean up

* more clean up

* more clean up

* fix static analysis

* calculate over 0.5 seconds

* limit to max steer

* type annotation

* calc once
2022-12-15 21:52:07 -08:00
alancyau 9c62513ffa Mazda: Add 2023 CX9 fw (#26704)
* Mazda: Add 2023 CX9 fw

DongleID: 629c4aced073d15a
Discord User: bsk#7841

* Attempt to steer below 28mph for CX9

* undo comment

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-07 16:50:14 -08:00
alancyau 47977b2c0e Mazda: Add support for 2023 CX9 in CARS.md (#26717)
* Mazda: Add support for 2023 CX9

See https://github.com/commaai/openpilot/pull/26704 for the 2023 CX9 firmware.

* update values

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-12-06 16:37:18 -08:00
Jafar Al-Gharaibeh 1be4150089 Mazda: Add CX-5 2023 to supported cars (#26182)
* Mazda: Add CX-5 2023 to supported cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* add missing cam fw

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-10-25 15:32:49 -07:00
Jafar Al-Gharaibeh 63035e535b Mazda: add missing CX5 2021 FW (#25477)
dongle-id: 82c6d952da5e2122

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-10-20 19:50:42 -07:00
Shane Smiskol 0ef6bb48df FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
2022-09-09 16:24:29 -07:00
Cameron Clough e9c87daef6 rename esp ECU to abs (#25640)
* rename esp ecu to abs

* bump cereal
2022-09-07 14:25:57 -07:00
Shane Smiskol a0af3a998d Car docs: add more videos (#25494)
* Add Civic video

* add mazda cx-9 2022 video link
2022-08-19 13:34:23 -07:00
kravatch 3bb1315136 Mazda: add missing CX5 FW versions (#25423)
2022 cx5 signature
2022-08-12 22:31:57 -07:00
Jafar Al-Gharaibeh 75473daf31 Mazda: update supported models info (#25230)
* Mazda: update supported models info

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* correct format

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-21 10:20:58 -07:00
Jafar Al-Gharaibeh a7b778c324 Mazda: Support CX-9 2022 (#25147)
* Mazda: Support CX-9 2022

dongle-id: 8c6e0e30decb68f7

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update years

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-13 00:31:52 -07:00
Jafar Al-Gharaibeh 0eab1ed817 Mazda: CX-5 22 FW FP (#24778)
Mazda CX-5 2022 FW FP

dongle-id: 661621a8442f0688

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2022-07-12 19:38:18 -07:00
Shane Smiskol e11bb76a64 car docs: remove steering torque hard-coding (#25019)
remove good torque hardcoding
2022-07-01 19:11:28 -07:00
Yu Yamaguchi b51a90b5a8 Mazda: add missing FW version for CX-5 2022 (#24925) 2022-06-30 23:35:37 -07:00
Shane Smiskol 433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol ac1566b4c4 cars: move common car info to subclass (#24481)
* clean up values a bit and make HondaCarInfo for package

* also move min_steer_speed which had 12 occurrences

* odyssey has ALC down to 0

* do Nissan, Mazda, and Chrysler
2022-05-09 18:50:10 -07:00
Shane Smiskol 628eecff06 CARS.md tweaks (#23983)
* CARS.md fixups

* wrong one

* sort footnotes

* Mazda CX-9 has good torque

* Try this

* generate

* yup, os uses native filesystem order
2022-03-17 16:11:03 -07:00
Shane Smiskol 31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00