selfdrived: don't alert on a message that was never received
posenetInvalid, locationdTemporaryError and paramsdTemporaryError are raised
off the capnp defaults of deviceMotion and vehicleParameters before either
message has ever arrived. When modeld is down, locationd and paramsd never
publish, the defaults read as a nan posenet speed, and that NoEntryAlert can
hide the process not running alert that names modeld.
Same guard as the big model alert in #38500.
* Move LFS asset transfers to xet-core
* Limit migration to Git LFS hosting on Hugging Face
---------
Co-authored-by: Harald Schäfer <6804392+haraschax@users.noreply.github.com>
* esim: MICI profile download UI
* Show temporary feedback for non-LPA QR codes
* Scan eSIM QR codes every 250 ms
* Shrink eSIM error text and log displayed errors
* Activate downloaded eSIM through the profile tap flow
* Let the eSIM connectivity error wrap naturally
* Release add-profile button feedback immediately
* Check internet before opening the eSIM QR scanner
* Use UI network state and standard connectivity dialog for eSIM
* Drop LPA prime settings change from eSIM download UI
* Scope eSIM UI constants to their owning classes
* Remove unused ot codespell exception
* esim: simplify profile download operation and UI state
* esim: share activation code validation with QR scanner
* esim: match QR scanner video to cabin preview
* esim: show errors in a scrollable text dialog
* esim: require nonblank profile nicknames
* qrcode: add QR decoder
Decodes a QR code from a grayscale image or a module matrix: adaptive
binarization, finder pattern search by run ratios, perspective sampling
with alignment pattern refinement, format info, unmasking, block
de-interleaving, Reed-Solomon correction, and numeric, alphanumeric,
byte (with ECI), and Kanji segments.
Fixtures are packed matrices from python-qrcode 8.2 covering every
version and level, plus Segno 1.6.6 matrices for the ECI cases.
* qrcode: tune decoder for the device
Measured on a comma mici with real cabin frames downsampled to 672x380,
the size the eSIM screen scans at. Per frame: 30 ms -> 8 ms with no
code in view, 42 ms -> 13 ms with a code.
- binarize: fixed two-radius fill from one integral image instead of an
iterative outward fill (a dark cabin is almost all flat tiles), tile
stats on a contiguous layout, flat tiles decided whole so sensor noise
cannot become speckle, uint8 threshold compare
- finder search: scan every 4th row, build column runs only at
candidate columns
- alignment search starts at a 2-module radius
- Reed-Solomon syndromes through table lookups, placement order cached
* qrcode: simplify decoder
Fold the function-module mask into _data_coords and the format
coordinates into _read_format, evaluate masks directly on the data
coordinates, compact the ECI, numeric, and alphanumeric parsing, and
flatten the retry loop in decode. No behavior change.
Replace the level-L-only Reed-Solomon parameters, the single hardcoded
format word, and the bitwise GF(256) multiply with the full EC table,
the 32 format words, and log/antilog tables. Block splitting and
interleaving move into _block_lengths and _interleaved. This is the
structure a decoder needs to read any version, level, and mask; the
encoder's module matrices are unchanged and test_encoder pins them.
The closed-form step between alignment patterns rounds the wrong way
for version 32 (28 instead of 26). Use the form that is right for every
version. The encoder only emits versions 1-20, so its output is
unchanged.
* modeld: build DM warp and model JITs for all camera configs
In #38684, camera_configs on comma_arm64 was restricted to only the host device
running SCons (selecting either _os_fisheye or _ar_ox_fisheye).
However, prebuilt release and nightly bundles are built on TICI/tizi runners
in Jenkins and distributed to both Comma 3/3X (TICI) and Comma 4 (MICI) devices.
Because the build machine was TICI, dm_warp_1344x760_tinygrad.pkl was omitted
from the packaged bundle, causing dmonitoringmodeld to fail with FileNotFoundError
on Comma 4 and leaving driver-monitoring calibration stuck at 0%.
Restore CAMERA_CONFIGS so both camera resolutions (1928x1208 and 1344x760)
are built for all platforms.
Fixes#38762
* simplify
---------
Co-authored-by: ZwX1616 <zwx1616@gmail.com>
* esim: MICI eSIM profile management UI
* esim: align rename button position regardless of delete button
* esim: skip profile UI when SIM is not an eUICC
Probe is_euicc() on the first profile poll and cache it; non-eUICC SIMs
avoid list_profiles/process_notifications (which hang on a plain SIM) and
the eSIM button shows ICCID/MCC-MNC metadata instead of opening the
profile management screen.
* esim: satisfy ruff E731 in action_pressed helper
* esim: get modem info from modem.py state instead of shelling out
* esim: simplify switch lifecycle, drop active flag and settle window
* esim: only show 'switching...' on the target profile
* esim: read cell strength directly from HARDWARE
* esim: hide checkmark and dim cell icon during switch; keep rename available
* esim: disable active profile button (rename still clickable as overlay)
* esim: stop rename/delete buttons and labels from flashing during operations
* esim: show 'comma prime' on network button for comma profile
* esim: move display_name and is_comma onto Profile dataclass
* esim: anchor rename button to rightmost slot to prevent shift
* esim: include iccid prefix check in Profile.is_comma
* esim: drop process_notifications from cellular manager
* esim: disable network button when SIM isn't an eUICC
* esim: rename ESim* classes to Esim*
* esim: sort imports
* esim: default to 'loading...' instead of 'no active profile'
* esim: rename PROFILE_POLL_INTERVAL to PROFILE_POLL_INTERVAL_S
* esim: slim EsimNetworkButton
* esim: use DEFAULT_TEXT_COLOR; load delete dialog texture in __init__
* esim: revert cell-icon index trick, name each NetworkStrength explicitly
* esim: tighten delete/rename spacing so 'switch' label fits on one line
* esim: shrink delete/rename buttons by 25%
* esim: keep rename button at full size, only delete shrinks
* Revert "disable modem.py for now"
This reverts commit 1eeba86ec1.
* Revert "modem.py is disabled"
This reverts commit d238a1ccc4.
* lpa: inline comma iccid prefix
* ui/cellular_manager: clear switching state when LPA returns
* ui/cellular_manager: lock callback queue, drop poll log noise
* esim: sort NetworkStrength/NetworkType imports
* esim: drop switching_iccid concept
* esim: show 'switching...' on the clicked profile button
* esim: optimistic switch, skip post-switch list_profiles to avoid flicker
* esim: only style profile button from local op flags, not global busy
* esim: remove deleting/switching state, collapse profile button branches
* esim: show GSM settings on full prime when non-comma profile is active
* esim: expose CellularManager.active_profile, dedup callers
* esim: apply comma prime defaults on switch (roaming, metered, no APN)
* esim: restore re_sort on show_event to avoid first-frame jank
* lpa: apply comma prime defaults inside TiciLPA.switch_profile
* lpa: lazy-import Params to break circular import
* lpa: treat +CME ERROR 13 (SIM failure) as non-eUICC in is_euicc
* esim: show 'obtaining IP...' on non-eUICC path while connecting
* Revert "lpa: treat +CME ERROR 13 (SIM failure) as non-eUICC in is_euicc"
This reverts commit 475ca448ea914ff8f9892b4cbf4525d961d7618b.
* esim: poll profiles every 5s
* lpa: tighten Profile.is_comma to require both Webbing provider and comma BIN
* lpa: fall back to '<unnamed>' instead of iccid prefix in display_name
* esim: re-probe is_euicc each poll for runtime SIM swaps
* esim_ui: rename EsimUIMici to EsimUI
* esim: simplify cellular manager and profile UI
- optimistic profile switch at click time so the active button no longer bounces back
- unify LPA worker threads, refresh_profiles resets the poll timer
- deterministic profile ordering on show
- reuse wifi ForgetButton for delete, drop DeleteButton
- construct CellularManager inside NetworkLayoutMici
- drop comma prime param defaults from LPA.switch_profile (moved to a separate PR)
* esim: drop eUICC state change log
* ui: gate cellular settings on prime subscription
* ui: disable eSIM management for full prime
* ui: keep eSIM management disabled for full prime
* ui: unify eSIM profile action buttons
* ui: tighten eSIM profile action spacing
* ui: place rename before delete in eSIM actions
* esim: restrict individual profiles and process switch notifications
* esim: defer poll after operations and confirm eUICC loss before clearing profiles
* ui: allow cellular settings for unregistered and unpaired devices
* ui: disable all profile switching for full prime
* ui: simplify cellular access to not full prime
* ui: make profile poll interval a CellularManager constant
* ui: read modem state on the profile poll cadence
* ui: scope eSIM profile colors to their class
* ui: inline modem state read in cellular polling
* ui: rely on hardware modem state fallback
* cabana: connect palette theme, rounded cards, floating page switch
Move the jotpluggler port's connect palette into a shared theme module
(ui/theme.h/.cc) and apply it to all of cabana: Palette struct for dark
and light, applyTheme fills ImGui and ImPlot styles, readableCurveColor
and sectionTitle for reuse by the analysis workspace. Drop the old
DarkTheme constants and per-theme color branches in widgets.
Docked panels are borderless with content in rounded bordered cards;
custom-drawn rects use the style radii. The detail widget's bottom tab
bar is replaced by a floating Messages/Logs pill.
* cabana: scrollbar and menu contrast, page switch below the page
The scrollbar grab uses the border color on the window-colored track.
Selection colors are stronger so an open menu reads as blue in both
themes and the hovered item is visible in light mode. The Messages/Logs
pill sits in a strip below the page instead of covering its last rows.
* cabana: even spacing around the page switch, steady top menu highlight
* cabana: inner spacing before the clear button of a clearable input
* cabana: center the page switch below the page, space the signal row buttons
* cabana: logs table cells padded and bordered like the messages table
* cabana: recess the signals card in the window color
* cabana: one button vocabulary
Three button shapes, all one frame height with the style padding and
rounding: ImGui::Button for framed text, iconButton for a framed square
icon, toolButton for a flat square icon (or flat text). Adjacent buttons
are ItemInnerSpacing apart, groups ItemSpacing apart. Tool bars drop
their private padding and 1 px spacing, the signal row, chart header,
detail header, logs export and signal selector buttons all use the
shared sizes, and the page switch is built from the same style values.
* cabana: center the glyph ink in square icon buttons
* cabana: framed tool buttons and plain icon glyphs
toolButton is now iconButton with an optional text, so every button in
the app is framed. Boxed glyphs (plus-square, x-square, dash-square,
arrow-*-square, window-stack) are replaced by their plain variants
(plus-lg, trash, arrows-collapse, box-arrow-*, window-plus), the light
x/plus/dash by their -lg forms, the chart menu by three-dots-vertical
and the toolbar overflow by chevron-double-right.
* cabana: draw square button glyphs at 80% so full bleed icons keep a margin
* cabana: signal values in the mono font
* cabana: center square button icons on their atlas ink, snapped to framebuffer pixels
* cabana: draw square button glyph quads directly, AddText truncates the position
* cabana: right align the messages and signals tool bars to the table edge, full size collapse button
* cabana: detail header and tab scroll buttons flush with the right edge
* cabana: header and footer strips, gap above the panels, video splitter as a separator
The menu bar and the status bar are strips in the surface color with a
separator line towards the panels, and the dockspace sits one item
spacing below the menu bar, matching the spacing above the status bar.
The video/charts splitter draws the same 1 px separator line as the
dock splitters, centered in a gap as tall as the side padding, and a
double click snaps the video back to its natural height.
* cabana: top menus flush with the menu bar, 2 px video splitter without double click
* cabana: dropdowns continue the menu bar, splitter in the border color, row button gap
Top level menus draw no top border and square top corners, and the menu
bar leaves its separator out under the open dropdown. The video splitter
uses the border color like the dock splitters. The signal row buttons
keep one inner spacing before the scrollbar.
* cabana: dropdowns share the bar's 1 px border line, messages toolbar spacing matches the video card
* cabana: tool bar groups, framed dropdown buttons, chart content flush with the tool bar
Tool bar items are ItemSpacing apart and the items of a group (a button
pair, a separator and its neighbor) ItemInnerSpacing apart, instead of
a private 1 px spacing. The dropdown buttons are framed like the other
buttons. The video time is a plain mono readout that toggles on click.
Chart cards have no horizontal margin so their header and plot line up
with the tool bar above.
* cabana: chart list spacing: gap above the scroll area, charts clear of the scrollbar, even legend gaps
* cabana: loop and speed buttons grouped like the playback buttons
* cabana: survive narrow panels and small windows
Stress tested by dragging the column and video splitters to their
limits and shrinking the window to 640x480. Fixes: the messages tool
bar and the message detail header overflow into the >> menu instead of
clipping (the view button and the name stay); the binary view keeps a
minimum cell width and scrolls sideways; the Messages/Logs switch drops
to icons when the strip is too narrow; the camera keeps its last frame
across reconnects, so a video restored from a collapsed splitter while
paused is no longer black.
* cabana: range slider spans the charts >> menu, remove all and float as menu entries
* cabana: the charts card keeps its tool bar row or collapses, like the video at the other end
* cabana: uniform >> menus: dropdowns become submenus, the time readout an action entry
* cabana: video/charts splitter gap matches the column splitters
* cabana: drop unused lambda capture in chart type menu
Claude-Session: https://claude.ai/code/session_01XTFaJpf235LeHBmyFRgeJ1
* cabana: the menu bar and the status bar stay in full screen
* cabana: simplify theme helpers and toolbar actions
* cabana: preserve panel width for overflow edit dialog
* cabana: keep message editor usable in narrow panels
* cabana: group heatmap modes in a dropdown
* cabana: trim redundant restyle comments
* cabana: fix review findings from the restyle
- set the caret and other unset colors so the light theme has no white caret
- tolerate float error in the toolbar fit check to stop spurious overflow
- restore the full screen chrome hiding
- clear stale camera frames when the server changes, keep them across a collapse
- cache icon glyph ink bounds instead of scanning the atlas every frame
- drop dead plot_bg and ImPlot globals, add a badge palette role
- add toolbarMenu and use toolbarAction for the remove message item
- derive the signal view button size seed from the font and style
* cabana: remove remaining redundant comments
On Wayland a vsynced glfwSwapBuffers blocks until the compositor sends a
frame callback, which it stops doing while the window is on another
workspace or otherwise off-screen. The main thread never gets back to
glfwPollEvents, so Hyprland reports cabana as not responding.
Run with swap interval 0 and pace the loop to the monitor refresh rate.
Daniel Koepping