Commit Graph

1050 Commits

Author SHA1 Message Date
Justin Newberry c4f322ce2d Linter: remove pylint (#29611)
remove pylint
old-commit-hash: 1ee6ed4b16e2ade0dd887c0687243aee769043e5
2023-08-24 16:30:54 -07:00
Shane Smiskol dcf9d9e3a7 ui/map: clip vehicle speed to min of 10 m/s (#29601)
* all the changes I want to make

* Revert "all the changes I want to make"

This reverts commit c18132b73eb9bba4d7871631d7cd4155eb7efcd0.

* add initialized

* clip to 10 m/s

* fix bug

* rm

* here?
old-commit-hash: b8fb26055825f4ee35f647b6d84c2e6e6878a93f
2023-08-24 15:09:30 -07:00
Shane Smiskol 9a1f82a853 ui/map: initialize speed filter with current speed (#29605)
fix map starting from 0 zoom
old-commit-hash: b9d77afd7e91d46916b471bdc067f83edb2d64de
2023-08-24 14:53:47 -07:00
Dean Lee a1fe0701e9 ui: remove Q_PROPERTY from AnnotatedCameraWidget (#28745)
old-commit-hash: b234cb022356baceba3fb4a990c7c483216bd860
2023-08-24 11:09:26 -07:00
Dean Lee de809632bf cpplint: add filter whitespace/comma (#29595)
old-commit-hash: 7bfd3dac811ae95bfd09495e88377dfbaacda393
2023-08-24 10:42:06 -07:00
Dean Lee c4ae679878 ui/map: delete map after unsubscribing from prime (#29136)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

old-commit-hash: 792ad7d81677ebb95888541bac14fb6089c1e5fc
2023-08-24 16:51:53 +01:00
Dean Lee 0984736972 cpplint: add filter build/include_subdir (#29585)
old-commit-hash: 21da5a216fc8f5269d2deedc538c2f543a1c270a
2023-08-24 15:42:17 +01:00
Cameron Clough c7820cf1cc ui: hasPrime/primeChanged helper (#29590)
old-commit-hash: 05e91c074d0fbabfd3475d4f34b975819159519b
2023-08-24 12:47:22 +01:00
Dean Lee c6db4c515c ui: use enum PrimeType for prime_type (#29491)
old-commit-hash: 99279b8eef43586aa09d001668355fa41e01b98f
2023-08-24 12:26:45 +01:00
Dean Lee f7efad93e4 ui/map_instructions: restore padding (#29548)
* restore padding

* fixes

* fix left and right margins

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 4ea78330605cc3e46005e3d0f8915ef8a60c952a
2023-08-23 23:32:01 -07:00
Dean Lee 56b582a059 cpplint: add filter whitespace/forcolon (#29582)
whitespace/forcolon
old-commit-hash: ac939029835542a02b866e8a0d174f09773e4e6e
2023-08-23 22:46:02 -07:00
pencilpusher cc4f6c5fbe ui/map: keep the car icon aligned to its bearing (#29482)
* rotate icon with current bearing

When user is rotating the map, the car icon should stay fixed on the cars bearing, not the map.

* spacing

* comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 472151b6a004d387532415039196c2165f7d32df
2023-08-23 17:33:58 -07:00
Dean Lee 5ac4f52c6f ui/PrimeUserWidget: cleanup layout (#29492)
cleanup layout

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5fcb7e9038ec9054dcdb8d9b832bea2f597d6aa9
2023-08-23 16:34:18 -07:00
Dean Lee db211ce617 cpplint: add filter whitespace/parens (#29565)
old-commit-hash: 5480d32bb5d98d57100fd709b9ffe7bfcc6e020a
2023-08-23 14:25:05 -07:00
Dean Lee 97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e7500902070d0aacce69528bcfd8b9964
2023-08-23 13:25:17 -07:00
Dean Lee 004a097c95 cpplint: add readability/braces filter (#29554)
old-commit-hash: 363740a497620249066522c87ddb03e1362749d4
2023-08-23 10:13:46 -07:00
Dean Lee 11b5cfa422 ui/settings: Don't apply styles to more elements than needed. (#29463)
old-commit-hash: 5765c1d978c5890513e55398490447590d3b1d3e
2023-08-22 14:00:01 -07:00
Adeeb Shihadeh 701cd6f6fe add cpplint (#26855)
* setup cpplint

* only start that

* check line length

* check these

* rm exceptions
old-commit-hash: 952d720b6e854b3ebbb9fd0fd82cd38f3ae04b90
2023-08-22 13:55:23 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Dean Lee ff74c8c4cb ui/map_instructions: center lanes (#29465)
* center lanes

* test

* similar spacing and no need for stretchj

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9ea2cd8d0b5b697ffe7ae38a318ef44e5233ea44
2023-08-19 01:23:42 -07:00
pencilpusher fc14939f02 ui/map: interactive counter fix (#29470)
* use interactive_counter instead of separate zoom and pan counters

* use interaction_counter instead of separate zoom and pan counters

* same styling

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f2d22075ebd3f5e17628d1cf1ea102c7ce0bbb09
2023-08-19 00:07:52 -07:00
Dean Lee 3078da290d ui/map: better rounding for distances (#29151)
* round distance

* use same format in ETA

* remove vanish

* restore translate

* use nearbyint

* update translations

* mark finished

* consistent style

* we don't include this anywhere in ui, needed?

* fix missing std

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: efefcfdca581fd75868b993426dfde21c21c1531
2023-08-17 22:58:18 -07:00
Shane Smiskol 709850e304 map eta: use pair (#29460)
use pair
old-commit-hash: d827cd6a83cbcc4f8231706f085df0d2ec5ef69f
2023-08-17 22:42:12 -07:00
Shane Smiskol 593322dfa9 ui/map: slight turn lane types (#29446)
* add slight turns

* bump cereal

* revert

* hmm, i like this better

* whops

* fix

* bump
old-commit-hash: 6d2922b8e6f6ef29b6d17ea7a1c3d16b40e2236f
2023-08-17 20:51:52 -07:00
Dean Lee 023cd0492f ui/networking: do not skip the connected network (#29396)
* do not skip connected network

* simplify

* revert

* revert

* no implicit

* ifwt

* fix missing ssid

* makes more sense to only update security_type once (first vs. last)

* better comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b8b1e17a21390d9a80b1b0643c0001129292576c
2023-08-17 14:43:40 -07:00
Dean Lee 4857b61f8f ui/networking: pass network by value (#29448)
old-commit-hash: 1887d9197ab495bb8f4dd2826730e6d53528dd65
2023-08-17 11:37:42 -07:00
Dean Lee a50a9ef9b4 ui/map: hide icon if no maneuver type (#29084)
hide icon if no maneuver type
old-commit-hash: 202b2f2113d48f517c64f0daf9ad2d61fdb0b7a6
2023-08-17 02:05:19 -07:00
Dean Lee f667936f3a ui/map: show map on destination set/change (#29327)
* show map on dest set/change

* check for rcv_frame

* clear current_nav_dest

* restore allow_open

* use requestShow

* cleanup

* one check

* revert behavior changes

* Update selfdrive/ui/qt/maps/map.cc

* more obvious

* Update selfdrive/ui/qt/maps/map.cc

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3a277f1b81fbb16673a77a475421a18751127cf2
2023-08-17 01:32:22 -07:00
Shane Smiskol 312d80c877 map: set destination marker visibility once (#29444)
set visibility once
old-commit-hash: da38aed48300ca1db0a1032c12c26b0268ebb03c
2023-08-17 01:02:59 -07:00
Dean Lee 5cc9fbe23f ui: longer screen timeout for driver view (#27457)
* longer driverview timeout

* Update ui.cc

* reset timeout

* do cleanup

* Apply suggestions from code review

* Update selfdrive/ui/ui.cc

* reset to default timeout on hidden

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f1568b960a3da819c41c62dcaeafb4eb6dd109eb
2023-08-16 22:22:39 -07:00
Dean Lee e0439a516f ui/map: assign the return value to last_position (#29341)
assign the return value directly to last_position
old-commit-hash: 613bbb7e6da40b313dea86af9bfae71c057b375d
2023-08-14 16:39:43 -07:00
Dean Lee ec3b69928a ui/networking: bolding the connected network (#29385)
old-commit-hash: 29f2389cce373ccbf27526183aa34cfe5612c52d
2023-08-14 15:18:41 +01:00
Dean Lee 87c4c661c7 ui/map_instructions: set margin-top to UI_BORDER_SIZE (#29387)
old-commit-hash: 9071c8a4fcd392efd9b0533879ee080aff9cccac
2023-08-14 12:43:32 +01:00
Dean Lee 25df6335f7 UI: make wifi network sorting more stable (#29376)
* stable sort

* fix typo,rename to strengthLevel
old-commit-hash: 01089cf4bfea0d9c4484d18d78157227f5733db0
2023-08-13 21:12:23 -07:00
Dean Lee 431797307d ui/sidebar: break long line for readability (#29379)
old-commit-hash: 878d3f4cfc1aa6d35d7775567bb40476d68cc4cb
2023-08-13 18:03:38 -07:00
Dean Lee ce5c95715c ui/networking: remove dynamic property and style sheet (#29377)
old-commit-hash: 373171afd08a7890d326993ce2a6275ca79c1876
2023-08-13 14:48:06 -07:00
Dean Lee 42dd6af842 ui/networking: remove call to clearLayout (#29037)
* build list inplace

* move clearLayout to cabana

* cleanup include

* polish style

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fd8a9c852016ccfd13ae5146648a65f01cc2468c
2023-08-13 11:57:40 -07:00
Shane Smiskol d33545a0b6 ui/map_instructions: round <500 distances (#29333)
round
old-commit-hash: cc747e21666c6a6e382503eaf4cc29bfe3329635
2023-08-11 03:33:40 -07:00
Dean Lee b065f5c9a2 ui/map: fix CSS error (#29332)
fix css error
old-commit-hash: 4a89928a9a1eebcf46e789a2df037af66b087252
2023-08-11 03:31:13 -07:00
Shane Smiskol f8d9860d20 ui/map_instructions: clean up lane icon selection (#29330)
* draft

* revert

* remove extra directions

* more clean up

* add todo

* revert rename

* I assume this is moot, but preserve behavior

* spacing
old-commit-hash: 52675b2739de56a9b5784ba8016791cdb5286085
2023-08-11 03:27:32 -07:00
Dean Lee eb695a00c2 ui/map: check NavDestination only if navInstruction is invalid (#29331)
* check NavDestination only if navInstruction is invalid

* Update selfdrive/ui/qt/maps/map.cc

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 80356b34f1c189bee4287c0b70c3e6a18e105cc3
2023-08-11 03:26:08 -07:00
Dean Lee a494b38f6e ui/map: set WA_NoMousePropagation to prevent mouse event from propagating up (#29329)
set WA_NoMousePropagation
old-commit-hash: 15bb9dd09612bc23cc0d59da6fafd74669e1190e
2023-08-11 02:45:54 -07:00
Jason Wen 55f7f723a0 ui onroad: utilize local variables for repeated capnp reader access (#29325)
old-commit-hash: 22cf5421d625aaf578efcf572404a4d096c269b8
2023-08-10 23:13:45 -07:00
Dean Lee c8c2c5f801 ui/onroad: move duplicated code to drawIcon() (#29149)
* move duplicate code to function drawIcon

* fix center point
old-commit-hash: cef693f3097bf9c7a34e6d61afcac341814ab341
2023-08-10 23:08:46 -07:00
eFini e90ced8449 map ui: Fixed ETA text alignment issue in CJK (#29311)
fixed ETA text alignment issue in CJK
old-commit-hash: 8d7e909b539ee5e8411ccb7e3375a74dc6c86c2d
2023-08-10 02:15:43 -07:00
Cameron Clough 6ed5aca05a ui/map: update mapbox style (#29186)
old-commit-hash: 748238f87cbce5e05ffa06a49f490012d5424864
2023-08-08 20:18:49 +01:00
Shane Smiskol 7b1fa23144 map: fix exit lane direction when active (#29159)
* fix

* clean up

* comment
old-commit-hash: cffc14e4d8da259c6b69708868c9bef8d0a6febd
2023-08-05 04:02:18 -07:00
Dean Lee 823b570082 ui/OnroadWindow: do not update state when offroad (#29134)
do not updateState when offroad
old-commit-hash: da9155505627cf4490704bf928e71f77a094337f
2023-07-31 20:25:15 -07:00
Shane Smiskol fdc00cf0b6 Experimental mode toggle description: missing spaces (#29167)
* Update settings.cc

* more missing spaces

* scons

* vanish

* fix that
old-commit-hash: 6fe480b232ab85282b06f50473c12c492b5364fd
2023-07-27 14:00:41 -07:00
Adeeb Shihadeh 178d9adec3 ui: less confusing wifi training (#29137)
* ui: less confusing wifi training

* update

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 0922a1040f3fba4d446f1f1ae03df897375a9341
2023-07-25 13:32:00 -07:00