Commit Graph

193 Commits

Author SHA1 Message Date
Adeeb Shihadeh aea2faaa98 Alert cleanup (#2274)
* no more focus recover active

* consistency

* more permanent

* dm alerts

* sanity check test

* no please

* clean that up

* update refs

* one more

* bump cereal
old-commit-hash: ae4b4bd1256c11153035e4236cd801738f135c51
2020-10-14 15:56:18 -07:00
Adeeb Shihadeh 5dc58abbbe clear irrelevant alerts on state transition (#2318)
* cleanup

* clear warnings

* more types

* needs refactor

* update refs

* update refs
old-commit-hash: 1c6905cac1c5b4528e60dac3279357959c2e2bc3
2020-10-14 14:08:15 -07:00
Willem Melching 94a947e59a Fix lane change when blinker is turned off early (#2324)
old-commit-hash: ce85e402f4a7141d8ee739006c20a5492c06a2ea
2020-10-13 17:42:29 +02:00
Shane Smiskol 09aad99228 Use math instead of numpy for calculating TTC, on average 80% faster (#2293)
* Use math instead of numpy, on average 80% faster

* whoops
old-commit-hash: 6133f603f046bb08c8e3493c3092c796156b8930
2020-10-08 14:23:53 +02:00
Logan Lasiter dd0c9d0796 Present alert if fan isn't spinning (#2258)
* Present alert if fan isn't spinning

* allow entry

* Small updates

Moving to fan malfunction event

Only trigger event for uno or dos

* Changed checking fanSpeed > 50%

* Update text for fan malfunction alert.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Alert if fan isn't spinning for 5 sec

* Alert edit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1a2efdc139868f3588a4a35505e8833eacee735d
2020-10-07 12:15:09 +02:00
Adeeb Shihadeh aff01412d3 cleanup duplicate function
old-commit-hash: bd4a1f291df99e237d73ff0b3743d9ffcd88eb93
2020-10-06 23:59:16 -07:00
Adeeb Shihadeh 69946508db bump cereal
old-commit-hash: 70bc935210c8b948ab20f1d72fd2c6a6884d4cfd
2020-10-05 18:43:21 -07:00
cydia2020 ca29e033e9 add 1 second delay to acc pedal alert (#2221)
So that the screen wouldn't appear to "flicker" when openpilot is engaged while the acc pedal is being released
old-commit-hash: 6d5b2af3f2290d9cf99c4eee3eb9c412a069fbb4
2020-09-28 16:17:21 -07:00
qadmus b48d1823e9 remove unused globals, use self.reset() (#2220)
Co-authored-by: user <email@web.com>
old-commit-hash: 254814cc793dc4668ea9fd25f092b0712fb5b8a0
2020-09-24 11:39:47 +02:00
Adeeb Shihadeh 6f96ed3c59 remove unused alert
old-commit-hash: cdcf2350252059e937b032ea2448584ff3c512a9
2020-09-22 13:47:30 -07:00
qadmus c613f8dfcc cleanup long planner, mpc: unused globals and arguments (#2211)
Co-authored-by: user <email@web.com>
old-commit-hash: 72e0ac2de1087760822b8a552c569ab3a859e2a5
2020-09-21 11:43:28 +02:00
Willem Melching 2b95a9fec2 Revert "tici: take into account frame timestamp (#2199)"
This reverts commit 58dc2982af6593d7a31464342d80190fa365287e.

old-commit-hash: 65e5032a97cba8c294e0763eeaaa430d4803a4d6
2020-09-21 10:31:01 +02:00
Adeeb Shihadeh 69c45af274 alertmanager type hints (#2201)
* alertmanager types

* clean that up

* more cleanup

* little more

* space
old-commit-hash: 15e4048318c2bf2e3e064c3f1e7e288edb9f902c
2020-09-19 10:53:14 -07:00
Willem Melching 5d817c4f46 tici: take into account frame timestamp (#2199)
* compensate for frame processing time

* add rolling shutter time

* Add max frame delay of 250ms

* only delay on tici
old-commit-hash: 3a494e144bd85166fe347cf3c0b8bfbf22d8e462
2020-09-18 17:42:29 +02:00
Adeeb Shihadeh 8221c26fab type hints for alerts and fix community feature alert (#2196)
* fix startup alert for community features

* type hints for alerts

* more type hints

* fix dashcam only alerts

* more type hints
old-commit-hash: a81a18205e85ac576a5cf5e330e3f7b99fcb4152
2020-09-17 22:06:31 -07:00
ZwX1616 6f3c2fba6e Cut down unnecessary DM uncertain alerts (#2157)
* cut down high std alerts

* clean comments

* uncertain curve tune

* update test gt

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a2adfdb155f2293d9a2e7be11e81af8c020f011b
2020-09-14 10:43:19 -07:00
Adeeb Shihadeh 6dbfe6fb9e prevent reversing alert from showing while changing gears
old-commit-hash: a4a4e28c1a9948297d36f562aad6343294380d47
2020-09-12 17:21:30 -07:00
Adeeb Shihadeh 64a9728f2e Reduce paramsd and calibrationd CPU usage (#2119)
* reduce paramsd cpu

* reduce calibrationd cpu usage

* calibration_helpers was mostly unused

* more calibration cleanup

* update refs

* fix thresholds in CPU test
old-commit-hash: e0004d09810d9c3bcb8681bca110bf5bbd09445a
2020-09-10 12:16:29 -07:00
Adeeb Shihadeh 5b9466a76e hide camera view when in reverse (#2144)
* partially hide camera view when in reverse

* lowest priority

* update ref commit

* fix type

* update refs
old-commit-hash: 9cd88526b513250aae592761a4d554a0eae4acc0
2020-09-09 00:11:12 -07:00
Adeeb Shihadeh e17575f36d make calibrationInvalid a permanent alert
old-commit-hash: 86f4d86cd7ae704d97efea1638f1a510d950c9bc
2020-09-04 13:20:48 -07:00
ZwX1616 fca076b982 not show soft recover alerts
old-commit-hash: 9731e7a0d7af7aec44097e0028c10427681d4e8c
2020-08-27 17:59:26 -07:00
Chris 42538fd54b Kilometers per hour now displayed as km/h (#2032)
Fixes #2031

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
old-commit-hash: 1b52930a52828b1423c59c677c9b42a5ff76125c
2020-08-17 11:16:52 +02:00
Adeeb Shihadeh c2b1d97b20 NEOS background updater (#1892)
old-commit-hash: cb5a2996e75658ac61f057fb729c229a554c551e
2020-08-12 11:39:21 -07:00
Adeeb Shihadeh 017b084154 Alert when updated consistently fails (#2013)
* alert when update fails more than 10 times

* bring over offroad alert refactor from other branch

* and we have tests

* use it in snapshot

* bump apk

* don't show exceptions on release branches

* only write when changed

* why does delete use so much cpu

* clean that up

* little more
old-commit-hash: 8e63f065400ea1868f077560ae89b2c17f5523f8
2020-08-11 16:23:57 -07:00
Adeeb Shihadeh 944759717e fix missing negative limit in pid controller (#2001)
old-commit-hash: ee99b59bade8d3b5057a5b3f22ad8b3edd102c78
2020-08-08 11:49:13 -07:00
HaraldSchafer 122118ccd4 add fall filter and less FP on posenet (#1971)
* add fall filter and less FP on posenet

* add alert

* list

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 490ee5268712c38f738161cab939c02573581ebf
2020-08-03 15:51:56 -07:00
HaraldSchafer bc3b340694 Misc locationd improvements (#1714)
* I like this more

* rewind less

* bump rednose

* falling off windshield detectopr

* adjust thresholds

* this is a soft disable now

* move that

* process replay fixes

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8e2d344135b9a1102503432d651e6bf599d9fa42
2020-07-30 15:33:22 -07:00
Shane Smiskol 3454f1e033 Fix hard deceleration after user accelerates above set cruise speed (#1880)
* Fix hard deceleration after user accelerates above set cruise speed

* 2nd required change
old-commit-hash: ebadb39e42d8a39eaf3bc969157777d596e42012
2020-07-20 17:04:05 +02:00
Adeeb Shihadeh cd317b0780 Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
old-commit-hash: 5db81f60ca8fbc0ef28924b7e93f25a1d4bb3764
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh a1dbb38a0c Alert when modeld is lagging by more than a frame (#1823)
* alert when modeld is lagging by more than 1 frame

* log frameAge in modelData

* set posenet valid

* compute frame_age once
old-commit-hash: 03e824a4b558daa15191408e88b73fee7ab1792f
2020-07-09 17:02:21 -07:00
Greg Hogan bcf7edf595 k-line 5 init fault type (#1821)
* k-line 5 baud fault type

* update name

* bump cereal

* fix name

* add missing event
old-commit-hash: c458f5a5d3587d0eb87abbebd86c4f399e28c63d
2020-07-06 09:33:16 -07:00
Adeeb Shihadeh 8b2ae9319a fix blindspot detection
old-commit-hash: 64aeb80dcc651de9836d46db08c2b4a17af364f0
2020-06-30 13:44:56 -07:00
robbederks 4b2775add9 Dos (#1795)
old-commit-hash: df86c476c76f53d385d3c8df63d27588dde3dccd
2020-06-29 12:47:48 +02:00
Adeeb Shihadeh 17fc7e2bec Add alert while in preEnabled state (#1791)
old-commit-hash: ce80684f7ec6a61d8e4f08471611a30562707154
2020-06-28 20:29:42 -07:00
Willem Melching 5f97bf6056 fix wrong car mode alert
old-commit-hash: 5e254da8b39bff7b2710652b5a3c5ec0d96abb95
2020-06-24 18:20:30 -07:00
Adeeb Shihadeh 55225dcd56 Block lane change start on blindspot detection (#1712)
* use BSM to block lane change start

* remove duplicate entry

* add approaching
old-commit-hash: c4a3d7afb0a190ea0abcf3deb0ec754b31de2cb3
2020-06-24 17:31:09 -07:00
ZwX1616 9bca4bfb20 recover EON/C2 AF (#1665)
old-commit-hash: 3aa99a01d7a29c69f1b767b3fca30d18a6047425
2020-06-23 14:33:32 -07:00
Adeeb Shihadeh ab66589a46 fix engage/disengage sounds
old-commit-hash: 51b7dc0e385945faf0341c52b14555e75e804d04
2020-06-23 10:50:24 -07:00
Adeeb Shihadeh d66c6202bb more generic alert text for wrongCarMode
old-commit-hash: cab96374c5c511adcb83882c52502924a2d08089
2020-06-19 20:36:10 -07:00
Adeeb Shihadeh e8ced8bee5 Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
old-commit-hash: ccf6b80c7e5aa24b922ed60a519eab91a1d5ec9b
2020-06-19 16:16:48 -07:00
Adeeb Shihadeh b32859413f hwType is in health
old-commit-hash: fd8514eee339e68df48c27711b79e90cbca43f76
2020-06-18 15:37:21 -07:00
Adeeb Shihadeh a8edabe453 if sky visible
old-commit-hash: e892d6a9d9efa624ae486d6c8449a452fd1286ee
2020-06-18 14:40:57 -07:00
Adeeb Shihadeh fb4bdf8c24 update no GPS alert for comma two users
old-commit-hash: b3101998ed6457e83e326f87be9f062ac97c0030
2020-06-18 13:01:28 -07:00
Adeeb Shihadeh 092cb5a021 NEOS update required alert (#1722)
* NEOS update required

* permanent alert

* bump cereal
old-commit-hash: 6c156d7f45ee21f77fbafcb9867fb0712adb53f5
2020-06-16 12:21:41 -07:00
Adeeb Shihadeh b16559c4a0 Block entry on non-adaptive cruise mode (#1708)
* block entry on non-adaptive cruise mode

* user disable

* toyota
old-commit-hash: 25688f36cc16f4a4ce57e2e6d7a5c33e78cd520f
2020-06-15 18:11:50 -07:00
Adeeb Shihadeh 1dfa960485 bump cereal
old-commit-hash: 9e34ed4e8ccf624125177df4f3a8511d02115a86
2020-06-15 16:01:35 -07:00
Adeeb Shihadeh f008dc9f61 bump cereal
old-commit-hash: 92c29c426916765b3af8d976a62502ece295f39e
2020-06-12 20:38:45 -07:00
Willem Melching 415c336c41 no gps warning after 5 minutes (#1692)
old-commit-hash: 684f7b2cc073010eb9e9cebfecbf1205be17d5a8
2020-06-12 16:03:35 -07:00
Adeeb f396864fab Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
old-commit-hash: 0bbe870b5f90c25427c4d21cabe4a0f78291eee9
2020-06-12 15:32:50 -07:00
Adeeb ea0292d86e Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
old-commit-hash: d4858e5ff5753f8a800f3e90cb4c0f69213b87f3
2020-06-09 13:25:15 -07:00