Commit Graph

214 Commits

Author SHA1 Message Date
Adeeb Shihadeh 944759717e fix missing negative limit in pid controller (#2001)
old-commit-hash: ee99b59bade8d3b5057a5b3f22ad8b3edd102c78
2020-08-08 11:49:13 -07:00
HaraldSchafer 122118ccd4 add fall filter and less FP on posenet (#1971)
* add fall filter and less FP on posenet

* add alert

* list

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 490ee5268712c38f738161cab939c02573581ebf
2020-08-03 15:51:56 -07:00
HaraldSchafer bc3b340694 Misc locationd improvements (#1714)
* I like this more

* rewind less

* bump rednose

* falling off windshield detectopr

* adjust thresholds

* this is a soft disable now

* move that

* process replay fixes

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8e2d344135b9a1102503432d651e6bf599d9fa42
2020-07-30 15:33:22 -07:00
Adeeb Shihadeh 224b7fd34b Remove get_one_can from messaging (#1946)
* move get_one_can into openpilot

* bump cereal
old-commit-hash: 714f8c3f0bf8fa98a4619763d46ecb3ea29bc9f6
2020-07-28 23:52:18 -07:00
Adeeb Shihadeh 6e7fde5d61 Revert "can't directly access sockets anymore", was supposed to be on branch
This reverts commit 1046c572b4e49608137f687263d443eab6c430f8.

old-commit-hash: acb25751b75059a6e212192064528afe0ebd5e03
2020-07-28 18:41:39 -07:00
Adeeb Shihadeh 59ade6c2f6 can't directly access sockets anymore
old-commit-hash: 6acda96a163ad77f2f0b283712ac79b3d3d90d54
2020-07-28 18:37:16 -07:00
Shane Smiskol 3454f1e033 Fix hard deceleration after user accelerates above set cruise speed (#1880)
* Fix hard deceleration after user accelerates above set cruise speed

* 2nd required change
old-commit-hash: ebadb39e42d8a39eaf3bc969157777d596e42012
2020-07-20 17:04:05 +02:00
Adeeb Shihadeh cd317b0780 Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
old-commit-hash: 5db81f60ca8fbc0ef28924b7e93f25a1d4bb3764
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh c374f03187 Revert modeld vipc conflate behavior and alert on dropped frame percent (#1877)
* Revert "Fix modeld dropping frames if processing takes over 50 ms"

This reverts commit fb908877a50d72e20a047bd4138316b12c8a30cc.

* track frame drop

* fix unused

* alert on frame drop perc

* reduce thresholds

* posenet is invalid on non-consecutive frames

* Refactor filter time constant

* Use vipc_dropped_frames for posenet valid check

* Actually set frame drop percentage

* Add explicit cast just to be sure

* Prevent frames dropped to go up to quickly on startup

* bump cereal

* reduce soft disable threshold to 1%

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 58c3b5ba84f6c3da3c660770148cea98c708fce5
2020-07-14 14:23:27 -07:00
Adeeb Shihadeh a1dbb38a0c Alert when modeld is lagging by more than a frame (#1823)
* alert when modeld is lagging by more than 1 frame

* log frameAge in modelData

* set posenet valid

* compute frame_age once
old-commit-hash: 03e824a4b558daa15191408e88b73fee7ab1792f
2020-07-09 17:02:21 -07:00
Greg Hogan bcf7edf595 k-line 5 init fault type (#1821)
* k-line 5 baud fault type

* update name

* bump cereal

* fix name

* add missing event
old-commit-hash: c458f5a5d3587d0eb87abbebd86c4f399e28c63d
2020-07-06 09:33:16 -07:00
Adeeb Shihadeh 0d79150606 Sound test (#1820)
* WIP sound test

* it does something

* refactor

* phone only

* update release files

* test sound card init

* add to CI

* check writes

* increase time

* unused

* only build cereal

* small tolerance

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f1afb3e3ae4b95a1de0262d1408c49093c5ada6f
2020-07-05 17:56:24 -07:00
George Hotz 70dbce450c Add an SSH param to disable updates (#1807)
* disable updates with optional param

* dont create the alert

* Revert "dont create the alert"

This reverts commit 7179a6c8b4b4656e0b203b5a590b33d3388aa9c9.

* keep alert, but allow engagement

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cb495bb8c9af8b9347bfe3cf4b59baf1f6d10482
2020-07-01 14:26:35 -07:00
Adeeb Shihadeh 8b2ae9319a fix blindspot detection
old-commit-hash: 64aeb80dcc651de9836d46db08c2b4a17af364f0
2020-06-30 13:44:56 -07:00
robbederks 4b2775add9 Dos (#1795)
old-commit-hash: df86c476c76f53d385d3c8df63d27588dde3dccd
2020-06-29 12:47:48 +02:00
Adeeb Shihadeh 17fc7e2bec Add alert while in preEnabled state (#1791)
old-commit-hash: ce80684f7ec6a61d8e4f08471611a30562707154
2020-06-28 20:29:42 -07:00
Willem Melching 5f97bf6056 fix wrong car mode alert
old-commit-hash: 5e254da8b39bff7b2710652b5a3c5ec0d96abb95
2020-06-24 18:20:30 -07:00
Adeeb Shihadeh 55225dcd56 Block lane change start on blindspot detection (#1712)
* use BSM to block lane change start

* remove duplicate entry

* add approaching
old-commit-hash: c4a3d7afb0a190ea0abcf3deb0ec754b31de2cb3
2020-06-24 17:31:09 -07:00
ZwX1616 9bca4bfb20 recover EON/C2 AF (#1665)
old-commit-hash: 3aa99a01d7a29c69f1b767b3fca30d18a6047425
2020-06-23 14:33:32 -07:00
Adeeb Shihadeh ab66589a46 fix engage/disengage sounds
old-commit-hash: 51b7dc0e385945faf0341c52b14555e75e804d04
2020-06-23 10:50:24 -07:00
Willem Melching 6dc1c6e58e cleanup no sensor data alert (#1760)
old-commit-hash: 264015c584a0a010ba5f63af67da2e6bddebbea4
2020-06-22 14:27:07 -07:00
Adeeb Shihadeh d66c6202bb more generic alert text for wrongCarMode
old-commit-hash: cab96374c5c511adcb83882c52502924a2d08089
2020-06-19 20:36:10 -07:00
Willem Melching df9cd4dadd Remove kernel check from controlsd
old-commit-hash: 77b7d306834feeba6ac131bfa438465e18d0a3f2
2020-06-19 16:54:42 -07:00
Adeeb Shihadeh e8ced8bee5 Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
old-commit-hash: ccf6b80c7e5aa24b922ed60a519eab91a1d5ec9b
2020-06-19 16:16:48 -07:00
Willem Melching c9e2c38f91 Only show gps event after 1 km (#1747)
old-commit-hash: 24de8174dcb59fea10402060b8dd1db6ecdaf0f5
2020-06-19 14:11:23 -07:00
Willem Melching 390b28cd11 Move kernel check to before creating the submaster, prevent SIGUSR2
old-commit-hash: 2b20479a5c37eeefe6ef6c3b91016c7d5874af30
2020-06-19 13:26:52 -07:00
Adeeb Shihadeh ac0bdce786 catch CalledProcessError when detecting kernel version
old-commit-hash: 0cda65b58e4cb452ac2c3e8a45e3bf7e2905b32f
2020-06-19 12:42:33 -07:00
Adeeb Shihadeh b32859413f hwType is in health
old-commit-hash: fd8514eee339e68df48c27711b79e90cbca43f76
2020-06-18 15:37:21 -07:00
Adeeb Shihadeh a8edabe453 if sky visible
old-commit-hash: e892d6a9d9efa624ae486d6c8449a452fd1286ee
2020-06-18 14:40:57 -07:00
Adeeb Shihadeh fb4bdf8c24 update no GPS alert for comma two users
old-commit-hash: b3101998ed6457e83e326f87be9f062ac97c0030
2020-06-18 13:01:28 -07:00
Adeeb Shihadeh 092cb5a021 NEOS update required alert (#1722)
* NEOS update required

* permanent alert

* bump cereal
old-commit-hash: 6c156d7f45ee21f77fbafcb9867fb0712adb53f5
2020-06-16 12:21:41 -07:00
Adeeb Shihadeh b16559c4a0 Block entry on non-adaptive cruise mode (#1708)
* block entry on non-adaptive cruise mode

* user disable

* toyota
old-commit-hash: 25688f36cc16f4a4ce57e2e6d7a5c33e78cd520f
2020-06-15 18:11:50 -07:00
Adeeb Shihadeh 1dfa960485 bump cereal
old-commit-hash: 9e34ed4e8ccf624125177df4f3a8511d02115a86
2020-06-15 16:01:35 -07:00
Adeeb Shihadeh f008dc9f61 bump cereal
old-commit-hash: 92c29c426916765b3af8d976a62502ece295f39e
2020-06-12 20:38:45 -07:00
Willem Melching 415c336c41 no gps warning after 5 minutes (#1692)
old-commit-hash: 684f7b2cc073010eb9e9cebfecbf1205be17d5a8
2020-06-12 16:03:35 -07:00
Adeeb f396864fab Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
old-commit-hash: 0bbe870b5f90c25427c4d21cabe4a0f78291eee9
2020-06-12 15:32:50 -07:00
Adeeb ea0292d86e Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
old-commit-hash: d4858e5ff5753f8a800f3e90cb4c0f69213b87f3
2020-06-09 13:25:15 -07:00
Willem Melching d0f60029cb Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
old-commit-hash: 15dc6044d44e7f85293cb9b0187c7d2a51a84c55
2020-06-05 16:01:53 -07:00
Jason Young ebed52527b Reduce scheduler latency for realtime processes (#1638)
* WIP: reduce boardd and other lags

* Copypasta fault

* Silence spurious startup warning

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 68531b071cde6fa5856d9b68bed63ecb50e03c2a
2020-06-05 17:09:41 -04:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Jafar Al-Gharaibeh bbe43de357 Fix rounding of minSteerSpeed in events (#1620)
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring

Python3 interpreter:
>>> print(" %d  %d" % (1.6,1.4))
 1  1
>>> print(" %d  %d" % (round(1.6),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),int(round(1.4))))
 2  1

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 73db0791997efa270f6793b7acb422aedc22d21f
2020-06-03 14:01:32 -07:00
Willem Melching dbdbef72d6 vehicle model types (#1631)
old-commit-hash: 240041708450d916bb49ee229ee4cff0e5f5ab59
2020-06-03 13:47:47 -07:00
Willem Melching db4a918c2a Bounds checks on liveParameters for testing on desk
old-commit-hash: 0f20ac728f4558ee8a849646f366d816a2479b62
2020-06-03 11:31:12 -07:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching a749ebb1c4 speedTooHigh should not be an immediate disable
old-commit-hash: 205cb04ee95f51c0d96f20d71564ef6d1c530d85
2020-06-01 15:53:41 -07:00
Willem Melching 3e630fce60 Make driverview not pin two cores at 100%
old-commit-hash: fab8425f2f5277f3e767e29f01942448674428b0
2020-06-01 13:58:54 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00