Commit Graph

178 Commits

Author SHA1 Message Date
Shane Smiskol 8aadc8dda6 Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
old-commit-hash: 860f441e2f122173c5034656aeed5706fd41e38f
2022-11-29 11:49:13 -08:00
Vivek Aithal 5bc529bf20 [controlsd] Toyota Prius 2017 (#26455)
* increase lag on prius

* better offline values computation

* split prius ecu more, set deadzone to 0

* add deadzone back

* replace deadzone with slack

* reduce deadzone to 0.2

* update refs
old-commit-hash: 0706b03e8cf41f7d51c9a42f01bda2084bfe3be6
2022-11-29 10:47:13 -08:00
Shane Smiskol bcdbd8edb9 Toyota: alert when in standstill (#26585)
* add resume required alert

* possibly need this (pressing resume with brake held does nothing)

* better text (has both meanings)

* try this

* Revert "try this"

This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.

* no alert with interceptor

* check long
old-commit-hash: 3253b8590002fa5f56e003add3f5f47a21870873
2022-11-25 16:00:58 -08:00
Vivek Aithal 66231d85de [controlsd] Toyota Rav4 TSS2 bugfix (#26421)
bugfix toyota rav4 pid init values
old-commit-hash: c64e2c228a57dd82685f9ca4251c49e953e1ac69
2022-11-09 12:09:55 -08:00
Vivek Aithal cfe94a3c1b [controlsd] Revert Rav4 TSS2 to PID control (#26403)
* revert rav4 tss2 to pid control

* Update interface.py
old-commit-hash: a0edd05bb0dec303df655a7695346ee0b90a2d37
2022-11-07 18:25:39 -08:00
Shane Smiskol da68ac1b66 car docs: auto-generate footnote for DSU cars (#26321)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* fix autoResume

* fix autoResume 2
old-commit-hash: 3e69973819ba337743d4d9c71d31369a761a688d
2022-11-03 01:00:33 -07:00
Shane Smiskol 94433bb818 Toyota: add unsupported DSU car list (#26336)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* .

* .

* revert

* revert

* smaller diff
old-commit-hash: b0656f2c751df64fb3974c66423470b7a59bc1e6
2022-11-02 20:12:35 -07:00
Shane Smiskol a230015754 Toyota: unify deadzone params (#26325)
* i'm sure this makes no difference

* update refs
old-commit-hash: 423d16693a4d805db2035dcd87f120b2902c2c4a
2022-11-02 02:09:54 -07:00
Vivek Aithal bfddb98683 [torqued] Extend to all Toyota and Hyundai cars (#26238)
* extend to toyota and hyundai

* remove all pid control in hyundai

* remove indi tunes

* remove toyota lat tunes

* release notes

* rm tunes.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f6bab0cd678e3020c7b0e2257309df69f83de0f0
2022-10-25 16:09:36 -07:00
cydia2020 858c249f90 Toyota: longitudinal tune condition cleanup (#25676)
* Toyota: clean up long tunes a bit

* Update selfdrive/car/toyota/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2704e2cf4d805712695422b6c8e513ba7f479877
2022-09-10 16:42:28 -07:00
Adeeb Shihadeh e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b60318ce44ef0271e03de16e8b135b5268
2022-09-07 17:12:49 -07:00
Shane Smiskol 1fcc31aac6 Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
old-commit-hash: 452d5e42ecf963fee65889937662c708f5e17474
2022-08-30 17:54:40 -07:00
Adeeb Shihadeh 5263356958 remove CS.steeringRateLimited (#25251)
* remove CS.steeringRateLimited

* bump cereal

* update refs
old-commit-hash: d462a08056d54a957084d594286626a2509c94aa
2022-07-24 14:56:55 -07:00
Shane Smiskol b81c26e7be Highlander: merge params (#25210)
* merge highlander params

* weight is average of tss normal/hybrid and tss2 normal/hybrid
old-commit-hash: 5ea641b79aaa57115b71313eee4cb47b78394c28
2022-07-18 23:54:45 -07:00
Shane Smiskol 0d83812f86 Clean up CarControllers (#25008)
* do VW

* Do the rest

* unused

* ford cc formatting

* final clean ups

* also just return update output
old-commit-hash: d2c2154a32db0876036f4f6b61b912de0c90fc5a
2022-06-30 17:23:12 -07:00
Adeeb Shihadeh 145f3c96ba cleanup torque tuning config (#24951)
old-commit-hash: 062a8bcdbd78826cbb035c1dabc6ebd18a9367dd
2022-06-24 13:01:49 -07:00
HaraldSchafer ce87f9af2f Cleanup car interfaces (#24948)
* remove interface overrides

* Fix test

* set torque tune for ev6
old-commit-hash: d8bfe2f0052390b8864910b00e43f61c0eeb9ff7
2022-06-22 19:20:07 -07:00
HaraldSchafer b0b1aff5cc Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: 9283040d847b120fdf7759d5bd12000863e12f73
2022-06-15 15:29:42 -07:00
Shane Smiskol 2be8856e28 Move RAV4 2022 out of bronze
old-commit-hash: a78197ab1af40dcdc0fe5a8f764b476da3837e87
2022-06-13 21:49:50 -07:00
HaraldSchafer 539221df6c Move couple toyotas to torque table values (#24849)
* Move couple toyotas to torque table values

* Dont set for all cars yet

* Dont regress docs

* update ref
old-commit-hash: dbfe923ecc0e14a781a7f03646ccf885ab2fa47a
2022-06-13 19:08:09 -07:00
Shane Smiskol 02cffeb858 Toyota Camry TSS2: update torque control params (#24819)
Use updated accel and friction values for TSS2 Camry
old-commit-hash: 566de12671f7fbf299306339c0ca901754f7f3ca
2022-06-13 09:29:28 -07:00
HaraldSchafer bc679f735d Misc torque control fixes (#24801)
* Fiction compensation should be based on error

* Update refs

* Add deadzone

* update ref
old-commit-hash: 843e59f6f0be33e6c51a35ef8912f5b7c4b58ca5
2022-06-10 22:52:48 -07:00
HaraldSchafer f7edd5f3d3 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3066ad81a8b2f89a22ddfc86a879395c573ce0f5
2022-06-10 17:57:23 -07:00
AlexandreSato db9d0e3bd6 Lexus: NX Hybrid 2020 support (#24796)
* LEXUS: Missing esp and engine FW versions in values.py

DongleId: 09ae96064ed85a14  | testRoute: 09ae96064ed85a14|2022-01-10--01-57-37 |

* Make a new platform for NX Hybrid TSS2

* Update releases

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 074f614f880fa85a56596cd2917c07d8f39961f1
2022-06-09 12:01:31 -07:00
Shane Smiskol 1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c04bec31677170782d5f3e1f404c2a7
2022-06-03 17:41:20 -07:00
ntegan1 44ae448563 TSS-P Corolla: use torque lateral control (#24291)
use torque controller for tssp corolla

Co-authored-by: ntegan <nick.egan.gg>
old-commit-hash: 7115f1f7c8e43a4e97fcb7bfb51f84b45eaedc6f
2022-05-27 15:11:16 -07:00
HaraldSchafer f5a6a6dc77 Tssp prius torque control (#24669)
* use llk

* use steering sensor at low speed stil

* Try more simple

* rm prius tune

* updated ref
old-commit-hash: d708a134bdff9db5cc65491dd9129a709e30ad34
2022-05-27 10:21:02 -07:00
HaraldSchafer 39886246c9 Rerevert torque control (#24649)
* Revert "Revert torque control (#24565)"

This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.

* Move tune out of car specific stuff

* Update ref commit
old-commit-hash: d9289721503976cd99ac90216c502a841988c1a6
2022-05-24 17:52:33 -07:00
Shane Smiskol 077a70d80d Support RAV4 2022 with stock longitudinal (#24367)
* support for ICE 2022 RAV4

* add to releases

* swap

* add fingerprints from a5c341bb250ca2f0

* update test route

* update docs

* add test for rav4

* values.py is a comma file
old-commit-hash: bdaf17415422ce16a1b2c412a89e099e552135a9
2022-05-18 19:04:11 -07:00
HaraldSchafer efa559f9be Revert torque control (#24565)
* torque reversal start

* Fix carmodel tests

* Update ref

* update ref

* Elif is better than if
old-commit-hash: 9f8b03753dbdb131fac7bdc021e841cb30b3bf2c
2022-05-17 19:00:57 -07:00
cydia2020 e6f1d751b9 Toyota: correct weight for the Prius V (#24499)
* correct weight for the Prius V 

https://www.toyotacertified.com/content/dam/tcuv/sections/brochures/en/prius-v/2017_priusv_ebrochure.pdf

* Remove comment

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Extra whitespace

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3f5afa158a96a0855b37c1a4f55a99949fe20444
2022-05-11 21:02:47 -07:00
Shane Smiskol 70c8bc4cd3 Camry TSS2: use torque controller (#24268)
* use measurements from harald

* update from table

* average of hybrid and non-hybrid
old-commit-hash: 191fbd4f67e7f878b518effd14411779b9435339
2022-05-07 21:34:17 -07:00
HaraldSchafer a5ed9358a5 Latcontrol torque: update tuning (#24357)
* Little more chill

* Update ref

* Update refs
old-commit-hash: 8cdeaf9aee158bf11869132f82863bec4489e4f9
2022-05-02 14:42:18 -07:00
Shane Smiskol 754b93997a Support RAV4 Hybrid 2022 with stock longitudinal (#23969)
* add panda flag for toyota stock long with camera

* clean up

* Add 2022 RAV4 Hybrid from Philly

* fix wrong fw in interface, did this ever work?

* Must be a hybrid

* no radar parsing

* fix can error

* move to own platform

* generate docs

* fix

* Add 2022 Rav4 XSE Australia fingerprint parameters (#24303)

* Update values.py

Add 2022 Rav4 XSE Australia

* add commas

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* bump panda

* wait, the camera doesn't even send 0x343, right?

* use a set instead, more obvious

* don't test without a parser

* bump panda

* flip panda flag

* bump panda

* add commas

* regen and update refs

* set to none by default

* revert parenthesis

* update comment

* bump panda

* regen and update refs

* add test models and update readme

* bump to master

Co-authored-by: BrettLynch123 <34538435+BrettLynch123@users.noreply.github.com>
old-commit-hash: c1caca104f8553d485334e33446bd7b8ec1fb8ca
2022-04-28 22:37:46 -07:00
Adeeb Shihadeh 211fc8fc68 Toyota: add safety param flag for alt brake message (#24341)
* Toyota: add safety param flag for alt brake message

* update refs

* update refs

* bump panda
old-commit-hash: 3e098c9ba5fd8f6958f38dc500c357db34e83ffe
2022-04-27 12:08:11 -07:00
HaraldSchafer ef41004968 Latcontrol torque: max_torque rename (#24265)
old-commit-hash: 506650bab66ae1d28f76526ffcb73470b755c170
2022-04-20 11:26:24 -07:00
HaraldSchafer 2174005f05 Lateral torque-based control with roll on TSS2 corolla and TSSP rav4 (#24260)
* Initial commit

* Fix bugs

* Need more torque rate

* Cleanup cray cray control

* Write nicely

* Chiiil

* Not relevant for cray cray control

* Do some logging

* Seems like it has more torque than I thought

* Bit more feedforward

* Tune change

* Retune

* Retune

* Little more chill

* Add coroll

* Add corolla

* Give craycray a good name

* Update to proper logging

* D to the PI

* Should be in radians

* Add d

* Start oscillations

* Add D term

* Only change torque rate limits for new tune

* Add d logging

* Should be enough

* Wrong sign in D

* Downtune a little

* Needed to prevent faults

* Add lqr rav4 to tune

* Try derivative again

* Data based retune

* Data based retune

* add friction compensation

* Doesnt need too much P with friction comp

* remove lqr

* Remove kd

* Fix tests

* fix tests

* Too much error

* Get roll induced error under 1cm/deg

* Too much jitter

* Do roll comp

* Add ki

* Final update

* Update refs

* Cleanup latcontrol_torque a little more
old-commit-hash: fe0bcdaef6b1fd3fc9d855aefeba755b35dfc222
2022-04-19 19:34:31 -07:00
Adeeb Shihadeh 3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814e07c1243ef2b979957760d64c9eb35
2022-04-12 22:58:34 -07:00
Shane Smiskol 8a88db322e Support Toyota Alphard Hybrid 2021 (#24003)
* add 2021 Alphard Hybrid

revert

* fix fp name

* run docs generator

* Add to releases

* test route

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 15368ec3d1cb41a71856fb8e3f2b89320b087053
2022-03-20 16:40:25 -07:00
Shane Smiskol ce4fd26e58 Toyota: Support Avalon Hybrid 2022 (TSS2.5) (#23892)
* Add Avalon Hybrid 2022

* update docs

* set a tune

* add test route

* uploaded route
old-commit-hash: 247b66f4a801d3621575edf5a247c54e275d2826
2022-03-19 13:14:04 -07:00
Shane Smiskol 2f0f77a4f7 Toyota: clean up CarInterface apply function (#23714)
* clean up CarController with intermediate variables only accessed once or twice

* format

* fixes and move frame to CarController
old-commit-hash: facf6c109d00be7fb15aa5ba35cc3df4b8046ce8
2022-03-16 20:06:17 -07:00
Adeeb Shihadeh 3327348aeb don't read params in car interfaces (#23978)
old-commit-hash: bae78dd46b817bea26c6de05322eed5cab0bfba8
2022-03-16 15:17:47 -07:00
Adeeb Shihadeh ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc7b25c9ce502419bcd0261c12ec2b0d
2022-03-13 21:42:39 -07:00
Shane Smiskol 3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a44925080b2c35b6dde35c093cc2e32035
2022-03-13 20:58:44 -07:00
Shane Smiskol b823d94018 2019+ Avalon: allow stop and go (#23952)
* Avalon actually has SNG

* update readme

* Revert "update readme"

This reverts commit 076561a0578bcc626fd6710bc411330ef13334d4.

* update readme

* fix

* variants as it includes hybrids
old-commit-hash: 156337475e51156739dc443ff6d15c9f9960c4bb
2022-03-11 19:45:30 -08:00
Adeeb Shihadeh 30b63dc0d4 Toyota: fix flaky EV detection (#23825)
old-commit-hash: 0965155a5bf93bc5c0f14f437d9bc7d505f32a91
2022-02-22 16:15:09 -08:00
Shane Smiskol 3bcd3e2b81 Toyota: merge Lexus ESH params into similar vehicles (#23673)
* merge LEXUS_ESH

* min and max of all variants
old-commit-hash: 31af75f2e35572dc0592bb87c190c9abb00e1c17
2022-01-31 17:30:48 -08:00
Adeeb Shihadeh 73b4613abf Toyota: merge IS and RC params
old-commit-hash: fe5056ffd8dfb6a8ecb1b008a8c77c2b3b2e7511
2022-01-27 16:20:57 -08:00
【TIM】 64ebc3b4fd Toyota: Prius V fixups (#23640)
* Fine tune Prius-V control parameter

* Adjust DBC file and enable SNG support

*Adjust the DBC file to CT200H, the parameters of this model are closer to PRIUS V
*Add PRIUS V to NO_STOP_TIMER_CAR list to enable SNG support

* Update interface.py

remove spaces

* Update values.py

Mod DBC to toyota_rav4_2017_pt_generated

* Update values.py

The file has been updated to resolve the conflict and can be directly merged

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: eaebf01e581b910763eb23ed3e15af1559e84dc6
2022-01-27 15:33:18 -08:00
Adeeb Shihadeh ed3eef90b1 Toyota: Prius V 2017 support (#23636)
* Add Toyota Prius Alpha support

* Fix opendbc link

* Update interface.py

* v

* revert opendbc

Co-authored-by: CT921 <tim.chen242@gmail.com>
Co-authored-by: 【TIM】 <90225659+CT921@users.noreply.github.com>
old-commit-hash: 2240b802be8f781d52b7c00da54a577612d67330
2022-01-26 22:57:26 -08:00