Jason Wen
0a667d79d0
espActive: IMMEDIATE_DISABLE -> SOFT_DISABLE ( #33003 )
...
* espActive: `IMMEDIATE_DISABLE` -> `SOFT_DISABLE`
* only stock long
* just soft disable for now
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: a654e5bd05811a896005ebb41bc2f15dcf443b5d
2024-07-22 13:09:00 -07:00
Shane Smiskol
a878118b00
Revert "selfdrive/car: ban imports from external modules" ( #32993 )
...
Revert "selfdrive/car: ban imports from external modules (#32973 )"
This reverts commit c1e8ff2dbc47ccb07fb41a4e88bfb66af2669254.
old-commit-hash: 35a4a773f1ff6c7b171b7acdb2fd4a65279edebd
2024-07-15 11:14:04 -07:00
Dean Lee
58df39a2ba
selfdrive/car: ban imports from external modules ( #32973 )
...
* lint import
* Update selfdrive/car/__init__.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 83d4623590f87dcb7df2b458a8814d5ad6ea711b
2024-07-15 11:12:24 -07:00
Jason Wen
ecb9dfecff
Hyundai CAN: Log ABS/ESP Activation to espActive ( #32743 )
...
* Hyundai CAN: Log active ABS to accFaulted
* Add comments
* `espActive` to CarState and CarEvent.EventName
* re-order
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 36eafc0dc6ea73bcc59df216a3231ae54960a282
2024-06-24 20:14:57 -07:00
Dean Lee
eb6e134869
events.py: rename event counters ( #32596 )
...
* improve prev event counters
* just rename
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 983063c3e6ce344b8569814fcdc2eafc2830c4e9
2024-06-06 00:13:57 -07:00
Adeeb Shihadeh
d0f0ee8435
define alert for actuatorsApiUnavailable
...
old-commit-hash: 075176f869088f9e2021aadc9e236edd8cac7d3e
2024-05-18 17:55:52 -07:00
Shane Smiskol
693c53cafc
events: reduce priority of resumeRequired ( #32450 )
...
CC
old-commit-hash: 42861f6683cf80b7ec0a1f05fc821e4cc5327962
2024-05-16 21:17:37 -07:00
Shane Smiskol
f9dc18f418
Events: remove dependency ( #32430 )
...
* Revert "Events: use sorted container (#32395 )"
This reverts commit 3c9c039ca3202649d7212ee259b1b82a65a92c4f.
* remove implicit dependency
old-commit-hash: e9bf36232bf587cacc1282837afbe82600c0977f
2024-05-14 15:19:02 -07:00
Shane Smiskol
4b0149cb14
Events: use sorted container ( #32395 )
...
* use SortedList
* Update ref_commit
old-commit-hash: d98ab4ddb1beebdf7079d403a837aabbf7d86918
2024-05-13 12:16:53 -07:00
Adeeb Shihadeh
a6faeb03ce
adjust gps alert
...
old-commit-hash: 6ef95f7a91b33f7f554c0d41353c7f77fb2eb6b4
2024-05-01 11:35:20 -07:00
ZwX1616
c741dca04c
Toggle to always enable DM ( #32205 )
...
* permanent
* param
* correct behavior
* toggle
* need trans
* ref_commit
* translate for chs/t
* disable on P and R
* read
old-commit-hash: 1d05704d27dbe4f73c0eba7e8dad2ae84d4e205e
2024-04-17 12:56:37 -07:00
Justin Newberry
a5bc36ea9d
move git commands to common/git.py ( #31921 )
...
move git into common/git.py
old-commit-hash: 4fbc8a389662f82018eeabd03294cc761b87ce75
2024-03-19 12:39:09 -07:00
Cameron Clough
9bd90112d0
use pyupgrade to update to new typing syntax ( #31580 )
...
* add pyupgrade hook
* run pyupgrade (pre-commit run -a)
* ruff --fix
* Revert "add pyupgrade hook"
This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.
* revert changes to third_party/
* manual type fixes
* explicit Optional wrapping capnp objects
old-commit-hash: 995250ae4967943ee33a3699a1d89a7a770d95e9
2024-02-24 16:41:23 -08:00
goodchoom
a1ff0696ce
Alerts: fix inconsistent capitalization ( #31514 )
...
fix capitalization
old-commit-hash: 8b5c9e84d2f5ae35925a9187abacd4543c046a8f
2024-02-19 18:18:20 -08:00
Greg Hogan
14e12980f5
simplify git remote is comma check ( #31284 )
...
* simplify git remote is comma check
* cast to str
* eliminate default and always return string
* add type annotation for cache decorator
* fix up default handling
old-commit-hash: 7affba06d89b366d98f42c4ea3a2f904e6ef3357
2024-02-02 21:23:32 -08:00
Harald Schäfer
66dbadb029
Delete lat planner ( #31089 )
...
* Initial commit
* Fixup
* typo
* ignore lateral plan
* Update cereal
* Remove lateralPlan
* Fix release build
* Fix release build
* give car params
* Add carParams to include_all_types
* Write car param in powerdraw test
* add demo mode
* Update model regf
* proc replay ref commit
* Try
* Move enum definition
* Update cereal
* typo
* Write car param for modeld test
* Update ref
* Update model ref again
---------
Co-authored-by: Kacper Rączy <gfw.kra@gmail.com >
old-commit-hash: e6c97c384671b448f307a7ed91416886f2186d80
2024-01-21 12:09:48 -08:00
Shane Smiskol
962c20f9be
events: fixup printing script ( #30268 )
...
* fix typing, no need for ordereddict, show priority name again
* just repr
old-commit-hash: ffeb99db54c5ff7c7c5cce82e87e15a766484ec9
2023-10-17 01:52:20 -07:00
Adeeb Shihadeh
9c8de3e08b
simplify sensor alert ( #29824 )
...
* simplify
* update proc replay
old-commit-hash: a4aa801fbe924ace2ebd493eeac7eb0c596f81b5
2023-09-26 16:47:21 -07:00
Shane Smiskol
13381ed446
services: capitalize constant service list ( #30005 )
...
* rename
* bump
* Apply suggestions from code review
old-commit-hash: 7f073483bb2586053d6c5508ef3f420947941d90
2023-09-21 18:25:15 -07:00
Vivek Aithal
56f4c138cd
Alerts: More understandable locationd, paramsd alerts ( #29831 )
...
* add locationd paramsd alerts
* remove more additions, just renames
* update refs
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* resolve comemnts
* update cereal
* update refs
* remove nosensor in new alerts
* bump cereal
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 00d1c682b0a6e62652dbfe4686c674539fe82d8f
2023-09-11 16:28:42 -07:00
Vivek Aithal
43ce3d16df
locationd: Add camera-IMU cross-checks ( #29727 )
...
* camera-gyro cross checks, but one way
* increase factor to account for gyro noise (potholes, bad roads etc
* increase factor to reduce FP with device taps, bad roads, etc
* factor to 30
* add inputsok to sensoir data invalid alert
* bugfix
* move the sensors check
* add localizer catchall alert
* update refcommit
* remove permanent alert
* revert sensorDataInvalid alert change, split into new PR
old-commit-hash: dbada885acf6418edbf6d781dc79fb85dfa74117
2023-09-06 21:01:01 -07:00
Justin Newberry
3b91610c0b
Precommit: ensure executable bit is set ( #29784 )
...
* precommit ensure executable
* exclude tinygrad
* bump submodules
* exclude tinygrad globally
old-commit-hash: 4e69937d0d3fbdc7d1d42cbc18d7ccf8ddb115f1
2023-09-05 16:33:26 -07:00
Adeeb Shihadeh
16ec56398c
add openpilot prefix to imports ( #29498 )
...
* add openpilot prefix to imports
* more
* more
* fix docs
* fix linter
* bump submodules
* fix patched tests
* update dynamic imports
* debug
* Revert "debug"
This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.
* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Eric Brown
1f6a7d4796
Swap belowSteerSpeed and resumeRequired alert priorities ( #28795 )
...
* GM: Don't send belowSteerSpeed when resumeRequired
* Set belowSteerSpeed alert to LOW priority, resumeRequired to MID
* Add script to output all events and their priorities by type
* Set CP, CS, sm
* Subscribe to same messages as controlsd
* Create callable alerts
* Remove event print script
* Remove sng check
old-commit-hash: 111b6438c6a27a4fc3992606321c2282a04ed6cb
2023-08-17 16:03:35 -07:00
Justin Newberry
715f028a0e
Ruff: enable flake8-builtins ( #29315 )
...
* enable flake8-builtins
* replace any with contains
* fix typo in pack
* fix type
* format is from the parent module, has to be enabled
* item_id
* fix item_id
* disable for id since that's what the remote server returns
old-commit-hash: 8793cbff40662a92bff16d75b51479c80517305a
2023-08-10 18:58:22 -07:00
Justin Newberry
3ee0786de3
CI: Pylint to ruff ( #29294 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
* set line length
* pylint exclusions to ruff
* same excludes as old linter
* fix tools QA
* remove unrequired check
* revert linting third_party
* ignore e402
old-commit-hash: 7fdd9fc37c1c5febf1cd3dc86441ebf0dec7f370
2023-08-09 13:26:54 -07:00
Justin Newberry
ff96892511
Revert "CI: pylint to ruff ( #29276 )" ( #29284 )
...
This reverts commit ffad7279cbad3c4f2ea786287b4624d3a3aa18d7.
old-commit-hash: a91764954b0c9bfe5ccfc8e64321af6bb6c56536
2023-08-08 14:24:04 -07:00
Justin Newberry
99006365a3
CI: pylint to ruff ( #29276 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
old-commit-hash: cb31a53d8a93cf6cb1f8bd2fff1431716b3a47e4
2023-08-08 13:41:30 -07:00
Adeeb Shihadeh
8bcaf1f942
increase min duration of steer saturated alert ( #29191 )
...
* increase min duration of steer saturated alert
* update refs
old-commit-hash: 347620556946eb365dc61363079655ae5a4a891d
2023-07-31 12:48:11 -07:00
Eric Brown
3ebff5c415
Events: debug script ( #28898 )
...
* Move to separate branch
* Fix mypy
* Better printout
* Fix spacing
* cleanup
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 22c413af6de56450cad3db4a978527549a924eaa
2023-07-16 16:59:27 -07:00
Adeeb Shihadeh
27b53b914b
reduce startup alert duration ( #28749 )
...
* reduce startup alert duration
* update refs
old-commit-hash: 336b5f732490b0f9ad5b3276a22c1629934e25c0
2023-06-29 17:57:25 -07:00
Shane Smiskol
8bb530cec5
Deprecate brakeUnavailable event ( #28351 )
...
* bump cereal
* deprecate
* Update selfdrive/controls/lib/events.py
old-commit-hash: fc2bd16e72a89feb270f99468cfd8d14ccbab4fd
2023-05-31 16:29:11 -07:00
Harald Schäfer
5ddceb553d
Calibrationd: make recalibrating alert ( #28149 )
...
* Initial
* fixes
* not an int anymore
* elif
* revert ref
* update ref
* fix alert text
* regen refs
* update ref
* add recalibration unit test
* set into recalibration state
* fix words
* recalib
* text
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 598343aad18a7896c6b65ff6e19f9e27ba19cc10
2023-05-15 09:29:57 -07:00
Shane Smiskol
298e7466f5
Ford: hybrids are unsupported ( #28171 )
...
* hybrid fords are dashcammed
* something like this?
* just do an alert
* good comment
* space
* bb
bb
* top
* Update selfdrive/car/ford/interface.py
* add a noEntry
* remove from release notes
* sad :(
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com >
old-commit-hash: 344064d6bd45b6d0f54e1eedfc73b87a856efe3e
2023-05-11 23:35:07 -07:00
Shane Smiskol
da12bfb021
Ford: add alert for steering wheel angle not ready ( #28140 )
...
* add event for steering angle calibrating
* how about this
how about this
* rename
* more openpilot-y
* add comment to code
* move to top
* better wording
* more general
* fix
* ?
* above
* bump cereal to master
* add more comms
old-commit-hash: fb29d0f3bfe69c83f73e3af09235bd4c8287aaac
2023-05-08 22:03:30 -07:00
Harald Schäfer
73e00a05ac
Calibration remount detector: soft disable ( #27993 )
...
* Calibration remount detector: soft disable
* Update test_calibrationd.py
old-commit-hash: a979a54cf9ce02610cc0999a52a9fbed2f7d4cbb
2023-04-22 00:27:20 +00:00
Jason Young
6433154d5d
remove accFaultedTemp, add steerTimeLimit ( #27720 )
...
* remove accFaultedTemp
* retry CI
* bump cereal
* grab the new steerTimeLimit Event
* bump cereal to updated master
old-commit-hash: 267974e00200324805c76ef2e8ae279efa7757a1
2023-03-28 16:04:14 -07:00
Adeeb Shihadeh
70cfe29351
better main off alert ( #27442 )
...
old-commit-hash: 7a3b3e8b567ea476088e6f3d7344c7220e35e398
2023-02-23 15:01:10 -08:00
Adeeb Shihadeh
0a1ee30b15
add 'remount device' to permanent calibration invalid alert ( #27407 )
...
old-commit-hash: ea419c5764739555673d5545f16cff7c05f9e6c0
2023-02-20 16:29:17 -08:00
Adeeb Shihadeh
37a1a0bc2c
better min enable speed alert ( #27317 )
...
old-commit-hash: 5af5f02ba82a0094c7f721ad8dd6138f503455d8
2023-02-14 13:29:23 -08:00
Shane Smiskol
47197d7009
events: reword ESP off alert ( #27304 )
...
* Rename event
* rename to Control
* rename to disabled
old-commit-hash: 4f2134468f2b2b94daa24d9ba80cc70da0ad8224
2023-02-10 23:46:48 -08:00
Shane Smiskol
bbed3a961a
Events: actionable accFaulted alert text ( #26783 )
...
same alert text as steer and brake unavailable
old-commit-hash: 9e9600a4f4fb69dd99cc24b791ccdd62540348f1
2022-12-13 00:16:36 -08:00
Shane Smiskol
e13e373bfb
alert: smaller standstill alert ( #26751 )
...
smaller standstill alert
old-commit-hash: 2545dd195efc164da9561ae9ae2115482eb9f931
2022-12-09 23:30:41 -08:00
Shane Smiskol
634a6c9802
Deprecate noTarget event ( #26638 )
...
deprecate notarget
old-commit-hash: 5409895ab2668284df7b688ce513fa0ef1e57be2
2022-11-30 02:32:47 -08:00
Shane Smiskol
d1dee4625a
controlsd: preEnable on brake at a standstill ( #26273 )
...
* pre-enable on brake at standstill
* test by getting rid of noTarget
* Update events.py
* rename
* stash what we got so far
* cmt
* not sure if best way to fix, but enabled with current states defs is fine
* no noEntry in preEnabled
* bumpcereal
* uncomment
* Update ref_commit
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: dbe512d167a51f02fe276e17a8794de2137d0e14
2022-11-29 17:34:10 -08:00
Shane Smiskol
bcdbd8edb9
Toyota: alert when in standstill ( #26585 )
...
* add resume required alert
* possibly need this (pressing resume with brake held does nothing)
* better text (has both meanings)
* try this
* Revert "try this"
This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.
* no alert with interceptor
* check long
old-commit-hash: 3253b8590002fa5f56e003add3f5f47a21870873
2022-11-25 16:00:58 -08:00
Adeeb Shihadeh
7c96e7876a
cleanup panda types everywhere ( #26574 )
...
* cleanup panda types everywhere
* one more
old-commit-hash: 65fa87a96965000986e76604ac868891e35a86bc
2022-11-21 23:43:24 -08:00
Shane Smiskol
054cb1f8c1
Hyundai: fix button enable controls mismatch ( #26471 )
...
* bump panda
* buttonCancel needs to be a noEntry
* bompo
* Update ref_commit
old-commit-hash: 89b88fc7a23c393b1d74c5c74aacd5c4ee254d81
2022-11-11 14:49:38 -08:00
Shane Smiskol
70249fae14
Rename gmAccFaultedTemp -> accFaultedTemp
...
old-commit-hash: b1efdab788da77380dfd3f5765bb6cc03ccc3a77
2022-10-19 01:31:12 -07:00
Shane Smiskol
961c613005
GM camera ACC: prevent fault when engaging at a stop ( #26079 )
...
* prevent bolt fault
* comment
* only for camera ACC
* fixup alert
* bump cereal to master
* use new name
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* only care about prevent engagement when we look at PCM
old-commit-hash: 4e82f68de2641e628f0df1aa82e5a5e935c8cce6
2022-10-14 22:21:53 -07:00