Commit Graph

265 Commits

Author SHA1 Message Date
Adeeb Shihadeh c319dfd924 controlsd: no cruise speed while main off (#24052)
* controlsd: no cruise speed while main off

* probably more accurate

* update refs
old-commit-hash: 49498aa7b5c7e5aed7a6ea767a0a9f10cb7dfdc7
2022-03-27 18:06:28 -07:00
Shane Smiskol 4bbc197433 update unsafeMode to alternativeExperience (#23995)
* update unsafeMode to alternativeExperience

* fix

* fix

* bump submodules

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: e91613bc625dfac43e9d3c4135dec8a1757ade37
2022-03-24 14:59:16 -07:00
HaraldSchafer 45b028e39a Add angular rates carcontroller packet (#23980)
* Controlsd: give carcontroller angular rates

* Update cereal

* Needs to be list

* Update refs
old-commit-hash: dcece099fff5def6c6d8feea6883ab0e0ee5b661
2022-03-16 21:12:11 -07:00
Shane Smiskol ca394949cc Move gas/brake pedal event logic to controlsd (#23850)
* move some state machine logic to controlsd

move some state machine logic to controlsd

* same order

same order

* move unsafeMode up

* disable at standstill

* save last CS

save last CS

* do we need to copy at all?

* don't copy

* rename

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Revert "Update selfdrive/controls/controlsd.py"

This reverts commit 10bb51a0f0ee0d8e2a27c746a0638280a5eaea8a.

* Update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 5fe00fb7738358c19b7db907047353d8785b5f20
2022-03-15 20:51:07 -07:00
Adeeb Shihadeh ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc7b25c9ce502419bcd0261c12ec2b0d
2022-03-13 21:42:39 -07:00
Shane Smiskol 3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a44925080b2c35b6dde35c093cc2e32035
2022-03-13 20:58:44 -07:00
Willem Melching debaf85830 lower model FCW + stock longitudinal threshold to -1.25m/s^2 (#23915)
old-commit-hash: 37a8b09cad8a1040bb6f426e04c76da3d5364f98
2022-03-07 10:42:07 +01:00
Shane Smiskol 6303d97278 controlsd: fix vCruise jumping on pcmCruise cars (#23388)
* clean up v_cruise_kph

fix

fix

* Revert "clean up v_cruise_kph"

This reverts commit 211b5c3dbe073414ef5c39b19d6d2c6e8de2cf0b.

* always update vCruise and don't init if pcmCruise

* revert change

* update refs
old-commit-hash: 274885fc4d6b1bffafa2b78e628f4fb3005ed52e
2022-03-03 05:23:14 -08:00
Adeeb Shihadeh 63bbcd7279 better steer fault names (#23890)
* better steer fault names

* bump cereal
old-commit-hash: 87849f93b165507ad980dbefdcf9c376d5165a18
2022-03-01 22:53:55 -08:00
Shane Smiskol 1f5570a96d Longitudinal control: interpolate longitudinal plan (#23787)
* interpolate longitudinal actuator delay

rename

* formatting

* interpolate v_target most importantly!

* fix interpolation and rename

* nicer setup

* left in from testing

* update refs
old-commit-hash: 2c7845fce0be2bfa72a5d2429daa35fb735c154c
2022-02-18 00:45:00 -08:00
Adeeb Shihadeh 97ea3c8ff2 controlsd: only add startup event until initialized (#23671)
* controlsd: only add startup event until initialized

* update refs

* update again
old-commit-hash: 602f92fc0e337ee5143dd2691f20fead68365b64
2022-01-30 20:38:05 -08:00
Shane Smiskol beeb0442ce base LatControl class (#21967)
* base LatControl class, move sat check out of pid.py

clean up

clean up

* fix

* global variable for min control speed

* nicer name

* unify latcontrol class init arguments

* add to release files

* saturated if close to limit

* move angle mode saturation checks into class

* check_saturation function takes in current saturated status

undo

* apply latcontrol_angle's active checking to all controllers

* clean up

* move those back

* make abstract baseclass

* add test for saturation

* keep clip

* update ref

* fix static analysis

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9de8f8cd8c384596868edf3307da51819b28bb4b
2022-01-26 17:10:41 +01:00
Shane Smiskol 183715ccea controlsd: verify unsafe mode consistency (#23563)
* add unsafe mode check to controlsd

bump submodules

forgot to add to health_t struct

bump

ahh forgot to set it!

bump

bump

clean up

clean up

bump

* fix ordering

* move to end

* unsigned

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 31d147dca2ada336d14c08ae35f5af510c309730
2022-01-25 12:09:13 +01:00
Adeeb Shihadeh d07d22c9b9 controlsd: remove redundant condition
old-commit-hash: e50efd7671e8c6a69f50eab794d33fa0c27b5196
2022-01-24 21:28:30 -08:00
Adeeb Shihadeh 70f1418256 remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
old-commit-hash: 3e9cb7fa12b5f686fdcf6122ef5979d01c41f0a3
2022-01-24 14:49:47 -08:00
Willem Melching 962201fff1 Ensure controlsd can engage again in process replay (#23556)
* hacks to make process replay engage again

* dont change that

* enable engagement check again

* chmod +x

* first working regen

* proper logMonoTime

* fix video framerate consistency

* mpc is valid again

* proper alive checks

* revert loggerd change

* ensure engaged in regen, fix managerState, peripheralState

* ubloxRaw is unused

* add submaster config for gm

* regen all services we can run without HW

* fix loggerd

* loggerd: matroska without the extension

* update ref
old-commit-hash: d3d10e014a69f77d3f67c8d01100b03fde8ab034
2022-01-21 13:13:34 +01:00
Adeeb Shihadeh c2a23fa24c clear no entry alerts if engaged (#23559)
* clear no entry alerts if engaged

* fix test
old-commit-hash: 59894a66669f72dd65acf8f7556c43007d1af68e
2022-01-17 13:57:53 -08:00
Dean Lee d0bfd37a95 controlsd: remove extra space (#23553)
old-commit-hash: 5cd103c3d4422d5456be26da0d869787fc49d61f
2022-01-17 13:51:44 +01:00
Adeeb Shihadeh 2013e086ba shutdownd is non essential
old-commit-hash: c6b892fe58b338987d02712d44f828b47bc72cb1
2022-01-14 11:59:04 -08:00
Dean Lee a1d3ab2ea1 controlsd: cleanup parsing android log (#23421)
* cleanup parse android log

* global CSID_MAP

* use generator express

* cleanup

* no walrus

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fd042a5924789e3b745b651d44a90013c0bbacc7
2022-01-13 19:43:22 -08:00
Dean Lee 7f9069cb34 controlsd: check self.enabled out of the any() (#23507)
old-commit-hash: 48b6dfa15de1bf8157288ea06114ab5418f2650c
2022-01-13 11:53:04 +01:00
Dean Lee 54bdb321bd cleanup iterate keys in dictionaries (#23497)
old-commit-hash: a186bcc9f16c08f405dda92b8ac9e8a80895cdc7
2022-01-12 12:42:50 +01:00
Robbe Derks 54a4dece4d Ignore statsd for running process check (#23483)
old-commit-hash: 1a54d7f6aee817cc3217041bc085f9b83faafce0
2022-01-10 19:54:41 +01:00
Dean Lee 61a28b2fb7 controlsd: check all_valid only if not initialized (#23437)
* check all valid in if statement

* apply review
old-commit-hash: 67af0956923558059d1feea9a9e263d37d09e865
2022-01-10 12:13:58 +01:00
Dean Lee df63cf059a controlsd: save lat_plan.dPathPoints to local variable (#23462)
old-commit-hash: 2d08f8b318641ee4e6d53ca736358c7a2d533b5d
2022-01-10 11:27:31 +01:00
Dean Lee 7276bf8197 controls: check contents in tuple instead of list (#23463)
old-commit-hash: b2beb5e6ba6eda6354e93649a5b5829c9c4537bc
2022-01-10 11:26:58 +01:00
Dean Lee 296925cd6a optimize alertmanager (#23433)
old-commit-hash: 09a835916b0c10175c5658a92cf5ca23a337cb19
2022-01-06 22:15:32 -08:00
Dean Lee 60a22bbc0c controlsd/state_transition: remove redundant check in elif (#23428)
old-commit-hash: e0338fd77b98073673f48213336965349e7194a9
2022-01-06 15:54:19 +01:00
Dean Lee 0a03f65b2b controlsd: remove duplicate event relayMalfunction (#23392)
old-commit-hash: 0357cf2af0bc7449e7aefff5b0f0881f1ae2adb3
2022-01-04 14:07:36 -08:00
Dean Lee ea519c31e4 controlsd/publish_logs: follow capnp best practices (#23372)
* follow follow capnp best practices

* cleanup
old-commit-hash: 960e0cf6a70638e5235f569da9391638eb94b513
2022-01-04 12:04:03 +01:00
Adeeb Shihadeh 98c8147ec3 CAN receive error is a comm issue (#23362)
old-commit-hash: 1e41f4723b539c9c76c1ae0c16f7a0a42cfe5deb
2022-01-03 14:13:45 -08:00
Ewout ter Hoeven f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
HaraldSchafer f64c2974b4 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
old-commit-hash: cf466222f623df5fac325b86b71dc4e181b40d55
2021-12-16 17:34:12 -08:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 83136e8016 increase cruise mismatch threshold
old-commit-hash: 7f618b16bfa47352143d6edac30fba05f9fdfc28
2021-12-12 13:35:12 -08:00
Adeeb Shihadeh 06a9b3448d alerts: escalate soft disable alert near disengagement (#23198)
* alerts: escalate soft disable alert if resulted in disengagement

* show 0.5s before disengagement
old-commit-hash: 8068df0b2a35eb8fcef809f4ce9a6cb7bfc75fdc
2021-12-11 17:07:37 -08:00
Adeeb Shihadeh 700ad9ec50 alerts: handle min duration properly (#23191)
* alerts: handle min duration properly

* add active

* tests

* cleanup test

* update refs
old-commit-hash: 07b971d4735d891cc59f404095812f5d001b3092
2021-12-10 19:20:07 -08:00
HaraldSchafer 9c03362ba8 Less sensitive torque saturated warning (#23003)
* Less sensetive torque saturated warning

* better comment
old-commit-hash: 8f3bc4872f19b84203608b2561924cd85e0d1788
2021-12-01 13:53:42 -08:00
Adeeb Shihadeh 2bcaee3678 add offroad alerts for car unrecognized (#22934)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: 2a72e2a5140a7b02c3a13f167e91b4238a01eba0
2021-11-17 20:29:00 -08:00
Adeeb Shihadeh 8a66c54064 Revert "add offroad alerts for car unrecognized"
This reverts commit 2ffaadb4d2eaabf6e8d86423fbc25328e81dfff0.

old-commit-hash: d8a5c415cd73b50a3424a28f644466fee263e09c
2021-11-16 13:31:10 -08:00
Adeeb Shihadeh 08bfdb151b add offroad alerts for car unrecognized
old-commit-hash: fb1e8ce086ec5e2dc7b2150b62fdd99368eb7e66
2021-11-16 13:30:33 -08:00
Adeeb Shihadeh d1eacc4619 alerts: make soft disables an orange alert (#22925)
old-commit-hash: 833399e9418db26df70169d37c2dff90051d89c7
2021-11-16 13:11:32 -08:00
Adeeb Shihadeh a1ab2f7c36 CI: skip cruise mismatch check for can replays
old-commit-hash: db92006dc0b964871c65ca9be88ebdb3b67137ec
2021-11-12 18:22:39 -08:00
HaraldSchafer d17ec32e0b Give car interface roll and pitch (#22891)
* Give car interface roll and pitch

* fixup

* whitespace
old-commit-hash: a04114f68c118caae5d9b3e19e70e885e87544ff
2021-11-12 12:21:22 -08:00
Adeeb Shihadeh d6c42f11f4 controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
old-commit-hash: 035bc0c20fd27490cc353a33f3c373201288a10a
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh 421a5db493 controls: don't wind up while EPS is faulted or below min steer speed (#22739)
* controlsd: don't wind up while EPS is faulted

* also check if above min steer speed

* car params
old-commit-hash: 385f3c5387cceb8e23c2d57752f81a2e919104aa
2021-10-29 14:13:41 -07:00
Robbe Derks dbe4641e04 Multipanda support (#22402)
* squash all PR commits for easy rebase

* merged all panda rx can into one message

* fix buffers in can_send

* more cleanup and minor fixes

* fix even more stuff

* fix non-allocated send buffer

* make connecting more robust

* fix bus offset

* fix controls_mismatch?

* simplify mismatch check

* C++ style struct

* fix connect loop

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 585c16cd2aba6e2504c2427aaf1855b97035eb41
2021-10-29 13:04:26 +02:00
Adeeb Shihadeh 05aa510c25 always show lane lines on HUD (#22693)
* always show lane lines on HUD

* update refs
old-commit-hash: f2b48a1803eed1512962ee80e0f4c9718f40d44b
2021-10-25 23:47:12 -07:00
Adeeb Shihadeh 300294d0c6 temporarily disable per-core cpu usage check
old-commit-hash: 7394956a9056ef313b3bffb2a1aa93ae9ba97856
2021-10-25 15:03:28 -07:00
Mitchell Goff 3e3b875111 Only trigger model FCW on stock long when not already braking (#22620)
* Only trigger model FCW on stock long when not already braking

* Split model_fcw checks for better readability
old-commit-hash: 38f775edfc12736f590885705c3a92a785d531f8
2021-10-20 16:16:40 +02:00