Commit Graph

178 Commits

Author SHA1 Message Date
Adeeb ea0292d86e Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
old-commit-hash: d4858e5ff5753f8a800f3e90cb4c0f69213b87f3
2020-06-09 13:25:15 -07:00
Willem Melching d0f60029cb Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
old-commit-hash: 15dc6044d44e7f85293cb9b0187c7d2a51a84c55
2020-06-05 16:01:53 -07:00
Jason Young ebed52527b Reduce scheduler latency for realtime processes (#1638)
* WIP: reduce boardd and other lags

* Copypasta fault

* Silence spurious startup warning

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 68531b071cde6fa5856d9b68bed63ecb50e03c2a
2020-06-05 17:09:41 -04:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Jafar Al-Gharaibeh bbe43de357 Fix rounding of minSteerSpeed in events (#1620)
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring

Python3 interpreter:
>>> print(" %d  %d" % (1.6,1.4))
 1  1
>>> print(" %d  %d" % (round(1.6),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),int(round(1.4))))
 2  1

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 73db0791997efa270f6793b7acb422aedc22d21f
2020-06-03 14:01:32 -07:00
Willem Melching dbdbef72d6 vehicle model types (#1631)
old-commit-hash: 240041708450d916bb49ee229ee4cff0e5f5ab59
2020-06-03 13:47:47 -07:00
Willem Melching db4a918c2a Bounds checks on liveParameters for testing on desk
old-commit-hash: 0f20ac728f4558ee8a849646f366d816a2479b62
2020-06-03 11:31:12 -07:00
Adeeb 8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching a749ebb1c4 speedTooHigh should not be an immediate disable
old-commit-hash: 205cb04ee95f51c0d96f20d71564ef6d1c530d85
2020-06-01 15:53:41 -07:00
Willem Melching 3e630fce60 Make driverview not pin two cores at 100%
old-commit-hash: fab8425f2f5277f3e767e29f01942448674428b0
2020-06-01 13:58:54 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Willem Melching 168ac65d9e White panda no longer supported
old-commit-hash: 106cddb49a3c60449a0413ff28dbbe50479c43bf
2020-05-31 13:33:56 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Adeeb Shihadeh 2feaebfc80 break canError into two separate events
old-commit-hash: 916448af25d61a9acf1d35356fafccdfc800c440
2020-05-29 12:00:41 -07:00
Adeeb Shihadeh 5ab1d48f90 Fix below steer speed alert text not updating
old-commit-hash: 7961d5ffd71328f4e104c01244cc6e08152d76fa
2020-05-28 20:39:13 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00
HaraldSchafer 3488486258 Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
old-commit-hash: 67017d69fe02d9ed6a9cfba54565a403e59afcc4
2020-05-27 14:35:01 -07:00
Adeeb Shihadeh 6f0c5834e7 Fix blank mdMonoTime and controlsStateMonoTime in radard
old-commit-hash: 2ecc7d9f6f85818765da23cfac614d186111abb7
2020-05-26 17:53:55 -07:00
Willem Melching 91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Willem Melching 4061f1d530 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
old-commit-hash: fcf879d783c345ccbf80252de23f649427c35fbd
2020-05-21 16:08:05 -07:00
Willem Melching ce310f3f65 Revert "Add permanent CAN error alert"
This reverts commit 41dfb2a149788a19eb1ee40a3497f2ab35386b74.

old-commit-hash: e6f24f239041da4dc0d889492f8fbcfda111cd7b
2020-05-21 15:30:16 -07:00
Willem Melching 5e4ada7249 Add permanent CAN error alert
old-commit-hash: 0abf99dbe01cfe87617bb293c8eb047d93f709dd
2020-05-21 14:53:40 -07:00
Willem Melching e57247be9d Sounds available isdir -> isfile
old-commit-hash: 41da10ff38abfb29c42e66250344176da14e2f65
2020-05-21 14:46:18 -07:00
Willem Melching 12d3366c55 Add percent sign to calibration screen
old-commit-hash: 517826c1e1263f0445c125a002223906b73538a8
2020-05-21 14:43:07 -07:00
Adeeb Shihadeh 982aacb28d fix possible FileNotFoundError
old-commit-hash: 260e6aff53f5f579298f81e1d3a01a0e1d6dc7fb
2020-05-21 09:59:39 -07:00
Willem Melching b2fb4632cd Fix #1545, sensor alert on startup
old-commit-hash: 9f0eac90895d9fc4cc4ab782d61f31d3b5ab9685
2020-05-20 11:25:55 -07:00
Willem Melching 6e41973c3c Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
old-commit-hash: d099e09fb77544eb00d13ba9aea34a0a3374a52e
2020-05-19 16:45:20 -07:00
eFini 7ec2abcf08 use buttonEvent.type instead of string (#1533)
old-commit-hash: e14dfa3beca9897dafa776fdd68c5076d7a31d4e
2020-05-18 10:15:30 -07:00
Andre Volmensky f6c2c72851 Bugfix: Reset saturated_count if angle no longer saturated (#1522)
old-commit-hash: 135385c5fb47ca1b9efaf3ae9e388b44cd6e538d
2020-05-16 01:14:10 -07:00
Willem Melching 8189186d8e Alert callback functions were returning tuples
old-commit-hash: c18891b936a964493393242020783482e5467ac5
2020-05-15 18:29:22 -07:00
Willem Melching a6676b8a62 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
old-commit-hash: c85b174584b1281ce1f1d168b0b0610d5d540896
2020-05-15 13:00:00 -07:00
Willem Melching 380d1e4f3d Fix two event names
old-commit-hash: 631d0d94d3beb1bd5ac9000b70104847c8c71dac
2020-05-15 12:24:12 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
Willem Melching 39e5985776 Clip v_cruise to V_CRUISE_MAX
old-commit-hash: ef330078130f71f93b3e81e9839c3386fe55946f
2020-05-13 18:05:24 -07:00
Willem Melching 43b696893d speed too high louder alert
old-commit-hash: e7ec02e2011721a819d0bafe0245bc017ef89f4a
2020-05-13 18:02:09 -07:00
Willem Melching ef6640c7c4 Fix controlsd typo in refactor
old-commit-hash: 516fa29738738b73b863597c4fae49cf688b7154
2020-05-12 18:58:18 -07:00
Adeeb fe106e25a3 Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
old-commit-hash: 08832ff29d20348ebffd0ac3bcce29ad3a479cee
2020-05-12 15:06:48 -07:00
Adeeb Shihadeh bd980f6048 delete unused lines
old-commit-hash: 10ae22a19247042b825f1bcac740f70f58b4e197
2020-05-10 11:25:42 -07:00
Adeeb Shihadeh 0a5273bf46 fix circular import reported by LGTM
old-commit-hash: 48dec51f0e93dd1a46b24414afc8ebac27269188
2020-05-09 16:47:36 -07:00
HaraldSchafer f3747d2fe5 Better poly (#1437)
- better polyfitting
- no mpc cost change during lane change
- model trained with better ll gt, sim noise and guaranteed memories
old-commit-hash: 65fcc7c45ff1d4d747dc52ff5791afb84a18744a
2020-05-08 17:14:43 -07:00
Willem Melching 21d7ad1e51 remove yet another reverse geocoder
old-commit-hash: 70ae01e3cdcba25b199e7831d24b70fa699db06d
2020-04-24 14:07:36 -07:00
Willem Melching 9da970c342 no more geofence
old-commit-hash: 267ee4d73b993cccee7098ed791b201fe07a3f1c
2020-04-24 14:06:17 -07:00
Willem Melching cd4c04e290 No more line following robots
old-commit-hash: 42f741d6ffe342b629cdcdf083c4edc77d7f0233
2020-04-24 14:05:19 -07:00
ZwX1616 34eebc37b1 orange distracted alert is now continuous (#1412)
old-commit-hash: 922055f464fbb98ef8366f802897035aa5342333
2020-04-23 14:15:05 -07:00
George Hotz 06407161e6 add safety note
old-commit-hash: 58e71de9fb1d88f08098b00dd333c8a8a2585850
2020-04-20 13:56:02 -07:00