Commit Graph

69 Commits

Author SHA1 Message Date
Willem Melching b772d12f87 Make model packets invalid when frames are too old (#1759)
* make model packets invalid when frames are too old

* add frame numbers to cloudlog
old-commit-hash: 88f92663780665b27fafdb5ab86ad501cad4cbcf
2020-06-22 14:27:58 -07:00
Willem Melching f9cae2aa8f Fix modeld dropping frames if processing takes over 50 ms
old-commit-hash: a8e7a187ca115a5fe5f3a04923dbe50bd00871c7
2020-06-19 16:57:28 -07:00
George Hotz 83f6ec221f c++ify thneed to remove memory leaks (#1737)
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 01a486308d7fbcd661d8f8786c140222703f659a
2020-06-19 15:53:48 -07:00
Dean Lee e04a272892 release resources in modeld (#1700)
old-commit-hash: c8082190a07b6534dffcd7c88945af8b26b241c0
2020-06-19 11:38:39 -07:00
Jason Young 266130770f modeld process time logging to DEBUG (#1720)
Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 80101b350b1f3de13d546bc0a45874e8132de2db
2020-06-16 10:36:04 -07:00
Willem Melching 725c5e742f Modeld: loop over platforms to find CPU/GPU (#1710)
* Modeld: loop over platforms to find gpu

* Remove prints

* PC needs CPU

* Keep default for qcom

* Update error message
old-commit-hash: 4ca8283d739ab31e2fdbd2aeb658cb4f0d2e1bcc
2020-06-15 15:58:12 -07:00
George Hotz 5d069eb8c3 Fixups for Mac, and a bunch for PC (#1654)
* fix mac nui

* fix cereal

* builds on mac without warnings

* ui swap shouldn't be instant on pc

* camerad builds on mac

* modeld, and now everything, builds on mac

* ui draws pictures on mac now

* fix camerad shutdown

* support ui looping on pc

* python3 on that

* SCNu64 should be cross platform

* bump cereal and new apk

* clean up

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 344a9a369983f58fe1e71f84478ded5c766e0d1b
2020-06-11 18:21:59 -07:00
Jason Young fae70a4d99 Update realtime priority for modeld/dmonitoringd (#1675)
old-commit-hash: ec5fc0e92b5f381c5e2c464d3fa65c8db0fc3246
2020-06-10 17:40:22 -04:00
Dean Lee 5fb85ede56 add function read_db_bytes (#1662)
old-commit-hash: 90d97de74ddc4672b35a5186e868794468a44345
2020-06-09 13:46:49 -07:00
George Hotz 4b6c80336b Getting PC openpilot working again (#1650)
* fixup keras_runner to work and be nicer

* truncate the lane lines based on the valid len
old-commit-hash: 7770041f9201c4f84717435b7a585fd70a937923
2020-06-05 17:40:56 -07:00
Dean Lee bbafa5a72d pass DMonitoringResult as referer (#1639)
old-commit-hash: c7ff6dd194b48629dbd05a2cc87afd328fffa3a5
2020-06-05 12:42:01 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
George Hotz 669977eb1f save valid_len
old-commit-hash: 4e7fe3a9ec4fddd517ea470af3b7eb3a6fd415e3
2020-06-03 14:18:42 -07:00
Adeeb d035394ce7 Add pre-commit hooks (#1629)
old-commit-hash: ab83e48ec4f7c7ddaa742d9797b0d38646fdb268
2020-06-03 12:54:49 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Dean Lee dbc8ca1d26 dmonitoring : use memory cache to avoid malloc/free on every frame (#1599)
* use memory cache

* use template function to return buffer

* inline function

* const size_t

* use std::vector instead of kj::array
old-commit-hash: cdb48cc180bd22fbad75785d07a7f47da959880c
2020-06-01 14:00:43 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Dean Lee b72fcb69e2 driving.cc: Pass ModelDataRaw by reference (#1600)
* pass ModelDataRaw by reference

* pass NVGpaint by refer
old-commit-hash: af36aa28abeb55a4445cbc1ff13ac55993d989d9
2020-05-30 10:08:44 -07:00
Willem Melching 2ac27def5a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
old-commit-hash: ba2ac1207a554d277e01af5b9514de4500d4f66a
2020-05-28 15:40:48 -07:00
Willem Melching 91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Dean Lee 9d31c0194f reduce the scope of mutex (#1561)
old-commit-hash: d5858955ee5aa9c8fae7c9f26e7754e86353377a
2020-05-26 09:57:14 -07:00
George Hotz 6a68510918 remove the clCreateProgramWithSource interceptor (#1559)
* remove the clCreateProgramWithSource interceptor

* that's old code, thneed is better

* label them thneed_, we shouldn't need to touch CL for anything not SNPE related
old-commit-hash: b8571710e09e58b9e67170a9924eef79f32c480b
2020-05-24 03:33:36 -07:00
Willem Melching 7f0b3180a4 Use C++ version of SubMaster and PubMaster (#1548)
* add PubMaster & SubMaster

remove 'delete msg'

remove headers

* use constructor to initial all submster

* modify drain sockets

* fix typo in ssconscript.remove lines

no checkValid in loggerd

last modify

handle_message:event->&event

fix type

remove heads

event to auto

* new interface

* api changed

* Revert "use constructor to initial all submster"

This reverts commit 73be7ea46250a325ce41d3a0445e34395a2ae692.

* change to new api

* revert loggerd

* dd

* use new PubSub api

* update to new interface

don't modify loggerd

reset panda

reset opendbc

remove empty lines

* switch to new pubMaster

* update to the new inteface

change

remove error code

. to ->

merge paramsd.cc

update panda

fix typo

simplify

fix typo

* Fix build

* always conflate

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: ab5af232b243ba8137695f68c125f922fb412d44
2020-05-21 16:04:33 -07:00
George Hotz 11628b1f14 add thneed self test (#1535)
* add thneed self test

* don't do the memset in thneed, shouldn't matter though

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 6c0ad1e67567e149cdf9e00ab7ae43f4cc5bc579
2020-05-18 11:34:29 -07:00
Comma Device 16c1926f64 wtf, how was that commented out and the tests still passed
old-commit-hash: 495e0c4648b5c3d20709bb3e08f83dad62725c2d
2020-05-18 17:10:39 +00:00
George Hotz 988361dd92 This isn't bigmodel, but there's a lot of good stuff here (#1532)
* bigmodel

* more debug print

* debugging bigmodel

* remove the tanh, debugging

* print images/buffers

* disassemble the command queues

* decompiler

* dump the shaders

* full disasm

* support patching kernel and fixing convolution_horizontal_reduced_reads_1x1

* microbenchmark

* 42 GFLOPS, 1 GB/s

* gemm benchmark

* 75 GFLOPS vs 42 GFLOPS

* 115 GFLOPS

* oops, never mind

* gemm image is slow

* this is pretty hopeless

* gemm image gets 62 GFLOPS

* this is addictive and still a waste of time

* cleanup cleanup

* that hook was dumb

* tabbing

* more tabbing

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 78a352a8ca8a948e86e7c752732e470f89d92280
2020-05-17 23:13:17 -07:00
George Hotz 206b6abe7d thneed saves 45% of a core (#1512)
* thneed runs the model

* thneed is doing the hooking

* set kernel args

* thneeding the bufferS

* print the images well

* thneeds with better buffers

* includes

* disasm adreno

* parse packets

* disasm works

* disasm better

* more thneeding

* much thneeding

* much more thneeding

* thneed works i think

* thneed is patient

* thneed works

* 7.7%

* gpuobj sync

* yay, it mallocs now

* cleaning it up, Thneed

* sync objs and set power

* thneed needs inputs and outputs

* thneed in modeld

* special modeld runs

* can't thneed the DSP

* test is weird

* thneed modeld uses 6.4% CPU

* add thneed to release

* move to debug

* delete some junk from the pr

* always track the timestamp

* timestamp hacks in thneed

* create a new command queue

* fix timestamp

* pretty much back to what we had, you can't use SNPE with thneed

* improve thneed test

* disable save log

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 302d06ee709cb65dba39e836917f5693f0819efb
2020-05-15 13:53:01 -07:00
Willem Melching aedf223401 remove eigen from phonelibs (#1505)
old-commit-hash: add784a7df0bd27aa1df115e38d43d5159c832f9
2020-05-13 16:41:52 -07:00
Willem Melching 8505259e41 Library cleanup (#1491)
* library cleanup

* remove fastcv

* Fix build step

* bump cereal

* bump cereal

* Install capnp

* bump

* no docker cache

* Update installation instructions

* Needs sudo

* Can we sudo?

* Cache was not the problem

* remove static libraries from boardd install script

* Update setup script

* Remove import

* No capnp install in lgtm

* Fix dockerfile
old-commit-hash: 72db8d890d04e6eb3ce652be3da9bdf23ebda510
2020-05-12 18:50:07 -07:00
Harald Schafer 02eeef5f2b safer
old-commit-hash: ee10697d861c422545ce29ce7869c328e42c7a7c
2020-05-10 22:00:41 -07:00
robbederks 5a12fc32e7 Ambient light calibration parameters on persist partition (#1429)
* WIP: light sensor persistent params

* fix params writing

* Persistent params argument in C params lib. Fixed symlink flow

* Removed debug prints

* fix boardd

* fix ui

* remove debug print
old-commit-hash: 71bebc4fca91681669c86b5600b67bf2b7f899bf
2020-05-08 19:39:18 -07:00
HaraldSchafer f3747d2fe5 Better poly (#1437)
- better polyfitting
- no mpc cost change during lane change
- model trained with better ll gt, sim noise and guaranteed memories
old-commit-hash: 65fcc7c45ff1d4d747dc52ff5791afb84a18744a
2020-05-08 17:14:43 -07:00
Dean Lee 0b0674ef20 camerad: move c-capnp to c++ (#1472)
* convert c-capnp to c++

change paramater type

* remove c-capnp header from commonmodel.c

* unsigned short -> uint16_t

* MSM_CAMERA_I2C_ADDR_TYPE_MAX->4
old-commit-hash: b6d6f520327226004c328a4b7cbbb3b855b2909d
2020-05-07 20:14:30 -07:00
George Hotz 16cbb5e255 Revert "Bypass alignment related copy whenever possible (#1443)"
This reverts commit 235d4f8957ee4566d6217783638fa58a586bb35a.

old-commit-hash: d5ca841b0f18d2e707eb1f73afac842ede9be7e8
2020-05-04 09:54:05 -07:00
George Hotz d47b2ef576 More LGTM fixups (#1457)
* exclude lib dirs, fix 3 cpp errors

* fix more alerts, exclude mkvparse

Co-authored-by: George Hotz <geohot@gmail.com>
old-commit-hash: e568d3cadc71d2b301fcb46af9afb3c8c8005f72
2020-05-02 20:00:41 -07:00
George Hotz 6fbcde48e5 Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
Dean Lee f2932aadfd Bypass alignment related copy whenever possible (#1443)
remove blank lines

add file messagehelp.h

remove blank line

simplify

after review
old-commit-hash: b2250166281406853de9901271d69a9e64b3b74e
2020-05-01 19:21:00 -07:00
Dean Lee 451af5865c unmap a previously mapped buff (#1410)
old-commit-hash: 98ec06e125b605405900673be0305677ad5efce3
2020-04-22 10:16:05 -07:00
Dean Lee f01bf14ba4 cleanup visionipc when recovering from fault in dmonitoringd and loggerd (#1402)
old-commit-hash: 2928c53e4fbf4be17f760f98c6b1dc3175f754bc
2020-04-20 13:15:11 -07:00
Andrew Sidhu 7fa9e07bf8 Fix by Boggyver - Add Traffic Convention data to input buffer (#1405)
Credit goes to Boggyver for finding this.
old-commit-hash: a120adaeccd8900995c0d9227e9354d0b176c615
2020-04-20 10:05:33 -07:00
Dean Lee 5564be35bf dmonitoringmodeld: fix memory leak (#1403)
old-commit-hash: ce4528c39219c203bc518d6ebd0d1d331b830d19
2020-04-20 09:23:23 -07:00
Dean Lee 83fde61d3b fixes the error with OpenCL depreciation warnings (#1394)
old-commit-hash: 25ab2521abb08e58b80f45f16ff51f949e28f05c
2020-04-19 14:04:33 -07:00
Willem Melching b5c2394ebe modeld, add cloudlogs
old-commit-hash: e171a7a047f9d5507ef650c79aee1d0981d66f5f
2020-04-19 14:00:30 -07:00
Dean Lee c69b4c17e8 modeld, cleanup visionipc when recovering from fault
old-commit-hash: 8f2858efba4ac7735c5bb237a7e88348ec4c424e
2020-04-19 13:59:36 -07:00
Willem Melching 93a539e7ff Release messaging sockets and context on shutdown (#1391)
* release resources when thread is done

* add white space

* add white space

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: 02e474580ee90713bc3426ea512278c5eb1c6b15
2020-04-17 16:37:34 -07:00
ZwX1616 f1a05ef594 fix RHD memory leak
old-commit-hash: 6c5080fa9860dbdfc6b97febc85ad1b537e42df9
2020-04-16 17:31:59 -07:00
HaraldSchafer 5d6131d711 add traffic convention (#1372)
* I think this works

* clean up
old-commit-hash: f5b28ad2d267adae0d6e6fd7816389d3f8d32200
2020-04-15 21:19:25 -07:00
ZwX1616 f90b956f47 RHD support for driver monitoring (#1299)
old-commit-hash: 133b1a20b42e56dc67a013dc2ee856360e4d1d1c
2020-04-15 16:48:44 -07:00