Commit Graph

884 Commits

Author SHA1 Message Date
ShaneSmiskol a830c71a03 Toyota: Only use gas interceptor under 19 mph (#21101)
* pedal improvements

* pedal tuning under 19 mph, stock tuning above

* Correctly set tuning, and a temporary reference script

* looking good

* use minEnableSpeed

* minEnableSpeed will always be -1 if pedal since it's used for lockout

* add hysteresis around 19 mph for enabling pedal use

* parameterize minAccSpeed (enable speed is -1 when stop and go to allow engage, acc is min limit for acc commands)

* fix Prius later, 5 mph gap around switch speed

* define min_acc_speed in interface and CC

* use pedal gains up to 22 mph, and correctly use hysteresis above the switch speed

* only check this if pedal

* consolidate comment

* Change BP to switch tuning at 19 mph, define global constant

* Start at interceptor status

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update releases

* typo

* transition tuning from 19 to +3 mph

* change cmd names and update tuning comment

* Update RELEASES.md

* calculate new pedal gains

* little more clear

* even clearer

* same comment convention and hardcode new pedal tune

* bump cereal

* weird, got added in with the rebase

* three possible long tunings: pedal, improved non-pedal, and default non-pedal

* update refs

* future note: don't add submodules when rebasing!

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ebc294296a
2021-06-03 15:11:10 -07:00
ShaneSmiskol 15a4851969 Use hyundaiLegacy safety model for Hyundai Elantra (#21108)
old-commit-hash: bf0e0ae00b
2021-06-03 13:48:54 -07:00
ShaneSmiskol eca70237fd Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: e9e197eb3c
2021-06-03 13:35:23 -07:00
Josh Smith 2cae3a3799 Add type hints, small cleanups (#21080)
* improve tools.lib.kbhit and tools.sim.lib.keyboard_ctrl

* unpack more efficiently

* minor improvements

* agnos.py match spec better

* manual_ctrl test missing queue arg

* fix incorrect type annotation

* queues are generic

* varname reuse resulting in incorrect type inference

* bytes().hex() rather than bytes.hex(bytes())

* a bit of type hinting stuff
old-commit-hash: 77321dbac4
2021-06-03 12:21:04 +02:00
Cruise Brantley 32139ae377 Update Elantra 2021 FPv2 values (#21069)
* Updates to fpv2 values

* Removed x00 changes

* Update incorrect value

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Remove possible incorrect duplicate value

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 8220056252
2021-06-03 11:31:18 +02:00
Adeeb Shihadeh d1422c20fc Honda: cleanup enable logic (#20749)
old-commit-hash: a69e1715d4
2021-06-03 01:49:33 -07:00
Jason Young fd9763b810 VW MQB: Add FW for 2017 Volkswagen Golf R (#21110)
old-commit-hash: fcc68d2a74
2021-06-02 10:43:28 -07:00
Jason Young 51db9216f2 Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
old-commit-hash: 83ca5a0d29
2021-06-02 15:51:54 +02:00
Adeeb Shihadeh 31a1fd79bf Kona EV: send LFA MFA message (#20320)
old-commit-hash: 9740052378
2021-06-01 18:11:46 -07:00
Adeeb Shihadeh c774eb6b64 fix missing semicolon
old-commit-hash: 2183582216
2021-06-01 15:58:26 -07:00
Robert Hanna f7a928ace3 Add LEXUS_ESH_TSS2 to improved longitudinal tune (#21016)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6d8c985801
2021-06-01 15:52:16 -07:00
Erich Moraga 76f49342b4 Add several missing PILOT_2019 f/w (#21097)
* Add several missing PILOT_2019 f/w

`@Abu ali#8344` 2019 Honda Pilot DongleID/route 1631748f51929063|2021-05-30--00-12-43

* Update selfdrive/car/honda/values.py

Ah yeah, got distracted ;-)

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Properly sorted the f/w

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 43fd045a3e
2021-06-01 15:47:09 -07:00
Adeeb Shihadeh 7ac7ec2094 Merge Lexus UXH into TSS2 Corolla Hybrid (#21100)
old-commit-hash: 2680537b4b
2021-06-01 14:56:53 -07:00
jbates9011 7bf71a3e3d Car Port: Toyota Avalon Hybrid 2019 (#21082)
* Add 2019 Avalon Hybrid

* Rename variable

* Update values.py

Remove AVALONH fingerprint due to pending deprecation

* Add Avalon Hybrid 2019

* Add Avalon Hybrid 2019

* Update test_routes.py for Avalon Hybrid 2019

Co-authored-by: ShaneSmiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 909b848fa3
2021-06-01 14:51:28 -07:00
ShaneSmiskol 1735252c7d Split Avalon 2016-18 and Avalon 2019+ (#21058)
* start to separate Avalon 2019+

* reverts #20824 (2020)...

and removes fw from a 2020 avalon

* revert 2020 fw from #20241

* revert 2021 fw from #19790

* bump opendbc, add smartDsu

* Add only removed fw from listed PRs above and from jryan's 2020

* bump opendbc to master

* comment out any non-original avalon fw

* new fw

* these 2016 (5 byte EPS_STATUS msg) Avalon fws are correct. comment out any 2019+ fw I haven't seen yet

* Add to release files

* these are good too

* nothing on 7e0 yet

* both have their engines on one address

* validated remaining fws! some from adeeb's, chris's, and kumar's PRs

* Add test route for Avalon 2019

* horrible

* Duplicate

* use nodsu dbc. Only difference is the addition of some signals that don't work, and max of BRAKE_PRESSURE is different

* Enablem 2019 Avalon test route
old-commit-hash: 07e4129edc
2021-06-01 12:41:24 -07:00
Jason Young 724323293e VW MQB: Add FW for 2015 Audi A3 (#21095)
* Add FW for 2015 Audi A3 (iamhtoo)

* Maintain sorting

* Maintain sorting
old-commit-hash: b12637d782
2021-06-01 18:11:02 +02:00
speedking456 9ffbacdae9 Add Kia Seltos fw versions (#21073)
old-commit-hash: 1a94a2cc8f
2021-05-30 17:03:16 -07:00
Jason Young 3355bc1381 VW MQB: Add FW for 2017 SEAT Leon (#21077)
* Add FW for 2017 SEAT Leon (fodys)

* Extend Leon MY range in README and RELEASES
old-commit-hash: 9b213538cf
2021-05-30 13:44:07 -07:00
Jason Young 2531599813 VW MQB: SEAT Leon Mk3 (#21048)
* Add 2020 SEAT Leon (exclamation point ai)

* Add SEAT Leon to README

* Fix Leon model-year

* Add SEAT Leon test route

* thanks me!
old-commit-hash: 34b6c56021
2021-05-28 13:53:50 -07:00
Jason Young bf9a2704f6 VW MQB: Add FW for 2018 Volkswagen Atlas (#21068)
old-commit-hash: 0c89ad98e5
2021-05-28 11:45:53 -07:00
Willem Melching 921aa1f0a4 Mazda: remove CAN fingerprints (#21067)
old-commit-hash: 0f13a80e0b
2021-05-28 16:53:12 +02:00
Jafar Al-Gharaibeh f108d93bc0 Mazda FP 2.0 support (#20879)
* Mazda FP 2.0 support

ECU FW for CX-5 2017 and Mazda3 2017

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use standard UDS request/reponse, fix missing arg.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add CX-5 FW test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update/add FW FP

Current suported models:
  CX-5 2017/2021
  CX-9 2019/2020
  Mazda3 2017/2018

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add Cx-9 2019 FW FP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Remove comments, remove TESTER_PRESENT_REQUEST from Mazda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* add transmission ecu to startup test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 824f93303d
2021-05-28 15:50:58 +02:00
Ewan e03be02f37 2019 Nissan Altima fingerprint (#20969)
* Update values.py

Add 2019 Altima support (may be specific to VC-Turbo model, do not have NA model to compare to)

* Update README.md

Add 2019 altima

* Update values.py

Combine fingerprint of 2020 + 2019

* Update values.py

* Update values.py

Sort fingerprint values numerically by key
old-commit-hash: a844c60f14
2021-05-26 17:54:44 -07:00
Jason Young f86abe47ce VW MQB: Škoda Octavia Mk3 (#21013)
* Add Skoda Octavia (cben, Saber422)

* Add Skoda Octavia to README

* Add to test_routes.py

* Remove non-viable test route

* Add test route for Octavia
old-commit-hash: 4de1655d20
2021-05-26 17:08:33 -07:00
Jason Young 24a9b9248c Update CI tests for CAN fingerprinting deprecation (#21043)
* Start refactor of CI tests for FPv1 deprecation

* Fix test_car_interfaces

* Touch up comment

* Smaller diff
old-commit-hash: 182b00896c
2021-05-26 14:02:42 -07:00
Adeeb Shihadeh d67b194790 chrysler pacifica 2020 fingerprint values
old-commit-hash: c736b7e5bb
2021-05-25 14:23:05 -07:00
dingyf12593 12a114dd6c VW MQB: Add FW values for 2018 Volkswagen Golf (#21020)
old-commit-hash: a6cfe90436
2021-05-25 12:37:23 +02:00
Jason Young 56612e7152 VW MQB: Rescue some FPv1 stragglers (#21019)
* Add FW, model-year for Audi A3 (Flyer)

* Add FW for 2016 Passat B8 (jwebb)
old-commit-hash: df93263a81
2021-05-24 19:17:51 -07:00
martinl c2a95c9d2c Fix Subaru Preglobal create_es_throttle_control (#21010)
old-commit-hash: aa0c2a1e7f
2021-05-24 15:36:31 -07:00
Adeeb Shihadeh e58a495396 Remove ignored CAN fingerprints (#20994)
* VW is all FW

* fix test

* toyota

* honda

* hyundai

* remove IGNORED_FINGERPRINTS

* toyota
old-commit-hash: e5575a6a4c
2021-05-24 13:50:10 -07:00
Jason Young 1399d2e98f Allow openpilot engaged while in manumatic (#20999)
old-commit-hash: 28a28834b7
2021-05-24 18:10:39 +02:00
Jason Young 124055b93c VW MQB: Cleanup, prep for J533 gateway integration (#20997)
* Refactor and clean up messages and signals

* Reenable checks[] enforcement

* Remove unused message check[]

* Comment touchup

* Make signal table names correct and consistent

* Refactor MqbExtraSignals for clarity
old-commit-hash: 591eaa1cbc
2021-05-23 16:47:52 -07:00
brianhaugen2 d36b821247 Car port: LEXUS UX 2019 (#20998)
* adding port for 2019 lexus ux 250h

* update README

* added route to test_routes

* added CAR.LEXUS_UXH_TSS2 to IGNORED_FINGERPRINTS
changed test route to a complete route (that will be uploaded)

* unused

* add fw

* forgot h

Co-authored-by: Brian Haugen <brian.haugen@toyota.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6089c95a35
2021-05-23 14:53:29 -07:00
Erich Moraga 35b1c6121d Add missing COROLLA_TSS2 engine f/w (#20988)
`@Papi#7442` 2020 Corolla LE ICE  DongleID/route 0f2c85da83cc0d82|2021-05-21--11-36-09--0
old-commit-hash: 4d2781b79e
2021-05-21 10:14:09 -07:00
TheWizard1328 50bd2c14f5 Chrysler Pacifica Fingerprint (#20935)
* Update values.py

* Update values.py

* Update selfdrive/car/chrysler/values.py

* Update values.py

Chrysler Pacifica 2020 fingerprint values added.

* Update values.py

* Update values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ed0c8a770f
2021-05-19 20:02:08 -07:00
martinl 1b6fe77d69 Add enableBsm for Subaru Preglobal (#20962)
old-commit-hash: 79050611d6
2021-05-18 23:45:37 -07:00
martinl 26071c770b Subaru signals update (#20956)
* switch to opendbc subaru-signals-2021-05-19

* update carstate signals to match dbc, rename fake_button to cruise_button

* Revert "switch to opendbc subaru-signals-2021-05-19"

This reverts commit f88d6ddcf5c10f8dd4ec37c5cb2cf9e208a56d75.

* bump opendbc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 587060bd92
2021-05-18 19:39:09 -07:00
ShaneSmiskol 0d45e6885a Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 551091bcfa
2021-05-18 17:48:02 -07:00
Cruise Brantley 8c61faf8ee 2021 Hyundai Elantra port (#20916)
* Elantra addition without fingerprint

* FPv1

* ignore fpv2 for fingerprint

* remove blank fpv2 troubleshooting

* FPV2

* missing commas

* added additional detected transmission

* Added to ignored fingerprints

* Test Route added

* Possible fixex for issues stated

* eps detected differently, added second detection

* Updated Naming
old-commit-hash: 42cd7b2b09
2021-05-18 15:52:22 -07:00
Erich Moraga fecadd2169 Add missing Camry FW (#20953)
* Add missing several missing Camry firmwares

@oxigen#0649 2019 Toyota Camry ICE  DongleID/route 04b2f59611cf9e7f|2021-05-18--11-11-17

* Update fw_versions.py
old-commit-hash: cb4ab31362
2021-05-18 15:46:04 -07:00
Adeeb Shihadeh 16c7107d65 fingerprint cloudlog event (#20950)
* fingerprint cloudlog event

* kale cloudlog

* not fuzzy
old-commit-hash: f08e01c97f
2021-05-18 10:52:53 -07:00
Willem Melching 41950a9f8a Cleanup HONDA_BOSCH alternate brake signal (#20901)
* Cleanup HONDA_BOSCH alternate brake signal

* always set self.brake_switch

* define in one place

* also defined here

* nesting

* remove CRV Hybrid

* rename brake_switch_ts

* add note about panda safety
old-commit-hash: 245312370f
2021-05-18 14:13:22 +02:00
Willem Melching b8e1d18f8e CRV Hybrid doesn't use alternate brake signal (#20945)
old-commit-hash: 4215f63769
2021-05-18 12:16:08 +02:00
Jason Young fe31599d8d VW MQB: Add FW for 2018 Volkswagen Atlas (#20938)
old-commit-hash: 22cf2e6440
2021-05-18 10:42:52 +02:00
ShaneSmiskol e4ad4a8e13 Honda - Don't send cancel cmd when using comma pedal (#20922)
* cancel is never true if cruise isn't enabled and pedal

* This is probably better

* comment

* want to see if this fails

* see what Actions says about this

* nice! just as a sanity test real quick

* Revert "nice! just as a sanity test real quick"

This reverts commit 2d86d1c32eca5ca8efb9b5d15483c65ce51c777a.

* Revert "see what Actions says about this"

This reverts commit c908488854ec391cc2ec0c2684739b94c5e526cc.

* Revert "want to see if this fails"

This reverts commit 2d515f37215095cedb790433429487d991630a9b.

* specify the fix

* No bitwise

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 483678adb1
2021-05-18 10:41:24 +02:00
Erich Moraga b822c0447a Add missing LEXUS_NXH EPS f/w (#20941)
`@wiDa#7648` 2018 Lexus NX 300H DongleID/route 886a703694424882|2021-05-17--23-01-14
old-commit-hash: b4f8223b5b
2021-05-17 20:54:04 -07:00
Chris McCammon 79c573e229 2021 Toyota Prius engine fw (#20939)
old-commit-hash: 82faee0edd
2021-05-17 19:46:46 -07:00
Chris McCammon df9b0f0af6 2020 Camry Hybrid engine fw (#20937)
old-commit-hash: 8d257af1e8
2021-05-17 19:22:45 -07:00
Jason Young ac22689c61 VW MQB: Add FW values for 2020 Volkswagen Jetta (#20936)
old-commit-hash: 1b56a454ef
2021-05-17 17:10:51 -07:00
Jason Young d235ea7ffb VW MQB: Add FW values for 2018 Volkswagen Golf Alltrack (#20905)
* Add FW values for 2018 Alltrack MT (pixl)

* Update README for supported Alltrack years
old-commit-hash: ed08d0af6c
2021-05-14 11:36:04 -07:00