ui: add accel boost indicator

.gitmodules

@@ -4,7 +4,6 @@
 [submodule "opendbc"]
   path = opendbc_repo
   url = https://github.com/sunnypilot/opendbc.git
-  branch = toyotabsmhack
 [submodule "msgq"]
   path = msgq_repo
   url = https://github.com/sunnypilot/msgq.git

openpilot/common/params_keys.h

@@ -200,7 +200,6 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"ShowAdvancedControls", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"ShowTurnSignals", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"StandstillTimer", {PERSISTENT | BACKUP, BOOL, "0"}},
-    {"TripSummary", {PERSISTENT | BACKUP, BOOL, "1"}},
     {"TrueVEgoUI", {PERSISTENT | BACKUP, BOOL, "0"}},
 
     // MADS params
@@ -246,7 +245,6 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"SubaruStopAndGoManualParkingBrake", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"TeslaCoopSteering", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"TeslaMadsScreenButton", {PERSISTENT | BACKUP, INT, "0"}},
-    {"ToyotaEnhancedBsm", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"ToyotaEnforceStockLongitudinal", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"ToyotaStopAndGoHack", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"ToyotaTSS2Smooth", {PERSISTENT | BACKUP, BOOL, "0"}},

openpilot/selfdrive/controls/controlsd.py

@@ -18,6 +18,7 @@ from openpilot.selfdrive.controls.lib.latcontrol_pid import LatControlPID
 from openpilot.selfdrive.controls.lib.latcontrol_angle import LatControlAngle, STEER_ANGLE_SATURATION_THRESHOLD
 from openpilot.selfdrive.controls.lib.latcontrol_curvature import LatControlCurvature
 from openpilot.selfdrive.controls.lib.latcontrol_torque import LatControlTorque
+from openpilot.selfdrive.controls.lib.longcontrol import LongControl
 from openpilot.selfdrive.modeld.modeld import LAT_SMOOTH_SECONDS
 from openpilot.selfdrive.locationd.helpers import PoseCalibrator, Pose
 
@@ -55,7 +56,7 @@ class Controls(ControlsExt):
     self.pose_calibrator = PoseCalibrator()
     self.calibrated_pose: Pose | None = None
 
-    self.LoC = ControlsExt.initialize_longitudinal_control(self, self.CP, self.CP_SP)
+    self.LoC = LongControl(self.CP, self.CP_SP)
     self.VM = VehicleModel(self.CP)
     self.LaC: LatControl
     if self.CP.steerControlType == car.CarParams.SteerControlType.angle:

openpilot/selfdrive/ui/layouts/main.py

@@ -10,7 +10,6 @@ from openpilot.selfdrive.ui.onroad.augmented_road_view import AugmentedRoadView
 from openpilot.selfdrive.ui.ui_state import device, ui_state
 from openpilot.selfdrive.ui.layouts.onboarding import OnboardingWindow
 from openpilot.selfdrive.ui.body.layouts.onroad import BodyLayout
-from openpilot.selfdrive.ui.sunnypilot.layouts.trip_summary import TripSummary
 
 if gui_app.sunnypilot_ui():
   from openpilot.selfdrive.ui.sunnypilot.layouts.settings.settings import SettingsLayoutSP as SettingsLayout
@@ -32,7 +31,6 @@ class MainLayout(Widget):
     self._sidebar = Sidebar()
     self._current_mode = MainState.HOME
     self._prev_onroad = False
-    self._trip_summary = TripSummary()
 
     # Initialize layouts
     self._home_layout = HomeLayout()

openpilot/selfdrive/ui/mici/layouts/main.py

@@ -10,7 +10,6 @@ from openpilot.selfdrive.ui.body.layouts.onroad import BodyLayout
 from openpilot.system.ui.widgets import Widget
 from openpilot.system.ui.widgets.scroller import Scroller
 from openpilot.system.ui.lib.application import gui_app
-from openpilot.selfdrive.ui.sunnypilot.layouts.trip_summary import TripSummary
 
 if gui_app.sunnypilot_ui():
   from openpilot.selfdrive.ui.sunnypilot.mici.layouts.settings import SettingsLayoutSP as SettingsLayout
@@ -58,7 +57,6 @@ class MiciMainLayout(Scroller):
     self._setup_callbacks()
 
     gui_app.add_nav_stack_tick(self._handle_transitions)
-    self._trip_summary = TripSummary()
     gui_app.push_widget(self)
 
     # Start onboarding if terms or training not completed, make sure to push after self

openpilot/selfdrive/ui/sunnypilot/layouts/settings/vehicle/brands/toyota.py

@@ -12,16 +12,10 @@ from openpilot.system.ui.widgets import DialogResult
 from openpilot.system.ui.widgets.confirm_dialog import ConfirmDialog
 from openpilot.system.ui.sunnypilot.widgets.list_view import toggle_item_sp
 from opendbc.car.toyota.values import ToyotaFlags
-from opendbc.sunnypilot.car.toyota.values import ToyotaFlagsSP
 
 
 ONROAD_ONLY_DESCRIPTION = tr_noop("Start the vehicle to check vehicle compatibility.")
 SNG_HACK_UNAVAILABLE = tr_noop("sunnypilot Longitudinal Control must be available and enabled for your vehicle to use this feature.")
-BSM_UNAVAILABLE = tr_noop("Enhanced Blind Spot Monitoring requires a TSS2 Toyota/Lexus without SecOC, " +
-                           "or a smartDSU with sunnypilot longitudinal control.")
-BSM_STOCK_LONG_UNAVAILABLE = tr_noop("Enhanced Blind Spot Monitoring is not available while Enforce Factory Longitudinal Control is enabled.")
-BSM_REQUIRED = tr_noop("This vehicle does not report blind spot status over the standard CAN signals. " +
-                        "Enhanced Blind Spot Monitoring is required for blind spot detection.")
 PLATFORM_UNAVAILABLE = tr_noop("This feature is currently not available on this platform.")
 
 DESCRIPTIONS = {
@@ -32,10 +26,6 @@ DESCRIPTIONS = {
     'sunnypilot will allow some Toyota/Lexus cars to auto resume during stop and go traffic. ' +
     'This feature is only applicable to certain models that are able to use longitudinal control. This is an alpha feature. Use at your own risk.'
   ),
-  'enhanced_bsm': tr_noop(
-    'sunnypilot will poll the blind spot monitor diagnostics directly from the radar. Use this on vehicles whose blind spot monitors ' +
-    'do not report blind spot status over the standard CAN signals. This is an alpha feature. Use at your own risk.'
-  ),
   'tss2_smooth': tr_noop(
     'Enable smoother longitudinal control for TSS2 vehicles. ' +
     'Uses a custom speed-dependent integral gain curve for smoother traffic driving.'
@@ -63,14 +53,6 @@ class ToyotaSettings(BrandSettings):
       enabled=lambda: not ui_state.engaged,
     )
 
-    self.enhanced_bsm = toggle_item_sp(
-      lambda: tr("Enhanced Blind Spot Monitoring (Alpha)"),
-      description=lambda: tr(DESCRIPTIONS["enhanced_bsm"]),
-      initial_state=ui_state.params.get_bool("ToyotaEnhancedBsm"),
-      callback=self._on_enable_enhanced_bsm,
-      enabled=lambda: not ui_state.engaged,
-    )
-
     self.tss2_smooth = toggle_item_sp(
       lambda: tr("TSS2 Smooth Longitudinal (Alpha)"),
       description=lambda: tr(DESCRIPTIONS["tss2_smooth"]),
@@ -82,7 +64,6 @@ class ToyotaSettings(BrandSettings):
     self.items = [
       self.enforce_stock_longitudinal,
       self.stop_and_go_hack,
-      self.enhanced_bsm,
       self.tss2_smooth,
     ]
 
@@ -149,25 +130,6 @@ class ToyotaSettings(BrandSettings):
       ui_state.params.put_bool("ToyotaStopAndGoHack", False)
       ui_state.params.put_bool("OnroadCycleRequested", True)
 
-  def _on_enable_enhanced_bsm(self, state: bool):
-    if state:
-      def confirm_callback(result: int):
-        if result == DialogResult.CONFIRM:
-          ui_state.params.put_bool("ToyotaEnhancedBsm", True)
-          ui_state.params.put_bool("OnroadCycleRequested", True)
-        else:
-          self.enhanced_bsm.action_item.set_state(False)
-
-      content = (f"<h1>{self.enhanced_bsm.title}</h1><br>" +
-                 f"<p>{self.enhanced_bsm.description}</p>")
-
-      dlg = ConfirmDialog(content, tr("Enable"), rich=True, callback=confirm_callback)
-      gui_app.push_widget(dlg)
-
-    else:
-      ui_state.params.put_bool("ToyotaEnhancedBsm", False)
-      ui_state.params.put_bool("OnroadCycleRequested", True)
-
   def update_settings(self):
     if ui_state.CP is not None:
       longitudinal = ui_state.CP.openpilotLongitudinalControl
@@ -188,31 +150,6 @@ class ToyotaSettings(BrandSettings):
         if show_desc:
           self.stop_and_go_hack.show_description(True)
 
-      # Enhanced BSM needs the radar diagnostic address, which is only in the TX allowlist for
-      # TSS2 cars without SecOC, or for TSS-P cars whose smartDSU lets sunnypilot control
-      # longitudinal. Enforcing factory longitudinal control rules both of those out.
-      sdsu_bsm_supported = (longitudinal and ui_state.CP_SP is not None and
-                            bool(ui_state.CP_SP.flags & ToyotaFlagsSP.SMART_DSU))
-      bsm_supported = (not bool(ui_state.CP.flags & ToyotaFlags.SECOC) and
-                       (bool(ui_state.CP.flags & ToyotaFlags.TSS2) or sdsu_bsm_supported))
-      bsm_available = bsm_supported and not enforce_stock
-      self.enhanced_bsm.action_item.set_enabled(bsm_available and not ui_state.engaged)
-
-      bsm_desc = tr(DESCRIPTIONS["enhanced_bsm"])
-      if not bsm_supported:
-        self.enhanced_bsm.action_item.set_state(False)
-        bsm_desc = "<b>" + tr(BSM_UNAVAILABLE) + "</b>\n\n" + bsm_desc
-      elif enforce_stock:
-        self.enhanced_bsm.action_item.set_state(False)
-        bsm_desc = "<b>" + tr(BSM_STOCK_LONG_UNAVAILABLE) + "</b>\n\n" + bsm_desc
-      elif ui_state.CP_SP is not None and ui_state.CP_SP.flags & ToyotaFlagsSP.SP_NEED_DEBUG_BSM:
-        bsm_desc = "<b>" + tr(BSM_REQUIRED) + "</b>\n\n" + bsm_desc
-
-      if self.enhanced_bsm.description != bsm_desc:
-        self.enhanced_bsm.set_description(bsm_desc)
-        if not bsm_available:
-          self.enhanced_bsm.show_description(True)
-
       tss2 = bool(ui_state.CP.flags & ToyotaFlags.TSS2)
       if longitudinal and not enforce_stock and tss2:
         self.tss2_smooth.action_item.set_enabled(not ui_state.engaged)
@@ -236,12 +173,6 @@ class ToyotaSettings(BrandSettings):
         self.stop_and_go_hack.set_description(new_desc)
         self.stop_and_go_hack.show_description(True)
 
-      self.enhanced_bsm.action_item.set_enabled(False)
-      bsm_desc = "<b>" + tr(ONROAD_ONLY_DESCRIPTION) + "</b>\n\n" + tr(DESCRIPTIONS["enhanced_bsm"])
-      if self.enhanced_bsm.description != bsm_desc:
-        self.enhanced_bsm.set_description(bsm_desc)
-        self.enhanced_bsm.show_description(True)
-
       self.tss2_smooth.action_item.set_enabled(False)
       new_desc = "<b>" + tr(ONROAD_ONLY_DESCRIPTION) + "</b>\n\n" + tr(DESCRIPTIONS["tss2_smooth"])
       if self.tss2_smooth.description != new_desc:

openpilot/selfdrive/ui/sunnypilot/layouts/settings/visuals.py

@@ -72,11 +72,6 @@ class VisualsLayout(Widget):
            "It is the driver's responsibility to observe their environment and make decisions accordingly."),
         None,
       ),
-      "TripSummary": (
-        lambda: tr("Trip Summary"),
-        tr("Show a summary of distance and engagement when you shift into park after a drive."),
-        None,
-      ),
       "TrueVEgoUI": (
         lambda: tr("Speedometer: Always Display True Speed"),
         tr("For applicable vehicles, always display the true vehicle current speed from wheel speed sensors."),

openpilot/selfdrive/ui/sunnypilot/layouts/trip_summary.py

@@ -1,199 +0,0 @@
-"""
-Copyright (c) 2021-, Haibin Wen, sunnypilot, and a number of other contributors.
-
-This file is part of sunnypilot and is licensed under the MIT License.
-See the LICENSE.md file in the root directory for more details.
-"""
-import time
-import pyray as rl
-
-from opendbc.car.structs import car
-
-from openpilot.common.constants import CV
-from openpilot.selfdrive.ui.onroad.augmented_road_view import BORDER_COLORS
-from openpilot.selfdrive.ui.ui_state import ui_state, UIStatus
-from openpilot.system.ui.lib.application import gui_app, FontWeight
-from openpilot.system.ui.lib.text_measure import measure_text_cached
-from openpilot.system.ui.widgets import Widget
-
-AUTO_DISMISS = 20.
-FADE_IN, FADE_OUT = 0.35, 0.3
-LAT = (UIStatus.ENGAGED, UIStatus.LAT_ONLY)
-LONG = (UIStatus.ENGAGED, UIStatus.LONG_ONLY)
-GEAR = car.CarState.GearShifter
-FORWARD = (GEAR.drive, GEAR.sport, GEAR.low, GEAR.brake, GEAR.eco, GEAR.manumatic)
-
-
-class TripTracker:
-  def __init__(self):
-    self.reset()
-
-  def reset(self):
-    self.segments: list[list] = []
-    self.seconds = 0.
-    self.takeovers = 0
-    self._t = None
-    self._status = None
-
-  def update(self, driving: bool):
-    now = time.monotonic()
-    if not driving:
-      self._t = None
-      self._status = None
-      return
-    dt = 0. if self._t is None else min(now - self._t, 0.5)
-    self._t = now
-    self.seconds += dt
-    if self._status not in (None, UIStatus.DISENGAGED) and ui_state.status == UIStatus.DISENGAGED:
-      self.takeovers += 1
-    self._status = ui_state.status
-    d = max(ui_state.sm["carState"].vEgo, 0.) * dt
-    if d <= 0.:
-      return
-    if self.segments and self.segments[-1][0] == ui_state.status:
-      self.segments[-1][1] += d
-    else:
-      self.segments.append([ui_state.status, d])
-
-  def total(self, statuses=None) -> float:
-    return sum(m for s, m in self.segments if statuses is None or s in statuses)
-
-
-class TripSummary:
-  def __init__(self):
-    self._trip = TripTracker()
-    self._dialog: TripSummaryDialog | None = None
-    self._gear = None
-    self._drove = False
-    gui_app.add_nav_stack_tick(self._tick)
-
-  def _tick(self):
-    gear = ui_state.sm["carState"].gearShifter if ui_state.started else None
-    self._trip.update(gear not in (None, GEAR.park))
-    self._drove |= gear in FORWARD
-    if gear == self._gear:
-      return
-    self._gear = gear
-
-    if gear not in (None, GEAR.park):
-      self._pop()
-    elif gear == GEAR.park and self._drove and ui_state.trip_summary and not ui_state.is_body and self._trip.total() > 0.:
-      self._dialog = TripSummaryDialog(self._trip, gui_app.get_active_widget(), self._pop)
-      gui_app.push_widget(self._dialog)
-    if gear is None:
-      self._trip.reset()
-    if gear in (None, GEAR.park):
-      self._drove = False
-
-  def _pop(self):
-    if self._dialog is not None and gui_app.get_active_widget() is self._dialog:
-      gui_app.pop_widget()
-    self._dialog = None
-
-
-def _ease(t: float) -> float:
-  t = min(max(t, 0.), 1.)
-  return 1 - (1 - t) ** 3
-
-
-def _fade(c, a: float) -> rl.Color:
-  r, g, b, al = c if isinstance(c, tuple) else (c.r, c.g, c.b, c.a)
-  return rl.Color(r, g, b, int(al * a))
-
-
-class TripSummaryDialog(Widget):
-  def __init__(self, trip: TripTracker, below: Widget | None, on_closed):
-    super().__init__()
-    self._below = below
-    self._on_closed = on_closed
-    self._segments = segments = trip.segments
-    total = sum(m for _, m in segments)
-
-    def pct(statuses):
-      return 100 * sum(m for s, m in segments if s in statuses) / total
-
-    dist = total * (CV.MS_TO_KPH if ui_state.is_metric else CV.MS_TO_MPH) / 3600
-    dist_fmt = "{:.1f}" if dist < 9.95 else "{:.0f}"
-    self._stats = [
-      (dist, dist_fmt, "km" if ui_state.is_metric else "mi", "driven"),
-      (pct(LAT + LONG), "{:.0f}", "%", "engaged"),
-      (pct(LAT), "{:.0f}", "%", "lateral"),
-      (pct(LONG), "{:.0f}", "%", "longitudinal"),
-    ]
-    mins = round(trip.seconds / 60)
-    self._details = [
-      (f"{mins // 60}h {mins % 60}" if mins >= 60 else f"{mins}", "min"),
-      (f"{trip.takeovers}", "takeover" if trip.takeovers == 1 else "takeovers"),
-    ]
-    self._bold = gui_app.font(FontWeight.BOLD)
-    self._semi = gui_app.font(FontWeight.SEMI_BOLD)
-    self._normal = gui_app.font(FontWeight.NORMAL)
-    self._big = gui_app.big_ui()
-    self._shown_t = rl.get_time()
-    self._closing_t: float | None = None
-    self.set_click_callback(self.close)
-
-  def close(self):
-    if self._closing_t is None:
-      self._closing_t = rl.get_time()
-
-  def _render(self, rect: rl.Rectangle):
-    t = rl.get_time() - self._shown_t
-    if self._closing_t is None and t > AUTO_DISMISS:
-      self.close()
-    out = 0. if self._closing_t is None else (rl.get_time() - self._closing_t) / FADE_OUT
-    if out >= 1.:
-      self._on_closed()
-      return
-    bg = 1 - _ease(out)
-    a = _ease(t / FADE_IN) * bg
-
-    if self._big and self._below is not None and bg < 1.:
-      self._below.render(rect)
-    rl.draw_rectangle_rec(rect, _fade(rl.BLACK, bg))
-
-    k = rect.height / 1080 * (1.0 if self._big else 1.22)
-    pad = 120 * k
-    x, w = rect.x + pad, rect.width - 2 * pad
-    y = rect.y + (rect.height - 850 * k) / 2
-
-    rl.draw_text_ex(self._bold, "trip summary", rl.Vector2(x, y), int(150 * k), 0, _fade(rl.WHITE, a))
-    y += 260 * k
-
-    col_w = w / len(self._stats)
-    for i, (target, fmt, unit, label) in enumerate(self._stats):
-      cx = x + col_w * (i + 0.5)
-      v = measure_text_cached(self._bold, fmt.format(target), int(170 * k))
-      u = measure_text_cached(self._semi, unit, int(80 * k))
-      vx = cx - (v.x + 10 * k + u.x) / 2
-      rl.draw_text_ex(self._bold, fmt.format(target), rl.Vector2(vx, y), int(170 * k), 0, _fade(rl.WHITE, a))
-      rl.draw_text_ex(self._semi, unit, rl.Vector2(vx + v.x + 10 * k, y + 75 * k), int(80 * k), 0, _fade(rl.WHITE, a))
-      lb = measure_text_cached(self._normal, label, int(70 * k))
-      rl.draw_text_ex(self._normal, label, rl.Vector2(cx - lb.x / 2, y + 180 * k), int(70 * k), 0, _fade(rl.Color(200, 200, 200, 255), a))
-    y += 330 * k
-
-    bar = rl.Rectangle(x, y, w, 90 * k)
-    total = sum(m for _, m in self._segments)
-    sx = bar.x
-    for status, m in self._segments:
-      sw = bar.width * m / total
-      rl.draw_rectangle_rec(rl.Rectangle(sx, bar.y, min(sw + 1, bar.x + bar.width - sx), bar.height), _fade(BORDER_COLORS[status], a))
-      sx += sw
-    rl.draw_rectangle_rounded_lines_ex(bar, 1.0, 20, 30 * k, _fade(rl.BLACK, a))
-
-    y += (90 + 70) * k
-
-    size = int(90 * k)
-    parts = []
-    for i, (value, unit) in enumerate(self._details):
-      if i:
-        parts.append(("     ", self._normal, None))
-      parts += [(value, self._bold, rl.WHITE), (" " + unit, self._normal, rl.Color(170, 170, 170, 255))]
-    widths = [measure_text_cached(f, t, size).x for t, f, _ in parts]
-    lx = x + (w - sum(widths)) / 2
-    for (text, font, color), tw in zip(parts, widths, strict=True):
-      if color is None:
-        rl.draw_circle(int(lx + tw / 2), int(y + size * 0.6), 12 * k, _fade(rl.Color(110, 110, 110, 255), a))
-      else:
-        rl.draw_text_ex(font, text, rl.Vector2(lx, y), size, 0, _fade(color, a))
-      lx += tw

openpilot/selfdrive/ui/sunnypilot/ui_state.py

@@ -49,7 +49,6 @@ class UIStateSP:
     self.model_runner_tinygrad: bool = False
     self.active_runner_tinygrad: bool = False
     self.blindspot: bool = False
-    self.trip_summary: bool = True
     self.chevron_metrics = None
     self.custom_interactive_timeout: int = 0
     self.developer_ui = None
@@ -188,7 +187,6 @@ class UIStateSP:
     self.standstill_timer = self.params.get_bool("StandstillTimer")
     self.sunnylink_enabled = self.params.get_bool("SunnylinkEnabled")
     self.torque_bar = self.params.get_bool("TorqueBar")
-    self.trip_summary = self.params.get_bool("TripSummary")
     self.enforce_torque_control = self.params.get_bool("EnforceTorqueControl")
     self.custom_torque_params = self.params.get_bool("CustomTorqueParams")
     self.torque_override_enabled = self.params.get_bool("TorqueParamsOverrideEnabled")

openpilot/sunnypilot/selfdrive/car/interfaces.py

@@ -126,7 +126,6 @@ def initialize_params(params) -> list[dict[str, Any]]:
   keys.extend([
     "ToyotaEnforceStockLongitudinal",
     "ToyotaStopAndGoHack",
-    "ToyotaEnhancedBsm",
     "ToyotaTSS2Smooth",
   ])
 

openpilot/sunnypilot/selfdrive/controls/controlsd_ext.py

@@ -17,7 +17,6 @@ from openpilot.sunnypilot.livedelay.helpers import get_lat_delay
 from openpilot.sunnypilot.modeld_v2.modeld_base import ModelStateBase
 from openpilot.sunnypilot.selfdrive.controls.lib.blinker_pause_lateral import BlinkerPauseLateral
 from openpilot.sunnypilot.selfdrive.controls.lib.latcontrol_torque_v0 import LatControlTorque as LatControlTorqueV0
-from openpilot.sunnypilot.selfdrive.controls.lib.longcontrol_sp import LongControlSP
 
 
 class ControlsExt(ModelStateBase):
@@ -35,9 +34,6 @@ class ControlsExt(ModelStateBase):
     self.sm_services_ext = ['radarState', 'selfdriveStateSP']
     self.pm_services_ext = ['carControlSP']
 
-  def initialize_longitudinal_control(self, CP: structs.CarParams, CP_SP: custom.CarParamsSP) -> LongControlSP:
-    return LongControlSP(CP, CP_SP)
-
   def initialize_lateral_control(self, lac, CI, dt):
     enforce_torque_control = self.params.get_bool("EnforceTorqueControl")
     torque_versions = self.params.get("TorqueControlTune")

openpilot/sunnypilot/selfdrive/controls/lib/longcontrol_sp.py

@@ -1,56 +0,0 @@
-"""
-Copyright (c) 2021-, sunnypilot, and a number of other contributors.
-
-This file is part of sunnypilot and is licensed under the MIT License.
-See the LICENSE.md file in the root directory for more details.
-"""
-import numpy as np
-
-from openpilot.common.realtime import DT_CTRL
-from openpilot.selfdrive.controls.lib.longcontrol import LongControl, LongCtrlState
-
-STOP_ACCEL_TAPER_GAIN = 3.0  # 1/s
-STOP_ACCEL_RAMP = 1.0  # m/s^3
-STOP_HOLD_RAMP = 4.0  # m/s^3
-STOP_HOLD_SPEED = 0.05  # m/s
-
-
-class StopSmoother:
-  def __init__(self, stop_accel: float):
-    self.stop_accel = stop_accel
-    self.last_accel = 0.0
-
-  def reset(self, accel: float = 0.0) -> None:
-    self.last_accel = accel
-
-  def update(self, v_ego: float, standstill: bool, accel_limits: tuple[float, float]) -> float:
-    v_ego = max(v_ego, 0.0)
-    stopped = standstill or v_ego <= STOP_HOLD_SPEED
-
-    if self.stop_accel < 0.0:
-      target_accel = self.stop_accel if stopped else max(self.stop_accel, -STOP_ACCEL_TAPER_GAIN * v_ego)
-    else:
-      target_accel = min(self.last_accel, 0.0)
-
-    ramp_rate = STOP_HOLD_RAMP if stopped else STOP_ACCEL_RAMP
-    max_change = ramp_rate * DT_CTRL
-    self.last_accel = float(np.clip(self.last_accel + np.clip(target_accel - self.last_accel, -max_change, max_change),
-                                    accel_limits[0], accel_limits[1]))
-    return self.last_accel
-
-
-class LongControlSP(LongControl):
-  def __init__(self, CP, CP_SP):
-    super().__init__(CP, CP_SP)
-    self.stop_smoother = StopSmoother(CP.stopAccel)
-
-  def update(self, active, CS, a_target, should_stop, accel_limits):
-    output_accel = super().update(active, CS, a_target, should_stop, accel_limits)
-
-    if self.long_control_state == LongCtrlState.stopping:
-      output_accel = self.stop_smoother.update(CS.vEgo, CS.standstill, accel_limits)
-      self.last_output_accel = output_accel
-    else:
-      self.stop_smoother.reset(output_accel)
-
-    return float(output_accel)

openpilot/sunnypilot/selfdrive/controls/lib/tests/test_longcontrol_sp.py

@@ -1,86 +0,0 @@
-"""
-Copyright (c) 2021-, sunnypilot, and a number of other contributors.
-
-This file is part of sunnypilot and is licensed under the MIT License.
-See the LICENSE.md file in the root directory for more details.
-"""
-from types import SimpleNamespace
-
-from opendbc.car.structs import car
-from openpilot.common.realtime import DT_CTRL
-from openpilot.common.test import OpenpilotTestCase
-from openpilot.cereal import custom
-from openpilot.selfdrive.controls.lib.longcontrol import LongCtrlState
-from openpilot.sunnypilot.selfdrive.controls.lib.longcontrol_sp import LongControlSP, STOP_ACCEL_RAMP, STOP_ACCEL_TAPER_GAIN
-
-
-class TestLongControlSP(OpenpilotTestCase):
-  CP_SP = custom.CarParamsSP.new_message()
-
-  def make_control(self, stop_accel=-1.5):
-    CP = car.CarParams.new_message()
-    CP.stopAccel = stop_accel
-    CP.longitudinalTuning.kiBP = [0.0]
-    CP.longitudinalTuning.kiV = [0.0]
-    return LongControlSP(CP, self.CP_SP)
-
-  @staticmethod
-  def make_cs(v_ego, a_ego=0.0, brake_pressed=False, standstill=False):
-    return SimpleNamespace(vEgo=v_ego, aEgo=a_ego, brakePressed=brake_pressed, standstill=standstill,
-                           cruiseState=SimpleNamespace(standstill=standstill))
-
-  def settle(self, loc, cs, frames=300, limits=(-2.0, 2.0)):
-    for _ in range(frames):
-      out = loc.update(True, cs, -0.5, should_stop=True, accel_limits=limits)
-    return out
-
-  def test_no_step_at_handover(self):
-    loc = self.make_control()
-    out = loc.update(True, self.make_cs(0.5, a_ego=-0.5), -0.5, should_stop=False, accel_limits=(-2.0, 2.0))
-    assert loc.long_control_state == LongCtrlState.pid
-    assert abs(out - -0.5) < 1e-6
-
-    out = loc.update(True, self.make_cs(0.3, a_ego=-0.5), -0.5, should_stop=True, accel_limits=(-2.0, 2.0))
-    assert loc.long_control_state == LongCtrlState.stopping
-    assert abs(out - (-0.5 - STOP_ACCEL_RAMP * DT_CTRL)) < 1e-6
-
-  def test_no_step_from_positive_accel(self):
-    loc = self.make_control()
-    loc.update(True, self.make_cs(0.4), 0.2, should_stop=False, accel_limits=(-2.0, 2.0))
-    out = loc.update(True, self.make_cs(0.25), 0.2, should_stop=True, accel_limits=(-2.0, 2.0))
-    assert loc.long_control_state == LongCtrlState.stopping
-    assert abs(out - (0.2 - STOP_ACCEL_RAMP * DT_CTRL)) < 1e-6
-
-  def test_decel_tapers_with_speed(self):
-    for v_ego in (1.0, 0.3, 0.1):
-      out = self.settle(self.make_control(), self.make_cs(v_ego))
-      assert abs(out - max(-1.5, -STOP_ACCEL_TAPER_GAIN * v_ego)) < 1e-6
-
-  def test_holds_at_standstill(self):
-    assert abs(self.settle(self.make_control(), self.make_cs(0.0)) - -1.5) < 1e-6
-    assert abs(self.settle(self.make_control(), self.make_cs(0.5, standstill=True)) - -1.5) < 1e-6
-
-  def test_car_holds_itself(self):
-    loc = self.make_control(stop_accel=0.0)
-    loc.update(True, self.make_cs(0.5), -0.4, should_stop=False, accel_limits=(-2.0, 2.0))
-    assert abs(self.settle(loc, self.make_cs(0.2)) - -0.4) < 1e-6
-
-  def test_stop_change_is_jerk_limited(self):
-    loc = self.make_control()
-    v_ego = 0.3
-    prev = loc.update(True, self.make_cs(v_ego), -0.5, should_stop=True, accel_limits=(-2.0, 2.0))
-    for _ in range(100):
-      out = loc.update(True, self.make_cs(v_ego), -0.5, should_stop=True, accel_limits=(-2.0, 2.0))
-      assert abs(out - prev) <= STOP_ACCEL_RAMP * DT_CTRL + 1e-9
-      prev = out
-
-  def test_repeatable(self):
-    runs = []
-    for _ in range(2):
-      loc = self.make_control()
-      run = []
-      for i in range(200):
-        v_ego = max(1.0 - i * 0.01, 0.0)
-        run.append(loc.update(True, self.make_cs(v_ego), -0.5, should_stop=v_ego < 0.3, accel_limits=(-2.0, 2.0)))
-      runs.append(run)
-    assert runs[0] == runs[1]

openpilot/sunnypilot/sunnylink/capabilities.py

@@ -13,7 +13,6 @@ from opendbc.car.subaru.values import CAR as SUBARU_CAR, SubaruFlags
 from opendbc.car.toyota.values import CAR as TOYOTA_CAR, ToyotaFlags
 from opendbc.sunnypilot.car.interfaces import has_bsm
 from opendbc.sunnypilot.car.tesla.values import TeslaFlagsSP
-from opendbc.sunnypilot.car.toyota.values import ToyotaFlagsSP
 from openpilot.common.params import Params
 from openpilot.common.swaglog import cloudlog
 from openpilot.common.hardware import HARDWARE
@@ -45,7 +44,6 @@ CAPABILITY_FIELDS = (
   "device_type",
   "subaru_has_sng",
   "hyundai_alpha_long_available",
-  "toyota_enhanced_bsm_available",
   "toyota_tss2",
   "custom_model_active",
 )
@@ -70,7 +68,6 @@ CAPABILITY_LABELS: dict[str, str] = {
   "device_type": "Device type",
   "subaru_has_sng": "Subaru Stop-and-Go available",
   "hyundai_alpha_long_available": "Hyundai Alpha Longitudinal available",
-  "toyota_enhanced_bsm_available": "Toyota Enhanced BSM available",
   "toyota_tss2": "Toyota TSS2 platform",
   "custom_model_active": "Non-Default model selected",
 }
@@ -92,7 +89,6 @@ CAR_CAPABILITY_FIELDS = (
   "subaru_has_sng",
   "hyundai_alpha_long_available",
   "toyota_tss2",
-  "toyota_enhanced_bsm_available",
 )
 
 # Explicit defaults for non-boolean capability fields
@@ -108,7 +104,7 @@ def _bundle_field(bundle: dict | None, key: str) -> str:
   return bundle.get(key, "") if isinstance(bundle, dict) else ""
 
 
-def _resolve_brand_capabilities(caps: dict, bundle_platform: str, CP, CP_SP=None) -> None:
+def _resolve_brand_capabilities(caps: dict, bundle_platform: str, CP) -> None:
   """Set brand-specific capabilities from bundle platform or CarParams fallback.
 
   Bundle (manual car selection) is a pre-fingerprint approximation.
@@ -142,18 +138,11 @@ def _resolve_brand_capabilities(caps: dict, bundle_platform: str, CP, CP_SP=None
   elif brand == "toyota":
     if bundle_platform:
       try:
-        flags = TOYOTA_CAR[bundle_platform].config.flags
-        caps["toyota_tss2"] = bool(flags & ToyotaFlags.TSS2)
-        caps["toyota_enhanced_bsm_available"] = bool(flags & ToyotaFlags.TSS2) and not bool(flags & ToyotaFlags.SECOC)
+        caps["toyota_tss2"] = bool(TOYOTA_CAR[bundle_platform].config.flags & ToyotaFlags.TSS2)
       except KeyError:
         cloudlog.exception(f"capabilities: unknown toyota platform {bundle_platform!r}")
     elif CP is not None:
       caps["toyota_tss2"] = bool(CP.flags & ToyotaFlags.TSS2)
-      # same gate as _initialize_toyota: TSS2 without SecOC, or TSS-P with a smartDSU and openpilot
-      # longitudinal control (the bundle path can't see 0x2FF, so it stays TSS2-only)
-      sdsu_bsm = CP_SP is not None and bool(CP_SP.flags & ToyotaFlagsSP.SMART_DSU) and bool(CP.openpilotLongitudinalControl)
-      caps["toyota_enhanced_bsm_available"] = (not bool(CP.flags & ToyotaFlags.SECOC) and
-                                               (bool(CP.flags & ToyotaFlags.TSS2) or sdsu_bsm))
 
 
 def generate_capabilities(params: Params | None = None) -> dict:
@@ -228,7 +217,7 @@ def generate_capabilities(params: Params | None = None) -> dict:
   if CP is not None:
     caps["has_bsm"] = has_bsm(CP, CP_SP)
 
-  _resolve_brand_capabilities(caps, bundle_platform, CP, CP_SP)
+  _resolve_brand_capabilities(caps, bundle_platform, CP)
 
   return caps
 

openpilot/sunnypilot/sunnylink/docs/README.md

@@ -156,7 +156,7 @@ The tables below describe the **compiled** `settings_ui.json` schema — what th
 
 **Enablement rules**: Grayed out (disabled) when rules fail. Frontend shows a contextual badge explaining why.
 
-**Capability fields** (referenced in rules): `has_longitudinal_control`, `has_icbm`, `icbm_available`, `torque_allowed`, `brand`, `pcm_cruise`, `alpha_long_available`, `steer_control_type`, `has_bsm`, `is_release`, `is_sp_release`, `is_development`, `tesla_has_vehicle_bus`, `has_stop_and_go`, `stock_longitudinal`, `toyota_enhanced_bsm_available`
+**Capability fields** (referenced in rules): `has_longitudinal_control`, `has_icbm`, `icbm_available`, `torque_allowed`, `brand`, `pcm_cruise`, `alpha_long_available`, `steer_control_type`, `has_bsm`, `is_release`, `is_sp_release`, `is_development`, `tesla_has_vehicle_bus`, `has_stop_and_go`, `stock_longitudinal`
 
 ---
 

openpilot/sunnypilot/sunnylink/settings_ui.json

@@ -1412,12 +1412,6 @@
                 }
               ]
             },
-            {
-              "key": "TripSummary",
-              "widget": "toggle",
-              "title": "Trip Summary",
-              "description": "Show a summary of distance and engagement when you shift into park after a drive."
-            },
             {
               "key": "RocketFuel",
               "widget": "toggle",
@@ -2367,28 +2361,6 @@
             }
           ]
         },
-        {
-          "key": "ToyotaEnhancedBsm",
-          "widget": "toggle",
-          "needs_onroad_cycle": true,
-          "title": "Enhanced Blind Spot Monitoring (Alpha)",
-          "description": "sunnypilot will poll the blind spot monitor diagnostics directly from the radar. Use this on vehicles whose blind spot monitors do not report blind spot status over the standard CAN signals. This is an alpha feature. Use at your own risk.",
-          "enablement": [
-            {
-              "type": "not_engaged"
-            },
-            {
-              "type": "capability",
-              "field": "toyota_enhanced_bsm_available",
-              "equals": true
-            },
-            {
-              "type": "capability",
-              "field": "stock_longitudinal",
-              "equals": false
-            }
-          ]
-        },
         {
           "key": "ToyotaTSS2Smooth",
           "widget": "toggle",

openpilot/sunnypilot/sunnylink/settings_ui_src/pages/vehicle.yaml

@@ -101,21 +101,6 @@ sections:
     - type: param
       key: ToyotaEnforceStockLongitudinal
       equals: false
-  - key: ToyotaEnhancedBsm
-    widget: toggle
-    needs_onroad_cycle: true
-    title: Enhanced Blind Spot Monitoring (Alpha)
-    description: sunnypilot will poll the blind spot monitor diagnostics directly from the radar. Use this on vehicles whose
-      blind spot monitors do not report blind spot status over the standard CAN signals. This is an alpha feature. Use at
-      your own risk.
-    enablement:
-    - $ref: '#/macros/not_engaged'
-    - type: capability
-      field: toyota_enhanced_bsm_available
-      equals: true
-    - type: capability
-      field: stock_longitudinal
-      equals: false
   - key: ToyotaTSS2Smooth
     widget: toggle
     needs_onroad_cycle: true

openpilot/sunnypilot/sunnylink/settings_ui_src/pages/visuals.yaml

@@ -39,10 +39,6 @@ sections:
     description: Show a timer on the HUD when the car is at a standstill.
     visibility:
     - $ref: '#/macros/hide_on_mici'
-  - key: TripSummary
-    widget: toggle
-    title: Trip Summary
-    description: Show a summary of distance and engagement when you shift into park after a drive.
   - key: RocketFuel
     widget: toggle
     title: Real-time Acceleration Bar

openpilot/sunnypilot/sunnylink/tests/test_capabilities.py

@@ -70,18 +70,12 @@ class TestOpaquePerBrandFlags(OpenpilotTestCase):
   def test_hyundai_alpha_long_available_field_present(self):
     assert "hyundai_alpha_long_available" in CAPABILITY_FIELDS
 
-  def test_toyota_enhanced_bsm_available_field_present(self):
-    assert "toyota_enhanced_bsm_available" in CAPABILITY_FIELDS
-
   def test_subaru_has_sng_default_false(self, caps):
     assert caps["subaru_has_sng"] is False
 
   def test_hyundai_alpha_long_available_default_false(self, caps):
     assert caps["hyundai_alpha_long_available"] is False
 
-  def test_toyota_enhanced_bsm_available_default_false(self, caps):
-    assert caps["toyota_enhanced_bsm_available"] is False
-
   def test_toyota_tss2_field_present(self):
     assert "toyota_tss2" in CAPABILITY_FIELDS
 

openpilot/sunnypilot/sunnylink/tests/test_settings_changes.py

@@ -207,7 +207,6 @@ class TestNotEngagedReplacement(OpenpilotTestCase):
     "AlphaLongitudinalEnabled",
     "ToyotaEnforceStockLongitudinal",
     "ToyotaStopAndGoHack",
-    "ToyotaEnhancedBsm",
     "ToyotaTSS2Smooth",
   ], names=["key"])
   def test_offroad_only_replaced_with_not_engaged(self, schema, key):

openpilot/sunnypilot/sunnylink/tests/test_settings_schema.py

@@ -286,7 +286,6 @@ class TestKnownVehicleSettings(OpenpilotTestCase):
     keys = {i["key"] for i in _brand_items(schema["vehicle_settings"].get("toyota"))}
     assert "ToyotaEnforceStockLongitudinal" in keys
     assert "ToyotaStopAndGoHack" in keys
-    assert "ToyotaEnhancedBsm" in keys
     assert "ToyotaTSS2Smooth" in keys
 
   def test_tesla_has_coop_steering(self, schema):