sunny said to split it, now he is going to say make separate pr... coming up

cereal/custom.capnp

@@ -150,6 +150,7 @@ struct LongitudinalPlanSP @0xf35cc4560bbf6ec2 {
   aTarget @5 :Float32;
   events @6 :List(OnroadEventSP.Event);
   e2eAlerts @7 :E2eAlerts;
+  accelPersonality @8 :AccelerationPersonality;
 
   struct DynamicExperimentalControl {
     state @0 :DynamicExperimentalControlState;
@@ -252,6 +253,11 @@ struct LongitudinalPlanSP @0xf35cc4560bbf6ec2 {
     greenLightAlert @0 :Bool;
     leadDepartAlert @1 :Bool;
   }
+  enum AccelerationPersonality {
+    sport @0;
+    normal @1;
+    eco @2;
+  }
 }
 
 struct OnroadEventSP @0xda96579883444c35 {

common/params_keys.h

@@ -130,6 +130,7 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"Version", {PERSISTENT, STRING}},
 
     // --- sunnypilot params --- //
+    {"AccelPersonality", {PERSISTENT | BACKUP, INT, std::to_string(static_cast<int>(cereal::LongitudinalPlanSP::AccelerationPersonality::NORMAL))}},
     {"ApiCache_DriveStats", {PERSISTENT, JSON}},
     {"AutoLaneChangeBsmDelay", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"AutoLaneChangeTimer", {PERSISTENT | BACKUP, INT, "0"}},
@@ -171,6 +172,9 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"ShowTurnSignals", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"StandstillTimer", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"TrueVEgoUI", {PERSISTENT | BACKUP, BOOL, "0"}},
+    {"VibePersonalityEnabled", {PERSISTENT | BACKUP, BOOL, "0"}},
+    {"VibeAccelPersonalityEnabled", {PERSISTENT | BACKUP, BOOL, "0"}},
+    {"VibeFollowPersonalityEnabled", {PERSISTENT | BACKUP, BOOL, "0"}},
 
     // MADS params
     {"Mads", {PERSISTENT | BACKUP, BOOL, "1"}},

selfdrive/controls/lib/longitudinal_mpc_lib/long_mpc.py

@@ -10,6 +10,8 @@ from openpilot.common.swaglog import cloudlog
 from openpilot.selfdrive.modeld.constants import index_function
 from openpilot.selfdrive.controls.radard import _LEAD_ACCEL_TAU
 
+from openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.vibe_personality import VibePersonalityController
+
 if __name__ == '__main__':  # generating code
   from openpilot.third_party.acados.acados_template import AcadosModel, AcadosOcp, AcadosOcpSolver
 else:
@@ -228,6 +230,7 @@ class LongitudinalMpc:
     self.solver = AcadosOcpSolverCython(MODEL_NAME, ACADOS_SOLVER_TYPE, N)
     self.reset()
     self.source = SOURCES[2]
+    self.vibe_controller = VibePersonalityController()
 
   def reset(self):
     # self.solver = AcadosOcpSolverCython(MODEL_NAME, ACADOS_SOLVER_TYPE, N)
@@ -328,10 +331,18 @@ class LongitudinalMpc:
     return lead_xv
 
   def update(self, radarstate, v_cruise, x, v, a, j, personality=log.LongitudinalPersonality.standard):
-    t_follow = get_T_FOLLOW(personality)
     v_ego = self.x0[1]
+
+    # Get following distance
+    t_follow_vibe = self.vibe_controller.get_follow_distance_multiplier(v_ego)
+    t_follow = t_follow_vibe if t_follow_vibe is not None else get_T_FOLLOW(personality)
+
     self.status = radarstate.leadOne.status or radarstate.leadTwo.status
 
+    # Get acceleration limits
+    accel_limits = self.vibe_controller.get_accel_limits(v_ego)
+    a_cruise_min = accel_limits[0] if accel_limits is not None else CRUISE_MIN_ACCEL
+
     lead_xv_0 = self.process_lead(radarstate.leadOne)
     lead_xv_1 = self.process_lead(radarstate.leadTwo)
 
@@ -350,7 +361,7 @@ class LongitudinalMpc:
 
       # Fake an obstacle for cruise, this ensures smooth acceleration to set speed
       # when the leads are no factor.
-      v_lower = v_ego + (T_IDXS * CRUISE_MIN_ACCEL * 1.05)
+      v_lower = v_ego + (T_IDXS * a_cruise_min * 1.05)
       # TODO does this make sense when max_a is negative?
       v_upper = v_ego + (T_IDXS * CRUISE_MAX_ACCEL * 1.05)
       v_cruise_clipped = np.clip(v_cruise * np.ones(N+1),
@@ -405,7 +416,7 @@ class LongitudinalMpc:
       if any((lead_0_obstacle - get_safe_obstacle_distance(self.x_sol[:,1], t_follow))- self.x_sol[:,0] < 0.0):
         self.source = 'lead0'
       if any((lead_1_obstacle - get_safe_obstacle_distance(self.x_sol[:,1], t_follow))- self.x_sol[:,0] < 0.0) and \
-         (lead_1_obstacle[0] - lead_0_obstacle[0]):
+            (lead_1_obstacle[0] - lead_0_obstacle[0]):
         self.source = 'lead1'
 
   def run(self):

selfdrive/controls/lib/longitudinal_planner.py

@@ -124,7 +124,11 @@ class LongitudinalPlanner(LongitudinalPlannerSP):
     prev_accel_constraint = not (reset_state or sm['carState'].standstill)
 
     if mode == 'acc':
-      accel_clip = [ACCEL_MIN, get_max_accel(v_ego)]
+      accel_limits = self.vibe_controller.get_accel_limits(v_ego)
+      if accel_limits is not None:
+        accel_clip = [ACCEL_MIN, accel_limits[1]]
+      else:
+        accel_clip = [ACCEL_MIN, get_max_accel(v_ego)]
       steer_angle_without_offset = sm['carState'].steeringAngleDeg - sm['liveParameters'].angleOffsetDeg
       accel_clip = limit_accel_in_turns(v_ego, steer_angle_without_offset, accel_clip, self.CP)
     else:

selfdrive/ui/qt/offroad/settings.cc

@@ -92,7 +92,15 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
                                              "your steering wheel distance button."),
                                           "../assets/icons/speed_limit.png",
                                           longi_button_texts);
-
+  // accel controller
+  std::vector<QString> accel_personality_texts{tr("Sport"), tr("Normal"), tr("Eco")};
+  accel_personality_setting = new ButtonParamControlSP("AccelPersonality", tr("Acceleration Personality"),
+                                          tr("Normal is recommended. In sport mode, sunnypilot will provide aggressive acceleration for a dynamic driving experience. "
+                                             "In eco mode, sunnypilot will apply smoother and more relaxed acceleration. On supported cars, you can cycle through these "
+                                             "acceleration personality within Onroad Settings on the driving screen."),
+                                          "",
+                                          accel_personality_texts);
+  accel_personality_setting->showDescription();
   // set up uiState update for personality setting
   QObject::connect(uiState(), &UIState::uiUpdate, this, &TogglesPanel::updateState);
 
@@ -120,6 +128,7 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
     // insert longitudinal personality after NDOG toggle
     if (param == "DisengageOnAccelerator") {
       addItem(long_personality_setting);
+      addItem(accel_personality_setting);
     }
   }
 
@@ -140,6 +149,13 @@ void TogglesPanel::updateState(const UIState &s) {
     }
     uiState()->scene.personality = personality;
   }
+  if (sm.updated("longitudinalPlanSP")) {
+    auto accel_personality = sm["longitudinalPlanSP"].getLongitudinalPlanSP().getAccelPersonality();
+    if (accel_personality != s.scene.accel_personality && s.scene.started && isVisible()) {
+      accel_personality_setting->setCheckedButton(static_cast<int>(accel_personality));
+    }
+    uiState()->scene.accel_personality = accel_personality;
+  }
 }
 
 void TogglesPanel::expandToggleDescription(const QString &param) {
@@ -186,10 +202,12 @@ void TogglesPanel::updateToggles() {
       experimental_mode_toggle->setEnabled(true);
       experimental_mode_toggle->setDescription(e2e_description);
       long_personality_setting->setEnabled(true);
+      accel_personality_setting->setEnabled(true);
     } else {
       // no long for now
       experimental_mode_toggle->setEnabled(false);
       long_personality_setting->setEnabled(false);
+      accel_personality_setting->setEnabled(true);
       params.remove("ExperimentalMode");
 
       const QString unavailable = tr("Experimental mode is currently unavailable on this car since the car's stock ACC is used for longitudinal control.");

selfdrive/ui/qt/offroad/settings.h

@@ -88,6 +88,7 @@ protected:
   Params params;
   std::map<std::string, ParamControl*> toggles;
   ButtonParamControl *long_personality_setting;
+  ButtonParamControl *accel_personality_setting;
 
   virtual void updateToggles();
 };

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal_panel.cc

@@ -75,6 +75,35 @@ LongitudinalPanel::LongitudinalPanel(QWidget *parent) : QWidget(parent) {
     main_layout->setCurrentWidget(cruisePanelScreen);
   });
 
+
+  // Vibe Personality Controller
+  vibePersonalityControl = new ParamControlSP("VibePersonalityEnabled",
+    tr("Vibe Personality Controller"),
+    tr("Advanced driving personality system with separate controls for acceleration behavior (Eco/Normal/Sport) and following distance/braking (Relaxed/Standard/Aggressive). "
+      "Customize your driving experience with independent acceleration and distance personalities."),
+    "../assets/offroad/icon_shell.png");
+  list->addItem(vibePersonalityControl);
+
+  connect(vibePersonalityControl, &ParamControlSP::toggleFlipped, [=]() {
+    refresh(offroad);
+  });
+
+  // Vibe Acceleration Personality
+  vibeAccelPersonalityControl = new ParamControlSP("VibeAccelPersonalityEnabled",
+    tr("Acceleration Personality"),
+    tr("Controls acceleration behavior: Eco (efficient), Normal (balanced), Sport (responsive). "
+      "Adjust how aggressively the vehicle accelerates while maintaining smooth operation."),
+    "../assets/offroad/icon_shell.png");
+  list->addItem(vibeAccelPersonalityControl);
+
+  // Vibe Following Distance Personality
+  vibeFollowPersonalityControl = new ParamControlSP("VibeFollowPersonalityEnabled",
+    tr("Following Distance Personality"),
+    tr("Controls following distance and braking behavior: Relaxed (longer distance, gentler braking), Standard (balanced), Aggressive (shorter distance, firmer braking). "
+      "Fine-tune your comfort level in traffic situations."),
+    "../assets/offroad/icon_shell.png");
+  list->addItem(vibeFollowPersonalityControl);
+
   main_layout->addWidget(cruisePanelScreen);
   main_layout->addWidget(speedLimitScreen);
   main_layout->setCurrentWidget(cruisePanelScreen);
@@ -135,6 +164,14 @@ void LongitudinalPanel::refresh(bool _offroad) {
       intelligentCruiseButtonManagement->toggleFlipped(false);
     }
   }
+  bool vibePersonalityEnabled = params.getBool("VibePersonalityEnabled");
+  if (vibePersonalityEnabled) {
+    vibeAccelPersonalityControl->setVisible(true);
+    vibeFollowPersonalityControl->setVisible(true);
+  } else {
+    vibeAccelPersonalityControl->setVisible(false);
+    vibeFollowPersonalityControl->setVisible(false);
+  }
 
   bool icbm_allowed = intelligent_cruise_button_management_available && !has_longitudinal_control;
   intelligentCruiseButtonManagement->setEnabled(icbm_allowed && offroad);
@@ -146,6 +183,13 @@ void LongitudinalPanel::refresh(bool _offroad) {
 
   SmartCruiseControlVision->setEnabled(has_longitudinal_control || icbm_allowed);
   SmartCruiseControlMap->setEnabled(has_longitudinal_control || icbm_allowed);
+  // Vibe Personality controls - always enabled for toggling
+  vibePersonalityControl->setEnabled(true);
+  vibeAccelPersonalityControl->setEnabled(true);
+  vibeFollowPersonalityControl->setEnabled(true);
+  vibePersonalityControl->refresh();
+  vibeAccelPersonalityControl->refresh();
+  vibeFollowPersonalityControl->refresh();
 
   offroad = _offroad;
 }

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal_panel.h

@@ -37,4 +37,8 @@ private:
   ParamControl *intelligentCruiseButtonManagement = nullptr;
   SpeedLimitSettings *speedLimitScreen;
   PushButtonSP *speedLimitSettings;
+
+  ParamControlSP *vibePersonalityControl;
+  ParamControlSP *vibeAccelPersonalityControl;
+  ParamControlSP *vibeFollowPersonalityControl;
 };

selfdrive/ui/ui.h

@@ -60,6 +60,7 @@ typedef struct UIScene {
   cereal::PandaState::PandaType pandaType;
 
   cereal::LongitudinalPersonality personality;
+  cereal::LongitudinalPlanSP::AccelerationPersonality accel_personality;
 
   float light_sensor = -1;
   bool started, ignition, is_metric, recording_audio;

sunnypilot/selfdrive/controls/lib/longitudinal_planner.py

@@ -17,6 +17,7 @@ from openpilot.sunnypilot.selfdrive.controls.lib.speed_limit.speed_limit_resolve
 from openpilot.sunnypilot.selfdrive.selfdrived.events import EventsSP
 from openpilot.sunnypilot.models.helpers import get_active_bundle
 
+from openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.vibe_personality import VibePersonalityController
 DecState = custom.LongitudinalPlanSP.DynamicExperimentalControl.DynamicExperimentalControlState
 LongitudinalPlanSource = custom.LongitudinalPlanSP.LongitudinalPlanSource
 
@@ -29,6 +30,7 @@ class LongitudinalPlannerSP:
     self.scc = SmartCruiseControl()
     self.resolver = SpeedLimitResolver()
     self.sla = SpeedLimitAssist(CP)
+    self.vibe_controller = VibePersonalityController()
     self.generation = int(model_bundle.generation) if (model_bundle := get_active_bundle()) else None
     self.source = LongitudinalPlanSource.cruise
     self.e2e_alerts_helper = E2EAlertsHelper()
@@ -81,6 +83,7 @@ class LongitudinalPlannerSP:
     self.events_sp.clear()
     self.dec.update(sm)
     self.e2e_alerts_helper.update(sm, self.events_sp)
+    self.vibe_controller.update()
 
   def publish_longitudinal_plan_sp(self, sm: messaging.SubMaster, pm: messaging.PubMaster) -> None:
     plan_sp_send = messaging.new_message('longitudinalPlanSP')

sunnypilot/selfdrive/controls/lib/vibe_personality/accel_personality.py

@@ -0,0 +1,74 @@
+"""
+Copyright (c) 2021-, rav4kumar, Haibin Wen, sunnypilot, and a number of other contributors.
+
+This file is part of sunnypilot and is licensed under the MIT License.
+See the LICENSE.md file in the root directory for more details.
+"""
+
+from cereal import log, custom
+import numpy as np
+from openpilot.common.realtime import DT_MDL
+from openpilot.common.params import Params
+
+LongPersonality = log.LongitudinalPersonality
+AccelPersonality = custom.LongitudinalPlanSP.AccelerationPersonality
+
+MAX_ACCEL_PROFILES = {
+  AccelPersonality.eco:       [2.0,  1.99,  1.88, 1.10, .500, .292, .15, .10],
+  AccelPersonality.normal:    [2.0,  2.00,  1.94, 1.22, .635, .33, .20, .16],
+  AccelPersonality.sport:     [2.0,  2.00,  2.00, 1.85, .800, .54, .32, .22],
+}
+MAX_ACCEL_BREAKPOINTS = [0., 4., 6., 9., 16., 25., 30., 55.]
+
+MIN_ACCEL_PROFILES = {
+  LongPersonality.relaxed:    [-.0007, -.0007, -.07, -1.00, -1.00],
+  LongPersonality.standard:   [-.0007, -.0007, -.08, -1.10, -1.10],
+  LongPersonality.aggressive: [-.0006, -.0007, -.09, -1.20, -1.20],
+}
+MIN_ACCEL_BREAKPOINTS = [0., 3.0, 11., 22., 50.]
+
+
+class AccelPersonalityController:
+  def __init__(self):
+    self.params = Params()
+    self.frame = 0
+    self.accel_personality = AccelPersonality.normal
+    self.long_personality = LongPersonality.standard
+
+  def _update_from_params(self):
+    if self.frame % int(1. / DT_MDL) != 0:
+      return
+    accel_bytes = self.params.get('AccelPersonality')
+    if accel_bytes:
+      self.accel_personality = int(accel_bytes)
+    long_bytes = self.params.get('LongitudinalPersonality')
+    if long_bytes:
+      self.long_personality = int(long_bytes)
+
+  def is_enabled(self) -> bool:
+    return self.params.get_bool('VibeAccelPersonalityEnabled') or False
+
+  def set_accel_personality(self, personality: int) -> bool:
+    if personality not in [AccelPersonality.eco, AccelPersonality.normal, AccelPersonality.sport]:
+      return False
+    self.accel_personality = personality
+    self.params.put('AccelPersonality', str(personality))
+    return True
+
+  def cycle_accel_personality(self) -> int:
+    personalities = [AccelPersonality.eco, AccelPersonality.normal, AccelPersonality.sport]
+    idx = personalities.index(self.accel_personality)
+    next_p = personalities[(idx + 1) % len(personalities)]
+    self.set_accel_personality(next_p)
+    return int(next_p)
+
+  def get_accel_limits(self, v_ego: float) -> tuple[float, float] | None:
+    if not self.is_enabled():
+      return None
+    self._update_from_params()
+    max_a = np.interp(v_ego, MAX_ACCEL_BREAKPOINTS, MAX_ACCEL_PROFILES[self.accel_personality])
+    min_a = np.interp(v_ego, MIN_ACCEL_BREAKPOINTS, MIN_ACCEL_PROFILES[self.long_personality])
+    return float(min_a), float(max_a)
+
+  def update(self):
+    self.frame += 1

sunnypilot/selfdrive/controls/lib/vibe_personality/follow_personality.py

@@ -0,0 +1,46 @@
+"""
+Copyright (c) 2021-, rav4kumar, Haibin Wen, sunnypilot, and a number of other contributors.
+
+This file is part of sunnypilot and is licensed under the MIT License.
+See the LICENSE.md file in the root directory for more details.
+"""
+
+from cereal import log
+import numpy as np
+from openpilot.common.realtime import DT_MDL
+from openpilot.common.params import Params
+
+LongPersonality = log.LongitudinalPersonality
+
+FOLLOW_PROFILES = {
+  LongPersonality.relaxed:    [1.55, 1.65, 1.65, 1.80, 1.80],
+  LongPersonality.standard:   [1.35, 1.45, 1.45, 1.55, 1.55],
+  LongPersonality.aggressive: [1.05, 1.10, 1.10, 1.25, 1.35],
+}
+FOLLOW_BREAKPOINTS = [0., 6., 18., 20., 36.]
+
+
+class FollowPersonalityController:
+  def __init__(self):
+    self.params = Params()
+    self.frame = 0
+    self.long_personality = LongPersonality.standard
+
+  def _update_from_params(self):
+    if self.frame % int(1. / DT_MDL) != 0:
+      return
+    long_bytes = self.params.get('LongitudinalPersonality')
+    if long_bytes:
+      self.long_personality = int(long_bytes)
+
+  def is_enabled(self) -> bool:
+    return self.params.get_bool('VibeFollowPersonalityEnabled') or False
+
+  def get_follow_distance_multiplier(self, v_ego: float) -> float | None:
+    if not self.is_enabled():
+      return None
+    self._update_from_params()
+    return float(np.interp(v_ego, FOLLOW_BREAKPOINTS, FOLLOW_PROFILES[self.long_personality]))
+
+  def update(self):
+    self.frame += 1

sunnypilot/selfdrive/controls/lib/vibe_personality/tests/test_vibe.py

@@ -0,0 +1,314 @@
+import pytest
+
+# Import the actual modules
+from cereal import log, custom
+from openpilot.common.realtime import DT_MDL
+
+# Import the enums we need for testing
+LongPersonality = log.LongitudinalPersonality
+AccelPersonality = custom.LongitudinalPlanSP.AccelerationPersonality
+
+
+class MockParams:
+  """Simple mock for Params class"""
+  def __init__(self):
+    self.data = {}
+    self.bool_data = {
+      'VibePersonalityEnabled': True,
+      'VibeAccelPersonalityEnabled': True,
+      'VibeFollowPersonalityEnabled': True
+    }
+
+  def get(self, key, encoding=None):
+    return self.data.get(key)
+
+  def get_bool(self, key):
+    return self.bool_data.get(key, True)
+
+  def put(self, key, value):
+    self.data[key] = value
+
+  def put_bool(self, key, value):
+    self.bool_data[key] = value
+
+  def reset_mock(self):
+    self.call_count = 0
+
+  @property
+  def call_count(self):
+    return getattr(self, '_call_count', 0)
+
+  @call_count.setter
+  def call_count(self, value):
+    self._call_count = value
+
+
+@pytest.fixture
+def mock_params():
+  """Create mock params instance"""
+  return MockParams()
+
+
+@pytest.fixture
+def controller(mock_params, monkeypatch):
+  """Create controller instance with mocked Params"""
+  # Patch the Params import in the controller module
+  monkeypatch.setattr('openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.vibe_personality.Params',
+                      lambda: mock_params)
+
+  from openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.vibe_personality import VibePersonalityController
+  return VibePersonalityController()
+
+
+class TestVibePersonalityController:
+
+  def test_initialization(self, controller):
+    """Test controller initializes with correct defaults"""
+    assert controller.frame == 0
+    assert controller.accel_personality == AccelPersonality.normal
+    assert controller.long_personality == LongPersonality.standard
+    assert 'accel_personality' in controller.param_keys
+    assert 'long_personality' in controller.param_keys
+
+  def test_frame_increment(self, controller):
+    """Test frame counter increments correctly"""
+    initial_frame = controller.frame
+    controller.update()
+    assert controller.frame == initial_frame + 1
+
+    controller.update()
+    assert controller.frame == initial_frame + 2
+
+  def test_parameter_reading_throttled(self, controller, mock_params):
+    """Test parameters are only read every DT_MDL frames"""
+    # Track calls manually
+    original_get = mock_params.get
+    call_count = 0
+
+    def counting_get(*args, **kwargs):
+      nonlocal call_count
+      call_count += 1
+      return original_get(*args, **kwargs)
+
+    mock_params.get = counting_get
+
+    # First call should read params (frame 0)
+    controller._update_from_params()
+
+    # Reset counter
+    call_count = 0
+
+    # Advance frame but not to threshold
+    controller.frame = 5  # Less than int(1/DT_MDL)
+    controller._update_from_params()
+    assert call_count == 0  # Should not read params
+
+    # Advance to threshold
+    controller.frame = int(1. / DT_MDL)  # Equal to threshold
+    controller._update_from_params()
+    assert call_count >= 2  # Should read both personality params
+
+  def test_accel_personality_management(self, controller, mock_params):
+    """Test acceleration personality setting and cycling"""
+    # Test setting valid personality
+    assert controller.set_accel_personality(AccelPersonality.eco)
+    assert controller.accel_personality == AccelPersonality.eco
+
+    assert controller.set_accel_personality(AccelPersonality.sport)
+    assert controller.accel_personality == AccelPersonality.sport
+
+    # Test setting invalid personality
+    assert not controller.set_accel_personality(999)
+    assert controller.accel_personality == AccelPersonality.sport  # Should remain unchanged
+
+    # Test cycling
+    controller.accel_personality = AccelPersonality.eco
+    next_personality = controller.cycle_accel_personality()
+    assert next_personality == AccelPersonality.normal  # should cycle to normal
+    assert controller.accel_personality == AccelPersonality.normal
+
+    next_personality = controller.cycle_accel_personality()
+    assert next_personality == AccelPersonality.sport  # should cycle to sport
+
+    next_personality = controller.cycle_accel_personality()
+    assert next_personality == AccelPersonality.eco  # should cycle back to eco
+
+  def test_long_personality_management(self, controller, mock_params):
+    """Test longitudinal personality setting and cycling"""
+    # Test setting valid personality
+    assert controller.set_long_personality(LongPersonality.relaxed)
+    assert controller.long_personality == LongPersonality.relaxed
+
+    assert controller.set_long_personality(LongPersonality.aggressive)
+    assert controller.long_personality == LongPersonality.aggressive
+
+    # Test setting invalid personality
+    assert not controller.set_long_personality(999)
+    assert controller.long_personality == LongPersonality.aggressive  # Should remain unchanged
+
+    # Test cycling
+    controller.long_personality = LongPersonality.standard
+    next_personality = controller.cycle_long_personality()
+    assert next_personality == LongPersonality.aggressive  # should cycle to aggressive
+    assert controller.long_personality == LongPersonality.aggressive
+
+    next_personality = controller.cycle_long_personality()
+    assert next_personality == LongPersonality.relaxed  # should cycle to relaxed
+
+    next_personality = controller.cycle_long_personality()
+    assert next_personality == LongPersonality.standard  # should cycle back to standard
+
+  def test_toggle_functions(self, controller, mock_params):
+    """Test toggle functionality"""
+    # Set initial state to False
+    mock_params.bool_data['VibePersonalityEnabled'] = False
+
+    result = controller.toggle_personality()
+    assert result  # Should toggle to True
+    assert mock_params.bool_data['VibePersonalityEnabled']
+
+    # Set initial state to True
+    mock_params.bool_data['VibeAccelPersonalityEnabled'] = True
+
+    result = controller.toggle_accel_personality()
+    assert not result  # Should toggle to False
+    assert not mock_params.bool_data['VibeAccelPersonalityEnabled']
+
+  def test_enable_checks(self, controller, mock_params):
+    """Test various enable state checks"""
+    # All enabled
+    mock_params.bool_data = {
+      'VibePersonalityEnabled': True,
+      'VibeAccelPersonalityEnabled': True,
+      'VibeFollowPersonalityEnabled': True
+    }
+
+    assert controller.is_enabled()
+    assert controller.is_accel_enabled()
+    assert controller.is_follow_enabled()
+
+    # Main toggle disabled
+    mock_params.bool_data['VibePersonalityEnabled'] = False
+
+    assert not controller.is_enabled()
+    assert not controller.is_accel_enabled()
+    assert not controller.is_follow_enabled()
+
+  def test_accel_limits_calculation(self, controller, mock_params):
+    """Test acceleration limits calculation"""
+    # Enable all features through mock_params bool_data
+    mock_params.bool_data = {
+      'VibePersonalityEnabled': True,
+      'VibeAccelPersonalityEnabled': True,
+      'VibeFollowPersonalityEnabled': True
+    }
+
+    # Test with different speeds and personalities
+    controller.accel_personality = 1  # normal
+    controller.long_personality = 1  # standard
+
+    limits = controller.get_accel_limits(10.0)  # 10 m/s
+    assert limits is not None
+    min_a, max_a = limits
+    assert isinstance(min_a, float)
+    assert isinstance(max_a, float)
+    assert min_a < 0  # Should be negative (braking)
+    assert max_a > 0  # Should be positive (acceleration)
+
+    # Test with disabled controller
+    mock_params.bool_data['VibePersonalityEnabled'] = False
+    limits = controller.get_accel_limits(10.0)
+    assert limits is None
+
+  def test_follow_distance_multiplier(self, controller, mock_params):
+    """Test following distance multiplier calculation"""
+    # Enable controller
+    mock_params.bool_data['VibePersonalityEnabled'] = True
+    mock_params.bool_data['VibeFollowPersonalityEnabled'] = True
+
+    # Test with different speeds and personalities
+    controller.long_personality = LongPersonality.relaxed
+
+    multiplier = controller.get_follow_distance_multiplier(15.0)  # 15 m/s
+    assert multiplier is not None
+    assert isinstance(multiplier, float)
+    assert multiplier > 0
+
+    # Test with different personality - aggressive should have shorter distance
+    controller.long_personality = LongPersonality.aggressive
+    aggressive_multiplier = controller.get_follow_distance_multiplier(15.0)
+    assert aggressive_multiplier is not None
+    assert aggressive_multiplier < multiplier  # Aggressive should have shorter distance
+
+    # Test with disabled controller
+    mock_params.bool_data['VibeFollowPersonalityEnabled'] = False
+    multiplier = controller.get_follow_distance_multiplier(15.0)
+    assert multiplier is None
+
+  def test_personality_differences(self, controller, mock_params):
+    """Test that different personalities actually produce different values"""
+    # Enable controller
+    mock_params.bool_data['VibePersonalityEnabled'] = True
+    mock_params.bool_data['VibeAccelPersonalityEnabled'] = True
+    mock_params.bool_data['VibeFollowPersonalityEnabled'] = True
+
+    # Test acceleration differences - sport should have higher max acceleration than eco
+    controller.accel_personality = AccelPersonality.eco
+    eco_limits = controller.get_accel_limits(20.0)
+
+    controller.accel_personality = AccelPersonality.sport
+    sport_limits = controller.get_accel_limits(20.0)
+
+    assert sport_limits[1] > eco_limits[1]  # Sport should have higher max acceleration
+
+    # Test following distance differences - relaxed should have longer distance than aggressive
+    controller.long_personality = LongPersonality.relaxed
+    relaxed_dist = controller.get_follow_distance_multiplier(20.0)
+
+    controller.long_personality = LongPersonality.aggressive
+    aggressive_dist = controller.get_follow_distance_multiplier(20.0)
+
+    assert relaxed_dist > aggressive_dist  # Relaxed should have longer following distance
+
+  def test_reset(self, controller):
+    """Test reset functionality"""
+    # Change some values
+    controller.accel_personality = AccelPersonality.sport
+    controller.long_personality = LongPersonality.relaxed
+    controller.frame = 100
+
+    # Reset
+    controller.reset()
+
+    # Check defaults are restored
+    assert controller.accel_personality == AccelPersonality.normal
+    assert controller.long_personality == LongPersonality.standard
+    assert controller.frame == 0
+
+  def test_edge_cases(self, controller, mock_params):
+    """Test edge cases and error handling"""
+    # Enable all features
+    mock_params.bool_data = {
+      'VibePersonalityEnabled': True,
+      'VibeAccelPersonalityEnabled': True,
+      'VibeFollowPersonalityEnabled': True
+    }
+
+    # Test with zero speed
+    limits = controller.get_accel_limits(0.0)
+    assert limits is not None
+
+    multiplier = controller.get_follow_distance_multiplier(0.0)
+    assert multiplier is not None
+
+    # Test with very high speed
+    limits = controller.get_accel_limits(100.0)
+    assert limits is not None
+
+    multiplier = controller.get_follow_distance_multiplier(100.0)
+    assert multiplier is not None
+
+    # Test interpolation works correctly
+    low_speed_limits = controller.get_accel_limits(5.0)
+    high_speed_limits = controller.get_accel_limits(50.0)
+    assert low_speed_limits[1] > high_speed_limits[1]  # Max accel should decrease with speed

sunnypilot/selfdrive/controls/lib/vibe_personality/vibe_personality.py

@@ -0,0 +1,81 @@
+"""
+Copyright (c) 2021-, rav4kumar, Haibin Wen, sunnypilot, and a number of other contributors.
+
+This file is part of sunnypilot and is licensed under the MIT License.
+See the LICENSE.md file in the root directory for more details.
+"""
+
+from cereal import log, custom
+from openpilot.common.params import Params
+from openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.accel_personality import AccelPersonalityController
+from openpilot.sunnypilot.selfdrive.controls.lib.vibe_personality.follow_personality import FollowPersonalityController
+
+LongPersonality = log.LongitudinalPersonality
+AccelPersonality = custom.LongitudinalPlanSP.AccelerationPersonality
+
+
+class VibePersonalityController:
+  def __init__(self):
+    self.accel = AccelPersonalityController()
+    self.follow = FollowPersonalityController()
+    self.params = Params()
+
+  @property
+  def frame(self):
+    return self.accel.frame
+
+  @frame.setter
+  def frame(self, value):
+    self.accel.frame = self.follow.frame = value
+
+  @property
+  def accel_personality(self):
+    return self.accel.accel_personality
+
+  @property
+  def long_personality(self):
+    return self.accel.long_personality
+
+  @long_personality.setter
+  def long_personality(self, value):
+    self.accel.long_personality = self.follow.long_personality = value
+
+  def set_accel_personality(self, personality: int) -> bool:
+    return self.accel.set_accel_personality(personality)
+
+  def cycle_accel_personality(self) -> int:
+    return self.accel.cycle_accel_personality()
+
+  def set_long_personality(self, personality: int) -> bool:
+    if personality not in [LongPersonality.relaxed, LongPersonality.standard, LongPersonality.aggressive]:
+      return False
+    self.long_personality = personality
+    self.params.put('LongitudinalPersonality', str(personality))
+    return True
+
+  def cycle_long_personality(self) -> int:
+    personalities = [LongPersonality.relaxed, LongPersonality.standard, LongPersonality.aggressive]
+    idx = personalities.index(self.long_personality)
+    next_p = personalities[(idx + 1) % len(personalities)]
+    self.set_long_personality(next_p)
+    return int(next_p)
+
+  def is_enabled(self) -> bool:
+    main_enabled = self.params.get_bool('VibePersonalityEnabled') or False
+    return main_enabled and (self.accel.is_enabled() or self.follow.is_enabled())
+
+  def get_accel_limits(self, v_ego: float) -> tuple[float, float] | None:
+    main_enabled = self.params.get_bool('VibePersonalityEnabled') or False
+    if not (main_enabled and self.accel.is_enabled()):
+      return None
+    return self.accel.get_accel_limits(v_ego)
+
+  def get_follow_distance_multiplier(self, v_ego: float) -> float | None:
+    main_enabled = self.params.get_bool('VibePersonalityEnabled') or False
+    if not (main_enabled and self.follow.is_enabled()):
+      return None
+    return self.follow.get_follow_distance_multiplier(v_ego)
+
+  def update(self):
+    self.accel.update()
+    self.follow.update()