more

because people be enabling ALL THE UI

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>

.github/workflows/forum-docs.yml

@@ -0,0 +1,46 @@
+name: Publish Docs
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+  workflow_dispatch:
+    inputs:
+      publish:
+        description: 'Set to true to publish to forum'
+        required: false
+        type: boolean
+
+env:
+  DOCS_CATEGORY_ID: 114
+  DOCS_DATA_EXPLORER_QUERY_ID: 2
+  DOCS_TARGET: https://forum.sunnypilot.ai
+  DOCS_API_KEY: ${{ secrets.DISCOURSE_API_KEY }}
+  GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }}
+
+jobs:
+#  dry_run:
+#    runs-on: ubuntu-latest
+#    steps:
+#      - uses: actions/checkout@v4
+#      - uses: ruby/setup-ruby@v1
+#        with:
+#          ruby-version: "3.3"
+#          bundler-cache: true
+#          working-directory: ./release/ci
+#      - run: bundle exec ./sync_docs.rb --dry-run
+#        working-directory: ./release/ci
+
+  publish:
+#    if: github.ref == 'refs/heads/main' || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish == 'true')
+#    needs: dry_run
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.3"
+          bundler-cache: true
+          working-directory: ./release/ci
+      - run: bundle exec ./sync_docs.rb
+        working-directory: ./release/ci

.gitignore

@@ -16,6 +16,7 @@ a.out
 .cache/
 
 /docs_site/
+/docs_sp_site/
 
 *.mp4
 *.dylib

cereal/custom.capnp

@@ -69,6 +69,48 @@ struct LeadData {
 struct SelfdriveStateSP @0x81c2f05a394cf4af {
   mads @0 :ModularAssistiveDrivingSystem;
   intelligentCruiseButtonManagement @1 :IntelligentCruiseButtonManagement;
+
+  enum AudibleAlert {
+    none @0;
+
+    engage @1;
+    disengage @2;
+    refuse @3;
+
+    warningSoft @4;
+    warningImmediate @5;
+
+    prompt @6;
+    promptRepeat @7;
+    promptDistracted @8;
+
+    # unused, these are reserved for upstream events so we don't collide
+    reserved9 @9;
+    reserved10 @10;
+    reserved11 @11;
+    reserved12 @12;
+    reserved13 @13;
+    reserved14 @14;
+    reserved15 @15;
+    reserved16 @16;
+    reserved17 @17;
+    reserved18 @18;
+    reserved19 @19;
+    reserved20 @20;
+    reserved21 @21;
+    reserved22 @22;
+    reserved23 @23;
+    reserved24 @24;
+    reserved25 @25;
+    reserved26 @26;
+    reserved27 @27;
+    reserved28 @28;
+    reserved29 @29;
+    reserved30 @30;
+
+    promptSingleLow @31;
+    promptSingleHigh @32;
+  }
 }
 
 struct ModelManagerSP @0xaedffd8f31e7b55d {
@@ -404,12 +446,12 @@ struct LiveMapDataSP @0xf416ec09499d9d19 {
 
 struct ModelDataV2SP @0xa1680744031fdb2d {
   laneTurnDirection @0 :TurnDirection;
-}
 
-enum TurnDirection {
-  none @0;
-  turnLeft @1;
-  turnRight @2;
+  enum TurnDirection {
+    none @0;
+    turnLeft @1;
+    turnRight @2;
+  }
 }
 
 struct CustomReserved10 @0xcb9fd56c7057593a {

common/params_keys.h

@@ -160,9 +160,9 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"ModelRunnerTypeCache", {CLEAR_ON_ONROAD_TRANSITION, INT}},
     {"OffroadMode", {CLEAR_ON_MANAGER_START, BOOL}},
     {"Offroad_TiciSupport", {CLEAR_ON_MANAGER_START, JSON}},
-    {"OnroadScreenOffBrightness", {PERSISTENT | BACKUP, INT, "100"}},
+    {"OnroadScreenOffBrightness", {PERSISTENT | BACKUP, INT, "0"}},
     {"OnroadScreenOffControl", {PERSISTENT | BACKUP, BOOL}},
-    {"OnroadScreenOffTimer", {PERSISTENT | BACKUP, INT, "0"}},
+    {"OnroadScreenOffTimer", {PERSISTENT | BACKUP, INT, "15"}},
     {"OnroadUploads", {PERSISTENT | BACKUP, BOOL, "1"}},
     {"QuickBootToggle", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"QuietMode", {PERSISTENT | BACKUP, BOOL, "0"}},
@@ -205,6 +205,8 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
 
     // sunnypilot car specific params
     {"HyundaiLongitudinalTuning", {PERSISTENT | BACKUP, INT, "0"}},
+    {"SubaruStopAndGo", {PERSISTENT | BACKUP, BOOL, "0"}},
+    {"SubaruStopAndGoManualParkingBrake", {PERSISTENT | BACKUP, BOOL, "0"}},
 
     {"DynamicExperimentalControl", {PERSISTENT | BACKUP, BOOL, "0"}},
     {"BlindSpot", {PERSISTENT | BACKUP, BOOL, "0"}},

docs_sp/SAFETY.md

@@ -0,0 +1,36 @@
+# Safety
+
+openpilot is an Adaptive Cruise Control (ACC) and Automated Lane Centering (ALC) system.
+Like other ACC and ALC systems, openpilot is a failsafe passive system and it requires the
+driver to be alert and to pay attention at all times.
+
+In order to enforce driver alertness, openpilot includes a driver monitoring feature
+that alerts the driver when distracted.
+
+However, even with an attentive driver, we must make further efforts for the system to be
+safe. We repeat, **driver alertness is necessary, but not sufficient, for openpilot to be
+used safely** and openpilot is provided with no warranty of fitness for any purpose.
+
+openpilot is developed in good faith to be compliant with FMVSS requirements and to follow
+industry standards of safety for Level 2 Driver Assistance Systems. In particular, we observe
+ISO26262 guidelines, including those from [pertinent documents](https://www.nhtsa.gov/sites/nhtsa.dot.gov/files/documents/13498a_812_573_alcsystemreport.pdf)
+released by NHTSA. In addition, we impose strict coding guidelines (like [MISRA C : 2012](https://www.misra.org.uk/what-is-misra/))
+on parts of openpilot that are safety relevant. We also perform software-in-the-loop,
+hardware-in-the-loop and in-vehicle tests before each software release.
+
+Following Hazard and Risk Analysis and FMEA, at a very high level, we have designed openpilot
+ensuring two main safety requirements.
+
+1. The driver must always be capable to immediately retake manual control of the vehicle,
+   by stepping on the brake pedal or by pressing the cancel button.
+2. The vehicle must not alter its trajectory too quickly for the driver to safely
+   react. This means that while the system is engaged, the actuators are constrained
+   to operate within reasonable limits[^1]. 
+
+For additional safety implementation details, refer to [panda safety model](https://github.com/commaai/panda#safety-model). For vehicle specific implementation of the safety concept, refer to [panda/board/safety/](https://github.com/commaai/panda/tree/master/board/safety).
+
+**Extra note**: comma.ai strongly discourages the use of openpilot forks with safety code either missing or
+  not fully meeting the above requirements.
+
+[^1]: For these actuator limits we observe ISO11270 and ISO15622. Lateral limits described there translate to 0.9 seconds of maximum actuation to achieve a 1m lateral deviation. 
+

docs_sp/assets/sp_logo.svg

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:675116a9b50eb713b2266396aff1460eed8263738455b1d49365f48168b4d4f9
+size 1698

docs_sp/branches/definitions.md

@@ -0,0 +1,13 @@
+# Definitions
+
+|     Branch     | Definition | Supported Devices                                                                                                                                                                                                                                 | Description                                                                                                                                                                                                                   | Stability/Readiness |
+|:--------------:|------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---|
+|   `release`    | Release branch | Comma 3X                                                                                                                                                                                                                                          | Stable release branch. After testing on `staging`, updates are pushed here and published publicly.                                                                                                                            | **Ready to Use:** Highly stable, recommended for most users.                                                                                                                                                             |
+|   `staging`    | Staging branch | Comma 3X                                                                                                                                                                                                                                          | Pre-release testing branch. Community feedback is essential to identify issues before public release.                                                                                                                         | **Varied Stability:** Generally stable, but intended for testing before public release.                 |
+|     `dev`      | Development branches | Comma 3X                                                                                                                                                                                                                                          | Experimental branch with the latest features and bug fixes brought in manually. Expect bugs and braking changes.                                                                                                              | **Experimental:** Least stable, suitable for testers and developers.                                    |
+|    `master`    | Primary development branch | Comma 3X | All Pull Requests are merged here for future releases. CI automatically strips, minifies, and pushes changes to `staging`. Running the `master` branch is suitable for development purposes but not recommended for non-development use. | **For Development Use:** Suitable for developers, may be unstable for general use.                                 |
+| `release-tici` | Release branch | Comma 3                                                                                                                                                                                                                                           | Stable release branch. After testing on `staging-tici`, updates are pushed here and published publicly.                                                                                                                       | **Ready to Use:** Highly stable, recommended for most users.                                                                                                                                                             |
+| `staging-tici` | Staging branch | Comma 3                                                                                                                                                                                                                                           | Pre-release testing branch. Community feedback is essential to identify issues before public release.                                                                                                                         | **Varied Stability:** Generally stable, but intended for testing before public release.                 |
+
+!!! tip
+    Your feedback is invaluable. Testers, even without software development experience, are encourage to run `dev` or `staging` and report issues.

docs_sp/branches/recommended-branches.md

@@ -0,0 +1,17 @@
+# Recommended Branches
+
+=== "Comma 3X"
+    
+    |  Branch   | Installation URL                      | Change Logs                                                                     |
+    |:---------:|-----------------------------------    |---------------------------------------------------------------------------------|
+    | `release` | **Coming Soon**                       | **Coming Soon**                                                                 |
+    | `staging` | [install.sunnypilot.ai/staging]()     | [CHANGELOG](https://github.com/sunnyhaibin/sunnypilot/blob/staging/RELEASES.md) |
+    |   `dev`   | [install.sunnypilot.ai/dev]()         | [CHANGELOG](https://github.com/sunnyhaibin/sunnypilot/blob/dev/RELEASES.md)     |
+
+=== "Comma 3"
+    
+    |  Branch   | Installation URL                              | Change Logs                                                                     |
+    |:---------:|---------------------------------------        |---------------------------------------------------------------------------------|
+    | `release-tici` | **Coming Soon**                          | **Coming Soon**                                                                 |
+    | `staging-tici` | [install.sunnypilot.ai/staging-tici]()   | [CHANGELOG](https://github.com/sunnyhaibin/sunnypilot/blob/staging/RELEASES.md) |
+

docs_sp/community/CONTRIBUTING.md

@@ -0,0 +1,68 @@
+# How to contribute
+
+Our software is open source so you can solve your own problems without needing help from others. And if you solve a problem and are so kind, you can upstream it for the rest of the world to use. Check out our [post about open-sourcing and externalization](https://www.sunnypilot.ai/blog/july/a-new-chapter-transparency/). Development activity is coordinated through our [GitHub Issues](https://github.com/sunnypilot/sunnypilot/issues), [GitHub Discussions](https://github.com/sunnypilot/sunnypilot/discussions), and [Discord](https://discord.sunnypilot.ai).
+
+### Getting Started
+
+* Setup your [development environment](https://github.com/sunnypilot/sunnypilot/tree/master/tools)
+* Read about the [development workflow](WORKFLOW.md)
+* Join our [Discord](https://discord.sunnypilot.ai)
+* Docs are at [https://docs.sunnypilot.ai](https://docs.sunnypilot.ai) and [https://www.sunnypilot.ai/blog](https://www.sunnypilot.ai/blog)
+
+## What contributions are we looking for?
+
+**sunnypilot's priorities are [safety](../SAFETY.md), stability, quality, and features, in that order.** Aligning with comma's ideals, part of sunnypilot's mission is to *solve self-driving cars while delivering shippable intermediaries*, and **all** development is towards that goal.
+
+### What gets merged?
+
+The probability of a pull request being merged is a function of its value to the project and the effort it will take us to get it merged.
+If a PR offers *some* value but will take lots of time to get merged, it will be closed.
+Simple, well-tested bug fixes are the easiest to merge, and new features are the hardest to get merged. 
+
+All of these are examples of good PRs:
+
+* [typo fix](https://github.com/commaai/openpilot/pull/30678)
+* [removing unused code](https://github.com/commaai/openpilot/pull/30573)
+* [simple car model port](https://github.com/commaai/openpilot/pull/30245)
+* [car brand port](https://github.com/commaai/openpilot/pull/23331)
+* [UI design changes](https://github.com/sunnypilot/sunnypilot/commit/84f6fce90639135611ec568c4d39a352a300bede)
+* [new features](https://github.com/sunnypilot/sunnypilot/commit/68e1379003bfdb599921cf9cd5684bfb762fd676)
+
+### What doesn't get merged?
+
+* **arbitrary style changes**: code is art, and it's up to the author to make it beautiful
+* **500+ line PRs**: clean it up, break it up into smaller PRs, or both
+* **PRs without a clear goal**: every PR must have a singular and clear goal
+
+### First contribution
+
+Check out any [good first issue from commaai's openpilot](https://github.com/commaai/openpilot/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) to get started.
+
+### What do I need to contribute?
+
+A lot of sunnypilot work requires only a PC, and some requires a comma device.
+Most car-related contributions require access to that car, plus a comma device installed in the car.
+
+## Pull Requests
+
+Pull requests should be against the [`master`](https://github.com/sunnypilot/sunnypilot) branch. If you're unsure about a contribution, feel free to open a discussion, issue, or draft PR to discuss the problem you're trying to solve.
+
+A good pull request has all of the following:
+
+- a clearly stated purpose
+- every line changed directly contributes to the stated purpose
+- verification, i.e. how did you test your PR?
+- justification
+
+    * if you've optimized something, post benchmarks to prove it's better
+    * if you've improved your car's tuning, post before and after plots
+
+- passes the CI tests
+
+## Contributing without Code
+
+* Report bugs in [GitHub issues](https://github.com/sunnypilot/sunnypilot/issues).
+* Report driving issues in the `#general` Discord channel.
+* Consider opting into driver camera uploads to improve the driver monitoring model.
+* Connect your device to Wi-Fi regularly, so that comma can pull data for training better driving models.
+* Run the `staging-c3` branch and report issues. This branch is like `master` but it's built just like a release.

docs_sp/community/WORKFLOW.md

@@ -0,0 +1,43 @@
+# sunnypilot development workflow
+
+Aside from the ML models, most tools used for sunnypilot development are in this repo.
+
+Most development happens on normal Ubuntu workstations, and not in cars or directly on comma devices. See the [setup guide](https://github.com/sunnypilot/sunnypilot/tree/master/tools) for getting your PC setup for sunnypilot development.
+
+## Quick start
+
+```bash
+# get the latest stuff
+git pull
+git lfs pull
+git submodule update --init --recursive
+
+# update dependencies
+tools/ubuntu_setup.sh
+
+# build everything
+scons -j$(nproc)
+
+# build just the ui with either of these
+scons -j8 selfdrive/ui/
+cd selfdrive/ui/ && scons -u -j8
+
+# test everything
+pytest
+
+# test just logging services
+cd system/loggerd && pytest .
+
+# run the linter
+op lint
+```
+
+## Testing
+
+### Automated Testing
+
+All PRs and commits are automatically checked by GitHub Actions. Check out `.github/workflows/` for what GitHub Actions runs. Any new tests should be added to GitHub Actions.
+
+### Code Style and Linting
+
+Code is automatically checked for style by GitHub Actions as part of the automated tests. You can also run these tests yourself by running `pre-commit run --all`.

docs_sp/community/reporting-a-bug.md

@@ -0,0 +1,274 @@
+# Bug Reports
+
+sunnypilot is an actively maintained project that we constantly strive to improve. With project of this size and complexity, 
+bugs may occur. If you think you have discovered a bug, you can help us by submitting an issue 
+in [comma's public issue tracker][comma's issue tracker], 
+[sunnypilot's public issue tracker][sunnypilot's issue tracker] or on our [Discord][discord], following this guide.
+
+  [comma's issue tracker]: https://github.com/commaai/openpilot/issues
+  [sunnypilot's issue tracker]: https://github.com/sunnypilot/sunnypilot/issues
+  [discord]: https://discord.sunnypilot.ai
+
+## Before creating an issue
+
+With more than 2,500 users, issues are created frequently. The maintainers of this project are trying very hard to keep 
+the number of open issues and reports down by fixing bugs as fast as possible. By following this guide, you will know 
+exactly what information we need to help you quickly.
+
+**But first, please do the following things before creating an issue.**
+
+### Upgrade to the latest version
+
+Chances are that the bug you discovered was already fixed in a subsequent version. Thus, before reporting an issue, 
+ensure that you're running the [latest release version](https://github.com/sunnypilot/sunnypilot/releases) of sunnypilot. 
+Please consult our [installation guide](../setup/read-before-installing.md) to learn how to upgrade to the latest version.
+
+!!! warning "Bug fixes are not backported"
+    Please understand that only bugs that occur in the latest version of sunnypilot will be addressed. Also, to reduce 
+    duplicate efforts, fixes cannot be backported to earlier versions.
+
+### Remove customizations
+
+If you're using customized features, such as your own tweaks of the features, please remove them from the branch 
+you are testing from before reporting a bug. We can't offer official support for bugs that might hide in your implementations, 
+so make sure to omit any customizations from the version being tested.
+
+If, after removing the customizations, the bug is gone, the bug is likely caused by your customizations. A good idea is 
+to add them back gradually to narrow down the root cause of the problem If you did a major version upgrade, make sure 
+you adjusted all customizations you have implemented.
+
+!!! tip
+    If you are an advanced user, you could also utilize `git bisect` 
+    to perform a binary search in the history to find a particular regression.
+
+!!! warning "Customizations mentioned in our documentation"
+    A handful of the features sunnypilot offers can only be implemented with customizations. if you find a bug in any of 
+    the customizations that our documentations explicitly mentioned, you are, of course, encouraged to report it.
+
+**Don't be shy to ask on our [Discord][discord] for help if you run into problems.**
+
+### Search for solutions
+
+At this stage, we know that the problem persists in the latest version and is not caused by any of your customizations. 
+However, the problem might result from a small typo or a syntactical error in the source code, e.g., `selfdrive/car/interfaces.py`.
+
+Now, before you go through the trouble of creating a bug report that is answered and closed right away with a link to
+the relevant documentation section or another already reported or closed issue or discussion, you can save time for us 
+and yourself by doing some research:
+
+1. [Search our documentation] and look for the relevant sections that could be related to your problem. If found, make
+    sure that the settings are configured correctly.
+2. [Search our Discord][discord] to learn if other users are struggling with similar problems and work together with 
+   our 
+   great community towards a solution. Many problems are solved there.
+3. [Search comma's openpilot issue tracker][comma's issue tracker], as another user might 
+   already have reported the same problem that may exist in
+   stock openpilot, and there might even be a known workaround or fix for it. Thus, no need to create a new issue.
+4. [Search sunnypilot's issue tracker][sunnypilot's issue tracker], as another user might already have 
+   reported the same problem, and there
+   might even be a known workaround or fix for it. Thus, no need to create a new issue.
+
+[Search our documentation]: ?q=
+
+**Keep track of all <u>search terms</u> and <u>relevant links</u>, you'll need them in the bug report.**[^1]
+
+  [^1]:
+    We might be using terminology in our documentation different from yours, but we mean the same. When you include the 
+    search terms and related links in your bug report, you help us to adjust and improve the documentation. 
+
+---
+
+At this point, when you still haven't found a solution to your problem, we encourage you to report the issue on our 
+[Discord][discord] because it's now very likely that you stumbled over something we don't know 
+yet. Read the following section 
+to learn how to create a complete and helpful bug report.
+
+## Issue template
+
+We have created an issue template to make the bug reporting process as simple as possible, and more efficient for our
+community and us.
+
+- [Title]
+- [Context]<small>optional</small>
+- [Bug description]
+- [Related links]
+- [Reproduction]
+- [Steps to reproduce]
+- [Checklist]
+
+  [Title]: #title
+  [Context]: #context
+  [Bug description]: #bug-description
+  [Related links]: #related-links
+  [Reproduction]: #reproduction
+  [Steps to reproduce]: #steps-to-reproduce
+  [Checklist]: #checklist
+
+### Title
+
+A good title is short and descriptive. It should be a one-sentence executive summary of the issue, so the impact and
+severity of the bug you want to report can be inferred from the title.
+
+| <!-- --> | Example                                                                                                      |
+| -------- |--------------------------------------------------------------------------------------------------------------|
+| :material-check:{ style="color: #4DB6AC" } __Clear__ | Speed Limit Control (SLC) stuck in `preActive` when engaged                                                  |
+| :material-close:{ style="color: #EF5350" } __Wordy__ | The Speed Limit Control (SLC) remains in the `preActive` state when longitudinal it's supposed to be engaged |
+| :material-close:{ style="color: #EF5350" } __Unclear__ | SLC does not work                                                                                            |
+| :material-close:{ style="color: #EF5350" } __Useless__ | Help                                                                                                         |
+
+### Context <small>optional</small> { #context }
+
+Before describing the bug, you can provide additional context for us to understand what you were trying to achieve.
+Explain the circumstances in which you're using sunnypilot, and what you _think_ might be relevant. Don't write 
+about the bug here.
+
+!!! note "__Why this might be helpful__"
+    Some errors only manifest in specific settings, environments or edge cases, for example, when the feature is not available
+    to certain cars.
+
+### Bug description
+
+Now, to the bug you want to report. Provide a clear, focused, specific, and concise summary of the bug you encountered. 
+Explain why you think this is a bug that should be reported to sunnypilot, and not to one of its dependencies.[^3]
+Adhere to the following principles:
+
+  [^3]:
+    Sometimes, users report bugs on our [sunnypilot's issue tracker] or [Discord][discord] 
+    that are caused by one of our upstream dependencies, including [comma's openpilot], [comma's panda],
+    or other openpilot forks' dependencies. A good rule of thumb is
+    to reproduce the issue with stock openpilot in the same conditions and
+    check if the problem persists. If it does, the problem is likely not
+    related to sunnypilot and should be reported upstream. When in
+    doubt, use our [Discord][discord] to ask for help.
+
+  [comma's openpilot]: https://github.com/commaai/openpilot
+  [comma's panda]: https://github.com/commaai/panda
+
+-   __Explain the <u>what</u>, not the <u>how</u>__ – don't explain
+    [how to reproduce the bug][Steps to reproduce] here, we're getting there.
+    Focus on articulating the problem and its impact as clearly as possible.
+
+-   __Keep it short and concise__ – if the bug can be precisely explained in one
+    or two sentences, perfect. Don't inflate it – maintainers and future users
+    will be grateful for having to read less.
+
+-   __One bug at a time__ – if you encounter several unrelated bugs, please
+    create separate issues for them. Don't report them in the same issue, as
+    this makes attribution difficult.
+
+---
+
+:material-run-fast: __Stretch goal__ – if you found a workaround or a way to fix
+the bug, you can help other users temporarily mitigate the problem before
+we maintainers can fix the bug in our code base.
+
+!!! note "__Why we need this__"
+    In order for us to understand the problem, we need a clear description of it and quantify its impact, which is 
+    essential for triage and prioritization.
+
+### Related links
+
+Of course, prior to reporting a bug, you have read our documentation and
+[could not find a working solution][search for solutions]. Please share links
+to all sections of our documentation that might be relevant to the bug, as it
+helps us gradually improve it.
+
+Additionally, since you have searched [comma's issue tracker], [sunnypilot's issue tracker] or [Discord][discord]
+before reporting an issue, and have possibly found several issues or
+discussions, include those as well. Every link to an issue or discussion creates
+a backlink, guiding us maintainers and other users in the future.
+
+---
+
+:material-run-fast: __Stretch goal__ – if you also include the search terms you
+used when [searching for a solution][search for solutions] to your problem, you
+make it easier for us maintainers to improve the documentation.
+
+  [search for solutions]: #search-for-solutions
+
+### Reproduction
+
+A minimal reproduction is at the heart of every well-written bug report, as
+it allows us maintainers to instantly recreate the necessary conditions to
+inspect the bug to quickly find its root cause. It's a proven fact that issues
+with concise and small reproductions can be fixed much faster.
+
+After you have created the reproduction, take note of your <u>__comma Dongle ID__</u>. It will be used during the bug 
+report.
+
+!!! note "__Why we need this__"
+    If an issue contains no minimal reproduction or just a link to a repository with thousands of files, the 
+    maintainers would need to invest a lot of time into trying to recreate the right conditions to even inspect the 
+    bug, let alone fix it.
+
+!!! warning "Don't share links to repositories"
+    While we know that it is a good practice among developers to include a link
+    to a repository with the bug report, we currently don't support those in our
+    process. The reason is that the reproduction, which is automatically
+    produced by the <u>__route ID__</u> contains all the necessary
+    environment information that is often forgotten to be included.
+
+    Additionally, there are many non-technical users of sunnypilot that
+    have trouble creating repositories.
+
+### Steps to reproduce
+
+At this point, you provided us with enough information to understand the bug
+and provided us with a reproduction that we could run and inspect. However, when
+we check your reproduction, it might not be immediately apparent how we can see
+the bug in action.
+
+Thus, please list the specific steps we should follow when running your
+reproduction to observe the bug. Keep the steps short and concise, and make sure
+not to leave anything out. Use simple language as you would explain it to a
+five-year-old, and focus on continuity.
+
+!!! note "__Why we need this__"
+    We must know how to navigate your reproduction in order
+    to observe the bug, as some bugs only occur at certain viewports or in
+    specific conditions.
+
+### Uploading logs and preserving routes
+
+After reproducing the bug, please follow these steps to upload the necessary logs and preserve the routes.
+
+1. Ensure the route is fully uploaded at [comma Connect]. We cannot look 
+  into issues without routes, or at least a comma Dongle ID.
+
+    1. Visit [comma Connect], select the route with the issue reproduced.
+    2. Under the "Files" button, locate "All logs". Click "Upload x files".
+    3. View the upload queue, and confirm that all raw logs are uploaded.
+
+    !!! note
+        Sometimes when the qlogs of the route are still being uploaded, some raw logs may not be available to 
+        request for upload. Refresh the page a few times once you have confirmed all qlogs have been uploaded, 
+        then try to upload all raw logs again if available.
+
+2. Share your Dongle ID with sunnypilot on [comma Connect].
+
+    1. Visit [comma Connect], navigate to the gear icon.
+    2. Select "Share by email", and enter `support@sunnypilot.ai`.
+    3. Confirm the sharing by clicking the share icon again.
+    4. Set the device name to your vehicle's year/make/model and your Discord username, so it can be easily identified.
+
+3. Once all raw logs are uploaded, click "More info" and enable the "Preserved" option to preserve the route.
+4. Attach the route ID in your issue submission.
+
+  [comma Connect]: https://connect.comma.ai
+
+### Checklist
+
+Thanks for following the guide and creating a high-quality and complete bug
+report – you are almost done. The checklist ensures that you have read this guide
+and have worked to your best knowledge to provide us with everything we need to
+know to help you.
+
+- [ ] I have upgraded to the latest release version of sunnypilot.
+- [ ] I have removed or disable any customizations and confirmed the bug persists.
+- [ ] I have searched the documentation, issue trackers, and Discord for similar issues.
+- [ ] I have created a minimal reproduction and noted my comma Dongle ID.
+- [ ] I have shared my Dongle ID with sunnypilot at `support@sunnypilot.ai`.
+- [ ] I have filled out all required sections of the issue template.
+- [ ] I have followed this guide and ensured all necessary information is included.
+
+__We'll take it from here.__

docs_sp/community/reporting-a-docs-issue.md

@@ -0,0 +1,97 @@
+# Documentation issues
+
+Our documentation is composed of many pages and includes extensive
+information on features, configurations, customizations, and much more. If you
+have found an inconsistency or see room for improvement, please follow this
+guide to submit an issue on our [issue tracker].
+
+  [issue tracker]: https://github.com/sunnypilot/sunnypilot/issues
+
+## Issue template
+
+Reporting a documentation issue is usually less involved than reporting a bug.
+Please thoroughly read this guide before creating a new documentation issue,
+and provide the following information as part of the issue:
+
+- [Title]
+- [Description]
+- [Related links]
+- [Proposed change] <small>optional</small>
+- [Checklist]
+
+  [Title]: #title
+  [Description]: #description
+  [Related links]: #related-links
+  [Proposed change]: #proposed-change
+  [Checklist]: #checklist
+
+### Title
+
+A good title should be a short, one-sentence description of the issue, contain
+all relevant information and, in particular, keywords to simplify the search in
+our issue tracker.
+
+| <!-- --> | Example  |
+| -------- | -------- |
+| :material-check:{ style="color: #4DB6AC" } __Clear__ | Clarify Speed Limit Control engagement
+| :material-close:{ style="color: #EF5350" } __Unclear__ | Missing information in the docs
+| :material-close:{ style="color: #EF5350" } __Useless__ | Help
+
+### Description
+
+Provide a clear and concise summary of the inconsistency or issue you
+encountered in the documentation or the documentation section that needs
+improvement. Explain why you think the documentation should be adjusted and
+describe the severity of the issue:
+
+-   __Keep it short and concise__ – if the inconsistency or issue can be
+    precisely explained in one or two sentences, perfect. Maintainers and future
+    users will be grateful for having to read less.
+
+-   __One issue at a time__ – if you encounter several unrelated inconsistencies,
+    please create separate issues for them. Don't report them in the same issue
+    – it makes attribution difficult.
+
+!!! note "__Why we need this__"
+    Describing the problem clearly and concisely is a prerequisite for improving
+    our documentation – we need to understand what's wrong, so we can fix it.
+
+### Related links
+
+After you described the documentation section that needs to be adjusted above,
+we now ask you to share the link to this specific documentation section and
+other possibly related sections. Make sure to use anchor links (permanent links)
+where possible, as it simplifies discovery.
+
+!!! note "__Why we need this__"
+    Providing the links to the documentation help us understand which sections
+    of our documentation need to be adjusted, extended, or overhauled.
+
+### Proposed change <small>optional</small> { #proposed-change }
+
+Now that you have provided us with the description and links to the
+documentation sections, you can help us, maintainers, and the community by
+proposing an improvement. You can sketch out rough ideas or write a concrete
+proposal. This field is optional but very helpful.
+
+!!! note "__Why we need this__"
+    An improvement proposal can be beneficial for other users who encounter
+    the same issue, as they offer solutions before we maintainers can update
+    the documentation.
+
+### Checklist
+
+Thanks for following the guide and providing valuable feedback for our
+documentation – you are almost done. The checklist ensures that you have read
+this guide and have worked to your best knowledge to provide us with every piece
+of information we need to improve it.
+
+- [ ] I have provided a clear and descriptive title for the documentation issue.
+- [ ] I have summarized the inconsistency or issue concisely in the description.
+- [ ] I have included links to the specific documentation section(s) that need
+      adjustments.
+- [ ] (Optional) I have proposed a change or improvement to the documentation.
+- [ ] I have followed this guide and ensured all necessary information is included.
+
+__We'll take it from here.__
+

docs_sp/features/auto-lane-change.md

@@ -0,0 +1,24 @@
+---
+title: Auto Lane Change
+description: Detailed documentation on the Auto Lane Change feature in sunnypilot.
+---
+
+# Auto Lane Change
+
+sunnypilot's Auto Lane Change feature allows the vehicle to automatically change lanes.
+
+## Key Setting and How to Use
+
+- **Nudge to Confirm:** This is the default method. To perform a lane change, activate the turn signal in the desired direction and then gently turn the steering wheel (nudges) in the same direction to confirm the maneuver.
+- **Nudge-less Lane Change:** For a more automated experience, users can enable a "nudge-less" option. With this setting, you only need to activate the turn signal to initiate a lane-change.
+- **Nudge-less with Delay** This is same as Nudge-less mode, but with a fixed delay. Once the turn-indicator is activated, sunnypilot will wait for the selected delay before initiating the lane change.
+
+### Additional Related Settings
+- **Delay with Blind Spot:** This crucial safety feature adds a delay to the lane change if the vehicle's blind spot monitoring (BSM) system detects an object. The lane change will only proceed after the blind spot is clear.
+
+## Important Considerations
+
+- **Manual Override:** The driver can regain control at any time by taking control of the steering wheel.
+- **Driver Monitoring:** sunnypilot utilizes driver monitoring to ensure the driver remains attentive.
+- **Object Detection:** The system is primarily designed to follow lane lines and may not detect all objects. The driver must always be prepared to take control.
+- **Lane Markings:** The feature's performance is dependent on clear and visible lane markings.

docs_sp/features/custom-acc-increments.md

@@ -0,0 +1,13 @@
+---
+title: Custom ACC Increments
+description: Detailed documentation on the Custom ACC Increments feature in sunnypilot.
+---
+
+# Custom ACC Increments
+
+sunnypilot offers customization to the set speed increments for Adaptive Cruise Control (ACC) when sunnypilot is controlling the vehicle's longitudinal control. This allows for more precise speed adjustments compared to the default behavior of many vehicles.
+
+- **Short press**: This controls the speed adjustment when the "RES+" or "SET-" button is pressed for a short period of time.
+  - Allowed values: 1 through 10
+- **Long press**: This controls the speed adjustment when the "RES+" or "SET-" button is pressed for a longer duration.
+  - Allowed values: 1, 5, 10

docs_sp/features/dynamic-experimental-control.md

@@ -0,0 +1,14 @@
+---
+title: Dynamic Experimental Control
+description: Detailed documentation on the Dynamic Experimental Control feature in sunnypilot.
+---
+
+# Dynamic Experimental Control (DEC)
+
+Dynamic Experimental Control (DEC) intelligently switches between the standard adaptive cruise control (ACC) and the end-to-end longitudinal control of Experimental Mode based on the driving conditions.
+
+**Chill Mode** is the standard adaptive cruise control method. It is designed to provide a smooth, predictable driving experience. However, it does not provide advanced driving capabilities like stopping at red lights and stop signs.
+
+**Experimental Mode** allows the system to control the vehicle's speed and tries to drive like a human, enabling it to slow down for turns, stop at red lights, and stop signs. While capable and experimental, this mode can sometimes be overly cautious, especially on highways.
+
+***Dynamic Experimental Control*** aims to provide the best of both worlds: the advanced capabilities of Experimental Mode when needed, and the smooth, predictable behavior of the standard system for less complex driving scenarios. This allows for a more natural driving experience by using Experimental Mode in situations where it excels, such as city driving and tight turns, while reverting to the default behavior for highway driving.

docs_sp/features/hyundai-longitudinal-tuning.md

@@ -0,0 +1,97 @@
+
+# **How custom longitudinal tuning works for Hyundai/Kia/Genesis vehicles in sunnypilot.**
+
+To begin this documentation, I would like to first present the safety guidelines followed to create the tune:
+
+Our main safety guideline considered is [ISO 15622:2018](https://www.iso.org/obp/ui/en/#iso:std:iso:15622:ed-3:v1:en)
+This provides the groundwork of safety limits this tune must adhere too, and therefore, must be followed.
+For example, in our jerk calculations throughout this tune, you will see how maximum jerk is clipped using the equation provided.
+
+In the tuning you will see a set of equations, the first being jerk, **but what exactly is jerk?**
+Jerk is calculated by taking current acceleration (in the form of m/s^2), subtracting that by previous acceleration, and
+dividing that by time. In our tune you will see the following equation:
+
+    planned_accel = CC.actuators.accel
+    current_accel = CS.out.aEgo
+    blended_value = 0.67 * planned_accel + 0.33 * current_accel
+    delta = blended_value - self.state.accel_last_jerk
+
+    self.state.jerk = math.copysign(delta * delta, delta)
+    self.state.accel_last_jerk = blended_value
+
+Instead of using a hardcoded time, we are focused on making jerk parabolic. First we have our planned acceleration from longitudinal_planner.
+Then we have our current carstate acceleration. These are then blended together 67:33 = 100% to form our blended value.
+Following this, we have our delta which subtracts our blended_value from our previous acceleration `self.state.accel_last_jerk`
+Lastly, we have our finalized jerk calculation, which squares the delta to create a parabolic response while retaining the original sign,
+which could be positive or negative (e.g., 5.0 or -5.0). This then goes through our minimum and maximum clipping
+which forces a value between our set min and max, which I discuss later in this readme.
+
+Moving on, the accel_last_jerk, stores current accel after each iteration and uses that in the calculation as previous accel for
+our jerk calculations. Now we see the calculation of jerk max and jerk min. 
+
+### Let's dive into how jerk lower limit max is calculated:
+
+     velocity = CS.out.vEgo
+    if velocity < 5.0:
+      decel_jerk_max = self.car_config.jerk_limits[1]
+    elif velocity > 20.0:
+      decel_jerk_max = 2.5
+    else:
+      decel_jerk_max = 3.64284 - 0.05714 * velocity
+
+This equation above is set by ISO 15622, and dictates that jerk lower limit can only be five when below 5 m/s. In our equation,
+
+    self.car_config.jerk_limits[1] 
+
+Jerk_limits[1] represents a jerk value of 3.3 m/s^3, which is the maximum analyzed lower jerk rate seen on stock SCC CAN.
+Between 5 m/s and 20 m/s jerk is capped using the calculation:
+
+    decel_jerk_max = 3.64284 - 0.05714 * velocity
+
+This equation calculates the linear jerk from 6m/s to 19m/s, scaling down from 3.3 to 2.5 m/s^3.
+This means that if current velocity is say, 15 m/s the final jerk max value would be capped at 2.78 m/s^3.
+Anything above 20 m/s is capped to a lower jerk max of 2.5 m/s^3. This allows for a smoother jerk range, while complying to ISO standards to a tee.
+The current jerk Lower Limit you will see in openpilot before this tune, is 5.0 m/s^3; Which as you can see from using the above calculation,
+the 5.0 m/s^3 technically does not comply with ISO standards at any speed above 5.0 m/s^3.
+Having our jerk max be clipped to these values not only allows for better consistency with ISO standards, 
+but also enables us to have a much smoother braking experience.
+
+### Getting into our next topic, I would like to explain how our minimum jerk was chosen.
+
+Minimum jerk was chosen based off of the following guideline proposed by Handbook of Intellegent Vehicles (2012):
+`Ride comfort may be sacrificed only under emergency conditions when vehicle and occupant safety consideration may preclude comfort.`
+
+### What the value of 0.53 m/s^3 of the jerk lower limit was chosen based off of
+
+[Carlowitz et al. (2024).](https://www.researchgate.net/publication/382274551_User_evaluation_of_comfortable_deceleration_profiles_for_highly_automated_driving_Findings_from_a_test_track_study)
+This research study identified the average lower jerk used in comfortable driving settings, which is 0.53 m/s^3.
+This is then inputted to jerk_limits[0] as 0.53 m/s^3 represents the value used in upper jerk absolute minimum.
+
+     min_lower_jerk = self.car_config.jerk_limits[0]
+
+As shown above, lower jerk minimum of 0.53 is used for our lower_jerk minimum bounds.
+
+### Why our minimum upper jerk is conditional
+
+Our minimum upper band jerk is conditional as well and is denoted below:
+
+    min_upper_jerk = self.car_config.jerk_limits[0] if (velocity > 3.611) else 0.60
+
+This means that for speeds under 3.611 m/s (8.077 mph/ 13 kph) we have a minimum jerk of 0.60. This allows for smooth
+takeoffs while not causing lag. For all other speeds, we use our normal jerk_limit for minimum, which is 0.53.
+
+### Next, we have our acceleration limiting
+
+For acceleration limiting, we use TCS signal brakeLightsDEPRECATED to measure when to enact the standstill delay 
+which stock SCC uses to allow smoother transitions in acceleration.
+
+### Lastly, we have our accel value calculations for hyundaican.py
+
+For our accel value calculations we have the following:
+
+   `self.accel_value = np.clip(self.accel_raw, self.state.accel_last - jerk_number, self.state.accel_last + jerk_number)`
+
+This essentially means that we have our accel_raw, which is acceleration (m/s^2), followed by our clipping variables. 
+jerk_number in this equation represents exactly `0.1`, which is subtracted or added by self.state.accel_last, which is 
+previous calculated accel_value. Furthermore, we have `self.state.accel_last`, which is calculated as the stored accel from
+the above calculations.

docs_sp/features/icbm.md

@@ -0,0 +1,17 @@
+---
+title: ICBM (Intelligent Cruise Button Management)
+description: Detailed documentation on the ICBM feature in sunnypilot.
+---
+
+# ICBM (Intelligent Cruise Button Management)
+
+Intelligent Cruise Button Management (ICBM) is a system designed to manage the vehicle's cruise control set speed by sending cruise control button commands via CAN bus to the car.
+
+ICBM is particularly useful in vehicles openpilot Longitudinal Control is not available or not desirable to use. By simulating button presses to adjust the stock cruise control set speed, sunnypilot's ICBM can manage the car's speed while keeping native safety features active, such as Forward Collision Warning (FCA) and Automatic Emergency Braking (AEB).
+
+ICBM also allows the vehicle to use the following features:
+
+- **[Smart Cruise Control - Vision (SCC-V)]()**
+- **[Smart Cruise Control - Map (SCC-M)]()**
+- **[Speed Limit Assist (SLA)]()**
+- **[Custom ACC Increments]()**

docs_sp/features/mads.md

@@ -0,0 +1,17 @@
+# Modular Assistive Driving System (M.A.D.S.)
+
+Modular Assistive Driving System (MADS) aims to elevate the user's driving experience by modifying the behaviors of 
+driving assist engagements.
+
+!!! note
+    This feature aligns closely with comma.ai's safety rules.
+
+## Independent Engagement
+
+MADS allows users to engage sunnypilot Automatic Lane Centering (ALC) for lateral control and Adaptive Cruise Control 
+(ACC) or Smart Cruise Control (SCC) for longitudinal control independently.
+
+!!! note "Why This Feature Exists"
+    While newer car models allow for independent engagement of lateral (steering) and longitudinal (speed) control, 
+    many older vehicle models and stock openpilot enforce engaging both controls together. MADS introduces this modern 
+    convenience to older vehicle models, effectively backporting a feature found in newer cars and providing users more flexibility.

docs_sp/features/nnlc.md

@@ -0,0 +1,15 @@
+---
+title: Neural Network Lateral Control (NNLC)
+description: Detailed documentation on the NNLC feature in sunnypilot.
+---
+
+# Neural Network Lateral Control (NNLC)
+
+sunnypilot's Neural Network Lateral Control (NNLC) is a feature that enhances the system's ability to steer a vehicle. It enhances the standard lateral controller with one based on a neural network trained on the vehicle's torque data, aiming for smoother and more precise steering adjustments.
+
+## Key Aspects of NNLC
+
+- **Improved Accuracy:** The neural network is trained using driving data specific to each vehicle, which allows for more accurate control.
+- **Smoother Turns:** NNLC inputs past curvature data into its driving model to achieve smoother and more precise lateral control, especially noticeable when taking curves on a highway. Users report that it reduces the oversteering and understeering corrections.
+
+Formerly known as "NNFF" (Neural Network Feedforward), NNLC aims to make the driving experience feel more natural and less "jittery" in turns.

docs_sp/features/scc-m.md

@@ -0,0 +1,9 @@
+# Smart Cruise Control - Map (SCC-M)
+
+Smart Cruise Control - Map (SCC-M) leverages map data to proactively adjust your vehicle's speed by calculating curvature in the road ahead.
+
+!!! note
+    This feature is only available when sunnypilot is actively controlling the vehicle's longitudinal control.
+
+!!! note
+    This feature requires OpenStreetMap data for the current location to be downloaded.

docs_sp/features/scc-v.md

@@ -0,0 +1,6 @@
+# Smart Cruise Control - Vision (SCC-V)
+
+Smart Cruise Control - Vision (SCC-V) leverages camera vision data to proactively adjust your vehicle's speed by calculating curvature in the road ahead.
+
+!!! note
+    This feature is only available when sunnypilot is actively controlling the vehicle's longitudinal control.

docs_sp/features/speed-limit-assist.md

@@ -0,0 +1,26 @@
+---
+title: Speed Limit Assist
+description: Detailed documentation on the Speed Limit Assist feature in sunnypilot.
+---
+
+# Speed Limit Assist (SLA)
+
+Speed Limit Assist (SLA) is a comprehensive framework in sunnypilot that adjusts the vehicle's set cruise speed according to detected speed limits. It reconciles data from multiple sources to determine the current speed limit.
+
+## Core Functionality
+
+SLA utilizes various data sources to determine the speed limit for the current road:
+
+- **OpenStreetMap (OSM):** Utilizes map data to fetch speed limits. sunnypilot has a refactored OSM implementation for lower resource usage and provides weekly updates.
+- **Car's Stock System:** On some compatible vehicles, it can pull speed limit data directly from the car's native system.
+
+## Key Features and Customization
+
+sunnypilot offers extensive customization for its speed control features:
+
+- **Selectable Speed Limit Source:** Users can define the priority of data sources (e.g., OSM, Navigation, Vision) for determining the speed limit.
+- **Configurable Offsets:** You can set an offset above the detected speed limit, either as a fixed value (e.g., +5 mph) or a percentage.
+- **Engagement Modes:**
+    - **Auto:** Automatically adjusts the cruise speed when a new speed limit is detected.
+    - **User Confirm:** Informs the driver of the new speed limit and waits for them to confirm the change before adjusting the speed.
+- **Alerts and Warnings:** The system provides alerts to inform the driver before a speed adjustment occurs.

docs_sp/getting-started/develop-sunnypilot.md

@@ -0,0 +1,9 @@
+# To start developing sunnypilot
+
+sunnypilot is a fork of [commaai's openpilot](https://github.com/commaai/openpilot), developed by [sunnypilot](https://sunnypilot.ai) and by users like you. 
+We welcome both pull requests and issues on [GitHub](http://github.com/sunnypilot/sunnypilot).
+
+* Join the [community Discord](https://discord.sunnypilot.ai)
+* Check out [the contributing docs](../community/CONTRIBUTING.md)
+* Check out the [openpilot tools](https://github.com/sunnypilot/sunnypilot/tree/master/tools)
+* Read about the [development workflow](../community/WORKFLOW.md)

docs_sp/getting-started/use-sunnypilot-in-a-car.md

@@ -0,0 +1,16 @@
+# To start using sunnypilot in a car
+
+To use sunnypilot in a car, you need four things:
+
+1. **Supported Device:** a comma 3/3X, available at [comma.ai/shop](https://comma.ai/shop/comma-3x).
+
+2. **Software:** The setup procedure for the comma 3/3X allows users to enter a URL for custom software. Use the URL `release-c3.sunnypilot.ai` to install the release version.
+
+3. **Supported Car:** Ensure that you have one of [the 275+ supported cars](https://github.com/sunnypilot/sunnypilot/blob/master/docs/CARS.md).
+
+4. **Car Harness:** You will also need a [car harness](https://comma.ai/shop/car-harness) to connect your comma 3/3X to your car.
+
+[comma.ai](https://comma.ai) have detailed instructions for [how to install the harness and device in a car](https://comma.ai/setup).
+
+!!! note
+    It's possible to run sunnypilot on [other hardware](https://blog.comma.ai/self-driving-car-for-free/), although it's not plug-and-play.

docs_sp/getting-started/what-is-sunnypilot.md

@@ -0,0 +1,11 @@
+# What is sunnypilot?
+
+sunnypilot is a fork of [comma.ai's openpilot](https://github.com/commaai/openpilot), an open source driver assistance system. sunnypilot offers the user a unique driving experience for over 250+ supported car makes and models with modified behaviors of driving assist engagements. sunnypilot complies with comma.ai's safety rules as accurately as possible.
+
+## How do I use it?
+
+sunnypilot is designed to be used on the comma 3/3X.
+
+## How does it work?
+
+In short, sunnypilot uses the car's existing APIs for the built-in [ADAS](https://en.wikipedia.org/wiki/Advanced_driver-assistance_system) system and simply provides better acceleration, braking, and steering inputs than the stock system.

docs_sp/index.md

@@ -0,0 +1,3 @@
+The documentation here is as best-effort sync from the official https://sunnypilot.github.io/ for ease of access and for AI enhancement when users asks on the forum.
+
+

docs_sp/safety-information/prohibited-safety-modifications.md

@@ -0,0 +1,14 @@
+# Prohibited Safety Modifications
+
+All [official sunnypilot branches](https://github.com/sunnyhaibin/sunnypilot/branches) strictly adhere to [comma.ai's safety policy](https://github.com/commaai/openpilot/blob/master/docs/SAFETY.md). Any changes that go against 
+this policy will result in your fork and your device being banned from both comma.ai and sunnypilot channels.
+
+The following changes are **VIOLATIONS** of the safety policy and **ARE NOT** supported in any official sunnypilot branches:
+
+!!! danger "Driver Monitoring"
+    - "Nerfing" or reducing monitoring parameters.
+
+!!! danger "Panda Safety"
+    - No preventing disengaging of <ins>**longitudinal control**</ins> (positive/negative acceleration) on brake pedal press.
+    - No auto re-engaging of <ins>**longitudinal control**</ins> (positive/negative acceleration) on brake pedal release.
+    - No disengaging on `CRUISE MAIN` in `OFF` state.

docs_sp/setup/read-before-installing.md

@@ -0,0 +1,20 @@
+# 🚨 Read Before Installing
+
+It is recommended to read the <u>**entire documentation**</u> before proceeding. This will ensure that you fully understand each added feature in sunnypilot. This also ensures that you are choosing the correct settings and branch for your car to have the best driving experience.
+
+!!! warning
+    By installing this software, you accept all responsibility for anything that might occur while you use it. sunnypilot and all contributors to sunnypilot are not liable.
+
+    **Use at your own risk.**
+
+## Installation
+
+Please refer to the [Recommended Branches](../branches/recommended-branches.md) to find your preferred/supported branch. This guide will assume you want to install the latest `release-c3` branch.
+
+You can install sunnypilot on your comma 3/3X using one of the following methods:
+
+- ### [URL Method (Directly on Device)](url-method.md)
+This method allows you to install sunnypilot directly from your device's screen using a provided URL. It's simple and user-friendly, requiring no additional tools or external devices.
+
+- ### [SSH Method (Command Line)](ssh-method.md)
+This method is for advanced users who prefer to use SSH to clone the sunnypilot repository and install it manually via the command line. It offeres greater control over the installation process.

docs_sp/setup/ssh-method.md

@@ -0,0 +1,28 @@
+# SSH Method
+
+If you are looking to install sunnypilot via SSH, run the following commands in an SSH terminal after connecting to your comma 3/3X:
+
+1. Navigate to `data` directory
+    ```sh 
+    cd /data
+    rm -rf openpilot
+    ```
+
+2. Clone sunnypilot
+
+    !!! example ""
+        `staging` branch is used in this step as an example.
+    ```sh
+    git clone -b staging --recurse-submodules https://github.com/sunnypilot/sunnypilot.git openpilot
+    ```
+
+3. Git LFS
+    ```sh
+    cd openpilot
+    git lfs pull
+    ```
+
+4. Reboot
+    ```sh
+    sudo reboot
+    ```

docs_sp/setup/url-method.md

@@ -0,0 +1,18 @@
+# URL Method
+
+The URL installation method can be done in two ways, depending on your device & if you already have sunnypilot installed.
+
+=== "sunnypilot not installed"
+
+    1. [Factory reset/uninstall](https://github.com/commaai/openpilot/wiki/FAQ#how-can-i-reset-the-device) the previous software if you have another software/fork installed.
+    2. After factory reset/uninstall, upon reboot, select `Custom Software` when given the option.
+    3. Input the **Installation URL** per [Recommended Branches](../branches/recommended-branches.md).
+    4. Complete the rest of the installation by following the onscreen instructions.
+
+
+=== "sunnypilot already installed"
+
+    1. On the comma 3/3X, go to `Settings` → `Software`.
+    2. At the `Download` option, press `CHECK`. This will fetch the list of latest branches from the sunnypilot repository on GitHub.
+    3. At the `Target Branch` option, press `SELECT` to open the `Target Branch` selector.
+    4. Scroll and select the **Desired Branch** per Recommended Branches.

docs_sp/stylesheets/style.css

@@ -0,0 +1,6 @@
+/**
+ * Copyright (c) 2021-, Haibin Wen, sunnypilot, and a number of other contributors.
+ *
+ * This file is part of sunnypilot and is licensed under the MIT License.
+ * See the LICENSE.md file in the root directory for more details.
+ */

mkdocs-sp.yml

@@ -0,0 +1,150 @@
+site_name: sunnypilot docs
+repo_name: sunnypilot/sunnypilot
+repo_url: https://github.com/sunnypilot/sunnypilot/
+site_description: sunnypilot Documentation
+site_url: https://docs.sunnypilot.ai
+edit_uri: blob/new-docs/docs_sp
+
+exclude_docs: README.md
+
+strict: true
+docs_dir: docs_sp
+site_dir: docs_sp_site/
+
+theme:
+  name: material
+  palette:
+    - media: "(prefers-color-scheme)"
+      toggle:
+        icon: material/brightness-auto
+        name: Switch to light mode
+    - scheme: default
+      media: "(prefers-color-scheme: light)"
+      primary: deep purple
+      accent: teal
+      toggle:
+        icon: material/brightness-7
+        name: Switch to dark mode
+    - scheme: slate
+      media: "(prefers-color-scheme: dark)"
+      primary: deep purple
+      accent: teal
+      toggle:
+        icon: material/brightness-4
+        name: Switch to system preference
+  font:
+    text: Open Sans
+    code: Fira Code
+  logo: assets/sp_logo.svg
+  favicon: assets/sp_logo.svg
+  features:
+    - content.code.copy
+    - navigation.tabs
+    - navigation.tabs.sticky
+
+extra_css:
+  - stylesheets/style.css
+
+markdown_extensions:
+  - admonition
+  - attr_list
+  - def_list
+  - footnotes
+  - md_in_html
+  - tables
+  - pymdownx.details
+  - pymdownx.emoji:
+      emoji_index: !!python/name:material.extensions.emoji.twemoji
+      emoji_generator: !!python/name:material.extensions.emoji.to_svg
+  - pymdownx.highlight:
+      anchor_linenums: true
+      line_spans: __span
+      pygments_lang_class: true
+  - pymdownx.inlinehilite
+  - pymdownx.magiclink:
+      normalize_issue_symbols: true
+      repo_url_shorthand: true
+      user: sunnypilot
+      repo: sunnypilot
+  - pymdownx.snippets
+  - pymdownx.superfences
+  - pymdownx.tabbed:
+      alternate_style: true
+  - pymdownx.tasklist:
+      custom_checkbox: true
+      clickable_checkbox: true
+  - toc:
+      permalink: true
+
+plugins:
+  - git-authors:
+      show_email_address: false
+  - git-committers:
+      repository: sunnypilot/sunnypilot
+      branch: master
+      enabled: !ENV [CI, false]
+  - git-revision-date-localized:
+      enable_creation_date: true
+  - search
+  - redirects:
+      redirect_maps:
+        'index.md': 'getting-started/what-is-sunnypilot.md'
+
+extra:
+  social:
+    - icon: fontawesome/brands/github
+      link: https://github.com/sunnypilot/sunnypilot
+    - icon: fontawesome/brands/discord
+      link: https://discord.sunnypilot.ai
+#  analytics:
+#    provider: google
+#    property: !ENV GOOGLE_ANALYTICS_KEY
+#    feedback:
+#      title: Was this page helpful?
+#      ratings:
+#        - icon: material/emoticon-happy-outline
+#          name: This page was helpful
+#          data: 1
+#          note: >-
+#            Thanks for your feedback!
+#        - icon: material/emoticon-sad-outline
+#          name: This page could be improved
+#          data: 0
+#          note: >-
+#            Thanks for your feedback! Help us improve this page by
+#            using our <a href="..." target="_blank" rel="noopener">feedback form</a>.
+
+nav:
+  - Getting Started:
+      - What is sunnypilot?: getting-started/what-is-sunnypilot.md
+      - Use sunnypilot in a car: getting-started/use-sunnypilot-in-a-car.md
+      - Develop sunnypilot: getting-started/develop-sunnypilot.md
+      - Setup:
+          - 🚨 Read before installing 🚨: setup/read-before-installing.md
+          - Installation:
+              - URL Method: setup/url-method.md
+              - SSH Method: setup/ssh-method.md
+  - Features:
+      - Auto Lane Change: features/auto-lane-change.md
+      - Custom ACC Increments: features/custom-acc-increments.md
+      - Dynamic Experimental Control: features/dynamic-experimental-control.md
+      - Hyundai Longitudinal Tuning: features/hyundai-longitudinal-tuning.md
+      - Intelligent Cruise Button Management: features/icbm.md
+      - Modular Assistive Driving System: features/mads.md
+      - Neutral Network Lateral Control: features/nnlc.md
+      - Smart Cruise Control - Map: features/scc-m.md
+      - Smart Cruise Control - Vision: features/scc-v.md
+      - Speed Limit - Assist: features/speed-limit-assist.md
+  - Community:
+      - Contributing: community/CONTRIBUTING.md
+      - Workflow: community/WORKFLOW.md
+      - Reporting a bug: community/reporting-a-bug.md
+      - Reporting a docs issue: community/reporting-a-docs-issue.md
+      - Discord Community: https://discord.sunnypilot.ai
+  - Safety Information:
+      - Safety: SAFETY.md
+      - Prohibited safety modifications: safety-information/prohibited-safety-modifications.md
+  - References:
+      - Branches:
+          - Recommended Branches: branches/recommended-branches.md
+          - Branch Definitions: branches/definitions.md

pyproject.toml

@@ -80,6 +80,13 @@ docs = [
   "Jinja2",
   "natsort",
   "mkdocs",
+  "mkdocs-material",
+  "mkdocs-material-extensions",
+  "mkdocs-git-revision-date-localized-plugin",
+  "mkdocs-git-committers-plugin-2",
+  "mkdocs-git-authors-plugin",
+  "mkdocs-glightbox",
+  "mkdocs-redirects",
 ]
 
 testing = [

release/ci/Gemfile

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+gem "faraday"
+gem "faraday-retry"
+gem "faraday-multipart"
+gem "listen"

release/ci/lib/api.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+module API
+  def self.client
+    @client ||=
+      Faraday.new(url: DOCS_TARGET) do |conn|
+        conn.request :multipart
+        conn.request :url_encoded
+        conn.request :retry,
+                     {
+                       methods: %i[get post delete put],
+                       retry_statuses: [429],
+                       max: 3,
+                       retry_block: ->(env:, options:, retry_count:, exception:, will_retry_in:) do
+                         puts "Rate limited... will retry in #{will_retry_in}s"
+                       end,
+                       exceptions: [Faraday::TooManyRequestsError]
+                     }
+        conn.response :json, content_type: "application/json"
+        conn.response :raise_error
+        conn.adapter Faraday.default_adapter
+        conn.headers["Api-Key"] = DOCS_API_KEY
+      end
+  end
+
+  def self.edit_post(post_id:, raw:, title: nil, category: nil)
+    if dry_run?
+      puts "  DRY RUN: skipping PUT /posts/#{post_id}"
+      return
+    end
+
+    params = {
+      post: {
+        raw: raw,
+        edit_reason: "Synced from github.com/discourse/discourse-developer-docs"
+      }
+    }
+    params[:title] = title if title
+    params[:category] = category if category
+    client.put("/posts/#{post_id}", params)
+  end
+
+  def self.create_topic(external_id:, raw:, category:, title:)
+    if dry_run?
+      puts "  DRY RUN: skipping POST /posts"
+      return
+    end
+    client.post("/posts", { title: title, raw: raw, external_id: external_id, category: category })
+  end
+
+  def self.trash_topic(topic_id:)
+    if dry_run?
+      puts "  DRY RUN: skipping DELETE /t/#{topic_id}.json"
+      return
+    end
+
+    client.delete("/t/#{topic_id}.json")
+  end
+
+  def self.fetch_current_state
+    result =
+      client.post(
+        "/admin/plugins/explorer/queries/#{DATA_EXPLORER_QUERY_ID}/run",
+        { params: { category_id: CATEGORY_ID.to_s }.to_json }
+      ).body
+
+    raise "Data explorer query failed" if result["success"] != true
+
+    if result["columns"] != %w[t_id first_p_id external_id title raw deleted_at is_index_topic]
+      raise "Data explorer query returned unexpected columns: #{result["columns"].inspect}"
+    end
+
+    result["rows"].map do |row|
+      {
+        topic_id: row[0],
+        first_post_id: row[1],
+        external_id: row[2],
+        title: row[3],
+        raw: row[4],
+        deleted_at: row[5],
+        is_index_topic: row[6]
+      }
+    end
+  end
+
+  def self.restore_topic(topic_id:)
+    path = "/t/#{topic_id}/recover.json"
+
+    if dry_run?
+      puts "  DRY RUN: skipping PUT #{path}"
+      return
+    end
+
+    client.put(path)
+  end
+
+  def self.upload_file(path)
+    if dry_run?
+      puts "  DRY RUN: skipping POST /uploads.json"
+      return { "short_url" => "upload://placeholder" }
+    end
+
+    client.post(
+      "/uploads.json",
+      { type: "composer", synchronous: true, file: Faraday::UploadIO.new(path, "image/png") }
+    ).body
+  end
+
+  def self.dry_run?
+    [nil, true].include?(DRY_RUN)
+  end
+end

release/ci/lib/local_doc.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+Asset = Struct.new(:local_path, :local_sha1, :remote_short_url, keyword_init: true)
+
+class LocalDoc
+  attr_accessor :path,
+                :frontmatter,
+                :content,
+                :topic_id,
+                :first_post_id,
+                :remote_content,
+                :remote_title,
+                :remote_deleted,
+                :assets
+
+  def initialize(**kwargs)
+    kwargs.each { |k, v| send("#{k}=", v) }
+    self.assets ||= []
+  end
+
+  def external_id
+    "DOC-#{frontmatter["id"]}"
+  end
+
+  def section
+    path_segments = path.split("/")
+    path_segments[0] if path_segments.size > 1
+  end
+
+  def content_with_uploads
+    unused_assets = assets.dup
+
+    result =
+      content.gsub(/![^\]]+\]\(([^)]+)\)/) do |match|
+        path = $1
+        next match if !path.start_with?("/")
+
+        resolved = File.expand_path("#{__dir__}/../#{path}")
+        assets_dir = File.expand_path("#{__dir__}/../assets/")
+        raise "Invalid path: #{resolved}" if !resolved.start_with?(assets_dir)
+
+        digest = Digest::SHA1.file(resolved).hexdigest
+
+        asset = assets.find { |a| a.local_sha1 == digest }
+        unused_assets.delete(asset)
+        if !asset
+          puts "  Uploading #{path}..."
+          result = API.upload_file(resolved)
+          raise "File upload failed: #{result.inspect}" if !result["short_url"]
+          asset =
+            Asset.new(local_path: path, local_sha1: digest, remote_short_url: result["short_url"])
+          assets.push(asset)
+        end
+
+        short_url = asset.remote_short_url
+
+        match.gsub(path, short_url)
+      end
+
+    unused_assets.each { |asset| assets.delete(asset) }
+
+    result = <<~MD
+      #{result}
+
+      ---
+
+      <small>This document is version controlled - suggest changes [on github](https://github.com/sunnypilot/sunnypilot/blob/master/docs_sp/#{path}).</small>
+    MD
+
+    if assets.size == 0
+      result
+    else
+      <<~MD
+        #{result}
+        <!-- START DOCS ASSET MAP
+        #{serialized_assets}
+        END DOCS ASSET MAP -->
+      MD
+    end
+  end
+
+  def serialized_assets
+    JSON.pretty_generate(
+      assets.map do |asset|
+        {
+          local_path: asset.local_path,
+          local_sha1: asset.local_sha1,
+          remote_short_url: asset.remote_short_url
+        }
+      end
+    )
+  end
+
+  def remote_content=(value)
+    if value.match(/<!-- START DOCS ASSET MAP\n(.+?)\nEND DOCS ASSET MAP -->/m)
+      self.assets = JSON.parse($1).map { |raw_asset| Asset.new(**raw_asset) }
+    end
+
+    value.gsub!(/![^\]]+\]\(([^)]+)\)/) do |match|
+      url = $1
+      found_asset = assets.find { |a| a.remote_short_url == url }
+      match.sub!(path, found_asset.local_path) if found_asset
+      match
+    end
+
+    @remote_content = value
+  end
+end

release/ci/lib/util.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Util
+  def self.parse_md(raw)
+    if match = raw.match(/\A---\s*\n(.+?)\n---\n?(.*)\z/m)
+      raw_frontmatter, content = match.captures
+      frontmatter = YAML.safe_load(raw_frontmatter)
+    else
+      content = raw
+      frontmatter = {}
+    end
+
+    [frontmatter, content]
+  end
+end

release/ci/sync_docs.rb

@@ -0,0 +1,762 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require "yaml"
+require "faraday"
+require "faraday/retry"
+require "faraday/multipart"
+require "listen"
+require "json"
+require "digest"
+
+CATEGORY_ID = ENV["DOCS_CATEGORY_ID"].to_i
+DATA_EXPLORER_QUERY_ID = ENV["DOCS_DATA_EXPLORER_QUERY_ID"].to_i
+DOCS_TARGET = ENV["DOCS_TARGET"]
+DOCS_API_KEY = ENV["DOCS_API_KEY"]
+GEMINI_API_KEY = ENV["GEMINI_API_KEY"]
+
+VERBOSE = ARGV.include?("-v")
+WATCH = ARGV.include?("--watch")
+DRY_RUN = ARGV.include?("--dry-run")
+
+require_relative "lib/local_doc"
+require_relative "lib/api"
+require_relative "lib/util"
+
+# Gemini API client for title generation
+class GeminiClient
+  GEMINI_API_URL = "https://generativelanguage.googleapis.com/v1beta/models/gemini-2.5-flash-lite:generateContent"
+  #GEMINI_API_URL = "https://generativelanguage.googleapis.com/v1beta/models/gemini-2.5-flash:generateContent"  
+#   MAX_REQUESTS_PER_MINUTE = 15
+  MAX_REQUESTS_PER_MINUTE = 9
+  RATE_LIMIT_WINDOW = 60 # seconds
+
+  def initialize(api_key)
+    @api_key = api_key
+    @request_timestamps = []
+    @mutex = Mutex.new
+  end
+
+  def generate_titles(file_path, content)
+    return nil unless @api_key
+
+    wait_for_rate_limit
+
+    prompt = build_prompt(file_path, content)
+    
+    response = Faraday.post(
+      "#{GEMINI_API_URL}?key=#{@api_key}",
+      { contents: [{ parts: [{ text: prompt }] }] }.to_json,
+      "Content-Type" => "application/json"
+    )
+
+    parse_response(response)
+  rescue => e
+    puts "Error calling Gemini API: #{e.message}"
+    nil
+  end
+
+  private
+
+  def wait_for_rate_limit
+    @mutex.synchronize do
+      now = Time.now
+      
+      # Remove timestamps older than the rate limit window
+      @request_timestamps.reject! { |ts| now - ts > RATE_LIMIT_WINDOW }
+      
+      # If we've hit the limit, wait until the oldest request expires
+      if @request_timestamps.length >= MAX_REQUESTS_PER_MINUTE
+        oldest_request = @request_timestamps.first
+        sleep_time = RATE_LIMIT_WINDOW - (now - oldest_request) + 0.1 # Add small buffer
+        
+        if sleep_time > 0
+          puts "Rate limit reached (#{MAX_REQUESTS_PER_MINUTE}/min). Waiting #{sleep_time.round(1)}s..."
+          sleep(sleep_time)
+          
+          # Clean up again after waiting
+          now = Time.now
+          @request_timestamps.reject! { |ts| now - ts > RATE_LIMIT_WINDOW }
+        end
+      end
+      
+      # Record this request
+      @request_timestamps << Time.now
+    end
+  end
+
+  def build_prompt(file_path, content)
+    <<~PROMPT
+      You are helping to generate documentation metadata. Given a markdown file path and its content, generate appropriate titles.
+
+      File path: #{file_path}
+      
+      Content preview:
+      #{content[0..500]}
+
+      Please analyze the file path and content, then provide:
+      1. A full title (3-8 words, descriptive and professional, MUST be at least 15 characters long)
+      2. A short title (1-3 words, concise, MUST be at least 15 characters long)
+
+      CRITICAL: Both titles MUST be at least 15 characters long. If a title would be shorter, expand it with relevant context.
+
+      Respond ONLY with valid JSON in this exact format:
+      {
+        "title": "Your Full Title Here",
+        "short_title": "Short Title Here"
+      }
+
+      Do not include any other text, explanation, or markdown formatting.
+    PROMPT
+  end
+
+  def parse_response(response)
+    body = JSON.parse(response.body)
+    text = body.dig("candidates", 0, "content", "parts", 0, "text")
+    
+    return nil unless text
+
+    # Extract JSON from potential markdown code blocks
+    json_text = text.strip.gsub(/^```json\n/, "").gsub(/\n```$/, "").strip
+    
+    parsed = JSON.parse(json_text)
+    
+    # Validate minimum length
+    if parsed["title"] && parsed["title"].length < 15
+      parsed["title"] = parsed["title"].ljust(15)
+    end
+    
+    if parsed["short_title"] && parsed["short_title"].length < 15
+      parsed["short_title"] = parsed["short_title"].ljust(15)
+    end
+    
+    parsed
+  rescue => e
+    puts "Error parsing Gemini response: #{e.message}"
+    nil
+  end
+end
+
+# Convert MkDocs "=== Tabs" sections to Obsidian callouts
+def convert_mkdocs_tabs_to_callouts(content, debug: false)
+  lines = content.lines
+  result = []
+  i = 0
+  match_count = 0
+
+  while i < lines.length
+    line = lines[i]
+
+    # Detect a MkDocs tab start, e.g., === "sunnypilot not installed"
+    if line =~ /^===\s+"([^"]+)"\s*$/
+      match_count += 1
+      tab_title = $1.strip
+
+      # Collect all indented lines following the tab
+      body_lines = []
+      i += 1
+      while i < lines.length
+        current_line = lines[i]
+        
+        # Check if line is indented (4+ spaces or tab)
+        if current_line =~ /^(?:    |\t)/
+          body_lines << current_line
+          i += 1
+        # Check if it's a blank line - peek ahead like we do for callouts
+        elsif current_line =~ /^\s*$/
+          peek_index = i + 1
+          has_more_indented = false
+          while peek_index < lines.length
+            if lines[peek_index] =~ /^(?:    |\t)/
+              has_more_indented = true
+              break
+            elsif lines[peek_index] =~ /^\s*$/
+              peek_index += 1
+            else
+              break
+            end
+          end
+          
+          if has_more_indented
+            body_lines << current_line
+            i += 1
+          else
+            break
+          end
+        else
+          # Non-indented, non-blank line (could be next tab!) - stop
+          break
+        end
+      end
+
+      puts "DEBUG: Tab '#{tab_title}', lines: #{body_lines.length}" if debug
+
+      # Convert the tab section to a callout
+      result << "> [!note] #{tab_title}\n"
+      body_lines.each do |body_line|
+        # Remove the first level of indentation (4 spaces or 1 tab) and add > prefix
+        stripped = body_line.sub(/^(?:    |\t)/, '')
+        if stripped.strip.empty?
+          result << ">\n"
+        else
+          result << ">#{stripped}"
+        end
+      end
+    else
+      result << line
+      i += 1
+    end
+  end
+
+  puts "DEBUG: Total tab matches: #{match_count}" if debug
+  result.join
+end
+
+
+# New implementation of MkDocs Material callout to Obsidian converter
+def convert_mkdocs_to_obsidian_callouts(content, debug: false)
+  # Map of MkDocs callout types to Obsidian equivalents
+  callout_map = {
+    'note' => 'note',
+    'tip' => 'tip',
+    'important' => 'important',
+    'warning' => 'warning',
+    'caution' => 'caution',
+    'info' => 'info',
+    'success' => 'success',
+    'question' => 'question',
+    'failure' => 'failure',
+    'danger' => 'danger',
+    'bug' => 'bug',
+    'example' => 'example',
+    'quote' => 'quote',
+    'abstract' => 'abstract',
+    'summary' => 'summary',
+    'tldr' => 'tldr'
+  }
+  
+  lines = content.lines
+  result = []
+  i = 0
+  match_count = 0
+  
+  while i < lines.length
+    line = lines[i]
+    
+    # Check if this line starts a callout (can be indented or not)
+    # Capture any leading indentation
+    if line =~ /^(\s*)!!!\s+(#{callout_map.keys.map { |k| Regexp.escape(k) }.join('|')})(?:\s+"([^"]*)")?\s*$/
+      leading_indent = $1
+      mkdocs_type = $2
+      custom_title = $3
+      match_count += 1
+      obsidian_type = callout_map[mkdocs_type]
+      
+      # Determine the base indentation level (number of spaces/tabs before !!!)
+      base_indent_size = leading_indent.length
+      
+      # Collect all lines that have MORE indentation than the base
+      body_lines = []
+      i += 1
+      while i < lines.length
+        current_line = lines[i]
+        
+        # Check if line has the required base indentation plus more (for body content)
+        # Body content should be indented relative to the !!! line
+        required_indent = leading_indent + "    " # base + 4 more spaces
+        alt_required_indent = leading_indent + "\t" # base + 1 tab
+        
+        if current_line.start_with?(required_indent) || current_line.start_with?(alt_required_indent)
+          body_lines << current_line
+          i += 1
+        # Check if line is blank - might be between paragraphs
+        elsif current_line =~ /^\s*$/
+          peek_index = i + 1
+          has_more_indented = false
+          while peek_index < lines.length
+            peek_line = lines[peek_index]
+            if peek_line.start_with?(required_indent) || peek_line.start_with?(alt_required_indent)
+              has_more_indented = true
+              break
+            elsif peek_line =~ /^\s*$/
+              peek_index += 1
+            else
+              break
+            end
+          end
+          
+          if has_more_indented
+            body_lines << current_line
+            i += 1
+          else
+            break
+          end
+        else
+          # Line doesn't have required indentation - stop
+          break
+        end
+      end
+      
+      puts "DEBUG: Match #{match_count} - indent: #{base_indent_size} spaces, type: #{mkdocs_type}, title: #{custom_title.inspect}, body lines: #{body_lines.length}" if debug
+      
+      # Build the converted callout, preserving the base indentation
+      if body_lines.empty?
+        if custom_title && !custom_title.empty?
+          result << "#{leading_indent}> [!#{obsidian_type}] \"#{custom_title}\"\n"
+        else
+          result << "#{leading_indent}> [!#{obsidian_type}]\n"
+        end
+      else
+        if custom_title && !custom_title.empty?
+          result << "#{leading_indent}> [!#{obsidian_type}] \"#{custom_title}\"\n"
+        else
+          result << "#{leading_indent}> [!#{obsidian_type}]\n"
+        end
+        # Add > prefix to each body line, removing the extra level of indentation
+        body_lines.each do |body_line|
+          # Remove the base indent + one level (4 spaces or tab)
+          stripped = body_line.sub(/^#{Regexp.escape(leading_indent)}(?:    |\t)/, '')
+          result << "#{leading_indent}>#{stripped}"
+        end
+      end
+    else
+      result << line
+      i += 1
+    end
+  end
+  
+  puts "DEBUG: Total matches found: #{match_count}" if debug
+  
+  result.join
+end
+
+# Convert MkDocs Material icons to standard emojis
+def convert_material_icons_to_emojis(content)
+  # Map of common Material icons to emoji equivalents
+  icon_map = {
+    # Check/success icons
+    ':material-check:' => '✅',
+    ':material-check-circle:' => '✅',
+    ':material-check-bold:' => '✅',
+    
+    # Close/error icons
+    ':material-close:' => '❌',
+    ':material-close-circle:' => '❌',
+    ':material-alert-circle:' => '⚠️',
+    
+    # Info icons
+    ':material-information:' => 'ℹ️',
+    ':material-information-outline:' => 'ℹ️',
+    ':material-help-circle:' => '❓',
+    
+    # Arrow icons
+    ':material-arrow-right:' => '→',
+    ':material-arrow-left:' => '←',
+    ':material-arrow-up:' => '↑',
+    ':material-arrow-down:' => '↓',
+    
+    # Other common icons
+    ':material-lightbulb:' => '💡',
+    ':material-star:' => '⭐',
+    ':material-heart:' => '❤️',
+    ':material-fire:' => '🔥',
+    ':material-flag:' => '🚩',
+    ':material-link:' => '🔗',
+    ':material-pencil:' => '✏️',
+    ':material-delete:' => '🗑️',
+    ':material-calendar:' => '📅',
+    ':material-clock:' => '🕐',
+    ':material-email:' => '📧',
+    ':material-phone:' => '📞',
+  }
+  
+  # Replace material icons with emojis, ignoring any style attributes
+  icon_map.each do |material_icon, emoji|
+    # Match the icon with optional style attributes like { style="color: #EF5350" }
+    content.gsub!(/#{Regexp.escape(material_icon)}\{\s*style="[^"]*"\s*\}/, emoji)
+    # Also match without style attributes
+    content.gsub!(material_icon, emoji)
+  end
+  
+  content
+end
+
+# Helper method to generate frontmatter from file path
+def generate_frontmatter_from_path(path, content = nil, gemini_client = nil)
+  # Remove .md extension and get the base name
+  base_name = File.basename(path, ".md")
+  
+  # Generate id from the full path (without extension)
+  # Replace / with -
+  # IMPORTANT: The LocalDoc#external_id method adds "DOC-" prefix (4 chars)
+  # So we need to limit the base ID to 46 chars to stay under the 50 char API limit
+  full_id = path.sub(/\.md$/, "").gsub("/", "-")
+  
+  # Maximum length for the base ID (50 char API limit - 4 char "DOC-" prefix)
+  max_base_id_length = 46
+  
+  if full_id.length > max_base_id_length
+    # Take first 37 chars and append an 8-char hash for uniqueness (37 + 1 dash + 8 = 46)
+    hash_suffix = Digest::MD5.hexdigest(path)[0..7]
+    id = "#{full_id[0..36]}-#{hash_suffix}"
+  else
+    id = full_id
+  end
+  
+  # Try to use Gemini for title generation
+  if gemini_client && content
+    gemini_titles = gemini_client.generate_titles(path, content)
+    
+    if gemini_titles
+      return {
+        "id" => id,
+        "title" => gemini_titles["title"],
+        "short_title" => gemini_titles["short_title"]
+      }
+    end
+  end
+  
+  # Fallback to original logic if Gemini fails or is not available
+  title = base_name.split(/[-_]/).map(&:capitalize).join(" ")
+  short_title = base_name.split(/[-_]/).map(&:capitalize).join(" ")
+  
+  # Ensure minimum length
+  title = title.ljust(15) if title.length < 15
+  short_title = short_title.ljust(15) if short_title.length < 15
+  
+  {
+    "id" => id,
+    "title" => title,
+    "short_title" => short_title
+  }
+end
+
+# Helper method to generate index.md content for a folder
+def generate_folder_index(folder_name)
+  # Convert folder name to a nice title (e.g., "my-folder" -> "My Folder")
+  title = folder_name.split(/[-_]/).map(&:capitalize).join(" ")
+  
+  "---\ntitle: #{title}\n---\n"
+end
+
+# Convert internal markdown links (.md) to Discourse topic links
+def rewrite_internal_links(content, docs)
+  require "uri"
+
+  content.gsub(/\]\(([^)]+\.md)(#[^)]+)?\)/) do |match|
+    raw_link = $1
+    anchor = $2 || ""
+    # Strip any ./ or ../ from the beginning, but preserve subfolders
+    normalized = raw_link.gsub(%r{^\./}, "").gsub(%r{^\.\./}, "")
+    # Remove trailing .md
+    normalized = normalized.gsub(/\.md$/, "")
+
+    # Try percent-decoding (handles %20 etc)
+    begin
+      normalized_decoded = URI.decode_www_form_component(normalized)
+    rescue
+      normalized_decoded = normalized
+    end
+
+    candidates = []
+
+    # Strategy 1: exact match against doc.path without .md
+    candidates += docs.select { |d| d.path.sub(/\.md$/, "") == normalized_decoded }
+
+    # Strategy 2: ends_with (useful if docs have a different root)
+    if candidates.empty?
+      candidates += docs.select { |d| d.path.end_with?("#{normalized_decoded}.md") }
+    end
+
+    # Strategy 3: match by basename (e.g., linking to index.md or same-named file in subfolder)
+    if candidates.empty?
+      basename = File.basename(normalized_decoded)
+      candidates += docs.select { |d| File.basename(d.path, ".md") == basename }
+    end
+
+    # Strategy 4: index.md handling — if link pointed to a folder/index.md, allow folder match
+    if candidates.empty? && normalized_decoded.end_with?("/index")
+      folder = normalized_decoded.sub(/\/index$/, "")
+      candidates += docs.select { |d| File.dirname(d.path) == folder && File.basename(d.path, ".md") == "index" }
+    end
+
+    # Pick the best candidate (prefer exact match)
+    target_doc =
+      if candidates.any?
+        # prefer exact equality if present
+        exact = candidates.find { |d| d.path.sub(/\.md$/, "") == normalized_decoded }
+        exact || candidates.first
+      else
+        nil
+      end
+
+    if target_doc && target_doc.topic_id
+      # Return a Discourse link preserving the anchor
+      "](/t/-/#{target_doc.topic_id}?silent=true#{anchor})"
+    else
+      if VERBOSE
+        puts "⚠️ rewrite_internal_links: unresolved '#{raw_link}' -> normalized='#{normalized_decoded}'"
+        # show up to 10 possible docs to help debugging
+        sample = docs.first(10).map(&:path).join(", ")
+        puts "  sample docs: #{sample}"
+      end
+      # Return original match unchanged so the link doesn't become invalid text
+      match
+    end
+  end
+end
+
+# Initialize Gemini client if API key is available
+gemini_client = GEMINI_API_KEY ? GeminiClient.new(GEMINI_API_KEY) : nil
+
+if gemini_client
+  puts "✓ Gemini API configured for title generation"
+else
+  puts "⚠ GEMINI_API_KEY not set - using fallback title generation"
+end
+
+docs = []
+
+puts "Reading local docs..."
+BASE = "#{__dir__}/../../docs_sp/"
+
+# Generate index.md for each folder that doesn't have one
+folders_needing_index = Set.new
+Dir.glob("**/", base: BASE).each do |folder|
+  next if folder == "./" || folder.empty?
+  
+  folder_path = folder.chomp("/")
+  index_path = File.join(BASE, folder_path, "index.md")
+  
+  unless File.exist?(index_path)
+    folders_needing_index.add(folder_path)
+    
+    # Get the folder name (last component of the path)
+    folder_name = File.basename(folder_path)
+    
+    # Generate the index.md content
+    index_content = generate_folder_index(folder_name)
+    
+    # Write the index.md file
+    File.write(index_path, index_content)
+    puts "Generated index.md for folder: #{folder_path}" if VERBOSE
+  end
+end
+
+puts "Generated #{folders_needing_index.size} index.md files" if folders_needing_index.any?
+
+Dir
+  .glob("**/*.md", base: BASE)
+  .each do |path|
+    next if path.end_with?("index.md")
+    next if path.include?("SAFETY")
+
+    content = File.read(File.join(BASE, path))
+
+    frontmatter, content = Util.parse_md(content)
+    
+    # Convert MkDocs Material callouts to Obsidian format
+    content = convert_mkdocs_tabs_to_callouts(content)
+    content = convert_mkdocs_to_obsidian_callouts(content)
+    content = convert_material_icons_to_emojis(content)
+
+    # Generate missing frontmatter fields dynamically
+    generated = generate_frontmatter_from_path(path, content, gemini_client)
+    
+    # Apply the generated values, ensuring ID is limited to 50 chars
+    frontmatter["id"] = generated["id"]
+    frontmatter["title"] ||= generated["title"]
+    frontmatter["short_title"] ||= generated["short_title"]
+
+    puts "Generated frontmatter for '#{path}': id='#{frontmatter["id"]}', title='#{frontmatter["title"]}'" if VERBOSE
+
+    docs.push(LocalDoc.new(frontmatter:, path:, content:))
+  end
+
+puts "Rewriting internal links..."
+docs.each do |doc|
+  doc.content = rewrite_internal_links(doc.content, docs)
+end
+
+puts "Validating local docs..."
+docs
+  .group_by { |doc| doc.external_id }
+  .each do |id, docs|
+    if docs.size > 1
+      puts "- duplicate external_id '#{id}' found in:"
+      docs.each { |doc| puts "- #{doc.path}" }
+      exit 1
+    end
+  end
+
+exit 0 if !DOCS_API_KEY
+
+puts "Fetching remote info via data-explorer..."
+remote_topics = API.fetch_current_state
+
+puts "Mapping to existing topics..."
+map_to_remote =
+  lambda do
+    docs.each do |doc|
+      puts "- checking '#{doc.external_id}'..." if VERBOSE
+      if topic_info = remote_topics.find { |t| t[:external_id] == doc.external_id }
+        doc.topic_id = topic_info[:topic_id]
+        doc.first_post_id = topic_info[:first_post_id]
+        doc.remote_title = topic_info[:title]
+        doc.remote_content = topic_info[:raw]
+        doc.remote_deleted = topic_info[:deleted_at]
+        puts "  found topic_id: #{doc.topic_id}" if VERBOSE
+      else
+        puts " not found" if VERBOSE
+      end
+    end
+  end
+map_to_remote.call
+
+puts "Deleting topics if necessary..."
+
+cat_desc_topic = remote_topics.find { |t| t[:is_index_topic] }
+if cat_desc_topic.nil?
+  puts "Docs category is missing an index topic"
+  exit 1
+end
+cat_desc_topic_id = cat_desc_topic[:topic_id]
+
+remote_topics
+  .reject { |remote_doc| remote_doc[:deleted_at] }
+  .reject { |remote_doc| docs.any? { |doc| doc.topic_id == remote_doc[:topic_id] } }
+  .reject { |remote_doc| remote_doc[:topic_id] == cat_desc_topic_id }
+  .each do |remote_doc|
+    id = remote_doc[:topic_id]
+    puts "- deleting topic #{id}..."
+    API.trash_topic(topic_id: id)
+  end
+
+puts "Restoring topics if necessary..."
+docs
+  .filter(&:remote_deleted)
+  .each do |doc|
+    puts "- restoring '#{doc.external_id}'..."
+    API.restore_topic(topic_id: doc.topic_id)
+  end
+
+puts "Creating missing topics..."
+created_any = false
+docs.each do |doc|
+  next if doc.topic_id
+
+  created_any = true
+  puts "- creating '#{doc.external_id} with title '#{doc.frontmatter["title"]}'..."
+  converted_content = convert_mkdocs_to_obsidian_callouts(doc.content_with_uploads)
+  API.create_topic(
+    external_id: doc.external_id,
+    raw: converted_content,
+    category: CATEGORY_ID,
+    title: doc.frontmatter["title"]
+  )
+rescue Faraday::UnprocessableEntityError => e
+  puts " 422 error: #{e.response[:body]}"
+  raise e
+end
+
+if created_any
+  puts "Re-fetching remote info..."
+  remote_topics = API.fetch_current_state
+  map_to_remote.call
+end
+
+puts "Updating content..."
+docs.each do |doc|
+  if doc.topic_id.nil?
+    next if DRY_RUN
+    raise "Topic ID not found for '#{doc.external_id}'. Something went wrong with creating it?"
+  end
+
+  # Convert callouts in the content before comparison and upload
+  converted_content = convert_mkdocs_to_obsidian_callouts(doc.content_with_uploads)
+
+  if converted_content.strip == doc.remote_content.strip &&
+       doc.frontmatter["title"] == doc.remote_title
+    puts "- no changes required for '#{doc.external_id}' (topic_id: #{doc.topic_id})" if VERBOSE
+    next
+  end
+
+  puts "- updating '#{doc.external_id}' (topic_id: #{doc.topic_id})... new title: '#{doc.frontmatter["title"]}'"
+  API.edit_post(
+    post_id: doc.first_post_id,
+    raw: converted_content,
+    title: doc.frontmatter["title"],
+    category: CATEGORY_ID
+  )
+rescue Faraday::UnprocessableEntityError => e
+  puts " 422 error: #{e.response[:body]}"
+  raise e
+end
+
+puts "Building index..."
+_, index_content = Util.parse_md(File.read("#{BASE}index.md"))
+index_content += "\n\n"
+docs
+  .group_by { |doc| doc.section }
+  .each do |section, section_docs|
+    if section
+      section_frontmatter, _ = Util.parse_md(File.read("#{BASE}#{section}/index.md"))
+      index_content += "## #{section_frontmatter["title"]}\n\n"
+    end
+
+    section_docs.each do |doc|
+      index_content +=
+        "- #{doc.frontmatter["short_title"]}: [#{doc.frontmatter["title"]}](/t/-/#{doc.topic_id}?silent=true)\n"
+    end
+    index_content += "\n"
+  end
+
+index_post_info = remote_topics.find { |t| t[:topic_id] == cat_desc_topic_id }
+
+if index_post_info[:raw].strip == index_content.strip
+  puts "- no changes required for index"
+else
+  puts "- updating index..."
+  API.edit_post(post_id: index_post_info[:first_post_id], raw: index_content)
+end
+
+if WATCH
+  puts "Watching for changes to files..."
+
+  Listen
+    .to("#{__dir__}/docs") do |modified, added, removed|
+      if added.size > 0 || removed.size > 0
+        puts "Files added/removed. Restarting sync..."
+        exec("ruby", "#{__dir__}/sync_docs", *ARGV)
+      end
+
+      modified.each do |path|
+        relative = path.sub(BASE, "")
+        doc = docs.find { |d| d.path == relative }
+        raise "Modified file not recognized: #{relative}" if doc.nil?
+
+        print "- updating '#{doc.external_id}' (topic_id: #{doc.topic_id})..."
+        new_frontmatter, new_content = Util.parse_md(File.read(path))
+        if %w[id short_title].any? { |key| doc.frontmatter[key] != new_frontmatter[key] }
+          puts "Frontmatter changed. Restarting sync..."
+          exec("ruby", "#{__dir__}/sync_docs", *ARGV)
+        end
+        doc.content, doc.frontmatter = new_content, new_frontmatter
+
+        # Convert callouts before uploading
+        converted_content = convert_mkdocs_to_obsidian_callouts(doc.content_with_uploads)
+
+        API.edit_post(
+          post_id: doc.first_post_id,
+          raw: converted_content,
+          title: doc.frontmatter["title"]
+        )
+        puts " done"
+      end
+    end
+    .start
+
+  sleep
+else
+  puts "Done."
+end

selfdrive/controls/lib/desire_helper.py

@@ -6,6 +6,7 @@ from openpilot.sunnypilot.selfdrive.controls.lib.lane_turn_desire import LaneTur
 
 LaneChangeState = log.LaneChangeState
 LaneChangeDirection = log.LaneChangeDirection
+TurnDirection = custom.ModelDataV2SP.TurnDirection
 
 LANE_CHANGE_SPEED_MIN = 20 * CV.MPH_TO_MS
 LANE_CHANGE_TIME_MAX = 10.
@@ -32,9 +33,9 @@ DESIRES = {
 }
 
 TURN_DESIRES = {
-  custom.TurnDirection.none: log.Desire.none,
-  custom.TurnDirection.turnLeft: log.Desire.turnLeft,
-  custom.TurnDirection.turnRight: log.Desire.turnRight,
+  TurnDirection.none: log.Desire.none,
+  TurnDirection.turnLeft: log.Desire.turnLeft,
+  TurnDirection.turnRight: log.Desire.turnRight,
 }
 
 
@@ -49,7 +50,7 @@ class DesireHelper:
     self.desire = log.Desire.none
     self.alc = AutoLaneChangeController(self)
     self.lane_turn_controller = LaneTurnController(self)
-    self.lane_turn_direction = custom.TurnDirection.none
+    self.lane_turn_direction = TurnDirection.none
 
   @staticmethod
   def get_lane_change_direction(CS):
@@ -126,7 +127,7 @@ class DesireHelper:
 
     self.prev_one_blinker = one_blinker
 
-    if self.lane_turn_direction != custom.TurnDirection.none:
+    if self.lane_turn_direction != TurnDirection.none:
       self.desire = TURN_DESIRES[self.lane_turn_direction]
     else:
       self.desire = DESIRES[self.lane_change_direction][self.lane_change_state]

selfdrive/selfdrived/selfdrived.py

@@ -24,6 +24,7 @@ from openpilot.selfdrive.selfdrived.alertmanager import AlertManager, set_offroa
 from openpilot.system.version import get_build_metadata
 
 from openpilot.sunnypilot.mads.mads import ModularAssistiveDrivingSystem
+from openpilot.sunnypilot import get_sanitize_int_param
 from openpilot.sunnypilot.selfdrive.car.car_specific import CarSpecificEventsSP
 from openpilot.sunnypilot.selfdrive.car.cruise_helpers import CruiseHelper
 from openpilot.sunnypilot.selfdrive.car.intelligent_cruise_button_management.controller import IntelligentCruiseButtonManagement
@@ -43,6 +44,7 @@ LaneChangeDirection = log.LaneChangeDirection
 EventName = log.OnroadEvent.EventName
 ButtonType = car.CarState.ButtonEvent.Type
 SafetyModel = car.CarParams.SafetyModel
+TurnDirection = custom.ModelDataV2SP.TurnDirection
 
 IGNORED_SAFETY_MODES = (SafetyModel.silent, SafetyModel.noOutput)
 
@@ -130,7 +132,12 @@ class SelfdriveD(CruiseHelper):
     self.logged_comm_issue = None
     self.not_running_prev = None
     self.experimental_mode = False
-    self.personality = self.params.get("LongitudinalPersonality", return_default=True)
+    self.personality = get_sanitize_int_param(
+      "LongitudinalPersonality",
+      min(log.LongitudinalPersonality.schema.enumerants.values()),
+      max(log.LongitudinalPersonality.schema.enumerants.values()),
+      self.params
+    )
     self.recalibrating_seen = False
     self.state_machine = StateMachine()
     self.rk = Ratekeeper(100, print_delay_threshold=None)
@@ -299,9 +306,9 @@ class SelfdriveD(CruiseHelper):
 
     # Handle lane turn
     lane_turn_direction = self.sm['modelDataV2SP'].laneTurnDirection
-    if lane_turn_direction == custom.TurnDirection.turnLeft:
+    if lane_turn_direction == TurnDirection.turnLeft:
       self.events_sp.add(custom.OnroadEventSP.EventName.laneTurnLeft)
-    elif lane_turn_direction == custom.TurnDirection.turnRight:
+    elif lane_turn_direction == TurnDirection.turnRight:
       self.events_sp.add(custom.OnroadEventSP.EventName.laneTurnRight)
 
     for i, pandaState in enumerate(self.sm['pandaStates']):

selfdrive/ui/qt/offroad/settings.cc

@@ -33,13 +33,6 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
       "../assets/icons/experimental_white.svg",
       false,
     },
-    {
-      "DynamicExperimentalControl",
-      tr("Enable Dynamic Experimental Control"),
-      tr("Enable toggle to allow the model to determine when to use sunnypilot ACC or sunnypilot End to End Longitudinal."),
-      "../assets/offroad/icon_blank.png",
-      false,
-    },
     {
       "DisengageOnAccelerator",
       tr("Disengage on Accelerator Pedal"),

selfdrive/ui/qt/onroad/model.cc

@@ -22,7 +22,7 @@ void ModelRenderer::draw(QPainter &painter, const QRect &surface_rect) {
 
   update_model(model, lead_one);
   drawLaneLines(painter);
-  drawPath(painter, model, surface_rect);
+  drawPath(painter, model, surface_rect.height());
 
   if (longitudinal_control && sm.alive("radarState")) {
     update_leads(radar_state, model.getPosition());
@@ -173,7 +173,6 @@ QColor ModelRenderer::blendColors(const QColor &start, const QColor &end, float
       (1 - t) * start.alphaF() + t * end.alphaF());
 }
 
-
 void ModelRenderer::drawLead(QPainter &painter, const cereal::RadarState::LeadData::Reader &lead_data,
                              const QPointF &vd, const QRect &surface_rect) {
   const float speedBuff = 10.;

selfdrive/ui/qt/onroad/model.h

@@ -39,9 +39,6 @@ protected:
   virtual void update_model(const cereal::ModelDataV2::Reader &model, const cereal::RadarState::LeadData::Reader &lead);
   void drawLaneLines(QPainter &painter);
   void drawPath(QPainter &painter, const cereal::ModelDataV2::Reader &model, int height);
-  virtual void drawPath(QPainter &painter, const cereal::ModelDataV2::Reader &model, const QRect &surface_rect) {;
-    drawPath(painter, model, surface_rect.height());
-  }
   void updatePathGradient(QLinearGradient &bg);
   QColor blendColors(const QColor &start, const QColor &end, float t);
 
@@ -58,5 +55,4 @@ protected:
   QPointF lead_vertices[2] = {};
   Eigen::Matrix3f car_space_transform = Eigen::Matrix3f::Zero();
   QRectF clip_region;
-
 };

selfdrive/ui/soundd.py

@@ -4,7 +4,7 @@ import time
 import wave
 
 
-from cereal import car, messaging
+from cereal import car, messaging, custom
 from openpilot.common.basedir import BASEDIR
 from openpilot.common.filter_simple import FirstOrderFilter
 from openpilot.common.realtime import Ratekeeper
@@ -26,8 +26,15 @@ AMBIENT_DB = 30 # DB where MIN_VOLUME is applied
 DB_SCALE = 30 # AMBIENT_DB + DB_SCALE is where MAX_VOLUME is applied
 
 AudibleAlert = car.CarControl.HUDControl.AudibleAlert
+AudibleAlertSP = custom.SelfdriveStateSP.AudibleAlert
 
 
+sound_list_sp: dict[int, tuple[str, int | None, float]] = {
+  # AudibleAlertSP, file name, play count (none for infinite)
+  AudibleAlertSP.promptSingleLow: ("prompt_single_low.wav", 1, MAX_VOLUME),
+  AudibleAlertSP.promptSingleHigh: ("prompt_single_high.wav", 1, MAX_VOLUME),
+}
+
 sound_list: dict[int, tuple[str, int | None, float]] = {
   # AudibleAlert, file name, play count (none for infinite)
   AudibleAlert.engage: ("engage.wav", 1, MAX_VOLUME),
@@ -40,6 +47,8 @@ sound_list: dict[int, tuple[str, int | None, float]] = {
 
   AudibleAlert.warningSoft: ("warning_soft.wav", None, MAX_VOLUME),
   AudibleAlert.warningImmediate: ("warning_immediate.wav", None, MAX_VOLUME),
+
+  **sound_list_sp,
 }
 
 def check_selfdrive_timeout_alert(sm):

selfdrive/ui/sunnypilot/qt/offroad/settings/display/onroad_screen_brightness.cc

@@ -29,7 +29,7 @@ OnroadScreenBrightnessControl::OnroadScreenBrightnessControl(const QString &para
     "Onroad Brightness",
     "",
     "",
-    {0, 100}, 10, true);
+    {0, 90}, 10, true);
 
   connect(onroadScreenOffTimer, &OptionControlSP::updateLabels, this, &OnroadScreenBrightnessControl::refresh);
   connect(onroadScreenBrightness, &OptionControlSP::updateLabels, this, &OnroadScreenBrightnessControl::refresh);

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal/speed_limit/helpers.h

@@ -13,9 +13,9 @@ enum class SpeedLimitOffsetType {
 };
 
 inline const QString SpeedLimitOffsetTypeTexts[]{
-  QObject::tr("None"),
-  QObject::tr("Fixed"),
-  QObject::tr("Percent"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "None"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Fixed"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Percent"),
 };
 
 enum class SpeedLimitSourcePolicy {
@@ -27,11 +27,11 @@ enum class SpeedLimitSourcePolicy {
 };
 
 inline const QString SpeedLimitSourcePolicyTexts[]{
-  QObject::tr("Car\nOnly"),
-  QObject::tr("Map\nOnly"),
-  QObject::tr("Car\nFirst"),
-  QObject::tr("Map\nFirst"),
-  QObject::tr("Combined\nData")
+  QT_TRANSLATE_NOOP("SpeedLimitPolicy", "Car\nOnly"),
+  QT_TRANSLATE_NOOP("SpeedLimitPolicy", "Map\nOnly"),
+  QT_TRANSLATE_NOOP("SpeedLimitPolicy", "Car\nFirst"),
+  QT_TRANSLATE_NOOP("SpeedLimitPolicy", "Map\nFirst"),
+  QT_TRANSLATE_NOOP("SpeedLimitPolicy", "Combined\nData")
 };
 
 enum class SpeedLimitMode {
@@ -42,8 +42,8 @@ enum class SpeedLimitMode {
 };
 
 inline const QString SpeedLimitModeTexts[]{
-  QObject::tr("Off"),
-  QObject::tr("Information"),
-  QObject::tr("Warning"),
-  QObject::tr("Assist"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Off"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Information"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Warning"),
+  QT_TRANSLATE_NOOP("SpeedLimitSettings", "Assist"),
 };

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal/speed_limit/speed_limit_policy.cc

@@ -23,11 +23,11 @@ SpeedLimitPolicy::SpeedLimitPolicy(QWidget *parent) : QWidget(parent) {
   ListWidgetSP *list = new ListWidgetSP(this);
 
   std::vector<QString> speed_limit_policy_texts{
-    SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::CAR_ONLY)],
-    SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::MAP_ONLY)],
-    SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::CAR_FIRST)],
-    SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::MAP_FIRST)],
-    SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::COMBINED)]
+    tr(SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::CAR_ONLY)].toStdString().c_str()),
+    tr(SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::MAP_ONLY)].toStdString().c_str()),
+    tr(SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::CAR_FIRST)].toStdString().c_str()),
+    tr(SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::MAP_FIRST)].toStdString().c_str()),
+    tr(SpeedLimitSourcePolicyTexts[static_cast<int>(SpeedLimitSourcePolicy::COMBINED)].toStdString().c_str())
   };
   speed_limit_policy = new ButtonParamControlSP(
     "SpeedLimitPolicy",

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal/speed_limit/speed_limit_settings.cc

@@ -25,10 +25,10 @@ SpeedLimitSettings::SpeedLimitSettings(QWidget *parent) : QStackedWidget(parent)
   speedLimitPolicyScreen = new SpeedLimitPolicy(this);
 
   std::vector<QString> speed_limit_mode_texts{
-    SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::OFF)],
-    SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::INFORMATION)],
-    SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::WARNING)],
-    SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::ASSIST)],
+    tr(SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::OFF)].toStdString().c_str()),
+    tr(SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::INFORMATION)].toStdString().c_str()),
+    tr(SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::WARNING)].toStdString().c_str()),
+    tr(SpeedLimitModeTexts[static_cast<int>(SpeedLimitMode::ASSIST)].toStdString().c_str())
   };
   speed_limit_mode_settings = new ButtonParamControlSP(
     "SpeedLimitMode",
@@ -64,9 +64,9 @@ SpeedLimitSettings::SpeedLimitSettings(QWidget *parent) : QStackedWidget(parent)
   QVBoxLayout *offsetLayout = new QVBoxLayout(offsetFrame);
 
   std::vector<QString> speed_limit_offset_texts{
-    SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::NONE)],
-    SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::FIXED)],
-    SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::PERCENT)]
+    tr(SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::NONE)].toStdString().c_str()),
+    tr(SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::FIXED)].toStdString().c_str()),
+    tr(SpeedLimitOffsetTypeTexts[static_cast<int>(SpeedLimitOffsetType::PERCENT)].toStdString().c_str())
   };
   speed_limit_offset_settings = new ButtonParamControlSP(
     "SpeedLimitOffsetType",
@@ -122,6 +122,12 @@ void SpeedLimitSettings::refresh() {
 
     has_longitudinal_control = hasLongitudinalControl(CP);
     intelligent_cruise_button_management_available = CP_SP.getIntelligentCruiseButtonManagementAvailable();
+
+    if (!has_longitudinal_control && CP_SP.getPcmCruiseSpeed()) {
+      if (speed_limit_mode_param == SpeedLimitMode::ASSIST) {
+        params.put("SpeedLimitMode", std::to_string(static_cast<int>(SpeedLimitMode::WARNING)));
+      }
+    }
   } else {
     has_longitudinal_control = false;
     intelligent_cruise_button_management_available = false;
@@ -148,7 +154,7 @@ void SpeedLimitSettings::refresh() {
     speed_limit_mode_settings->setEnableSelectedButtons(true, convertSpeedLimitModeValues(getSpeedLimitModeValues()));
   } else {
     speed_limit_mode_settings->setEnableSelectedButtons(true, convertSpeedLimitModeValues(
-      {SpeedLimitMode::OFF,SpeedLimitMode::INFORMATION, SpeedLimitMode::WARNING}));
+      {SpeedLimitMode::OFF, SpeedLimitMode::INFORMATION, SpeedLimitMode::WARNING}));
   }
 
   speed_limit_mode_settings->showDescription();

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal_panel.cc

@@ -43,6 +43,15 @@ LongitudinalPanel::LongitudinalPanel(QWidget *parent) : QWidget(parent) {
   intelligentCruiseButtonManagement->setConfirmation(true, false);
   list->addItem(intelligentCruiseButtonManagement);
 
+  dynamicExperimentalControl = new ParamControlSP(
+    "DynamicExperimentalControl",
+    tr("Dynamic Experimental Control (DEC)"),
+    tr("Enable toggle to allow the model to determine when to use sunnypilot ACC or sunnypilot End to End Longitudinal."),
+    "",
+    this
+  );
+  list->addItem(dynamicExperimentalControl);
+
   SmartCruiseControlVision = new ParamControl(
     "SmartCruiseControlVision",
     tr("Smart Cruise Control - Vision"),
@@ -104,6 +113,17 @@ void LongitudinalPanel::refresh(bool _offroad) {
     has_longitudinal_control = hasLongitudinalControl(CP);
     is_pcm_cruise = CP.getPcmCruise();
     intelligent_cruise_button_management_available = CP_SP.getIntelligentCruiseButtonManagementAvailable();
+
+    if (!intelligent_cruise_button_management_available || has_longitudinal_control) {
+      params.remove("IntelligentCruiseButtonManagement");
+    }
+
+    if (!has_longitudinal_control && CP_SP.getPcmCruiseSpeed()) {
+      params.remove("CustomAccIncrementsEnabled");
+      params.remove("DynamicExperimentalControl");
+      params.remove("SmartCruiseControlVision");
+      params.remove("SmartCruiseControlMap");
+    }
   } else {
     has_longitudinal_control = false;
     is_pcm_cruise = false;
@@ -127,11 +147,9 @@ void LongitudinalPanel::refresh(bool _offroad) {
         customAccIncrement->setDescription(accEnabledDescription);
       }
     } else {
-      params.remove("CustomAccIncrementsEnabled");
       customAccIncrement->toggleFlipped(false);
       customAccIncrement->setDescription(accNoLongDescription);
       customAccIncrement->showDescription();
-      params.remove("IntelligentCruiseButtonManagement");
       intelligentCruiseButtonManagement->toggleFlipped(false);
     }
   }
@@ -144,6 +162,7 @@ void LongitudinalPanel::refresh(bool _offroad) {
   customAccIncrement->setEnabled(cai_allowed && !offroad);
   customAccIncrement->refresh();
 
+  dynamicExperimentalControl->setEnabled(has_longitudinal_control);
   SmartCruiseControlVision->setEnabled(has_longitudinal_control || icbm_allowed);
   SmartCruiseControlMap->setEnabled(has_longitudinal_control || icbm_allowed);
 

selfdrive/ui/sunnypilot/qt/offroad/settings/longitudinal_panel.h

@@ -35,6 +35,7 @@ private:
   ParamControl *SmartCruiseControlVision;
   ParamControl *SmartCruiseControlMap;
   ParamControl *intelligentCruiseButtonManagement = nullptr;
+  ParamControl *dynamicExperimentalControl = nullptr;
   SpeedLimitSettings *speedLimitScreen;
   PushButtonSP *speedLimitSettings;
 };

selfdrive/ui/sunnypilot/qt/offroad/settings/vehicle/subaru_settings.cc

@@ -8,7 +8,52 @@
 #include "selfdrive/ui/sunnypilot/qt/offroad/settings/vehicle/subaru_settings.h"
 
 SubaruSettings::SubaruSettings(QWidget *parent) : BrandSettingsInterface(parent) {
+  stopAndGoToggle = new ParamControl("SubaruStopAndGo", tr("Stop and Go (Beta)"), "", "");
+  stopAndGoToggle->setConfirmation(true, false);
+  list->addItem(stopAndGoToggle);
+
+  stopAndGoManualParkingBrakeToggle = new ParamControl(
+    "SubaruStopAndGoManualParkingBrake",
+    tr("Stop and Go for Manual Parking Brake (Beta)"),
+    "",
+    ""
+  );
+  stopAndGoManualParkingBrakeToggle->setConfirmation(true, false);
+  list->addItem(stopAndGoManualParkingBrakeToggle);
 }
 
 void SubaruSettings::updateSettings() {
+  auto cp_bytes = params.get("CarParamsPersistent");
+  if (!cp_bytes.empty()) {
+    AlignedBuffer aligned_buf;
+    capnp::FlatArrayMessageReader cmsg(aligned_buf.align(cp_bytes.data(), cp_bytes.size()));
+    cereal::CarParams::Reader CP = cmsg.getRoot<cereal::CarParams>();
+
+    is_subaru = CP.getBrand() == "subaru";
+
+    if (is_subaru) {
+      if (!(CP.getFlags() & (SUBARU_FLAG_GLOBAL_GEN2 | SUBARU_FLAG_HYBRID))) {
+        has_stop_and_go = true;
+      }
+    }
+  } else {
+    is_subaru = false;
+    has_stop_and_go = false;
+  }
+
+  bool stop_and_go_disabled = !offroad || !has_stop_and_go;
+  QString stop_and_go_desc = stopAndGoDescriptionBuilder(stopAndGoDesc);
+  QString stop_and_go_manual_parking_brake_desc = stopAndGoDescriptionBuilder(stopAndGoManualParkingBrakeDesc);
+  if (stop_and_go_disabled) {
+    stop_and_go_desc = stopAndGoDescriptionBuilder(stopAndGoDesc, stopAndGoDisabledMsg());
+    stop_and_go_manual_parking_brake_desc = stopAndGoDescriptionBuilder(stopAndGoManualParkingBrakeDesc, stopAndGoDisabledMsg());
+  }
+
+  stopAndGoToggle->setEnabled(has_stop_and_go);
+  stopAndGoToggle->setDescription(stop_and_go_desc);
+  stopAndGoToggle->showDescription();
+
+  stopAndGoManualParkingBrakeToggle->setEnabled(has_stop_and_go);
+  stopAndGoManualParkingBrakeToggle->setDescription(stop_and_go_manual_parking_brake_desc);
+  stopAndGoManualParkingBrakeToggle->showDescription();
 }

selfdrive/ui/sunnypilot/qt/offroad/settings/vehicle/subaru_settings.h

@@ -14,6 +14,9 @@
 #include "selfdrive/ui/sunnypilot/qt/offroad/settings/settings.h"
 #include "selfdrive/ui/sunnypilot/qt/widgets/controls.h"
 
+const int SUBARU_FLAG_GLOBAL_GEN2 = 4;
+const int SUBARU_FLAG_HYBRID = 32;
+
 class SubaruSettings : public BrandSettingsInterface {
   Q_OBJECT
 
@@ -23,4 +26,32 @@ public:
 
 private:
   bool offroad = false;
+  bool is_subaru;
+  bool has_stop_and_go;
+
+  ParamControl* stopAndGoToggle;
+  ParamControl* stopAndGoManualParkingBrakeToggle;
+
+  QString stopAndGoDesc = tr("Experimental feature to enable auto-resume during stop-and-go for certain supported Subaru platforms.");
+  QString stopAndGoManualParkingBrakeDesc = tr("Experimental feature to enable stop and go for Subaru Global models with manual handbrake. Models with electric parking brake should keep this disabled. Thanks to martinl for this implementation!");
+
+  QString stopAndGoDisabledMsg() const {
+    if (is_subaru && !has_stop_and_go) {
+      return tr("This feature is currently not available on this platform.");
+    }
+
+    if (!is_subaru) {
+      return tr("Start the car to check car compatibility.");
+    }
+
+    if (!offroad) {
+      return tr("Enable \"Always Offroad\" in Device panel, or turn vehicle off to toggle.");
+    }
+
+    return QString();
+  }
+
+  static QString stopAndGoDescriptionBuilder(const QString &base_description, const QString &custom_description = "") {
+    return "<b>" + custom_description + "</b><br><br>" + base_description;
+  }
 };

selfdrive/ui/sunnypilot/qt/onroad/hud.cc

@@ -12,43 +12,65 @@
 
 
 HudRendererSP::HudRendererSP() {
-  plus_arrow_up_img = loadPixmap("../../sunnypilot/selfdrive/assets/img_plus_arrow_up", {105, 105});
-  minus_arrow_down_img = loadPixmap("../../sunnypilot/selfdrive/assets/img_minus_arrow_down", {105, 105});
+  plus_arrow_up_img = loadPixmap("../../sunnypilot/selfdrive/assets/img_plus_arrow_up", {90, 90});
+  minus_arrow_down_img = loadPixmap("../../sunnypilot/selfdrive/assets/img_minus_arrow_down", {90, 90});
 
-  int small_max = e2e_alert_small * 2 - 40;
-  int large_max = e2e_alert_large * 2 - 40;
-  green_light_alert_small_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/green_light.png", {small_max, small_max});
-  green_light_alert_large_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/green_light.png", {large_max, large_max});
-  lead_depart_alert_small_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/lead_depart.png", {small_max, small_max});
-  lead_depart_alert_large_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/lead_depart.png", {large_max, large_max});
+  int size = e2e_alert_size * 2 - 40;
+  green_light_alert_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/green_light.png", {size, size});
+  lead_depart_alert_img = loadPixmap("../../sunnypilot/selfdrive/assets/images/lead_depart.png", {size, size});
 }
 
 void HudRendererSP::updateState(const UIState &s) {
   HudRenderer::updateState(s);
 
+  float speedConv = is_metric ? MS_TO_KPH : MS_TO_MPH;
+  devUiInfo = s.scene.dev_ui_info;
+  roadName = s.scene.road_name;
+  showTurnSignals = s.scene.turn_signals;
+  speedLimitMode = static_cast<SpeedLimitMode>(s.scene.speed_limit_mode);
+  speedUnit = is_metric ? tr("km/h") : tr("mph");
+  standstillTimer = s.scene.standstill_timer;
+
   const SubMaster &sm = *(s.sm);
   const auto cs = sm["controlsState"].getControlsState();
   const auto car_state = sm["carState"].getCarState();
   const auto car_control = sm["carControl"].getCarControl();
   const auto radar_state = sm["radarState"].getRadarState();
   const auto is_gps_location_external = sm.rcv_frame("gpsLocationExternal") > 1;
-  const auto gpsLocation = is_gps_location_external ? sm["gpsLocationExternal"].getGpsLocationExternal() : sm["gpsLocation"].getGpsLocation();
+  const char *gps_source = is_gps_location_external ? "gpsLocationExternal" : "gpsLocation";
+  const auto gpsLocation = is_gps_location_external ? sm[gps_source].getGpsLocationExternal() : sm[gps_source].getGpsLocation();
   const auto ltp = sm["liveTorqueParameters"].getLiveTorqueParameters();
   const auto car_params = sm["carParams"].getCarParams();
+  const auto car_params_sp = sm["carParamsSP"].getCarParamsSP();
   const auto lp_sp = sm["longitudinalPlanSP"].getLongitudinalPlanSP();
   const auto lmd = sm["liveMapDataSP"].getLiveMapDataSP();
 
-  float speedConv = is_metric ? MS_TO_KPH : MS_TO_MPH;
-  speedLimit = lp_sp.getSpeedLimit().getResolver().getSpeedLimit() * speedConv;
-  speedLimitLast = lp_sp.getSpeedLimit().getResolver().getSpeedLimitLast() * speedConv;
-  speedLimitOffset = lp_sp.getSpeedLimit().getResolver().getSpeedLimitOffset() * speedConv;
-  speedLimitValid = lp_sp.getSpeedLimit().getResolver().getSpeedLimitValid();
-  speedLimitLastValid = lp_sp.getSpeedLimit().getResolver().getSpeedLimitLastValid();
-  speedLimitFinalLast = lp_sp.getSpeedLimit().getResolver().getSpeedLimitFinalLast() * speedConv;
-  speedLimitMode = static_cast<SpeedLimitMode>(s.scene.speed_limit_mode);
-  speedLimitAssistState = lp_sp.getSpeedLimit().getAssist().getState();
-  speedLimitAssistActive = lp_sp.getSpeedLimit().getAssist().getActive();
-  roadName = s.scene.road_name;
+  if (sm.updated("carParams")) {
+    steerControlType = car_params.getSteerControlType();
+  }
+
+  if (sm.updated("carParamsSP")) {
+    pcmCruiseSpeed = car_params_sp.getPcmCruiseSpeed();
+  }
+
+  if (sm.updated("longitudinalPlanSP")) {
+    speedLimit = lp_sp.getSpeedLimit().getResolver().getSpeedLimit() * speedConv;
+    speedLimitLast = lp_sp.getSpeedLimit().getResolver().getSpeedLimitLast() * speedConv;
+    speedLimitOffset = lp_sp.getSpeedLimit().getResolver().getSpeedLimitOffset() * speedConv;
+    speedLimitValid = lp_sp.getSpeedLimit().getResolver().getSpeedLimitValid();
+    speedLimitLastValid = lp_sp.getSpeedLimit().getResolver().getSpeedLimitLastValid();
+    speedLimitFinalLast = lp_sp.getSpeedLimit().getResolver().getSpeedLimitFinalLast() * speedConv;
+    speedLimitSource = lp_sp.getSpeedLimit().getResolver().getSource();
+    speedLimitAssistState = lp_sp.getSpeedLimit().getAssist().getState();
+    speedLimitAssistActive = lp_sp.getSpeedLimit().getAssist().getActive();
+    smartCruiseControlVisionEnabled = lp_sp.getSmartCruiseControl().getVision().getEnabled();
+    smartCruiseControlVisionActive = lp_sp.getSmartCruiseControl().getVision().getActive();
+    smartCruiseControlMapEnabled = lp_sp.getSmartCruiseControl().getMap().getEnabled();
+    smartCruiseControlMapActive = lp_sp.getSmartCruiseControl().getMap().getActive();
+  }
+  greenLightAlert = lp_sp.getE2eAlerts().getGreenLightAlert();
+  leadDepartAlert = lp_sp.getE2eAlerts().getLeadDepartAlert();
+
   if (sm.updated("liveMapDataSP")) {
     roadNameStr = QString::fromStdString(lmd.getRoadName());
     speedLimitAheadValid = lmd.getSpeedLimitAheadValid();
@@ -64,7 +86,7 @@ void HudRendererSP::updateState(const UIState &s) {
 
   static int reverse_delay = 0;
   bool reverse_allowed = false;
-  if (int(car_state.getGearShifter()) != 4) {
+  if (car_state.getGearShifter() != cereal::CarState::GearShifter::REVERSE) {
     reverse_delay = 0;
     reverse_allowed = false;
   } else {
@@ -76,46 +98,47 @@ void HudRendererSP::updateState(const UIState &s) {
 
   reversing = reverse_allowed;
 
+  if (sm.updated("liveParameters")) {
+    roll = sm["liveParameters"].getLiveParameters().getRoll();
+  }
+
+  if (sm.updated("deviceState")) {
+    memoryUsagePercent = sm["deviceState"].getDeviceState().getMemoryUsagePercent();
+  }
+
+  if (sm.updated(gps_source)) {
+    gpsAccuracy = is_gps_location_external ? gpsLocation.getHorizontalAccuracy() : 1.0;  // External reports accuracy, internal does not.
+    altitude = gpsLocation.getAltitude();
+    bearingAccuracyDeg = gpsLocation.getBearingAccuracyDeg();
+    bearingDeg = gpsLocation.getBearingDeg();
+  }
+
+  if (sm.updated("liveTorqueParameters")) {
+    torquedUseParams = ltp.getUseParams();
+    latAccelFactorFiltered = ltp.getLatAccelFactorFiltered();
+    frictionCoefficientFiltered = ltp.getFrictionCoefficientFiltered();
+    liveValid = ltp.getLiveValid();
+  }
+
   latActive = car_control.getLatActive();
+  actuators = car_control.getActuators();
+  longOverride = car_control.getCruiseControl().getOverride();
+  carControlEnabled = car_control.getEnabled();
+
   steerOverride = car_state.getSteeringPressed();
-
-  devUiInfo = s.scene.dev_ui_info;
-
-  speedUnit = is_metric ? tr("km/h") : tr("mph");
   lead_d_rel = radar_state.getLeadOne().getDRel();
   lead_v_rel = radar_state.getLeadOne().getVRel();
   lead_status = radar_state.getLeadOne().getStatus();
-  steerControlType = car_params.getSteerControlType();
-  actuators = car_control.getActuators();
   torqueLateral = steerControlType == cereal::CarParams::SteerControlType::TORQUE;
   angleSteers = car_state.getSteeringAngleDeg();
   desiredCurvature = cs.getDesiredCurvature();
   curvature = cs.getCurvature();
-  roll = sm["liveParameters"].getLiveParameters().getRoll();
-  memoryUsagePercent = sm["deviceState"].getDeviceState().getMemoryUsagePercent();
-  gpsAccuracy = is_gps_location_external ? gpsLocation.getHorizontalAccuracy() : 1.0;  // External reports accuracy, internal does not.
-  altitude = gpsLocation.getAltitude();
   vEgo = car_state.getVEgo();
   aEgo = car_state.getAEgo();
   steeringTorqueEps = car_state.getSteeringTorqueEps();
-  bearingAccuracyDeg = gpsLocation.getBearingAccuracyDeg();
-  bearingDeg = gpsLocation.getBearingDeg();
-  torquedUseParams = ltp.getUseParams();
-  latAccelFactorFiltered = ltp.getLatAccelFactorFiltered();
-  frictionCoefficientFiltered = ltp.getFrictionCoefficientFiltered();
-  liveValid = ltp.getLiveValid();
 
-  standstillTimer = s.scene.standstill_timer;
   isStandstill = car_state.getStandstill();
-  if (not s.scene.started) standstillElapsedTime = 0.0;
-  longOverride = car_control.getCruiseControl().getOverride();
-  smartCruiseControlVisionEnabled = lp_sp.getSmartCruiseControl().getVision().getEnabled();
-  smartCruiseControlVisionActive = lp_sp.getSmartCruiseControl().getVision().getActive();
-  smartCruiseControlMapEnabled = lp_sp.getSmartCruiseControl().getMap().getEnabled();
-  smartCruiseControlMapActive = lp_sp.getSmartCruiseControl().getMap().getActive();
-
-  greenLightAlert = lp_sp.getE2eAlerts().getGreenLightAlert();
-  leadDepartAlert = lp_sp.getE2eAlerts().getLeadDepartAlert();
+  if (!s.scene.started) standstillElapsedTime = 0.0;
 
   // override stock current speed values
   float v_ego = (v_ego_cluster_seen && !s.scene.trueVEgoUI) ? car_state.getVEgoCluster() : car_state.getVEgo();
@@ -126,10 +149,11 @@ void HudRendererSP::updateState(const UIState &s) {
   rightBlinkerOn = car_state.getRightBlinker();
   leftBlindspot = car_state.getLeftBlindspot();
   rightBlindspot = car_state.getRightBlindspot();
-  showTurnSignals = s.scene.turn_signals;
 
-  carControlEnabled = car_control.getEnabled();
   speedCluster = car_state.getCruiseState().getSpeedCluster() * speedConv;
+
+  allow_e2e_alerts = sm["selfdriveState"].getSelfdriveState().getAlertSize() == cereal::SelfdriveState::AlertSize::NONE &&
+                     sm.rcv_frame("driverStateV2") > s.scene.started_frame && !reversing;
 }
 
 void HudRendererSP::draw(QPainter &p, const QRect &surface_rect) {
@@ -222,7 +246,7 @@ void HudRendererSP::draw(QPainter &p, const QRect &surface_rect) {
     drawRoadName(p, surface_rect);
 
     // Green Light & Lead Depart Alerts
-    if (greenLightAlert or leadDepartAlert) {
+    if (greenLightAlert || leadDepartAlert) {
       e2eAlertDisplayTimer = 3 * UI_FREQ;
       // reset onroad sleep timer for e2e alerts
       uiStateSP()->reset_onroad_sleep_timer();
@@ -232,11 +256,11 @@ void HudRendererSP::draw(QPainter &p, const QRect &surface_rect) {
       e2eAlertFrame++;
       if (greenLightAlert) {
         alert_text = tr("GREEN\nLIGHT");
-        alert_img = devUiInfo > 0 ? green_light_alert_small_img : green_light_alert_large_img;
+        alert_img = green_light_alert_img;
       }
       else if (leadDepartAlert) {
         alert_text = tr("LEAD VEHICLE\nDEPARTING");
-        alert_img = devUiInfo > 0 ? lead_depart_alert_small_img : lead_depart_alert_large_img;
+        alert_img = lead_depart_alert_img;
       }
       drawE2eAlert(p, surface_rect);
     }
@@ -254,7 +278,7 @@ void HudRendererSP::draw(QPainter &p, const QRect &surface_rect) {
     // No Alerts displayed
     else {
       e2eAlertFrame = 0;
-      if (not isStandstill) standstillElapsedTime = 0.0;
+      if (!isStandstill) standstillElapsedTime = 0.0;
     }
 
     // Blinker
@@ -545,7 +569,8 @@ void HudRendererSP::drawSpeedLimitSigns(QPainter &p, QRect &sign_rect) {
 }
 
 void HudRendererSP::drawUpcomingSpeedLimit(QPainter &p) {
-  bool speed_limit_ahead = speedLimitAheadValid && speedLimitAhead > 0 && speedLimitAhead != speedLimit && speedLimitAheadValidFrame > 0;
+  bool speed_limit_ahead = speedLimitAheadValid && speedLimitAhead > 0 && speedLimitAhead != speedLimit && speedLimitAheadValidFrame > 0 &&
+                           speedLimitSource == cereal::LongitudinalPlanSP::SpeedLimit::Source::MAP;
   if (!speed_limit_ahead) {
     return;
   }
@@ -639,7 +664,7 @@ void HudRendererSP::drawRoadName(QPainter &p, const QRect &surface_rect) {
 
 void HudRendererSP::drawSpeedLimitPreActiveArrow(QPainter &p, QRect &sign_rect) {
   const int sign_margin = 12;
-  const int arrow_spacing = sign_margin * 3;
+  const int arrow_spacing = sign_margin * 1.4;
   int arrow_x = sign_rect.right() + arrow_spacing;
 
   int _set_speed = std::nearbyint(set_speed);
@@ -689,7 +714,7 @@ void HudRendererSP::drawSetSpeedSP(QPainter &p, const QRect &surface_rect) {
   }
 
   // Draw "MAX" or carState.cruiseState.speedCluster (when ICBM is active) text
-  if (carControlEnabled) {
+  if (!pcmCruiseSpeed && carControlEnabled) {
     if (std::nearbyint(set_speed) != std::nearbyint(speedCluster)) {
       icbm_active_counter = 3 * UI_FREQ;
     } else if (icbm_active_counter > 0) {
@@ -714,26 +739,26 @@ void HudRendererSP::drawSetSpeedSP(QPainter &p, const QRect &surface_rect) {
 }
 
 void HudRendererSP::drawE2eAlert(QPainter &p, const QRect &surface_rect, const QString &alert_alt_text) {
-  int size = devUiInfo > 0 ? e2e_alert_small : e2e_alert_large;
-  int x = surface_rect.center().x() + surface_rect.width() / 4;
+  if (!allow_e2e_alerts) return;
+
+  int x = surface_rect.right() - e2e_alert_size - (devUiInfo > 0 ? 180 : 100) - (UI_BORDER_SIZE * 3);
   int y = surface_rect.center().y() + 20;
-  x += devUiInfo > 0 ? 0 : 50;
-  QRect alertRect(x - size, y - size, size * 2, size * 2);
+  QRect alertRect(x - e2e_alert_size, y - e2e_alert_size, e2e_alert_size * 2, e2e_alert_size * 2);
 
   // Alert Circle
   QPoint center = alertRect.center();
   QColor frameColor;
-  if (not alert_alt_text.isEmpty()) frameColor = QColor(255, 255, 255, 75);
+  if (!alert_alt_text.isEmpty()) frameColor = QColor(255, 255, 255, 75);
   else frameColor = pulseElement(e2eAlertFrame) ? QColor(255, 255, 255, 75) : QColor(0, 255, 0, 75);
   p.setPen(QPen(frameColor, 15));
   p.setBrush(QColor(0, 0, 0, 190));
-  p.drawEllipse(center, size, size);
+  p.drawEllipse(center, e2e_alert_size, e2e_alert_size);
 
   // Alert Text
   QColor txtColor;
   QFont font;
   int alert_bottom_adjustment;
-  if (not alert_alt_text.isEmpty()) {
+  if (!alert_alt_text.isEmpty()) {
     font = InterFont(100, QFont::Bold);
     alert_bottom_adjustment = 5;
     txtColor = QColor(255, 255, 255, 255);
@@ -750,7 +775,7 @@ void HudRendererSP::drawE2eAlert(QPainter &p, const QRect &surface_rect, const Q
   textRect.moveBottom(alertRect.bottom() - alertRect.height() / alert_bottom_adjustment);
   p.drawText(textRect, Qt::AlignCenter, alert_text);
 
-  if (not alert_alt_text.isEmpty()) {
+  if (!alert_alt_text.isEmpty()) {
     // Alert Alternate Text
     p.setFont(InterFont(80, QFont::Bold));
     p.setPen(QColor(255, 175, 3, 240));
@@ -779,7 +804,7 @@ void HudRendererSP::drawCurrentSpeedSP(QPainter &p, const QRect &surface_rect) {
 
 void HudRendererSP::drawBlinker(QPainter &p, const QRect &surface_rect) {
   const bool hazard = leftBlinkerOn && rightBlinkerOn;
-  int blinkerStatus = hazard ? 2 : (leftBlinkerOn or rightBlinkerOn) ? 1 : 0;
+  int blinkerStatus = hazard ? 2 : (leftBlinkerOn || rightBlinkerOn) ? 1 : 0;
 
   if (!leftBlinkerOn && !rightBlinkerOn) {
     blinkerFrameCounter = 0;

selfdrive/ui/sunnypilot/qt/onroad/hud.h

@@ -83,6 +83,7 @@ private:
   bool speedLimitValid;
   bool speedLimitLastValid;
   float speedLimitFinalLast;
+  cereal::LongitudinalPlanSP::SpeedLimit::Source speedLimitSource;
   bool speedLimitAheadValid;
   float speedLimitAhead;
   float speedLimitAheadDistance;
@@ -96,16 +97,14 @@ private:
   int speedLimitAssistFrame;
   QPixmap plus_arrow_up_img;
   QPixmap minus_arrow_down_img;
-  int e2e_alert_small = 250;
-  int e2e_alert_large = 300;
-  QPixmap green_light_alert_small_img;
-  QPixmap green_light_alert_large_img;
+  int e2e_alert_size = 250;
+  QPixmap green_light_alert_img;
   bool greenLightAlert;
   int e2eAlertFrame;
   int e2eAlertDisplayTimer = 0;
+  bool allow_e2e_alerts;
   bool leadDepartAlert;
-  QPixmap lead_depart_alert_small_img;
-  QPixmap lead_depart_alert_large_img;
+  QPixmap lead_depart_alert_img;
   QString alert_text;
   QPixmap alert_img;
   bool hideVEgoUI;
@@ -120,4 +119,5 @@ private:
   bool carControlEnabled;
   float speedCluster = 0;
   int icbm_active_counter = 0;
+  bool pcmCruiseSpeed = true;
 };

selfdrive/ui/sunnypilot/qt/onroad/model.cc

@@ -21,74 +21,73 @@ void ModelRendererSP::update_model(const cereal::ModelDataV2::Reader &model, con
   mapLineToPolygon(model.getLaneLines()[2], 0.2, -0.05, &right_blindspot_vertices, max_idx_barrier);
 }
 
-void ModelRendererSP::drawPath(QPainter &painter, const cereal::ModelDataV2::Reader &model, const QRect &surface_rect) {
+void ModelRendererSP::draw(QPainter &painter, const QRect &surface_rect) {
   auto *s = uiState();
   auto &sm = *(s->sm);
-  bool blindspot = s->scene.blindspot_ui;
 
-  if (blindspot) {
-    bool left_blindspot = sm["carState"].getCarState().getLeftBlindspot();
-    bool right_blindspot = sm["carState"].getCarState().getRightBlindspot();
-
-    //painter.setBrush(QColor::fromRgbF(1.0, 0.0, 0.0, 0.4));  // Red with alpha for blind spot
-
-    if (left_blindspot && !left_blindspot_vertices.isEmpty()) {
-      QLinearGradient gradient(0, 0, surface_rect.width(), 0); // Horizontal gradient from left to right
-      gradient.setColorAt(0.0, QColor(255, 165, 0, 102)); // Orange with alpha
-      gradient.setColorAt(1.0, QColor(255, 255, 0, 102)); // Yellow with alpha
-      painter.setBrush(gradient);
-      painter.drawPolygon(left_blindspot_vertices);
-    }
-
-    if (right_blindspot && !right_blindspot_vertices.isEmpty()) {
-      QLinearGradient gradient(surface_rect.width(), 0, 0, 0); // Horizontal gradient from right to left
-      gradient.setColorAt(0.0, QColor(255, 165, 0, 102)); // Orange with alpha
-      gradient.setColorAt(1.0, QColor(255, 255, 0, 102)); // Yellow with alpha
-      painter.setBrush(gradient);
-      painter.drawPolygon(right_blindspot_vertices);
-    }
+  if (sm.rcv_frame("liveCalibration") < s->scene.started_frame ||
+      sm.rcv_frame("modelV2") < s->scene.started_frame) {
+    return;
   }
 
-  bool rainbow = s->scene.rainbow_mode;
-  //float v_ego = sm["carState"].getCarState().getVEgo();
+  clip_region = surface_rect.adjusted(-CLIP_MARGIN, -CLIP_MARGIN, CLIP_MARGIN, CLIP_MARGIN);
+  experimental_mode = sm["selfdriveState"].getSelfdriveState().getExperimentalMode();
+  longitudinal_control = sm["carParams"].getCarParams().getOpenpilotLongitudinalControl();
+  path_offset_z = sm["liveCalibration"].getLiveCalibration().getHeight()[0];
 
-  if (rainbow) {
-    // Simple time-based animation
-    float time_offset = std::chrono::duration_cast<std::chrono::milliseconds>(
-        std::chrono::steady_clock::now().time_since_epoch()).count() / 1000.0f;
+  painter.save();
 
-    // simple linear gradient from bottom to top
-    QLinearGradient bg(0, surface_rect.height(), 0, 0);
+  const auto &model = sm["modelV2"].getModelV2();
+  const auto &radar_state = sm["radarState"].getRadarState();
+  const auto &lead_one = radar_state.getLeadOne();
+  const auto &car_state = sm["carState"].getCarState();
 
-    // evenly spaced colors across the spectrum
-    // The animation shifts the entire spectrum smoothly
-    float animation_speed = 40.0f; // speed vroom vroom
-    float hue_offset = fmod(time_offset * animation_speed, 360.0f);
+  update_model(model, lead_one);
+  drawLaneLines(painter);
 
-    // 6-8 color stops for smooth transitions more color makes it laggy
-    const int num_stops = 7;
-    for (int i = 0; i < num_stops; i++) {
-      float position = static_cast<float>(i) / (num_stops - 1);
-
-      float hue = fmod(hue_offset + position * 360.0f, 360.0f);
-      float saturation = 0.9f;
-      float lightness = 0.6f;
-
-      // Alpha fades out towards the far end of the path
-      float alpha = 0.8f * (1.0f - position * 0.3f);
-
-      QColor color = QColor::fromHslF(hue / 360.0f, saturation, lightness, alpha);
-      bg.setColorAt(position, color);
-    }
-
-    painter.setBrush(bg);
-    painter.drawPolygon(track_vertices);
+  if (s->scene.rainbow_mode) {
+    drawRainbowPath(painter, surface_rect);
   } else {
-    // Normal path rendering
     ModelRenderer::drawPath(painter, model, surface_rect.height());
   }
 
+  if (longitudinal_control && sm.alive("radarState")) {
+    update_leads(radar_state, model.getPosition());
+    const auto &lead_two = radar_state.getLeadTwo();
+    if (lead_one.getStatus()) {
+      drawLead(painter, lead_one, lead_vertices[0], surface_rect);
+    }
+    if (lead_two.getStatus() && (std::abs(lead_one.getDRel() - lead_two.getDRel()) > 3.0)) {
+      drawLead(painter, lead_two, lead_vertices[1], surface_rect);
+    }
+  }
+
+  if (s->scene.blindspot_ui) {
+    const bool left_blindspot = car_state.getLeftBlindspot();
+    const bool right_blindspot = car_state.getRightBlindspot();
+    drawBlindspot(painter, surface_rect, left_blindspot, right_blindspot);
+  }
   drawLeadStatus(painter, surface_rect.height(), surface_rect.width());
+
+  painter.restore();
+}
+
+void ModelRendererSP::drawBlindspot(QPainter &painter, const QRect &surface_rect, bool left_blindspot, bool right_blindspot) {
+  if (left_blindspot && !left_blindspot_vertices.isEmpty()) {
+    QLinearGradient gradient(0, 0, surface_rect.width(), 0); // Horizontal gradient from left to right
+    gradient.setColorAt(0.0, QColor(255, 165, 0, 102)); // Orange with alpha
+    gradient.setColorAt(1.0, QColor(255, 255, 0, 102)); // Yellow with alpha
+    painter.setBrush(gradient);
+    painter.drawPolygon(left_blindspot_vertices);
+  }
+
+  if (right_blindspot && !right_blindspot_vertices.isEmpty()) {
+    QLinearGradient gradient(surface_rect.width(), 0, 0, 0); // Horizontal gradient from right to left
+    gradient.setColorAt(0.0, QColor(255, 165, 0, 102)); // Orange with alpha
+    gradient.setColorAt(1.0, QColor(255, 255, 0, 102)); // Yellow with alpha
+    painter.setBrush(gradient);
+    painter.drawPolygon(right_blindspot_vertices);
+  }
 }
 
 void ModelRendererSP::drawLeadStatus(QPainter &painter, int height, int width) {
@@ -121,19 +120,16 @@ void ModelRendererSP::drawLeadStatus(QPainter &painter, int height, int width) {
   }
 
   if (has_lead_one) {
-    drawLeadStatusAtPosition(painter, lead_one, lead_vertices[0], height, width, "L1");
+    drawLeadStatusPosition(painter, lead_one, lead_vertices[0], height, width);
   }
 
   if (has_lead_two && std::abs(lead_one.getDRel() - lead_two.getDRel()) > 3.0) {
-    drawLeadStatusAtPosition(painter, lead_two, lead_vertices[1], height, width, "L2");
+    drawLeadStatusPosition(painter, lead_two, lead_vertices[1], height, width);
   }
 }
 
-void ModelRendererSP::drawLeadStatusAtPosition(QPainter &painter,
-                                               const cereal::RadarState::LeadData::Reader &lead_data,
-                                               const QPointF &chevron_pos,
-                                               int height, int width,
-                                               const QString &label) {
+void ModelRendererSP::drawLeadStatusPosition(QPainter &painter, const cereal::RadarState::LeadData::Reader &lead_data,
+                                             const QPointF &chevron_pos, int height, int width) {
   float d_rel = lead_data.getDRel();
   float v_rel = lead_data.getVRel();
   auto *s = uiState();
@@ -223,3 +219,36 @@ void ModelRendererSP::drawLeadStatusAtPosition(QPainter &painter,
 
   painter.setPen(Qt::NoPen);
 }
+
+void ModelRendererSP::drawRainbowPath(QPainter &painter, const QRect &surface_rect) {
+  // Simple time-based animation
+  float time_offset = std::chrono::duration_cast<std::chrono::milliseconds>(
+      std::chrono::steady_clock::now().time_since_epoch()).count() / 1000.0f;
+
+  // simple linear gradient from bottom to top
+  QLinearGradient bg(0, surface_rect.height(), 0, 0);
+
+  // evenly spaced colors across the spectrum
+  // The animation shifts the entire spectrum smoothly
+  float animation_speed = 40.0f; // speed vroom vroom
+  float hue_offset = fmod(time_offset * animation_speed, 360.0f);
+
+  // 6-8 color stops for smooth transitions more color makes it laggy
+  const int num_stops = 7;
+  for (int i = 0; i < num_stops; i++) {
+    float position = static_cast<float>(i) / (num_stops - 1);
+
+    float hue = fmod(hue_offset + position * 360.0f, 360.0f);
+    float saturation = 0.9f;
+    float lightness = 0.6f;
+
+    // Alpha fades out towards the far end of the path
+    float alpha = 0.8f * (1.0f - position * 0.3f);
+
+    QColor color = QColor::fromHslF(hue / 360.0f, saturation, lightness, alpha);
+    bg.setColorAt(position, color);
+  }
+
+  painter.setBrush(bg);
+  painter.drawPolygon(track_vertices);
+}

selfdrive/ui/sunnypilot/qt/onroad/model.h

@@ -13,17 +13,15 @@ class ModelRendererSP : public ModelRenderer {
 public:
   ModelRendererSP() = default;
 
+  void draw(QPainter &painter, const QRect &surface_rect);
+
 private:
   void update_model(const cereal::ModelDataV2::Reader &model, const cereal::RadarState::LeadData::Reader &lead) override;
-  void drawPath(QPainter &painter, const cereal::ModelDataV2::Reader &model, const QRect &rect) override;
-
-  // Lead status display methods
   void drawLeadStatus(QPainter &painter, int height, int width);
-  void drawLeadStatusAtPosition(QPainter &painter,
-                                const cereal::RadarState::LeadData::Reader &lead_data,
-                                const QPointF &chevron_pos,
-                                int height, int width,
-                                const QString &label);
+  void drawLeadStatusPosition(QPainter &painter, const cereal::RadarState::LeadData::Reader &lead_data,
+                              const QPointF &chevron_pos, int height, int width);
+  void drawBlindspot(QPainter &painter, const QRect &surface_rect, bool left_blindspot, bool right_blindspot);
+  void drawRainbowPath(QPainter &painter, const QRect &surface_rect);
 
   QPolygonF left_blindspot_vertices;
   QPolygonF right_blindspot_vertices;

selfdrive/ui/sunnypilot/ui.cc

@@ -29,7 +29,7 @@ UIStateSP::UIStateSP(QObject *parent) : UIState(parent) {
     "wideRoadCameraState", "managerState", "selfdriveState", "longitudinalPlan",
     "modelManagerSP", "selfdriveStateSP", "longitudinalPlanSP", "backupManagerSP",
     "carControl", "gpsLocationExternal", "gpsLocation", "liveTorqueParameters",
-    "carStateSP", "liveParameters", "liveMapDataSP"
+    "carStateSP", "liveParameters", "liveMapDataSP", "carParamsSP"
   });
 
   // update timer

selfdrive/ui/translations/main_ko.ts

@@ -1778,62 +1778,6 @@ Warning: You are on a metered connection!</source>
         <source>sunnypilot</source>
         <translation>sunnypilot</translation>
     </message>
-    <message>
-        <source>None</source>
-        <translation>없음</translation>
-    </message>
-    <message>
-        <source>Fixed</source>
-        <translation>고정</translation>
-    </message>
-    <message>
-        <source>Percent</source>
-        <translation>비율</translation>
-    </message>
-    <message>
-        <source>Car
-Only</source>
-        <translation>차량만</translation>
-    </message>
-    <message>
-        <source>Map
-Only</source>
-        <translation>지도만</translation>
-    </message>
-    <message>
-        <source>Car
-First</source>
-        <translation>차량
-우선</translation>
-    </message>
-    <message>
-        <source>Map
-First</source>
-        <translation>지도
-우선</translation>
-    </message>
-    <message>
-        <source>Combined
-Data</source>
-        <translation>결합
-데이터</translation>
-    </message>
-    <message>
-        <source>Off</source>
-        <translation>끄기</translation>
-    </message>
-    <message>
-        <source>Information</source>
-        <translation>정보</translation>
-    </message>
-    <message>
-        <source>Warning</source>
-        <translation>경고</translation>
-    </message>
-    <message>
-        <source>Assist</source>
-        <translation>보조</translation>
-    </message>
 </context>
 <context>
     <name>SettingsWindow</name>
@@ -2198,6 +2142,34 @@ Data</source>
         <source>⦿ Combined: Use combined Speed Limit data from Car &amp; OpenStreetMaps</source>
         <translation>⦿ 결합: 차량 및 OpenStreetMaps의 속도 제한 결합 데이터 사용</translation>
     </message>
+    <message>
+        <source>Car
+Only</source>
+        <translation>차량만</translation>
+    </message>
+    <message>
+        <source>Map
+Only</source>
+        <translation>지도만</translation>
+    </message>
+    <message>
+        <source>Car
+First</source>
+        <translation>차량
+우선</translation>
+    </message>
+    <message>
+        <source>Map
+First</source>
+        <translation>지도
+우선</translation>
+    </message>
+    <message>
+        <source>Combined
+Data</source>
+        <translation>결합
+데이터</translation>
+    </message>
 </context>
 <context>
     <name>SpeedLimitSettings</name>
@@ -2245,6 +2217,34 @@ Data</source>
         <source>⦿ Assist: Adjusts the vehicle&apos;s cruise speed based on the current road&apos;s speed limit when operating the +/- buttons.</source>
         <translation>⦿ 보조: +/- 버튼을 조작할 때 현재 도로의 제한 속도를 기준으로 차량의 크루즈 속도를 조정합니다.</translation>
     </message>
+    <message>
+        <source>None</source>
+        <translation>없음</translation>
+    </message>
+    <message>
+        <source>Fixed</source>
+        <translation>고정</translation>
+    </message>
+    <message>
+        <source>Percent</source>
+        <translation>비율</translation>
+    </message>
+    <message>
+        <source>Off</source>
+        <translation>끄기</translation>
+    </message>
+    <message>
+        <source>Information</source>
+        <translation>정보</translation>
+    </message>
+    <message>
+        <source>Warning</source>
+        <translation>경고</translation>
+    </message>
+    <message>
+        <source>Assist</source>
+        <translation>보조</translation>
+    </message>
 </context>
 <context>
     <name>SshControl</name>

sunnypilot/__init__.py

@@ -5,6 +5,7 @@ This file is part of sunnypilot and is licensed under the MIT License.
 See the LICENSE.md file in the root directory for more details.
 """
 
+from enum import IntEnum
 import hashlib
 
 PARAMS_UPDATE_PERIOD = 3  # seconds
@@ -16,3 +17,23 @@ def get_file_hash(path: str) -> str:
     for byte_block in iter(lambda: f.read(4096), b""):
       sha256_hash.update(byte_block)
   return sha256_hash.hexdigest()
+
+
+class IntEnumBase(IntEnum):
+  @classmethod
+  def min(cls):
+    return min(cls)
+
+  @classmethod
+  def max(cls):
+    return max(cls)
+
+
+def get_sanitize_int_param(key: str, min_val: int, max_val: int, params) -> int:
+  val: int = params.get(key, return_default=True)
+  clipped_val = max(min_val, min(max_val, val))
+
+  if clipped_val != val:
+    params.put(key, clipped_val)
+
+  return clipped_val

sunnypilot/mapd/live_map_data/base_map_data.py

@@ -8,8 +8,12 @@ from abc import abstractmethod, ABC
 
 import cereal.messaging as messaging
 from openpilot.common.params import Params
+from openpilot.common.constants import CV
+from openpilot.selfdrive.car.cruise import V_CRUISE_UNSET
 from openpilot.sunnypilot.navd.helpers import coordinate_from_param
 
+MAX_SPEED_LIMIT = V_CRUISE_UNSET * CV.KPH_TO_MS
+
 
 class BaseMapData(ABC):
   def __init__(self):
@@ -46,9 +50,9 @@ class BaseMapData(ABC):
     mapd_sp_send.valid = self.sm['liveLocationKalman'].gpsOK
     live_map_data = mapd_sp_send.liveMapDataSP
 
-    live_map_data.speedLimitValid = bool(speed_limit > 0)
+    live_map_data.speedLimitValid = bool(MAX_SPEED_LIMIT > speed_limit > 0)
     live_map_data.speedLimit = speed_limit
-    live_map_data.speedLimitAheadValid = bool(next_speed_limit > 0)
+    live_map_data.speedLimitAheadValid = bool(MAX_SPEED_LIMIT > next_speed_limit > 0)
     live_map_data.speedLimitAhead = next_speed_limit
     live_map_data.speedLimitAheadDistance = next_speed_limit_distance
     live_map_data.roadName = self.get_current_road_name()

sunnypilot/selfdrive/car/interfaces.py

@@ -11,6 +11,7 @@ from opendbc.car.interfaces import CarInterfaceBase
 from openpilot.common.params import Params
 from openpilot.common.swaglog import cloudlog
 from openpilot.sunnypilot.selfdrive.controls.lib.nnlc.helpers import get_nn_model_path
+from openpilot.sunnypilot.selfdrive.controls.lib.speed_limit.common import Mode as SpeedLimitMode
 
 import openpilot.system.sentry as sentry
 
@@ -66,6 +67,30 @@ def _initialize_torque_lateral_control(CI: CarInterfaceBase, CP: structs.CarPara
     CI.configure_torque_tune(CP.carFingerprint, CP.lateralTuning)
 
 
+def _cleanup_unsupported_params(CP: structs.CarParams, CP_SP: structs.CarParamsSP, params: Params = None) -> None:
+  if params is None:
+    params = Params()
+
+  if CP.steerControlType == structs.CarParams.SteerControlType.angle:
+    cloudlog.warning("SteerControlType is angle, cleaning up params")
+    params.remove("NeuralNetworkLateralControl")
+    params.remove("EnforceTorqueControl")
+
+  if not CP_SP.intelligentCruiseButtonManagementAvailable or CP.openpilotLongitudinalControl:
+    cloudlog.warning("ICBM not available or openpilot Longitudinal Control enabled, cleaning up params")
+    params.remove("IntelligentCruiseButtonManagement")
+
+  if not CP.openpilotLongitudinalControl and CP_SP.pcmCruiseSpeed:
+    cloudlog.warning("openpilot Longitudinal Control and ICBM not available, cleaning up params")
+    params.remove("DynamicExperimentalControl")
+    params.remove("CustomAccIncrementsEnabled")
+    params.remove("SmartCruiseControlVision")
+    params.remove("SmartCruiseControlMap")
+
+    if params.get("SpeedLimitMode", return_default=True) == SpeedLimitMode.assist:
+      params.put("SpeedLimitMode", int(SpeedLimitMode.warning))
+
+
 def setup_interfaces(CI: CarInterfaceBase, params: Params = None) -> None:
   CP = CI.CP
   CP_SP = CI.CP_SP
@@ -74,6 +99,7 @@ def setup_interfaces(CI: CarInterfaceBase, params: Params = None) -> None:
   nnlc_enabled = _initialize_neural_network_lateral_control(CP, CP_SP, params)
   _initialize_intelligent_cruise_button_management(CP, CP_SP, params)
   _initialize_torque_lateral_control(CI, CP, enforce_torque, nnlc_enabled)
+  _cleanup_unsupported_params(CP, CP_SP)
 
 
 def initialize_params(params) -> list[dict[str, Any]]:
@@ -84,4 +110,10 @@ def initialize_params(params) -> list[dict[str, Any]]:
     "HyundaiLongitudinalTuning"
   ])
 
+  # subaru
+  keys.extend([
+    "SubaruStopAndGo",
+    "SubaruStopAndGoManualParkingBrake",
+  ])
+
   return [{k: params.get(k, return_default=True)} for k in keys]

sunnypilot/selfdrive/controls/lib/e2e_alerts_helper.py

@@ -12,47 +12,159 @@ from openpilot.common.realtime import DT_MDL
 from openpilot.sunnypilot import PARAMS_UPDATE_PERIOD
 from openpilot.sunnypilot.selfdrive.selfdrived.events import EventsSP
 
-TRIGGER_THRESHOLD = 30
+GREEN_LIGHT_X_THRESHOLD = 30
+LEAD_DEPART_DIST_THRESHOLD = 1.0
+TRIGGER_TIMER_THRESHOLD = 0.3
+
+
+class E2EStates:
+  INACTIVE = 0
+  ARMED = 1
+  CONSUMED = 2
 
 
 class E2EAlertsHelper:
   def __init__(self):
     self._params = Params()
-    self._frame = -1
+    self.frame = -1
+    self.green_light_state = E2EStates.INACTIVE
+    self.prev_green_light_state = E2EStates.INACTIVE
+    self.lead_depart_state = E2EStates.INACTIVE
+    self.prev_lead_depart_state = E2EStates.INACTIVE
 
     self.green_light_alert = False
     self.green_light_alert_enabled = self._params.get_bool("GreenLightAlert")
     self.lead_depart_alert = False
     self.lead_depart_alert_enabled = self._params.get_bool("LeadDepartAlert")
 
+    self.green_light_trigger_timer = 0
+    self.lead_depart_trigger_timer = 0
+    self.last_lead_distance = -1
+    self.last_moving_frame = -1
+
+    self.allowed = False
+    self.last_allowed = False
+    self.has_lead = False
+
+    self.lead_depart_arm_timer = 0
+    self.lead_depart_confirmed_lead = False
+    self.lead_depart_armed = False
+
   def _read_params(self) -> None:
-    if self._frame % int(PARAMS_UPDATE_PERIOD / DT_MDL) == 0:
+    if self.frame % int(PARAMS_UPDATE_PERIOD / DT_MDL) == 0:
       self.green_light_alert_enabled = self._params.get_bool("GreenLightAlert")
       self.lead_depart_alert_enabled = self._params.get_bool("LeadDepartAlert")
 
-    self._frame += 1
-
-  def update(self, sm: messaging.SubMaster, events_sp: EventsSP) -> None:
-    self._read_params()
-
-    if not (self.green_light_alert_enabled or self.lead_depart_alert_enabled):
-      return
-
+  def update_alert_trigger(self, sm: messaging.SubMaster):
     CS = sm['carState']
     CC = sm['carControl']
 
     model_x = sm['modelV2'].position.x
     max_idx = len(model_x) - 1
-    has_lead = sm['radarState'].leadOne.status
-    lead_vRel: float = sm['radarState'].leadOne.vRel
+    self.has_lead = sm['radarState'].leadOne.status
+    lead_dRel = sm['radarState'].leadOne.dRel
 
-    # Green light alert
-    self.green_light_alert = (self.green_light_alert_enabled and model_x[max_idx] > TRIGGER_THRESHOLD
-                              and not has_lead and CS.standstill and not CS.gasPressed and not CC.enabled)
+    standstill = CS.standstill
+    moving = not standstill and CS.vEgo > 0.1
+
+    if moving:
+      self.last_moving_frame = self.frame
+    recent_moving = self.last_moving_frame == -1 or (self.frame - self.last_moving_frame) * DT_MDL < 2.0
+
+    self.allowed = not moving and not CS.gasPressed and not CC.enabled and not recent_moving
+
+    # Green Light Alert
+    green_light_trigger = False
+    if self.green_light_state == E2EStates.ARMED:
+      if model_x[max_idx] > GREEN_LIGHT_X_THRESHOLD:
+        self.green_light_trigger_timer += 1
+      else:
+        self.green_light_trigger_timer = 0
+
+      if self.green_light_trigger_timer * DT_MDL > TRIGGER_TIMER_THRESHOLD:
+        green_light_trigger = True
+    elif self.green_light_state != E2EStates.ARMED:
+      self.green_light_trigger_timer = 0
 
     # Lead Departure Alert
-    self.lead_depart_alert = (self.lead_depart_alert_enabled and CS.standstill and model_x[max_idx] > 30
-                              and has_lead and lead_vRel > 1 and not CS.gasPressed)
+    close_lead_valid = self.has_lead and lead_dRel < 8.0
+    if self.allowed and not self.last_allowed and close_lead_valid:
+      self.lead_depart_confirmed_lead = True
+    elif not self.allowed:
+      self.lead_depart_confirmed_lead = False
+
+    if self.allowed and self.lead_depart_confirmed_lead and close_lead_valid:
+      self.lead_depart_arm_timer += 1
+
+      if self.lead_depart_arm_timer * DT_MDL >= 1.0:
+        self.lead_depart_armed = True
+    else:
+      self.lead_depart_arm_timer = 0
+      self.lead_depart_armed = False
+
+    lead_depart_trigger = False
+    if self.lead_depart_state == E2EStates.ARMED:
+      if self.last_lead_distance == -1 or lead_dRel < self.last_lead_distance:
+        self.last_lead_distance = lead_dRel
+
+      if self.last_lead_distance != -1 and (lead_dRel - self.last_lead_distance > LEAD_DEPART_DIST_THRESHOLD):
+        self.lead_depart_trigger_timer += 1
+      else:
+        self.lead_depart_trigger_timer = 0
+
+      if self.lead_depart_trigger_timer * DT_MDL > TRIGGER_TIMER_THRESHOLD:
+        lead_depart_trigger = True
+    elif self.lead_depart_state != E2EStates.ARMED:
+      self.last_lead_distance = -1
+      self.lead_depart_trigger_timer = 0
+
+    self.last_allowed = self.allowed
+
+    return green_light_trigger, lead_depart_trigger
+
+  @staticmethod
+  def update_state_machine(state: int, enabled: bool, allowed: bool, triggered: bool) -> tuple[int, bool]:
+    if state != E2EStates.INACTIVE:
+      if not allowed or not enabled:
+        state = E2EStates.INACTIVE
+
+      else:
+        if state == E2EStates.ARMED:
+          if triggered:
+            state = E2EStates.CONSUMED
+
+        elif state == E2EStates.CONSUMED:
+          pass
+
+    elif state == E2EStates.INACTIVE:
+      if allowed and enabled:
+        state = E2EStates.ARMED
+
+    return state, triggered
+
+  def update(self, sm: messaging.SubMaster, events_sp: EventsSP) -> None:
+    self._read_params()
+
+    green_light_trigger, lead_depart_trigger = self.update_alert_trigger(sm)
+
+    self.prev_green_light_state = self.green_light_state
+    self.prev_lead_depart_state = self.lead_depart_state
+
+    self.green_light_state, self.green_light_alert = self.update_state_machine(
+      self.green_light_state,
+      self.green_light_alert_enabled,
+      self.allowed and not self.has_lead,
+      green_light_trigger
+    )
+
+    self.lead_depart_state, self.lead_depart_alert = self.update_state_machine(
+      self.lead_depart_state,
+      self.lead_depart_alert_enabled,
+      self.allowed and self.lead_depart_armed,
+      lead_depart_trigger
+    )
 
     if self.green_light_alert or self.lead_depart_alert:
       events_sp.add(custom.OnroadEventSP.EventName.e2eChime)
+
+    self.frame += 1

sunnypilot/selfdrive/controls/lib/lane_turn_desire.py

@@ -9,13 +9,15 @@ from cereal import custom
 from openpilot.common.constants import CV
 from openpilot.common.params import Params
 
+TurnDirection = custom.ModelDataV2SP.TurnDirection
+
 LANE_CHANGE_SPEED_MIN = 20 * CV.MPH_TO_MS
 
 
 class LaneTurnController:
   def __init__(self, desire_helper):
     self.DH = desire_helper
-    self.turn_direction = custom.TurnDirection.none
+    self.turn_direction = TurnDirection.none
     self.params = Params()
     self.lane_turn_value = float(self.params.get("LaneTurnValue", return_default=True)) * CV.MPH_TO_MS
     self.param_read_counter = 0
@@ -33,13 +35,13 @@ class LaneTurnController:
 
   def update_lane_turn(self, blindspot_left: bool, blindspot_right: bool, left_blinker: bool, right_blinker: bool, v_ego: float) -> None:
     if left_blinker and not right_blinker and v_ego < self.lane_turn_value and not blindspot_left:
-      self.turn_direction = custom.TurnDirection.turnLeft
+      self.turn_direction = TurnDirection.turnLeft
     elif right_blinker and not left_blinker and v_ego < self.lane_turn_value and not blindspot_right:
-      self.turn_direction = custom.TurnDirection.turnRight
+      self.turn_direction = TurnDirection.turnRight
     else:
-      self.turn_direction = custom.TurnDirection.none
+      self.turn_direction = TurnDirection.none
 
   def get_turn_direction(self):
     if not self.enabled:
-      return custom.TurnDirection.none
+      return TurnDirection.none
     return self.turn_direction

sunnypilot/selfdrive/controls/lib/speed_limit/common.py

@@ -4,10 +4,11 @@ Copyright (c) 2021-, Haibin Wen, sunnypilot, and a number of other contributors.
 This file is part of sunnypilot and is licensed under the MIT License.
 See the LICENSE.md file in the root directory for more details.
 """
-from enum import IntEnum
+
+from openpilot.sunnypilot import IntEnumBase
 
 
-class Policy(IntEnum):
+class Policy(IntEnumBase):
   car_state_only = 0
   map_data_only = 1
   car_state_priority = 2
@@ -15,13 +16,13 @@ class Policy(IntEnum):
   combined = 4
 
 
-class OffsetType(IntEnum):
+class OffsetType(IntEnumBase):
   off = 0
   fixed = 1
   percentage = 2
 
 
-class Mode(IntEnum):
+class Mode(IntEnumBase):
   off = 0
   information = 1
   warning = 2

sunnypilot/selfdrive/controls/lib/speed_limit/speed_limit_resolver.py

@@ -12,7 +12,7 @@ from openpilot.common.constants import CV
 from openpilot.common.gps import get_gps_location_service
 from openpilot.common.params import Params
 from openpilot.common.realtime import DT_MDL
-from openpilot.sunnypilot import PARAMS_UPDATE_PERIOD
+from openpilot.sunnypilot import PARAMS_UPDATE_PERIOD, get_sanitize_int_param
 from openpilot.sunnypilot.selfdrive.controls.lib.speed_limit import LIMIT_MAX_MAP_DATA_AGE, LIMIT_ADAPT_ACC
 from openpilot.sunnypilot.selfdrive.controls.lib.speed_limit.common import Policy, OffsetType
 
@@ -42,6 +42,12 @@ class SpeedLimitResolver:
     self.distance_solutions = {}  # Store for distance to current speed limit start for different sources
 
     self.policy = self.params.get("SpeedLimitPolicy", return_default=True)
+    self.policy = get_sanitize_int_param(
+      "SpeedLimitPolicy",
+      Policy.min().value,
+      Policy.max().value,
+      self.params
+    )
     self._policy_to_sources_map = {
       Policy.car_state_only: [SpeedLimitSource.car],
       Policy.map_data_only: [SpeedLimitSource.map],
@@ -54,7 +60,12 @@ class SpeedLimitResolver:
       self._reset_limit_sources(source)
 
     self.is_metric = self.params.get_bool("IsMetric")
-    self.offset_type = self.params.get("SpeedLimitOffsetType", return_default=True)
+    self.offset_type = get_sanitize_int_param(
+      "SpeedLimitOffsetType",
+      OffsetType.min().value,
+      OffsetType.max().value,
+      self.params
+    )
     self.offset_value = self.params.get("SpeedLimitValueOffset", return_default=True)
 
     self.speed_limit = 0.
@@ -131,6 +142,7 @@ class SpeedLimitResolver:
     self.limit_solutions[SpeedLimitSource.map] = speed_limit
     self.distance_solutions[SpeedLimitSource.map] = 0.
 
+    # FIXME-SP: this is not working as expected
     if 0. < next_speed_limit < self.v_ego:
       adapt_time = (next_speed_limit - self.v_ego) / LIMIT_ADAPT_ACC
       adapt_distance = self.v_ego * adapt_time + 0.5 * LIMIT_ADAPT_ACC * adapt_time ** 2

sunnypilot/selfdrive/controls/lib/tests/test_lane_turn_desire.py

@@ -1,113 +1,113 @@
 import pytest
-from cereal import log
+from cereal import log, custom
 from openpilot.common.params import Params
 
 from openpilot.selfdrive.controls.lib.desire_helper import DesireHelper
 from openpilot.sunnypilot.selfdrive.controls.lib.lane_turn_desire import LaneTurnController, LANE_CHANGE_SPEED_MIN
 from openpilot.sunnypilot.selfdrive.controls.lib.auto_lane_change import AutoLaneChangeMode
 
-
-class TurnDirection:
-    none = 0
-    turnLeft = 1
-    turnRight = 2
+TurnDirection = custom.ModelDataV2SP.TurnDirection
 
 
 @pytest.mark.parametrize("left_blinker,right_blinker,v_ego,blindspot_left,blindspot_right,expected", [
-    (True, False, 5, False, False, TurnDirection.turnLeft),
-    (False, True, 6, False, False, TurnDirection.turnRight),
-    (True, False, 9, False, False, TurnDirection.none),
-    (True, False, 7, True, False, TurnDirection.none),
-    (False, True, 6, False, True, TurnDirection.none),
-    (False, False, 5, False, False, TurnDirection.none),
-    (True, True, 5, False, False, TurnDirection.none),
+  (True, False, 5, False, False, TurnDirection.turnLeft),
+  (False, True, 6, False, False, TurnDirection.turnRight),
+  (True, False, 9, False, False, TurnDirection.none),
+  (True, False, 7, True, False, TurnDirection.none),
+  (False, True, 6, False, True, TurnDirection.none),
+  (False, False, 5, False, False, TurnDirection.none),
+  (True, True, 5, False, False, TurnDirection.none),
 ])
 def test_lane_turn_desire_conditions(left_blinker, right_blinker, v_ego, blindspot_left, blindspot_right, expected):
-    dh = DesireHelper()
-    controller = LaneTurnController(dh)
-    controller.enabled = True
-    controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
-    controller.turn_direction = TurnDirection.none
-    controller.update_lane_turn(blindspot_left, blindspot_right, left_blinker, right_blinker, v_ego)
-    assert controller.get_turn_direction() == expected
+  dh = DesireHelper()
+  controller = LaneTurnController(dh)
+  controller.enabled = True
+  controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
+  controller.turn_direction = TurnDirection.none
+  controller.update_lane_turn(blindspot_left, blindspot_right, left_blinker, right_blinker, v_ego)
+  assert controller.get_turn_direction() == expected
 
 
 def test_lane_turn_desire_disabled():
-    dh = DesireHelper()
-    controller = LaneTurnController(dh)
-    controller.enabled = False
-    controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
-    controller.turn_direction = TurnDirection.none
-    controller.update_lane_turn(False, False, True, False, 7)
-    assert controller.get_turn_direction() == TurnDirection.none
+  dh = DesireHelper()
+  controller = LaneTurnController(dh)
+  controller.enabled = False
+  controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
+  controller.turn_direction = TurnDirection.none
+  controller.update_lane_turn(False, False, True, False, 7)
+  assert controller.get_turn_direction() == TurnDirection.none
 
 
 def test_lane_turn_overrides_lane_change():
-    dh = DesireHelper()
-    controller = LaneTurnController(dh)
-    controller.enabled = True
-    controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
-    controller.turn_direction = TurnDirection.none
-    # left turn desire
-    controller.update_lane_turn(False, False, True, False, 5)
-    assert controller.get_turn_direction() == TurnDirection.turnLeft
-    # right turn desire
-    controller.update_lane_turn(False, False, False, True, 6)
-    assert controller.get_turn_direction() == TurnDirection.turnRight
-    # no turn
-    controller.update_lane_turn(False, False, False, False, 7)
-    assert controller.get_turn_direction() == TurnDirection.none
+  dh = DesireHelper()
+  controller = LaneTurnController(dh)
+  controller.enabled = True
+  controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
+  controller.turn_direction = TurnDirection.none
+  # left turn desire
+  controller.update_lane_turn(False, False, True, False, 5)
+  assert controller.get_turn_direction() == TurnDirection.turnLeft
+  # right turn desire
+  controller.update_lane_turn(False, False, False, True, 6)
+  assert controller.get_turn_direction() == TurnDirection.turnRight
+  # no turn
+  controller.update_lane_turn(False, False, False, False, 7)
+  assert controller.get_turn_direction() == TurnDirection.none
 
 
 @pytest.mark.parametrize("v_ego,expected", [
-    (8.93, TurnDirection.turnLeft),   # just below threshold
-    (8.96, TurnDirection.none),       # above threshold
-    (8.95, TurnDirection.none),       # just above threshold
+  (8.93, TurnDirection.turnLeft),  # just below threshold
+  (8.96, TurnDirection.none),  # above threshold
+  (8.95, TurnDirection.none),  # just above threshold
 ])
 def test_lane_turn_desire_speed_boundary(v_ego, expected):
-    dh = DesireHelper()
-    controller = LaneTurnController(dh)
-    controller.enabled = True
-    controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
-    controller.turn_direction = TurnDirection.none
-    controller.update_lane_turn(False, True, True, False, v_ego)
-    assert controller.get_turn_direction() == expected
+  dh = DesireHelper()
+  controller = LaneTurnController(dh)
+  controller.enabled = True
+  controller.lane_turn_value = LANE_CHANGE_SPEED_MIN
+  controller.turn_direction = TurnDirection.none
+  controller.update_lane_turn(False, True, True, False, v_ego)
+  assert controller.get_turn_direction() == expected
 
 
 class DummyCarState:
-    def __init__(self, vEgo=0, leftBlinker=False, rightBlinker=False, leftBlindspot=False, rightBlindspot=False,
-                 steeringPressed=False, steeringTorque=0, brakePressed=False):
-        self.vEgo = vEgo
-        self.leftBlinker = leftBlinker
-        self.rightBlinker = rightBlinker
-        self.leftBlindspot = leftBlindspot
-        self.rightBlindspot = rightBlindspot
-        self.steeringPressed = steeringPressed
-        self.steeringTorque = steeringTorque
-        self.brakePressed = brakePressed
+  def __init__(self, vEgo=0, leftBlinker=False, rightBlinker=False, leftBlindspot=False, rightBlindspot=False,
+               steeringPressed=False, steeringTorque=0, brakePressed=False):
+    self.vEgo = vEgo
+    self.leftBlinker = leftBlinker
+    self.rightBlinker = rightBlinker
+    self.leftBlindspot = leftBlindspot
+    self.rightBlindspot = rightBlindspot
+    self.steeringPressed = steeringPressed
+    self.steeringTorque = steeringTorque
+    self.brakePressed = brakePressed
+
 
 @pytest.fixture
 def set_lane_turn_params():
-    params = Params()
-    params.put("LaneTurnDesire", True)
-    params.put("LaneTurnValue", 20.0)
+  params = Params()
+  params.put("LaneTurnDesire", True)
+  params.put("LaneTurnValue", 20.0)
+
 
 @pytest.mark.parametrize("carstate, lateral_active, lane_change_prob, expected_desire", [
-    # Lane turn desire overrides lane change desire
-    (DummyCarState(vEgo=5, leftBlinker=True, rightBlinker=False, leftBlindspot=False, rightBlindspot=False), True, 1.0, log.Desire.turnLeft),
-    (DummyCarState(vEgo=7, leftBlinker=False, rightBlinker=True, leftBlindspot=False, rightBlindspot=False), True, 1.0, log.Desire.turnRight),
-    # Lane change desire only (no turn desires)
-    (DummyCarState(vEgo=9, leftBlinker=True, rightBlinker=False, leftBlindspot=False, rightBlindspot=False,
-                   steeringPressed=True, steeringTorque=1), True, 1.0, log.Desire.laneChangeLeft),
-    (DummyCarState(vEgo=9, leftBlinker=False, rightBlinker=True, leftBlindspot=False, rightBlindspot=False,
-                   steeringPressed=True, steeringTorque=-1), True, 1.0, log.Desire.laneChangeRight),
-    # No desire (inactive)
-    (DummyCarState(vEgo=9, leftBlinker=False, rightBlinker=False), False, 1.0, log.Desire.none),
-    (DummyCarState(vEgo=4, leftBlinker=False, rightBlinker=False), True, 1.0, log.Desire.none),  # No blinkers? no desire!
+  # Lane turn desire overrides lane change desire
+  (DummyCarState(vEgo=5, leftBlinker=True, rightBlinker=False, leftBlindspot=False, rightBlindspot=False), True, 1.0,
+   log.Desire.turnLeft),
+  (DummyCarState(vEgo=7, leftBlinker=False, rightBlinker=True, leftBlindspot=False, rightBlindspot=False), True, 1.0,
+   log.Desire.turnRight),
+  # Lane change desire only (no turn desires)
+  (DummyCarState(vEgo=9, leftBlinker=True, rightBlinker=False, leftBlindspot=False, rightBlindspot=False,
+                 steeringPressed=True, steeringTorque=1), True, 1.0, log.Desire.laneChangeLeft),
+  (DummyCarState(vEgo=9, leftBlinker=False, rightBlinker=True, leftBlindspot=False, rightBlindspot=False,
+                 steeringPressed=True, steeringTorque=-1), True, 1.0, log.Desire.laneChangeRight),
+  # No desire (inactive)
+  (DummyCarState(vEgo=9, leftBlinker=False, rightBlinker=False), False, 1.0, log.Desire.none),
+  (DummyCarState(vEgo=4, leftBlinker=False, rightBlinker=False), True, 1.0, log.Desire.none),  # No blinkers? no desire!
 ])
 def test_desire_helper_integration(carstate, lateral_active, lane_change_prob, expected_desire, set_lane_turn_params):
-    dh = DesireHelper()
-    dh.alc.lane_change_set_timer = AutoLaneChangeMode.NUDGE
-    for _ in range(10):
-        dh.update(carstate, lateral_active, lane_change_prob)
-    assert dh.desire == expected_desire  # The first four tests were unit tests to test the controller, where this tests the integration in desire helpers
+  dh = DesireHelper()
+  dh.alc.lane_change_set_timer = AutoLaneChangeMode.NUDGE
+  for _ in range(10):
+    dh.update(carstate, lateral_active, lane_change_prob)
+  assert dh.desire == expected_desire  # The first four tests were unit tests to test the controller, where this tests the integration in desire helpers

sunnypilot/selfdrive/selfdrived/events.py

@@ -11,6 +11,7 @@ AlertSize = log.SelfdriveState.AlertSize
 AlertStatus = log.SelfdriveState.AlertStatus
 VisualAlert = car.CarControl.HUDControl.VisualAlert
 AudibleAlert = car.CarControl.HUDControl.AudibleAlert
+AudibleAlertSP = custom.SelfdriveStateSP.AudibleAlert
 EventNameSP = custom.OnroadEventSP.EventName
 
 
@@ -58,7 +59,7 @@ def speed_limit_pre_active_alert(CP: car.CarParams, CS: car.CarState, sm: messag
     "Speed Limit Assist: Activation Required",
     alert_2_str,
     AlertStatus.normal, AlertSize.mid,
-    Priority.LOW, VisualAlert.none, AudibleAlert.none, .1)
+    Priority.LOW, VisualAlert.none, AudibleAlertSP.promptSingleLow, .1)
 
 
 class EventsSP(EventsBase):
@@ -202,7 +203,7 @@ EVENTS_SP: dict[int, dict[str, Alert | AlertCallbackType]] = {
       "Automatically adjusting to the posted speed limit",
       "",
       AlertStatus.normal, AlertSize.small,
-      Priority.LOW, VisualAlert.none, AudibleAlert.none, 5.),
+      Priority.LOW, VisualAlert.none, AudibleAlertSP.promptSingleHigh, 5.),
   },
 
   EventNameSP.speedLimitChanged: {
@@ -210,7 +211,7 @@ EVENTS_SP: dict[int, dict[str, Alert | AlertCallbackType]] = {
       "Set speed changed",
       "",
       AlertStatus.normal, AlertSize.small,
-      Priority.LOW, VisualAlert.none, AudibleAlert.none, 5.),
+      Priority.LOW, VisualAlert.none, AudibleAlertSP.promptSingleHigh, 5.),
   },
 
   EventNameSP.speedLimitPreActive: {
@@ -222,7 +223,7 @@ EVENTS_SP: dict[int, dict[str, Alert | AlertCallbackType]] = {
       "Automatically adjusting to the last speed limit",
       "",
       AlertStatus.normal, AlertSize.small,
-      Priority.LOW, VisualAlert.none, AudibleAlert.none, 5.),
+      Priority.LOW, VisualAlert.none, AudibleAlertSP.promptSingleHigh, 5.),
   },
 
   EventNameSP.e2eChime: {
@@ -230,6 +231,6 @@ EVENTS_SP: dict[int, dict[str, Alert | AlertCallbackType]] = {
       "",
       "",
       AlertStatus.normal, AlertSize.none,
-      Priority.MID, VisualAlert.none, AudibleAlert.prompt, 0.1),
+      Priority.MID, VisualAlert.none, AudibleAlert.prompt, 3.),
   },
 }