Commit Graph

49 Commits

Author SHA1 Message Date
Willem Melching 4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Willem Melching e6180738fd add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh c6ce88e231 Nissan: use cleaner Leaf brake pressed signal (#22890) 2021-11-12 12:18:13 -08:00
Andre Volmensky 293a383d3a Added fingerprint for Japanese 2017 X-Trail (#22881) 2021-11-12 14:02:13 +01:00
robin-reckmann e2288371f2 Fingerprinting v2 support for Nissan vehicles (#22655)
* Add Nissan FPv2

* Update Nissan version response

* Add second Nissan FPv2 query

* Add multiple offsets for Nissan

* Nissan offset fix

* Add Nissan diagnostic request

* Use 21 83 for Nissan version request

* Add partial 2018 Leaf FPv2

* Update 2018 Leaf FPv2

* Nissan FPv2: more RX offsets, add no diagostic request scan for 0x20

* Add FPv2 imports to Nissan values

* Change LEAF to LEAF_IC

It is an instrument cluster leaf. With this minor change it works :).

* fixed ecu addr for nissan eps

* Remove FW not used for fpv2

* Remove unused offsets

* add fw versions for 2018 Nissan Leaf JP

* add standard ecu fw query

* add esp fw

* add nissan xtrail

* Add missing ESP FW for 2018 Nissan Leaf IC

* Add fwdCamera FW for Xtrail 2017

* add missing comma

* Add 0x8 default offset

needed e.g. for xtrail engine ecu

* Apply suggestions from code review

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Fix variable naming

* remove unnecessary part of standard fw query

* add fw versions for CAN-GW ECU

* transmission eco does not reliable answer -> remove

* add Altima FWs (part 1)

* add Altima EPS FW

* Remove NISSAN_KWP_DIAGNOSTIC_REQUEST and cleanup

* Revert "Remove NISSAN_KWP_DIAGNOSTIC_REQUEST and cleanup"

This reverts commit 808d6f1562e9a6cb57ea365d184b74d51f6da017.

* cleanup

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
Co-authored-by: Julian Pieles <julian@pieles.digital>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-08 10:51:59 +01:00
Robbe Derks 91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh 649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
HaraldSchafer 1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
CrispinFlowerday 7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Jason Young 83ca5a0d29 Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
2021-06-02 15:51:54 +02:00
Ewan a844c60f14 2019 Nissan Altima fingerprint (#20969)
* Update values.py

Add 2019 Altima support (may be specific to VC-Turbo model, do not have NA model to compare to)

* Update README.md

Add 2019 altima

* Update values.py

Combine fingerprint of 2020 + 2019

* Update values.py

* Update values.py

Sort fingerprint values numerically by key
2021-05-26 17:54:44 -07:00
ShaneSmiskol 551091bcfa Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
Adeeb Shihadeh 6c7ed8f2e4 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Adeeb Shihadeh 90d6bcc8e9 remove conflicting nissan leaf fingerprint 2021-04-06 15:22:53 -07:00
Willem Melching c23ec9f753 LateralPlanner should only compute curvature (#20289)
* get curvature from planner

* no need to check active

* remove that

* remove self

* liveParams not needed

* cast

* fix test bug

* fixes

* fix ui.py

* fix radians

* update refs

* update refs

* bump cereal

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-11 21:08:51 -08:00
Andre Volmensky 11785fe321 Nissan altima (#2742)
* Altima port

* Add Nissan Altima 2020 to README.md

* Added Nissan Altima test route

* Fixed up checks
2021-02-19 23:27:55 -08:00
Adeeb Shihadeh 312b681a46 cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
robin-reckmann bba378d9f9 Add fingerprint for 2018 Nissan Leaf G (Japan) (#20081)
* add fingerprint for 2018 Nissan Leaf G (Japan)

* Integrated fingerprint into existing one

* Add low-frequency messages to the fingerprint
2021-02-15 16:07:50 +01:00
Julian Pieles 2e32f18d06 support for Nissan Leaf with ADAS ECU in alt location (instrument cluster) (#19619) 2021-02-05 11:04:45 -08:00
Willem Melching e4cf43c6fc Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Igor 093456cc40 Parametrize MIN_CAN_SPEED in car interfaces (#2684)
* Parametrize MIN_CAN_SPEED in car interfaces

* fixed instance in planner.py

* fix typo

* var name change

* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files

* added default value to get_std_params, removed unneeded instances from car interface files

* Revert PEP8 autoformat corrections

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-12-04 11:09:34 +01:00
Adeeb Shihadeh 47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Andre Volmensky a1037b5334 Nissan Rogue 2018 (#2336)
* Added Nissan Rogue 2018 fingerprint

* Merged Nissan Rogue fingerprints. Updated README.md
2020-10-14 11:03:40 -07:00
VirtuallyChris f10497a75d Add Nissan Leaf 2020 (#2311)
* Add 2020 Leaf fingerprint

* Split fingerpints

* un-merge fingerprints
2020-10-12 16:30:34 -07:00
Adeeb Shihadeh 892e1162c0 Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Andre Volmensky da5dc7693e Nissan: Tweaking steeringPressed/LKAS_MAX_TORQUE (#1865)
* Tweaking steeringPressed/LKAS_MAX_TORQUE

* Update ref commit
2020-07-20 16:30:40 -07:00
Andre Volmensky 977a6ba46b Nissan: Increase steer pressed threshold (#1833)
* Increasing steer threshold

* Update ref commit
2020-07-09 13:50:50 +02:00
Adeeb 367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching 843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Willem Melching fa7d8f6e1b remove unused line in nissan carstate 2020-06-01 14:39:06 -07:00
Andre Volmensky 843b2940c5 Nissan mph bit (#1609)
* Added MPH bit for Rogue/XTrail

* Init seatbeltUnlatched as True
2020-06-01 14:38:20 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Andre Volmensky 9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
George Hotz 1295cfe06c Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
2020-05-02 12:07:34 -07:00
Willem Melching f7f0a81d13 Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
Willem Melching c9cefb2fbc nissan and hyundai are community 2020-04-17 11:42:33 -07:00
Adeeb 8d791d78dd Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
2020-04-10 16:12:58 -07:00
Andre Volmensky 9c16ad8e18 Nissan set speed (#1289)
* LKA_ACTIVE should be set with enabled, not cruiseState.enabled. Was causing panda violations

* Added cruiseState.speed to Nissan X-Trail

* Bump opendbc

* Remove redundant if statement

* Fix tests

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-29 15:28:06 -07:00
Willem Melching 1df6b67511 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
2020-03-27 21:44:59 -07:00
Willem Melching 82fb752e3c Nissan cleanup (#1273)
* nissan cleanup

* Fix typos

* Remove print statements

* Remove leaf fingerprint
2020-03-25 10:42:43 -07:00
Andre Volmensky 6b3ff455e2 Nissan lane change (#1236)
* Scaled LKAS_MAX_TORQUE based on dbc change

* Bump opendbc
2020-03-12 14:45:24 -07:00
rbiasini 093d6cb5ff Fingerprint cleanup (#1231)
* upd panda and opendbc

* Delete unnecessary fingerprints, fix RavH occasional test issue, re-enable test error for overlapping fingerprints within the same candidate
2020-03-11 14:32:03 -07:00
Andre Volmensky e0227c9a1d Added LKAS HUD line detection/steer status/hand on wheel warning (#1225) 2020-03-11 12:21:08 -07:00
rbiasini fe911bcca8 abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
2020-03-08 23:35:00 -07:00
rbiasini 543ba27103 Nissan: remove unnecessary lines (#1207) 2020-03-05 17:25:18 -08:00
Willem Melching 6db044c86c Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models
2020-03-05 15:40:07 -08:00