Shane Smiskol
35a4a773f1
Revert "selfdrive/car: ban imports from external modules" ( #32993 )
...
Revert "selfdrive/car: ban imports from external modules (#32973 )"
This reverts commit 83d4623590 .
2024-07-15 11:14:04 -07:00
Dean Lee
83d4623590
selfdrive/car: ban imports from external modules ( #32973 )
...
* lint import
* Update selfdrive/car/__init__.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
2024-07-15 11:12:24 -07:00
Jason Wen
36eafc0dc6
Hyundai CAN: Log ABS/ESP Activation to espActive ( #32743 )
...
* Hyundai CAN: Log active ABS to accFaulted
* Add comments
* `espActive` to CarState and CarEvent.EventName
* re-order
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
2024-06-24 20:14:57 -07:00
Dean Lee
983063c3e6
events.py: rename event counters ( #32596 )
...
* improve prev event counters
* just rename
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
2024-06-06 00:13:57 -07:00
Adeeb Shihadeh
075176f869
define alert for actuatorsApiUnavailable
2024-05-18 17:55:52 -07:00
Shane Smiskol
42861f6683
events: reduce priority of resumeRequired ( #32450 )
...
CC
2024-05-16 21:17:37 -07:00
Shane Smiskol
e9bf36232b
Events: remove dependency ( #32430 )
...
* Revert "Events: use sorted container (#32395 )"
This reverts commit d98ab4ddb1 .
* remove implicit dependency
2024-05-14 15:19:02 -07:00
Shane Smiskol
d98ab4ddb1
Events: use sorted container ( #32395 )
...
* use SortedList
* Update ref_commit
2024-05-13 12:16:53 -07:00
Adeeb Shihadeh
6ef95f7a91
adjust gps alert
2024-05-01 11:35:20 -07:00
ZwX1616
1d05704d27
Toggle to always enable DM ( #32205 )
...
* permanent
* param
* correct behavior
* toggle
* need trans
* ref_commit
* translate for chs/t
* disable on P and R
* read
2024-04-17 12:56:37 -07:00
Justin Newberry
4fbc8a3896
move git commands to common/git.py ( #31921 )
...
move git into common/git.py
2024-03-19 12:39:09 -07:00
Cameron Clough
995250ae49
use pyupgrade to update to new typing syntax ( #31580 )
...
* add pyupgrade hook
* run pyupgrade (pre-commit run -a)
* ruff --fix
* Revert "add pyupgrade hook"
This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.
* revert changes to third_party/
* manual type fixes
* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
goodchoom
8b5c9e84d2
Alerts: fix inconsistent capitalization ( #31514 )
...
fix capitalization
2024-02-19 18:18:20 -08:00
Greg Hogan
7affba06d8
simplify git remote is comma check ( #31284 )
...
* simplify git remote is comma check
* cast to str
* eliminate default and always return string
* add type annotation for cache decorator
* fix up default handling
2024-02-02 21:23:32 -08:00
Harald Schäfer
e6c97c3846
Delete lat planner ( #31089 )
...
* Initial commit
* Fixup
* typo
* ignore lateral plan
* Update cereal
* Remove lateralPlan
* Fix release build
* Fix release build
* give car params
* Add carParams to include_all_types
* Write car param in powerdraw test
* add demo mode
* Update model regf
* proc replay ref commit
* Try
* Move enum definition
* Update cereal
* typo
* Write car param for modeld test
* Update ref
* Update model ref again
---------
Co-authored-by: Kacper Rączy <gfw.kra@gmail.com >
2024-01-21 12:09:48 -08:00
Shane Smiskol
ffeb99db54
events: fixup printing script ( #30268 )
...
* fix typing, no need for ordereddict, show priority name again
* just repr
2023-10-17 01:52:20 -07:00
Adeeb Shihadeh
a4aa801fbe
simplify sensor alert ( #29824 )
...
* simplify
* update proc replay
2023-09-26 16:47:21 -07:00
Shane Smiskol
7f073483bb
services: capitalize constant service list ( #30005 )
...
* rename
* bump
* Apply suggestions from code review
2023-09-21 18:25:15 -07:00
Vivek Aithal
00d1c682b0
Alerts: More understandable locationd, paramsd alerts ( #29831 )
...
* add locationd paramsd alerts
* remove more additions, just renames
* update refs
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* resolve comemnts
* update cereal
* update refs
* remove nosensor in new alerts
* bump cereal
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2023-09-11 16:28:42 -07:00
Vivek Aithal
dbada885ac
locationd: Add camera-IMU cross-checks ( #29727 )
...
* camera-gyro cross checks, but one way
* increase factor to account for gyro noise (potholes, bad roads etc
* increase factor to reduce FP with device taps, bad roads, etc
* factor to 30
* add inputsok to sensoir data invalid alert
* bugfix
* move the sensors check
* add localizer catchall alert
* update refcommit
* remove permanent alert
* revert sensorDataInvalid alert change, split into new PR
2023-09-06 21:01:01 -07:00
Justin Newberry
4e69937d0d
Precommit: ensure executable bit is set ( #29784 )
...
* precommit ensure executable
* exclude tinygrad
* bump submodules
* exclude tinygrad globally
2023-09-05 16:33:26 -07:00
Adeeb Shihadeh
a9626f95b6
add openpilot prefix to imports ( #29498 )
...
* add openpilot prefix to imports
* more
* more
* fix docs
* fix linter
* bump submodules
* fix patched tests
* update dynamic imports
* debug
* Revert "debug"
This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.
* fix pm test
2023-08-20 20:49:55 -07:00
Eric Brown
111b6438c6
Swap belowSteerSpeed and resumeRequired alert priorities ( #28795 )
...
* GM: Don't send belowSteerSpeed when resumeRequired
* Set belowSteerSpeed alert to LOW priority, resumeRequired to MID
* Add script to output all events and their priorities by type
* Set CP, CS, sm
* Subscribe to same messages as controlsd
* Create callable alerts
* Remove event print script
* Remove sng check
2023-08-17 16:03:35 -07:00
Justin Newberry
8793cbff40
Ruff: enable flake8-builtins ( #29315 )
...
* enable flake8-builtins
* replace any with contains
* fix typo in pack
* fix type
* format is from the parent module, has to be enabled
* item_id
* fix item_id
* disable for id since that's what the remote server returns
2023-08-10 18:58:22 -07:00
Justin Newberry
7fdd9fc37c
CI: Pylint to ruff ( #29294 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
* set line length
* pylint exclusions to ruff
* same excludes as old linter
* fix tools QA
* remove unrequired check
* revert linting third_party
* ignore e402
2023-08-09 13:26:54 -07:00
Justin Newberry
a91764954b
Revert "CI: pylint to ruff ( #29276 )" ( #29284 )
...
This reverts commit cb31a53d8a .
2023-08-08 14:24:04 -07:00
Justin Newberry
cb31a53d8a
CI: pylint to ruff ( #29276 )
...
* pylint to riff
* pylint to riff
* pylint to riff
* revert more
* undo exclude removal
* exclude tinygrad
2023-08-08 13:41:30 -07:00
Adeeb Shihadeh
3476205569
increase min duration of steer saturated alert ( #29191 )
...
* increase min duration of steer saturated alert
* update refs
2023-07-31 12:48:11 -07:00
Eric Brown
22c413af6d
Events: debug script ( #28898 )
...
* Move to separate branch
* Fix mypy
* Better printout
* Fix spacing
* cleanup
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2023-07-16 16:59:27 -07:00
Adeeb Shihadeh
336b5f7324
reduce startup alert duration ( #28749 )
...
* reduce startup alert duration
* update refs
2023-06-29 17:57:25 -07:00
Shane Smiskol
fc2bd16e72
Deprecate brakeUnavailable event ( #28351 )
...
* bump cereal
* deprecate
* Update selfdrive/controls/lib/events.py
2023-05-31 16:29:11 -07:00
Harald Schäfer
598343aad1
Calibrationd: make recalibrating alert ( #28149 )
...
* Initial
* fixes
* not an int anymore
* elif
* revert ref
* update ref
* fix alert text
* regen refs
* update ref
* add recalibration unit test
* set into recalibration state
* fix words
* recalib
* text
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2023-05-15 09:29:57 -07:00
Shane Smiskol
344064d6bd
Ford: hybrids are unsupported ( #28171 )
...
* hybrid fords are dashcammed
* something like this?
* just do an alert
* good comment
* space
* bb
bb
* top
* Update selfdrive/car/ford/interface.py
* add a noEntry
* remove from release notes
* sad :(
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com >
2023-05-11 23:35:07 -07:00
Shane Smiskol
fb29d0f3bf
Ford: add alert for steering wheel angle not ready ( #28140 )
...
* add event for steering angle calibrating
* how about this
how about this
* rename
* more openpilot-y
* add comment to code
* move to top
* better wording
* more general
* fix
* ?
* above
* bump cereal to master
* add more comms
2023-05-08 22:03:30 -07:00
Harald Schäfer
a979a54cf9
Calibration remount detector: soft disable ( #27993 )
...
* Calibration remount detector: soft disable
* Update test_calibrationd.py
2023-04-22 00:27:20 +00:00
Jason Young
267974e002
remove accFaultedTemp, add steerTimeLimit ( #27720 )
...
* remove accFaultedTemp
* retry CI
* bump cereal
* grab the new steerTimeLimit Event
* bump cereal to updated master
2023-03-28 16:04:14 -07:00
Adeeb Shihadeh
7a3b3e8b56
better main off alert ( #27442 )
2023-02-23 15:01:10 -08:00
Adeeb Shihadeh
ea419c5764
add 'remount device' to permanent calibration invalid alert ( #27407 )
2023-02-20 16:29:17 -08:00
Adeeb Shihadeh
5af5f02ba8
better min enable speed alert ( #27317 )
2023-02-14 13:29:23 -08:00
Shane Smiskol
4f2134468f
events: reword ESP off alert ( #27304 )
...
* Rename event
* rename to Control
* rename to disabled
2023-02-10 23:46:48 -08:00
Shane Smiskol
9e9600a4f4
Events: actionable accFaulted alert text ( #26783 )
...
same alert text as steer and brake unavailable
2022-12-13 00:16:36 -08:00
Shane Smiskol
2545dd195e
alert: smaller standstill alert ( #26751 )
...
smaller standstill alert
2022-12-09 23:30:41 -08:00
Shane Smiskol
5409895ab2
Deprecate noTarget event ( #26638 )
...
deprecate notarget
2022-11-30 02:32:47 -08:00
Shane Smiskol
dbe512d167
controlsd: preEnable on brake at a standstill ( #26273 )
...
* pre-enable on brake at standstill
* test by getting rid of noTarget
* Update events.py
* rename
* stash what we got so far
* cmt
* not sure if best way to fix, but enabled with current states defs is fine
* no noEntry in preEnabled
* bumpcereal
* uncomment
* Update ref_commit
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
2022-11-29 17:34:10 -08:00
Shane Smiskol
3253b85900
Toyota: alert when in standstill ( #26585 )
...
* add resume required alert
* possibly need this (pressing resume with brake held does nothing)
* better text (has both meanings)
* try this
* Revert "try this"
This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.
* no alert with interceptor
* check long
2022-11-25 16:00:58 -08:00
Adeeb Shihadeh
65fa87a969
cleanup panda types everywhere ( #26574 )
...
* cleanup panda types everywhere
* one more
2022-11-21 23:43:24 -08:00
Shane Smiskol
89b88fc7a2
Hyundai: fix button enable controls mismatch ( #26471 )
...
* bump panda
* buttonCancel needs to be a noEntry
* bompo
* Update ref_commit
2022-11-11 14:49:38 -08:00
Shane Smiskol
b1efdab788
Rename gmAccFaultedTemp -> accFaultedTemp
2022-10-19 01:31:12 -07:00
Shane Smiskol
4e82f68de2
GM camera ACC: prevent fault when engaging at a stop ( #26079 )
...
* prevent bolt fault
* comment
* only for camera ACC
* fixup alert
* bump cereal to master
* use new name
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* only care about prevent engagement when we look at PCM
2022-10-14 22:21:53 -07:00
Shane Smiskol
992707c172
controls: enter overriding state for steering override ( #25617 )
...
* lateral overriding is overriding
* Update test
* remove
* also could do something like this and only have one OVERRIDE ET
* Revert "also could do something like this and only have one OVERRIDE ET"
This reverts commit 5c381641c08961676a56a9718fbdaa84989ac249.
* full names
* bump cereal
* test every event type
* update refs
2022-09-13 23:20:45 -07:00