Commit Graph

693 Commits

Author SHA1 Message Date
Shane Smiskol 493d6ef693 Fix new steer saturated warning with joystick mode (#25113)
Fix steer sat warning with joystick mode
old-commit-hash: be7f704168
2022-07-11 12:52:03 -07:00
Shane Smiskol 9bc945c428 Stock longitudinal: spam resume button when lead starts moving (#24873)
* always log leads, we hide them in ui

* only spam resume when future is > vEgoStarting

* do rest but vw

* vw

* remove comments

* rename to resume

* maintain original button msg rate

* mazda: ensure no resume if cancelling

* same for non-HDA2

* Always run planner if not opLong

* try 0.2

* 0.1 should be pretty safe

* add test for resuming

* fix test

* stricter test, speeds[-1] is 0.14 when starting here

* no walrus

* fixup mazda cc

* remove extra import
old-commit-hash: fd2de54172
2022-07-07 00:24:03 -07:00
Shane Smiskol 4eabd3b9d9 FW fingerprinting: log all FW versions (#25042)
* get_fw_versions returns all fw versions with request's brand

* keep track of everything received

* debug

* need to regen or write a hack in build_fw_dict

* to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)

to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)

* update test_fw_query_on_routes

* clean up

* better name

* slightly cleaner

* fix test_startup unit test

del

* fix imports

* fix test_fw_fingerprint

fix test_fw_fingerprint

fix

* fingerprint on all FW_VERSIONS, not just brands with requests

* support old routes in test_fw_query_on_routes

* regen and update refs

* similar function style to before

* better comment

* space

switch name

* try to exact match first

* useless else

* fix debug script

* simpler dictionary

* bump cereal to master
old-commit-hash: ea241bf3dc
2022-07-06 19:42:58 -07:00
Shane Smiskol 220db41bab long planner: run when using stock longitudinal (#25017)
* Squashed commit of the following:

commit e27a5b4e2bfeab4e6a47440b1d4eb180ee4acf49
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Jul 1 14:10:06 2022 -0700

    remove this test

    remove this test

commit c3c10af82222ea4641d94c53a3a07b486cca8452
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Jul 1 14:08:15 2022 -0700

    only planner changes

commit 50e0f1d8704c15acfce8987faf3515c99e8af4f4
Merge: e088fde67 86f0c5757
Author: Shane Smiskol <shane@smiskol.com>
Date:   Fri Jul 1 14:05:36 2022 -0700

    Merge remote-tracking branch 'upstream/master' into enable-planner2

commit e088fde67edcc32ccfeea23b4ae9e44845240429
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Jun 30 13:58:38 2022 -0700

    no walrus

commit b7b425e530e949b9cc427833562473cc241d1367
Merge: f8634266b 8fd235fc6
Author: Shane Smiskol <shane@smiskol.com>
Date:   Thu Jun 30 13:54:30 2022 -0700

    Merge remote-tracking branch 'upstream/master' into enable-planner

commit f8634266b49c3f692b255e6cfac66cccc438ae20
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 29 16:07:35 2022 -0700

    stricter test, speeds[-1] is 0.14 when starting here

commit c9e446ad2183feba9d03ee39f9801091ab791c08
Merge: e6c4106ea cb46531fe
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 29 16:01:32 2022 -0700

    Merge remote-tracking branch 'upstream/master' into enable-planner

commit e6c4106ea185c68a6c7b3d59d5bde664df8bdc9c
Author: Shane Smiskol <shane@smiskol.com>
Date:   Sat Jun 25 03:28:41 2022 -0700

    fix test

commit 0520c7f21613b57b804e08a8e8d10950ac059074
Author: Shane Smiskol <shane@smiskol.com>
Date:   Sat Jun 25 03:26:16 2022 -0700

    add test for resuming

commit 04db5f80bff4a002f5241765a625d7cf57b74364
Merge: e23b37d3f d18a5ee5a
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 22 20:15:50 2022 -0700

    Merge remote-tracking branch 'upstream/master' into enable-planner

commit e23b37d3fe8dd3dd07b46a32a4f0564fabade1aa
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jun 21 12:46:04 2022 -0700

    0.1 should be pretty safe

commit e7dc3960da3d713753f28732f50dbd25811fad28
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jun 21 12:39:30 2022 -0700

    try 0.2

commit ff0597ec92a0d2c52915316961ec123b0183c5cf
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jun 21 11:34:00 2022 -0700

    Always run planner if not opLong

commit 13997c55271f79fd3ca62d6db45ec3790b09aa60
Merge: d2f51ee55 7bba47a10
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jun 21 11:29:22 2022 -0700

    Merge remote-tracking branch 'upstream/master' into enable-planner

commit d2f51ee55fd3bde38275371e76714d7741bc6f6b
Author: Shane Smiskol <shane@smiskol.com>
Date:   Tue Jun 21 11:27:45 2022 -0700

    same for non-HDA2

commit 6a63bd60f09a0abd9185049cd173100d3ef6fefa
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Jun 20 23:37:07 2022 -0700

    mazda: ensure no resume if cancelling

commit 5771cdecab7999765d9f5203c75a67f1555cf975
Author: Shane Smiskol <shane@smiskol.com>
Date:   Mon Jun 20 23:27:58 2022 -0700

    maintain original button msg rate

commit 6c1fe0606fd0a0819ffeaac92526e43b3110f2f4
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 23:45:26 2022 -0700

    rename to resume

commit 00b1df652f1679137c769f9db61eed7dd14e1542
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 21:57:54 2022 -0700

    remove comments

commit 325ea9bbd5e0dd946961ede0cdcc446ad5e5bbdb
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 21:56:20 2022 -0700

    vw

commit 2c9061042b36fe1d6b029a4216655be69a980849
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 21:54:37 2022 -0700

    do rest but vw

commit 3dc51f663dfdd4ea1fd72d239bcd5db8c7da4b47
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 16:34:48 2022 -0700

    only spam resume when future is > vEgoStarting

commit 5f32cd1fcb402bee425d866a9dc76b6feea3d241
Author: Shane Smiskol <shane@smiskol.com>
Date:   Wed Jun 15 16:09:43 2022 -0700

    always log leads, we hide them in ui

* reset when not CS.enabled

remove comment

* update refs
old-commit-hash: f797567ef8
2022-07-05 22:19:20 -07:00
Willem Melching 297a0bd65b controlsd: avoid lag on first iteration due to get_short_branch (#25031)
* controlsd: avoid lag on first iteration due to get_short_branch

* always cache
old-commit-hash: d4cc13c88a
2022-07-04 17:13:30 +02:00
HaraldSchafer 316de57010 Torque control: max torque warning (#25018)
* New steer torque warning

* typo
old-commit-hash: 0c95493dc0
2022-07-01 19:14:21 -07:00
Willem Melching 0c2afda822 enable laikad (#25013)
* enable laikad

* increase logprint for onroad test
old-commit-hash: cdc7a6dbea
2022-07-01 08:26:41 -07:00
HaraldSchafer 2d945b2fd5 Torque control: higher low speed gains and better steering angle deadzone logic (#24980)
* Try no friction and no deadzone

* Learn fromd ata

* update refs
old-commit-hash: b3226d505b
2022-06-27 15:25:47 -07:00
Adeeb Shihadeh 145f3c96ba cleanup torque tuning config (#24951)
old-commit-hash: 062a8bcdbd
2022-06-24 13:01:49 -07:00
Willem Melching f22b124acf ui: change alerts to Inter (#24937)
* ui: change alerts to Inter

* fix up test
old-commit-hash: 88f246b909
2022-06-22 11:45:38 +02:00
HaraldSchafer c4dcf67acc Long e2e planner: better xva weights (#24893)
better long xva weights
old-commit-hash: 2c877ce490
2022-06-17 10:35:24 -07:00
Adeeb Shihadeh 8cd45d02c0 add param to override carParams.dashcamOnly (#24857)
* add param to override carParams.dashcamOnly

* little cleaner
old-commit-hash: 7c826b4fa1
2022-06-17 11:56:04 +02:00
grekiki cc0ba78b69 More accurate jerk limits (#24755)
* More accurate jerk limits

* Min is not - max

For example max_curvature_rate can be negative.

* reduce diff
old-commit-hash: b941b39c56
2022-06-16 10:47:53 -07:00
HaraldSchafer b0b1aff5cc Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: 9283040d84
2022-06-15 15:29:42 -07:00
HaraldSchafer 5e002bff96 Torque control: low speed boost (#24859)
* Make very low speed more aggressive

* Less extreme low speed boost

* Update ref
old-commit-hash: a6652a539d
2022-06-14 22:29:08 -07:00
Adeeb Shihadeh 3c48bc47b7 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
old-commit-hash: 0fce5d9045
2022-06-11 23:19:27 -07:00
Adeeb Shihadeh 9a45a3b99b Move selfdrive/hardware/ to system/ (#24725)
* move hardware to system/

* fix mypy
old-commit-hash: 1139fe507b
2022-06-11 16:38:24 -07:00
HaraldSchafer bc679f735d Misc torque control fixes (#24801)
* Fiction compensation should be based on error

* Update refs

* Add deadzone

* update ref
old-commit-hash: 843e59f6f0
2022-06-10 22:52:48 -07:00
ClockeNessMnstr 52a28d8938 update DH names + notes for MPC output curvatures (#24701)
* update names + notes for MPC outputs

"current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate. 

If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct. 
This was possibly how it was initially set up but the nomenclature here is now confusing.

* more notes

* match

* Clarify #1
old-commit-hash: b215d611b1
2022-06-07 09:41:03 -07:00
Shane Smiskol 1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
2022-06-03 17:41:20 -07:00
HaraldSchafer 08ad733229 Remove laneless toggle (#24738)
* Remove laneless toggle

* Update refs
old-commit-hash: 7f16e19f79
2022-06-03 14:04:14 -07:00
Willem Melching 753045c73d less TICI when not needed (#24698)
* less TICI when not needed

* fix process replay

* move reading voltages into hw abstraction layer

* Update selfdrive/hardware/tici/hardware.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/hw.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/hardware/base.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* rename init function

* Update selfdrive/athena/athenad.py

Co-authored-by: Robbe Derks <robbe.derks@gmail.com>

* Update selfdrive/boardd/boardd.cc

* Apply suggestions from code review

* Update selfdrive/thermald/thermald.py

* update ref

* fix alert width if all cameras are bad

* add ecam to test_loggerd

* bump cereal

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
old-commit-hash: f49a9c9fd2
2022-06-02 15:20:51 +02:00
Gijs Koning 6a53db981b Simulator: Speed up process by removing second camera (#24679)
* simulator: support running wide camera only

* proper frame id

* use param name that makes more sense

* do some cleanup

* Update tools/sim/bridge.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: b5aed2bf67
2022-05-30 15:25:07 +02:00
HaraldSchafer f5a6a6dc77 Tssp prius torque control (#24669)
* use llk

* use steering sensor at low speed stil

* Try more simple

* rm prius tune

* updated ref
old-commit-hash: d708a134bd
2022-05-27 10:21:02 -07:00
HaraldSchafer 39886246c9 Rerevert torque control (#24649)
* Revert "Revert torque control (#24565)"

This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.

* Move tune out of car specific stuff

* Update ref commit
old-commit-hash: d928972150
2022-05-24 17:52:33 -07:00
HaraldSchafer 55085a12db New model: better laneless (#24605)
* Fix ping pong

* Fix hugging: e6fd3a62-aa86-46d1-a414-19137ed1babc/800

* Remove lateral toggle

* a6da6265-1952-48dd-986b-2b5996dd2642/950

* Model replay commit

* Revert "Remove lateral toggle"

This reverts commit 69e57eb7e1a72e4bad5e12bcfded6ff431a21a0e.
old-commit-hash: 7da48ebdba
2022-05-24 09:11:31 -07:00
Adeeb Shihadeh 29e2b3f757 controlsd: ensure all system malfunction events have the right types (#24635)
old-commit-hash: 71901c94db
2022-05-23 17:46:46 -07:00
HaraldSchafer 51165e5df5 Latcontrol torque: integrator need not be reset (#24606)
slow integrators need not be reset
old-commit-hash: 2181bbca71
2022-05-20 13:50:47 -07:00
Shane Smiskol 56a44d41f8 controls: pressing set while gas pressed resets to vEgo (#24100)
* set while gas pressed to resume

* better order

* what was I thinking?

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Gijs Koning <gijs-koning@live.nl>

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Gijs Koning <gijs-koning@live.nl>

* only if under set speed

* some clean up and ciel the v_cruise_kph

* clean up

* actually floor

* Should be cruise min

* On phone, will clean up

* Think no floor is fine

* clean up and catch setCruise

* update comment and just always do rounding and clipping

update comment

* flip order

Co-authored-by: Gijs Koning <gijs-koning@live.nl>
old-commit-hash: d3d210c183
2022-05-19 03:28:50 -07:00
HaraldSchafer efa559f9be Revert torque control (#24565)
* torque reversal start

* Fix carmodel tests

* Update ref

* update ref

* Elif is better than if
old-commit-hash: 9f8b03753d
2022-05-17 19:00:57 -07:00
Adeeb Shihadeh a6bcd14abd show which cameras are malfunctioning (#24558)
old-commit-hash: 0b1f6e3620
2022-05-16 22:01:04 -07:00
Adeeb Shihadeh cfc16a88c5 improved alert verbosity (#24434)
* improved alert verbosity

* better testing script

* better description

* speed diff

* touch ups

* fix that
old-commit-hash: b1858df00e
2022-05-16 21:19:38 -07:00
Shane Smiskol 19aebce4f2 Round system overheated temperature (#24544)
* Update events.py

* Apply suggestions from code review

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 961a121fde
2022-05-16 18:08:02 +02:00
ntegan1 b9a07b8f05 Round model lagging frame drop percentage (#24549)
alerts: round model frame drop percentage
old-commit-hash: 076f0acd5f
2022-05-16 16:26:18 +02:00
Willem Melching 0a2c2a6b28 Add unittest for alert callbacks (#24551)
add alert callback test
old-commit-hash: 31af13101b
2022-05-16 16:25:52 +02:00
ClockeNessMnstr a7dceb30ae LatControlTorque: clean up class variable (#24526)
* move to super

* no class variable

* there's CP

* whitespace

* drop CI from latcontrol super

* Revert "drop CI from latcontrol super"

This reverts commit 9218273060ade6431c4fc4c310b27e7e210158b9.

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a693b3a26b
2022-05-13 16:52:20 -07:00
Shane Smiskol f1f447d092 Add desired curvature to controlsState (#24510)
* Add desired_curvature to controlsState

* clean up

* bump

* bump

* update refs from GitHub!

Co-authored-by: Jason Shuler <jshuler@gmail.com>
old-commit-hash: 6518ecca8f
2022-05-12 16:59:52 -07:00
Dylan Herman 2dfba97175 add mypy check for return-any (#24379)
* add mypy check for return-any

* remove unused import

* typing

* remove unnecessary variable typing

* cleanup

* cleanup

* bump submodules

* small fixes

* only a problem on mac

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c
2022-05-12 14:59:00 +02:00
grekiki 7cd23af9b1 Mypy fixes for --check-untyped-defs (#24372)
more type fixes
old-commit-hash: 17e33978cd
2022-05-12 14:08:11 +02:00
HaraldSchafer 3427eb411b Latcontrol torque: fix integrator induced ping pong (#24458)
* Latcontrol torque: fix integrator induced ping pong

* Reset on disengage since unwind resets anywayh

* Might be overkill

* rm whitespace

* update ref
old-commit-hash: 29afd53d88
2022-05-06 22:17:21 -07:00
Adeeb Shihadeh a6f314bc56 increase cruiseMismatch threshold (#24428)
old-commit-hash: 1bc6f2fa7d
2022-05-04 15:58:08 -07:00
ntegan1 af82274bac LatControlTorque: log desired/actual lateral accel (#24406)
* log torque lateral accel

* bump cereal

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9a44d4c4e0
2022-05-03 14:18:46 -07:00
Adeeb Shihadeh 247c153a35 controlsd: better alert precedence for system malfunctions (#24366)
* controlsd: better alert precedence for system malfunctions

* down to 20

* move that

* check can flags

* update refs

* update refs
old-commit-hash: be748c0d6a
2022-04-29 13:36:25 -07:00
Adeeb Shihadeh fdf13d565b controlsd: add lagging alert (#24360)
* controlsd: add lagging alert

* move those

* just this for now

* no camera malfunction
old-commit-hash: 3abbe827de
2022-04-28 19:51:42 -07:00
Jason Young d82f65a1b7 Accept resumeCruise for resuming prior speed setpoint (#24348)
* accept two button types for resume

* retry CI

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 45f131e0e7
2022-04-28 17:46:58 -07:00
Shane Smiskol 12d0a18a05 Clean up controllers (#24340)
* clean up lat controllers

* pass CP once

* sort
old-commit-hash: c9be2f02c3
2022-04-28 00:42:52 -07:00
Shane Smiskol 3e9694d3f3 LatControlTorque: fix deadzone and missing steer saturated warning (#24294)
* fix steer saturated alert and deadzone

* fix and formatting

* update refs

* update refs

* not needed

* remove
old-commit-hash: e834b4d9be
2022-04-27 01:18:05 -07:00
Vivek Aithal 8823b9e4a5 longitudinal_mpc: Compute forward distance from velocity (#24328)
* add vel integ as x in e2e long mpc

* add comment
old-commit-hash: 1a9f5d29d4
2022-04-25 20:15:04 -07:00
Shane Smiskol 82e5b382f1 longActive: consider longitudinal control (#24295)
* consider longitudinal control

* update refs
old-commit-hash: f4d1703b42
2022-04-22 20:32:36 -07:00
Adeeb Shihadeh 75174c93d7 more verbose debug alerts (#24126)
old-commit-hash: 70987fd9d9
2022-04-22 16:12:54 -07:00