mawei/panda
1
0
Fork 0
mirror of https://github.com/commaai/panda.git synced 2026-06-15 08:36:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #223 from commaai/misra_12_3

Browse Source 
The comma operator should not be used
This commit is contained in:
George Hotz
2019-06-26 11:51:13 -07:00
committed by GitHub
parent c4311a7fee 541f8beee3
commit 2d45e89c3d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
board/drivers/usb.h
View File

@@ -397,9 +397,10 @@ void *USB_ReadPacket(void *dest, uint16_t len) {
uint32_t i=0;
uint32_t count32b = (len + 3) / 4;
for ( i = 0; i < count32b; i++, dest += 4 ) {
for ( i = 0; i < count32b; i++) {
// packed?
*(__attribute__((__packed__)) uint32_t *)dest = USBx_DFIFO(0);
dest += 4;
}
return ((void *)dest);
}
@@ -420,8 +421,9 @@ void USB_WritePacket(const uint8_t *src, uint16_t len, uint32_t ep) {
USBx_INEP(ep)->DIEPCTL |= (USB_OTG_DIEPCTL_CNAK | USB_OTG_DIEPCTL_EPENA);
// load the FIFO
for (i = 0; i < count32b; i++, src += 4) {
for (i = 0; i < count32b; i++) {
USBx_DFIFO(ep) = *((__attribute__((__packed__)) uint32_t *)src);
src += 4;
}
}