Adeeb Shihadeh
59c76fc993
resolve misc car TODOs
...
old-commit-hash: 3c83975ef6ee340bebca362ef1238b4f9018ac8e
2022-02-06 13:50:59 -08:00
Shane Smiskol
fadba4b34d
CANParser: remove default values ( #23642 )
...
* draft
* remove rest
* bump
* update radar interfaces
* do rest and formatting
* bump
* fix mising check
* try this
* Revert "try this"
This reverts commit 0d26d9a072f87dbc897ed525b70fb1db9cb04a06.
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 3645186d7cfcbe8889fed14caf5c51a0a84f14bb
2022-01-27 17:06:18 -08:00
Adeeb Shihadeh
39d98d3d2d
Car cleanup ( #1924 )
...
* cleanup car code
* more pruning
* little more
* less pylint disables
* radar stuff
* fix
* udpate refs
* fix honda bosch
* fix test
old-commit-hash: 892e1162c0bfa0970cbe262452a70745eccb8ba6
2020-07-25 15:07:27 -07:00
George Hotz
6fbcde48e5
Using lgtm.com and fixing found alerts ( #1452 )
...
* lgtm in readme, and mac nui fixes
* call super inits in radars
* unused imports, dup lines
* more radars, more unused imports
* pass CP into RadarInterfaceBase
* more fixups
* unused imports
* delete unused lines
* ugh, new unused import
Co-authored-by: George Hotz <geohot@gmail.com >
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
George Hotz
9ef085076b
selfdrive/car
...
old-commit-hash: 71ead9adea44410b281f0ff1a9c07080d0bada47
2020-01-17 10:58:43 -08:00
George Hotz
81dd5a50cf
root commit
...
old-commit-hash: 6c33a5c1f3878e1d8c8a9db600dd44d188f02c87
2020-01-17 10:02:52 -08:00
Vehicle Researcher
99b637c7ce
openpilot v0.7 release
...
old-commit-hash: c025b96e8a15640ee4d6e4d513fada6ed101afe5
2019-12-13 13:03:08 -08:00
Vehicle Researcher
89d1d84c70
openpilot v0.6.5 release
...
old-commit-hash: cf80f7a28bc737f50e096b21dea2dd2d6d4a1621
2019-10-09 18:43:53 +00:00
Vehicle Researcher
dfe603c178
openpilot v0.6.4 release
...
old-commit-hash: 61229779e4a38431e934cabe700a93e120dfa468
2019-09-09 23:03:02 +00:00
Vehicle Researcher
07aa8b1bf3
openpilot v0.6.1 release
...
old-commit-hash: 94053536b4bfa7a8c4760db99063093aae69374d
2019-07-22 19:17:47 +00:00
Vehicle Researcher
9abcfabc5f
openpilot v0.6 release
...
old-commit-hash: 8a9ed94f5f33faf282b1918ebe2c37f06cef74e6
2019-06-28 21:11:30 +00:00
Vehicle Researcher
e47a2e6e30
openpilot v0.5.13 release
...
old-commit-hash: dd34ccfe288ebda8e2568cf550994ae890379f45
2019-06-06 04:38:45 +00:00
Drew Hintz
3ad68e4378
getting ready for Python 3 ( #619 )
...
* tabs to spaces
python 2 to 3: https://portingguide.readthedocs.io/en/latest/syntax.html#tabs-and-spaces
* use the new except syntax
python 2 to 3: https://portingguide.readthedocs.io/en/latest/exceptions.html#the-new-except-syntax
* make relative imports absolute
python 2 to 3: https://portingguide.readthedocs.io/en/latest/imports.html#absolute-imports
* Queue renamed to queue in python 3
Use the six compatibility library to support both python 2 and 3: https://portingguide.readthedocs.io/en/latest/stdlib-reorg.html#renamed-modules
* replace dict.has_key() with in
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#removed-dict-has-key
* make dict views compatible with python 3
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#dict-views-and-iterators
Where needed, wrapping things that will be a view in python 3 with a list(). For example, if it's accessed with []
Python 3 has no iter*() methods, so just using the values() instead of itervalues() as long as it's not too performance intensive. Note that any minor performance hit of using a list instead of a view will go away when switching to python 3. If it is intensive, we could use the six version.
* Explicitly use truncating division
python 2 to 3: https://portingguide.readthedocs.io/en/latest/numbers.html#division
python 3 treats / as float division. When we want the result to be an integer, use //
* replace map() with list comprehension where a list result is needed.
In python 3, map() returns an iterator.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* replace filter() with list comprehension
In python 3, filter() returns an interatoooooooooooor.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* wrap zip() in list() where we need the result to be a list
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-zip
* clean out some lint
Removes these pylint warnings:
************* Module selfdrive.car.chrysler.chryslercan
W: 15, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 16, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 25, 0: Unnecessary semicolon (unnecessary-semicolon)
************* Module common.dbc
W:101, 0: Anomalous backslash in string: '\?'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
************* Module selfdrive.car.gm.interface
R:102, 6: Redefinition of ret.minEnableSpeed type from float to int (redefined-variable-type)
R:103, 6: Redefinition of ret.mass type from int to float (redefined-variable-type)
************* Module selfdrive.updated
R: 20, 6: Redefinition of r type from int to str (redefined-variable-type)
old-commit-hash: 9dae0bfac4e54ec2b2e488d2b4ead1495c8f56d8
2019-05-02 11:08:59 -07:00
Vehicle Researcher
83dfc3ca1f
openpilot v0.5.11 release
...
old-commit-hash: 2f92d577f995ff6ae1945ef6b89df3cb69b92999
2019-04-23 01:41:19 +00:00
Vehicle Researcher
3bde47d556
openpilot v0.5.8 release
...
old-commit-hash: b967da5fc1f7a07e3561db072dd714d325e857b0
2019-01-23 15:34:52 -08:00