Dean Lee
11b5cfa422
ui/settings: Don't apply styles to more elements than needed. ( #29463 )
...
old-commit-hash: 5765c1d978c5890513e55398490447590d3b1d3e
2023-08-22 14:00:01 -07:00
Adeeb Shihadeh
701cd6f6fe
add cpplint ( #26855 )
...
* setup cpplint
* only start that
* check line length
* check these
* rm exceptions
old-commit-hash: 952d720b6e854b3ebbb9fd0fd82cd38f3ae04b90
2023-08-22 13:55:23 -07:00
Adeeb Shihadeh
16ec56398c
add openpilot prefix to imports ( #29498 )
...
* add openpilot prefix to imports
* more
* more
* fix docs
* fix linter
* bump submodules
* fix patched tests
* update dynamic imports
* debug
* Revert "debug"
This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.
* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Dean Lee
ff74c8c4cb
ui/map_instructions: center lanes ( #29465 )
...
* center lanes
* test
* similar spacing and no need for stretchj
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 9ea2cd8d0b5b697ffe7ae38a318ef44e5233ea44
2023-08-19 01:23:42 -07:00
pencilpusher
fc14939f02
ui/map: interactive counter fix ( #29470 )
...
* use interactive_counter instead of separate zoom and pan counters
* use interaction_counter instead of separate zoom and pan counters
* same styling
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: f2d22075ebd3f5e17628d1cf1ea102c7ce0bbb09
2023-08-19 00:07:52 -07:00
Dean Lee
3078da290d
ui/map: better rounding for distances ( #29151 )
...
* round distance
* use same format in ETA
* remove vanish
* restore translate
* use nearbyint
* update translations
* mark finished
* consistent style
* we don't include this anywhere in ui, needed?
* fix missing std
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: efefcfdca581fd75868b993426dfde21c21c1531
2023-08-17 22:58:18 -07:00
Shane Smiskol
709850e304
map eta: use pair ( #29460 )
...
use pair
old-commit-hash: d827cd6a83cbcc4f8231706f085df0d2ec5ef69f
2023-08-17 22:42:12 -07:00
Shane Smiskol
593322dfa9
ui/map: slight turn lane types ( #29446 )
...
* add slight turns
* bump cereal
* revert
* hmm, i like this better
* whops
* fix
* bump
old-commit-hash: 6d2922b8e6f6ef29b6d17ea7a1c3d16b40e2236f
2023-08-17 20:51:52 -07:00
Dean Lee
023cd0492f
ui/networking: do not skip the connected network ( #29396 )
...
* do not skip connected network
* simplify
* revert
* revert
* no implicit
* ifwt
* fix missing ssid
* makes more sense to only update security_type once (first vs. last)
* better comment
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: b8b1e17a21390d9a80b1b0643c0001129292576c
2023-08-17 14:43:40 -07:00
Dean Lee
4857b61f8f
ui/networking: pass network by value ( #29448 )
...
old-commit-hash: 1887d9197ab495bb8f4dd2826730e6d53528dd65
2023-08-17 11:37:42 -07:00
Dean Lee
a50a9ef9b4
ui/map: hide icon if no maneuver type ( #29084 )
...
hide icon if no maneuver type
old-commit-hash: 202b2f2113d48f517c64f0daf9ad2d61fdb0b7a6
2023-08-17 02:05:19 -07:00
Dean Lee
f667936f3a
ui/map: show map on destination set/change ( #29327 )
...
* show map on dest set/change
* check for rcv_frame
* clear current_nav_dest
* restore allow_open
* use requestShow
* cleanup
* one check
* revert behavior changes
* Update selfdrive/ui/qt/maps/map.cc
* more obvious
* Update selfdrive/ui/qt/maps/map.cc
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 3a277f1b81fbb16673a77a475421a18751127cf2
2023-08-17 01:32:22 -07:00
Shane Smiskol
312d80c877
map: set destination marker visibility once ( #29444 )
...
set visibility once
old-commit-hash: da38aed48300ca1db0a1032c12c26b0268ebb03c
2023-08-17 01:02:59 -07:00
Dean Lee
5cc9fbe23f
ui: longer screen timeout for driver view ( #27457 )
...
* longer driverview timeout
* Update ui.cc
* reset timeout
* do cleanup
* Apply suggestions from code review
* Update selfdrive/ui/ui.cc
* reset to default timeout on hidden
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: f1568b960a3da819c41c62dcaeafb4eb6dd109eb
2023-08-16 22:22:39 -07:00
Dean Lee
e0439a516f
ui/map: assign the return value to last_position ( #29341 )
...
assign the return value directly to last_position
old-commit-hash: 613bbb7e6da40b313dea86af9bfae71c057b375d
2023-08-14 16:39:43 -07:00
Dean Lee
ec3b69928a
ui/networking: bolding the connected network ( #29385 )
...
old-commit-hash: 29f2389cce373ccbf27526183aa34cfe5612c52d
2023-08-14 15:18:41 +01:00
Dean Lee
87c4c661c7
ui/map_instructions: set margin-top to UI_BORDER_SIZE ( #29387 )
...
old-commit-hash: 9071c8a4fcd392efd9b0533879ee080aff9cccac
2023-08-14 12:43:32 +01:00
Dean Lee
25df6335f7
UI: make wifi network sorting more stable ( #29376 )
...
* stable sort
* fix typo,rename to strengthLevel
old-commit-hash: 01089cf4bfea0d9c4484d18d78157227f5733db0
2023-08-13 21:12:23 -07:00
Dean Lee
431797307d
ui/sidebar: break long line for readability ( #29379 )
...
old-commit-hash: 878d3f4cfc1aa6d35d7775567bb40476d68cc4cb
2023-08-13 18:03:38 -07:00
Dean Lee
ce5c95715c
ui/networking: remove dynamic property and style sheet ( #29377 )
...
old-commit-hash: 373171afd08a7890d326993ce2a6275ca79c1876
2023-08-13 14:48:06 -07:00
Dean Lee
42dd6af842
ui/networking: remove call to clearLayout ( #29037 )
...
* build list inplace
* move clearLayout to cabana
* cleanup include
* polish style
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: fd8a9c852016ccfd13ae5146648a65f01cc2468c
2023-08-13 11:57:40 -07:00
Shane Smiskol
d33545a0b6
ui/map_instructions: round <500 distances ( #29333 )
...
round
old-commit-hash: cc747e21666c6a6e382503eaf4cc29bfe3329635
2023-08-11 03:33:40 -07:00
Dean Lee
b065f5c9a2
ui/map: fix CSS error ( #29332 )
...
fix css error
old-commit-hash: 4a89928a9a1eebcf46e789a2df037af66b087252
2023-08-11 03:31:13 -07:00
Shane Smiskol
f8d9860d20
ui/map_instructions: clean up lane icon selection ( #29330 )
...
* draft
* revert
* remove extra directions
* more clean up
* add todo
* revert rename
* I assume this is moot, but preserve behavior
* spacing
old-commit-hash: 52675b2739de56a9b5784ba8016791cdb5286085
2023-08-11 03:27:32 -07:00
Dean Lee
eb695a00c2
ui/map: check NavDestination only if navInstruction is invalid ( #29331 )
...
* check NavDestination only if navInstruction is invalid
* Update selfdrive/ui/qt/maps/map.cc
Co-authored-by: Shane Smiskol <shane@smiskol.com >
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: 80356b34f1c189bee4287c0b70c3e6a18e105cc3
2023-08-11 03:26:08 -07:00
Dean Lee
a494b38f6e
ui/map: set WA_NoMousePropagation to prevent mouse event from propagating up ( #29329 )
...
set WA_NoMousePropagation
old-commit-hash: 15bb9dd09612bc23cc0d59da6fafd74669e1190e
2023-08-11 02:45:54 -07:00
Jason Wen
55f7f723a0
ui onroad: utilize local variables for repeated capnp reader access ( #29325 )
...
old-commit-hash: 22cf5421d625aaf578efcf572404a4d096c269b8
2023-08-10 23:13:45 -07:00
Dean Lee
c8c2c5f801
ui/onroad: move duplicated code to drawIcon() ( #29149 )
...
* move duplicate code to function drawIcon
* fix center point
old-commit-hash: cef693f3097bf9c7a34e6d61afcac341814ab341
2023-08-10 23:08:46 -07:00
eFini
e90ced8449
map ui: Fixed ETA text alignment issue in CJK ( #29311 )
...
fixed ETA text alignment issue in CJK
old-commit-hash: 8d7e909b539ee5e8411ccb7e3375a74dc6c86c2d
2023-08-10 02:15:43 -07:00
Cameron Clough
6ed5aca05a
ui/map: update mapbox style ( #29186 )
...
old-commit-hash: 748238f87cbce5e05ffa06a49f490012d5424864
2023-08-08 20:18:49 +01:00
Shane Smiskol
7b1fa23144
map: fix exit lane direction when active ( #29159 )
...
* fix
* clean up
* comment
old-commit-hash: cffc14e4d8da259c6b69708868c9bef8d0a6febd
2023-08-05 04:02:18 -07:00
Dean Lee
823b570082
ui/OnroadWindow: do not update state when offroad ( #29134 )
...
do not updateState when offroad
old-commit-hash: da9155505627cf4490704bf928e71f77a094337f
2023-07-31 20:25:15 -07:00
Shane Smiskol
fdc00cf0b6
Experimental mode toggle description: missing spaces ( #29167 )
...
* Update settings.cc
* more missing spaces
* scons
* vanish
* fix that
old-commit-hash: 6fe480b232ab85282b06f50473c12c492b5364fd
2023-07-27 14:00:41 -07:00
Adeeb Shihadeh
178d9adec3
ui: less confusing wifi training ( #29137 )
...
* ui: less confusing wifi training
* update
* cleanup
---------
Co-authored-by: Comma Device <device@comma.ai >
old-commit-hash: 0922a1040f3fba4d446f1f1ae03df897375a9341
2023-07-25 13:32:00 -07:00
Harald Schäfer
069e9ef4f8
Experimental mode description: update nav ( #29130 )
...
* Update description
* Update releases
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* Update selfdrive/ui/qt/offroad/settings.cc
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
* small tweaks
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com >
old-commit-hash: 9c3c7f0dda4dd3355fa9a85bc6068fddef66b79b
2023-07-25 10:31:25 -07:00
Shane Smiskol
ec900d0389
navd: don't use empty last step banner instructions ( #29034 )
...
* fix empty banner instructions when arriving at destination
* bug fixes
* hide distance on arrival
* stash
* simpler
* can also do this, but i don't like modifying the response
* clean up
* rm
* revert
* rm
* flip this order
* move up
* need to flip order
* Revert "need to flip order"
This reverts commit ba961b8e6aa5d9490ab0dc661866cff9c72db91d.
* Revert "move up"
This reverts commit f1a4d8ae883080d52547fdaf9472457050e40669.
* Update selfdrive/navd/navd.py
old-commit-hash: 412ed6a017acef84e42395299042717d7120544b
2023-07-25 01:28:17 -07:00
Shane Smiskol
d4ec764235
ui: new nav settings button ( #29068 )
...
* add image
* remove extra spacing
* add images
* use nav-settings-square-smaller.png
* draft
* clean up
* kinda works!
* nop need to update state
* can just use clicked
* MORE
* remove old button
* slightly smaller (todo change image))
* this works but is ugly
* remove old settings button
* draft
* no it's not
* draft 2.0
* clean up
* clean up
* let's make map_settings_btn public
* since we don't have map, use enabled
* fix image size
* can do clean up in another PR
show
* add line
* rename
* useless spacing
* use old nav icon
* handle DM icon (and test)
* clean up
* no reason
* remove old image
* don't use setCurrentIndex
* Revert "don't use setCurrentIndex"
This reverts commit 6fde765a3cd3a9ee39205614587a23fbfbc60950.
* also can use a ternary
* seems cleanest
This reverts commit f9287230704b94f46b6bb5376d9a17075a20caf7.
old-commit-hash: 0dd1dcc7d06e8d5873dc9a2fa5c3e220295bfc1c
2023-07-24 22:27:01 -07:00
Shane Smiskol
6d9a313f19
ui/map: hide settings with showing map ( #29127 )
...
consistent map showing behavior
old-commit-hash: 13dc0325b237a378304bf2a54b66ecb501fc2bea
2023-07-24 18:25:46 -07:00
Dean Lee
916784cfbe
ui/settings: use existing params instance ( #29109 )
...
use exsting params
old-commit-hash: bcfb9d694061e5aef5e0e6bb3d756407b57315a2
2023-07-23 17:45:19 -07:00
Dean Lee
8d2a08723a
ui/map: remove unused variables ( #29098 )
...
old-commit-hash: 980ba1312fc587b735c71887251e16dd20f6cec3
2023-07-22 12:24:16 -07:00
Dean Lee
ee42f316d7
ui/MapSettings: remove function shorten ( #29078 )
...
old-commit-hash: cc551fe24bf62e1825b36b1b9d37df34e84b0188
2023-07-21 19:51:25 +01:00
Shane Smiskol
b8bf3fc0c2
nav: improve no route alert text ( #29076 )
...
* kind of
* Revert "kind of"
This reverts commit 25abbbf1764b0f7e8fbcb83e37159ba6f8cdf641.
* more generic alert text, whenever we're waiting for navd.
* actual better comment
* update translations
old-commit-hash: d70c4916db0af3c5288034db9a361fd0aff39f7b
2023-07-20 22:40:31 -07:00
Dean Lee
9865a32252
ui/map: fix ETA widget text spacing ( #29065 )
...
* fix eta spacing
* fix unit color
---------
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com >
old-commit-hash: 0b8d35b132de6249640a2b8b46bdb1018dc8560c
2023-07-20 21:10:17 -07:00
Shane Smiskol
a069514c36
ui: set global map transition duration ( #29061 )
...
* this works!
* revert properties
* more clean up
* more
* more
* add comment
* final
old-commit-hash: e4dc86f44d6efc6153f8ace852a63802e4a65ca4
2023-07-20 16:11:23 -07:00
Dean Lee
7d5d1b1e70
ui/map: move MapInstructions & MapETA to separate files ( #28976 )
...
old-commit-hash: 942a2f97608b0b371c5ca48564d83b3744c82c77
2023-07-20 21:58:46 +01:00
Shane Smiskol
a7b32acd4b
nav: show warning for routing problems ( #29055 )
...
* all my debugging stuff
* this works
* add comment
* bb navd
* navInstruction is valid when we get a non-empty route response
* now don't need this
* stash
* big cleanup
* clean up
* clean up
* debug
* final clean up
* one line
* flip order
* update translations
* is this simpler?
old-commit-hash: 5b368a67eadff384e8c38085a5e8f10ecd37c1e5
2023-07-20 04:01:55 -07:00
Shane Smiskol
3a41e53b08
nav: set icon anchor for destination pin ( #29054 )
...
* anchor!
* whoops
* fix anchor
old-commit-hash: d0ea8be95fd5900930070b55c8582bafd329639e
2023-07-20 01:28:21 -07:00
Mitchell Goff
949375984f
nav: draw destination pin on top of navigation path ( #29050 )
...
* Draw destination pin on top of navigation path
* fix draw ordering
fix draw ordering
* add todo
* rename to feature
* draft
* clean up
* testing
* testing 2
* Revert "testing 2"
This reverts commit fc236aafbc14bbdc5ddb52fb56265302247ddf4b.
* Revert "testing"
This reverts commit 982a508ad701268ebdae910980fd5464454f44a8.
* clean up
* add todo
* show!
* Update selfdrive/ui/qt/maps/map.cc
* lgtm
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com >
old-commit-hash: ba03e9429044e40477c3b1f38737688f5a24f4b4
2023-07-20 00:54:42 -07:00
Dean Lee
ff94bdb79d
ui/networking: call isTetheringEnabled out of the loop ( #29028 )
...
old-commit-hash: 4584e883dcf93079ad958da2042229750a3e260d
2023-07-19 12:28:44 +01:00
Shane Smiskol
372ae37d91
nav: show green path when enabled ( #29020 )
...
* draft
* draft
* clean up
* clean up
* cleaner
* needs to be here to work
* or this works
* works too
* stash
* clean up qdebugs
* revert to master
* reapply changes
add bool
* consistent cmts
* clean up
* can be simpler combined
* clean up/fix
old-commit-hash: 7a673c87ffd8bac16debd306977d00e0db156360
2023-07-18 15:52:59 -07:00