Adeeb Shihadeh
39d98d3d2d
Car cleanup ( #1924 )
...
* cleanup car code
* more pruning
* little more
* less pylint disables
* radar stuff
* fix
* udpate refs
* fix honda bosch
* fix test
old-commit-hash: 892e1162c0bfa0970cbe262452a70745eccb8ba6
2020-07-25 15:07:27 -07:00
Adeeb
9027018368
Update Flake8 config ( #1624 )
...
* update flake8 checks
* add E502
* no whitespace warnings
* fix violations
* no W391
Co-authored-by: Jason Young <jason@comma.ai >
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Willem Melching
a56e2b01f8
Make pylint more strict ( #1626 )
...
* make pylint more strict
* cleanup in progress
* done cleaning up
* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh
9823f1164c
enable flake8 E303: too many blank lines
...
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
be0b43f339
enable flake8 E231: missing whitespace after comma
...
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb
7965569766
Flake8 E22X ( #1607 )
...
* e221
* e225
* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Adeeb
5e857427ba
Enable more flake8 checks ( #1602 )
...
* enable some more flake8 checks
* some more quick ones
* bump opendbc
* e401
* e711 e712
* e115 e116
* e222
* e301
* remove that
* e129
* e701 e702
* e125 e131
* e227
* e306
* e262
* W503
* e713
* e704
* e731
* bump opendbc
* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Adeeb
48340cc8cb
Alerts + Events refactor ( #1466 )
...
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
George Hotz
6fbcde48e5
Using lgtm.com and fixing found alerts ( #1452 )
...
* lgtm in readme, and mac nui fixes
* call super inits in radars
* unused imports, dup lines
* more radars, more unused imports
* pass CP into RadarInterfaceBase
* more fixups
* unused imports
* delete unused lines
* ugh, new unused import
Co-authored-by: George Hotz <geohot@gmail.com >
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
Adeeb
614adb569e
Add steerWarning and steerError to carState ( #1444 )
...
* Add steerWarning and steerError to carState
* fix gm and hyundai
* update refs
old-commit-hash: 337529d5cb7c8f35ed776c96bc2c2f394f766305
2020-05-01 13:13:12 -07:00
Adeeb
15916d03f4
Abstract pcmEnable and pcmDisable events ( #1350 )
...
* don't need individual prev state vars since whole CS is copied
* don't need a whole function since toyota alerts were simplified
* better here
* abstract pcmEnable/pcmDisable events
* the flippening came to NEOS
* delete
* unused
* Revert "the flippening came to NEOS"
This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
old-commit-hash: 8d791d78dd4fbc973eb61ccd9df2ed4cf9bbbcd5
2020-04-10 16:12:58 -07:00
rbiasini
5849f719ef
abstract pedalPressed event ( #1218 )
...
* abstract pedalPressed event
* Fix bug
* update refs
old-commit-hash: fe911bcca8ece66cfeec1eda353fa9bd658cd2bf
2020-03-08 23:35:00 -07:00
rbiasini
8fc38619c0
Abstract gasPressed for all cars ( #1151 )
...
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event
* move lines a bit
* more GM cleanup
* typo
* move espDisabled to carState packet
* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed
* ops, wrong change
* bug
* update cereal
* update ref
old-commit-hash: 9685a5a74318dc168cf4f3da994f983df5db08c0
2020-02-21 18:24:37 -08:00
Adeeb
65a2c62114
Abstract common events + event cleanup ( #1129 )
...
* too many if
* unused
* whitespace
* key
* sefldrive/car/*
* no more gctx
* lower
* start abstracting common events
* all cars
* start small
* all cars
* reverse gear
* wrongCarMode
* wrongGear
* espDisabled
* steerUnvailable
* make linter happy
* c isn't used
* fix esp_disabled in VW
* update ref
* more red
* more cleanup
* fix subaru
* update ref
old-commit-hash: e8cb6ea06a2470dd89a6ad8fd17bd1d1b62034cc
2020-02-20 16:22:25 -08:00
rbiasini
b495a36507
Abstract std params ( #1138 )
...
* get_can_parser and get_cam_can_parser are now standard static methods
old-commit-hash: af39d74a5bad29660e244daf0ed000b1183458bc
2020-02-20 14:06:02 -08:00
rbiasini
5375a08920
get_can_parser and get_cam_can_parser are now standard static methods ( #1136 )
...
old-commit-hash: dc3ea9b08d831203d31294eb37e88a682ae9d79a
2020-02-20 13:08:43 -08:00
Adeeb
0468c42f22
Abstract CarInterface init ( #1131 )
...
* abstract CarInterface init
* unused
* subaru
* gm cleanup
* vw
* typo
* carcontroller
* more cleanup
* fix vw
old-commit-hash: 13f60eae91764a2cdc7405e323381dcf971b11c3
2020-02-19 20:37:07 -08:00
rbiasini
f80b147fac
Ford: have carstate update returning capnp struct directly ( #1113 )
...
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* abstract common instance vars in carstate init and a generic gear parser static method
* abstract gear parser for chrysler
* abstract gm gear parser too
* remove unnecessary random vars
* Chrysler: carstate returns capnp struct directly
* revert ref commit
* test ref
* WIP
* more WIP
* ops, missed this conflict
* ford as well
* not sure why this got deleted
* no need to copy
* remove copy
* remove copy import
* remove unnecessary intermediate variable
* remove obsolete comments
Co-authored-by: Willem Melching <willem.melching@gmail.com >
old-commit-hash: bfa79153b4a6c25ec0e5960776f6f9773a7db7d0
2020-02-17 14:42:41 -08:00
rbiasini
4277ff5355
abstract kf and gear parser as static methods ( #1103 )
...
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* Abstract gear parser static method (#1107 )
* abstract common instance vars in carstate init and a generic gear parser static method
* update opendbc (#1105 )
* abstract gear parser for chrysler
* update opendbc (#1106 )
* abstract gm gear parser too
* remove unnecessary random vars
old-commit-hash: 5c52be27ca8ecef959b1bb7eabcedc0c970d0a8f
2020-02-17 11:53:53 -08:00
Adeeb
cf26bb52b5
Clean up ECU redundancy in selfdrive/car/* ( #963 )
...
* clean up ecu redundancy in selfdrive/car
* clean up gear parsing
old-commit-hash: dafdb79db2f70bc7a4050b4d28dd1886124fb13d
2020-01-18 23:35:10 -08:00
George Hotz
9ef085076b
selfdrive/car
...
old-commit-hash: 71ead9adea44410b281f0ff1a9c07080d0bada47
2020-01-17 10:58:43 -08:00
George Hotz
81dd5a50cf
root commit
...
old-commit-hash: 6c33a5c1f3878e1d8c8a9db600dd44d188f02c87
2020-01-17 10:02:52 -08:00
Vehicle Researcher
fa4b6f33d1
openpilot v0.7.1 release
...
old-commit-hash: 8da8b6135c600ec653c16606239364ab9324fd98
2020-01-15 14:05:04 -08:00
Vehicle Researcher
99b637c7ce
openpilot v0.7 release
...
old-commit-hash: c025b96e8a15640ee4d6e4d513fada6ed101afe5
2019-12-13 13:03:08 -08:00
Vehicle Researcher
89d1d84c70
openpilot v0.6.5 release
...
old-commit-hash: cf80f7a28bc737f50e096b21dea2dd2d6d4a1621
2019-10-09 18:43:53 +00:00
Vehicle Researcher
dfe603c178
openpilot v0.6.4 release
...
old-commit-hash: 61229779e4a38431e934cabe700a93e120dfa468
2019-09-09 23:03:02 +00:00
Vehicle Researcher
3835061760
openpilot v0.6.2 release
...
old-commit-hash: e90c41c576b4630f3039be671ad5f203a865f4c8
2019-07-30 02:27:48 +00:00
Vehicle Researcher
07aa8b1bf3
openpilot v0.6.1 release
...
old-commit-hash: 94053536b4bfa7a8c4760db99063093aae69374d
2019-07-22 19:17:47 +00:00
dekerr
ae1fbf70fa
Refactor default Civic params ( #720 )
...
* move civic params out
* fix variable name
* simplify ford scaling
* cleanup
* remove import dependency
* requested changes
* keep hyundai
old-commit-hash: 4a48ef8dbc51ea2df02b1cf1b54fb514d8120c92
2019-07-08 16:59:32 -07:00
Vehicle Researcher
9abcfabc5f
openpilot v0.6 release
...
old-commit-hash: 8a9ed94f5f33faf282b1918ebe2c37f06cef74e6
2019-06-28 21:11:30 +00:00
Vehicle Researcher
e47a2e6e30
openpilot v0.5.13 release
...
old-commit-hash: dd34ccfe288ebda8e2568cf550994ae890379f45
2019-06-06 04:38:45 +00:00
Vehicle Researcher
0932b367bd
openpilot v0.5.12 release
...
old-commit-hash: 3f9059fea886f1fa3b0c19a62a981d891dcc84eb
2019-05-16 13:20:29 -07:00
Drew Hintz
3ad68e4378
getting ready for Python 3 ( #619 )
...
* tabs to spaces
python 2 to 3: https://portingguide.readthedocs.io/en/latest/syntax.html#tabs-and-spaces
* use the new except syntax
python 2 to 3: https://portingguide.readthedocs.io/en/latest/exceptions.html#the-new-except-syntax
* make relative imports absolute
python 2 to 3: https://portingguide.readthedocs.io/en/latest/imports.html#absolute-imports
* Queue renamed to queue in python 3
Use the six compatibility library to support both python 2 and 3: https://portingguide.readthedocs.io/en/latest/stdlib-reorg.html#renamed-modules
* replace dict.has_key() with in
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#removed-dict-has-key
* make dict views compatible with python 3
python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#dict-views-and-iterators
Where needed, wrapping things that will be a view in python 3 with a list(). For example, if it's accessed with []
Python 3 has no iter*() methods, so just using the values() instead of itervalues() as long as it's not too performance intensive. Note that any minor performance hit of using a list instead of a view will go away when switching to python 3. If it is intensive, we could use the six version.
* Explicitly use truncating division
python 2 to 3: https://portingguide.readthedocs.io/en/latest/numbers.html#division
python 3 treats / as float division. When we want the result to be an integer, use //
* replace map() with list comprehension where a list result is needed.
In python 3, map() returns an iterator.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* replace filter() with list comprehension
In python 3, filter() returns an interatoooooooooooor.
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
* wrap zip() in list() where we need the result to be a list
python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-zip
* clean out some lint
Removes these pylint warnings:
************* Module selfdrive.car.chrysler.chryslercan
W: 15, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 16, 0: Unnecessary semicolon (unnecessary-semicolon)
W: 25, 0: Unnecessary semicolon (unnecessary-semicolon)
************* Module common.dbc
W:101, 0: Anomalous backslash in string: '\?'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
************* Module selfdrive.car.gm.interface
R:102, 6: Redefinition of ret.minEnableSpeed type from float to int (redefined-variable-type)
R:103, 6: Redefinition of ret.mass type from int to float (redefined-variable-type)
************* Module selfdrive.updated
R: 20, 6: Redefinition of r type from int to str (redefined-variable-type)
old-commit-hash: 9dae0bfac4e54ec2b2e488d2b4ead1495c8f56d8
2019-05-02 11:08:59 -07:00
Vehicle Researcher
83dfc3ca1f
openpilot v0.5.11 release
...
old-commit-hash: 2f92d577f995ff6ae1945ef6b89df3cb69b92999
2019-04-23 01:41:19 +00:00
Nigel Armstrong
2f228d6f5a
Add pylint to travis-ci ( #595 )
...
* Add pylint to travis-ci
* Change travis build order
* Fix missing pylint
* Add pylint to dockerfile
* Test with fixed linter for chrysler changes
* Fix linter issues in OP
* fixed linter on ford
* Fix Riccardo's comments
old-commit-hash: 76dfb135ca049ddd3ceadb6ce8b024c9c8193c2a
2019-04-12 23:12:34 -07:00
Vehicle Researcher
30f7a33535
openpilot v0.5.10 release
...
old-commit-hash: f74a201edcce4a81ae9e1ba388039a982a68f2fa
2019-03-26 01:09:18 -07:00
Vehicle Researcher
2cc4edde68
openpilot v0.5.9 release
...
old-commit-hash: 0207a970400ee28d3e366f2e8f5c551281accf02
2019-02-20 01:39:02 +00:00
Vehicle Researcher
f8ce921247
openpilot v0.5.7 release
...
old-commit-hash: 210db686bb89f8696aa040e6e16de65424b808c9
2018-12-10 14:13:12 -08:00
Vehicle Researcher
b73d457d20
openpilot v0.5.2 release
...
old-commit-hash: 0129a8a4ff8da5314e8e4d4d3336e89667ff6d54
2018-08-19 20:36:37 -07:00
Vehicle Researcher
86d4bbcba6
openpilot v0.5.1 release
...
old-commit-hash: 6f3d10a4c475c4c4509f0b370805419acd13912d
2018-08-02 02:58:52 +00:00
Vehicle Researcher
e41a943dd0
openpilot v0.5 release
...
old-commit-hash: de33bc46452b1046387ee2b3a03191b2c71135fb
2018-07-12 18:52:06 -07:00
dekerr
df4cfe1580
Small cleanup ( #275 )
...
* mass unit conversions
* flat/explicit conditions
* fix typos
* remove hardcode
* Update README.md
* Update carcontroller.py
old-commit-hash: ce67c75f1f8cd65e86070d1ac9f6fe8cca1379cc
2018-06-28 12:33:54 -07:00
Vehicle Researcher
405e7c1b02
openpilot v0.4.7.2 release
...
old-commit-hash: 95509a58cd906827bff61937f6132daa7460122e
2018-06-25 13:48:52 -07:00
Vehicle Researcher
242328f92c
openpilot v0.4.7 release
...
old-commit-hash: ae5cb7a0dab8b1bed9d52292f9b4e8e66a0f8ec9
2018-06-16 20:59:34 -07:00