Commit Graph

177 Commits

Author SHA1 Message Date
Shane Smiskol 40a688983a Honda: use common DBC for CRV H and Accord Diesel (#23743)
* bump

* use Accord DBC for CRVH, Civic Diesel

* bump

* bump opendbc
old-commit-hash: 31228ce5605b6ba231ac09e22fd41946bf80ab36
2022-02-12 16:28:53 -08:00
Adeeb Shihadeh f4a10c631f test car models: fix all panda safety mismatches (#23616)
* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
old-commit-hash: d2735d73fc488f0da98073268eb266d492be37f9
2022-01-29 22:14:27 -08:00
Shane Smiskol 3ec9266de0 Honda: use common DBC for PILOT and others (#23659)
* use common dbc

* bump

* remove from files common
old-commit-hash: a5844363280ec4bafba9eaf046813f16aba6d6ac
2022-01-28 22:26:18 -08:00
vanillagorillaa 455fd17008 Honda: Merge Pilot_2019 into Pilot (#23590)
* merge pilot

* these weren't on the 2019 pilot

* add non essential ECUs
old-commit-hash: 4f827e2e9e62944dd804268780ffd410c3e628c1
2022-01-24 21:19:40 -08:00
Adeeb Shihadeh b0071e3742 Honda: use Pilot DBC for Ridgeline
old-commit-hash: 5b2d2f31ef1f63cbe778e6542104128b9c8bfad8
2022-01-19 22:11:21 -08:00
Ewout ter Hoeven f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
Adeeb Shihadeh 189c41a614 Merge 2021 Accords into 2018 Accords (#23174)
* Merge 2021 Accords into 2018 Accords

* last of them
old-commit-hash: 1638975627d8321c05449f06dc5dca5a66e68094
2021-12-08 14:40:14 -08:00
Willem Melching ca8e47242d 0.8.11-release FW batch (#23167)
* 0.8.11-release FW batch

* those toyota also dont always return esp

* attempt to clean up 2018 & 2021 accord
old-commit-hash: 0ec68a5a09824e7e372b2e8e47b3b41f586c36a5
2021-12-08 14:44:00 +01:00
Adeeb Shihadeh 87f707ec87 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
old-commit-hash: 0283942a9538d121b783dba89be2c2d4e7fd40f8
2021-12-05 13:51:33 -08:00
Chris McCammon 03056baec1 Honda Pilot fw (#23119)
old-commit-hash: 9e51befe182fd7c48941f1efa907d064bffddf38
2021-12-03 16:11:15 -08:00
Willem Melching b8ab21bd64 add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
old-commit-hash: e6180738fdc4c55ba913905e6591de5435966eb1
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh 89eb02fee4 Bring back Accord 2021 + 2021 Hybrid (#23021)
Co-authored-by: Chris Souers <csouers@gmail.com>
old-commit-hash: 239c7c1d4e7c5b854490bc44f6f4dc252b331cf3
2021-11-23 23:19:11 -08:00
Brett Sanderson a42e858c99 Honda: rename HONDA_NIDEC_ALT_MAIN to HONDA_PARAM_NIDEC_ALT_SCM_MESSAGES (#22970)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8b25551c7fe61ab5e4a7842f72e6474d517b9e04
2021-11-18 14:52:37 -08:00
Adeeb Shihadeh 1792ebea6d Honda: handle ACC state consistent with ISO 15622:2018 (#22958)
old-commit-hash: 14651866c2ec1dded8fae7ae3c9109acf2e79985
2021-11-17 17:30:50 -08:00
Willem Melching 1bcba44589 Batch of ECU FW from cars that fuzzy fingerprinted (#22883)
* honda

* hyundai

* toyota

* VW
old-commit-hash: 8a8cee5e544d4df6e5db28198207422d1aa5df6f
2021-11-12 16:31:29 +01:00
Adeeb Shihadeh c2a413a2f4 Remove remaining Toyota + Honda CAN fingerprints (#22827)
old-commit-hash: 8933859e35c4fbeae0cb9d35eb6ca002e792c616
2021-11-08 14:37:25 -08:00
justinmccaffrey bba8594f74 Add 2021 Honda Passport (#22781)
* update values.py

* add passport to carstate, interface, values

* add a test route with mostly green

* switch to newer route

* update readme

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 28e16c7b8480fb540810216fd09ff711db09ed90
2021-11-04 15:28:04 +01:00
Adeeb Shihadeh 5dddf7515e Remove CAN fingerprints + FW dump (#22647)
* add missing pilot fw

* toyotas

* camry hybrid
old-commit-hash: c85c8fee3c8ba363edbf19aad21e2e2462279f73
2021-10-20 23:12:04 -07:00
Adeeb Shihadeh 477f87a885 remove unused can fingerprints (#22646)
old-commit-hash: 66c20026f6b6bd7056f84060d9436f42c92d3984
2021-10-20 22:32:51 -07:00
Willem Melching 6dea543246 Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
old-commit-hash: 6c29a4c7fb83f9a4935d6003970b6b3442cccfd8
2021-10-07 16:37:02 +02:00
Erich Moraga ccb06114e4 RIDGELINE add missing combinationMeter f/w (#22458)
`elliot sharpe <elliot2345@hotmail.com>`  2021 Ridgeline  DongleID/route 03ba90562055a83e|2021-10-06--08-27-30
old-commit-hash: 519fdc0816f9cdb3698cde75c4082aa01f542f12
2021-10-06 11:56:46 -07:00
Kamil Klimkiewicz e0960b25a3 Add fingerprint for 2019 Honda Civic Hatchback (#22400)
Honda Civic Hatchback 1.0T Elegance (Europe - Poland)
old-commit-hash: 2ab0d52fdad1ed66b9ed77eb3321e272263cb1cf
2021-10-01 15:02:26 -07:00
John Belmonte d9aa78a6bb Car Port: Honda Freed 2020 (#22003)
* car port: Honda Freed

Popular 3-row compact minivan in Japan based on Fit platform.

test route: 2c4292a5cd10536c|2021-08-19--21-32-15

* missing DRIVERS_DOOR_OPEN signal on FREED

* remove redundant long parameters

* additional FW; confirm lack of stop-and-go

* restore gateway ECU to fingerprint

* corrected mass and wheelbase

* add another forwardRadar id
old-commit-hash: edabca193d011f2f8bcfd1bb84c67f265df17f09
2021-09-24 17:11:47 -07:00
Chris McCammon 8329452a22 Add Odyssey fw versions (#22266)
* 6a492387bdfcb4ba

* rerun ci
old-commit-hash: 5f85ea09cddb9eff8b2a8be60460f079d4204cf4
2021-09-17 16:55:34 -07:00
vanillagorillaa 1349e159e7 Honda e Port (#22108)
* Honda e Port

* Test route for Honda e

* remove

* Update README.md

* update values based on logs

* no need for Honda e specific DBC

* fix tests

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: bcb8a11d7fe3868535bb7a66fcb767885c21a5e6
2021-09-07 16:46:44 -07:00
HaraldSchafer 745c8ce522 Speed only ACC control for NIDEC Odyssey (#22156)
* speed only nidec control

* mergeable
old-commit-hash: 449a28b9aa0e9307124961958b26c3a6125de023
2021-09-06 21:11:26 -07:00
Willem Melching 6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcdc9d651fe7169044fb7f52fd70f94ab
2021-09-06 17:29:32 -07:00
HaraldSchafer 0551450068 no more old nidec (#22104)
old-commit-hash: c93f3b10f725ee581884faa764407866fb69733c
2021-09-02 12:05:03 -07:00
Adeeb Shihadeh faee789b90 Update Honda HRV DBC (#22086)
* update honda hrv dbc

* fix release files
old-commit-hash: b4e9ab9343ff245aa3bbb2b05048092349fc0849
2021-08-30 22:14:35 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh b3e3708dbc Revert 2021 Accord (#22063)
* bump panda

* Revert "Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)"

This reverts commit b305a94049606c7a92aebf0e50dc21eda58aa017.

* revert release notes

* bump panda
old-commit-hash: 4be956f8861ecbb521ef9503a3c87b07c9d36721
2021-08-28 21:28:14 -07:00
Adeeb Shihadeh 3c4005ed10 Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)
* Add 2021 Accord 2.0 Touring & Hybrid Touring

- Create the HONDA_BOSCH_EXT set for HONDA_BOSCH cars that utilize the new extended IDs for LKAS_HUD

* Remove ids added to the wrong car

* add comment

* fix undefined signal

* fix tests

Co-authored-by: Chris Souers <csouers@gmail.com>
old-commit-hash: 7e53a42984b38eb45cad8628c225ded3f843d4bb
2021-08-22 12:50:58 -07:00
Adeeb Shihadeh 760cdcd896 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
old-commit-hash: 9e03aa0b92fd846bc643040fa8b8d4ab06ee2855
2021-08-22 00:27:48 -07:00
HaraldSchafer 6fa8d389f3 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
old-commit-hash: a8f3e2b3c26f2b617a1c9c94250b44adce861d04
2021-08-11 18:32:37 -07:00
aniva 2e8f640a52 Add fingerprint for 2018 honda accord sport 2.0L canadian version (#21831)
old-commit-hash: 02da4375e56ee5e5d0506391dbda45de5a49c476
2021-08-02 23:41:10 -07:00
Edward fe34cbc16a Add fingerprint for 2018 honda civic coupe touring (#21795)
* Add honda civic coupe touring 2018

* Fix sort
old-commit-hash: 75bb9a784b784cf6a37529fef081f558582e1840
2021-08-02 11:16:47 +02:00
HaraldSchafer 285d015e5a hard honda max accel in car interface (#21585)
* hard set in car interface, not related to planning

* move to values
old-commit-hash: b8a4adfb2f68e93c63f95935bd2fff2a3a40c20f
2021-07-14 11:06:29 -07:00
Adeeb Shihadeh c3f5996920 remove unused can fingerprints (#21516)
old-commit-hash: b4278baf8c22895a718f0ce7fd4b8f2a6eb8f4d7
2021-07-07 19:59:17 -07:00
Willem Melching 5bc0d28708 Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
old-commit-hash: a8fac002ae8e7c6ab37e9b1a5deb8cfcea2a71ac
2021-06-22 16:28:11 +02:00
Chris McCammon 2f2f4c1891 2021 Honda Ridgeline fw (#21308)
old-commit-hash: ec2524c7ac5773002b445c10360320188464b112
2021-06-16 17:49:32 -07:00
tanmayparikh d123edbece Add 2018 Accord 2.0T Touring transmission FW Vers (#21279)
Co-authored-by: Tanmay Parikh <tparikh@utex.com>
old-commit-hash: 1abb971835459f3c454777ef6190fbf1a582c596
2021-06-15 13:25:28 -07:00
jhlee111 5d7143daee Adding firmware for 2021 Honda CRV Touring (#21211)
* Adding firmware for 2021 Honda CRV Touring

* Update selfdrive/car/honda/values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 4fc48834a42ce96859079de9f69e0f13f773ea4a
2021-06-10 13:07:11 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Willem Melching 6815c68da8 add FW versions
old-commit-hash: 72199e60d38f16076acabfee5fec21553cffefad
2021-06-04 10:37:00 +02:00
Adeeb Shihadeh c40fb813e3 Remove unused CAN fingerprints (#21124)
* toyota

* honda
old-commit-hash: 66d01bd847c60d524fc32eabee859fc3af3a1900
2021-06-03 15:22:40 -07:00
ShaneSmiskol eca70237fd Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: e9e197eb3c5f3714134ebfc104c2e4523fe57177
2021-06-03 13:35:23 -07:00
Erich Moraga 76f49342b4 Add several missing PILOT_2019 f/w (#21097)
* Add several missing PILOT_2019 f/w

`@Abu ali#8344` 2019 Honda Pilot DongleID/route 1631748f51929063|2021-05-30--00-12-43

* Update selfdrive/car/honda/values.py

Ah yeah, got distracted ;-)

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Properly sorted the f/w

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 43fd045a3ecce82bf4bc4f2be9b58f15da87c80f
2021-06-01 15:47:09 -07:00
Adeeb Shihadeh e58a495396 Remove ignored CAN fingerprints (#20994)
* VW is all FW

* fix test

* toyota

* honda

* hyundai

* remove IGNORED_FINGERPRINTS

* toyota
old-commit-hash: e5575a6a4ccf1b43ba652ec7c3009d2389edac63
2021-05-24 13:50:10 -07:00
Willem Melching 41950a9f8a Cleanup HONDA_BOSCH alternate brake signal (#20901)
* Cleanup HONDA_BOSCH alternate brake signal

* always set self.brake_switch

* define in one place

* also defined here

* nesting

* remove CRV Hybrid

* rename brake_switch_ts

* add note about panda safety
old-commit-hash: 245312370f9fd6c36fc197147f6d2037500bc1f3
2021-05-18 14:13:22 +02:00
cfranhonda 918e59c03a 2021 Acura RDX FW versions (#20876)
for @izjamest
old-commit-hash: 2dc4d3584ba30212784cbf150f189be22e1c8ba0
2021-05-12 11:14:56 +02:00