Commit Graph

102 Commits

Author SHA1 Message Date
Adeeb Shihadeh 63bbcd7279 better steer fault names (#23890)
* better steer fault names

* bump cereal
old-commit-hash: 87849f93b165507ad980dbefdcf9c376d5165a18
2022-03-01 22:53:55 -08:00
Adeeb Shihadeh 59c76fc993 resolve misc car TODOs
old-commit-hash: 3c83975ef6ee340bebca362ef1238b4f9018ac8e
2022-02-06 13:50:59 -08:00
Shane Smiskol f443d62f8d CANParser: consistent style for adding signals/checks (#23646)
* consistent style, like toyota

* typo
old-commit-hash: 95caa5f3996dff4ec621d45d3ce6446aff4bd512
2022-01-28 13:20:13 -08:00
Shane Smiskol fadba4b34d CANParser: remove default values (#23642)
* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072f87dbc897ed525b70fb1db9cb04a06.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3645186d7cfcbe8889fed14caf5c51a0a84f14bb
2022-01-27 17:06:18 -08:00
Jason Young b32725c94f Chrysler: remove standstill exception for gas disengage (#23515)
* Chrysler: remove standstill exception for gas disengage

* remove test exception

* bump panda

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 57156c44826e223ffbdfdc200fbb05fa5bc29b24
2022-01-13 16:06:56 -08:00
Adeeb Shihadeh 597535c014 linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
old-commit-hash: 2c94f155840b49639b8bf1ec996d99e268fa9a52
2022-01-13 14:19:38 -08:00
Dean Lee 98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec18b1313148905172ba54bac9f5fdfd
2022-01-10 16:36:51 +01:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
Willem Melching b8ab21bd64 add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
old-commit-hash: e6180738fdc4c55ba913905e6591de5435966eb1
2021-12-03 14:57:53 +01:00
Robbe Derks 58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh 821f1f6cb6 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4ade524df8eb6c56cc8bb09b3772e7c
2021-09-23 17:34:52 -07:00
Adam Boeglin 841091d6d7 Added fingerprint for 2018 Jeep Trackhawk (#21976)
* Added fingerprint for 2018 Jeep Trackhawk

When connecting the Comma3 to my Trackhawk with the latest jvePilot beta, it showed the error "Car Unrecognized: Dashcam Mode".

Obtaining this fingerprint resolved the issue. I don't know if it works with any other model years.

* merge fingerprints

* add missing vals

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b5daca388199b8d295f086a769dcaded471d4252
2021-09-02 15:12:43 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh 691ea8553f deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
old-commit-hash: c72d163e142d90edac5086892c0cd297bdc636fe
2021-07-07 14:59:18 -07:00
Erich Moraga c7eef35429 Add PACIFICA_2020 fingerprint (#21106)
old-commit-hash: 66035ccac9fa2e27248663b3e2a48ac986882074
2021-06-18 15:52:58 -07:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Jason Young 51db9216f2 Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
old-commit-hash: 83ca5a0d29a5befa210f60a60e25029cadf30930
2021-06-02 15:51:54 +02:00
Adeeb Shihadeh d67b194790 chrysler pacifica 2020 fingerprint values
old-commit-hash: c736b7e5bb928b42c22a9acf0fb33ff43ae3c0cc
2021-05-25 14:23:05 -07:00
TheWizard1328 50bd2c14f5 Chrysler Pacifica Fingerprint (#20935)
* Update values.py

* Update values.py

* Update selfdrive/car/chrysler/values.py

* Update values.py

Chrysler Pacifica 2020 fingerprint values added.

* Update values.py

* Update values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: ed0c8a770f99d6b8893c0b90cb6e7ba62effc3cc
2021-05-19 20:02:08 -07:00
ShaneSmiskol 0d45e6885a Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 551091bcfa46e50ef60dac3f3bdff299dba95f35
2021-05-18 17:48:02 -07:00
xps-genesis ba5898bed4 Chrysler BSM info signal (#20694)
* Chrysler BSM info signal

* change to ==1

* add checks to enable bsm

* add fingerprint can id for enableBsm

* gate behind enableBsm

* fix indenatation

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1e473d764a26e923bdba86879f317ab2d6c6d96c
2021-05-04 20:37:39 -07:00
mahlzeit1948 8daa2f45c8 Fix Chrysler Pacifica weight (#20647)
* Update interface.py

2858 is the gross vehicle weight of the hybrid (maximum weight of vehicle + cargo).
Curb weight for the ICE is 1964 kg, for the hybrid it is 2242 kg

* hybrid & update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f6d800a89eede879fbe5637ad4bde5c89327bcfc
2021-04-11 17:18:31 -07:00
vanillagorillaa bacd271a98 2021 Pacifica Hybrid values (#20380)
* 2021 Pacifica Hybrid values

* combine all 2019 PacHy fingerprints into one

* Revert "combine all 2019 PacHy fingerprints into one"

This reverts commit a08ede166608ef2b51ab54f2aebbaf0b550e8db1.

* this one isn't needed, fully contained in one below with the new values
old-commit-hash: 4a5e43cdcc21b8986974fe4baa8bb65a2c9c6849
2021-03-31 00:57:48 -07:00
qadmus 1b8d4b1eef int(round()) on apply_steer for correct comparison after rate limiting (#20425)
old-commit-hash: 0d61d8a4b61287289632ec143f328efdf0c900b0
2021-03-22 13:01:33 +01:00
Drew Hintz 15f51babda include PACIFICA_2020 in late-model behavior (#20399)
These models need to turn off gone_fast_yet bit at -3 to avoid LKAS
faults.

This was likely an accidental omission from PR #1297
To avoid future similar mistakes, we could define a list of these cars
in values.py instead of having the list in multiple places.
old-commit-hash: 01f20229cb893614c8ba669e426c0b0ef614e5e7
2021-03-18 17:29:36 -07:00
vanillagorillaa 0e22a0ee03 2021 pacifica hybrid - additional fingerprint values (#20164)
* 2021 Pacifica Hybrid

* this weird space always gets added

* one more space
old-commit-hash: d1b651af7d8eeb8141f53dd965ff9911d1e09df6
2021-02-25 22:20:23 -08:00
Shane Smiskol 545c046b99 Chrysler: Default fingerprint argument to empty fingerprint (#20146)
old-commit-hash: 700f7db644acbe90cfe0d4943c44feb9a77444f1
2021-02-24 15:41:20 +01:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
vanillagorillaa eb847854ea Chrysler Pacifica: additional 2020 Fingerprint values (#20032)
* Additional 2020 Values

* space
old-commit-hash: 4e99b4c2324074afe3f78c409a3d198dbde3c632
2021-02-07 17:36:34 -08:00
Chris McCammon 4e8130235d 2021 Pacifica Hybrid fingerprint (#19846)
* Merge fingerprint of 2021 Pacifica Hybrid from b66bf349eecf2fda

* add route information

* remove comment
old-commit-hash: 332e01ee91d771e577befd51f95b071eaefe2f7e
2021-01-20 13:48:48 -08:00
vanillagorillaa 47d58291f1 Pacifica Fingerprint Addition (#19750)
* Pacifica: Should fix dashcam mode when remote start

* extra indent
old-commit-hash: f005fd07967e0a3a77d6171d28f4ce8bb9480b60
2021-01-15 13:40:23 -08:00
vanillagorillaa 3af3dc7d76 Chrysler non-ACC Fix - Only allow openpilot in ACC mode (#19581)
* initial try, needs to be tested

* Chrysler: Add to CAN parser

* Chrysler: move cruise state by other dash message

* fix messed up force push

* whitespace

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 937aa829a3a4871e46bddfb42e67c37d38884da6
2021-01-06 12:06:03 -08:00
Willem Melching 4daa6f05cf Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
old-commit-hash: e4cf43c6fcc2f442318df815fdc38fb26a74bdb7
2021-01-06 11:20:44 +01:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
Adeeb Shihadeh dc5a5160d8 Add missing chrysler can parser checks (#1967)
* add missing chrysler can parser checks

* toyota

* toyota cam

* toyota freqs

* chrysler freqs

* doors

* just chrysler for now

* update refs

* update again
old-commit-hash: 1e44b99478e22d89e9b5077aa9e9d6b2aeee37dd
2020-08-02 18:11:42 -07:00
Adeeb Shihadeh 39d98d3d2d Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
old-commit-hash: 892e1162c0bfa0970cbe262452a70745eccb8ba6
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh 370a68623e minor cleanups from LGTM
old-commit-hash: 35a5b057c1ab6d3f77daae6a40d14c9bff28f08b
2020-07-17 23:34:38 -07:00
Adeeb Shihadeh 5913405951 2020 Jeep Grand Cherokee fingerprint
Squashed commit of the following:

commit a1a14048375b4d9c9181b2797621e999738104f8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Jul 13 16:30:54 2020 -0700

    cleanup

commit cf7d4bb162c5018a05b81dd83f124b3ef7826714
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 21:08:59 2020 -0700

    added missed value

commit b91af6eef1b5d966cf4342475a37129ddb46e8de
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 20:52:41 2020 -0700

    Update values.py

commit d3d564fc76db19eae1464d6d938fdc43aa9b6d4e
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Fri Jul 10 00:23:35 2020 -0700

    add support for 2020 Grand Cherokee

old-commit-hash: 1ef3b2095564518cd16190f1f4ed2c2d3030e7a2
2020-07-13 17:00:27 -07:00
VirtuallyChris 498cd9f47a Add missing fp value for Jeep Grand Cherokee 2019
old-commit-hash: 59cbaf88ef2d1477948bbd4f21c6f8398e38be74
2020-06-24 16:11:59 -07:00
Adeeb 9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a0c9fb698c8248a5c28c66c2987ae65
2020-06-03 16:13:34 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Tunder (Chris in RL) 6300cd1a82 add missing 2020 pacifica value (#1551)
old-commit-hash: ee371919c1fd2866a2f76344083cc24dc23a0398
2020-05-22 10:37:05 -07:00
Adeeb 48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
George Hotz 6fbcde48e5 Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00
Adeeb 614adb569e Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
old-commit-hash: 337529d5cb7c8f35ed776c96bc2c2f394f766305
2020-05-01 13:13:12 -07:00