Params: support filtering by ParamKeyType for allKeys (#696)

This commit is contained in:
Jason Wen
2025-03-22 10:29:24 -04:00
committed by GitHub
parent 309304a352
commit c70d3db1e6
3 changed files with 9 additions and 6 deletions
+4 -2
View File
@@ -103,10 +103,12 @@ Params::~Params() {
assert(queue.empty());
}
std::vector<std::string> Params::allKeys() const {
std::vector<std::string> Params::allKeys(ParamKeyType type) const {
std::vector<std::string> ret;
for (auto &p : keys) {
ret.push_back(p.first);
if (type == ALL || (p.second & type)) {
ret.push_back(p.first);
}
}
return ret;
}
+1 -1
View File
@@ -28,7 +28,7 @@ public:
Params(const Params&) = delete;
Params& operator=(const Params&) = delete;
std::vector<std::string> allKeys() const;
std::vector<std::string> allKeys(ParamKeyType type = ALL) const;
bool checkKey(const std::string &key);
ParamKeyType getKeyType(const std::string &key);
inline std::string getParamPath(const std::string &key = {}) {
+4 -3
View File
@@ -11,6 +11,7 @@ cdef extern from "common/params.h":
CLEAR_ON_ONROAD_TRANSITION
CLEAR_ON_OFFROAD_TRANSITION
DEVELOPMENT_ONLY
BACKUP
ALL
cdef cppclass c_Params "Params":
@@ -25,7 +26,7 @@ cdef extern from "common/params.h":
bool checkKey(string) nogil
string getParamPath(string) nogil
void clearAll(ParamKeyType)
vector[string] allKeys()
vector[string] allKeys(ParamKeyType)
def ensure_bytes(v):
@@ -119,5 +120,5 @@ cdef class Params:
cdef string key_bytes = ensure_bytes(key)
return self.p.getParamPath(key_bytes).decode("utf-8")
def all_keys(self):
return self.p.allKeys()
def all_keys(self, type=ParamKeyType.ALL):
return self.p.allKeys(type)